[GitHub] [hbase] Apache-HBase commented on pull request #4426: HBASE-26933 Remove all ref guide stuff on branch other than master
Apache-HBase commented on PR #4426: URL: https://github.com/apache/hbase/pull/4426#issuecomment-1125699617 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 34s | branch-2 passed | | +1 :green_heart: | compile | 1m 49s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 48s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 57s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 31s | the patch passed | | +1 :green_heart: | compile | 1m 49s | the patch passed | | +1 :green_heart: | javac | 1m 49s | the patch passed | | +1 :green_heart: | shadedjars | 3m 49s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 233m 37s | root in the patch passed. | | | | 257m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4426 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux edd2544b5602 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 62dbae2914 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/2/testReport/ | | Max. process+thread count | 5703 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27013) Introduce read all bytes when using pread for prefetch
[
https://issues.apache.org/jira/browse/HBASE-27013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536438#comment-17536438
]
Tak-Lon (Stephen) Wu commented on HBASE-27013:
--
{quote}I think what you're saying is the following.
Read header for block1
Read block1 and try to read block2's header
Read block2 and try to read block3's header
Repeat
{quote}
Above is correct.
Meanwhile, your observation about HDFS is doing good enough but we still have
the read short logic in pread for HDFS (it should be only for HDFS back to this
pread was introduced) was an interesting point.
{quote}I think, long-term, it makes sense for this configuration to be on by
default, but I am motivated by the expose this configuration property for
additional testing on HDFS while committing this change to try to help the
S3-based prefetching workload. I'm leaning towards putting this in since the
risk is low (given my understanding).
{quote}
Maybe the old days was trying to solve concurrent thread issue, or other short
cut for returning the read from input stream faster. But now, if we ask for
"give me those extra bytes", we're basically comparing a stuck input stream or
a input stream that may re-read from the offset quicker. In short, I agree that
we don't have the answer for HDFS as well, and we may need to revisit and see
if HDFS would be harmed by this feature.
> Introduce read all bytes when using pread for prefetch
> --
>
> Key: HBASE-27013
> URL: https://issues.apache.org/jira/browse/HBASE-27013
> Project: HBase
> Issue Type: Improvement
> Components: HFile, Performance
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.13
>Reporter: Tak-Lon (Stephen) Wu
>Assignee: Tak-Lon (Stephen) Wu
>Priority: Major
>
> h2. Problem statement
> When prefetching HFiles from blob storage like S3 and use it with the storage
> implementation like S3A, we found there is a logical issue in HBase pread
> that causes the reading of the remote HFile aborts the input stream multiple
> times. This aborted stream and reopen slow down the reads and trigger many
> aborted bytes and waste time in recreating the connection especially when SSL
> is enabled.
> h2. ROOT CAUSE
> The root cause of above issue was due to
> [BlockIOUtils#preadWithExtra|https://github.com/apache/hbase/blob/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443/hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/BlockIOUtils.java#L214-L257]
> is reading an input stream that does not guarrentee to return the data block
> and the next block header as an option data to be cached.
> In the case of the input stream read short and when the input stream read
> passed the length of the necessary data block with few more bytes within the
> size of next block header, the
> [BlockIOUtils#preadWithExtra|https://github.com/apache/hbase/blob/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443/hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/BlockIOUtils.java#L214-L257]
> returns to the caller without a cached the next block header. As a result,
> before HBase tries to read the next block,
> [HFileBlock#readBlockDataInternal|https://github.com/apache/hbase/blob/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java#L1648-L1664]
> in hbase tries to re-read the next block header from the input stream. Here,
> the reusable input stream has move the current position pointer ahead from
> the offset of the last read data block, when using with the [S3A
> implementation|https://github.com/apache/hadoop/blob/29401c820377d02a992eecde51083cf87f8e57af/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java#L339-L361],
> the input stream is then closed, aborted all the remaining bytes and reopen
> a new input stream at the offset of the last read data block .
> h2. How do we fix it?
> S3A is doing the right job that HBase is telling to move the offset from
> position A back to A - N, so there is not much thing we can do on how S3A
> handle the inputstream. meanwhile in the case of HDFS, this operation is fast.
> Such that, we should fix in HBase level, and try always to read datablock +
> next block header when we're using blob storage to avoid expensive draining
> the bytes in a stream and reopen the socket with the remote storage.
> h2. Draw back and discussion
> * A known drawback is, when we're at the last block, we will read extra
> length that should not be a header, and we still read that into the byte
> buffer array. the size should be always 33 bytes, and it should not a big
> issue in data correctness because the trailer will tell when the last
> datablock should end. And we just waste a 33 byte read and that data is not
> being us
[jira] [Commented] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way
[
https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536432#comment-17536432
]
Hudson commented on HBASE-27021:
Results for branch branch-2
[build #539 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/539/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/539/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/539/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/539/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/539/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> StoreFileInfo should set its initialPath in a consistent way
>
>
> Key: HBASE-27021
> URL: https://issues.apache.org/jira/browse/HBASE-27021
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.6.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3
>
>
> Currently, StoreFileInfo provides overloaded public constructors where the
> related file path can be passed as either a Path or FileStatus instance. This
> can lead to the StoreFileInfo instances related to the same file entry to
> have different representations of the file path, which could create problems
> for functions relying on equality for comparing store files. One example I
> could find is the StoreEngine.refreshStoreFiles method, which list some files
> from the SFT, then compares against a list of files from the SFM to decide
> how it should update SFM internal cache. Here's a sample output from the
> TestHStore.testRefreshStoreFiles:
> ---
> 2022-05-10T15:06:42,831 INFO [Time-limited test]
> regionserver.StoreEngine(399): Refreshing store files for
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine@69d58ac1 files to
> add:
> [file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/6e92c2f5cf1f40f7b8c6b6b34a176fa5,
>
> file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> files to remove:
> [/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> ---
> The above will wrongly add it to SFM's list of compacted files, making a
> valid file potentially eligible for deletion and data loss.
> I think we can avoid that by always converting Path instances passed in
> StoreFileInfo constructors to a FileStatus, for consistently build the
> internal StoreFileInfo path.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125615550 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 42s | master passed | | +1 :green_heart: | compile | 1m 3s | master passed | | +1 :green_heart: | shadedjars | 3m 41s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 44s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 38s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 3m 40s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-common generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 44s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 184m 36s | hbase-server in the patch passed. | | | | 205m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/10/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4414 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d7b4e10ae3df 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3fbf66729d | | Default Java | AdoptOpenJDK-11.0.10+9 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/10/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-common.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/10/testReport/ | | Max. process+thread count | 2550 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/10/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125615012 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 26s | master passed | | +1 :green_heart: | compile | 0m 46s | master passed | | +1 :green_heart: | shadedjars | 3m 48s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 8s | the patch passed | | +1 :green_heart: | compile | 0m 49s | the patch passed | | +1 :green_heart: | javac | 0m 49s | the patch passed | | +1 :green_heart: | shadedjars | 3m 51s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 38s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 184m 24s | hbase-server in the patch passed. | | | | 204m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/10/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4414 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b6980c475d32 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3fbf66729d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/10/testReport/ | | Max. process+thread count | 2143 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/10/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bitterfox commented on pull request #4425: HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated SslContextFactory
bitterfox commented on PR #4425: URL: https://github.com/apache/hbase/pull/4425#issuecomment-1125609642 Thank you for checking this. We need this change in both branches. - branch-2.4 uses hbase-thirdparty.version = 3.5.1 which contains jetty 9.4.41.v20210516 - https://github.com/apache/hbase-thirdparty/blob/c28a235236b9f63ec1d36431e5d1b6c8d4b66d90/pom.xml#L139 - SslContextFacotry is deprecated in jetty 9.4.41 already - https://github.com/eclipse/jetty.project/blob/98607f93c7833e7dc59489b13f3cb0a114fb9f4c/jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslContextFactory.java#L187-L222 - branch-2.5 and master uses hbase-thirdparty.version = 4.1.0 which contains jetty 9.4.44.v20210927 - https://github.com/apache/hbase-thirdparty/blob/c120582f161149e0c8a6b2ec134b5bf22d859a21/pom.xml#L141 - SslContextFactory is deprecated in jetty 9.4.44 as well as - https://github.com/eclipse/jetty.project/blob/8da83308eeca865e495e53ef315a249d63ba9332/jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslContextFactory.java#L193-L223 JFYI, the deprecation was released in jetty 9.4.16 and the breaking change that throws the exception is released in jetty 9.4.23, so branches using jetty 9.4.23+ are affected https://github.com/eclipse/jetty.project/commit/6fb243ff6c96714d997e71064c3e7b99d114d633 https://github.com/eclipse/jetty.project/commit/f4d387e0d616df5ffa33fbbe5c9ad3e0b842657a https://github.com/eclipse/jetty.project/commit/53073ca25704ebd49c7133226053418a5124900f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4426: HBASE-26933 Remove all ref guide stuff on branch other than master
Apache-HBase commented on PR #4426: URL: https://github.com/apache/hbase/pull/4426#issuecomment-1125602451 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 7s | branch-2 passed | | +1 :green_heart: | compile | 6m 22s | branch-2 passed | | +1 :green_heart: | mvnsite | 1m 48s | branch-2 passed | | +1 :green_heart: | spotless | 0m 38s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 7s | the patch passed | | +1 :green_heart: | compile | 6m 20s | the patch passed | | +1 :green_heart: | javac | 6m 20s | the patch passed | | +1 :green_heart: | mvnsite | 1m 49s | the patch passed | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 7m 35s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 35m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4426 | | Optional Tests | dupname asflicense spotless javac hadoopcheck xml compile shellcheck shelldocs mvnsite | | uname | Linux 3adf526078cb 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 62dbae2914 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 141 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/2/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4425: HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated SslContextFactory
Apache9 commented on PR #4425: URL: https://github.com/apache/hbase/pull/4425#issuecomment-1125586002 Which branches should this change be applied? Branch-2.4+ or branch-2.5+? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way
[
https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536389#comment-17536389
]
Hudson commented on HBASE-27021:
Results for branch master
[build #585 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/585/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/585/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/585/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/585/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/585//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> StoreFileInfo should set its initialPath in a consistent way
>
>
> Key: HBASE-27021
> URL: https://issues.apache.org/jira/browse/HBASE-27021
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.6.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3
>
>
> Currently, StoreFileInfo provides overloaded public constructors where the
> related file path can be passed as either a Path or FileStatus instance. This
> can lead to the StoreFileInfo instances related to the same file entry to
> have different representations of the file path, which could create problems
> for functions relying on equality for comparing store files. One example I
> could find is the StoreEngine.refreshStoreFiles method, which list some files
> from the SFT, then compares against a list of files from the SFM to decide
> how it should update SFM internal cache. Here's a sample output from the
> TestHStore.testRefreshStoreFiles:
> ---
> 2022-05-10T15:06:42,831 INFO [Time-limited test]
> regionserver.StoreEngine(399): Refreshing store files for
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine@69d58ac1 files to
> add:
> [file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/6e92c2f5cf1f40f7b8c6b6b34a176fa5,
>
> file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> files to remove:
> [/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> ---
> The above will wrongly add it to SFM's list of compacted files, making a
> valid file potentially eligible for deletion and data loss.
> I think we can avoid that by always converting Path instances passed in
> StoreFileInfo constructors to a FileStatus, for consistently build the
> internal StoreFileInfo path.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase] tomscut commented on pull request #4416: HBASE-27018 Add a tool command list_liveservers
tomscut commented on PR #4416: URL: https://github.com/apache/hbase/pull/4416#issuecomment-1125544145 Thanks @pankaj72981 for your review. I filed a jira HBASE-27026 for discussing the rubocop warn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125540469 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 42s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 30s | master passed | | +1 :green_heart: | compile | 2m 42s | master passed | | +1 :green_heart: | checkstyle | 0m 38s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 39s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 9s | the patch passed | | +1 :green_heart: | compile | 2m 41s | the patch passed | | +1 :green_heart: | javac | 2m 41s | the patch passed | | +1 :green_heart: | checkstyle | 0m 38s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 1s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 52s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 35m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/10/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4414 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 8873a16766c4 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3fbf66729d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 66 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/10/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] tomscut commented on pull request #4423: HBASE-27026 Disable Style/FrozenStringLiteralComment for ruby
tomscut commented on PR #4423: URL: https://github.com/apache/hbase/pull/4423#issuecomment-1125534685 Thanks @apurtell for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] joshelser commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch
joshelser commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125532727 My bad -- Stephen chatted me and we got on the same page. I thought Stephen was going to override the config in PrefetchExecutor/HFileReaderImpl automatically, but he clarified that the expectation was to just do it via hbase-site.xml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] taklwu commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch
taklwu commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125519726 > I think you're missing the addition to update HFileReaderImpl, where we created the Runnable to pass to PrefetchExecutor? do you mean `ReaderContextBuilder`? I may be wrong, but configuration was from the `hfs` or `fs` object that should have `hfile.pread.all.bytes.enabled` flag? or do you mean we should have `HFilePreadReader` has a `ReaderContext` that also turn on this addition? https://github.com/apache/hbase/blob/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ReaderContextBuilder.java#L92-L95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4426: HBASE-26933 Remove all ref guide stuff on branch other than master
Apache-HBase commented on PR #4426: URL: https://github.com/apache/hbase/pull/4426#issuecomment-1125488785 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 25s | branch-2 passed | | +1 :green_heart: | compile | 1m 25s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 28s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 9s | the patch passed | | +1 :green_heart: | compile | 1m 23s | the patch passed | | +1 :green_heart: | javac | 1m 23s | the patch passed | | +1 :green_heart: | shadedjars | 3m 52s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 22s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 337m 26s | root in the patch failed. | | | | 359m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4426 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 05a15d5dfcae 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 930bc5368c | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/1/testReport/ | | Max. process+thread count | 4765 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125458246 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 49s | master passed | | +1 :green_heart: | compile | 1m 3s | master passed | | +1 :green_heart: | shadedjars | 3m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 44s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 33s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | +1 :green_heart: | shadedjars | 3m 38s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-common generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 45s | hbase-common in the patch passed. | | -1 :x: | unit | 187m 44s | hbase-server in the patch failed. | | | | 208m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4414 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4f7ff5374ddf 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3fbf66729d | | Default Java | AdoptOpenJDK-11.0.10+9 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/9/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-common.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/9/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/9/testReport/ | | Max. process+thread count | 2319 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/9/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125453866 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 6s | master passed | | +1 :green_heart: | compile | 0m 47s | master passed | | +1 :green_heart: | shadedjars | 3m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 9s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed | | +1 :green_heart: | javac | 0m 48s | the patch passed | | +1 :green_heart: | shadedjars | 3m 51s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 37s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 183m 23s | hbase-server in the patch passed. | | | | 202m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/9/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4414 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 40088eb50fff 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3fbf66729d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/9/testReport/ | | Max. process+thread count | 2207 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/9/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4426: HBASE-26933 Remove all ref guide stuff on branch other than master
Apache-HBase commented on PR #4426: URL: https://github.com/apache/hbase/pull/4426#issuecomment-1125427834 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 51s | branch-2 passed | | +1 :green_heart: | compile | 1m 49s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 1s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 25s | the patch passed | | +1 :green_heart: | compile | 1m 51s | the patch passed | | +1 :green_heart: | javac | 1m 51s | the patch passed | | +1 :green_heart: | shadedjars | 3m 51s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 57s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 234m 47s | root in the patch passed. | | | | 259m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4426 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cfa0dbc9f1f3 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 930bc5368c | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/1/testReport/ | | Max. process+thread count | 5547 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125329578 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 18s | master passed | | +1 :green_heart: | compile | 2m 48s | master passed | | +1 :green_heart: | checkstyle | 0m 48s | master passed | | +1 :green_heart: | spotless | 0m 43s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 45s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 9s | the patch passed | | +1 :green_heart: | compile | 2m 46s | the patch passed | | +1 :green_heart: | javac | 2m 46s | the patch passed | | +1 :green_heart: | checkstyle | 0m 44s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 34s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 57s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 35m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/9/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4414 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 7087bd68d20a 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3fbf66729d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 65 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4414/9/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25465) Use javac --release option for supporting cross version compilation
[
https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536286#comment-17536286
]
Viraj Jasani commented on HBASE-25465:
--
Got it, let me explore if I can find it, I thought it was HBASE-25864 but then
it's marked resolved without requiring any commits.
cc [~ndimiduk]
> Use javac --release option for supporting cross version compilation
> ---
>
> Key: HBASE-25465
> URL: https://issues.apache.org/jira/browse/HBASE-25465
> Project: HBase
> Issue Type: Improvement
> Components: create-release
>Affects Versions: 3.0.0-alpha-3
>Reporter: Andrew Kyle Purtell
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
> See https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/
> {quote}
> the Java compiler’s --release parameter, which was introduced via JEP 247
> ("Compile for Older Platform Versions"), added to the platform also in JDK 9.
> In contrast to the more widely known pair of --source and --target, the
> --release switch will ensure that only byte code is produced which actually
> will be usable with the specified Java version. For this purpose, the JDK
> contains the signature data for all supported Java versions (stored in the
> $JAVA_HOME/lib/ct.sym file).
> {quote}
> Using one JDK (i.e. Java 11) to build Java 8-and-up and Java 11-and-up
> compatible release artifacts would reduce some sources of accidental
> complexity, assuming the --release parameter actually works as advertised. To
> produce Java 8-and-up compatible artifacts, supply --release=8. To produce
> Java 11-and-up compatible release artifacts, supply --release=11. Maven
> activations based on JDK version and command line defined profiles can
> control what --release parameter, if any, should be passed to the compiler.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Comment Edited] (HBASE-25465) Use javac --release option for supporting cross version compilation
[
https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536275#comment-17536275
]
Viraj Jasani edited comment on HBASE-25465 at 5/12/22 6:12 PM:
---
In order to backport hbase-thirdparty version 4.1.0 to 2.4 release line, we
need to backport HBASE-26523 followed by HBASE-25465 to branch-2.4. Sounds good
[~zhangduo] [~apurtell] ?
I will come up with PRs, maybe I can create separate Jira to backport both of
above to branch-2.4 together.
was (Author: vjasani):
In order to backport this to 2.4 release line, we need to backport HBASE-26523
followed by HBASE-25465 to branch-2.4. Sounds good [~zhangduo] [~apurtell] ?
I will come up with PRs, maybe I can create separate Jira to backport both of
above to branch-2.4 together?
> Use javac --release option for supporting cross version compilation
> ---
>
> Key: HBASE-25465
> URL: https://issues.apache.org/jira/browse/HBASE-25465
> Project: HBase
> Issue Type: Improvement
> Components: create-release
>Affects Versions: 3.0.0-alpha-3
>Reporter: Andrew Kyle Purtell
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
> See https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/
> {quote}
> the Java compiler’s --release parameter, which was introduced via JEP 247
> ("Compile for Older Platform Versions"), added to the platform also in JDK 9.
> In contrast to the more widely known pair of --source and --target, the
> --release switch will ensure that only byte code is produced which actually
> will be usable with the specified Java version. For this purpose, the JDK
> contains the signature data for all supported Java versions (stored in the
> $JAVA_HOME/lib/ct.sym file).
> {quote}
> Using one JDK (i.e. Java 11) to build Java 8-and-up and Java 11-and-up
> compatible release artifacts would reduce some sources of accidental
> complexity, assuming the --release parameter actually works as advertised. To
> produce Java 8-and-up compatible artifacts, supply --release=8. To produce
> Java 11-and-up compatible release artifacts, supply --release=11. Maven
> activations based on JDK version and command line defined profiles can
> control what --release parameter, if any, should be passed to the compiler.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (HBASE-25465) Use javac --release option for supporting cross version compilation
[
https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536282#comment-17536282
]
Andrew Kyle Purtell commented on HBASE-25465:
-
[~vjasani] I believe there is a patch to hbase-http that [~ndimiduk] landed
that is also required in order to apply HBASE-26523 , but I do not recall the
specific issue.
> Use javac --release option for supporting cross version compilation
> ---
>
> Key: HBASE-25465
> URL: https://issues.apache.org/jira/browse/HBASE-25465
> Project: HBase
> Issue Type: Improvement
> Components: create-release
>Affects Versions: 3.0.0-alpha-3
>Reporter: Andrew Kyle Purtell
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
> See https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/
> {quote}
> the Java compiler’s --release parameter, which was introduced via JEP 247
> ("Compile for Older Platform Versions"), added to the platform also in JDK 9.
> In contrast to the more widely known pair of --source and --target, the
> --release switch will ensure that only byte code is produced which actually
> will be usable with the specified Java version. For this purpose, the JDK
> contains the signature data for all supported Java versions (stored in the
> $JAVA_HOME/lib/ct.sym file).
> {quote}
> Using one JDK (i.e. Java 11) to build Java 8-and-up and Java 11-and-up
> compatible release artifacts would reduce some sources of accidental
> complexity, assuming the --release parameter actually works as advertised. To
> produce Java 8-and-up compatible artifacts, supply --release=8. To produce
> Java 11-and-up compatible release artifacts, supply --release=11. Maven
> activations based on JDK version and command line defined profiles can
> control what --release parameter, if any, should be passed to the compiler.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (HBASE-26233) The region replication framework should not be built upon the general replication framework
[
https://issues.apache.org/jira/browse/HBASE-26233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536279#comment-17536279
]
Huaxiang Sun commented on HBASE-26233:
--
Sorry, [~zhangduo], catching up the topic so late! I am starting to review the
feature now.
{quote}And when discussing around HBASE-18070, I recall that we talked about
only replicate the 'info' family. So have we already done this, i.e, only
replicate 'info' family but not other families? Reading the section in ref guide
[http://hbase.apache.org/book.html#async.wal.replication.meta]
I haven't seen any related topics. So my question is do we still need to
implement this feature?
{quote}
Yeah, since it only needs the info family for region locations, it really does
not need to replicate other families. I can create Jira and implement it during
the reviewing process if it has not been in the place, thanks.
> The region replication framework should not be built upon the general
> replication framework
> ---
>
> Key: HBASE-26233
> URL: https://issues.apache.org/jira/browse/HBASE-26233
> Project: HBase
> Issue Type: Umbrella
> Components: read replicas
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-3
>
>
> At least, at the source path, where we track the edits, we should not make
> region replication rely on general replication framework.
> The difficulty here for switching to a table based storage is that, the WAL
> system and replication system highly depend on each other. There will be
> cyclic dependency if we want to store replication peer and queue data in a
> hbase table.
> And after HBASE-18070, even meta wal provider will be integrated together
> with replication system, which makes things more difficult.
> But in general, for region replication, it is not a big deal to lose some
> edits, a flush can fix everything, which means we do not so heavy tracking
> system in the general replication system.
> We should find a more light-weighted way to do region replication.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (HBASE-25465) Use javac --release option for supporting cross version compilation
[
https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536275#comment-17536275
]
Viraj Jasani commented on HBASE-25465:
--
In order to backport this to 2.4 release line, we need to backport HBASE-26523
followed by HBASE-25465 to branch-2.4. Sounds good [~zhangduo] [~apurtell] ?
I will come up with PRs, maybe I can create separate Jira to backport both of
above to branch-2.4 together?
> Use javac --release option for supporting cross version compilation
> ---
>
> Key: HBASE-25465
> URL: https://issues.apache.org/jira/browse/HBASE-25465
> Project: HBase
> Issue Type: Improvement
> Components: create-release
>Affects Versions: 3.0.0-alpha-3
>Reporter: Andrew Kyle Purtell
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
> See https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/
> {quote}
> the Java compiler’s --release parameter, which was introduced via JEP 247
> ("Compile for Older Platform Versions"), added to the platform also in JDK 9.
> In contrast to the more widely known pair of --source and --target, the
> --release switch will ensure that only byte code is produced which actually
> will be usable with the specified Java version. For this purpose, the JDK
> contains the signature data for all supported Java versions (stored in the
> $JAVA_HOME/lib/ct.sym file).
> {quote}
> Using one JDK (i.e. Java 11) to build Java 8-and-up and Java 11-and-up
> compatible release artifacts would reduce some sources of accidental
> complexity, assuming the --release parameter actually works as advertised. To
> produce Java 8-and-up compatible artifacts, supply --release=8. To produce
> Java 11-and-up compatible release artifacts, supply --release=11. Maven
> activations based on JDK version and command line defined profiles can
> control what --release parameter, if any, should be passed to the compiler.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase] Apache-HBase commented on pull request #4426: HBASE-26933 Remove all ref guide stuff on branch other than master
Apache-HBase commented on PR #4426: URL: https://github.com/apache/hbase/pull/4426#issuecomment-1125249774 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 21s | branch-2 passed | | +1 :green_heart: | compile | 6m 27s | branch-2 passed | | +1 :green_heart: | mvnsite | 2m 10s | branch-2 passed | | -1 :x: | spotless | 0m 34s | branch has 63 errors when running spotless:check, run spotless:apply to fix. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 5s | the patch passed | | +1 :green_heart: | compile | 6m 16s | the patch passed | | +1 :green_heart: | javac | 6m 16s | the patch passed | | +1 :green_heart: | mvnsite | 1m 48s | the patch passed | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 7m 42s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | -1 :x: | spotless | 0m 37s | patch has 63 errors when running spotless:check, run spotless:apply to fix. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 36m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4426 | | Optional Tests | dupname asflicense spotless javac hadoopcheck xml compile shellcheck shelldocs mvnsite | | uname | Linux ae056adbadc2 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 930bc5368c | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/1/artifact/yetus-general-check/output/branch-spotless.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/1/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 140 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4426/1/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-27029) When HMaster is stopped, the HMaster local region cache cannot be flushed normally
LiangJun He created HBASE-27029:
---
Summary: When HMaster is stopped, the HMaster local region cache
cannot be flushed normally
Key: HBASE-27029
URL: https://issues.apache.org/jira/browse/HBASE-27029
Project: HBase
Issue Type: Bug
Components: master
Affects Versions: 3.0.0-alpha-3
Reporter: LiangJun He
Assignee: LiangJun He
Fix For: 3.0.0-alpha-3
After HBASE-26951, HMaster can be stoped gracefully. For example, the internal
threads of HMaster can be closed normally, but I found that the local region of
HMaster still cannot be closed normally.
The following is my test error message:
{code:java}
Wed May 11 14:48:56 CST 2022 Terminating master
2022-05-11 14:48:56,382 INFO [shutdown-hook-0] regionserver.ShutdownHook:
Shutdown hook starting; hbase.shutdown.hook=true;
fsShutdownHook=org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@4f4c789f
2022-05-11 14:48:56,382 INFO [shutdown-hook-0] master.HMaster: * STOPPING
master 'emr-header-1.cluster-x,16000,1652240899395' *
2022-05-11 14:48:56,382 INFO [shutdown-hook-0] master.HMaster: STOPPED:
Shutdown hook
..
..
2022-05-11 14:48:57,367 ERROR [KeepAlivePEWorker-41]
assignment.RegionStateStore: FAILED persisting
region=23a692981e91e944d380a8bdf4b50c7e state=OPEN
org.apache.hadoop.hbase.ipc.StoppedRpcClientException: Call to
address=emr-worker-1.cluster-x:16020 failed on local exception:
org.apache.hadoop.hbase.ipc.StoppedRpcClientException
at java.lang.Thread.getStackTrace(Thread.java:1559)
at
org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:130)
at org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:149)
at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:172)
at
org.apache.hadoop.hbase.client.TableOverAsyncTable.put(TableOverAsyncTable.java:214)
at
org.apache.hadoop.hbase.master.assignment.RegionStateStore.updateRegionLocation(RegionStateStore.java:259)
at
org.apache.hadoop.hbase.master.assignment.RegionStateStore.updateRegionLocation(RegionStateStore.java:224)
at
org.apache.hadoop.hbase.master.assignment.AssignmentManager.persistToMeta(AssignmentManager.java:2034)
at
org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.execute(RegionRemoteProcedureBase.java:297)
at
org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.execute(RegionRemoteProcedureBase.java:57)
at
org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:953)
at
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1667)
at
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1414)
at
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78)
at
org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1981)
at Future.get(Unknown Source)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:210)
at
org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:388)
at
org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:92)
at
org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:422)
at
org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:417)
at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:114)
at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:129)
at
org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:443)
at
org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$300(AbstractRpcClient.java:92)
at
org.apache.hadoop.hbase.ipc.AbstractRpcClient$RpcChannelImplementation.callMethod(AbstractRpcClient.java:614)
at
org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$Stub.mutate(ClientProtos.java:46147)
at
org.apache.hadoop.hbase.client.RawAsyncTableImpl.lambda$mutate$0(RawAsyncTableImpl.java:175)
at
org.apache.hadoop.hbase.client.ConnectionUtils.call(ConnectionUtils.java:616)
at
org.apache.hadoop.hbase.client.RawAsyncTableImpl.mutate(RawAsyncTableImpl.java:174)
at
org.apache.hadoop.hbase.client.RawAsyncTableImpl.voidMutate(RawAsyncTableImpl.java:181)
at
org.apache.hadoop.hbase.client.RawAsyncTableImpl.lambda$null$8(RawAsyncTableImpl.java:249)
at
org.apache.hadoop.hbase.client.AsyncSingle
[jira] [Assigned] (HBASE-26933) Remove all ref guide stuff on branch other than master
[ https://issues.apache.org/jira/browse/HBASE-26933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26933: - Assignee: Duo Zhang > Remove all ref guide stuff on branch other than master > -- > > Key: HBASE-26933 > URL: https://issues.apache.org/jira/browse/HBASE-26933 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (HBASE-27024) The User API and Developer API links are broken on hbase.apache.org
[ https://issues.apache.org/jira/browse/HBASE-27024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27024: - Assignee: Duo Zhang > The User API and Developer API links are broken on hbase.apache.org > --- > > Key: HBASE-27024 > URL: https://issues.apache.org/jira/browse/HBASE-27024 > Project: HBase > Issue Type: Sub-task > Components: website >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (HBASE-27024) The User API and Developer API links are broken on hbase.apache.org
[ https://issues.apache.org/jira/browse/HBASE-27024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27024: -- Status: Patch Available (was: Open) > The User API and Developer API links are broken on hbase.apache.org > --- > > Key: HBASE-27024 > URL: https://issues.apache.org/jira/browse/HBASE-27024 > Project: HBase > Issue Type: Sub-task > Components: website >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (HBASE-27028) Add a shell command for flushing master local region
LiangJun He created HBASE-27028: --- Summary: Add a shell command for flushing master local region Key: HBASE-27028 URL: https://issues.apache.org/jira/browse/HBASE-27028 Project: HBase Issue Type: New Feature Components: shell Affects Versions: 3.0.0-alpha-3 Reporter: LiangJun He Fix For: 3.0.0-alpha-3 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (HBASE-27028) Add a shell command for flushing master local region
[ https://issues.apache.org/jira/browse/HBASE-27028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LiangJun He reassigned HBASE-27028: --- Assignee: LiangJun He > Add a shell command for flushing master local region > - > > Key: HBASE-27028 > URL: https://issues.apache.org/jira/browse/HBASE-27028 > Project: HBase > Issue Type: New Feature > Components: shell >Affects Versions: 3.0.0-alpha-3 >Reporter: LiangJun He >Assignee: LiangJun He >Priority: Minor > Fix For: 3.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-25192) s390x support for HBase CI
[ https://issues.apache.org/jira/browse/HBASE-25192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536157#comment-17536157 ] Vasudha Nikam commented on HBASE-25192: --- As s390x nodes are now added to Apache Jenkins CI ( https://issues.apache.org/jira/browse/INFRA-21433 ) , will it be possible to enable s390x jobs in hbase ci? [~zhangduo] Please let us know if there's anything else required from our end. > s390x support for HBase CI > -- > > Key: HBASE-25192 > URL: https://issues.apache.org/jira/browse/HBASE-25192 > Project: HBase > Issue Type: Improvement >Reporter: Aditi Jadhav >Priority: Major > > Hi All, > As I understand that currently CI available for HBase ( to validate any code > updates ) is : https://ci-hadoop.apache.org/job/HBase/ and as can be seen > most of the deployment here is on amd64 and ppc64le. > Wanted to know your views/comments/suggestions for extending CI of HBase on > s390x . > 1) If the community will be willing to add - vm's/slaves ( s390x based ) to > their current above CI. > 2) Use an externally hosted jenkins CI - for running HBase build on s390x and > link the results of the build to the above CI. > Please let me know your thoughts. > Regards, > Aditi -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] Apache-HBase commented on pull request #4424: HBASE-27024 The User API and Developer API links are broken on hbase.…
Apache-HBase commented on PR #4424: URL: https://github.com/apache/hbase/pull/4424#issuecomment-1124951667 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 21s | master passed | | +1 :green_heart: | compile | 2m 20s | master passed | | +1 :green_heart: | shadedjars | 4m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 55s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 2s | the patch passed | | +1 :green_heart: | compile | 2m 18s | the patch passed | | +1 :green_heart: | javac | 2m 18s | the patch passed | | +1 :green_heart: | shadedjars | 5m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 59s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 358m 48s | root in the patch passed. | | | | 387m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4424/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4424 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a148f241d4ce 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a712f9fa34 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4424/1/testReport/ | | Max. process+thread count | 4791 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4424/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4424: HBASE-27024 The User API and Developer API links are broken on hbase.…
Apache-HBase commented on PR #4424: URL: https://github.com/apache/hbase/pull/4424#issuecomment-1124842211 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 50s | master passed | | +1 :green_heart: | compile | 1m 52s | master passed | | +1 :green_heart: | shadedjars | 3m 43s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 56s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 33s | the patch passed | | +1 :green_heart: | compile | 1m 52s | the patch passed | | +1 :green_heart: | javac | 1m 52s | the patch passed | | +1 :green_heart: | shadedjars | 3m 37s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 55s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 243m 3s | root in the patch passed. | | | | 267m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4424/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4424 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4505473940e5 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a712f9fa34 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4424/1/testReport/ | | Max. process+thread count | 4724 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4424/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way
[
https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil resolved HBASE-27021.
--
Resolution: Fixed
Merged into master, branch-2 and branch-2.5. Thanks for reviewing it
[~zhangduo] [~elserj] !
> StoreFileInfo should set its initialPath in a consistent way
>
>
> Key: HBASE-27021
> URL: https://issues.apache.org/jira/browse/HBASE-27021
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.6.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3
>
>
> Currently, StoreFileInfo provides overloaded public constructors where the
> related file path can be passed as either a Path or FileStatus instance. This
> can lead to the StoreFileInfo instances related to the same file entry to
> have different representations of the file path, which could create problems
> for functions relying on equality for comparing store files. One example I
> could find is the StoreEngine.refreshStoreFiles method, which list some files
> from the SFT, then compares against a list of files from the SFM to decide
> how it should update SFM internal cache. Here's a sample output from the
> TestHStore.testRefreshStoreFiles:
> ---
> 2022-05-10T15:06:42,831 INFO [Time-limited test]
> regionserver.StoreEngine(399): Refreshing store files for
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine@69d58ac1 files to
> add:
> [file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/6e92c2f5cf1f40f7b8c6b6b34a176fa5,
>
> file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> files to remove:
> [/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> ---
> The above will wrongly add it to SFM's list of compacted files, making a
> valid file potentially eligible for deletion and data loss.
> I think we can avoid that by always converting Path instances passed in
> StoreFileInfo constructors to a FileStatus, for consistently build the
> internal StoreFileInfo path.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way
[
https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-27021:
-
Fix Version/s: 2.5.0
> StoreFileInfo should set its initialPath in a consistent way
>
>
> Key: HBASE-27021
> URL: https://issues.apache.org/jira/browse/HBASE-27021
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.6.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3
>
>
> Currently, StoreFileInfo provides overloaded public constructors where the
> related file path can be passed as either a Path or FileStatus instance. This
> can lead to the StoreFileInfo instances related to the same file entry to
> have different representations of the file path, which could create problems
> for functions relying on equality for comparing store files. One example I
> could find is the StoreEngine.refreshStoreFiles method, which list some files
> from the SFT, then compares against a list of files from the SFM to decide
> how it should update SFM internal cache. Here's a sample output from the
> TestHStore.testRefreshStoreFiles:
> ---
> 2022-05-10T15:06:42,831 INFO [Time-limited test]
> regionserver.StoreEngine(399): Refreshing store files for
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine@69d58ac1 files to
> add:
> [file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/6e92c2f5cf1f40f7b8c6b6b34a176fa5,
>
> file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> files to remove:
> [/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> ---
> The above will wrongly add it to SFM's list of compacted files, making a
> valid file potentially eligible for deletion and data loss.
> I think we can avoid that by always converting Path instances passed in
> StoreFileInfo constructors to a FileStatus, for consistently build the
> internal StoreFileInfo path.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way
[
https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-27021:
-
Fix Version/s: 2.6.0
> StoreFileInfo should set its initialPath in a consistent way
>
>
> Key: HBASE-27021
> URL: https://issues.apache.org/jira/browse/HBASE-27021
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.6.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-3
>
>
> Currently, StoreFileInfo provides overloaded public constructors where the
> related file path can be passed as either a Path or FileStatus instance. This
> can lead to the StoreFileInfo instances related to the same file entry to
> have different representations of the file path, which could create problems
> for functions relying on equality for comparing store files. One example I
> could find is the StoreEngine.refreshStoreFiles method, which list some files
> from the SFT, then compares against a list of files from the SFM to decide
> how it should update SFM internal cache. Here's a sample output from the
> TestHStore.testRefreshStoreFiles:
> ---
> 2022-05-10T15:06:42,831 INFO [Time-limited test]
> regionserver.StoreEngine(399): Refreshing store files for
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine@69d58ac1 files to
> add:
> [file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/6e92c2f5cf1f40f7b8c6b6b34a176fa5,
>
> file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> files to remove:
> [/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> ---
> The above will wrongly add it to SFM's list of compacted files, making a
> valid file potentially eligible for deletion and data loss.
> I think we can avoid that by always converting Path instances passed in
> StoreFileInfo constructors to a FileStatus, for consistently build the
> internal StoreFileInfo path.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way
[
https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536012#comment-17536012
]
Wellington Chevreuil commented on HBASE-27021:
--
Right, decided to run the spotless fix, then pushed straight to master.
I apologise for this mistake, but frankly, I feel that reverting a bug fix just
because of style issues is quite a drastic move, [~zhangduo]. Pinging the
author for an amending commit would be a much more reasonable and polite
approach.
> StoreFileInfo should set its initialPath in a consistent way
>
>
> Key: HBASE-27021
> URL: https://issues.apache.org/jira/browse/HBASE-27021
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.6.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0-alpha-3
>
>
> Currently, StoreFileInfo provides overloaded public constructors where the
> related file path can be passed as either a Path or FileStatus instance. This
> can lead to the StoreFileInfo instances related to the same file entry to
> have different representations of the file path, which could create problems
> for functions relying on equality for comparing store files. One example I
> could find is the StoreEngine.refreshStoreFiles method, which list some files
> from the SFT, then compares against a list of files from the SFM to decide
> how it should update SFM internal cache. Here's a sample output from the
> TestHStore.testRefreshStoreFiles:
> ---
> 2022-05-10T15:06:42,831 INFO [Time-limited test]
> regionserver.StoreEngine(399): Refreshing store files for
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine@69d58ac1 files to
> add:
> [file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/6e92c2f5cf1f40f7b8c6b6b34a176fa5,
>
> file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> files to remove:
> [/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> ---
> The above will wrongly add it to SFM's list of compacted files, making a
> valid file potentially eligible for deletion and data loss.
> I think we can avoid that by always converting Path instances passed in
> StoreFileInfo constructors to a FileStatus, for consistently build the
> internal StoreFileInfo path.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase] tomscut commented on pull request #4423: HBASE-27026 Disable Style/FrozenStringLiteralComment for ruby
tomscut commented on PR #4423: URL: https://github.com/apache/hbase/pull/4423#issuecomment-1124743189 I sent an email `[DISCUSS] Disable Style/FrozenStringLiteralComment for ruby` for discussing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way
[
https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535990#comment-17535990
]
Wellington Chevreuil commented on HBASE-27021:
--
{quote}
I've already commented on the PR for HBASE-26999 that merging a PR with
spotless:check failures have confused other developers, but here we do th same
thing again...
{quote}
Sorry, missed that comment.
{quote}
So please run 'mvn spotless:apply' to fix the style issue and applying the
patch again.
{quote}
Should I open a new github PR after running this?
> StoreFileInfo should set its initialPath in a consistent way
>
>
> Key: HBASE-27021
> URL: https://issues.apache.org/jira/browse/HBASE-27021
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.6.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0-alpha-3
>
>
> Currently, StoreFileInfo provides overloaded public constructors where the
> related file path can be passed as either a Path or FileStatus instance. This
> can lead to the StoreFileInfo instances related to the same file entry to
> have different representations of the file path, which could create problems
> for functions relying on equality for comparing store files. One example I
> could find is the StoreEngine.refreshStoreFiles method, which list some files
> from the SFT, then compares against a list of files from the SFM to decide
> how it should update SFM internal cache. Here's a sample output from the
> TestHStore.testRefreshStoreFiles:
> ---
> 2022-05-10T15:06:42,831 INFO [Time-limited test]
> regionserver.StoreEngine(399): Refreshing store files for
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine@69d58ac1 files to
> add:
> [file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/6e92c2f5cf1f40f7b8c6b6b34a176fa5,
>
> file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> files to remove:
> [/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> ---
> The above will wrongly add it to SFM's list of compacted files, making a
> valid file potentially eligible for deletion and data loss.
> I think we can avoid that by always converting Path instances passed in
> StoreFileInfo constructors to a FileStatus, for consistently build the
> internal StoreFileInfo path.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way
[
https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535977#comment-17535977
]
Duo Zhang commented on HBASE-27021:
---
I've reverted the commit to master as it breaks the spotless:check.
We added the spotless:check to pre commit is let committers know that they
should run spotless:apply before generating the PR.
I've already commented on the PR for HBASE-26999 that merging a PR with
spotless:check failures have confused other developers, but here we do th same
thing again...
FWIW, even if we do not know the spotless stuff, at least there is a big cross
in the pre commit check and the overall vote is -1, we need to make sure that
it is not introduced by the PR before merging right?
So please run 'mvn spotless:apply' to fix the style issue and applying the
patch again.
Thanks. [~wchevreuil].
> StoreFileInfo should set its initialPath in a consistent way
>
>
> Key: HBASE-27021
> URL: https://issues.apache.org/jira/browse/HBASE-27021
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.6.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0-alpha-3
>
>
> Currently, StoreFileInfo provides overloaded public constructors where the
> related file path can be passed as either a Path or FileStatus instance. This
> can lead to the StoreFileInfo instances related to the same file entry to
> have different representations of the file path, which could create problems
> for functions relying on equality for comparing store files. One example I
> could find is the StoreEngine.refreshStoreFiles method, which list some files
> from the SFT, then compares against a list of files from the SFM to decide
> how it should update SFM internal cache. Here's a sample output from the
> TestHStore.testRefreshStoreFiles:
> ---
> 2022-05-10T15:06:42,831 INFO [Time-limited test]
> regionserver.StoreEngine(399): Refreshing store files for
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine@69d58ac1 files to
> add:
> [file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/6e92c2f5cf1f40f7b8c6b6b34a176fa5,
>
> file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> files to remove:
> [/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> ---
> The above will wrongly add it to SFM's list of compacted files, making a
> valid file potentially eligible for deletion and data loss.
> I think we can avoid that by always converting Path instances passed in
> StoreFileInfo constructors to a FileStatus, for consistently build the
> internal StoreFileInfo path.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way
[
https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535974#comment-17535974
]
Duo Zhang commented on HBASE-27021:
---
Please stop cherry-picking to branch-2.x. [~wchevreuil]
> StoreFileInfo should set its initialPath in a consistent way
>
>
> Key: HBASE-27021
> URL: https://issues.apache.org/jira/browse/HBASE-27021
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.6.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0-alpha-3
>
>
> Currently, StoreFileInfo provides overloaded public constructors where the
> related file path can be passed as either a Path or FileStatus instance. This
> can lead to the StoreFileInfo instances related to the same file entry to
> have different representations of the file path, which could create problems
> for functions relying on equality for comparing store files. One example I
> could find is the StoreEngine.refreshStoreFiles method, which list some files
> from the SFT, then compares against a list of files from the SFM to decide
> how it should update SFM internal cache. Here's a sample output from the
> TestHStore.testRefreshStoreFiles:
> ---
> 2022-05-10T15:06:42,831 INFO [Time-limited test]
> regionserver.StoreEngine(399): Refreshing store files for
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine@69d58ac1 files to
> add:
> [file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/6e92c2f5cf1f40f7b8c6b6b34a176fa5,
>
> file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> files to remove:
> [/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> ---
> The above will wrongly add it to SFM's list of compacted files, making a
> valid file potentially eligible for deletion and data loss.
> I think we can avoid that by always converting Path instances passed in
> StoreFileInfo constructors to a FileStatus, for consistently build the
> internal StoreFileInfo path.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase] Apache-HBase commented on pull request #4422: HBASE-26905 ReplicationPeerManager#checkPeerExists should throw ReplicationPeerNotFoundException if peer doesn't exists
Apache-HBase commented on PR #4422: URL: https://github.com/apache/hbase/pull/4422#issuecomment-1124699055 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 14s | master passed | | +1 :green_heart: | compile | 0m 39s | master passed | | +1 :green_heart: | shadedjars | 3m 43s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 12s | the patch passed | | +1 :green_heart: | compile | 0m 40s | the patch passed | | +1 :green_heart: | javac | 0m 40s | the patch passed | | +1 :green_heart: | shadedjars | 3m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 230m 24s | hbase-server in the patch failed. | | | | 247m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4422/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4422 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fb2af4d4a1ec 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a712f9fa34 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4422/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4422/3/testReport/ | | Max. process+thread count | 2345 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4422/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way
[
https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-27021:
-
Affects Version/s: 2.5.0
2.6.0
> StoreFileInfo should set its initialPath in a consistent way
>
>
> Key: HBASE-27021
> URL: https://issues.apache.org/jira/browse/HBASE-27021
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.6.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
>
> Currently, StoreFileInfo provides overloaded public constructors where the
> related file path can be passed as either a Path or FileStatus instance. This
> can lead to the StoreFileInfo instances related to the same file entry to
> have different representations of the file path, which could create problems
> for functions relying on equality for comparing store files. One example I
> could find is the StoreEngine.refreshStoreFiles method, which list some files
> from the SFT, then compares against a list of files from the SFM to decide
> how it should update SFM internal cache. Here's a sample output from the
> TestHStore.testRefreshStoreFiles:
> ---
> 2022-05-10T15:06:42,831 INFO [Time-limited test]
> regionserver.StoreEngine(399): Refreshing store files for
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine@69d58ac1 files to
> add:
> [file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/6e92c2f5cf1f40f7b8c6b6b34a176fa5,
>
> file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> files to remove:
> [/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> ---
> The above will wrongly add it to SFM's list of compacted files, making a
> valid file potentially eligible for deletion and data loss.
> I think we can avoid that by always converting Path instances passed in
> StoreFileInfo constructors to a FileStatus, for consistently build the
> internal StoreFileInfo path.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way
[
https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-27021:
-
Fix Version/s: 3.0.0-alpha-3
> StoreFileInfo should set its initialPath in a consistent way
>
>
> Key: HBASE-27021
> URL: https://issues.apache.org/jira/browse/HBASE-27021
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.6.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0-alpha-3
>
>
> Currently, StoreFileInfo provides overloaded public constructors where the
> related file path can be passed as either a Path or FileStatus instance. This
> can lead to the StoreFileInfo instances related to the same file entry to
> have different representations of the file path, which could create problems
> for functions relying on equality for comparing store files. One example I
> could find is the StoreEngine.refreshStoreFiles method, which list some files
> from the SFT, then compares against a list of files from the SFM to decide
> how it should update SFM internal cache. Here's a sample output from the
> TestHStore.testRefreshStoreFiles:
> ---
> 2022-05-10T15:06:42,831 INFO [Time-limited test]
> regionserver.StoreEngine(399): Refreshing store files for
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine@69d58ac1 files to
> add:
> [file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/6e92c2f5cf1f40f7b8c6b6b34a176fa5,
>
> file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> files to remove:
> [/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> ---
> The above will wrongly add it to SFM's list of compacted files, making a
> valid file potentially eligible for deletion and data loss.
> I think we can avoid that by always converting Path instances passed in
> StoreFileInfo constructors to a FileStatus, for consistently build the
> internal StoreFileInfo path.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way
[
https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-27021:
-
Affects Version/s: 3.0.0-alpha-2
> StoreFileInfo should set its initialPath in a consistent way
>
>
> Key: HBASE-27021
> URL: https://issues.apache.org/jira/browse/HBASE-27021
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
>
> Currently, StoreFileInfo provides overloaded public constructors where the
> related file path can be passed as either a Path or FileStatus instance. This
> can lead to the StoreFileInfo instances related to the same file entry to
> have different representations of the file path, which could create problems
> for functions relying on equality for comparing store files. One example I
> could find is the StoreEngine.refreshStoreFiles method, which list some files
> from the SFT, then compares against a list of files from the SFM to decide
> how it should update SFM internal cache. Here's a sample output from the
> TestHStore.testRefreshStoreFiles:
> ---
> 2022-05-10T15:06:42,831 INFO [Time-limited test]
> regionserver.StoreEngine(399): Refreshing store files for
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine@69d58ac1 files to
> add:
> [file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/6e92c2f5cf1f40f7b8c6b6b34a176fa5,
>
> file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> files to remove:
> [/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}]
> ---
> The above will wrongly add it to SFM's list of compacted files, making a
> valid file potentially eligible for deletion and data loss.
> I think we can avoid that by always converting Path instances passed in
> StoreFileInfo constructors to a FileStatus, for consistently build the
> internal StoreFileInfo path.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase] wchevreuil merged pull request #4419: HBASE-27021 StoreFileInfo should set its initialPath in a consistent way
wchevreuil merged PR #4419: URL: https://github.com/apache/hbase/pull/4419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4422: HBASE-26905 ReplicationPeerManager#checkPeerExists should throw ReplicationPeerNotFoundException if peer doesn't exists
Apache-HBase commented on PR #4422: URL: https://github.com/apache/hbase/pull/4422#issuecomment-1124650380 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 39s | master passed | | +1 :green_heart: | compile | 0m 43s | master passed | | +1 :green_heart: | shadedjars | 3m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 36s | the patch passed | | +1 :green_heart: | compile | 0m 42s | the patch passed | | +1 :green_heart: | javac | 0m 42s | the patch passed | | +1 :green_heart: | shadedjars | 3m 49s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 179m 34s | hbase-server in the patch passed. | | | | 197m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4422/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4422 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f614a52d4e49 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a712f9fa34 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4422/3/testReport/ | | Max. process+thread count | 2795 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4422/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4425: HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated SslContextFactory
Apache-HBase commented on PR #4425: URL: https://github.com/apache/hbase/pull/4425#issuecomment-1124623515 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 18s | master passed | | +1 :green_heart: | compile | 1m 15s | master passed | | +1 :green_heart: | checkstyle | 0m 43s | master passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 28s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 3s | the patch passed | | +1 :green_heart: | compile | 1m 14s | the patch passed | | +1 :green_heart: | javac | 1m 14s | the patch passed | | +1 :green_heart: | checkstyle | 0m 37s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 0s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotless | 0m 37s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 46s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 31m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4425 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 4ebf08c5c216 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a712f9fa34 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 69 (vs. ulimit of 3) | | modules | C: hbase-http hbase-thrift hbase-rest U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4425: HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated SslContextFactory
Apache-HBase commented on PR #4425: URL: https://github.com/apache/hbase/pull/4425#issuecomment-1124622319 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 13s | master passed | | +1 :green_heart: | compile | 0m 44s | master passed | | +1 :green_heart: | shadedjars | 3m 55s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 44s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 5s | the patch passed | | +1 :green_heart: | compile | 0m 43s | the patch passed | | +1 :green_heart: | javac | 0m 43s | the patch passed | | +1 :green_heart: | shadedjars | 3m 51s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 34s | hbase-http in the patch passed. | | +1 :green_heart: | unit | 6m 27s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 3m 52s | hbase-rest in the patch passed. | | | | 30m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4425 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c8f5f6e9f4e1 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a712f9fa34 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/testReport/ | | Max. process+thread count | 1520 (vs. ulimit of 3) | | modules | C: hbase-http hbase-thrift hbase-rest U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4425: HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated SslContextFactory
Apache-HBase commented on PR #4425: URL: https://github.com/apache/hbase/pull/4425#issuecomment-1124621725 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 21s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 37s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | shadedjars | 3m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 1s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 35s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 3m 39s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 0s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 43s | hbase-http in the patch passed. | | +1 :green_heart: | unit | 6m 49s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 3m 1s | hbase-rest in the patch passed. | | | | 29m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4425 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 28acfb0af08a 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a712f9fa34 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/testReport/ | | Max. process+thread count | 1393 (vs. ulimit of 3) | | modules | C: hbase-http hbase-thrift hbase-rest U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
