[jira] [Commented] (HBASE-28366) Mis-order of SCP and regionServerReport results into region inconsistencies
[
https://issues.apache.org/jira/browse/HBASE-28366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818267#comment-17818267
]
Duo Zhang commented on HBASE-28366:
---
If the new server has already bound to the same port, how could the old server
still be alive and receive a network packet through the same host port?
I think, there could be race that master think a region server is dead, but the
region server is still alive. But after SCP, the region server can not accept
any write requests any more, although it could still serve read requests.
And for regionServerReport, we used to make use of the information to fix
inconsistency but it introduced bunch of new inconsistency so IIRC finally we
choose to only log the inconsistency, instead of fixing it in
regionServerReport, or at least we will not fix it immediately...
> Mis-order of SCP and regionServerReport results into region inconsistencies
> ---
>
> Key: HBASE-28366
> URL: https://issues.apache.org/jira/browse/HBASE-28366
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.4.17, 3.0.0-beta-1, 2.5.7
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
>
> If the regionserver is online but due to network issue, if it's rs ephemeral
> node gets deleted in zookeeper, active master schedules the SCP. However, if
> the regionserver is alive, it can still send regionServerReport to active
> master. In the case where SCP assigns regions to other regionserver that were
> previously hosted on the old regionserver (which is still alive), the old rs
> can continue to sent regionServerReport to active master.
> Eventually this results into region inconsistencies because region is alive
> on two regionservers at the same time (though it's temporary state because
> the rs will be aborted soon). While old regionserver can have zookeeper
> connectivity issues, it can still make rpc calls to active master.
> Logs:
> SCP:
> {code:java}
> 2024-01-29 16:50:33,956 INFO [RegionServerTracker-0]
> assignment.AssignmentManager - Scheduled ServerCrashProcedure pid=9812440 for
> server1-114.xyz,61020,1706541866103 (carryingMeta=false)
> server1-114.xyz,61020,1706541866103/CRASHED/regionCount=364/lock=java.util.concurrent.locks.ReentrantReadWriteLock@5d5fc31[Write
> locks = 1, Read locks = 0], oldState=ONLINE.
> 2024-01-29 16:50:33,956 DEBUG [RegionServerTracker-0]
> procedure2.ProcedureExecutor - Stored pid=9812440,
> state=RUNNABLE:SERVER_CRASH_START; ServerCrashProcedure
> server1-114.xyz,61020,1706541866103, splitWal=true, meta=false
> 2024-01-29 16:50:33,973 INFO [PEWorker-36] procedure.ServerCrashProcedure -
> Splitting WALs pid=9812440, state=RUNNABLE:SERVER_CRASH_SPLIT_LOGS,
> locked=true; ServerCrashProcedure server1-114.xyz,61020,1706541866103,
> splitWal=true, meta=false, isMeta: false
> {code}
> As part of SCP, d743ace9f70d55f55ba1ecc6dc49a5cb was assigned to another
> server:
>
> {code:java}
> 2024-01-29 16:50:42,656 INFO [PEWorker-24] procedure.MasterProcedureScheduler
> - Took xlock for pid=9818494, ppid=9812440,
> state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE;
> TransitRegionStateProcedure
> table=PLATFORM_ENTITY.PLATFORM_IMMUTABLE_ENTITY_DATA,
> region=d743ace9f70d55f55ba1ecc6dc49a5cb, ASSIGN
> 2024-01-29 16:50:43,106 INFO [PEWorker-23] assignment.RegionStateStore -
> pid=9818494 updating hbase:meta row=d743ace9f70d55f55ba1ecc6dc49a5cb,
> regionState=OPEN, repBarrier=12867482, openSeqNum=12867482,
> regionLocation=server1-65.xyz,61020,1706165574050
> {code}
>
> rs abort, after ~5 min:
> {code:java}
> 2024-01-29 16:54:27,235 ERROR [regionserver/server1-114:61020]
> regionserver.HRegionServer - * ABORTING region server
> server1-114.xyz,61020,1706541866103: Unexpected exception handling getData
> *
> org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode
> = ConnectionLoss for /hbase/master
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:102)
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:54)
> at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1229)
> at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.getData(RecoverableZooKeeper.java:414)
> at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.getDataInternal(ZKUtil.java:403)
> at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.getDataAndWatch(ZKUtil.java:367)
> at
> org.apache.hadoop.hbase.zookeeper.ZKNodeTracker.getData(ZKNodeTracker.java:180)
> at
> org.apache.hadoop.hbase.zookeeper.MasterAddressTracker.getMasterAddress(MasterAddressTracker.java:152)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.createRegionServerStatusStub(HRegionServer.java:2892)
> at
> or
Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]
Apache9 commented on code in PR #5683:
URL: https://github.com/apache/hbase/pull/5683#discussion_r1493729696
##
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RateLimiter.java:
##
@@ -135,18 +135,31 @@ protected synchronized long getTimeUnitInMillis() {
/**
* Is there at least one resource available to allow execution?
- * @return true if there is at least one resource available, otherwise false
+ * @return the waitInterval to backoff, or 0 if execution is allowed
*/
- public boolean canExecute() {
+ public long canExecute() {
Review Comment:
Name it getWaitIntervalMs?
##
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RateLimiter.java:
##
@@ -135,18 +135,31 @@ protected synchronized long getTimeUnitInMillis() {
/**
* Is there at least one resource available to allow execution?
- * @return true if there is at least one resource available, otherwise false
+ * @return the waitInterval to backoff, or 0 if execution is allowed
*/
- public boolean canExecute() {
+ public long canExecute() {
return canExecute(1);
}
+ /**
+ * Are there enough available resources to allow execution?
+ * @param amount the number of required resources, a non-negative number
+ * @return the waitInterval to backoff, or 0 if execution is allowed
+ */
+ public synchronized long canExecute(final long amount) {
+assert amount >= 0;
+if (!isAvailable(amount)) {
+ return waitInterval(amount);
+}
+return 0;
+ }
+
/**
* Are there enough available resources to allow execution?
* @param amount the number of required resources, a non-negative number
* @return true if there are enough available resources, otherwise false
*/
- public synchronized boolean canExecute(final long amount) {
+ private synchronized boolean isAvailable(final long amount) {
Review Comment:
Since we already have synchronization in the caller above, do we still need
synchronization here?
For me, I prefer we only add synchronization in the public methods, which
could make it more clear on what we are protecting.
##
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java:
##
@@ -131,7 +131,8 @@ public void close() {
@Override
public long getReadAvailable() {
-return readAvailable;
+// at this point we've grabbed some quota, so we should use at least that
+return Math.max(readAvailable, readConsumed);
Review Comment:
Should we move this Math.max to caller? Theoretically readAvailable could be
negative, the caller should decide how to deal with this.
##
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RateLimiter.java:
##
@@ -135,18 +135,31 @@ protected synchronized long getTimeUnitInMillis() {
/**
* Is there at least one resource available to allow execution?
- * @return true if there is at least one resource available, otherwise false
+ * @return the waitInterval to backoff, or 0 if execution is allowed
*/
- public boolean canExecute() {
+ public long canExecute() {
return canExecute(1);
}
+ /**
+ * Are there enough available resources to allow execution?
+ * @param amount the number of required resources, a non-negative number
+ * @return the waitInterval to backoff, or 0 if execution is allowed
+ */
+ public synchronized long canExecute(final long amount) {
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28378 Bump cryptography from 42.0.0 to 42.0.2 in /dev-support/git-jira-release-audit [hbase]
Apache9 merged PR #5687: URL: https://github.com/apache/hbase/pull/5687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-28378) Bump cryptography from 42.0.0 to 42.0.2 in /dev-support/git-jira-release-audit
Duo Zhang created HBASE-28378: - Summary: Bump cryptography from 42.0.0 to 42.0.2 in /dev-support/git-jira-release-audit Key: HBASE-28378 URL: https://issues.apache.org/jira/browse/HBASE-28378 Project: HBase Issue Type: Task Components: dependabot, scripts, security Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-28378) Bump cryptography from 42.0.0 to 42.0.2 in /dev-support/git-jira-release-audit
[ https://issues.apache.org/jira/browse/HBASE-28378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28378. --- Fix Version/s: 4.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed > Bump cryptography from 42.0.0 to 42.0.2 in /dev-support/git-jira-release-audit > -- > > Key: HBASE-28378 > URL: https://issues.apache.org/jira/browse/HBASE-28378 > Project: HBase > Issue Type: Task > Components: dependabot, scripts, security >Reporter: Duo Zhang >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0-alpha-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28378) Bump cryptography from 42.0.0 to 42.0.2 in /dev-support/git-jira-release-audit
[ https://issues.apache.org/jira/browse/HBASE-28378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28378: --- Labels: pull-request-available (was: ) > Bump cryptography from 42.0.0 to 42.0.2 in /dev-support/git-jira-release-audit > -- > > Key: HBASE-28378 > URL: https://issues.apache.org/jira/browse/HBASE-28378 > Project: HBase > Issue Type: Task > Components: dependabot, scripts, security >Reporter: Duo Zhang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28368 Backport "HBASE-27693 Support for Hadoop's LDAP Authentic… [hbase]
Apache9 commented on PR #5680: URL: https://github.com/apache/hbase/pull/5680#issuecomment-1951108254 The failure for jdk8 hadoop2 is related? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28368 Backport "HBASE-27693 Support for Hadoop's LDAP Authentic… [hbase]
NihalJain commented on PR #5680: URL: https://github.com/apache/hbase/pull/5680#issuecomment-1951156370 Yes I have checked the test failures ate related. There's more changes needed for hadoop2. In hadoop 2 the version of directory services used is different from what we are importing for hadoop 3 and both versions have somewhat incompatible changes. I will submit a fix to make test run for both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]
Apache-HBase commented on PR #5688: URL: https://github.com/apache/hbase/pull/5688#issuecomment-1951244869 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 0s | master passed | | +1 :green_heart: | compile | 1m 52s | master passed | | +1 :green_heart: | shadedjars | 5m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 0s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 42s | the patch passed | | +1 :green_heart: | compile | 1m 53s | the patch passed | | +1 :green_heart: | javac | 1m 53s | the patch passed | | +1 :green_heart: | shadedjars | 5m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 34s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 32s | hbase-client in the patch passed. | | -1 :x: | unit | 218m 25s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 1m 54s | hbase-examples in the patch passed. | | | | 250m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5688 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 59e19cf0ae40 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d9257543a5 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/testReport/ | | Max. process+thread count | 5157 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28321) RpcConnectionRegistry is broken when security is enabled and we use different principal for master and region server
[ https://issues.apache.org/jira/browse/HBASE-28321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28321: --- Labels: pull-request-available (was: ) > RpcConnectionRegistry is broken when security is enabled and we use different > principal for master and region server > > > Key: HBASE-28321 > URL: https://issues.apache.org/jira/browse/HBASE-28321 > Project: HBase > Issue Type: Sub-task > Components: Client, IPC/RPC, security >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Labels: pull-request-available > > After introducing RpcConnectionRegistry, we let master and region server both > implement ClientMetaService. > In our current client architecture, when security is enabled, we rely on the > record in SecurityInfo to determine the server principal to use, > unfortunately there is only one principal can be specified, so if we use > different principal for master and region server, either we can not connect > to master, or we can not connect to region server. > And just changing the server principal field in SecurityInfo to an array can > not solve the problem, as when connecting, we do not know whether the remote > server is a master or region server, so we still can not determine which > principal to use... > Anyway, since this has been in our code base since 2.5.0, it is not a new > problem, so just set it as critical, not a blocker. But we should find out > the solution ASAP. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]
Apache-HBase commented on PR #5688: URL: https://github.com/apache/hbase/pull/5688#issuecomment-1951262986 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 24s | master passed | | +1 :green_heart: | compile | 1m 49s | master passed | | +1 :green_heart: | shadedjars | 4m 59s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 4s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 25s | the patch passed | | +1 :green_heart: | compile | 1m 50s | the patch passed | | +1 :green_heart: | javac | 1m 50s | the patch passed | | +1 :green_heart: | shadedjars | 5m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 5s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 31s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 19s | hbase-client in the patch passed. | | -1 :x: | unit | 231m 1s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 2m 12s | hbase-examples in the patch passed. | | | | 261m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5688 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6b336bcbf1cd 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d9257543a5 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/testReport/ | | Max. process+thread count | 5799 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28376) Column family ns does not exist in region during upgrade to 3.0.0-beta-2
[ https://issues.apache.org/jira/browse/HBASE-28376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818293#comment-17818293 ] Bryan Beaudreault commented on HBASE-28376: --- [~zhangduo] this should probably be a blocker for 3.0. Thoughts? > Column family ns does not exist in region during upgrade to 3.0.0-beta-2 > > > Key: HBASE-28376 > URL: https://issues.apache.org/jira/browse/HBASE-28376 > Project: HBase > Issue Type: Bug >Reporter: Bryan Beaudreault >Priority: Major > > Upgrading from 2.5.x to 3.0.0-alpha-2, migrateNamespaceTable kicks in to copy > data from the namespace table to an "ns" family of the meta table. If you > don't have an "ns" family, the migration fails and the hmaster will crash > loop. You then can't rollback, because the briefly alive upgraded hmaster > created a procedure that can't be deserialized by 2.x (I don't have this log > handy unfortunately). I tried pushing code to create the ns family on > startup, but it doesnt work becuase the migration happens while the hmaster > is still initializing. > So it seems imperative that you create the ns family before upgrading. We > should handle this more gracefully. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]
rmdmattingly commented on code in PR #5683:
URL: https://github.com/apache/hbase/pull/5683#discussion_r1493784706
##
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java:
##
@@ -131,7 +131,8 @@ public void close() {
@Override
public long getReadAvailable() {
-return readAvailable;
+// at this point we've grabbed some quota, so we should use at least that
+return Math.max(readAvailable, readConsumed);
Review Comment:
Yeah, I wonder whether it's worth having a separate method,
`OperationQuota#getMaxResultSize`, which encapsulates this logic and is not
hiding business logic in what appears to be a simple getter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]
bbeaudreault commented on code in PR #5683:
URL: https://github.com/apache/hbase/pull/5683#discussion_r1493785086
##
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java:
##
@@ -131,7 +131,8 @@ public void close() {
@Override
public long getReadAvailable() {
-return readAvailable;
+// at this point we've grabbed some quota, so we should use at least that
+return Math.max(readAvailable, readConsumed);
Review Comment:
I think we should keep this here. I have three reasons:
1. There are only 2 callers to this method, and both would need the
Math.max() added
2. We don't currently expose readConsumed
3. Logically, I think it makes sense to consider readAvailable in this way
for all cases. I could even see it being `Math.max(readAvailable +
readConsumed, readConsumed)`. This is because of the nuanced quota logic in
checkQuota. Details on this one below:
In checkQuota, it iterates all limiters twice. Once to check for available
(or throw throttle exception). Once it gets through all limiters, it loops them
again to grab the quota. This loop can over consume the quota. At this point
we've grabbed the quota and there's no easy way to return it. So we might as
well consider this as "available" for us.
The quotas are complicated because there can be many limiters and checkQuota
is not synchronized. It'd be more accurate to synchronize the entire
checkQuota, but I think it's better for performance to let it be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-28376) Column family ns does not exist in region during upgrade to 3.0.0-beta-2
[ https://issues.apache.org/jira/browse/HBASE-28376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818297#comment-17818297 ] Duo Zhang commented on HBASE-28376: --- It should be a blocker. Will take a look soon, after fixing HBASE-28321 related issues~ > Column family ns does not exist in region during upgrade to 3.0.0-beta-2 > > > Key: HBASE-28376 > URL: https://issues.apache.org/jira/browse/HBASE-28376 > Project: HBase > Issue Type: Bug >Reporter: Bryan Beaudreault >Priority: Major > > Upgrading from 2.5.x to 3.0.0-alpha-2, migrateNamespaceTable kicks in to copy > data from the namespace table to an "ns" family of the meta table. If you > don't have an "ns" family, the migration fails and the hmaster will crash > loop. You then can't rollback, because the briefly alive upgraded hmaster > created a procedure that can't be deserialized by 2.x (I don't have this log > handy unfortunately). I tried pushing code to create the ns family on > startup, but it doesnt work becuase the migration happens while the hmaster > is still initializing. > So it seems imperative that you create the ns family before upgrading. We > should handle this more gracefully. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]
Apache9 commented on code in PR #5683:
URL: https://github.com/apache/hbase/pull/5683#discussion_r1493787434
##
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java:
##
@@ -131,7 +131,8 @@ public void close() {
@Override
public long getReadAvailable() {
-return readAvailable;
+// at this point we've grabbed some quota, so we should use at least that
+return Math.max(readAvailable, readConsumed);
Review Comment:
Then better rename the method, or at least add more comments to describe the
logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28370 Set `updateTs` on default UserQuotaState [hbase]
rmdmattingly commented on PR #5686: URL: https://github.com/apache/hbase/pull/5686#issuecomment-1951356592 Oh, I just forgot the @ClassRule. Pushing a fix now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]
rmdmattingly commented on code in PR #5683:
URL: https://github.com/apache/hbase/pull/5683#discussion_r1493788632
##
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java:
##
@@ -131,7 +131,8 @@ public void close() {
@Override
public long getReadAvailable() {
-return readAvailable;
+// at this point we've grabbed some quota, so we should use at least that
+return Math.max(readAvailable, readConsumed);
Review Comment:
Ah sorry Bryan, I didn't see your comment until I pushed a change. I think
the only difference though would be to remove the readAvailable and
readConsumed getters, and move the getMaxResultSize logic out of the interface.
Do you think that's worth doing, or do you like the changeset in its current
form?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]
bbeaudreault commented on code in PR #5683:
URL: https://github.com/apache/hbase/pull/5683#discussion_r1493789446
##
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java:
##
@@ -131,7 +131,8 @@ public void close() {
@Override
public long getReadAvailable() {
-return readAvailable;
+// at this point we've grabbed some quota, so we should use at least that
+return Math.max(readAvailable, readConsumed);
Review Comment:
Personally I prefer the original name, which has the javadoc:
>/** Returns the number of bytes available to read to avoid exceeding the
quota *
To me "read available" makes sense to be "how much did we grab, plus how
much is left". But I can see that might be subjective. So I don't have a strong
opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-28376) Column family ns does not exist in region during upgrade to 3.0.0-beta-2
[ https://issues.apache.org/jira/browse/HBASE-28376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-28376: -- Affects Version/s: 3.0.0-beta-1 > Column family ns does not exist in region during upgrade to 3.0.0-beta-2 > > > Key: HBASE-28376 > URL: https://issues.apache.org/jira/browse/HBASE-28376 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0-beta-1 >Reporter: Bryan Beaudreault >Priority: Blocker > > Upgrading from 2.5.x to 3.0.0-alpha-2, migrateNamespaceTable kicks in to copy > data from the namespace table to an "ns" family of the meta table. If you > don't have an "ns" family, the migration fails and the hmaster will crash > loop. You then can't rollback, because the briefly alive upgraded hmaster > created a procedure that can't be deserialized by 2.x (I don't have this log > handy unfortunately). I tried pushing code to create the ns family on > startup, but it doesnt work becuase the migration happens while the hmaster > is still initializing. > So it seems imperative that you create the ns family before upgrading. We > should handle this more gracefully. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28376) Column family ns does not exist in region during upgrade to 3.0.0-beta-2
[ https://issues.apache.org/jira/browse/HBASE-28376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-28376: -- Priority: Blocker (was: Major) > Column family ns does not exist in region during upgrade to 3.0.0-beta-2 > > > Key: HBASE-28376 > URL: https://issues.apache.org/jira/browse/HBASE-28376 > Project: HBase > Issue Type: Bug >Reporter: Bryan Beaudreault >Priority: Blocker > > Upgrading from 2.5.x to 3.0.0-alpha-2, migrateNamespaceTable kicks in to copy > data from the namespace table to an "ns" family of the meta table. If you > don't have an "ns" family, the migration fails and the hmaster will crash > loop. You then can't rollback, because the briefly alive upgraded hmaster > created a procedure that can't be deserialized by 2.x (I don't have this log > handy unfortunately). I tried pushing code to create the ns family on > startup, but it doesnt work becuase the migration happens while the hmaster > is still initializing. > So it seems imperative that you create the ns family before upgrading. We > should handle this more gracefully. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]
Apache9 opened a new pull request, #5690: URL: https://github.com/apache/hbase/pull/5690 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28377) Fallback to simple is broken for blocking rpc client
[ https://issues.apache.org/jira/browse/HBASE-28377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28377: --- Labels: pull-request-available (was: ) > Fallback to simple is broken for blocking rpc client > > > Key: HBASE-28377 > URL: https://issues.apache.org/jira/browse/HBASE-28377 > Project: HBase > Issue Type: Bug > Components: IPC/RPC >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Labels: pull-request-available > > Found this when implementing HBASE-28321, we do not have a test for fallback > to simple with blocking rpc client... -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]
Apache9 commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951359301 The fix itself is very simple, just set `saslRpcClient` to `null` when we want to fallback to simple auth at client side. The most important changes are the newly added tests in AbstractTestSecureIPC. Also changed to throw `FallbackDisallowedException` instead of `IOException` in HBaseSaslRpcClient, to align with netty rpc client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]
Apache9 commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951359539 @bbeaudreault We need to fix this before landing HBASE-28321. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28370 Set `updateTs` on default UserQuotaState [hbase]
Apache-HBase commented on PR #5686: URL: https://github.com/apache/hbase/pull/5686#issuecomment-1951370799 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 49s | master passed | | +1 :green_heart: | compile | 2m 24s | master passed | | +1 :green_heart: | checkstyle | 0m 36s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 27s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 40s | the patch passed | | +1 :green_heart: | compile | 2m 26s | the patch passed | | +1 :green_heart: | javac | 2m 26s | the patch passed | | +1 :green_heart: | checkstyle | 0m 35s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 4m 47s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 27m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5686 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 2da859a79b60 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 96a447f0e6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/3/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]
Apache-HBase commented on PR #5683: URL: https://github.com/apache/hbase/pull/5683#issuecomment-1951371002 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 3s | master passed | | +1 :green_heart: | compile | 2m 30s | master passed | | +1 :green_heart: | checkstyle | 0m 39s | master passed | | +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 31s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 46s | the patch passed | | +1 :green_heart: | compile | 2m 25s | the patch passed | | +1 :green_heart: | javac | 2m 25s | the patch passed | | +1 :green_heart: | checkstyle | 0m 36s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 4m 52s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 28m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5683/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5683 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 9361c2d30f40 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 96a447f0e6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 80 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5683/4/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]
bbeaudreault commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951371107 I'm not an expert on sasl. It makes some sense that if we fallback to simple, we don't need a saslRpcClient. But can you explain a little more what the issue was and why this change fixes it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951372283 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 55s | master passed | | +1 :green_heart: | compile | 3m 4s | master passed | | +1 :green_heart: | checkstyle | 0m 54s | master passed | | +1 :green_heart: | spotless | 0m 43s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 17s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 43s | the patch passed | | +1 :green_heart: | compile | 3m 1s | the patch passed | | +1 :green_heart: | javac | 3m 1s | the patch passed | | +1 :green_heart: | checkstyle | 0m 16s | hbase-client: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3) | | +1 :green_heart: | checkstyle | 0m 36s | The patch passed checkstyle in hbase-server | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 4m 46s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 44s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 32s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. | | | | 32m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5690 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux f01c2d64ca0f 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 96a447f0e6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 80 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]
rmdmattingly commented on code in PR #5683:
URL: https://github.com/apache/hbase/pull/5683#discussion_r1493805682
##
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java:
##
@@ -131,7 +131,8 @@ public void close() {
@Override
public long getReadAvailable() {
-return readAvailable;
+// at this point we've grabbed some quota, so we should use at least that
+return Math.max(readAvailable, readConsumed);
Review Comment:
I see both sides. I think it's ok for us to be more specific with the naming
here because, like you said, the current usage scope is small enough for us to
be specific
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28367 Backport "HBASE-27811 Enable cache control for logs endpo… [hbase]
NihalJain merged PR #5679: URL: https://github.com/apache/hbase/pull/5679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28370 Set `updateTs` on default UserQuotaState [hbase]
Apache-HBase commented on PR #5686: URL: https://github.com/apache/hbase/pull/5686#issuecomment-1951425250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 52s | master passed | | +1 :green_heart: | compile | 0m 47s | master passed | | +1 :green_heart: | shadedjars | 5m 46s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 53s | the patch passed | | +1 :green_heart: | compile | 0m 46s | the patch passed | | +1 :green_heart: | javac | 0m 46s | the patch passed | | +1 :green_heart: | shadedjars | 5m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 219m 36s | hbase-server in the patch passed. | | | | 243m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5686 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 33e9dd6475bf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 96a447f0e6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/3/testReport/ | | Max. process+thread count | 4981 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28370 Set `updateTs` on default UserQuotaState [hbase]
Apache-HBase commented on PR #5686: URL: https://github.com/apache/hbase/pull/5686#issuecomment-1951425569 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 15s | master passed | | +1 :green_heart: | compile | 0m 37s | master passed | | +1 :green_heart: | shadedjars | 5m 19s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 17s | the patch passed | | +1 :green_heart: | compile | 0m 36s | the patch passed | | +1 :green_heart: | javac | 0m 36s | the patch passed | | +1 :green_heart: | shadedjars | 5m 17s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 223m 30s | hbase-server in the patch failed. | | | | 244m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5686 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2bcbab7a9329 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 96a447f0e6 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/3/testReport/ | | Max. process+thread count | 5317 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28367) Backport "HBASE-27811 Enable cache control for logs endpoint and set max age as 0" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-28367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28367: --- Fix Version/s: 2.6.0 > Backport "HBASE-27811 Enable cache control for logs endpoint and set max age > as 0" to branch-2 > --- > > Key: HBASE-28367 > URL: https://issues.apache.org/jira/browse/HBASE-28367 > Project: HBase > Issue Type: Improvement >Reporter: Yash Dodeja >Assignee: Nihal Jain >Priority: Minor > Labels: pull-request-available > Fix For: 2.6.0 > > > Not setting the proper header values may cause browsers to store pages within > their respective caches. On public, shared, or any other non-private > computers, a malicious person may search through the browser cache to locate > sensitive information cached during another user's session. > /logs endpoint contains sensitive information that an attacker can exploit. > Any page with sensitive information needs to have the following headers in > response: > Cache-Control: no-cache, no-store, max-age=0 > Pragma: no-cache > Expires: -1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951427028 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 58s | master passed | | +1 :green_heart: | compile | 1m 9s | master passed | | +1 :green_heart: | shadedjars | 5m 13s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 48s | the patch passed | | +1 :green_heart: | compile | 1m 8s | the patch passed | | +1 :green_heart: | javac | 1m 8s | the patch passed | | +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 42s | hbase-client in the patch passed. | | -1 :x: | unit | 224m 30s | hbase-server in the patch failed. | | | | 251m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5690 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b50cb63ec347 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 96a447f0e6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/1/testReport/ | | Max. process+thread count | 4928 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]
Apache-HBase commented on PR #5683: URL: https://github.com/apache/hbase/pull/5683#issuecomment-1951426877 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 25s | master passed | | +1 :green_heart: | compile | 0m 38s | master passed | | +1 :green_heart: | shadedjars | 5m 29s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 20s | the patch passed | | +1 :green_heart: | compile | 0m 38s | the patch passed | | +1 :green_heart: | javac | 0m 38s | the patch passed | | +1 :green_heart: | shadedjars | 5m 24s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 228m 44s | hbase-server in the patch passed. | | | | 250m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5683/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5683 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a8ded6bc9e60 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 96a447f0e6 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5683/4/testReport/ | | Max. process+thread count | 5252 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5683/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28367) Backport "HBASE-27811 Enable cache control for logs endpoint and set max age as 0" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-28367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28367: --- Fix Version/s: 2.7.0 > Backport "HBASE-27811 Enable cache control for logs endpoint and set max age > as 0" to branch-2 > --- > > Key: HBASE-28367 > URL: https://issues.apache.org/jira/browse/HBASE-28367 > Project: HBase > Issue Type: Improvement >Reporter: Yash Dodeja >Assignee: Nihal Jain >Priority: Minor > Labels: pull-request-available > Fix For: 2.6.0, 2.7.0 > > > Not setting the proper header values may cause browsers to store pages within > their respective caches. On public, shared, or any other non-private > computers, a malicious person may search through the browser cache to locate > sensitive information cached during another user's session. > /logs endpoint contains sensitive information that an attacker can exploit. > Any page with sensitive information needs to have the following headers in > response: > Cache-Control: no-cache, no-store, max-age=0 > Pragma: no-cache > Expires: -1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28367) Backport "HBASE-27811 Enable cache control for logs endpoint and set max age as 0" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-28367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28367: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Backport "HBASE-27811 Enable cache control for logs endpoint and set max age > as 0" to branch-2 > --- > > Key: HBASE-28367 > URL: https://issues.apache.org/jira/browse/HBASE-28367 > Project: HBase > Issue Type: Improvement >Reporter: Yash Dodeja >Assignee: Nihal Jain >Priority: Minor > Labels: pull-request-available > Fix For: 2.6.0, 2.7.0 > > > Not setting the proper header values may cause browsers to store pages within > their respective caches. On public, shared, or any other non-private > computers, a malicious person may search through the browser cache to locate > sensitive information cached during another user's session. > /logs endpoint contains sensitive information that an attacker can exploit. > Any page with sensitive information needs to have the following headers in > response: > Cache-Control: no-cache, no-store, max-age=0 > Pragma: no-cache > Expires: -1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]
Apache-HBase commented on PR #5683: URL: https://github.com/apache/hbase/pull/5683#issuecomment-1951427201 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 58s | master passed | | +1 :green_heart: | compile | 0m 49s | master passed | | +1 :green_heart: | shadedjars | 5m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 0m 50s | the patch passed | | +1 :green_heart: | javac | 0m 50s | the patch passed | | +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-server generated 1 new + 95 unchanged - 0 fixed = 96 total (was 95) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 228m 31s | hbase-server in the patch passed. | | | | 252m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5683/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5683 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a31e421702b9 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 96a447f0e6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5683/4/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5683/4/testReport/ | | Max. process+thread count | 5420 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5683/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28367) Backport "HBASE-27811 Enable cache control for logs endpoint and set max age as 0" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-28367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818308#comment-17818308 ] Nihal Jain commented on HBASE-28367: Pushed to branch-2.6 and branch-2. Thanks for the review [~chrajeshbab...@gmail.com]. > Backport "HBASE-27811 Enable cache control for logs endpoint and set max age > as 0" to branch-2 > --- > > Key: HBASE-28367 > URL: https://issues.apache.org/jira/browse/HBASE-28367 > Project: HBase > Issue Type: Improvement >Reporter: Yash Dodeja >Assignee: Nihal Jain >Priority: Minor > Labels: pull-request-available > Fix For: 2.6.0, 2.7.0 > > > Not setting the proper header values may cause browsers to store pages within > their respective caches. On public, shared, or any other non-private > computers, a malicious person may search through the browser cache to locate > sensitive information cached during another user's session. > /logs endpoint contains sensitive information that an attacker can exploit. > Any page with sensitive information needs to have the following headers in > response: > Cache-Control: no-cache, no-store, max-age=0 > Pragma: no-cache > Expires: -1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [HBASE-28142] Region Server Logs getting spammed with warning when st… [hbase]
NihalJain merged PR #5685: URL: https://github.com/apache/hbase/pull/5685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951429766 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 40s | master passed | | +1 :green_heart: | compile | 1m 1s | master passed | | +1 :green_heart: | shadedjars | 5m 6s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 29s | the patch passed | | +1 :green_heart: | compile | 1m 0s | the patch passed | | +1 :green_heart: | javac | 1m 0s | the patch passed | | +1 :green_heart: | shadedjars | 5m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 18s | hbase-client in the patch passed. | | -1 :x: | unit | 238m 6s | hbase-server in the patch failed. | | | | 263m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5690 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux da91e08a466e 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 96a447f0e6 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/1/testReport/ | | Max. process+thread count | 4999 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-28366) Mis-order of SCP and regionServerReport results into region inconsistencies
[
https://issues.apache.org/jira/browse/HBASE-28366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818310#comment-17818310
]
Viraj Jasani edited comment on HBASE-28366 at 2/18/24 8:21 PM:
---
{quote}And for regionServerReport, we used to make use of the information to
fix inconsistency but it introduced bunch of new inconsistency so IIRC finally
we choose to only log the inconsistency, instead of fixing it in
regionServerReport, or at least we will not fix it immediately
{quote}
I see, that makes sense. As part of this Jira, we could still reject serving rs
report from old server, i.e. make that check more stringent by not only relying
on dead server map but also compare with online server map and if we find that
we have new online server with same host + port but with higher startcode, we
reject rs report from old server immediately. As of today, we accept it after
logging a warning, and that results into inconsistencies.
{quote}I think, there could be race that master think a region server is dead,
but the region server is still alive.
{quote}
That is correct for this case. As per the logs, at 16:50:33, master scheduled
SCP due to removal of ephemeral rs znode.
>From master side, the SCP was completed at 16:53:01:
{code:java}
2024-01-29 16:53:01,640 INFO [PEWorker-39] procedure2.ProcedureExecutor -
Finished pid=9812440, state=SUCCESS; ServerCrashProcedure
hbase2a-dnds1-114-ia6.ops.sfdc.net,61020,1706541866103, splitWal=true,
meta=false in 2 mins, 27.679 sec{code}
>From regionserver side, at 16:54:27, we saw the first occurrence of:
{code:java}
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode =
ConnectionLoss for /hbase/master{code}
{quote}But after SCP, the region server can not accept any write requests any
more, although it could still serve read requests.
{quote}
That's because of the WAL splitting done by the master, correct?
was (Author: vjasani):
{quote}And for regionServerReport, we used to make use of the information to
fix inconsistency but it introduced bunch of new inconsistency so IIRC finally
we choose to only log the inconsistency, instead of fixing it in
regionServerReport, or at least we will not fix it immediately
{quote}
I see, that makes sense. As part of this Jira, we could still reject serving rs
report from old server, i.e. make that check more stringent by not only relying
on dead server map but also compare with online server map and if we find that
we have new online server with same host + port but with higher startcode, we
reject rs report from old server immediately. As of today, we accept it after
logging a warning, and that results into inconsistencies.
{quote}I think, there could be race that master think a region server is dead,
but the region server is still alive.
{quote}
That is correct for this case. As per the logs, at 16:50:33, master scheduled
SCP due to removal of ephemeral rs znode.
>From master side, the SCP was completed at 16:53:01:
{code:java}
2024-01-29 16:53:01,640 INFO [PEWorker-39] procedure2.ProcedureExecutor -
Finished pid=9812440, state=SUCCESS; ServerCrashProcedure
hbase2a-dnds1-114-ia6.ops.sfdc.net,61020,1706541866103, splitWal=true,
meta=false in 2 mins, 27.679 sec{code}
>From regionserver side, at 16:54:27, we saw the first occurrence of:
{code:java}
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode =
ConnectionLoss for /hbase/master{code}
{quote}But after SCP, the region server can not accept any write requests any
more, although it could still serve read requests.
{quote}
That's because of the WAL splitting done by the master, correct?
> Mis-order of SCP and regionServerReport results into region inconsistencies
> ---
>
> Key: HBASE-28366
> URL: https://issues.apache.org/jira/browse/HBASE-28366
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.4.17, 3.0.0-beta-1, 2.5.7
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
>
> If the regionserver is online but due to network issue, if it's rs ephemeral
> node gets deleted in zookeeper, active master schedules the SCP. However, if
> the regionserver is alive, it can still send regionServerReport to active
> master. In the case where SCP assigns regions to other regionserver that were
> previously hosted on the old regionserver (which is still alive), the old rs
> can continue to sent regionServerReport to active master.
> Eventually this results into region inconsistencies because region is alive
> on two regionservers at the same time (though it's temporary state because
> the rs will be aborted soon). While old regionserver can have zookeeper
> connectivity issues, it can still make rpc calls to a
[jira] [Commented] (HBASE-28366) Mis-order of SCP and regionServerReport results into region inconsistencies
[
https://issues.apache.org/jira/browse/HBASE-28366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818310#comment-17818310
]
Viraj Jasani commented on HBASE-28366:
--
{quote}And for regionServerReport, we used to make use of the information to
fix inconsistency but it introduced bunch of new inconsistency so IIRC finally
we choose to only log the inconsistency, instead of fixing it in
regionServerReport, or at least we will not fix it immediately
{quote}
I see, that makes sense. As part of this Jira, we could still reject serving rs
report from old server, i.e. make that check more stringent by not only relying
on dead server map but also compare with online server map and if we find that
we have new online server with same host + port but with higher startcode, we
reject rs report from old server immediately. As of today, we accept it after
logging a warning, and that results into inconsistencies.
{quote}I think, there could be race that master think a region server is dead,
but the region server is still alive.
{quote}
That is correct for this case. As per the logs, at 16:50:33, master scheduled
SCP due to removal of ephemeral rs znode.
>From master side, the SCP was completed at 16:53:01:
{code:java}
2024-01-29 16:53:01,640 INFO [PEWorker-39] procedure2.ProcedureExecutor -
Finished pid=9812440, state=SUCCESS; ServerCrashProcedure
hbase2a-dnds1-114-ia6.ops.sfdc.net,61020,1706541866103, splitWal=true,
meta=false in 2 mins, 27.679 sec{code}
>From regionserver side, at 16:54:27, we saw the first occurrence of:
{code:java}
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode =
ConnectionLoss for /hbase/master{code}
{quote}But after SCP, the region server can not accept any write requests any
more, although it could still serve read requests.
{quote}
That's because of the WAL splitting done by the master, correct?
> Mis-order of SCP and regionServerReport results into region inconsistencies
> ---
>
> Key: HBASE-28366
> URL: https://issues.apache.org/jira/browse/HBASE-28366
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.4.17, 3.0.0-beta-1, 2.5.7
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
>
> If the regionserver is online but due to network issue, if it's rs ephemeral
> node gets deleted in zookeeper, active master schedules the SCP. However, if
> the regionserver is alive, it can still send regionServerReport to active
> master. In the case where SCP assigns regions to other regionserver that were
> previously hosted on the old regionserver (which is still alive), the old rs
> can continue to sent regionServerReport to active master.
> Eventually this results into region inconsistencies because region is alive
> on two regionservers at the same time (though it's temporary state because
> the rs will be aborted soon). While old regionserver can have zookeeper
> connectivity issues, it can still make rpc calls to active master.
> Logs:
> SCP:
> {code:java}
> 2024-01-29 16:50:33,956 INFO [RegionServerTracker-0]
> assignment.AssignmentManager - Scheduled ServerCrashProcedure pid=9812440 for
> server1-114.xyz,61020,1706541866103 (carryingMeta=false)
> server1-114.xyz,61020,1706541866103/CRASHED/regionCount=364/lock=java.util.concurrent.locks.ReentrantReadWriteLock@5d5fc31[Write
> locks = 1, Read locks = 0], oldState=ONLINE.
> 2024-01-29 16:50:33,956 DEBUG [RegionServerTracker-0]
> procedure2.ProcedureExecutor - Stored pid=9812440,
> state=RUNNABLE:SERVER_CRASH_START; ServerCrashProcedure
> server1-114.xyz,61020,1706541866103, splitWal=true, meta=false
> 2024-01-29 16:50:33,973 INFO [PEWorker-36] procedure.ServerCrashProcedure -
> Splitting WALs pid=9812440, state=RUNNABLE:SERVER_CRASH_SPLIT_LOGS,
> locked=true; ServerCrashProcedure server1-114.xyz,61020,1706541866103,
> splitWal=true, meta=false, isMeta: false
> {code}
> As part of SCP, d743ace9f70d55f55ba1ecc6dc49a5cb was assigned to another
> server:
>
> {code:java}
> 2024-01-29 16:50:42,656 INFO [PEWorker-24] procedure.MasterProcedureScheduler
> - Took xlock for pid=9818494, ppid=9812440,
> state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE;
> TransitRegionStateProcedure
> table=PLATFORM_ENTITY.PLATFORM_IMMUTABLE_ENTITY_DATA,
> region=d743ace9f70d55f55ba1ecc6dc49a5cb, ASSIGN
> 2024-01-29 16:50:43,106 INFO [PEWorker-23] assignment.RegionStateStore -
> pid=9818494 updating hbase:meta row=d743ace9f70d55f55ba1ecc6dc49a5cb,
> regionState=OPEN, repBarrier=12867482, openSeqNum=12867482,
> regionLocation=server1-65.xyz,61020,1706165574050
> {code}
>
> rs abort, after ~5 min:
> {code:java}
> 2024-01-29 16:54:27,235 ERROR [regionserver/server1-114:61020]
> regionserver.HRegionServer - * ABORTI
[jira] [Assigned] (HBASE-25749) Improved logging when interrupting active RPC handlers holding the region close lock (HBASE-25212 hbase.regionserver.close.wait.abort)
[ https://issues.apache.org/jira/browse/HBASE-25749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-25749: Assignee: Umesh Kumar Kumawat > Improved logging when interrupting active RPC handlers holding the region > close lock (HBASE-25212 hbase.regionserver.close.wait.abort) > -- > > Key: HBASE-25749 > URL: https://issues.apache.org/jira/browse/HBASE-25749 > Project: HBase > Issue Type: Bug > Components: regionserver, rpc >Affects Versions: 3.0.0-alpha-1, 1.7.0, 2.4.0 >Reporter: David Manning >Assignee: Umesh Kumar Kumawat >Priority: Minor > Fix For: 3.0.0-beta-2 > > > HBASE-25212 adds an optional improvement to Close Region, for interrupting > active RPC handlers holding the region close lock. If, after the timeout is > reached, the close lock can still not be acquired, the regionserver may > abort. It would be helpful to add logging for which threads or components are > holding the region close lock at this time. > Depending on the size of regionLockHolders, or use of any stack traces, log > output may need to be truncated. The interrupt code is in > HRegion#interruptRegionOperations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-25749) Improved logging when interrupting active RPC handlers holding the region close lock (HBASE-25212 hbase.regionserver.close.wait.abort)
[ https://issues.apache.org/jira/browse/HBASE-25749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818311#comment-17818311 ] Viraj Jasani commented on HBASE-25749: -- [~umesh9414] granted you with the contributor access, you can assign any jira to yourself going forward. > Improved logging when interrupting active RPC handlers holding the region > close lock (HBASE-25212 hbase.regionserver.close.wait.abort) > -- > > Key: HBASE-25749 > URL: https://issues.apache.org/jira/browse/HBASE-25749 > Project: HBase > Issue Type: Bug > Components: regionserver, rpc >Affects Versions: 3.0.0-alpha-1, 1.7.0, 2.4.0 >Reporter: David Manning >Assignee: Umesh Kumar Kumawat >Priority: Minor > Fix For: 3.0.0-beta-2 > > > HBASE-25212 adds an optional improvement to Close Region, for interrupting > active RPC handlers holding the region close lock. If, after the timeout is > reached, the close lock can still not be acquired, the regionserver may > abort. It would be helpful to add logging for which threads or components are > holding the region close lock at this time. > Depending on the size of regionLockHolders, or use of any stack traces, log > output may need to be truncated. The interrupt code is in > HRegion#interruptRegionOperations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28142) Region Server Logs getting spammed with warning when storefile has no reader
[ https://issues.apache.org/jira/browse/HBASE-28142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28142: --- Summary: Region Server Logs getting spammed with warning when storefile has no reader (was: Getting WARN log "StoreFile has a null Reader" on hbase region server) > Region Server Logs getting spammed with warning when storefile has no reader > > > Key: HBASE-28142 > URL: https://issues.apache.org/jira/browse/HBASE-28142 > Project: HBase > Issue Type: Improvement >Reporter: Nikita Pande >Assignee: Anchal Kejriwal >Priority: Major > Labels: pull-request-available > > Hbase tables which have IS_MOB set as TRUE and table metrics is enabled, > there are warning logs getting generated "StoreFile has a null > Reader on hbase region server. > After setting IS_MOB as false for a table, this logs are not visible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28142) Region Server Logs getting spammed with warning when storefile has no reader
[ https://issues.apache.org/jira/browse/HBASE-28142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28142: --- Fix Version/s: 2.6.0 2.7.0 3.0.0-beta-2 > Region Server Logs getting spammed with warning when storefile has no reader > > > Key: HBASE-28142 > URL: https://issues.apache.org/jira/browse/HBASE-28142 > Project: HBase > Issue Type: Improvement >Reporter: Nikita Pande >Assignee: Anchal Kejriwal >Priority: Major > Labels: pull-request-available > Fix For: 2.6.0, 2.7.0, 3.0.0-beta-2 > > > Hbase tables which have IS_MOB set as TRUE and table metrics is enabled, > there are warning logs getting generated "StoreFile has a null > Reader on hbase region server. > After setting IS_MOB as false for a table, this logs are not visible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-28142) Region Server Logs getting spammed with warning when storefile has no reader
[ https://issues.apache.org/jira/browse/HBASE-28142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain resolved HBASE-28142. Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.6+. Thanks for the PR [~anchalk1]. Thanks for the review [~chrajeshbab...@gmail.com]. Thanks for reporting [~nikitapande]! > Region Server Logs getting spammed with warning when storefile has no reader > > > Key: HBASE-28142 > URL: https://issues.apache.org/jira/browse/HBASE-28142 > Project: HBase > Issue Type: Improvement >Reporter: Nikita Pande >Assignee: Anchal Kejriwal >Priority: Major > Labels: pull-request-available > Fix For: 2.6.0, 2.7.0, 3.0.0-beta-2 > > > Hbase tables which have IS_MOB set as TRUE and table metrics is enabled, > there are warning logs getting generated "StoreFile has a null > Reader on hbase region server. > After setting IS_MOB as false for a table, this logs are not visible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28142) Region Server Logs getting spammed with warning when storefile has no reader
[ https://issues.apache.org/jira/browse/HBASE-28142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28142: --- Priority: Minor (was: Major) > Region Server Logs getting spammed with warning when storefile has no reader > > > Key: HBASE-28142 > URL: https://issues.apache.org/jira/browse/HBASE-28142 > Project: HBase > Issue Type: Improvement >Reporter: Nikita Pande >Assignee: Anchal Kejriwal >Priority: Minor > Labels: pull-request-available > Fix For: 2.6.0, 2.7.0, 3.0.0-beta-2 > > > Hbase tables which have IS_MOB set as TRUE and table metrics is enabled, > there are warning logs getting generated "StoreFile has a null > Reader on hbase region server. > After setting IS_MOB as false for a table, this logs are not visible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-28183) It's impossible to re-enable the quota table if it gets disabled
[ https://issues.apache.org/jira/browse/HBASE-28183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chandra Sekhar K reassigned HBASE-28183: Assignee: Chandra Sekhar K > It's impossible to re-enable the quota table if it gets disabled > > > Key: HBASE-28183 > URL: https://issues.apache.org/jira/browse/HBASE-28183 > Project: HBase > Issue Type: Bug >Reporter: Bryan Beaudreault >Assignee: Chandra Sekhar K >Priority: Major > > HMaster.enableTable tries to read the quota table. If you disable the quota > table, this fails. So then it's impossible to re-enable it. The only solution > I can find is to delete the table at this point, so that it gets recreated at > startup, but this results in losing any quotas you had defined. We should > fix enableTable to not check quotas if the table in question is hbase:quota. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28183) It's impossible to re-enable the quota table if it gets disabled
[ https://issues.apache.org/jira/browse/HBASE-28183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28183: --- Labels: pull-request-available (was: ) > It's impossible to re-enable the quota table if it gets disabled > > > Key: HBASE-28183 > URL: https://issues.apache.org/jira/browse/HBASE-28183 > Project: HBase > Issue Type: Bug >Reporter: Bryan Beaudreault >Assignee: Chandra Sekhar K >Priority: Major > Labels: pull-request-available > > HMaster.enableTable tries to read the quota table. If you disable the quota > table, this fails. So then it's impossible to re-enable it. The only solution > I can find is to delete the table at this point, so that it gets recreated at > startup, but this results in losing any quotas you had defined. We should > fix enableTable to not check quotas if the table in question is hbase:quota. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]
Apache9 commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951621133 Let me fix the failed UT, seems we could also have other types of exceptions when server close the connection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]
Apache-HBase commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-1951632917 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 7s | master passed | | +1 :green_heart: | compile | 2m 27s | master passed | | +1 :green_heart: | checkstyle | 0m 34s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 44s | the patch passed | | +1 :green_heart: | compile | 2m 24s | the patch passed | | +1 :green_heart: | javac | 2m 24s | the patch passed | | +1 :green_heart: | checkstyle | 0m 34s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 4m 58s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 30s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 27m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5691/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5691 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 71d54fb2e0f7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b5175bad9d | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 80 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5691/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951657370 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 54s | master passed | | +1 :green_heart: | compile | 3m 2s | master passed | | +1 :green_heart: | checkstyle | 0m 55s | master passed | | +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 14s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 44s | the patch passed | | +1 :green_heart: | compile | 3m 5s | the patch passed | | +1 :green_heart: | javac | 3m 5s | the patch passed | | +1 :green_heart: | checkstyle | 0m 16s | hbase-client: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3) | | +1 :green_heart: | checkstyle | 0m 35s | The patch passed checkstyle in hbase-server | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 4m 48s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 43s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 3m 5s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 32m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5690 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 955a15cbe32e 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b5175bad9d | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 82 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/2/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]
chrajeshbabu commented on code in PR #5689:
URL: https://github.com/apache/hbase/pull/5689#discussion_r1493987791
##
dev-support/docker/Dockerfile:
##
@@ -110,6 +110,13 @@ SHELL ["/bin/bash", "-o", "pipefail", "-c"]
RUN curl --location --fail --silent --show-error --output
/tmp/adoptopenjdk11.tar.gz "${OPENJDK11_URL}" && \
echo "${OPENJDK11_SHA256} */tmp/adoptopenjdk11.tar.gz" | sha256sum -c -
+FROM base_image AS openjdk17_download_image
+ENV OPENJDK17_URL
'https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.9%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.9_9.tar.gz'
Review Comment:
Since 17.0.9 on top picked it. Thanks for pointing correcting one @Apache9 .
Changed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-27949) [JDK17] Add JDK17 compilation and unit test support to nightly job
[ https://issues.apache.org/jira/browse/HBASE-27949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-27949: --- Labels: pull-request-available (was: ) > [JDK17] Add JDK17 compilation and unit test support to nightly job > -- > > Key: HBASE-27949 > URL: https://issues.apache.org/jira/browse/HBASE-27949 > Project: HBase > Issue Type: Sub-task >Reporter: tianhang tang >Assignee: tianhang tang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]
chrajeshbabu commented on code in PR #5689:
URL: https://github.com/apache/hbase/pull/5689#discussion_r1493988246
##
dev-support/Jenkinsfile:
##
@@ -628,6 +630,118 @@ pipeline {
}
}
}
+
+stage ('yetus jdk17 hadoop3 checks') {
Review Comment:
I can do the same for all the active branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS [hbase]
chrajeshbabu merged PR #5558: URL: https://github.com/apache/hbase/pull/5558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951669151 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5689/2/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951669618 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 1m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5689/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5689 | | Optional Tests | | | uname | Linux 91b2b0ed531f 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 5398b13bab | | Max. process+thread count | 33 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5689/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951668899 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5689/2/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951668916 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5689/2/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28238) rpcservice should perform some important admin operation to priority ADMIN_QOS
[
https://issues.apache.org/jira/browse/HBASE-28238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HBASE-28238:
---
Labels: pull-request-available (was: )
> rpcservice should perform some important admin operation to priority ADMIN_QOS
> --
>
> Key: HBASE-28238
> URL: https://issues.apache.org/jira/browse/HBASE-28238
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.5.0
>Reporter: selina.yan
>Assignee: selina.yan
>Priority: Minor
> Labels: pull-request-available
>
> some important admin operations should be admin priority,like
> compactionSwitch,rollWALWriter,updateConfiguration.
> these operations called by admin should be considered a higher priority
> operation and given to the priority queue, but is currently considered to
> have the same priority as read or write requests. If the handle is occupied,
> the operations cannot be execute successful. For example, in our scenario,
> some abnormal phoenix sql is killed by controlling the amount of data that
> scan can filter with dynamic parameters. Abnormal sql often results in a full
> handle. In this case, the configuration cannot be dynamically modified to
> implement emergency traffic limiting.
> {code:java}
> @Override
> @QosPriority(priority = HConstants.ADMIN_QOS)
> public UpdateConfigurationResponse updateConfiguration(
> RpcController controller, UpdateConfigurationRequest request)
> throws ServiceException {{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951670031 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5689/2/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951670200 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 2m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5689/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5689 | | Optional Tests | | | uname | Linux 43dec7d4d6b3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 5398b13bab | | Max. process+thread count | 39 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5689/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951670687 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 1m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5689/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5689 | | Optional Tests | | | uname | Linux 2ff02fbf27cf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 5398b13bab | | Max. process+thread count | 38 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5689/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951670721 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for patch | | +1 :green_heart: | hadolint | 0m 1s | There were no new hadolint issues. | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | spotless | 0m 36s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 3m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5689/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5689 | | Optional Tests | dupname asflicense spotless hadolint shellcheck shelldocs | | uname | Linux 3228e072d199 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 5398b13bab | | Max. process+thread count | 43 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5689/2/console | | versions | git=2.34.1 maven=3.8.6 shellcheck=0.8.0 hadolint=Haskell Dockerfile Linter 2.10.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-28238) rpcservice should perform some important admin operation to priority ADMIN_QOS
[
https://issues.apache.org/jira/browse/HBASE-28238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818341#comment-17818341
]
Rajeshbabu Chintaguntla edited comment on HBASE-28238 at 2/19/24 4:46 AM:
--
[~selina.yan] Pushed the changes to master and branch-3.Same changes cannot be
applied to branch-2.x branches as the updateconfiugration method still in
RSRpcServices. Could you please raise another PR for branch-2.
was (Author: rajeshbabu):
[~selina.yan] Pushed the changes to master and branch-3. It's directory not
applicable to branch-2.x branches as the updateconfiugration method still in
RSRpcServices. Could you please raise another PR for branch-2.
> rpcservice should perform some important admin operation to priority ADMIN_QOS
> --
>
> Key: HBASE-28238
> URL: https://issues.apache.org/jira/browse/HBASE-28238
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.5.0
>Reporter: selina.yan
>Assignee: selina.yan
>Priority: Minor
> Labels: pull-request-available
>
> some important admin operations should be admin priority,like
> compactionSwitch,rollWALWriter,updateConfiguration.
> these operations called by admin should be considered a higher priority
> operation and given to the priority queue, but is currently considered to
> have the same priority as read or write requests. If the handle is occupied,
> the operations cannot be execute successful. For example, in our scenario,
> some abnormal phoenix sql is killed by controlling the amount of data that
> scan can filter with dynamic parameters. Abnormal sql often results in a full
> handle. In this case, the configuration cannot be dynamically modified to
> implement emergency traffic limiting.
> {code:java}
> @Override
> @QosPriority(priority = HConstants.ADMIN_QOS)
> public UpdateConfigurationResponse updateConfiguration(
> RpcController controller, UpdateConfigurationRequest request)
> throws ServiceException {{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28238) rpcservice should perform some important admin operation to priority ADMIN_QOS
[
https://issues.apache.org/jira/browse/HBASE-28238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818341#comment-17818341
]
Rajeshbabu Chintaguntla commented on HBASE-28238:
-
[~selina.yan] Pushed the changes to master and branch-3. It's directory not
applicable to branch-2.x branches as the updateconfiugration method still in
RSRpcServices. Could you please raise another PR for branch-2.
> rpcservice should perform some important admin operation to priority ADMIN_QOS
> --
>
> Key: HBASE-28238
> URL: https://issues.apache.org/jira/browse/HBASE-28238
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.5.0
>Reporter: selina.yan
>Assignee: selina.yan
>Priority: Minor
> Labels: pull-request-available
>
> some important admin operations should be admin priority,like
> compactionSwitch,rollWALWriter,updateConfiguration.
> these operations called by admin should be considered a higher priority
> operation and given to the priority queue, but is currently considered to
> have the same priority as read or write requests. If the handle is occupied,
> the operations cannot be execute successful. For example, in our scenario,
> some abnormal phoenix sql is killed by controlling the amount of data that
> scan can filter with dynamic parameters. Abnormal sql often results in a full
> handle. In this case, the configuration cannot be dynamically modified to
> implement emergency traffic limiting.
> {code:java}
> @Override
> @QosPriority(priority = HConstants.ADMIN_QOS)
> public UpdateConfigurationResponse updateConfiguration(
> RpcController controller, UpdateConfigurationRequest request)
> throws ServiceException {{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]
Apache-HBase commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-1951833326 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 24s | master passed | | +1 :green_heart: | compile | 0m 48s | master passed | | +1 :green_heart: | shadedjars | 5m 46s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 0s | the patch passed | | +1 :green_heart: | compile | 0m 47s | the patch passed | | +1 :green_heart: | javac | 0m 47s | the patch passed | | +1 :green_heart: | shadedjars | 5m 47s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 223m 30s | hbase-server in the patch failed. | | | | 248m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5691/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5691 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4df2c5f2b1a5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b5175bad9d | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5691/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5691/1/testReport/ | | Max. process+thread count | 5509 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5691/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]
Apache-HBase commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-1951846434 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 42s | master passed | | +1 :green_heart: | compile | 0m 43s | master passed | | +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 27s | the patch passed | | +1 :green_heart: | compile | 0m 43s | the patch passed | | +1 :green_heart: | javac | 0m 43s | the patch passed | | +1 :green_heart: | shadedjars | 5m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 237m 2s | hbase-server in the patch passed. | | | | 259m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5691/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5691 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5ca8ece82130 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b5175bad9d | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5691/1/testReport/ | | Max. process+thread count | 4979 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5691/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27949) [JDK17] Add JDK17 compilation and unit test support to nightly job
[ https://issues.apache.org/jira/browse/HBASE-27949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818363#comment-17818363 ] tianhang tang commented on HBASE-27949: --- Hi [~rajeshbabu] I'm sorry I haven't started working on this yet. I'd be very grateful if you could take over it. > [JDK17] Add JDK17 compilation and unit test support to nightly job > -- > > Key: HBASE-27949 > URL: https://issues.apache.org/jira/browse/HBASE-27949 > Project: HBase > Issue Type: Sub-task >Reporter: tianhang tang >Assignee: tianhang tang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951871696 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 43s | master passed | | +1 :green_heart: | compile | 1m 7s | master passed | | +1 :green_heart: | shadedjars | 5m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 43s | the patch passed | | +1 :green_heart: | compile | 1m 9s | the patch passed | | +1 :green_heart: | javac | 1m 9s | the patch passed | | +1 :green_heart: | shadedjars | 5m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 43s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 222m 54s | hbase-server in the patch passed. | | | | 249m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5690 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3fcae02d4d1e 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b5175bad9d | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/2/testReport/ | | Max. process+thread count | 5409 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5690/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
