[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r366112963
##
File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
##
@@ -127,8 +147,11 @@
pageTitle = "Table: " + escaped_fqtn;
}
pageContext.setAttribute("pageTitle", pageTitle);
- AsyncConnection connection =
ConnectionFactory.createAsyncConnection(master.getConfiguration()).get();
- AsyncAdmin admin = connection.getAdminBuilder().setOperationTimeout(5,
TimeUnit.SECONDS).build();
+ final AsyncConnection connection = master.getAsyncConnection();
Review comment:
nice..
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r366111041
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/RegionReplicaInfo.java
##
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.webapp;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.StreamSupport;
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.commons.lang3.builder.ToStringStyle;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.MetaTableAccessor;
+import org.apache.hadoop.hbase.RegionLocations;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.master.RegionState;
+import org.apache.hadoop.hbase.master.assignment.RegionStateStore;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * A POJO that consolidates the information about a single region replica
that's stored in meta.
+ */
+@InterfaceAudience.Private
+public final class RegionReplicaInfo {
+ private final byte[] row;
+ private final RegionInfo regionInfo;
+ private final RegionState.State regionState;
+ private final ServerName serverName;
+
+ private RegionReplicaInfo(final Result result, final HRegionLocation
location) {
+this.row = result != null ? result.getRow() : null;
+this.regionInfo = location != null ? location.getRegion() : null;
+this.regionState = (result != null && regionInfo != null)
+ ? RegionStateStore.getRegionState(result, regionInfo)
+ : null;
+this.serverName = location != null ? location.getServerName() : null;
+ }
+
+ public static List from(final Result result) {
+if (result == null) {
+ return Collections.singletonList(null);
+}
+
+final RegionLocations locations =
MetaTableAccessor.getRegionLocations(result);
+if (locations == null) {
+ return Collections.singletonList(null);
+}
+
+return StreamSupport.stream(locations.spliterator(), false)
+ .map(location -> new RegionReplicaInfo(result, location))
+ .collect(Collectors.toList());
+ }
+
+ public byte[] getRow() {
+return row;
+ }
+
+ public RegionInfo getRegionInfo() {
+return regionInfo;
+ }
+
+ public byte[] getRegionName() {
Review comment:
Thanks for the clean up.. this is what I had in mind.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r366106432
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java
##
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.webapp;
+
+import java.io.UnsupportedEncodingException;
+import java.net.URLDecoder;
+import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Optional;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.stream.Collectors;
+import javax.servlet.http.HttpServletRequest;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.commons.lang3.builder.ToStringStyle;
+import org.apache.hadoop.hbase.CompareOperator;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.AsyncConnection;
+import org.apache.hadoop.hbase.client.AsyncTable;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.ScanResultConsumer;
+import org.apache.hadoop.hbase.filter.Filter;
+import org.apache.hadoop.hbase.filter.FilterList;
+import org.apache.hadoop.hbase.filter.PrefixFilter;
+import org.apache.hadoop.hbase.filter.SingleColumnValueFilter;
+import org.apache.hadoop.hbase.master.RegionState;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import
org.apache.hbase.thirdparty.com.google.common.util.concurrent.ThreadFactoryBuilder;
+import
org.apache.hbase.thirdparty.io.netty.handler.codec.http.QueryStringEncoder;
+
+/**
+ * A support class for the "Meta Entries" section in
+ * {@code resources/hbase-webapps/master/table.jsp}.
+ */
+@InterfaceAudience.Private
+public class MetaBrowser implements Iterable {
+ private static final Logger logger =
LoggerFactory.getLogger(MetaBrowser.class);
+
+ public static final String NAME_PARAM = "name";
+ public static final String SCAN_LIMIT_PARAM = "scan_limit";
+ public static final String SCAN_REGION_STATE_PARAM = "scan_region_state";
+ public static final String SCAN_START_PARAM = "scan_start";
+ public static final String SCAN_TABLE_PARAM = "scan_table";
+
+ public static final int SCAN_LIMIT_DEFAULT = 10;
+ public static final int SCAN_LIMIT_MAX = 10_000;
Review comment:
I think some form of this could be captured in the javadoc class comment.
Otherwise, one needs to understand how this class paginates the result by
setting the start row intelligently..
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r366110661
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java
##
@@ -0,0 +1,378 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.webapp;
+
+import java.io.UnsupportedEncodingException;
+import java.net.URLDecoder;
+import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.stream.StreamSupport;
+import javax.servlet.http.HttpServletRequest;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.commons.lang3.builder.ToStringStyle;
+import org.apache.hadoop.hbase.CompareOperator;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.AdvancedScanResultConsumer;
+import org.apache.hadoop.hbase.client.AsyncConnection;
+import org.apache.hadoop.hbase.client.AsyncTable;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.filter.Filter;
+import org.apache.hadoop.hbase.filter.FilterList;
+import org.apache.hadoop.hbase.filter.PrefixFilter;
+import org.apache.hadoop.hbase.filter.SingleColumnValueFilter;
+import org.apache.hadoop.hbase.master.RegionState;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.hbase.thirdparty.com.google.common.collect.Iterators;
+import
org.apache.hbase.thirdparty.io.netty.handler.codec.http.QueryStringEncoder;
+
+/**
+ * A support class for the "Meta Entries" section in
+ * {@code resources/hbase-webapps/master/table.jsp}.
+ */
+@InterfaceAudience.Private
+public class MetaBrowser {
+ public static final String NAME_PARAM = "name";
+ public static final String SCAN_LIMIT_PARAM = "scan_limit";
+ public static final String SCAN_REGION_STATE_PARAM = "scan_region_state";
+ public static final String SCAN_START_PARAM = "scan_start";
+ public static final String SCAN_TABLE_PARAM = "scan_table";
+
+ public static final int SCAN_LIMIT_DEFAULT = 10;
+ public static final int SCAN_LIMIT_MAX = 10_000;
+
+ private final AsyncConnection connection;
+ private final HttpServletRequest request;
+ private final List errorMessages;
+ private final String name;
+ private final Integer scanLimit;
+ private final RegionState.State scanRegionState;
+ private final byte[] scanStart;
+ private final TableName scanTable;
+
+ public MetaBrowser(final AsyncConnection connection, final
HttpServletRequest request) {
+this.connection = connection;
+this.request = request;
+this.errorMessages = new LinkedList<>();
+this.name = resolveName(request);
+this.scanLimit = resolveScanLimit(request);
+this.scanRegionState = resolveScanRegionState(request);
+this.scanStart = resolveScanStart(request);
+this.scanTable = resolveScanTable(request);
+ }
+
+ public List getErrorMessages() {
+return errorMessages;
+ }
+
+ public String getName() {
+return name;
+ }
+
+ public Integer getScanLimit() {
+return scanLimit;
+ }
+
+ public byte[] getScanStart() {
+return scanStart;
+ }
+
+ public RegionState.State getScanRegionState() {
+return scanRegionState;
+ }
+
+ public TableName getScanTable() {
+return scanTable;
+ }
+
+ public Results getResults() {
+final AsyncTable asyncTable =
+ connection.getTable(TableName.META_TABLE_NAME);
+return new Results(asyncTable.getScanner(buildScan()));
+ }
+
+ @Override
+ public String toString() {
+return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE)
+ .append("scanStart", scanStart)
+ .append("scanLimit", scanLimit)
+ .append("scanTable", scanTable)
+ .append("scanRegionState", scanRegionState)
+ .toString();
+ }
+
+ private static String resolveName(final HttpServletRe
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r366109181
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java
##
@@ -0,0 +1,378 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.webapp;
+
+import java.io.UnsupportedEncodingException;
+import java.net.URLDecoder;
+import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.stream.StreamSupport;
+import javax.servlet.http.HttpServletRequest;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.commons.lang3.builder.ToStringStyle;
+import org.apache.hadoop.hbase.CompareOperator;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.AdvancedScanResultConsumer;
+import org.apache.hadoop.hbase.client.AsyncConnection;
+import org.apache.hadoop.hbase.client.AsyncTable;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.filter.Filter;
+import org.apache.hadoop.hbase.filter.FilterList;
+import org.apache.hadoop.hbase.filter.PrefixFilter;
+import org.apache.hadoop.hbase.filter.SingleColumnValueFilter;
+import org.apache.hadoop.hbase.master.RegionState;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.hbase.thirdparty.com.google.common.collect.Iterators;
+import
org.apache.hbase.thirdparty.io.netty.handler.codec.http.QueryStringEncoder;
+
+/**
+ * A support class for the "Meta Entries" section in
+ * {@code resources/hbase-webapps/master/table.jsp}.
+ */
+@InterfaceAudience.Private
+public class MetaBrowser {
+ public static final String NAME_PARAM = "name";
+ public static final String SCAN_LIMIT_PARAM = "scan_limit";
+ public static final String SCAN_REGION_STATE_PARAM = "scan_region_state";
+ public static final String SCAN_START_PARAM = "scan_start";
+ public static final String SCAN_TABLE_PARAM = "scan_table";
+
+ public static final int SCAN_LIMIT_DEFAULT = 10;
+ public static final int SCAN_LIMIT_MAX = 10_000;
+
+ private final AsyncConnection connection;
+ private final HttpServletRequest request;
+ private final List errorMessages;
+ private final String name;
+ private final Integer scanLimit;
+ private final RegionState.State scanRegionState;
+ private final byte[] scanStart;
+ private final TableName scanTable;
+
+ public MetaBrowser(final AsyncConnection connection, final
HttpServletRequest request) {
+this.connection = connection;
+this.request = request;
+this.errorMessages = new LinkedList<>();
+this.name = resolveName(request);
+this.scanLimit = resolveScanLimit(request);
+this.scanRegionState = resolveScanRegionState(request);
+this.scanStart = resolveScanStart(request);
+this.scanTable = resolveScanTable(request);
+ }
+
+ public List getErrorMessages() {
+return errorMessages;
+ }
+
+ public String getName() {
+return name;
+ }
+
+ public Integer getScanLimit() {
+return scanLimit;
+ }
+
+ public byte[] getScanStart() {
+return scanStart;
+ }
+
+ public RegionState.State getScanRegionState() {
+return scanRegionState;
+ }
+
+ public TableName getScanTable() {
+return scanTable;
+ }
+
+ public Results getResults() {
+final AsyncTable asyncTable =
+ connection.getTable(TableName.META_TABLE_NAME);
+return new Results(asyncTable.getScanner(buildScan()));
+ }
+
+ @Override
+ public String toString() {
+return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE)
+ .append("scanStart", scanStart)
+ .append("scanLimit", scanLimit)
+ .append("scanTable", scanTable)
+ .append("scanRegionState", scanRegionState)
+ .toString();
+ }
+
+ private static String resolveName(final HttpServletRe
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r366108162
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java
##
@@ -0,0 +1,378 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.webapp;
+
+import java.io.UnsupportedEncodingException;
+import java.net.URLDecoder;
+import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.stream.StreamSupport;
+import javax.servlet.http.HttpServletRequest;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.commons.lang3.builder.ToStringStyle;
+import org.apache.hadoop.hbase.CompareOperator;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.AdvancedScanResultConsumer;
+import org.apache.hadoop.hbase.client.AsyncConnection;
+import org.apache.hadoop.hbase.client.AsyncTable;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.filter.Filter;
+import org.apache.hadoop.hbase.filter.FilterList;
+import org.apache.hadoop.hbase.filter.PrefixFilter;
+import org.apache.hadoop.hbase.filter.SingleColumnValueFilter;
+import org.apache.hadoop.hbase.master.RegionState;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.hbase.thirdparty.com.google.common.collect.Iterators;
+import
org.apache.hbase.thirdparty.io.netty.handler.codec.http.QueryStringEncoder;
+
+/**
+ * A support class for the "Meta Entries" section in
+ * {@code resources/hbase-webapps/master/table.jsp}.
+ */
+@InterfaceAudience.Private
+public class MetaBrowser {
+ public static final String NAME_PARAM = "name";
+ public static final String SCAN_LIMIT_PARAM = "scan_limit";
+ public static final String SCAN_REGION_STATE_PARAM = "scan_region_state";
+ public static final String SCAN_START_PARAM = "scan_start";
+ public static final String SCAN_TABLE_PARAM = "scan_table";
+
+ public static final int SCAN_LIMIT_DEFAULT = 10;
+ public static final int SCAN_LIMIT_MAX = 10_000;
+
+ private final AsyncConnection connection;
+ private final HttpServletRequest request;
+ private final List errorMessages;
+ private final String name;
+ private final Integer scanLimit;
+ private final RegionState.State scanRegionState;
+ private final byte[] scanStart;
+ private final TableName scanTable;
+
+ public MetaBrowser(final AsyncConnection connection, final
HttpServletRequest request) {
+this.connection = connection;
+this.request = request;
+this.errorMessages = new LinkedList<>();
+this.name = resolveName(request);
+this.scanLimit = resolveScanLimit(request);
+this.scanRegionState = resolveScanRegionState(request);
+this.scanStart = resolveScanStart(request);
+this.scanTable = resolveScanTable(request);
+ }
+
+ public List getErrorMessages() {
+return errorMessages;
+ }
+
+ public String getName() {
+return name;
+ }
+
+ public Integer getScanLimit() {
+return scanLimit;
+ }
+
+ public byte[] getScanStart() {
+return scanStart;
+ }
+
+ public RegionState.State getScanRegionState() {
+return scanRegionState;
+ }
+
+ public TableName getScanTable() {
+return scanTable;
+ }
+
+ public Results getResults() {
+final AsyncTable asyncTable =
+ connection.getTable(TableName.META_TABLE_NAME);
+return new Results(asyncTable.getScanner(buildScan()));
+ }
+
+ @Override
+ public String toString() {
+return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE)
+ .append("scanStart", scanStart)
+ .append("scanLimit", scanLimit)
+ .append("scanTable", scanTable)
+ .append("scanRegionState", scanRegionState)
+ .toString();
+ }
+
+ private static String resolveName(final HttpServletRe
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r366112562
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java
##
@@ -0,0 +1,378 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.webapp;
+
+import java.io.UnsupportedEncodingException;
+import java.net.URLDecoder;
+import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.stream.StreamSupport;
+import javax.servlet.http.HttpServletRequest;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.commons.lang3.builder.ToStringStyle;
+import org.apache.hadoop.hbase.CompareOperator;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.AdvancedScanResultConsumer;
+import org.apache.hadoop.hbase.client.AsyncConnection;
+import org.apache.hadoop.hbase.client.AsyncTable;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.filter.Filter;
+import org.apache.hadoop.hbase.filter.FilterList;
+import org.apache.hadoop.hbase.filter.PrefixFilter;
+import org.apache.hadoop.hbase.filter.SingleColumnValueFilter;
+import org.apache.hadoop.hbase.master.RegionState;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.hbase.thirdparty.com.google.common.collect.Iterators;
+import
org.apache.hbase.thirdparty.io.netty.handler.codec.http.QueryStringEncoder;
+
+/**
+ * A support class for the "Meta Entries" section in
+ * {@code resources/hbase-webapps/master/table.jsp}.
+ */
+@InterfaceAudience.Private
+public class MetaBrowser {
+ public static final String NAME_PARAM = "name";
+ public static final String SCAN_LIMIT_PARAM = "scan_limit";
+ public static final String SCAN_REGION_STATE_PARAM = "scan_region_state";
+ public static final String SCAN_START_PARAM = "scan_start";
+ public static final String SCAN_TABLE_PARAM = "scan_table";
+
+ public static final int SCAN_LIMIT_DEFAULT = 10;
+ public static final int SCAN_LIMIT_MAX = 10_000;
+
+ private final AsyncConnection connection;
+ private final HttpServletRequest request;
+ private final List errorMessages;
+ private final String name;
+ private final Integer scanLimit;
+ private final RegionState.State scanRegionState;
+ private final byte[] scanStart;
+ private final TableName scanTable;
+
+ public MetaBrowser(final AsyncConnection connection, final
HttpServletRequest request) {
+this.connection = connection;
+this.request = request;
+this.errorMessages = new LinkedList<>();
+this.name = resolveName(request);
+this.scanLimit = resolveScanLimit(request);
+this.scanRegionState = resolveScanRegionState(request);
+this.scanStart = resolveScanStart(request);
+this.scanTable = resolveScanTable(request);
+ }
+
+ public List getErrorMessages() {
+return errorMessages;
+ }
+
+ public String getName() {
+return name;
+ }
+
+ public Integer getScanLimit() {
+return scanLimit;
+ }
+
+ public byte[] getScanStart() {
+return scanStart;
+ }
+
+ public RegionState.State getScanRegionState() {
+return scanRegionState;
+ }
+
+ public TableName getScanTable() {
+return scanTable;
+ }
+
+ public Results getResults() {
+final AsyncTable asyncTable =
+ connection.getTable(TableName.META_TABLE_NAME);
+return new Results(asyncTable.getScanner(buildScan()));
+ }
+
+ @Override
+ public String toString() {
+return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE)
+ .append("scanStart", scanStart)
+ .append("scanLimit", scanLimit)
+ .append("scanTable", scanTable)
+ .append("scanRegionState", scanRegionState)
+ .toString();
+ }
+
+ private static String resolveName(final HttpServletRe
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r365474032
##
File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
##
@@ -129,6 +151,7 @@
pageContext.setAttribute("pageTitle", pageTitle);
AsyncConnection connection =
ConnectionFactory.createAsyncConnection(master.getConfiguration()).get();
Review comment:
Not your change, but creating a new connection every time this page loads
seems a little heavy? Why not reuse the async connection created at the master
startup? (master.getAsyncConnection()).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r365475813
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java
##
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.webapp;
+
+import java.io.UnsupportedEncodingException;
+import java.net.URLDecoder;
+import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Optional;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.stream.Collectors;
+import javax.servlet.http.HttpServletRequest;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.commons.lang3.builder.ToStringStyle;
+import org.apache.hadoop.hbase.CompareOperator;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.AsyncConnection;
+import org.apache.hadoop.hbase.client.AsyncTable;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.ScanResultConsumer;
+import org.apache.hadoop.hbase.filter.Filter;
+import org.apache.hadoop.hbase.filter.FilterList;
+import org.apache.hadoop.hbase.filter.PrefixFilter;
+import org.apache.hadoop.hbase.filter.SingleColumnValueFilter;
+import org.apache.hadoop.hbase.master.RegionState;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import
org.apache.hbase.thirdparty.com.google.common.util.concurrent.ThreadFactoryBuilder;
+import
org.apache.hbase.thirdparty.io.netty.handler.codec.http.QueryStringEncoder;
+
+/**
+ * A support class for the "Meta Entries" section in
+ * {@code resources/hbase-webapps/master/table.jsp}.
+ */
+@InterfaceAudience.Private
+public class MetaBrowser implements Iterable {
+ private static final Logger logger =
LoggerFactory.getLogger(MetaBrowser.class);
+
+ public static final String NAME_PARAM = "name";
+ public static final String SCAN_LIMIT_PARAM = "scan_limit";
+ public static final String SCAN_REGION_STATE_PARAM = "scan_region_state";
+ public static final String SCAN_START_PARAM = "scan_start";
+ public static final String SCAN_TABLE_PARAM = "scan_table";
+
+ public static final int SCAN_LIMIT_DEFAULT = 10;
+ public static final int SCAN_LIMIT_MAX = 10_000;
+
+ private final AsyncConnection connection;
+ private final HttpServletRequest request;
+ private final ExecutorService pool;
+ private final List errorMessages;
+ private final String name;
+ private final Integer scanLimit;
+ private final RegionState.State scanRegionState;
+ private final byte[] scanStart;
+ private final TableName scanTable;
+
+ public MetaBrowser(final AsyncConnection connection, final
HttpServletRequest request) {
+this.connection = connection;
+this.request = request;
+this.pool = buildThreadPool();
+this.errorMessages = new LinkedList<>();
+this.name = resolveName(request);
+this.scanLimit = resolveScanLimit(request);
+this.scanRegionState = resolveScanRegionState(request);
+this.scanStart = resolveScanStart(request);
+this.scanTable = resolveScanTable(request);
+ }
+
+ public List getErrorMessages() {
+return errorMessages;
+ }
+
+ public String getName() {
+return name;
+ }
+
+ public Integer getScanLimit() {
+return scanLimit;
+ }
+
+ public byte[] getScanStart() {
+return scanStart;
+ }
+
+ public RegionState.State getScanRegionState() {
+return scanRegionState;
+ }
+
+ public TableName getScanTable() {
+return scanTable;
+ }
+
+ @Override
+ public Iterator iterator() {
+return limitIterator();
+ }
+
+ public LimitIterator limitIterator() {
+logger.debug("initiating meta scan, {}", this);
+
+final AsyncTable asyncTable =
+ connection.getTable(TableNa
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r365476199
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java
##
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.webapp;
+
+import java.io.UnsupportedEncodingException;
+import java.net.URLDecoder;
+import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Optional;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.stream.Collectors;
+import javax.servlet.http.HttpServletRequest;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.commons.lang3.builder.ToStringStyle;
+import org.apache.hadoop.hbase.CompareOperator;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.AsyncConnection;
+import org.apache.hadoop.hbase.client.AsyncTable;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.ScanResultConsumer;
+import org.apache.hadoop.hbase.filter.Filter;
+import org.apache.hadoop.hbase.filter.FilterList;
+import org.apache.hadoop.hbase.filter.PrefixFilter;
+import org.apache.hadoop.hbase.filter.SingleColumnValueFilter;
+import org.apache.hadoop.hbase.master.RegionState;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import
org.apache.hbase.thirdparty.com.google.common.util.concurrent.ThreadFactoryBuilder;
+import
org.apache.hbase.thirdparty.io.netty.handler.codec.http.QueryStringEncoder;
+
+/**
+ * A support class for the "Meta Entries" section in
+ * {@code resources/hbase-webapps/master/table.jsp}.
+ */
+@InterfaceAudience.Private
+public class MetaBrowser implements Iterable {
+ private static final Logger logger =
LoggerFactory.getLogger(MetaBrowser.class);
+
+ public static final String NAME_PARAM = "name";
+ public static final String SCAN_LIMIT_PARAM = "scan_limit";
+ public static final String SCAN_REGION_STATE_PARAM = "scan_region_state";
+ public static final String SCAN_START_PARAM = "scan_start";
+ public static final String SCAN_TABLE_PARAM = "scan_table";
+
+ public static final int SCAN_LIMIT_DEFAULT = 10;
+ public static final int SCAN_LIMIT_MAX = 10_000;
+
+ private final AsyncConnection connection;
+ private final HttpServletRequest request;
+ private final ExecutorService pool;
+ private final List errorMessages;
+ private final String name;
+ private final Integer scanLimit;
+ private final RegionState.State scanRegionState;
+ private final byte[] scanStart;
+ private final TableName scanTable;
+
+ public MetaBrowser(final AsyncConnection connection, final
HttpServletRequest request) {
+this.connection = connection;
+this.request = request;
+this.pool = buildThreadPool();
+this.errorMessages = new LinkedList<>();
+this.name = resolveName(request);
+this.scanLimit = resolveScanLimit(request);
+this.scanRegionState = resolveScanRegionState(request);
+this.scanStart = resolveScanStart(request);
+this.scanTable = resolveScanTable(request);
+ }
+
+ public List getErrorMessages() {
+return errorMessages;
+ }
+
+ public String getName() {
+return name;
+ }
+
+ public Integer getScanLimit() {
+return scanLimit;
+ }
+
+ public byte[] getScanStart() {
+return scanStart;
+ }
+
+ public RegionState.State getScanRegionState() {
+return scanRegionState;
+ }
+
+ public TableName getScanTable() {
+return scanTable;
+ }
+
+ @Override
+ public Iterator iterator() {
+return limitIterator();
+ }
+
+ public LimitIterator limitIterator() {
+logger.debug("initiating meta scan, {}", this);
+
+final AsyncTable asyncTable =
+ connection.getTable(TableNa
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r365477051
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java
##
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.webapp;
+
+import java.io.UnsupportedEncodingException;
+import java.net.URLDecoder;
+import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Optional;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.stream.Collectors;
+import javax.servlet.http.HttpServletRequest;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.commons.lang3.builder.ToStringStyle;
+import org.apache.hadoop.hbase.CompareOperator;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.AsyncConnection;
+import org.apache.hadoop.hbase.client.AsyncTable;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.ScanResultConsumer;
+import org.apache.hadoop.hbase.filter.Filter;
+import org.apache.hadoop.hbase.filter.FilterList;
+import org.apache.hadoop.hbase.filter.PrefixFilter;
+import org.apache.hadoop.hbase.filter.SingleColumnValueFilter;
+import org.apache.hadoop.hbase.master.RegionState;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import
org.apache.hbase.thirdparty.com.google.common.util.concurrent.ThreadFactoryBuilder;
+import
org.apache.hbase.thirdparty.io.netty.handler.codec.http.QueryStringEncoder;
+
+/**
+ * A support class for the "Meta Entries" section in
+ * {@code resources/hbase-webapps/master/table.jsp}.
+ */
+@InterfaceAudience.Private
+public class MetaBrowser implements Iterable {
+ private static final Logger logger =
LoggerFactory.getLogger(MetaBrowser.class);
+
+ public static final String NAME_PARAM = "name";
+ public static final String SCAN_LIMIT_PARAM = "scan_limit";
+ public static final String SCAN_REGION_STATE_PARAM = "scan_region_state";
+ public static final String SCAN_START_PARAM = "scan_start";
+ public static final String SCAN_TABLE_PARAM = "scan_table";
+
+ public static final int SCAN_LIMIT_DEFAULT = 10;
+ public static final int SCAN_LIMIT_MAX = 10_000;
+
+ private final AsyncConnection connection;
+ private final HttpServletRequest request;
+ private final ExecutorService pool;
+ private final List errorMessages;
+ private final String name;
+ private final Integer scanLimit;
+ private final RegionState.State scanRegionState;
+ private final byte[] scanStart;
+ private final TableName scanTable;
+
+ public MetaBrowser(final AsyncConnection connection, final
HttpServletRequest request) {
+this.connection = connection;
+this.request = request;
+this.pool = buildThreadPool();
+this.errorMessages = new LinkedList<>();
+this.name = resolveName(request);
+this.scanLimit = resolveScanLimit(request);
+this.scanRegionState = resolveScanRegionState(request);
+this.scanStart = resolveScanStart(request);
+this.scanTable = resolveScanTable(request);
+ }
+
+ public List getErrorMessages() {
+return errorMessages;
+ }
+
+ public String getName() {
+return name;
+ }
+
+ public Integer getScanLimit() {
+return scanLimit;
+ }
+
+ public byte[] getScanStart() {
+return scanStart;
+ }
+
+ public RegionState.State getScanRegionState() {
+return scanRegionState;
+ }
+
+ public TableName getScanTable() {
+return scanTable;
+ }
+
+ @Override
+ public Iterator iterator() {
+return limitIterator();
+ }
+
+ public LimitIterator limitIterator() {
+logger.debug("initiating meta scan, {}", this);
+
+final AsyncTable asyncTable =
+ connection.getTable(TableNa
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r365478702
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/RegionReplicaInfo.java
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.webapp;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Optional;
+import java.util.stream.Collectors;
+import java.util.stream.StreamSupport;
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.commons.lang3.builder.ToStringStyle;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.MetaTableAccessor;
+import org.apache.hadoop.hbase.RegionLocations;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.master.RegionState;
+import org.apache.hadoop.hbase.master.assignment.RegionStateStore;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * A POJO that consolidates the information about a single region replica
that's stored in meta.
+ */
+@InterfaceAudience.Private
+public final class RegionReplicaInfo {
+ private final byte[] row;
+ private final RegionInfo regionInfo;
+ private final byte[] regionName;
+ private final byte[] startKey;
+ private final byte[] endKey;
+ private final Integer replicaId;
+ private final RegionState.State regionState;
+ private final ServerName serverName;
+
+ private RegionReplicaInfo(final Result result, final HRegionLocation
location) {
+final Optional maybeResult = Optional.ofNullable(result);
+final Optional maybeLocation =
Optional.ofNullable(location);
+final Optional maybeRegionInfo =
maybeLocation.map(HRegionLocation::getRegion);
+
+this.row = maybeResult.map(Result::getRow).orElse(null);
Review comment:
nit: the accessors methods could work directly on regioninfo object ? (less
code).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r365477170
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java
##
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.webapp;
+
+import java.io.UnsupportedEncodingException;
+import java.net.URLDecoder;
+import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Optional;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.stream.Collectors;
+import javax.servlet.http.HttpServletRequest;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.commons.lang3.builder.ToStringStyle;
+import org.apache.hadoop.hbase.CompareOperator;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.AsyncConnection;
+import org.apache.hadoop.hbase.client.AsyncTable;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.ScanResultConsumer;
+import org.apache.hadoop.hbase.filter.Filter;
+import org.apache.hadoop.hbase.filter.FilterList;
+import org.apache.hadoop.hbase.filter.PrefixFilter;
+import org.apache.hadoop.hbase.filter.SingleColumnValueFilter;
+import org.apache.hadoop.hbase.master.RegionState;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import
org.apache.hbase.thirdparty.com.google.common.util.concurrent.ThreadFactoryBuilder;
+import
org.apache.hbase.thirdparty.io.netty.handler.codec.http.QueryStringEncoder;
+
+/**
+ * A support class for the "Meta Entries" section in
+ * {@code resources/hbase-webapps/master/table.jsp}.
+ */
+@InterfaceAudience.Private
+public class MetaBrowser implements Iterable {
+ private static final Logger logger =
LoggerFactory.getLogger(MetaBrowser.class);
+
+ public static final String NAME_PARAM = "name";
+ public static final String SCAN_LIMIT_PARAM = "scan_limit";
+ public static final String SCAN_REGION_STATE_PARAM = "scan_region_state";
+ public static final String SCAN_START_PARAM = "scan_start";
+ public static final String SCAN_TABLE_PARAM = "scan_table";
+
+ public static final int SCAN_LIMIT_DEFAULT = 10;
+ public static final int SCAN_LIMIT_MAX = 10_000;
+
+ private final AsyncConnection connection;
+ private final HttpServletRequest request;
+ private final ExecutorService pool;
+ private final List errorMessages;
+ private final String name;
+ private final Integer scanLimit;
+ private final RegionState.State scanRegionState;
+ private final byte[] scanStart;
+ private final TableName scanTable;
+
+ public MetaBrowser(final AsyncConnection connection, final
HttpServletRequest request) {
+this.connection = connection;
+this.request = request;
+this.pool = buildThreadPool();
+this.errorMessages = new LinkedList<>();
+this.name = resolveName(request);
+this.scanLimit = resolveScanLimit(request);
+this.scanRegionState = resolveScanRegionState(request);
+this.scanStart = resolveScanStart(request);
+this.scanTable = resolveScanTable(request);
+ }
+
+ public List getErrorMessages() {
+return errorMessages;
+ }
+
+ public String getName() {
+return name;
+ }
+
+ public Integer getScanLimit() {
+return scanLimit;
+ }
+
+ public byte[] getScanStart() {
+return scanStart;
+ }
+
+ public RegionState.State getScanRegionState() {
+return scanRegionState;
+ }
+
+ public TableName getScanTable() {
+return scanTable;
+ }
+
+ @Override
+ public Iterator iterator() {
+return limitIterator();
+ }
+
+ public LimitIterator limitIterator() {
+logger.debug("initiating meta scan, {}", this);
+
+final AsyncTable asyncTable =
+ connection.getTable(TableNa
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r365481059
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterRule.java
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase;
+
+import java.io.IOException;
+import java.util.concurrent.CompletableFuture;
+import org.apache.hadoop.hbase.client.AsyncConnection;
+import org.apache.hadoop.hbase.client.ConnectionFactory;
+import org.junit.Rule;
+import org.junit.rules.ExternalResource;
+
+/**
+ * A {@link Rule} that manages an instance of the {@link MiniHBaseCluster}.
+ */
+public class TestClusterRule extends ExternalResource {
+ private final HBaseTestingUtility testingUtility;
+ private final StartMiniClusterOption miniClusterOptions;
+
+ private MiniHBaseCluster miniCluster;
+
+ public TestClusterRule() {
+this(StartMiniClusterOption.builder().build());
+ }
+
+ public TestClusterRule(final StartMiniClusterOption miniClusterOptions) {
+this.testingUtility = new HBaseTestingUtility();
+this.miniClusterOptions = miniClusterOptions;
+ }
+
+ public CompletableFuture createConnection() {
+if (miniCluster == null) { throw new IllegalStateException("test cluster
not initialized"); }
Review comment:
nit: You'll probably run into checkstyle issues with inline if blocks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r365480952
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/ClearUserNamespacesAndTablesRule.java
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase;
+
+import java.util.List;
+import java.util.Objects;
+import java.util.StringJoiner;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Supplier;
+import java.util.stream.Collectors;
+import org.apache.hadoop.hbase.client.AsyncAdmin;
+import org.apache.hadoop.hbase.client.AsyncConnection;
+import org.junit.Rule;
+import org.junit.rules.ExternalResource;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * A {@link Rule} that clears all user tables and namespaces before the test
executes.
+ */
+public class ClearUserNamespacesAndTablesRule extends ExternalResource {
+ private static final Logger logger =
+LoggerFactory.getLogger(ClearUserNamespacesAndTablesRule.class);
+
+ private final Supplier connectionSupplier;
Review comment:
May be add a comment that this class doesn't close the connection by the end
of it and needs to chained with TestConnectionRule which does it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r365468451
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/LimitIterator.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.webapp;
+
+import java.util.Iterator;
+import java.util.NoSuchElementException;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.hbase.thirdparty.com.google.common.collect.Iterators;
+
+/**
+ * An {@link Iterator} over {@code delegate} that limits results to the first
{@code limit}
Review comment:
Any reason not to use Iterators.limit() from guava?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui
bharathv commented on a change in pull request #1020: HBASE-23653 Expose
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r365480306
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/ClearUserNamespacesAndTablesRule.java
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase;
+
+import java.util.List;
+import java.util.Objects;
+import java.util.StringJoiner;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Supplier;
+import java.util.stream.Collectors;
+import org.apache.hadoop.hbase.client.AsyncAdmin;
+import org.apache.hadoop.hbase.client.AsyncConnection;
+import org.junit.Rule;
+import org.junit.rules.ExternalResource;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * A {@link Rule} that clears all user tables and namespaces before the test
executes.
+ */
+public class ClearUserNamespacesAndTablesRule extends ExternalResource {
Review comment:
nice.. for some reason, I thought we already had this somewhere, looked
around but didn't find one.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
