[GitHub] [hbase] nyl3532016 commented on a change in pull request #3538: HBASE-26045 Master control the global throughtput of all compaction servers
nyl3532016 commented on a change in pull request #3538: URL: https://github.com/apache/hbase/pull/3538#discussion_r706015667 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java ## @@ -2256,6 +2256,17 @@ void cloneTableSchema(TableName tableName, TableName newTableName, boolean prese */ boolean isCompactionOffloadEnabled() throws IOException; + /** + * update compaction server total throughput bound + * @param upperBound the total throughput upper bound of all compaction servers + * @param lowerBound the total throughput lower bound of all compaction servers + * @param offPeak the total throughput offPeak bound of all compaction servers + * @return the now total throughput of all compaction servers + * @throws IOException if a remote or network exception occurs + */ + Map updateCompactionServerTotalThroughput(Long upperBound, Long lowerBound, Review comment: Yes, We do not control regionserver's compaction throughtput in this PR (it is OK?), For HRegionserver can adjust their compaction throughtput via update_config shell commend, no need restart server. They implement ConfigurationObserver interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] nyl3532016 commented on a change in pull request #3538: HBASE-26045 Master control the global throughtput of all compaction servers
nyl3532016 commented on a change in pull request #3538: URL: https://github.com/apache/hbase/pull/3538#discussion_r706015667 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java ## @@ -2256,6 +2256,17 @@ void cloneTableSchema(TableName tableName, TableName newTableName, boolean prese */ boolean isCompactionOffloadEnabled() throws IOException; + /** + * update compaction server total throughput bound + * @param upperBound the total throughput upper bound of all compaction servers + * @param lowerBound the total throughput lower bound of all compaction servers + * @param offPeak the total throughput offPeak bound of all compaction servers + * @return the now total throughput of all compaction servers + * @throws IOException if a remote or network exception occurs + */ + Map updateCompactionServerTotalThroughput(Long upperBound, Long lowerBound, Review comment: Yes, We do not control regionserver's compaction throughtput in this PR, For HRegionserver can adjust their compaction throughtput via update_config shell commend, no need restart server. They implement ConfigurationObserver interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] nyl3532016 commented on a change in pull request #3538: HBASE-26045 Master control the global throughtput of all compaction servers
nyl3532016 commented on a change in pull request #3538: URL: https://github.com/apache/hbase/pull/3538#discussion_r687452241 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java ## @@ -2256,6 +2256,17 @@ void cloneTableSchema(TableName tableName, TableName newTableName, boolean prese */ boolean isCompactionOffloadEnabled() throws IOException; + /** + * update compaction server total throughput bound + * @param upperBound the total throughput upper bound of all compaction servers Review comment: This method talk to master only, compaction servers get throughput control message through periodic heartbeat report -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] nyl3532016 commented on a change in pull request #3538: HBASE-26045 Master control the global throughtput of all compaction servers
nyl3532016 commented on a change in pull request #3538: URL: https://github.com/apache/hbase/pull/3538#discussion_r686530779 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java ## @@ -2256,6 +2256,17 @@ void cloneTableSchema(TableName tableName, TableName newTableName, boolean prese */ boolean isCompactionOffloadEnabled() throws IOException; + /** + * update compaction server total throughput bound + * @param upperBound the total throughput upper bound of all compaction servers Review comment: we can control compaction throughtput on compactionServers, can not control regionservers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
