[jira] [Comment Edited] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[
https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590475#comment-16590475
]
Ted Yu edited comment on HBASE-19008 at 8/23/18 4:32 PM:
-
Reid:
You can drop the changes to {{SparkSQLPushDownFilter}} in patch v21 and apply
it to branch-2.
Liubang's identity would be kept.
FYI
was (Author: yuzhih...@gmail.com):
Reid:
You can drop the changes to 19008-21.patch in patch v21 and apply it to
branch-2.
Liubang's identity would be kept.
FYI
> Add missing equals or hashCode method(s) to stock Filter implementations
>
>
> Key: HBASE-19008
> URL: https://issues.apache.org/jira/browse/HBASE-19008
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: liubangchen
>Priority: Major
> Labels: filter
> Fix For: 3.0.0
>
> Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch,
> HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch,
> HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-16.patch,
> HBASE-19008-17.patch, HBASE-19008-18.patch, HBASE-19008-2.patch,
> HBASE-19008-20.patch, HBASE-19008-21.patch, HBASE-19008-3.patch,
> HBASE-19008-4.patch, HBASE-19008-5.patch, HBASE-19008-6.patch,
> HBASE-19008-7.patch, HBASE-19008-8.patch, HBASE-19008-9.patch,
> HBASE-19008.patch
>
>
> In HBASE-15410, [~mdrob] reminded me that Filter implementations may not
> write {{equals}} or {{hashCode}} method(s).
> This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock
> Filter implementations such as KeyOnlyFilter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[
https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590466#comment-16590466
]
Reid Chan edited comment on HBASE-19008 at 8/23/18 4:26 PM:
It's better if you can provide a patch for branch-2. [~liubangchen]
was (Author: reidchan):
It's better you can provide a patch for branch-2. [~liubangchen]
> Add missing equals or hashCode method(s) to stock Filter implementations
>
>
> Key: HBASE-19008
> URL: https://issues.apache.org/jira/browse/HBASE-19008
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: liubangchen
>Priority: Major
> Labels: filter
> Fix For: 3.0.0
>
> Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch,
> HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch,
> HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-16.patch,
> HBASE-19008-17.patch, HBASE-19008-18.patch, HBASE-19008-2.patch,
> HBASE-19008-20.patch, HBASE-19008-21.patch, HBASE-19008-3.patch,
> HBASE-19008-4.patch, HBASE-19008-5.patch, HBASE-19008-6.patch,
> HBASE-19008-7.patch, HBASE-19008-8.patch, HBASE-19008-9.patch,
> HBASE-19008.patch
>
>
> In HBASE-15410, [~mdrob] reminded me that Filter implementations may not
> write {{equals}} or {{hashCode}} method(s).
> This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock
> Filter implementations such as KeyOnlyFilter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[
https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586884#comment-16586884
]
Reid Chan edited comment on HBASE-19008 at 8/21/18 3:27 AM:
{{SingleColumnValueExcludeFilter}} extends {{SingleColumnValueFilter}} without
additional properties, no need overriding {{equals}} and {{hashCode}}.
(I only skimmed one class and found a problem)
Far to go i'm afraid, please be patient and detailed, especially to this bored
and tedious patch. :)
was (Author: reidchan):
{{SingleColumnValueExcludeFilter}} extends {{SingleColumnValueFilter}} without
additional properties, no need overriding.
(I only skimmed one class and found a problem)
Far to go i'm afraid, please be patient and detailed, especially to this bored
and tedious patch. :)
> Add missing equals or hashCode method(s) to stock Filter implementations
>
>
> Key: HBASE-19008
> URL: https://issues.apache.org/jira/browse/HBASE-19008
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: liubangchen
>Priority: Major
> Labels: filter
> Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch,
> HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch,
> HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-2.patch,
> HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch,
> HBASE-19008-6.patch, HBASE-19008-7.patch, HBASE-19008-8.patch,
> HBASE-19008-9.patch, HBASE-19008.patch
>
>
> In HBASE-15410, [~mdrob] reminded me that Filter implementations may not
> write {{equals}} or {{hashCode}} method(s).
> This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock
> Filter implementations such as KeyOnlyFilter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[
https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570012#comment-16570012
]
Ted Yu edited comment on HBASE-19008 at 8/6/18 10:33 AM:
-
Please fix the following compilation errors:
{code}
[ERROR]
/testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithOR.java:[413,24]
[ArrayHashCode] hashcode method on array does not hash array contents
(see http://errorprone.info/bugpattern/ArrayHashCode)
Did you mean 'return
Objects.hash(this.prevFilterRCList,this.prevCellList,Arrays.hashCode(this.filters.toArray()));'?
[ERROR]
/testptch/hbase/hbase-spark/src/main/java/org/apache/hadoop/hbase/spark/SparkSQLPushDownFilter.java:[307,33]
[ArrayHashCode] hashcode method on array does not hash array contents
(see http://errorprone.info/bugpattern/ArrayHashCode)
Did you mean 'hash=hash+Arrays.hashCode(val);'?
{code}
Please also address findbugs and checkstyle warnings.
The above comment was made before seeing patch v5.
was (Author: yuzhih...@gmail.com):
Please fix the following compilation errors:
{code}
[ERROR]
/testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithOR.java:[413,24]
[ArrayHashCode] hashcode method on array does not hash array contents
(see http://errorprone.info/bugpattern/ArrayHashCode)
Did you mean 'return
Objects.hash(this.prevFilterRCList,this.prevCellList,Arrays.hashCode(this.filters.toArray()));'?
[ERROR]
/testptch/hbase/hbase-spark/src/main/java/org/apache/hadoop/hbase/spark/SparkSQLPushDownFilter.java:[307,33]
[ArrayHashCode] hashcode method on array does not hash array contents
(see http://errorprone.info/bugpattern/ArrayHashCode)
Did you mean 'hash=hash+Arrays.hashCode(val);'?
{code}
Please also address findbugs and checkstyle warnings.
> Add missing equals or hashCode method(s) to stock Filter implementations
>
>
> Key: HBASE-19008
> URL: https://issues.apache.org/jira/browse/HBASE-19008
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: liubangchen
>Priority: Major
> Labels: filter
> Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch,
> HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch,
> HBASE-19008.patch
>
>
> In HBASE-15410, [~mdrob] reminded me that Filter implementations may not
> write {{equals}} or {{hashCode}} method(s).
> This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock
> Filter implementations such as KeyOnlyFilter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[
https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565344#comment-16565344
]
Reid Chan edited comment on HBASE-19008 at 8/1/18 1:47 PM:
---
Any criterion about which Filter should implement those methods?
Listed filters are only a subset.
!Filters.png!
was (Author: reidchan):
Any criterion about which Filter should implement those methods?
Listed filters are only a subset.
> Add missing equals or hashCode method(s) to stock Filter implementations
>
>
> Key: HBASE-19008
> URL: https://issues.apache.org/jira/browse/HBASE-19008
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: liubangchen
>Priority: Major
> Labels: filter
> Attachments: Filters.png, HBASE-19008.patch
>
>
> In HBASE-15410, [~mdrob] reminded me that Filter implementations may not
> write {{equals}} or {{hashCode}} method(s).
> This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock
> Filter implementations such as KeyOnlyFilter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[
https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565142#comment-16565142
]
Ted Yu edited comment on HBASE-19008 at 8/1/18 1:40 PM:
Liubang:
Can you change the status to Patch Available for QA run ?
thanks
was (Author: yuzhih...@gmail.com):
Liubang:
Can you attach the patch here for QA run ?
thanks
> Add missing equals or hashCode method(s) to stock Filter implementations
>
>
> Key: HBASE-19008
> URL: https://issues.apache.org/jira/browse/HBASE-19008
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: liubangchen
>Priority: Major
> Labels: filter
> Attachments: HBASE-19008.patch
>
>
> In HBASE-15410, [~mdrob] reminded me that Filter implementations may not
> write {{equals}} or {{hashCode}} method(s).
> This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock
> Filter implementations such as KeyOnlyFilter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[
https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564927#comment-16564927
]
liubangchen edited comment on HBASE-19008 at 8/1/18 8:11 AM:
-
[~Jan Hentschel] Thanks .
Add equals and hashCode for Filters as below:
- ColumnPaginationFilter
- ColumnCountGetFilter
- MultiRowRangeFilter
- KeyOnlyFilter
- MultipleColumnPrefixFilter
- ColumnPrefixFilter
- SingleColumnValueFilter
- FuzzyRowFilter
- FirstKeyOnlyFilter
- RandomRowFilter
- PrefixFilter
- CompareFilter -
- FilterList
- TimestampsFilter
- ColumnRangeFilter
Code Review Link: https://reviews.apache.org/r/68079/
was (Author: liubangchen):
[~Jan Hentschel] Thanks .
Add equals and hashCode for Filters as below:
- ColumnPaginationFilter
- ColumnCountGetFilter
- MultiRowRangeFilter
- KeyOnlyFilter
- MultipleColumnPrefixFilter
- ColumnPrefixFilter
- SingleColumnValueFilter
- FuzzyRowFilter
- FirstKeyOnlyFilter
- RandomRowFilter
- PrefixFilter
- CompareFilter -
FilterList
- TimestampsFilter
- ColumnRangeFilter
Code Review Link: https://reviews.apache.org/r/68079/
> Add missing equals or hashCode method(s) to stock Filter implementations
>
>
> Key: HBASE-19008
> URL: https://issues.apache.org/jira/browse/HBASE-19008
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: liubangchen
>Priority: Major
> Labels: filter
>
> In HBASE-15410, [~mdrob] reminded me that Filter implementations may not
> write {{equals}} or {{hashCode}} method(s).
> This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock
> Filter implementations such as KeyOnlyFilter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
