[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848543#comment-13848543 ] Lars Hofhansl commented on HBASE-10048: --- Thanks Liu and Ted. > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.94.15, 0.99.0 > > Attachments: 10048.096.v4.txt, HBASE-10048-0.94-v1.diff, > HBASE-10048-0.94-v2.diff, HBASE-10048-0.94-v3.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff, HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848541#comment-13848541 ] Hudson commented on HBASE-10048: SUCCESS: Integrated in HBase-0.94-security #360 (See [https://builds.apache.org/job/HBase-0.94-security/360/]) HBASE-10048 Add hlog number metric in regionserver (tedyu: rev 1550997) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtilsForTests.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.94.15, 0.99.0 > > Attachments: 10048.096.v4.txt, HBASE-10048-0.94-v1.diff, > HBASE-10048-0.94-v2.diff, HBASE-10048-0.94-v3.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff, HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848537#comment-13848537 ] Hudson commented on HBASE-10048: SUCCESS: Integrated in HBase-0.94 #1227 (See [https://builds.apache.org/job/HBase-0.94/1227/]) HBASE-10048 Add hlog number metric in regionserver (tedyu: rev 1550997) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtilsForTests.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.94.15, 0.99.0 > > Attachments: 10048.096.v4.txt, HBASE-10048-0.94-v1.diff, > HBASE-10048-0.94-v2.diff, HBASE-10048-0.94-v3.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff, HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846088#comment-13846088 ] Lars Hofhansl commented on HBASE-10048: --- [~lshmouse], are you still planning a new 0.94 patch? > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.99.0 > > Attachments: 10048.096.v4.txt, HBASE-10048-0.94-v1.diff, > HBASE-10048-0.94-v2.diff, HBASE-10048-trunk-v1.diff, > HBASE-10048-trunk-v2.diff, HBASE-10048-trunk-v3.diff, > HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842372#comment-13842372 ] Hudson commented on HBASE-10048: SUCCESS: Integrated in hbase-0.96-hadoop2 #144 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/144/]) HBASE-10048 Add hlog number metric in regionserver (stack: rev 1548917) * /hbase/branches/0.96/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java * /hbase/branches/0.96/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java * /hbase/branches/0.96/hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * /hbase/branches/0.96/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtilsForTests.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.99.0 > > Attachments: 10048.096.v4.txt, HBASE-10048-0.94-v1.diff, > HBASE-10048-0.94-v2.diff, HBASE-10048-trunk-v1.diff, > HBASE-10048-trunk-v2.diff, HBASE-10048-trunk-v3.diff, > HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842353#comment-13842353 ] Hudson commented on HBASE-10048: SUCCESS: Integrated in hbase-0.96 #218 (See [https://builds.apache.org/job/hbase-0.96/218/]) HBASE-10048 Add hlog number metric in regionserver (stack: rev 1548917) * /hbase/branches/0.96/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java * /hbase/branches/0.96/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java * /hbase/branches/0.96/hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * /hbase/branches/0.96/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtilsForTests.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.99.0 > > Attachments: 10048.096.v4.txt, HBASE-10048-0.94-v1.diff, > HBASE-10048-0.94-v2.diff, HBASE-10048-trunk-v1.diff, > HBASE-10048-trunk-v2.diff, HBASE-10048-trunk-v3.diff, > HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842230#comment-13842230 ] stack commented on HBASE-10048: --- Committed the 0.96 patch. Leaving open for 0.94 patch. Thanks [~liushaohui] > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.99.0 > > Attachments: 10048.096.v4.txt, HBASE-10048-0.94-v1.diff, > HBASE-10048-0.94-v2.diff, HBASE-10048-trunk-v1.diff, > HBASE-10048-trunk-v2.diff, HBASE-10048-trunk-v3.diff, > HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[
https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842225#comment-13842225
]
Hadoop QA commented on HBASE-10048:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12617555/10048.096.v4.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 18 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8086//console
This message is automatically generated.
> Add hlog number metric in regionserver
> --
>
> Key: HBASE-10048
> URL: https://issues.apache.org/jira/browse/HBASE-10048
> Project: HBase
> Issue Type: Improvement
> Components: metrics
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Fix For: 0.98.0, 0.96.1, 0.99.0
>
> Attachments: 10048.096.v4.txt, HBASE-10048-0.94-v1.diff,
> HBASE-10048-0.94-v2.diff, HBASE-10048-trunk-v1.diff,
> HBASE-10048-trunk-v2.diff, HBASE-10048-trunk-v3.diff,
> HBASE-10048-trunk-v4.diff
>
>
> Add hlog number metric in regionserver.
> We can use this metric to alert about memstore flush because of too many
> hlogs.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842179#comment-13842179 ] Hudson commented on HBASE-10048: FAILURE: Integrated in hbase-0.98-hadoop2 #2 (See [https://builds.apache.org/job/hbase-0.98-hadoop2/2/]) HBASE-10048 Add hlog number metric in regionserver (stack: rev 1548769) * /hbase/branches/0.98/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java * /hbase/branches/0.98/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java * /hbase/branches/0.98/hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * /hbase/branches/0.98/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtilsForTests.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.99.0 > > Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff, HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842167#comment-13842167 ] Liu Shaohui commented on HBASE-10048: - [~lhofhansl] The total blog size metric which is in trunk patch is not contained in 0.94 patch. Please wait and I will update the 0.94 patch. > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.99.0 > > Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff, HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842155#comment-13842155 ] Hudson commented on HBASE-10048: SUCCESS: Integrated in HBase-TRUNK #4715 (See [https://builds.apache.org/job/HBase-TRUNK/4715/]) HBASE-10048 Add hlog number metric in regionserver (stack: rev 1548768) * /hbase/trunk/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java * /hbase/trunk/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java * /hbase/trunk/hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * /hbase/trunk/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtilsForTests.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.99.0 > > Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff, HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842084#comment-13842084 ] stack commented on HBASE-10048: --- [~lhofhansl] I added it to trunk. Will add to 0.94 after I shoehorn it into 0.96 (morrow) > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.99.0 > > Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff, HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841963#comment-13841963 ] Lars Hofhansl commented on HBASE-10048: --- That is nice. And something we would monitor. +1 for 0.94. Needs to be in trunk (0.99 now) as well, right? > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.99.0 > > Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff, HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841948#comment-13841948 ] stack commented on HBASE-10048: --- Applied to trunk and to 0.98. 0.96 not going in. Will fix it later. [~lhofhansl] You want this? Its nice. > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.99.0 > > Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff, HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841937#comment-13841937 ] Elliott Clark commented on HBASE-10048: --- +1 thanks > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.99.0 > > Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff, HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841904#comment-13841904 ] stack commented on HBASE-10048: --- +1 Patch is great. [~eclark] Please bless and then I'll commit. > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.98.0, 0.96.1, 0.99.0 > > Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff, HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840914#comment-13840914 ] Liu Shaohui commented on HBASE-10048: - [~zjushch] [~yuzhih...@gmail.com] [~v.himanshu] Anyone helps to push this issue? thx > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff, HBASE-10048-trunk-v4.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[
https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837655#comment-13837655
]
Hadoop QA commented on HBASE-10048:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12616734/HBASE-10048-trunk-v4.diff
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 18 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8050//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8050//console
This message is automatically generated.
> Add hlog number metric in regionserver
> --
>
> Key: HBASE-10048
> URL: https://issues.apache.org/jira/browse/HBASE-10048
> Project: HBase
> Issue Type: Improvement
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff,
> HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff,
> HBASE-10048-trunk-v3.diff, HBASE-10048-trunk-v4.diff
>
>
> Add hlog number metric in regionserver.
> We can use this metric to alert about memstore flush because of too many
> hlogs.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[
https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837471#comment-13837471
]
Liu Shaohui commented on HBASE-10048:
-
{quote}
(I'd avoid doing the "numLogs +1" stuff, as it looks brittle). IMO, it is OKAY
to show the rolled WALs and leave out the current one. And, name the metrics
accordingly. What do you think Liu Shaohui?
{quote}
I agree. thx.
I will update the patch later.
> Add hlog number metric in regionserver
> --
>
> Key: HBASE-10048
> URL: https://issues.apache.org/jira/browse/HBASE-10048
> Project: HBase
> Issue Type: Improvement
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff,
> HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff,
> HBASE-10048-trunk-v3.diff
>
>
> Add hlog number metric in regionserver.
> We can use this metric to alert about memstore flush because of too many
> hlogs.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837470#comment-13837470 ] Liu Shaohui commented on HBASE-10048: - [~zjushch][~v.himanshu] First, it's easy to get the accurate total size of all hlog files with this patch, so we don't need to guess it. Secondly, the accurate log size metric is necessary and very useful to optimize the failover time. > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836177#comment-13836177 ] chunhui shen commented on HBASE-10048: -- bq,couldn't just we make an intelligent "guess" about log size rather than creating a separate metrics for the same. I know the hlog size is about 95% of block size in normal case, but we have seen the hlog file size much bigger than block size in abnormal case. I think such a metric could show the unhealthy scenario timely, avoiding the hlog size become very huge. Maybe we only need the metric for the max size of current hlog. [~liushaohui] Any thought about the log size metric? > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836076#comment-13836076 ] Himanshu Vashishtha commented on HBASE-10048: - +1 to the idea of exposing log numbers, and thanks for the patch. (I'd avoid doing the "numLogs +1" stuff, as it looks brittle). IMO, it is OKAY to show the rolled WALs and leave out the current one. And, name the metrics accordingly. What do you think [~lshmouse]? [~zjushch]: Pardon for chiming in late; but couldn't just we make an intelligent "guess" about log size rather than creating a separate metrics for the same. https://github.com/apache/hbase/blob/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java#L360 > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff, > HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, > HBASE-10048-trunk-v3.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[
https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835389#comment-13835389
]
Hadoop QA commented on HBASE-10048:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12616374/HBASE-10048-trunk-v3.diff
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8030//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8030//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8030//console
This message is automatically generated.
> Add hlog number metric in regionserver
> --
>
> Key: HBASE-10048
> URL: https://issues.apache.org/jira/browse/HBASE-10048
> Project: HBase
> Issue Type: Improvement
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff,
> HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff,
> HBASE-10048-trunk-v3.diff
>
>
> Add hlog number metric in regionserver.
> We can use this metric to alert about memstore flush because of too many
> hlogs.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[
https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835334#comment-13835334
]
Liu Shaohui commented on HBASE-10048:
-
It's the problem of code. getFileStatus should be before archiveLogFile
{quote}
- archiveLogFile(p);
this.totalLogSize.addAndGet(-this.fs.getFileStatus(p).getLen());
+ archiveLogFile(p);
{quote}
> Add hlog number metric in regionserver
> --
>
> Key: HBASE-10048
> URL: https://issues.apache.org/jira/browse/HBASE-10048
> Project: HBase
> Issue Type: Improvement
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff,
> HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff
>
>
> Add hlog number metric in regionserver.
> We can use this metric to alert about memstore flush because of too many
> hlogs.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[
https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835332#comment-13835332
]
Hadoop QA commented on HBASE-10048:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12616354/HBASE-10048-trunk-v2.diff
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS
org.apache.hadoop.hbase.client.TestAdmin
org.apache.hadoop.hbase.regionserver.wal.TestHLog
org.apache.hadoop.hbase.replication.TestReplicationKillSlaveRS
org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8028//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8028//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8028//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8028//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8028//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8028//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8028//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8028//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8028//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8028//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8028//console
This message is automatically generated.
> Add hlog number metric in regionserver
> --
>
> Key: HBASE-10048
> URL: https://issues.apache.org/jira/browse/HBASE-10048
> Project: HBase
> Issue Type: Improvement
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff,
> HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff
>
>
> Add hlog number metric in regionserver.
> We can use this metric to alert about memstore flush because of too many
> hlogs.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[
https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835169#comment-13835169
]
Liu Shaohui commented on HBASE-10048:
-
[~zjushch]
{quote}
Total size of all logs seems useful too since one hlog would be very big in
normal case
{quote}
Yes. I will add this metric too. Thx [~zjushch]
> Add hlog number metric in regionserver
> --
>
> Key: HBASE-10048
> URL: https://issues.apache.org/jira/browse/HBASE-10048
> Project: HBase
> Issue Type: Improvement
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff,
> HBASE-10048-trunk-v1.diff
>
>
> Add hlog number metric in regionserver.
> We can use this metric to alert about memstore flush because of too many
> hlogs.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[
https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835141#comment-13835141
]
chunhui shen commented on HBASE-10048:
--
{code}
+ // +1 for the current log
+ numHLogFiles = regionServer.hlog.getNumLogFiles() + 1;
{code}
Need +2 for MetaServer.
But I think no addition is acceptable here.
Total size of all logs seems useful too since one hlog would be very big in
normal case
Other looks good to me
> Add hlog number metric in regionserver
> --
>
> Key: HBASE-10048
> URL: https://issues.apache.org/jira/browse/HBASE-10048
> Project: HBase
> Issue Type: Improvement
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff,
> HBASE-10048-trunk-v1.diff
>
>
> Add hlog number metric in regionserver.
> We can use this metric to alert about memstore flush because of too many
> hlogs.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13834638#comment-13834638 ] Ted Yu commented on HBASE-10048: Trunk patch please. > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13834505#comment-13834505 ] Ted Yu commented on HBASE-10048: Okay. Can you attach trunk patch ? > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10048-0.94-v1.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13834478#comment-13834478 ] Liu Shaohui commented on HBASE-10048: - [~yuzhih...@gmail.com] hlog.getNumLogFiles() only returns the number of all log files but the current one, so we need to add one for the current log. Maybe, it's clearer to add 1 in the method of hlog.getNumLogFiles(). > Add hlog number metric in regionserver > -- > > Key: HBASE-10048 > URL: https://issues.apache.org/jira/browse/HBASE-10048 > Project: HBase > Issue Type: Improvement >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10048-0.94-v1.diff > > > Add hlog number metric in regionserver. > We can use this metric to alert about memstore flush because of too many > hlogs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver
[
https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833985#comment-13833985
]
Ted Yu commented on HBASE-10048:
{code}
+this.metrics.hlogfiles.set(this.hlog.getNumLogFiles() + 1);
{code}
Why '+1' is needed ?
Trunk patch is welcome.
> Add hlog number metric in regionserver
> --
>
> Key: HBASE-10048
> URL: https://issues.apache.org/jira/browse/HBASE-10048
> Project: HBase
> Issue Type: Improvement
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Attachments: HBASE-10048-0.94-v1.diff
>
>
> Add hlog number metric in regionserver.
> We can use this metric to alert about memstore flush because of too many
> hlogs.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
