[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-04-18 Thread Nicolas Liochon (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973936#comment-13973936
 ] 

Nicolas Liochon commented on HBASE-10156:
-

The first fix you propose seems very simple (mine was more complex). I'm going 
to create a jira with this.

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-04-17 Thread Nicolas Liochon (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972377#comment-13972377
 ] 

Nicolas Liochon commented on HBASE-10156:
-

bq. What you seeing? Slow down?
Not yet. I'm tracking the latency peaks on the write path.

bq. If a sync thread came back between your write and just before you go to 
call sync
There is still a part that I don't understand here:

Suppose that we have 4 writes by 4 different clients w1, w2, w3, w4. Scenario 
would be
w1 gets into the WAL; not sync
w2 gets into the WAL; not sync
w2 finishes: for this it needs to sync, to w1  are now sync. Client 2 is done
w3 gets into the WAL; not sync
w1 wants to finish. it calls sync, this syncs on w3

that's this last point I'm not sure about? When we sync for w1, do we skip 
immediately, or we do sync on w3 because it made it into the WAL in the 
meantime?








 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-04-17 Thread Himanshu Vashishtha (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972870#comment-13972870
 ] 

Himanshu Vashishtha commented on HBASE-10156:
-

When you invoke a sync, you would get a new entry in the RingBuffer, i.e., you 
create a new SyncFuture object with a higher sequence number. So, in the above 
case, when w1 calls sync, it would also sync w3 entry.

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-04-17 Thread Nicolas Liochon (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972940#comment-13972940
 ] 

Nicolas Liochon commented on HBASE-10156:
-

Thanks, [~himan...@cloudera.com]. I think we should optimize this for no 
syncing w3 if we only need w1. I will give it a try. is that ok for you, 
[~saint@gmail.com]?

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-04-17 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973214#comment-13973214
 ] 

stack commented on HBASE-10156:
---

[~liochon] You have a point.

We could do this:

@@ -1486,6 +1488,9 @@ class FSHLog implements HLog, Syncable {
   @Override
   // txid is unused.  txid is an implementation detail.  It should not leak 
outside of WAL.
   public void sync(long txid) throws IOException {
+// If this edit has been sync'd already, we can just return.  This is 
dangerous.  Can only
+// be for a single edit or for a sequence of edits written by this thread.
+if (this.highestSyncedSequence.get()  txid) return;
 publishSyncThenBlockOnCompletion();
   }

This is all before the ringbuffer.  It would be hard to do on other side of the 
ringbuffer unless we carried this seqid -- which would be different from the 
ringbuffers' current seqid -- over to the other side and then on the other side 
did something similar (would be a bit more involved on other side since context 
would be blown).

Good one.

(Would have to undo my 'deprecation' of the sync that takes a txid in a more 
complete patch).

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-04-17 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973215#comment-13973215
 ] 

stack commented on HBASE-10156:
---

On other side of the ring buffer would be difficult as things are now as we 
don't keep track of the seqids we've 'appended' to the WAL (this we could 
change and it is changed in Himanshu's patch that introduces switching WALs).

Thanks for taking a look here [~nkeywal]

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-04-16 Thread Nicolas Liochon (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13971943#comment-13971943
 ] 

Nicolas Liochon commented on HBASE-10156:
-

[~saint@gmail.com] A quick followup question, after I looked at the code 
with [~devaraj]:

We sync .meta. in the initial phase 'appendNoSync' in trunk. This seems new:
0.98
{code}
if (doSync 
(info.isMetaRegion() ||
!htd.isDeferredLogFlush())) {
{code}

trunk
{code}
if (doSync || info.isMetaRegion()) publishSyncThenBlockOnCompletion();
{code}

As well, if I read the code correctly, we're not taking into account the txId 
when we sync? So if there is a stream of writes, we will wait for the sync of 
the last writes, even if our edits are already in?

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-04-16 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972124#comment-13972124
 ] 

stack commented on HBASE-10156:
---

bq. We sync .meta. in the initial phase 'appendNoSync' in trunk. 

What are you seeing lads?  Ain't this doing same as 0.98 did; i.e. sync and not 
return until sync completes?  Or you seeing double sync call per meta write?

The txid is no longer exposed, that is right.  It is kept internal to the 
implementation.

bq. So if there is a stream of writes, we will wait for the sync of the last 
writes, even if our edits are already in?

There is preemption.  If a sync thread came back between your write and just 
before you go to call sync, we'll skip the sync call.  Search // 
See if we can process any syncfutures BEFORE we go sync.

What is the problem you lads are seeing?  (I've been around this code a bit so 
hopefully can help).




 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-04-16 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972132#comment-13972132
 ] 

stack commented on HBASE-10156:
---

bq. What are you seeing lads? Ain't this doing same as 0.98 did; i.e. sync and 
not return until sync completes? Or you seeing double sync call per meta write?

I see now.  Should be: doSync  info.isMetaRegion() instead of doSync || 
info.isMetaRegion()

Just removing !htd.isDeferredLogFlush() and parens ended up adding a sync.

Good one.

What you seeing?  Slow down?

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-04-16 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972136#comment-13972136
 ] 

stack commented on HBASE-10156:
---

I made HBASE-11009 and put a patch up there.

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-01-27 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883059#comment-13883059
 ] 

Andrew Purtell commented on HBASE-10156:


[~stack], since parent went into 0.98.0RC0, what do you think about this for 
0.98.0RC1 now that it's in?

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-01-27 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883174#comment-13883174
 ] 

stack commented on HBASE-10156:
---

[~apurtell] I think it too radical a change for 0.98.  [~himan...@cloudera.com] 
made me change the subject to be FSHLog refactor.  The parent issue bought us a 
bunch of speedup when contention (at cost of some small slow down when low 
contention).  That is sweet enough for a major release?  What you reckon boss?

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-01-27 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883178#comment-13883178
 ] 

Andrew Purtell commented on HBASE-10156:


Probably this issue should be made a first class issue rather than a subtask.

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-01-27 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883177#comment-13883177
 ] 

Andrew Purtell commented on HBASE-10156:


bq.  I think it too radical a change for 0.98.

Ok, this opinion is what I was after.

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-01-27 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883206#comment-13883206
 ] 

stack commented on HBASE-10156:
---

bq. Probably this issue should be made a first class issue rather than a 
subtask.

Tried.  Can only move to be a subtask of another issue.  Rather than make a new 
parent to host this one, will just leave as is.

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-01-26 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1388#comment-1388
 ] 

Hudson commented on HBASE-10156:


FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #65 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/65/])
HBASE-10156 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low 
contention) (stack: rev 1561450)
* 
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
* 
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FailedLogCloseException.java
* 
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FailedSyncBeforeLogCloseException.java
* /hbase/trunk/hbase-server/pom.xml
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogFactory.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtil.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/RingBufferTruck.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SyncFuture.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestParallelPut.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestDurability.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollingNoCluster.java
* /hbase/trunk/pom.xml


 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-01-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882043#comment-13882043
 ] 

Hadoop QA commented on HBASE-10156:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12625215/10156v21.txt
  against trunk revision .
  ATTACHMENT ID: 12625215

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 30 new 
or modified tests.

{color:red}-1 hadoop1.0{color}.  The patch failed to compile against the 
hadoop 1.0 profile.
Here is snippet of errors:
{code}[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project hbase-server: Compilation failure: Compilation failure:
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java:[600,8]
 cannot find symbol
[ERROR] symbol  : variable currentFilenum
[ERROR] location: class org.apache.hadoop.hbase.regionserver.wal.FSHLog
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java:[602,32]
 cannot find symbol
[ERROR] symbol  : variable currentFilenum
--
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project hbase-server: Compilation failure
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
--
Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation 
failure
at 
org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:729)
at org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:128)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
... 19 more{code}

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8515//console

This message is automatically generated.

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v3.txt, 10156v4.txt, 10156v5.txt, 10156v6.txt, 10156v7.txt, 10156v9.txt, 
 Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-01-25 Thread Himanshu Vashishtha (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882087#comment-13882087
 ] 

Himanshu Vashishtha commented on HBASE-10156:
-

+1 (non binding, though) :) Great stuff.
Thanks Stack.

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 10156v6.txt, 
 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-01-25 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882097#comment-13882097
 ] 

Andrew Purtell commented on HBASE-10156:


I have looked at a couple of revisions of this patch - it is a fat change that 
I'm not going to be able to deeply understand ahead of commit. However I've 
looked at reviews from those who've spent the necessary time (Himanshu, Ram, 
etc.) and the response to those reviews and this looks ready to try. I'm +1 if 
one of those guys are also of that opinion, and I see Himanshu is.

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 10156v6.txt, 
 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-01-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882102#comment-13882102
 ] 

Hadoop QA commented on HBASE-10156:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12625221/10156v21.txt
  against trunk revision .
  ATTACHMENT ID: 12625221

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 30 new 
or modified tests.

{color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

{color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 
1.1 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:red}-1 site{color}.  The patch appears to cause mvn site goal to 
fail.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

 {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8516//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8516//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8516//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8516//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8516//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8516//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8516//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8516//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8516//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8516//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8516//console

This message is automatically generated.

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 10156v6.txt, 
 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-01-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882148#comment-13882148
 ] 

Hadoop QA commented on HBASE-10156:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12625231/10156v21.txt
  against trunk revision .
  ATTACHMENT ID: 12625231

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 30 new 
or modified tests.

{color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

{color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 
1.1 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:red}-1 site{color}.  The patch appears to cause mvn site goal to 
fail.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8520//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8520//console

This message is automatically generated.

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-01-25 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882171#comment-13882171
 ] 

stack commented on HBASE-10156:
---

Let me commit this then. Thanks @apurtell for +1 (and @himanshu)

 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10156) FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)

2014-01-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882217#comment-13882217
 ] 

Hudson commented on HBASE-10156:


SUCCESS: Integrated in HBase-TRUNK #4856 (See 
[https://builds.apache.org/job/HBase-TRUNK/4856/])
HBASE-10156 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low 
contention) (stack: rev 1561450)
* 
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
* 
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FailedLogCloseException.java
* 
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FailedSyncBeforeLogCloseException.java
* /hbase/trunk/hbase-server/pom.xml
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogFactory.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtil.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/RingBufferTruck.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SyncFuture.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestParallelPut.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestDurability.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollingNoCluster.java
* /hbase/trunk/pom.xml


 FSHLog Refactor (WAS - Fix up the HBASE-8755 slowdown when low contention)
 ---

 Key: HBASE-10156
 URL: https://issues.apache.org/jira/browse/HBASE-10156
 Project: HBase
  Issue Type: Sub-task
  Components: wal
Reporter: stack
Assignee: stack
 Fix For: 0.99.0

 Attachments: 10156.txt, 10156v10.txt, 10156v11.txt, 10156v12.txt, 
 10156v12.txt, 10156v13.txt, 10156v16.txt, 10156v17.txt, 10156v18.txt, 
 10156v19.txt, 10156v2.txt, 10156v20.txt, 10156v20.txt, 10156v21.txt, 
 10156v21.txt, 10156v21.txt, 10156v3.txt, 10156v4.txt, 10156v5.txt, 
 10156v6.txt, 10156v7.txt, 10156v9.txt, Disrupting.java


 HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)