[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[
https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305788#comment-16305788
]
Hadoop QA commented on HBASE-10255:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 4m
51s{color} | {color:red} branch has 13 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
41s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
9s{color} | {color:red} hbase-protocol in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 9s{color}
| {color:red} hbase-protocol in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
9s{color} | {color:red} hbase-protocol: The patch generated 2 new + 0 unchanged
- 0 fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 4m
42s{color} | {color:red} patch has 13 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m
40s{color} | {color:red} The patch causes 12 errors with Hadoop v2.6.5. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m
43s{color} | {color:red} The patch causes 12 errors with Hadoop v2.7.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m
54s{color} | {color:red} The patch causes 12 errors with Hadoop v3.0.0. {color}
|
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
11s{color} | {color:red} hbase-protocol in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 10s{color}
| {color:red} hbase-protocol in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 53s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-10255 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12620905/alternate_lis.txt |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ba6d8baa8620 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13861077#comment-13861077 ] Hudson commented on HBASE-10255: SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #38 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/38/]) HBASE-10255 Remove dependency on LimitInputStream - revert, discussion on-going (Tedyu: rev 1554870) * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860966#comment-13860966 ] Hudson commented on HBASE-10255: FAILURE: Integrated in HBase-TRUNK #4780 (See [https://builds.apache.org/job/HBase-TRUNK/4780/]) HBASE-10255 Remove dependency on LimitInputStream - revert, discussion on-going (Tedyu: rev 1554870) * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860773#comment-13860773 ] Hudson commented on HBASE-10255: FAILURE: Integrated in HBase-0.98 #49 (See [https://builds.apache.org/job/HBase-0.98/49/]) HBASE-10255 Remove dependency on LimitInputStream - revert (Tedyu: rev 1554869) * /hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860734#comment-13860734 ] Hudson commented on HBASE-10255: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #46 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/46/]) HBASE-10255 Remove dependency on LimitInputStream - revert (Tedyu: rev 1554869) * /hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860560#comment-13860560 ] Ted Yu commented on HBASE-10255: Should have provided more background on the perf test: This was done on a 5-RS cluster where hadoop 2.2 was deployed. Here was the command line used for both tests: bin/hbase org.apache.hadoop.hbase.regionserver.wal.HLogPerformanceEvaluation -path hdfs://hor12n22.gq1.ygridcore.net:8020/tmp -threads 10 -roll 1000 -verify I obtained the first stat using 0.96 Then I switched jars recompiled with patch v2 and obtained the second set of numbers. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860532#comment-13860532 ] stack commented on HBASE-10255: --- -1 The justification is irrational so not to be trusted. The context in hbase is pb (pb uses pb LIS). In hadoop the quoted use is web and log aggregation. Irrelevant. Test numbers look good but I don't trust them given all that has proceeded here and they are provided out of thin air: nothing on whether with or without hdfs, on cluster or not. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860506#comment-13860506 ] Ted Yu commented on HBASE-10255: Reverted from 0.98 and trunk for further discussion. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860426#comment-13860426 ] Andrew Purtell commented on HBASE-10255: Since there is a -1 on the current patch, I will back it out of 0.98 branch if the disagreement is not shortly resolved in favor of the current patch. Thanks guys. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860407#comment-13860407 ] Ted Yu commented on HBASE-10255: BoundedInputStream is used in the following classes in hadoop: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/ByteRangeInputStream.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java I searched for LimitInputStream in hadoop but didn't find any occurrence. I did some performance testing. Below was the comparison: --0.96.1.1 org.apache.hadoop.hbase.regionserver.wal.HLogPerformanceEvaluation: append: count = 762367720 mean rate = 2335.76 bytes/ms 1-minute rate = 2362.35 bytes/ms 5-minute rate = 1967.47 bytes/ms 15-minute rate = 1562.28 bytes/ms syncMeter: count = 1204781 mean rate = 3.69 syncs/ms 1-minute rate = 3.70 syncs/ms 5-minute rate = 3.08 syncs/ms 15-minute rate = 2.42 syncs/ms -with patch: append: count = 983061720 mean rate = 2337.51 bytes/ms 1-minute rate = 2360.75 bytes/ms 5-minute rate = 2117.03 bytes/ms 15-minute rate = 1757.53 bytes/ms syncMeter: count = 1554486 mean rate = 3.70 syncs/ms 1-minute rate = 3.73 syncs/ms 5-minute rate = 3.34 syncs/ms 15-minute rate = 2.76 syncs/ms > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860376#comment-13860376 ] stack commented on HBASE-10255: --- This issue remains unresolved though it has had a patch applied to a few branches. -1 on current patch as applied since no supporting benchmark that new dependency does not slow throughput in a critical section. I've also taken the time to attach an alternative suggestion that would have us back on the original class w/o need of import from a 'foreign' domain. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859342#comment-13859342 ] stack commented on HBASE-10255: --- bq. The checkin of hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java was not done in HBASE-10174. You misread. bq. I was just addressing your review comments I said nothing about LIS in previous reviews. If you would like me to give you direction on what I think you should work on rather than you guessing (wrongly) my intent, just ask. bq. I have helped in producing 0.98 release I'd suggest you do more of the above less of the trivial especially when the trivial pulls in others trying to work on higher priority issues. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859319#comment-13859319 ] Hudson commented on HBASE-10255: SUCCESS: Integrated in HBase-TRUNK #4770 (See [https://builds.apache.org/job/HBase-TRUNK/4770/]) HBASE-10255 Remove dependency on LimitInputStream (tedyu: rev 1554236) * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859217#comment-13859217 ] Hudson commented on HBASE-10255: FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #29 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/29/]) HBASE-10255 Remove dependency on LimitInputStream (tedyu: rev 1554236) * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858950#comment-13858950 ] Hudson commented on HBASE-10255: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #41 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/41/]) HBASE-10255 Remove dependency on LimitInputStream (tedyu: rev 1554240) * /hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858941#comment-13858941 ] Hudson commented on HBASE-10255: SUCCESS: Integrated in HBase-0.98 #44 (See [https://builds.apache.org/job/HBase-0.98/44/]) HBASE-10255 Remove dependency on LimitInputStream (tedyu: rev 1554240) * /hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858931#comment-13858931 ] Ted Yu commented on HBASE-10255: bq. there there was a wrong-headed attempt at adding a guava class to hbase core. The checkin of hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java was not done in HBASE-10174. I was just addressing your review comments. The priority of this JIRA was set according to the tone of your comment from HBASE-10174. bq. on issues that it is easy to discern how they move the project forward. Understood your point. I have helped in producing 0.98 release. See the following example where Andrew spent much time hunting down the cause: HBASE-10142 TestLogRolling#testLogRollOnDatanodeDeath test failure > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858929#comment-13858929 ] stack commented on HBASE-10255: --- Your interpretation of my remark is off. You apply a statement of mine about an action of yours -- adding a guava class to hbase core to accommodate and upgrade -- from a different issue to a completely different context, one that is of the past and motivated likely because LIS is protected in pb Nor did I ask you to go through code base looking for offenders. So, no performance compare though you have changed a critical class? > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858918#comment-13858918 ] Ted Yu commented on HBASE-10255: bq. Does this change come of just roaming the code randomly? No. The latest change is to address your comment from HBASE-10174: bq. I just have a problem with adding classes from said library to hbase core to make it happen. bq. the need for an upgrade There is no upgrade in patch v2. bq. one used WAL writing The InputStream class is used in reading. See ProtobufLogReader bq. For sure it works exactly the same way? Yes. I compared the source code of hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java and http://commons.apache.org/proper/commons-io/apidocs/src-html/org/apache/commons/io/input/BoundedInputStream.html > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858908#comment-13858908 ] stack commented on HBASE-10255: --- My question was 'Out of interest, what brings on the need for an upgrade and the need to remove LIS? Have you run into an issue that requires this?' It was not answered before commit. Does this change come of just roaming the code randomly? You changed a fundamental class -- one used WAL writing -- w/ one from a different library altogether with perhaps different motivations. Any performance regression seen? For sure it works exactly the same way? > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858831#comment-13858831 ] Ted Yu commented on HBASE-10255: Integrated to 0.98 and trunk. Thanks for the reviews. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[
https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858512#comment-13858512
]
Hadoop QA commented on HBASE-10255:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12620788/10255-v2.txt
against trunk revision .
ATTACHMENT ID: 12620788
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8300//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8300//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8300//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8300//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8300//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8300//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8300//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8300//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8300//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8300//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8300//console
This message is automatically generated.
> Remove dependency on LimitInputStream
> -
>
> Key: HBASE-10255
> URL: https://issues.apache.org/jira/browse/HBASE-10255
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 0.98.0, 0.99.0
>
> Attachments: 10255-v1.txt, 10255-v2.txt
>
>
> LimitInputStream has always been a @Beta API and beta apis aren't guaranteed
> to remain stable over such a long period (v12 to v15).
> LimitInputStream was copied from Guava v12
> The recommended replacement is to use ByteStreams#limit(java.io.InputStream,
> long) instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858488#comment-13858488 ] Ted Yu commented on HBASE-10255: I ran TestLogRollAbort and TestHLog which passed locally. Let's see what Hadoop QA says. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858487#comment-13858487 ] Ted Yu commented on HBASE-10255: Thanks Andy for the reminder - I should have jumped out of guava in the first place. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 0.98.0, 0.99.0 > > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858485#comment-13858485 ] Andrew Purtell commented on HBASE-10255: bq. Patch v2 uses org.apache.commons.io.input.BoundedInputStream where no upgrade of any dependency is needed. That sounds good Ted, +1, let's try it. Thank you. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 10255-v1.txt, 10255-v2.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858479#comment-13858479 ] Ted Yu commented on HBASE-10255: LimitInputStream is already checked into 0.96 and above branches at hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 10255-v1.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858478#comment-13858478 ] Andrew Purtell commented on HBASE-10255: So don't add a class from Guava, and don't upgrade it either - issues here and on the other JIRA go away. Let's resolve them as wontfix or something. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 10255-v1.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858475#comment-13858475 ] Ted Yu commented on HBASE-10255: The need came from this comment on HBASE-10174 : bq. I just have a problem with adding classes from said library to hbase core to make it happen. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 10255-v1.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[
https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858474#comment-13858474
]
Andrew Purtell commented on HBASE-10255:
Like I said, we are already on shaky ground here. Let's get back to Stack's
earlier question:
{quote}
Out of interest, what brings on the need for an upgrade and the need to remove
LIS?
{quote}
What is the current need to do this? Seems like we are going to introduce new
probably code and test instability for the sake of what exactly?
> Remove dependency on LimitInputStream
> -
>
> Key: HBASE-10255
> URL: https://issues.apache.org/jira/browse/HBASE-10255
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 10255-v1.txt
>
>
> LimitInputStream has always been a @Beta API and beta apis aren't guaranteed
> to remain stable over such a long period (v12 to v15).
> LimitInputStream was copied from Guava v12
> The recommended replacement is to use ByteStreams#limit(java.io.InputStream,
> long) instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858442#comment-13858442 ] Ted Yu commented on HBASE-10255: One of the comments I got over in HBASE-10174 was the problem with adding classes from guava library to hbase core. I agree with that. To follow recommended way of replacing LimitInputStream, guava version needs to be upgraded. w.r.t. Andrew's comment, hadoop trunk is currently on guava 11.0.2 which is older than 12.0.1 - the version used by 0.96 and newer releases. I think the proposed change can be carried out in a major release of HBase. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 10255-v1.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858425#comment-13858425 ] Andrew Purtell commented on HBASE-10255: Implied in my above comment is at least we shouldn't be changing Guava versions without good reason. > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 10255-v1.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858423#comment-13858423 ] Andrew Purtell commented on HBASE-10255: Speaking of Guava versions, we already have lurking classpath issues, the DFSClient uses Guava classes and, for Hadoop 2.2.x at least, is compiled against 11.0.2. (I'm looking at the POMs for 2.2.3-SNAPSHOT right now.) This is possibly something we should synchronize with our upstream to avoid future accidents. Is there a Maven plugin that can figure that out at build time? > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 10255-v1.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[
https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858401#comment-13858401
]
Hadoop QA commented on HBASE-10255:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12620773/10255-v1.txt
against trunk revision .
ATTACHMENT ID: 12620773
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8298//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8298//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8298//console
This message is automatically generated.
> Remove dependency on LimitInputStream
> -
>
> Key: HBASE-10255
> URL: https://issues.apache.org/jira/browse/HBASE-10255
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 10255-v1.txt
>
>
> LimitInputStream has always been a @Beta API and beta apis aren't guaranteed
> to remain stable over such a long period (v12 to v15).
> LimitInputStream was copied from Guava v12
> The recommended replacement is to use ByteStreams#limit(java.io.InputStream,
> long) instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream
[ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858385#comment-13858385 ] stack commented on HBASE-10255: --- This patch also upgrades guava from v12 to v14. Any implications making the upgrade? Out of interest, what brings on the need for an upgrade and the need to remove LIS? Have you run into an issue that requires this? > Remove dependency on LimitInputStream > - > > Key: HBASE-10255 > URL: https://issues.apache.org/jira/browse/HBASE-10255 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 10255-v1.txt > > > LimitInputStream has always been a @Beta API and beta apis aren't guaranteed > to remain stable over such a long period (v12 to v15). > LimitInputStream was copied from Guava v12 > The recommended replacement is to use ByteStreams#limit(java.io.InputStream, > long) instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
