[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028279#comment-14028279 ] stack commented on HBASE-10336: --- +1 I tried it. It seems to be working. Let hadoopqa run. See what it says. If it comes back good enough I'll commit. You the man [~echarles] I suppose there will be followup issues? No need of an InfoServer if HttpServer is in our context? I wonder what else can be removed? Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-11.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch, HBASE-10336-after-first-review.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028309#comment-14028309 ] Eric Charles commented on HBASE-10336: -- [~stack] Sure, there will be follow-up to clean up and e.g. merge InfoServer with HttpServer. All located in http package. IMHO what is now is needed. The good thing is that we can make it evolve (new jetty version...) Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-11.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch, HBASE-10336-after-first-review.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028373#comment-14028373
]
Hadoop QA commented on HBASE-10336:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12649852/HBASE-10336-11.patch
against trunk revision .
ATTACHMENT ID: 12649852
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 48 new
or modified tests.
{color:red}-1 javac{color}. The applied patch generated 45 javac compiler
warnings (more than the trunk's current 4 warnings).
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+.append(isAlive() ? STATE_DESCRIPTION_ALIVE :
STATE_DESCRIPTION_NOT_LIVE).append(), listening at:);
+ private void writeAttribute(JsonGenerator jg, ObjectName oname,
MBeanAttributeInfo attr) throws IOException {
+ public static HttpServer createServer(String webapp, Configuration conf,
AccessControlList adminsAcl)
+return
localServerBuilder(webapp).setFindPort(true).setConf(conf).setPathSpec(pathSpecs).build();
+String serverURL = http://; +
NetUtils.getHostPortString(myServer.getConnectorAddress(0)) + /;
+
Mockito.verify(response).sendError(Mockito.eq(HttpServletResponse.SC_UNAUTHORIZED),
Mockito.anyString());
+
Mockito.verify(response).sendError(Mockito.eq(HttpServletResponse.SC_UNAUTHORIZED),
Mockito.anyString());
+ assertTrue( e.getMessage().contains(Problem in starting http server.
Server handlers failed));
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9746//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9746//console
This message is automatically generated.
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: 10336-v10.txt, HBASE-10336-1.patch,
HBASE-10336-11.patch, HBASE-10336-2.patch, HBASE-10336-3.patch,
HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch,
HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch,
HBASE-10336-after-first-review-2.patch, HBASE-10336-after-first-review.patch,
HBASE-10569-10.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028594#comment-14028594 ] Hudson commented on HBASE-10336: SUCCESS: Integrated in HBase-TRUNK #5197 (See [https://builds.apache.org/job/HBase-TRUNK/5197/]) HBASE-10336 Remove deprecated usage of Hadoop HttpServer in InfoServer (Eric Charles) (stack: rev 26096f363e8645ec61982ef26073e3172f1ce91c) * hbase-server/src/test/java/org/apache/hadoop/hbase/http/TestServletFilter.java * hbase-server/src/test/java/org/apache/hadoop/hbase/http/HttpServerFunctionalTest.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/InfoServer.java * hbase-server/src/test/resources/webapps/test/testjsp.jsp * hbase-server/src/main/java/org/apache/hadoop/hbase/http/jmx/package-info.java * hbase-server/src/test/java/org/apache/hadoop/hbase/http/TestSSLHttpServer.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/HttpConfig.java * hbase-server/src/test/java/org/apache/hadoop/hbase/http/TestHtmlQuoting.java * hbase-server/src/test/java/org/apache/hadoop/hbase/GenericTestUtils.java * hbase-server/src/test/java/org/apache/hadoop/hbase/http/jmx/TestJMXJsonServlet.java * hbase-server/src/test/java/org/apache/hadoop/hbase/http/TestGlobalFilter.java * hbase-common/src/main/resources/hbase-default.xml * hbase-server/src/test/java/org/apache/hadoop/hbase/http/conf/TestConfServlet.java * hbase-server/src/test/java/org/apache/hadoop/hbase/http/TestHttpRequestLog.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/ServerConfigurationKeys.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/FilterInitializer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/jmx/JMXJsonServlet.java * hbase-server/src/test/java/org/apache/hadoop/hbase/http/TestHttpRequestLogAppender.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/NoCacheFilter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/conf/ConfServlet.java * hbase-server/src/test/java/org/apache/hadoop/hbase/http/TestHttpServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/package-info.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/FilterContainer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/http/log/TestLogLevel.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/HtmlQuoting.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/AdminAuthorizedServlet.java * hbase-server/src/test/resources/webapps/static/test.css * hbase-server/pom.xml * hbase-server/src/test/java/org/apache/hadoop/hbase/http/lib/TestStaticUserWebFilter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RESTServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/lib/package-info.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/lib/StaticUserWebFilter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/HttpRequestLogAppender.java * hbase-server/src/test/java/org/apache/hadoop/hbase/http/TestPathFilter.java * hbase-server/src/test/java/org/apache/hadoop/hbase/http/TestHttpServerLifecycle.java * hbase-server/src/main/java/org/apache/hadoop/hbase/http/HttpRequestLog.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/TimedOutTestsListener.java * hbase-server/src/test/java/org/apache/hadoop/hbase/http/TestHttpServerWebapps.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/http/ssl/KeyStoreTestUtil.java * hbase-server/src/test/java/org/apache/hadoop/hbase/http/resource/JerseyResource.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Fix For: 0.99.0 Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-11.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch, HBASE-10336-after-first-review.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028800#comment-14028800 ] Eric Charles commented on HBASE-10336: -- [~stack] Lovely! [~stack] [~te...@apache.org] Thx for your encouragements and reviews. I will look what we can remove. I think the http infrastructure is quite well built and flexible like it is. I've worked a lot with embedded jetty, and this one sounds like a great base and should be kept and polished, upgrading to latest jetty. But yes, a few class merge is possible. Let me note it and gimme a a few weeks (time is really busy atm). Also who knows, there could be some side effects I didn't identify. I will monitor the mailing list and ask to ping me for anything suspect around http. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Fix For: 0.99.0 Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-11.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch, HBASE-10336-after-first-review.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015628#comment-14015628 ] stack commented on HBASE-10336: --- Looking at raw patch because rb not working for me: Why a new 'conf' package? conf/ServerConfigurationKeys.java Are the keys used by master and regionserver? You don't want to put them in the Server interface or in HConstants? Or in the InfoServer or in 'http' package since the constants seem to pertain there? I asked some questions on rb like how much of this is copy and paste from hadoop. and do we have to pull it all in? E.g. HtmlQuoting. I think InfoServer only exists because most of HttpServer was private. It could probably go away right? (Another JIRA). I took a quick look. I'd be up for taking in this patch even if it does too much as long as it works and then working on purging stuff after it is in. This is a difficult task doing this kind of work. Thanks [~echarles] Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch, HBASE-10336-after-first-review.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015677#comment-14015677 ] Eric Charles commented on HBASE-10336: -- [~saint@gmail.com] Tr Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch, HBASE-10336-after-first-review.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015685#comment-14015685 ] Eric Charles commented on HBASE-10336: -- [~stack] Trying to answer your points taking into account my last patch uploaded on rb (also answered you comments on rb): - no more conf package and interface instead of class - yep, we could put then in server interface or hconstants - just wanted to mimick what hadoop does and btw, a dedicated interface could make sense for http. - 95% copy/paste from hadoop - pulled everyting related to http - Yes, we could have left HtmlQuoting... in Hadoop, but this could lead later on to issues (changes that we don't want, more difficult to inject changes...) - hierarchy of InfoServer/HttpServer could be reviewed indeed. The patch works. Thx, Eric Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch, HBASE-10336-after-first-review.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015696#comment-14015696 ] Eric Charles commented on HBASE-10336: -- [~stack] to avoid confusion, the latest patch with all @tedyu and yours comments has been uploaded on rb, but not on this jira. If you think we should commit this, I will double check everything, clean a few unneeded spaces and upload the final patch here. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch, HBASE-10336-after-first-review.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015706#comment-14015706 ] stack commented on HBASE-10336: --- The patch on rb is kinda messed up. Please attach latest here and I'll give it another go over I'm thinking commit if it works then in subsequent issues do purge of uneeded classes. I was going to suggest you put your patch philosophy -- i.e. clean cut of the cord up in the rlease notes -- but it is there already. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch, HBASE-10336-after-first-review.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014544#comment-14014544 ] Eric Charles commented on HBASE-10336: -- [~tedyu] [~saint@gmail.com] - you comments have been commented. - I have implemented your comments (except the x509 warning which I propose to solve later on, with all the jazz on upgrading jetty...) - the diff are on https://reviews.apache.org/r/21705/diff/1-2 (I had to make an old-scholl diff, applying the git patch on the 1 week-old trunk, and regenerating via svn diff to be compatible with the review based on svn) (The review for hbase-git ddidn't work with the patch generated with git - normal?) Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch, HBASE-10336-after-first-review.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013455#comment-14013455
]
Hadoop QA commented on HBASE-10336:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12647553/HBASE-10336-after-first-review-2.patch
against trunk revision .
ATTACHMENT ID: 12647553
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 48 new
or modified tests.
{color:red}-1 javac{color}. The applied patch generated 45 javac compiler
warnings (more than the trunk's current 4 warnings).
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+.append(isAlive() ? STATE_DESCRIPTION_ALIVE :
STATE_DESCRIPTION_NOT_LIVE).append(), listening at:);
+ private void writeAttribute(JsonGenerator jg, ObjectName oname,
MBeanAttributeInfo attr) throws IOException {
+ public static HttpServer createServer(String webapp, Configuration conf,
AccessControlList adminsAcl)
+return
localServerBuilder(webapp).setFindPort(true).setConf(conf).setPathSpec(pathSpecs).build();
+String serverURL = http://; +
NetUtils.getHostPortString(myServer.getConnectorAddress(0)) + /;
+
Mockito.verify(response).sendError(Mockito.eq(HttpServletResponse.SC_UNAUTHORIZED),
Mockito.anyString());
+
Mockito.verify(response).sendError(Mockito.eq(HttpServletResponse.SC_UNAUTHORIZED),
Mockito.anyString());
+ assertTrue( e.getMessage().contains(Problem in starting http server.
Server handlers failed));
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9645//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9645//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9645//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9645//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9645//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9645//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9645//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9645//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9645//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9645//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9645//console
This message is automatically generated.
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch,
HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch,
HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch,
HBASE-10336-after-first-review.patch, HBASE-10569-10.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013721#comment-14013721
]
Ted Yu commented on HBASE-10336:
From
https://builds.apache.org/job/PreCommit-HBASE-Build/9645//artifact/patchprocess/patchJavacWarnings.txt
:
{code}
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/http/ssl/KeyStoreTestUtil.java:[99,39]
sun.security.x509.AlgorithmId is Sun proprietary API and may be removed in a
future release
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/http/ssl/KeyStoreTestUtil.java:[100,13]
sun.security.x509.X509CertInfo is Sun proprietary API and may be removed in a
future release
{code}
Can you suppress the above warnings ?
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch,
HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch,
HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch,
HBASE-10336-after-first-review.patch, HBASE-10569-10.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013868#comment-14013868 ] Eric Charles commented on HBASE-10336: -- [~te...@apache.org] I have removed the warning reading a self-signed certificate from a file, but got now an java.security.SignatureException: Signature length not correct: got 128 but was expecting 256. Are the warning stoppers, they are only in the tests? Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch, HBASE-10336-after-first-review.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014388#comment-14014388 ] Ted Yu commented on HBASE-10336: The above warnings on x509 are not stoppers. You can address review comments first. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch, HBASE-10336-after-first-review.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14012680#comment-14012680
]
Hadoop QA commented on HBASE-10336:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12647405/HBASE-10336-after-first-review.patch
against trunk revision .
ATTACHMENT ID: 12647405
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 48 new
or modified tests.
{color:red}-1 javac{color}. The applied patch generated 45 javac compiler
warnings (more than the trunk's current 4 warnings).
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+.append(isAlive() ? STATE_DESCRIPTION_ALIVE :
STATE_DESCRIPTION_NOT_LIVE).append(), listening at:);
+ private void writeAttribute(JsonGenerator jg, ObjectName oname,
MBeanAttributeInfo attr) throws IOException {
+ public static HttpServer createServer(String webapp, Configuration conf,
AccessControlList adminsAcl)
+return
localServerBuilder(webapp).setFindPort(true).setConf(conf).setPathSpec(pathSpecs).build();
+String serverURL = http://; +
NetUtils.getHostPortString(myServer.getConnectorAddress(0)) + /;
+
Mockito.verify(response).sendError(Mockito.eq(HttpServletResponse.SC_UNAUTHORIZED),
Mockito.anyString());
+
Mockito.verify(response).sendError(Mockito.eq(HttpServletResponse.SC_UNAUTHORIZED),
Mockito.anyString());
+ assertTrue( e.getMessage().contains(Problem in starting http server.
Server handlers failed));
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.crypto.aes.TestAES
org.apache.hadoop.hbase.TestHBaseConfiguration
org.apache.hadoop.hbase.TestClassFinder
org.apache.hadoop.hbase.util.TestCoprocessorClassLoader
org.apache.hadoop.hbase.io.crypto.TestKeyProvider
org.apache.hadoop.hbase.io.crypto.TestCipherProvider
org.apache.hadoop.hbase.io.crypto.TestEncryption
org.apache.hadoop.hbase.util.TestDynamicClassLoader
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//console
This message is automatically generated.
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch,
HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch,
HBASE-10336-9.patch,
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013252#comment-14013252
]
Ted Yu commented on HBASE-10336:
In hbase-common/src/main/resources/hbase-default.xml:
{code}
+ /property
+ property
/configuration
{code}
The last 'property' caused parsing error.
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch,
HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch,
HBASE-10336-9.patch, HBASE-10336-after-first-review.patch,
HBASE-10569-10.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009935#comment-14009935 ] Eric Charles commented on HBASE-10336: -- Thx [~tedyu] for your review. [~stack], [~apurtell],... any other comment on it? Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009936#comment-14009936 ] Eric Charles commented on HBASE-10336: -- [~stack], [~apurtell]... it being https://reviews.apache.org/r/21705/ thx, Eric Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003278#comment-14003278 ] Eric Charles commented on HBASE-10336: -- Thx Ted. I don't find the review request you created... can you post the url. Maybe github is also useful to review : https://github.com/datalayer/hbase/compare/HBASE-6581...HBASE-10336 Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003279#comment-14003279 ] Eric Charles commented on HBASE-10336: -- [~te...@apache.org] The github push contains the move of GenericTestUtils and TimedOutTestsListener you proposed. Any other comment? Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003313#comment-14003313 ] Ted Yu commented on HBASE-10336: @Eric: You can create review request using the file I attached. The creator of review request is able to upload new patches onto the same review request. That was why I didn't post the request I created. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003552#comment-14003552
]
Hadoop QA commented on HBASE-10336:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12645625/10336-v10.txt
against trunk revision .
ATTACHMENT ID: 12645625
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 69 new
or modified tests.
{color:red}-1 javac{color}. The applied patch generated 45 javac compiler
warnings (more than the trunk's current 4 warnings).
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+String serverURL = http://; +
NetUtils.getHostPortString(myServer.getConnectorAddress(0)) + /;
+
Mockito.verify(response).sendError(Mockito.eq(HttpServletResponse.SC_UNAUTHORIZED),
Mockito.anyString());
+
Mockito.verify(response).sendError(Mockito.eq(HttpServletResponse.SC_UNAUTHORIZED),
Mockito.anyString());
+ public static HttpServer createServer(String webapp, Configuration conf,
AccessControlList adminsAcl)
+return
localServerBuilder(webapp).setFindPort(true).setConf(conf).setPathSpec(pathSpecs).build();
+ assertTrue( e.getMessage().contains(Problem in starting http server.
Server handlers failed));
+.append(isAlive() ? STATE_DESCRIPTION_ALIVE :
STATE_DESCRIPTION_NOT_LIVE).append(), listening at:);
+ private void writeAttribute(JsonGenerator jg, ObjectName oname,
MBeanAttributeInfo attr) throws IOException {
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.procedure.TestZKProcedure
org.apache.hadoop.hbase.client.TestHCM
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9549//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9549//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9549//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9549//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9549//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9549//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9549//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9549//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9549//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9549//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9549//console
This message is automatically generated.
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch,
HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch,
HBASE-10336-9.patch, HBASE-10569-10.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003619#comment-14003619 ] Eric Charles commented on HBASE-10336: -- [~te...@apache.org] Thx for the support. Review is not published on https://reviews.apache.org/r/21705/ Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001977#comment-14001977 ] Eric Charles commented on HBASE-10336: -- [~te...@apache.org] I generated the diff with git diff --no-prefix and gets from https://reviews.apache.org/r/new/ the error message : No valid separator after the filename was found in the diff header. The patch I try to upload is the HBASE-10569-10.patch. Any idea? Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001981#comment-14001981 ] Ted Yu commented on HBASE-10336: Did you select hbase-git repository ? Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002069#comment-14002069 ] Eric Charles commented on HBASE-10336: -- [~te...@apache.org] I didn't.. now with hbase-git, I have The file 'hbase-server/pom.xml' (r3b4e546) could not be found in the repository Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002086#comment-14002086 ] Ted Yu commented on HBASE-10336: I got the same error. Maybe re-generate patch ? --no-prefix is not needed - reviewboard should be able to recognize git diff. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002115#comment-14002115 ] Eric Charles commented on HBASE-10336: -- [~te...@apache.org] even with a new patch created without '--no-prefix option, I get The file 'hbase-server/pom.xml' (r3b4e546) could not be found in the repository Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002306#comment-14002306
]
Ted Yu commented on HBASE-10336:
Should the following two files be under
hbase-server/src/test/java/org/apache/hadoop/hbase ?
{code}
$ ls hbase-server/src/test/java/org/apache/hadoop/hbase/test | head
GenericTestUtils.java
TimedOutTestsListener.java
{code}
I re-generated diff using svn repo (based on patch v10) and was able to create
review request. I will attach that patch here.
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch,
HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch,
HBASE-10336-9.patch, HBASE-10569-10.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998630#comment-13998630 ] Ted Yu commented on HBASE-10336: Uploading onto review board would make review process smooth. Thanks Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998877#comment-13998877 ] stack commented on HBASE-10336: --- @eric charles TestMultiParallel is not likely your patch -- it has been failing a while. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998410#comment-13998410 ] Eric Charles commented on HBASE-10336: -- [~tedyu] Thx for the jenkins trrigger. It gave back -1 for the tests. After a few hours, the build #9471 logs and information are already purged (the links return a 404) - Latest precommit build is now #9511, which is 40 precommit builds in a few hours. I can not see if the org.apache.hadoop.hbase.client.TestMultiParallel is the only failing test and why it has failed (stacktrace). It is a client test, not related to http. The other http test *seem* to have succeeded (not sure, I don't have the test reports). Is it a good time to upload the patch on the review board (https://reviews.apache.org/) or do we need to try again with jenkins ? Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10569-10.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885983#comment-13885983 ] stack commented on HBASE-10336: --- [~echarles] Lets avoid ...a more complete solution via 'HBASE-9213 create a unified shim for hadoop 1 and 2 so that there's one build of HBase' if we can. We have the hadoop1 and hadoop2 modules. Can particular needs per target be code added in here? [~echarles] Do we have to do something crazy like rely on hadoop httpserver if hadoop1 and this new one if hadoop2? Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885984#comment-13885984 ] stack commented on HBASE-10336: --- Or, we can't break the dependency till post 1.0? 1.0 hbase can't run on hadoop3? After 1.0, we commit this patch? Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881952#comment-13881952
]
Hadoop QA commented on HBASE-10336:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12624767/HBASE-10336-7.patch
against trunk revision .
ATTACHMENT ID: 12624767
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 48 new
or modified tests.
{color:red}-1 hadoop1.0{color}. The patch failed to compile against the
hadoop 1.0 profile.
Here is snippet of errors:
{code}[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project hbase-server: Compilation failure: Compilation failure:
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java:[50,24]
cannot find symbol
[ERROR] symbol : class HadoopIllegalArgumentException
[ERROR] location: package org.apache.hadoop
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/http/lib/StaticUserWebFilter.java:[41,0]
cannot find symbol
[ERROR] symbol : static DEFAULT_HADOOP_HTTP_STATIC_USER
--
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project hbase-server: Compilation failure
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
--
Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation
failure
at
org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:729)
at org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:128)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
... 19 more{code}
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8509//console
This message is automatically generated.
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch,
HBASE-10336-6.patch, HBASE-10336-7.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881971#comment-13881971
]
Eric Charles commented on HBASE-10336:
--
on my env (tested with jdk6 and jdk7):
{code}
git stash
git pull upstream trunk
patch -p0 HBASE-10336-7.patch
mvn clean install -DskipTests
...
BUILD SUCCESS
{code}
I wonder jenkins is not happy - anyone could quickly run the above snippet and
report back?
Thx, Eric
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch,
HBASE-10336-6.patch, HBASE-10336-7.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881980#comment-13881980
]
Ted Yu commented on HBASE-10336:
As QA reported, compilation against hadoop-1 failed:
{code}
+throw new HadoopIllegalArgumentException(name is not set);
{code}
HadoopIllegalArgumentException is not in hadoop-1
Consider using IllegalArgumentException instead.
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch,
HBASE-10336-6.patch, HBASE-10336-7.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881992#comment-13881992
]
Eric Charles commented on HBASE-10336:
--
[~te...@apache.org] thx for the pointer. Actually, I looked at jenkins output
and didn't see the command invoked not any details on the outputs. just the
exception. I guess the build script mutes this on purpose which makes it more
tricky for newbies like me, if the -Dhadoop.profile=1.0 would have appeared in
the log, I would have seen where the error was coming from, obviously from the
fact I didn't try to compile with hadoop1.
I have decoupled quite more keys (there was the reported
DEFAULT_HADOOP_HTTP_STATIC_USER and a few more). Now I have a more tricky one
{code}
[ERROR]
/home/eric/wrk/com/hbase.git/hbase-server/src/main/java/org/apache/hadoop/hbase/http/conf/ConfServlet.java:[93,10]
writeXml(java.io.OutputStream) in org.apache.hadoop.conf.Configuration cannot
be applied to (java.io.Writer)
{code}
It's the classical ball of wool I'm sure you see what I eman You guys
please tell me: a quick hack for this before falling on the next one or a more
complete solution via 'HBASE-9213 create a unified shim for hadoop 1 and 2 so
that there's one build of HBase' - Depends how quick you want this HBASE-10336
to land.
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch,
HBASE-10336-6.patch, HBASE-10336-7.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882013#comment-13882013
]
Hadoop QA commented on HBASE-10336:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12625203/HBASE-10336-8.patch
against trunk revision .
ATTACHMENT ID: 12625203
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 48 new
or modified tests.
{color:red}-1 hadoop1.0{color}. The patch failed to compile against the
hadoop 1.0 profile.
Here is snippet of errors:
{code}[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project hbase-server: Compilation failure
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/http/conf/ConfServlet.java:[93,10]
writeXml(java.io.OutputStream) in org.apache.hadoop.conf.Configuration cannot
be applied to (java.io.Writer)
[ERROR] - [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project hbase-server: Compilation failure
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/http/conf/ConfServlet.java:[93,10]
writeXml(java.io.OutputStream) in org.apache.hadoop.conf.Configuration cannot
be applied to (java.io.Writer)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
--
Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation
failure
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/http/conf/ConfServlet.java:[93,10]
writeXml(java.io.OutputStream) in org.apache.hadoop.conf.Configuration cannot
be applied to (java.io.Writer)
at
org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:729)
at org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:128)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101){code}
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8514//console
This message is automatically generated.
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch,
HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879798#comment-13879798 ] Eric Charles commented on HBASE-10336: -- [~stack] can you trigger jenkins build for HBASE-10336-6.patch ? Optionally, can you induce me on how to do this ? (is it possible to specify a set of patches to apply or does it take the last uploaded one?) (or do I need special granting?) Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879825#comment-13879825 ] Eric Charles commented on HBASE-10336: -- [~stack] ServerConfigurationKeys need a small change. I will wait jenkins results before uploading a new patch. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13880751#comment-13880751 ] stack commented on HBASE-10336: --- Let me try kicking hadoopqa. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13880758#comment-13880758 ] stack commented on HBASE-10336: --- Jenkins is 'sick'. Will try again in our morning. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878833#comment-13878833
]
Ted Yu commented on HBASE-10336:
Starting HBase 0.98 on hadoop built from hadoop-2 branch gave us:
{code}
2014-01-21 06:07:17,871 FATAL [master:h2-centos6-uns-1390276854-hbase-10:6]
master.HMaster: Unhandled exception. Starting shutdown.
java.lang.IllegalArgumentException: Property value must not be null
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:92)
at org.apache.hadoop.conf.Configuration.set(Configuration.java:958)
at org.apache.hadoop.conf.Configuration.set(Configuration.java:940)
at org.apache.hadoop.http.HttpServer.initializeWebServer(HttpServer.java:510)
at org.apache.hadoop.http.HttpServer.init(HttpServer.java:470)
at org.apache.hadoop.http.HttpServer.init(HttpServer.java:458)
at org.apache.hadoop.http.HttpServer.init(HttpServer.java:412)
at org.apache.hadoop.hbase.util.InfoServer.init(InfoServer.java:59)
at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:584)
{code}
Looks like this JIRA would get us pass the above issue.
[~apurtell]:
Can you consider this for 0.98.0 ?
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878951#comment-13878951 ] Andrew Purtell commented on HBASE-10336: bq. Looks like this JIRA would get us pass the above issue. Also, I hate to ask, but [~yuzhih...@gmail.com] did you check that applying this patch fixes the problem you have reported? Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878948#comment-13878948 ] Andrew Purtell commented on HBASE-10336: This is a pretty substantial and risky change to go in so late just ahead of RC0, which I am likely to tag today. It should go on trunk only. However, that does mean neither 0.96.x nor 0.98.x will work on Hadoop 2.4.0 unless this change can go in on a minor bump. Ping [~stack] - would you put this in on a 0.96 minor? (I doubt it, just checking.) Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878952#comment-13878952 ] Eric Charles commented on HBASE-10336: -- [~te...@apache.org] I had that error with trunk on h3-snapshot, and yes, this patch solves it. - I am also double checking the other error you mentioned. I am working on trunk: against which 0.98.x branch would you like to port this? Finally oops, although on my top-3 for today, my dev time is exhausted, so this will be hopefully for tomorrow. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878971#comment-13878971 ] Eric Charles commented on HBASE-10336: -- [~apurtell] I hate to say it, but yes, it will fix the reported issue. Will [~te...@apache.org] fall on another issue, who knows. At least, here it runs fine on h3-snapshot. I will come back in one hour and see if there is a demand for a final patch. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878975#comment-13878975 ] Andrew Purtell commented on HBASE-10336: bq. [~apurtell] I hate to say it, but yes, it will fix the reported issue. :-) bq. I will come back in one hour and see if there is a demand for a final patch. If there's a patch that fixes this issue I promise to try it and consider it. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878978#comment-13878978 ] stack commented on HBASE-10336: --- Not for a point release in 0.96. The exception should be carried back up to hadoop. There is a contract in place. It says we are allowed access at the head of the hadoop class. Lets fix hadoop branch-2 before it releases. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878979#comment-13878979
]
Haohui Mai commented on HBASE-10336:
The following code has been deprecated:
{code}
+
+ static {
+Configuration conf = new Configuration();
+boolean sslEnabled = conf.getBoolean(
+CommonConfigurationKeysPublic.HADOOP_SSL_ENABLED_KEY,
+CommonConfigurationKeysPublic.HADOOP_SSL_ENABLED_DEFAULT);
+policy = sslEnabled ? Policy.HTTPS_ONLY : Policy.HTTP_ONLY;
+ }
+
+ public static void setPolicy(Policy policy) {
+HttpConfig.policy = policy;
+ }
+
+ public static boolean isSecure() {
+return policy == Policy.HTTPS_ONLY;
+ }
+
+ public static String getSchemePrefix() {
+return (isSecure()) ? https://; : http://;;
+ }
+
+ public static String getScheme(Policy policy) {
+return policy == Policy.HTTPS_ONLY ? https://; : http://;;
+ }
{code}
{code}
+/**
+ * Use setAppDir() instead.
+ */
+@Deprecated
+public Builder setName(String name){
+ this.name = name;
+ return this;
+}
+
+/**
+ * Use addEndpoint() instead.
+ */
+@Deprecated
+public Builder setBindAddress(String bindAddress){
+ this.bindAddress = bindAddress;
+ return this;
+}
+
+/**
+ * Use addEndpoint() instead.
+ */
+@Deprecated
+public Builder setPort(int port) {
+ this.port = port;
+ return this;
+}
+
{code}
And there are significant amount of code in {{HttpServer}} has been marked as
deprecated. You might want to get rid of them as well.
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878980#comment-13878980 ] Andrew Purtell commented on HBASE-10336: bq. h3-snapshot. h3-snapshot is branch-2 HEAD and HBase trunk, that right? Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878983#comment-13878983 ] Andrew Purtell commented on HBASE-10336: bq. There is a contract in place. It says we are allowed access at the head of the hadoop class. Lets fix hadoop branch-2 before it releases. Ok, you heard the man. This is very unlikely to make the 0.98.0 RC 0 because I want to tag it today after a couple more things go in. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878989#comment-13878989 ] Eric Charles commented on HBASE-10336: -- [~apurtell] I run hbase-trunk on hadoop-trunk. To run it successfully, I have two options: 1. The tiny patch of HADOOP-10232 rejected by [~wheat9] 2. The large patch of HBASE-10336 which is nearly ready, but for which I miss one hour. my bad, and I wouldn't want to inject incomplete and potentially buggy code in a hbase release. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878999#comment-13878999 ] Andrew Purtell commented on HBASE-10336: Thanks [~e...@apache.org] bq. but for which I miss one hour. my bad It's not you. The solution to this problem looks to need doing upstream. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879002#comment-13879002 ] stack commented on HBASE-10336: --- [~wheat9] it is deprecated... and the implication is? That you will purge in a 2.4 release? Why not in a 3.0? Which hadoop issue is this? Thanks. (For a whiff of why we are disturbed, we would like to avoid there being yet more variants on our hbase x hadoop table here http://hbase.apache.org/book.html#hadoop -- it is frightening enough as it is) Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879013#comment-13879013 ] Andrew Purtell commented on HBASE-10336: The exception Ted reported above has been reported upstream as HADOOP-10252 looks like. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879038#comment-13879038 ] stack commented on HBASE-10336: --- Is [~ted_yu] not picking up HADOOP-10252 in his testing or does that patch not totally fix the issue? Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879037#comment-13879037
]
Haohui Mai commented on HBASE-10336:
HDFS-5305 and related jiras implement HTTPS support, as a side effect they have
changed a lot how {{HttpServer}} works.
I anticipate that there are more changes for {{HttpServer}} in the near term.
We want to keep it as an private API so that we can keep cleaning it up and
without worrying about compatibility.
For distribution, the approach of this jira might work better. It seems to me
that this is a reliable way to not making the table you've mentioned more
frightening. :-)
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879039#comment-13879039 ] Ted Yu commented on HBASE-10336: @Andy: I was about to test patch v5 which applies cleanly on 0.98 in a cluster. Somehow there was rollback in local repo. I will proceed and report back. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879046#comment-13879046 ] Andrew Purtell commented on HBASE-10336: bq. I was about to test patch v5 which applies cleanly on 0.98 in a cluster. It doesn't matter because this change isn't going to make RC0. I'm guessing we won't have just one release candidate, but a change of this magnitude is not likely to go in on any subsequent RC because it addresses a future problem. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879055#comment-13879055 ] stack commented on HBASE-10336: --- [~wheat9] All well and good. We are working to undo our dependency. This patch will go in soon but as [~jxiang] says up in HADOOP-5305, we want both the deprecated APIs to remain in place a while. We've just 'learned' of your effort to purge this code in 2.x timeframe. Unless there is some hard reason that the deprecated methods cannot stay in place (other than you have not tested them -- we'll yell and patch if you break something), rather than piss off a downstream project and put us in an awkward spot, I suggest leave them in place deprecated. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879067#comment-13879067 ] Eric Charles commented on HBASE-10336: -- If [~te...@apache.org] confirms patch v5 works well, it is safe to commit and release. The cleaning is more about class servlet move to http package, gitignore file to remove, hadoop key to rename/document, @InterfaceAudience to be removed. This can be done after. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879071#comment-13879071 ] Andrew Purtell commented on HBASE-10336: bq. If Ted Yu confirms patch v5 works well, it is safe to commit and release. Well two HBase RMs disagree with your assessment. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879081#comment-13879081 ] Jimmy Xiang commented on HBASE-10336: - FYI HADOOP-10252 hasn't fixed all issues related to the deprecated constructor. I am still looking into it now. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879103#comment-13879103 ] Eric Charles commented on HBASE-10336: -- [~jxiang] HADOOP-10252 sounds like a duplicate of HADOOP-10232 for which [1] is a valid patch IMHO. the patch submitted for HADOOP-10252 [2] seems like the first try I made, but had to add more code to make it work [~apurtell] sorry, I should have said IMHO, it would be safe to commit and release if no other issue is found after unit and integration tests + real deployment and traffic on a real cluster [1] https://issues.apache.org/jira/secure/attachment/12622867/HDFS-5760-2.patch [2] https://issues.apache.org/jira/secure/attachment/12624372/hadoop-10252.patch Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879116#comment-13879116 ] Jimmy Xiang commented on HBASE-10336: - [~echarles], you are right HADOOP-10252 is not complete. I filed HADOOP-10254, with which the mini cluster starts. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879127#comment-13879127 ] Eric Charles commented on HBASE-10336: -- [~jxiang] With HADOOP-10254, TestInfoServer may be ok, but hbase will fail at runtime, at least I would bet on that. On the other hand HADOOP-10252 is not enough, a patch uploaded here (not the last one) would be needed. Btw, what about simply dropping any change to hadoop and concentrate on the hbase decoupling. It was the plan, no? Sorry, i have to leave. Read you tomorrow. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879151#comment-13879151 ] Jimmy Xiang commented on HBASE-10336: - I just tested. My HBase cluster works fine with it. Thanks. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879256#comment-13879256
]
Haohui Mai commented on HBASE-10336:
As [~sureshms] suggested in HADOOP-10253, an alternative approach is to
maintain a temporary copy of {{HttpServer}} in hadoop-common for HBase in 2.4.
That way hbase can work with hadoop 2.4 untile HBASE-10336 is landed.
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879265#comment-13879265 ] Jimmy Xiang commented on HBASE-10336: - If this works, it is great. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879335#comment-13879335 ] Ted Yu commented on HBASE-10336: For Eric's patch v5: applied on 0.98 tip built 0.98 tar ball built Hoya with 0.98 dependency ran LoadTestTool using Hoya with 0.98 tar ball - it passed. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879351#comment-13879351 ] Andrew Purtell commented on HBASE-10336: I see you didn't actually check the InfoServers [~yuzhih...@gmail.com] -1 for 0.98. I am tagging RC0 today. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879349#comment-13879349 ] stack commented on HBASE-10336: --- [~wheat9] Thanks. Am up for testing and review np. [~ted_yu] You are not helping. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879353#comment-13879353 ] Andrew Purtell commented on HBASE-10336: By the way, what does Hoya have to do with validating an HBase release? If you want to make it part of HBase release criteria, raise a discussion on dev@. Mention on this issue is completely beside the point. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879354#comment-13879354 ] Ted Yu commented on HBASE-10336: @Andy: I was not suggesting Eric's patch for 0.98 Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879357#comment-13879357 ] Andrew Purtell commented on HBASE-10336: bq. I was not suggesting Eric's patch for 0.98 Could have fooled me because there is a mention of 0.98 on every line of your above comment. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879462#comment-13879462 ] stack commented on HBASE-10336: --- bq. I was not suggesting Eric's patch for 0.98 As per Andrew, the above is a non sequitur Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877328#comment-13877328
]
Eric Charles commented on HBASE-10336:
--
[~stack] 250 was set as default if hadoop.http.max.threads was not present, but
yes, I also found this value much too high. +1 for 10 which is a very
reasonable number
Yes, a few servlet classes to go home in the http package (as well in main as
test).
Didn't look at HADOOP_SSL_ENABLED_KEY nor HADOOP_JETTY_LOGS_SERVE_ALIASES...
Jenkins is strict and doesn't like the uneeded comma in
/package-info.java:[25,43] @InterfaceAudience.LimitedPrivate({HBase,})
Where are we now Mr. Stack? have you updated the patch and will upload a new
patch or do you like me to make it?
We can talk and fix the HADOOP_SSL_ENABLED_KEY,
HADOOP_JETTY_LOGS_SERVE_ALIASES and the upgrade to whatever jetty version after
the commit.
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877570#comment-13877570 ] stack commented on HBASE-10336: --- I have not made the changes. Would you mind? Doing the hadoop keys -- if at all -- post commit makes sense. Put up new patch and I'll commit. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877623#comment-13877623 ] Eric Charles commented on HBASE-10336: -- Ok [~stack]. I'm a bit short at time today, so it will be for tomorrow - will look also at the hadoop keys. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877968#comment-13877968
]
Ted Yu commented on HBASE-10336:
Is the following file needed ?
{code}
+++ hbase-server/src/test/resources/webapps/test/.gitignore
{code}
Is the following annotation needed ?
{code}
+@InterfaceAudience.LimitedPrivate({HBase})
{code}
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877217#comment-13877217 ] stack commented on HBASE-10336: --- I applied the patch locally. I don't see any difference! (smile). You thinking we stay with jetty6 @eric charles? I suppose at least till this patch goes in. In another issue we can wrangle with upgrading jetty if wanted. Let me try on cluster. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877225#comment-13877225
]
Hadoop QA commented on HBASE-10336:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12623623/HBASE-10336-5.patch
against trunk revision .
ATTACHMENT ID: 12623623
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 50 new
or modified tests.
{color:red}-1 hadoop1.0{color}. The patch failed to compile against the
hadoop 1.0 profile.
Here is snippet of errors:
{code}[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project hbase-server: Compilation failure
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/http/package-info.java:[25,43]
illegal start of expression
[ERROR] - [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project hbase-server: Compilation failure
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/http/package-info.java:[25,43]
illegal start of expression
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
--
Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation
failure
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/http/package-info.java:[25,43]
illegal start of expression
at
org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:729)
at org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:128)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101){code}
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8479//console
This message is automatically generated.
Remove deprecated usage of Hadoop HttpServer in InfoServer
--
Key: HBASE-10336
URL: https://issues.apache.org/jira/browse/HBASE-10336
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Eric Charles
Assignee: Eric Charles
Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch,
HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch
Recent changes in Hadoop HttpServer give NPE when running on hadoop
3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
not fixed (see HDFS-5760). We'd better move to the new proposed builder
pattern, which means we can no more use inheritance to build our nice
InfoServer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877249#comment-13877249 ] stack commented on HBASE-10336: --- I tried it on cluster. Looks good. Let me review the patch now. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877261#comment-13877261 ] stack commented on HBASE-10336: --- I'd cut this down to ten threads on commit... ok w/ you @eric charles? +namehbase.http.max.threads/name +value250/value My guess is that it is high in hadoop because its the MR transport This should be in http package? ConfServlet.java Might make more sense there. Should these configs be made into hbase configs? HADOOP_SSL_ENABLED_KEY And there HADOOP_JETTY_LOGS_SERVE_ALIASES This is good: + * Copied from hadoop source code.br/ + * See https://issues.apache.org/jira/browse/HADOOP-10232 to know why. Skimmed the patch. I'm +1 on it. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Assignee: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874252#comment-13874252 ] stack commented on HBASE-10336: --- I took a quick look. Seems like you are copying into hbase the hadoop httpserver and servlets (and tests) to undo our dependency. You also move around a few classes to put them into places that make more sense now httpserver is in hbase. That right? What are implications of applying this to our trunk Eric? (I did not see adding jetty to our pom. Do we need it or are we transitively including it? Do we need to exclude import of jetty from hadoop now?). Good work. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872350#comment-13872350 ] stack commented on HBASE-10336: --- [~echarles] Help me out boss. We can't commit this patch until HADOOP-10232 is in all hadoops we depend on? (Do I have that right?) Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872386#comment-13872386 ] Eric Charles commented on HBASE-10336: -- We need to wait on HBASE-9213 to provide a correct shim (on hdfs and jetty apis, such as hive does it). Once we have the shim, we need HADOOP-10232 to be committed in 3.0.0-SNAPSHOT to allow hbase run on h3. does it make sense? Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872399#comment-13872399 ] stack commented on HBASE-10336: --- yessir. Thanks. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870915#comment-13870915 ] stack commented on HBASE-10336: --- Patch looks good [~echarles]. Thanks. In here: +builder.setName(name).addEndpoint(URI.create(http://; + bindAddress + : + port)) Could we pass // instead of http://; so it works for both http and https if configured? Will this break h2 and h1 if it gets committed? Thanks. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870932#comment-13870932 ] Eric Charles commented on HBASE-10336: -- I will test with //, it should work. h2 is still ok, but I need to check for h1, but I expect it will fail, the builder was probably not there. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871002#comment-13871002 ] Eric Charles commented on HBASE-10336: -- [~stack] it will break on h1 and even h2 because we use releases. We need to go for a more generic and larger shim. I will hack on HBASE-9213 to solve this and HBASE-6581. Remove deprecated usage of Hadoop HttpServer in InfoServer -- Key: HBASE-10336 URL: https://issues.apache.org/jira/browse/HBASE-10336 Project: HBase Issue Type: Bug Affects Versions: 0.99.0 Reporter: Eric Charles Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
