[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899073#comment-13899073 ] Hudson commented on HBASE-10505: SUCCESS: Integrated in hbase-0.96-hadoop2 #201 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/201/]) HBASE-10505 Import.filterKv does not call Filter.filterRowKey. (larsh: rev 1567524) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899618#comment-13899618 ] Vasu Mariyala commented on HBASE-10505: --- [~lhofhansl] May be this is one of the issues of HBASE-10416 ? I think we need to fix the TestImportExport.testWithFilter test case by inserting atleast another row. This works currently because we insert only one row (row1), perform export, perform import with prefix filter. The prefix filter filterRowKey is never called (before this fix) so all the rows are included in the import. But since we only have one row (row1), the test case doesn't really test the functionality of import with filter. Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899675#comment-13899675 ] Andrew Purtell commented on HBASE-10505: Why not branches 0.96? Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899746#comment-13899746 ] Vasu Mariyala commented on HBASE-10505: --- For branches 0.96, the issue is fixed with HBASE-10416 Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899914#comment-13899914 ] Lars Hofhansl commented on HBASE-10505: --- Yeah, this is fixed in 0.98 and later. Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[
https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898715#comment-13898715
]
Ted Yu commented on HBASE-10505:
Thanks for fixing this.
{code}
+ * @param row on which to apply the filter
+ * @return true if the key should not be written, false otherwise
{code}
Please add javadoc for other parameters.
Import.filterKv does not call Filter.filterRowKey
-
Key: HBASE-10505
URL: https://issues.apache.org/jira/browse/HBASE-10505
Project: HBase
Issue Type: Bug
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Critical
Fix For: 0.98.0, 0.96.2, 0.99.0, 0.94.17
Attachments: 10505-0.94.txt
The general contract of a Filter is that filterRowKey is called before
filterKeyValue.
Import is using Filters for custom filtering but it does not called
filterRowKey at all. That throws off some Filters (such as RowFilter, and
more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and
HBASE-10485.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[
https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898719#comment-13898719
]
Ted Yu commented on HBASE-10505:
In trunk, we have:
{code}
if (filter == null || !filter.filterRowKey(key.get(), key.getOffset(),
key.getLength())) {
for (Cell kv : result.rawCells()) {
{code}
So this problem doesn't exist in trunk.
Import.filterKv does not call Filter.filterRowKey
-
Key: HBASE-10505
URL: https://issues.apache.org/jira/browse/HBASE-10505
Project: HBase
Issue Type: Bug
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Critical
Fix For: 0.98.0, 0.96.2, 0.99.0, 0.94.17
Attachments: 10505-0.94.txt
The general contract of a Filter is that filterRowKey is called before
filterKeyValue.
Import is using Filters for custom filtering but it does not called
filterRowKey at all. That throws off some Filters (such as RowFilter, and
more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and
HBASE-10485.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898729#comment-13898729 ] Lars Hofhansl commented on HBASE-10505: --- Heh, I hadn't sync'ed trunk in a but, was just fixed recently. I'll fix it the same way in 0.94 and 0.96 (so it's all the same). Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898735#comment-13898735 ] Lars Hofhansl commented on HBASE-10505: --- 0.98 is fine too. Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898741#comment-13898741 ] Lars Hofhansl commented on HBASE-10505: --- [~vmariyala], [~jesse_yates], not sure if that any impact on our stuff. Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898772#comment-13898772 ] Lars Hofhansl commented on HBASE-10505: --- [~yuzhih...@gmail.com], [~stack], you good with the patch? Including 0.96? (Without it filtering in Import is broken) Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898779#comment-13898779 ] ramkrishna.s.vasudevan commented on HBASE-10505: [~lhofhansl] Patch looks good to me. Can we try adding a filter testcase in testimportExport that validates this behaviour. The current test as you said my be just passing. Even sometime back I found that the testcases in TestImport were just passing without actually getting any KVs. So add a testcase for this behaviour. If it takes time, then we can address in a seperate JIRA. +1 on patch. Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898787#comment-13898787 ] Lars Hofhansl commented on HBASE-10505: --- I'd like to address the issues first. It's not much work to add a non-matching row/kvs to TestImportExport.testWithFilter, but that would need to be in branches. I'll file a subtask for that. Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898792#comment-13898792 ] stack commented on HBASE-10505: --- +1 for 0.96 Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898842#comment-13898842 ] Hudson commented on HBASE-10505: SUCCESS: Integrated in HBase-0.94-security #409 (See [https://builds.apache.org/job/HBase-0.94-security/409/]) HBASE-10505 Import.filterKv does not call Filter.filterRowKey. (larsh: rev 1567522) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898851#comment-13898851 ] Hudson commented on HBASE-10505: FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #20 (See [https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/20/]) HBASE-10505 Import.filterKv does not call Filter.filterRowKey. (larsh: rev 1567522) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898866#comment-13898866 ] Hudson commented on HBASE-10505: FAILURE: Integrated in HBase-0.94 #1284 (See [https://builds.apache.org/job/HBase-0.94/1284/]) HBASE-10505 Import.filterKv does not call Filter.filterRowKey. (larsh: rev 1567522) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898899#comment-13898899 ] Hudson commented on HBASE-10505: FAILURE: Integrated in HBase-0.94-JDK7 #47 (See [https://builds.apache.org/job/HBase-0.94-JDK7/47/]) HBASE-10505 Import.filterKv does not call Filter.filterRowKey. (larsh: rev 1567522) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
[ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898902#comment-13898902 ] Hudson commented on HBASE-10505: SUCCESS: Integrated in hbase-0.96 #291 (See [https://builds.apache.org/job/hbase-0.96/291/]) HBASE-10505 Import.filterKv does not call Filter.filterRowKey. (larsh: rev 1567524) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java Import.filterKv does not call Filter.filterRowKey - Key: HBASE-10505 URL: https://issues.apache.org/jira/browse/HBASE-10505 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Critical Fix For: 0.96.2, 0.94.17 Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt The general contract of a Filter is that filterRowKey is called before filterKeyValue. Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
