[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010176#comment-14010176 ] Hudson commented on HBASE-11096: SUCCESS: Integrated in HBase-0.94 #1371 (See [https://builds.apache.org/job/HBase-0.94/1371/]) HBASE-11096 stop method of Master and RegionServer coprocessor is not invoked (Qiang Tian) (apurtell: rev 6ed3d0770202a497e9884d0347efa46121dc2808) * src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorStop.java * src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.98.3, 0.94.21 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.1.patch, > HBASE-11096-trunk-v3.patch, HBASE-11096-trunk-v3.patch, > TestCoprocessorStop-failed-output.txt > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010150#comment-14010150 ] Hudson commented on HBASE-11096: FAILURE: Integrated in HBase-0.94-JDK7 #139 (See [https://builds.apache.org/job/HBase-0.94-JDK7/139/]) HBASE-11096 stop method of Master and RegionServer coprocessor is not invoked (Qiang Tian) (apurtell: rev 6ed3d0770202a497e9884d0347efa46121dc2808) * src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorStop.java * src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.98.3, 0.94.21 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.1.patch, > HBASE-11096-trunk-v3.patch, HBASE-11096-trunk-v3.patch, > TestCoprocessorStop-failed-output.txt > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010072#comment-14010072 ] Hudson commented on HBASE-11096: SUCCESS: Integrated in HBase-0.94-security #487 (See [https://builds.apache.org/job/HBase-0.94-security/487/]) HBASE-11096 stop method of Master and RegionServer coprocessor is not invoked (Qiang Tian) (apurtell: rev 6ed3d0770202a497e9884d0347efa46121dc2808) * src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorStop.java * src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.98.3, 0.94.21 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.1.patch, > HBASE-11096-trunk-v3.patch, HBASE-11096-trunk-v3.patch, > TestCoprocessorStop-failed-output.txt > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009274#comment-14009274 ] Lars Hofhansl commented on HBASE-11096: --- +1 for 0.94. > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.98.3 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.1.patch, > HBASE-11096-trunk-v3.patch, HBASE-11096-trunk-v3.patch, > TestCoprocessorStop-failed-output.txt > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009137#comment-14009137 ] Hudson commented on HBASE-11096: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #296 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/296/]) HBASE-11096 stop method of Master and RegionServer coprocessor is not invoked (Qiang Tian) (apurtell: rev 4a075c781e03ac6d89e8b311b66ae217370674ca) * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorStop.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.98.3 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.1.patch, > HBASE-11096-trunk-v3.patch, HBASE-11096-trunk-v3.patch, > TestCoprocessorStop-failed-output.txt > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009129#comment-14009129 ] Hudson commented on HBASE-11096: SUCCESS: Integrated in HBase-0.98 #315 (See [https://builds.apache.org/job/HBase-0.98/315/]) HBASE-11096 stop method of Master and RegionServer coprocessor is not invoked (Qiang Tian) (apurtell: rev 4a075c781e03ac6d89e8b311b66ae217370674ca) * hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorStop.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.98.3 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.1.patch, > HBASE-11096-trunk-v3.patch, HBASE-11096-trunk-v3.patch, > TestCoprocessorStop-failed-output.txt > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009123#comment-14009123 ] Hudson commented on HBASE-11096: SUCCESS: Integrated in HBase-TRUNK #5141 (See [https://builds.apache.org/job/HBase-TRUNK/5141/]) HBASE-11096 stop method of Master and RegionServer coprocessor is not invoked (Qiang Tian) (apurtell: rev 8e2a8cc0a8c3ca84c7f44bcb7c1ab661681a5e99) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorStop.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.98.3 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.1.patch, > HBASE-11096-trunk-v3.patch, HBASE-11096-trunk-v3.patch, > TestCoprocessorStop-failed-output.txt > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008993#comment-14008993 ] Andrew Purtell commented on HBASE-11096: The failure in TestTableLockManager is being fixed on HBASE-11251 and is not related to this change. > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.21, 0.98.4 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.1.patch, > HBASE-11096-trunk-v3.patch, HBASE-11096-trunk-v3.patch, > TestCoprocessorStop-failed-output.txt > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[
https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008728#comment-14008728
]
Hadoop QA commented on HBASE-11096:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12646762/HBASE-11096-trunk-v3.1.patch
against trunk revision .
ATTACHMENT ID: 12646762
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 3
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 31 release
audit warnings (more than the trunk's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestTableLockManager
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9586//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9586//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9586//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9586//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9586//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9586//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9586//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9586//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9586//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9586//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9586//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9586//console
This message is automatically generated.
> stop method of Master and RegionServer coprocessor is not invoked
> --
>
> Key: HBASE-11096
> URL: https://issues.apache.org/jira/browse/HBASE-11096
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.96.2, 0.98.1, 0.94.19
>Reporter: Qiang Tian
>Assignee: Qiang Tian
> Fix For: 0.99.0, 0.96.3, 0.94.21, 0.98.4
>
> Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch,
> HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch,
> HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch,
> HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.1.patch,
> HBASE-11096-trunk-v3.patch, HBASE-11096-trunk-v3.patch,
> TestCoprocessorStop-failed-output.txt
>
>
> the stop method of coprocessor specified by
> "hbase.coprocessor.master.classes" and
> "hbase.coprocessor.regionserver.classes" is not invoked.
> If coprocessor allocates OS resources, it could cause master/regionserver
> resource leak or hang during exit.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008680#comment-14008680 ] Qiang Tian commented on HBASE-11096: Hi [~apurtell], it looks the code base changed much since HBASE-11096-trunk-v3.patch was uploaded, so that the merge against latest trunk fails to pick up the fix correctly(but without reporting any error). I create a new patch based on the latest code base I can see: Author: Ramkrishna Date: Mon May 26 11:47:04 2014 +0530 HBASE-11251-LoadTestTool should grant READ permission for the users that are given READ access for specific cells (Ram) local test "mvn test -Dtest=org.apache.hadoop.hbase.coprocessor.*" passed thanks. > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.21, 0.98.4 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.1.patch, > HBASE-11096-trunk-v3.patch, HBASE-11096-trunk-v3.patch, > TestCoprocessorStop-failed-output.txt > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008311#comment-14008311 ] Qiang Tian commented on HBASE-11096: Hi [~apurtell], it looks the shutdown method is not called..could you please check if the patch apply to the MasterCoprocessorHost.java correctly? I just run command "patch -p0< ../backup/HBASE-11096-trunk-v3.patch" to trunk, and the change is not applied correctly. ps when I firstly saw your update on 20/5, I merged the code with latest code using "git merge" command and the test running fine. today I used "git rebase" command to merge my local branch with the latest code (since you recommended rebase in mailing list), and I got the error ---after investigation the MasterCoprocessorHost.java was not merged correctly.. I did a search, it looks git rebase uses patch command to do the final merge. so if patch does not work correctly, the rebase will fail too... pps..this is my second time to see patch command fails...Did I use wrong option? > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.21, 0.98.4 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.patch, > HBASE-11096-trunk-v3.patch, TestCoprocessorStop-failed-output.txt > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002717#comment-14002717 ] Qiang Tian commented on HBASE-11096: Hi [~apurtell], I ran "mvn test -Dtest=org.apache.hadoop.hbase.coprocessor.*" several times...all good. Could you paste the full log file? thanks. > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.patch > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[
https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002609#comment-14002609
]
Andrew Purtell commented on HBASE-11096:
I applied patch v3 to trunk and ran the coprocessor unit tests locally. The new
test TestCoprocessorStop failed:
{quote}
Test set: org.apache.hadoop.hbase.coprocessor.TestCoprocessorStop
---
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 29.904 sec <<<
FAILURE!
testStopped(org.apache.hadoop.hbase.coprocessor.TestCoprocessorStop) Time
elapsed: 1.326 sec <<< FAILURE!
java.lang.AssertionError: Master flag file should have been created
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at
org.apache.hadoop.hbase.coprocessor.TestCoprocessorStop.testStopped(TestCoprocessorStop.java:120)
{quote}
> stop method of Master and RegionServer coprocessor is not invoked
> --
>
> Key: HBASE-11096
> URL: https://issues.apache.org/jira/browse/HBASE-11096
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.96.2, 0.98.1, 0.94.19
>Reporter: Qiang Tian
>Assignee: Qiang Tian
> Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3
>
> Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch,
> HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch,
> HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch,
> HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.patch
>
>
> the stop method of coprocessor specified by
> "hbase.coprocessor.master.classes" and
> "hbase.coprocessor.regionserver.classes" is not invoked.
> If coprocessor allocates OS resources, it could cause master/regionserver
> resource leak or hang during exit.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002337#comment-14002337 ] stack commented on HBASE-11096: --- [~apurtell] You have my blessing > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.patch > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002135#comment-14002135 ] Andrew Purtell commented on HBASE-11096: lgtm, thanks [~tianq] Will commit this to 0.94+ later today unless objection. Ping [~stack] - heads up on small change to 0.96 needed to avoid minor weirdness if we skip that version. > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.patch > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001345#comment-14001345 ] Qiang Tian commented on HBASE-11096: Thanks [~lhofhansl] [~apurtell], is it OK for trunk? thanks! > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.patch > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001005#comment-14001005 ] Lars Hofhansl commented on HBASE-11096: --- Looked at the 0.94 patch. +1 for 0.94. > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.patch > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[
https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000396#comment-14000396
]
Hadoop QA commented on HBASE-11096:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12645196/HBASE-11096-0.94.patch
against trunk revision .
ATTACHMENT ID: 12645196
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9525//console
This message is automatically generated.
> stop method of Master and RegionServer coprocessor is not invoked
> --
>
> Key: HBASE-11096
> URL: https://issues.apache.org/jira/browse/HBASE-11096
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.96.2, 0.98.1, 0.94.19
>Reporter: Qiang Tian
>Assignee: Qiang Tian
> Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3
>
> Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch,
> HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch,
> HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch,
> HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.patch
>
>
> the stop method of coprocessor specified by
> "hbase.coprocessor.master.classes" and
> "hbase.coprocessor.regionserver.classes" is not invoked.
> If coprocessor allocates OS resources, it could cause master/regionserver
> resource leak or hang during exit.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999677#comment-13999677 ] Qiang Tian commented on HBASE-11096: Hi Guys, update and upload the patches for other branches.(mvn test passed) thanks. > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, > HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, > HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.patch > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[
https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992777#comment-13992777
]
Hadoop QA commented on HBASE-11096:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12643918/HBASE-11096-trunk-v2.patch
against trunk revision .
ATTACHMENT ID: 12643918
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.mapreduce.TestTableMapReduceBase.testMultiRegionTable(TestTableMapReduceBase.java:96)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9483//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9483//console
This message is automatically generated.
> stop method of Master and RegionServer coprocessor is not invoked
> --
>
> Key: HBASE-11096
> URL: https://issues.apache.org/jira/browse/HBASE-11096
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.96.2, 0.98.1, 0.94.19
>Reporter: Qiang Tian
>Assignee: Qiang Tian
> Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3
>
> Attachments: HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v0.patch,
> HBASE-11096-trunk-v1.patch, HBASE-11096-trunk-v2.patch
>
>
> the stop method of coprocessor specified by
> "hbase.coprocessor.master.classes" and
> "hbase.coprocessor.regionserver.classes" is not invoked.
> If coprocessor allocates OS resources, it could cause master/regionserver
> resource leak or hang during exit.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992587#comment-13992587 ] Qiang Tian commented on HBASE-11096: Hi [~apurtell], happen to find another new bug... it looks 0.99 is in BIG refactoring... HRegionServer becomes the base class of HMaster, for coprocessor stuff, since they share the same run method, the master will call coprocessor twice. see below example logs, one is for real regionserver, the other is for the regionserver code path in master, 2014-05-08 00:33:51,632 INFO [M:0;bdvm135:36021] coprocessor.TestCoprocessorStop$FooCoprocessor(66): st art coprocessor on regionserver 2014-05-08 00:33:51,633 INFO [RS:0;bdvm135:47513] coprocessor.TestCoprocessorStop$FooCoprocessor(66): s tart coprocessor on regionserver ... 2014-05-08 00:34:03,166 INFO [main] regionserver.HRegionServer(1624): call stack of stop java.io.IOException at org.apache.hadoop.hbase.regionserver.HRegionServer.stop(HRegionServer.java:1624) at org.apache.hadoop.hbase.master.ServerManager.shutdownCluster(ServerManager.java:975) at org.apache.hadoop.hbase.master.HMaster.shutdown(HMaster.java:1623) at org.apache.hadoop.hbase.util.JVMClusterUtil.shutdown(JVMClusterUtil.java:256) at org.apache.hadoop.hbase.LocalHBaseCluster.shutdown(LocalHBaseCluster.java:437) at org.apache.hadoop.hbase.MiniHBaseCluster.shutdown(MiniHBaseCluster.java:519) at org.apache.hadoop.hbase.coprocessor.TestCoprocessorStop.testStopped(TestCoprocessorStop.java: 114) ... 2014-05-08 00:34:03,215 INFO [main] regionserver.HRegionServer(1629): rsHost code path called 2014-05-08 00:34:03,228 DEBUG [main] coprocessor.CoprocessorHost(258): Stop coprocessor org.apache.hadoo p.hbase.coprocessor.TestCoprocessorStop$FooCoprocessor 2014-05-08 00:34:03,462 INFO [main] coprocessor.TestCoprocessorStop$FooCoprocessor(88): create file hdf s://localhost:8155/user/tianq/test-data/f0c9423c-e505-4feb-907e-c7bd6e16545b/regionserver1399534399680 r eturn rc true ... 2014-05-08 00:34:03,482 INFO [main] regionserver.HRegionServer(1624): call stack of stop java.io.IOException at org.apache.hadoop.hbase.regionserver.HRegionServer.stop(HRegionServer.java:1624) at org.apache.hadoop.hbase.util.JVMClusterUtil.shutdown(JVMClusterUtil.java:264) at org.apache.hadoop.hbase.LocalHBaseCluster.shutdown(LocalHBaseCluster.java:437) at org.apache.hadoop.hbase.MiniHBaseCluster.shutdown(MiniHBaseCluster.java:519) at org.apache.hadoop.hbase.coprocessor.TestCoprocessorStop.testStopped(TestCoprocessorStop.java: 114) 2014-05-08 00:34:03,485 INFO [main] regionserver.HRegionServer(1629): rsHost code path called 2014-05-08 00:34:03,485 DEBUG [main] coprocessor.CoprocessorHost(258): Stop coprocessor org.apache.hadoo p.hbase.coprocessor.TestCoprocessorStop$FooCoprocessor 2014-05-08 00:34:03,493 INFO [main] coprocessor.TestCoprocessorStop$FooCoprocessor(88): create file hdf s://localhost:8155/user/tianq/test-data/f0c9423c-e505-4feb-907e-c7bd6e16545b/regionserver1399534399680 r eturn rc false > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v1.patch, HBASE-11096-trunk-v2.patch > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996228#comment-13996228 ] Qiang Tian commented on HBASE-11096: Thanks Ted's comment. sure, will remove it. Hi [~apurtell], [~yuzhih...@gmail.com], [~jxiang], Regarding HBASE-11146, after studying HBASE-10569 and the code, it is by design. my concern is that, although master is also a regionserver, but from user's perspective master is still of a 'master role', so if they deploy master coprocessor and regionserver coprocessor on master and regionserver respectively, they might not want to see 2 coprocessors created on master, in which case the master coprocessor and regionserver coprocessor might have potential conflict. --I just see we remove the master infoserver, and redirect the request to regionserver infoserver in 0.99. maybe we could follow similar way? i.e. disable RegionServerCoprocessorHost on master. Could you please let me know your thoughts? Thanks! Qiang > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v1.patch, HBASE-11096-trunk-v2.patch > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[
https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995235#comment-13995235
]
Ted Yu commented on HBASE-11096:
{code}
+LOG.error("on RegionCoprocessorEnvironment!!", new IOException(
+"in RegionCoprocessorEnvironment"));
{code}
Is your intention of creating IOException just for record keeping ?
Looks like IOException doesn't have to be created.
> stop method of Master and RegionServer coprocessor is not invoked
> --
>
> Key: HBASE-11096
> URL: https://issues.apache.org/jira/browse/HBASE-11096
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.96.2, 0.98.1, 0.94.19
>Reporter: Qiang Tian
>Assignee: Qiang Tian
> Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3
>
> Attachments: HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v0.patch,
> HBASE-11096-trunk-v1.patch, HBASE-11096-trunk-v2.patch
>
>
> the stop method of coprocessor specified by
> "hbase.coprocessor.master.classes" and
> "hbase.coprocessor.regionserver.classes" is not invoked.
> If coprocessor allocates OS resources, it could cause master/regionserver
> resource leak or hang during exit.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1391#comment-1391 ] Andrew Purtell commented on HBASE-11096: We should have a quick and simple unit test for this issue. It's no problem to add a new one rather than change an existing test. > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v1.patch > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986473#comment-13986473 ] Qiang Tian commented on HBASE-11096: Hi [~apurtell], I took a look at current testcase, there is a TestMasterObserver.wasStopped method, but it is not called --it looks there is no good place to test it due to the scenario.. HBASE-10289 is a better place, it will cover the stop test naturally. please let me know if it is acceptable. thanks. > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v0.patch, > HBASE-11096-trunk-v1.patch > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[
https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985855#comment-13985855
]
Hadoop QA commented on HBASE-11096:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12642660/HBASE-11096-trunk-v0.patch
against trunk revision .
ATTACHMENT ID: 12642660
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9433//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9433//console
This message is automatically generated.
> stop method of Master and RegionServer coprocessor is not invoked
> --
>
> Key: HBASE-11096
> URL: https://issues.apache.org/jira/browse/HBASE-11096
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.96.2, 0.98.1, 0.94.19
>Reporter: Qiang Tian
>Assignee: Qiang Tian
> Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3
>
> Attachments: HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v0.patch
>
>
> the stop method of coprocessor specified by
> "hbase.coprocessor.master.classes" and
> "hbase.coprocessor.regionserver.classes" is not invoked.
> If coprocessor allocates OS resources, it could cause master/regionserver
> resource leak or hang during exit.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[
https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985846#comment-13985846
]
Andrew Purtell commented on HBASE-11096:
bq. Failed tests: testNativeSizes
Non Oracle JVM? Anyway this will be unrelated to this patch.
Please log at debug level and add a check for if debug logging is enabled
(skips string formatting costs if not), e.g.
{code}
if (LOG.isDebugEnabled()) {
LOG.debug(...)
}
{code}
If possible please add or modify a unit test to confirm the stop method is
invoked.
> stop method of Master and RegionServer coprocessor is not invoked
> --
>
> Key: HBASE-11096
> URL: https://issues.apache.org/jira/browse/HBASE-11096
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.96.2, 0.98.1, 0.94.19
>Reporter: Qiang Tian
>Assignee: Qiang Tian
> Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3
>
> Attachments: HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v0.patch
>
>
> the stop method of coprocessor specified by
> "hbase.coprocessor.master.classes" and
> "hbase.coprocessor.regionserver.classes" is not invoked.
> If coprocessor allocates OS resources, it could cause master/regionserver
> resource leak or hang during exit.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985338#comment-13985338 ] Qiang Tian commented on HBASE-11096: Hi, I ran the regression test by "mvn clean package ", 1 test did fail...but without the fix it failed either..: Failed tests: testNativeSizes(org.apache.hadoop.hbase.io.TestHeapSize): expected:<64> but was:<56> Tests in error: org.apache.hadoop.hbase.procedure.TestProcedureManager: org/apache/hadoop/io/nativeio/SharedFileDescriptorFactory.createDescriptor0(Ljava/lang/String;Ljava/lang/String;I)Ljava/io/FileDescriptor; but I did not see result file of TestFlushSnapshotFromClient ... I also tried "mvn test", did I miss something? thanks! > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11096-trunk-v0.patch > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[
https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985304#comment-13985304
]
Hadoop QA commented on HBASE-11096:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12642609/HBASE-11096-trunk-v0.patch
against trunk revision .
ATTACHMENT ID: 12642609
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9431//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9431//console
This message is automatically generated.
> stop method of Master and RegionServer coprocessor is not invoked
> --
>
> Key: HBASE-11096
> URL: https://issues.apache.org/jira/browse/HBASE-11096
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.96.2, 0.98.1, 0.94.19
>Reporter: Qiang Tian
>Assignee: Qiang Tian
> Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3
>
> Attachments: HBASE-11096-trunk-v0.patch
>
>
> the stop method of coprocessor specified by
> "hbase.coprocessor.master.classes" and
> "hbase.coprocessor.regionserver.classes" is not invoked.
> If coprocessor allocates OS resources, it could cause master/regionserver
> resource leak or hang during exit.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985271#comment-13985271 ] Qiang Tian commented on HBASE-11096: oops...just notice the "stop coprocessor.." message is logged per-region for "hbase.coprocessor.region.classes" coprocessor. need to be lower level or removed... > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11096-trunk-v0.patch > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985250#comment-13985250 ] Qiang Tian commented on HBASE-11096: Hi [~apurtell], 1)For MasterCoprocessorHost, I can see preShutdown is called in my test, not sure how preStopMaster is called(looks command invocation via RPC?) 2)HRegionServer.stop change is for the bug mentioned above. thanks! > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11096-trunk-v0.patch > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[
https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985069#comment-13985069
]
Qiang Tian commented on HBASE-11096:
Hi [~apurtell],
Thanks for response.
Yes, I will. the fix is simple.. this is part of work for HBASE-10289,
during my test I just find another small bug--the HRegionServer.stop is called
twice, the fix looks simple as well, but I better study the related code
first..:-)
the first time:
HRegionServer.run:
} else if (this.stopping) {
boolean allUserRegionsOffline = areAllUserRegionsOffline();
if (allUserRegionsOffline) {
// Set stopped if no requests since last time we went around the
loop.
// The remaining meta regions will be closed on our way out.
if (oldRequestCount == this.requestCount.get()) {
stop("Stopped; only catalog regions remaining online");
break;
}
the second time in shutdown hook:
at
org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:273)
at
org.apache.hadoop.hbase.regionserver.RegionServerCoprocessorHost.preStop(RegionServerCoproces
sorHost.java:63)
at
org.apache.hadoop.hbase.regionserver.HRegionServer.stop(HRegionServer.java:1680)
at
org.apache.hadoop.hbase.regionserver.ShutdownHook$ShutdownHookThread.run(ShutdownHook.java:114)
at
org.apache.hadoop.util.ShutdownHookManager$1.run(ShutdownHookManager.java:54)
2014-04-29 18:56:02,617 WARN
org.apache.hadoop.hbase.coprocessor.CoprocessorHost: Not stopping coprocess
or org.apache.hadoop.hbase.jmxAgent because not active (state=STOPPED)
2014-04-29 18:56:02,617 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer: STOPPED: Shutdown hook
2014-04-29 18:56:02,617 INFO org.apache.hadoop.hbase.regionserver.ShutdownHook:
Starting fs shutdown hoo
k thread.
> stop method of Master and RegionServer coprocessor is not invoked
> --
>
> Key: HBASE-11096
> URL: https://issues.apache.org/jira/browse/HBASE-11096
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.96.2, 0.98.1, 0.94.19
>Reporter: Qiang Tian
>Assignee: Qiang Tian
> Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3
>
>
> the stop method of coprocessor specified by
> "hbase.coprocessor.master.classes" and
> "hbase.coprocessor.regionserver.classes" is not invoked.
> If coprocessor allocates OS resources, it could cause master/regionserver
> resource leak or hang during exit.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11096) stop method of Master and RegionServer coprocessor is not invoked
[ https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985041#comment-13985041 ] Andrew Purtell commented on HBASE-11096: Hi [~tianq], thanks for reporting the issue. Are you planning to provide a patch? > stop method of Master and RegionServer coprocessor is not invoked > -- > > Key: HBASE-11096 > URL: https://issues.apache.org/jira/browse/HBASE-11096 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.2, 0.98.1, 0.94.19 >Reporter: Qiang Tian >Assignee: Qiang Tian > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > > the stop method of coprocessor specified by > "hbase.coprocessor.master.classes" and > "hbase.coprocessor.regionserver.classes" is not invoked. > If coprocessor allocates OS resources, it could cause master/regionserver > resource leak or hang during exit. -- This message was sent by Atlassian JIRA (v6.2#6252)
