[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937957#comment-14937957 ] Hudson commented on HBASE-14394: SUCCESS: Integrated in HBase-1.3-IT #194 (See [https://builds.apache.org/job/HBase-1.3-IT/194/]) HBASE-14394 Properly close the connection after reading records from (jerryjch: rev c75382860f793f31599cffc6ad697f8ab58c4eb0) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394-addendum-v2.patch, > HBASE-14394-addendum.patch, HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936420#comment-14936420 ] Hudson commented on HBASE-14394: FAILURE: Integrated in HBase-1.2 #210 (See [https://builds.apache.org/job/HBase-1.2/210/]) HBASE-14394 Properly close the connection after reading records from table: addendum (jerryjch: rev a8b79e2768230b6a2bb5f26ea5daa091685d35f2) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394-addendum-v2.patch, > HBASE-14394-addendum.patch, HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936484#comment-14936484 ] Hudson commented on HBASE-14394: FAILURE: Integrated in HBase-TRUNK #6856 (See [https://builds.apache.org/job/HBase-TRUNK/6856/]) HBASE-14394 Properly close the connection after reading records from table: addendum (jerryjch: rev e6905a14446e9d795a797e091d5b35a75fe370d6) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394-addendum-v2.patch, > HBASE-14394-addendum.patch, HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934808#comment-14934808 ] Nick Dimiduk commented on HBASE-14394: -- Thanks [~jerryhe], this addendum cleans up the [compatibility report|http://people.apache.org/~ndimiduk/1.1.0_14394-addendum-branch-1.1_compat_report.html]. +1 > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394-addendum.patch, HBASE-14394.patch, > HBASE-14394_v2.patch, HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936405#comment-14936405 ] Hudson commented on HBASE-14394: SUCCESS: Integrated in HBase-1.1 #686 (See [https://builds.apache.org/job/HBase-1.1/686/]) HBASE-14394 Properly close the connection after reading records from table: addendum (jerryjch: rev ea00aed0506f7f16de5c6fa5d0da9a1827e9de18) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394-addendum-v2.patch, > HBASE-14394-addendum.patch, HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936384#comment-14936384 ] Hudson commented on HBASE-14394: FAILURE: Integrated in HBase-1.3 #216 (See [https://builds.apache.org/job/HBase-1.3/216/]) HBASE-14394 Properly close the connection after reading records from table: addendum (jerryjch: rev c75382860f793f31599cffc6ad697f8ab58c4eb0) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394-addendum-v2.patch, > HBASE-14394-addendum.patch, HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936339#comment-14936339 ] Hudson commented on HBASE-14394: FAILURE: Integrated in HBase-1.0 #1063 (See [https://builds.apache.org/job/HBase-1.0/1063/]) HBASE-14394 Properly close the connection after reading records from table: addendum (jerryjch: rev 85eec3e20303b73cce899b068a8cf6248e76da3f) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394-addendum-v2.patch, > HBASE-14394-addendum.patch, HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936391#comment-14936391 ] Hudson commented on HBASE-14394: SUCCESS: Integrated in HBase-1.2-IT #176 (See [https://builds.apache.org/job/HBase-1.2-IT/176/]) HBASE-14394 Properly close the connection after reading records from table: addendum (jerryjch: rev a8b79e2768230b6a2bb5f26ea5daa091685d35f2) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394-addendum-v2.patch, > HBASE-14394-addendum.patch, HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936324#comment-14936324 ] Jerry He commented on HBASE-14394: -- Thanks, [~ndimiduk] Attached addendum-v2, which fixed the checkstyle warnings by removing unused import and fixing one long line. Committed addendum-v2 from branch-1.0 to master. > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394-addendum-v2.patch, > HBASE-14394-addendum.patch, HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934116#comment-14934116 ] Jerry He commented on HBASE-14394: -- [~ndimiduk], [~srikanth235] Are you ok with the addendum? I will fix the checkstyle warnings. > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394-addendum.patch, HBASE-14394.patch, > HBASE-14394_v2.patch, HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[
https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14909950#comment-14909950
]
Hadoop QA commented on HBASE-14394:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12762537/HBASE-14394-addendum.patch
against master branch at commit 526520de0a9d7a29fcf1b4c521f017ca75a46cbc.
ATTACHMENT ID: 12762537
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1789 checkstyle errors (more than the master's current 1787 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestShell
org.apache.hadoop.hbase.client.TestReplicationShell
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15778//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15778//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15778//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15778//console
This message is automatically generated.
> Properly close the connection after reading records from table.
> ---
>
> Key: HBASE-14394
> URL: https://issues.apache.org/jira/browse/HBASE-14394
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>Priority: Minor
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3
>
> Attachments: HBASE-14394-addendum.patch, HBASE-14394.patch,
> HBASE-14394_v2.patch, HBASE-14394_v3.patch, HBASE-14394_v4.patch
>
>
> This was brought to notice by one of our observant customers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908320#comment-14908320 ] Jerry He commented on HBASE-14394: -- Sure. Will get a patch shortly. > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14909044#comment-14909044 ] Srikanth Srungarapu commented on HBASE-14394: - Thanks, Jerry! > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[
https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905996#comment-14905996
]
Srikanth Srungarapu commented on HBASE-14394:
-
Yeah, I can definitely provide doc comments. Reducing the visibility of the
method may not be feasible option, as we have to call {{trr.setConnection()}}
method from {{MultiTableInputFormatBase}}, and hence it can't be marked as
either protected or private. Please do let me know if you guys have any better
alternatives in mind.
> Properly close the connection after reading records from table.
> ---
>
> Key: HBASE-14394
> URL: https://issues.apache.org/jira/browse/HBASE-14394
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>Priority: Minor
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3
>
> Attachments: HBASE-14394.patch, HBASE-14394_v2.patch,
> HBASE-14394_v3.patch, HBASE-14394_v4.patch
>
>
> This was brought to notice by one of our observant customers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906570#comment-14906570 ] Jerry He commented on HBASE-14394: -- Looking at TableInputFormatBase. It used an inner class in createRecordReader() that seems to be only for closing the resources. You guys can decide if it is good or worth doing it here or not. > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[
https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906584#comment-14906584
]
Nick Dimiduk commented on HBASE-14394:
--
[~srikanth235] Is {{setConnection}} only called from
{{MultiTableInputFormatBase}}? If so, it can be added at protected visibility.
Either way, adding a docstring should help future maintainers to understand
what's going on.
[~jerryhe] I don't mind adding the method, so long as it's added with good
reason, is considered thoughtfully as part of the API of a public interface,
and is documented appropriately.
However, on the {{close()}} descriptor, we need to maintain 100% source
compatibility for patch releases, so 1.0, and 1.1 branch (and 0.98 actually),
patches must not change the throws signature of this method. Mind adding an
addendum for those release versions that addresses the visibility, docstring,
and interface issues?
For your reference, I generate the compatibility report linked in the dev
thread using the tool {{dev-support/check_compatibility.sh}} on master. Thanks
folks.
> Properly close the connection after reading records from table.
> ---
>
> Key: HBASE-14394
> URL: https://issues.apache.org/jira/browse/HBASE-14394
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>Priority: Minor
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3
>
> Attachments: HBASE-14394.patch, HBASE-14394_v2.patch,
> HBASE-14394_v3.patch, HBASE-14394_v4.patch
>
>
> This was brought to notice by one of our observant customers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[
https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906716#comment-14906716
]
Sean Busbey commented on HBASE-14394:
-
chiming in late, but we could annotate the {{setConnection}} method with
{{InterfaceAudience.Private}} and remove it from the API.
> Properly close the connection after reading records from table.
> ---
>
> Key: HBASE-14394
> URL: https://issues.apache.org/jira/browse/HBASE-14394
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>Priority: Minor
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3
>
> Attachments: HBASE-14394.patch, HBASE-14394_v2.patch,
> HBASE-14394_v3.patch, HBASE-14394_v4.patch
>
>
> This was brought to notice by one of our observant customers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906806#comment-14906806 ] Nick Dimiduk commented on HBASE-14394: -- [~busbey] Early for you was right on schedule for me ;) > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906717#comment-14906717 ] Sean Busbey commented on HBASE-14394: - also thanks for catching this compat issue early [~ndimiduk]! > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[
https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906642#comment-14906642
]
Nick Dimiduk commented on HBASE-14394:
--
Reading again the [compatibility
matrix|http://hbase.apache.org/book.html#hbase.versioning], the only time we
can make source-level incompatibility changes is on a major release. That means
the {{close()}} signature must be retained through all 1.x branches.
FYI [~busbey] [~enis].
> Properly close the connection after reading records from table.
> ---
>
> Key: HBASE-14394
> URL: https://issues.apache.org/jira/browse/HBASE-14394
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>Priority: Minor
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3
>
> Attachments: HBASE-14394.patch, HBASE-14394_v2.patch,
> HBASE-14394_v3.patch, HBASE-14394_v4.patch
>
>
> This was brought to notice by one of our observant customers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907353#comment-14907353 ] Srikanth Srungarapu commented on HBASE-14394: - [~jerryhe] Do you mind picking this up? I might not be able to attend to this anytime soon. > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905694#comment-14905694 ] Jerry He commented on HBASE-14394: -- See your comment in the email thread 'Thinking of HBase 1.1.3' as well, [~ndimiduk] There must a way to accomplish the same (closing the connection) without adding the method and introducing this compatibility issue. Do you want to fix the issue by redoing in a different way? > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905429#comment-14905429 ] Nick Dimiduk commented on HBASE-14394: -- Hi [~srikanth235]. While prepping for 1.1.3 release, I noticed this patch added TableRecordReader#setConnection as a public method with no Javadoc string. This is a @InterfaceAudience.Public, @InterfaceStability.Stable class, which means it's now and forever part of our public, stable API. Thus I have to ask: can it's visibility be reduced and can you please provide a basic docstring explaining when and where it needs to be used? Maybe [~jerryhe] can provide some context here as well. Thanks. > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746407#comment-14746407 ] Hudson commented on HBASE-14394: FAILURE: Integrated in HBase-1.2 #174 (See [https://builds.apache.org/job/HBase-1.2/174/]) HBASE-14394 Properly close the connection after reading records from table. (ssrungarapu: rev 0d3f0f64a49cbd33f26d7dfd97ec30aa7d78a752) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746499#comment-14746499 ] Hudson commented on HBASE-14394: FAILURE: Integrated in HBase-TRUNK #6809 (See [https://builds.apache.org/job/HBase-TRUNK/6809/]) HBASE-14394 Properly close the connection after reading records from table. (ssrungarapu: rev 938d2a0c9cfa4c033ccc72de490672f151bb0351) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746070#comment-14746070 ] Hudson commented on HBASE-14394: FAILURE: Integrated in HBase-1.1 #663 (See [https://builds.apache.org/job/HBase-1.1/663/]) HBASE-14394 Properly close the connection after reading records from table. (ssrungarapu: rev 73db03ff856e17941bf646423fb038b244993541) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746084#comment-14746084 ] Hudson commented on HBASE-14394: FAILURE: Integrated in HBase-1.0 #1051 (See [https://builds.apache.org/job/HBase-1.0/1051/]) HBASE-14394 Properly close the connection after reading records from table. (ssrungarapu: rev 4af173f3f16d7c85ab565b10a5b0cfc0f1fb4977) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746231#comment-14746231 ] Hudson commented on HBASE-14394: SUCCESS: Integrated in HBase-1.3-IT #156 (See [https://builds.apache.org/job/HBase-1.3-IT/156/]) HBASE-14394 Properly close the connection after reading records from table. (ssrungarapu: rev 1e90df8aa87969d503cabf435025c4aff3cca100) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746284#comment-14746284 ] Hudson commented on HBASE-14394: FAILURE: Integrated in HBase-1.3 #175 (See [https://builds.apache.org/job/HBase-1.3/175/]) HBASE-14394 Properly close the connection after reading records from table. (ssrungarapu: rev 1e90df8aa87969d503cabf435025c4aff3cca100) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746174#comment-14746174 ] Hudson commented on HBASE-14394: SUCCESS: Integrated in HBase-1.2-IT #147 (See [https://builds.apache.org/job/HBase-1.2-IT/147/]) HBASE-14394 Properly close the connection after reading records from table. (ssrungarapu: rev 0d3f0f64a49cbd33f26d7dfd97ec30aa7d78a752) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742326#comment-14742326 ] Jerry He commented on HBASE-14394: -- +1 on v4. > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740272#comment-14740272 ] Ashish Singhi commented on HBASE-14394: --- OK. I got your point. What about the above comment, "Also the htable instance in TRRI is already closed as part of TRRI#close() call, so the newly added one is not required" ? > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740287#comment-14740287 ] Srikanth Srungarapu commented on HBASE-14394: - Yeah, the table close method call is redundant. Uploaded new patch. > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740290#comment-14740290 ] Ashish Singhi commented on HBASE-14394: --- +1 (non-binding) > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[
https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740502#comment-14740502
]
Hadoop QA commented on HBASE-14394:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12755337/HBASE-14394_v3.patch
against master branch at commit fda317cebb5d306cabf1899e05cedb0225b2b62b.
ATTACHMENT ID: 12755337
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan1
org.apache.hadoop.hbase.mapreduce.TestSyncTable
org.apache.hadoop.hbase.mob.mapreduce.TestMobSweeper
org.apache.hadoop.hbase.mapreduce.TestHashTable
org.apache.hadoop.hbase.mapreduce.TestCellCounter
org.apache.hadoop.hbase.replication.TestReplicationSmallTests
org.apache.hadoop.hbase.mapreduce.TestTableInputFormat
org.apache.hadoop.hbase.TestStochasticBalancerJmxMetrics
{color:red}-1 core zombie tests{color}. There are 5 zombie test(s):
at
org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScanBase.testScan(TestTableInputFormatScanBase.java:243)
at
org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan2.testScanOBBToQPP(TestTableInputFormatScan2.java:58)
at
org.apache.hadoop.hbase.mapreduce.TestImportExport.testMetaExport(TestImportExport.java:216)
at
org.apache.hadoop.hbase.mapreduce.TestTableInputFormat.testInputFormat(TestTableInputFormat.java:373)
at
org.apache.hadoop.hbase.mapreduce.TestTableInputFormat.testDeprecatedExtensionOfTableInputFormatBase(TestTableInputFormat.java:361)
at
org.apache.hadoop.hbase.mapreduce.TestCellCounter.testCellCounteEndTimeRange(TestCellCounter.java:179)
at
org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScanBase.testScan(TestTableInputFormatScanBase.java:243)
at
org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan1.testScanEmptyToBBB(TestTableInputFormatScan1.java:84)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15556//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15556//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15556//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15556//console
This message is automatically generated.
> Properly close the connection after reading records from table.
> ---
>
> Key: HBASE-14394
> URL: https://issues.apache.org/jira/browse/HBASE-14394
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>Priority: Minor
> Attachments: HBASE-14394.patch, HBASE-14394_v2.patch,
> HBASE-14394_v3.patch
>
>
> This was brought to notice by one of our observant customers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[
https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741763#comment-14741763
]
Hadoop QA commented on HBASE-14394:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12755482/HBASE-14394_v4.patch
against master branch at commit dff5243c89544de8ed3127a7df5ec79cdab3373b.
ATTACHMENT ID: 12755482
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.mapred.TestLazyOutput.testLazyOutput(TestLazyOutput.java:195)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15569//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15569//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15569//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15569//console
This message is automatically generated.
> Properly close the connection after reading records from table.
> ---
>
> Key: HBASE-14394
> URL: https://issues.apache.org/jira/browse/HBASE-14394
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>Priority: Minor
> Attachments: HBASE-14394.patch, HBASE-14394_v2.patch,
> HBASE-14394_v3.patch, HBASE-14394_v4.patch
>
>
> This was brought to notice by one of our observant customers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[
https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740043#comment-14740043
]
Hadoop QA commented on HBASE-14394:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12755246/HBASE-14394_v2.patch
against master branch at commit bf26088d7be4386864148516b151dfb0a858c416.
ATTACHMENT ID: 12755246
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15542//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15542//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15542//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15542//console
This message is automatically generated.
> Properly close the connection after reading records from table.
> ---
>
> Key: HBASE-14394
> URL: https://issues.apache.org/jira/browse/HBASE-14394
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>Priority: Minor
> Attachments: HBASE-14394.patch, HBASE-14394_v2.patch
>
>
> This was brought to notice by one of our observant customers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740239#comment-14740239 ] Ashish Singhi commented on HBASE-14394: --- [~srikanth235], I don't see any change in the behavior this patch brings. We are still closing the resources in the catch block. Also the htable instance in TRRI is already closed as part of TRRI#close() call, so the newly added one is not required, > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[
https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740245#comment-14740245
]
Srikanth Srungarapu commented on HBASE-14394:
-
Currently, we are closing the resources only in case of exception i.e. in catch
block.
{code}
catch (IOException ioe) {
// If there is an exception make sure that all
// resources are closed and released.
- connection.close();
- table.close();
trr.close();
throw ioe;
{code}
This patch ensures resources get closed in _all_ cases.
> Properly close the connection after reading records from table.
> ---
>
> Key: HBASE-14394
> URL: https://issues.apache.org/jira/browse/HBASE-14394
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>Priority: Minor
> Attachments: HBASE-14394.patch, HBASE-14394_v2.patch
>
>
> This was brought to notice by one of our observant customers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
