[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220564#comment-16220564 ] stack commented on HBASE-19095: --- What should we add here? Why we need them when in-memory compaction is internal? Thanks. > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-alpha-4 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221201#comment-16221201 ] stack commented on HBASE-19095: --- Would it make sense setting inmemory compaction to NONE for alpha-4 so we could punt on this till beta-1? > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-alpha-4 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221393#comment-16221393
]
stack commented on HBASE-19095:
---
[~Apache9] comments from dev list on the 'Moving 2.0 forward' thread:
{code}
As Anoop suggested in HBASE-19001, we still need to give user the ability
to extend the max versions and TTL config, so I plan to add back the hooks
above to let CP users can change the max versions and TTL of a ScanInfo
object. But I'm not sure whether in memory compaction will also discard
expired cells, if so then we are in trouble...
OK, skimmed, we are in trouble! The in memory compaction just use the same
constructor with normal compaction to construct a StoreScanner, and use it
to do compaction...
We have to provide several preXXX and postXXX for it, at least we should
allow user reset TTL and max versions, and also do filtering on the scanner.
{code}
So, the in-memory compaction needs to call the hooks and it is not doing this
currenlty. Is that the concern [~Apache9]? Thanks sir.
> Add CP hooks in RegionObserver for in memory compaction
> ---
>
> Key: HBASE-19095
> URL: https://issues.apache.org/jira/browse/HBASE-19095
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
>
> This is a hole in our CP hooks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221408#comment-16221408 ] Duo Zhang commented on HBASE-19095: --- Yes. In memory compaction can drop cells so we need to provide CP hooks to reset versions and TTL otherwise the example in HBASE-19033 will fail. > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-alpha-4 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221684#comment-16221684 ] Duo Zhang commented on HBASE-19095: --- One way is to not drop cells when doing in memory compaction. But think of the example in HBASE-19033, if we could do the same aggregating thing when doing in memory compaction, then we could keep the counter in memory for ever and greatly increase the performance. So I think it worth to add the CP hooks support. Thanks. > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-alpha-4 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222881#comment-16222881 ] Josh Elser commented on HBASE-19095: bq. we could punt on this till beta-1 We're adding net-new CP APIs for a net-new feature, right? I'd say if [~Apache9] doesn't have a patch ready to go, we take this up in beta-1... > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-alpha-4 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223093#comment-16223093 ] Duo Zhang commented on HBASE-19095: --- I do not have a patch yet. And I think in memory compaction itself is not stable enough yet? So I think it is OK to delay this to beta-1? Say in release note of alpha4 that in memory compaction is still under development so the CP hooks for it will be added later is OK? Thanks. > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-alpha-4 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223095#comment-16223095 ] stack commented on HBASE-19095: --- Moved to beta-1. [~eshcar] and [~anastas] FYI. > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-beta-1 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223956#comment-16223956 ] Eshcar Hillel commented on HBASE-19095: --- The current default is the Basic in-memory compaction which *does not* drop any version while doing compaction. Do you still see a problem with this [~Apache9]? > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-beta-1 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223964#comment-16223964 ] Eshcar Hillel commented on HBASE-19095: --- bq. The in memory compaction just use the same constructor with normal compaction to construct a StoreScanner, and use it to do compaction... Which other StoreScanner constructor we should be using then when we do want to drop cells? > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-beta-1 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223966#comment-16223966
]
Duo Zhang commented on HBASE-19095:
---
{quote}
Which other StoreScanner constructor we should be using then when we do want to
drop cells?
{quote}
This is not the point I'd say. We do have in memory compaction mechanism other
than 'basic' which we want to drop cells so we need to provide the CP hooks.
The fix version is moved to beta1 so it will not block the alpha4 release.
Let's fix this before beta1 release.
And for not droppring cells, HBASE-19033 provides a CustomizedScanInfoBuilder
which can reset the max versions when open a StoreScanner. I tried to reset it
to Integer.MAX_VALUE and then I got several failed UTs for in memory
compaction. Maybe I modified the wrong place since I'm not very familiar with
in memory compaction.
Thanks.
> Add CP hooks in RegionObserver for in memory compaction
> ---
>
> Key: HBASE-19095
> URL: https://issues.apache.org/jira/browse/HBASE-19095
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Duo Zhang
> Fix For: 2.0.0-beta-1
>
>
> This is a hole in our CP hooks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224011#comment-16224011
]
Eshcar Hillel commented on HBASE-19095:
---
Indeed currently MemStoreCompactorSegmentsIterator::createScanner() creates a
StoreScanner to do in-memory compaction, and it invokes the StoreScanner
constructor without adding the CP hooks.
What if we add a ScanInfo object to this method parameters and then invoke it
like the code in HBASE-19033.
So the constructor of MemStoreCompactorSegmentsIterator will include the
following code
{code}
ScanInfo scanInfo;
if (store.getCoprocessorHost() != null) {
scanInfo =
store.getCoprocessorHost().preInMemoryCompactScannerOpen(store, user);
} else {
scanInfo = store.getScanInfo();
}
compactingScanner = createScanner(store, scanInfo, scanners);
{code}
This requires adding one more method to RegionObserver -
preInMemoryCompactScannerOpen(store, user), similar to the three methods in
HBASE-19033.
Is this enough to solve the problem?
> Add CP hooks in RegionObserver for in memory compaction
> ---
>
> Key: HBASE-19095
> URL: https://issues.apache.org/jira/browse/HBASE-19095
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Duo Zhang
> Fix For: 2.0.0-beta-1
>
>
> This is a hole in our CP hooks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224013#comment-16224013 ] Duo Zhang commented on HBASE-19095: --- Sounds good. Maybe we also need to tell CP users the compaction type, 'basic' or something else. And how do we control whether to drop cells when doing in memory compaction? We do not use StoreScanner in basic mode? If we use the same code base for different compaction types, then it is possible that CP users can drop cells even if we are doing a basic in memory compaction. Is it acceptable? Thanks. > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-beta-1 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224169#comment-16224169 ] Eshcar Hillel commented on HBASE-19095: --- Basic mode does not use StoreScanner. Basic applies two kinds of steps - a flattening step and a merge step. A merge step creates a MemStoreMergerSegmentsIterator. This iterator manages a KeyValueHeap it uses it to merge the index of several segments, and does not drop any cell. A flattening step simply uses a segment scanner to create a flat index, and does not drop any cell. I would not open these to CP hooks. Other modes (like Eager, and Adaptive which I am about to commit to trunk) may apply a compact step which imitates disk data compaction in-memory. A compact step creates a MemStoreCompactorSegmentsIterator which uses a StoreScanner as described above. Here, I agree there is room to give the user control on the number of versions to keep, TTL etc. > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-beta-1 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224873#comment-16224873
]
Duo Zhang commented on HBASE-19095:
---
Thanks for the explanation. Skimmed the code again, much easier to understand
now.
There is a flatten operation which is used to make a segment immutable. And
then we can do merge/compact. In basic mode, we do merging, so we use
{{MemStoreMergerSegmentsIterator}}, where we use a KeyValueHeap directly to
skip the SQM logic. In eager mode, we do compaction, so we use
{{MemStoreCompactorSegmentsIterator }}, where we use a StoreScanner and will
drop cells.
Agree that we could provide a preInMemoryCompactScannerOpen method which allow
users to change the max versions and TTL. And we could also change the
StoreScanner field in {{MemStoreCompactorSegmentsIterator}} to InternalScanner,
and add a preInMemoryCompact method which allow users to do filtering.
And seems there is no selection so we do not need
(pre/post)InMemoryCompactSelection methods, so the only unsure method is
postInMemoryCompact. For compaction and flush we have a similar method, but I
do not think it is very useful for in memory compaction? Anyway, no harm to add
it I think.
Let me provide a patch.
Thanks.
> Add CP hooks in RegionObserver for in memory compaction
> ---
>
> Key: HBASE-19095
> URL: https://issues.apache.org/jira/browse/HBASE-19095
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Duo Zhang
> Fix For: 2.0.0-beta-1
>
>
> This is a hole in our CP hooks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226691#comment-16226691
]
Eshcar Hillel commented on HBASE-19095:
---
[~Apache9] can you please explain again why do we need the
{{preMemStoreCompaction(store)}} and the {{postMemStoreCompaction(store)}}
before and after {{doCompaction()}} ? What kind of manipulation do we want to
allow the user? Is it some preparation work before the compaction that cannot
be done in {{preMemStoreCompactionCompactScannerOpen(store)}}?, Is it something
equivalent to what is done on store file compaction?
> Add CP hooks in RegionObserver for in memory compaction
> ---
>
> Key: HBASE-19095
> URL: https://issues.apache.org/jira/browse/HBASE-19095
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19095.patch
>
>
> This is a hole in our CP hooks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226722#comment-16226722
]
Duo Zhang commented on HBASE-19095:
---
Just follow the normal flush and compaction way. See my comment above
{quote}
And seems there is no selection so we do not need
(pre/post)InMemoryCompactSelection methods, so the only unsure method is
postInMemoryCompact. For compaction and flush we have a similar method, but I
do not think it is very useful for in memory compaction? Anyway, no harm to add
it I think.
{quote}
Thanks.
> Add CP hooks in RegionObserver for in memory compaction
> ---
>
> Key: HBASE-19095
> URL: https://issues.apache.org/jira/browse/HBASE-19095
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19095.patch
>
>
> This is a hole in our CP hooks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226775#comment-16226775
]
Hadoop QA commented on HBASE-19095:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
3s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
10s{color} | {color:red} hbase-server: The patch generated 2 new + 330
unchanged - 3 fixed = 332 total (was 333) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
46s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
49m 43s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}103m
25s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
45s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
39s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}177m 36s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19095 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12894951/HBASE-19095.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux aee846608e1f 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 5000652e5e |
| Default Java | 1.8.0_141 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/9532/artifact/patchprocess/diff-checkstyle-hbas
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234288#comment-16234288
]
Hadoop QA commented on HBASE-19095:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
51s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
53s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
8s{color} | {color:green} hbase-server: The patch generated 0 new + 134
unchanged - 3 fixed = 134 total (was 137) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} The patch hbase-examples passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
49s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
46m 15s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 94m
50s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
38s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
36s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}165m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19095 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12895187/HBASE-19095-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 9776293b95c0 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git rev
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235265#comment-16235265
]
Hadoop QA commented on HBASE-19095:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
33s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
7s{color} | {color:red} hbase-server: The patch generated 2 new + 134 unchanged
- 3 fixed = 136 total (was 137) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
42s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
49m 52s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}126m 20s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
35s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
36s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}201m 27s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19095 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12895335/HBASE-19095-v2.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 803d9ddda3c7 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 8d1e6a3e23 |
| Default Java | 1.8.0_141 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/9571/artifact/patchprocess/diff-checkstyle-hbase-ser
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238275#comment-16238275 ] Chia-Ping Tsai commented on HBASE-19095: TestReplicationKillMasterRS pass locally. Adding the new hooks to access control checks can be addressed in HBASE-18799. +1 to commit it after the checkstyle warnings are fixed. > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19095-v1.patch, HBASE-19095-v2.patch, > HBASE-19095.patch > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239102#comment-16239102
]
Hadoop QA commented on HBASE-19095:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 7m
43s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
14s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
25s{color} | {color:red} hbase-server: The patch generated 1 new + 134
unchanged - 3 fixed = 135 total (was 137) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
37s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
50m 29s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}110m 19s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
47s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
38s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}192m 48s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19095 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12896051/HBASE-19095-v3.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 9ca08524ad8a 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / ac6b998afe |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_141 |
| checkstyle
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239105#comment-16239105 ] stack commented on HBASE-19095: --- Skimmed patch. LGTM. Was waiting on [~eshcar] to take a look (they come on line tomorrow...) > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19095-v1.patch, HBASE-19095-v2.patch, > HBASE-19095-v3.patch, HBASE-19095.patch > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239437#comment-16239437 ] Eshcar Hillel commented on HBASE-19095: --- I already reviewed the code last week. All hooks seem to be in the correct location in the code. +1 here > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19095-v1.patch, HBASE-19095-v2.patch, > HBASE-19095-v3.patch, HBASE-19095.patch > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239454#comment-16239454 ] Duo Zhang commented on HBASE-19095: --- Thanks [~eshcar], let me commit. For the failed UT, it seems that a UT will call System.exit so the maven build can not finish properly. Do we already have a issue for it sir [~stack]? Thanks. > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19095-v1.patch, HBASE-19095-v2.patch, > HBASE-19095-v3.patch, HBASE-19095.patch > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239611#comment-16239611 ] Hudson commented on HBASE-19095: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4002 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4002/]) HBASE-19095 Add CP hooks in RegionObserver for in memory compaction (zhangduo: rev 28cdf4afb8a864c0cfccf278960a6597708f7dd6) * (add) hbase-examples/src/test/java/org/apache/hadoop/hbase/coprocessor/example/TestWriteHeavyIncrementObserverWithMemStoreCompaction.java * (edit) hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/WriteHeavyIncrementObserver.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * (edit) hbase-examples/src/test/java/org/apache/hadoop/hbase/coprocessor/example/TestWriteHeavyIncrementObserver.java * (add) hbase-examples/src/test/java/org/apache/hadoop/hbase/coprocessor/example/WriteHeavyIncrementObserverTestBase.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactorSegmentsIterator.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19095-v1.patch, HBASE-19095-v2.patch, > HBASE-19095-v3.patch, HBASE-19095.patch > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239631#comment-16239631 ] Hudson commented on HBASE-19095: SUCCESS: Integrated in Jenkins build HBase-2.0 #802 (See [https://builds.apache.org/job/HBase-2.0/802/]) HBASE-19095 Add CP hooks in RegionObserver for in memory compaction (zhangduo: rev 143e4949fe6d83b7864ab2a0ae39d09b1686fc8c) * (add) hbase-examples/src/test/java/org/apache/hadoop/hbase/coprocessor/example/TestWriteHeavyIncrementObserverWithMemStoreCompaction.java * (add) hbase-examples/src/test/java/org/apache/hadoop/hbase/coprocessor/example/WriteHeavyIncrementObserverTestBase.java * (edit) hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/WriteHeavyIncrementObserver.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * (edit) hbase-examples/src/test/java/org/apache/hadoop/hbase/coprocessor/example/TestWriteHeavyIncrementObserver.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactorSegmentsIterator.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19095-v1.patch, HBASE-19095-v2.patch, > HBASE-19095-v3.patch, HBASE-19095.patch > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239750#comment-16239750 ] stack commented on HBASE-19095: --- [~Apache9] Where is the system.exit? Grepping codebase, we have a bunch but they seem to be in ok places? > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19095-v1.patch, HBASE-19095-v2.patch, > HBASE-19095-v3.patch, HBASE-19095.patch > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239798#comment-16239798
]
Duo Zhang commented on HBASE-19095:
---
I do not know the exact one but the pre commit console said:
{quote}
Caused by: org.apache.maven.surefire.booter.SurefireBooterForkException: The
forked VM terminated without properly saying goodbye. VM crash or System.exit
called?
{quote}
Or it was killed by someone?
> Add CP hooks in RegionObserver for in memory compaction
> ---
>
> Key: HBASE-19095
> URL: https://issues.apache.org/jira/browse/HBASE-19095
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19095-v1.patch, HBASE-19095-v2.patch,
> HBASE-19095-v3.patch, HBASE-19095.patch
>
>
> This is a hole in our CP hooks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240557#comment-16240557 ] Josh Elser commented on HBASE-19095: bq. Or it was killed by someone? My suspicions of late have been that this is something on the Jenkins worker itself, but I've yet to find any definitive proof :) > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19095-v1.patch, HBASE-19095-v2.patch, > HBASE-19095-v3.patch, HBASE-19095.patch > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241536#comment-16241536 ] stack commented on HBASE-19095: --- bq. Or it was killed by someone? Yeah. Probably the OS. You saw the deadly battle going on over in HDFS-12711 trying to contain hadoop burning down the build boxes? That should be 'fixed' now. Maybe something else. Sean added nice stuff to yetus so can see what environment is like... Will report back. > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19095-v1.patch, HBASE-19095-v2.patch, > HBASE-19095-v3.patch, HBASE-19095.patch > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242268#comment-16242268 ] Josh Elser commented on HBASE-19095: Yup, we're on the same page :) > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19095-v1.patch, HBASE-19095-v2.patch, > HBASE-19095-v3.patch, HBASE-19095.patch > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
