[jira] [Commented] (HBASE-19181) LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog

2017-11-16 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256424#comment-16256424
 ] 

Hudson commented on HBASE-19181:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4065 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4065/])
HBASE-19181 LogRollBackupSubprocedure will fail if we use AsyncFSWAL (stack: 
rev 5b13b624bb3487c6a6805fd5368227ccbe357c7b)
* (edit) 
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/regionserver/LogRollBackupSubprocedure.java


> LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog
> --
>
> Key: HBASE-19181
> URL: https://issues.apache.org/jira/browse/HBASE-19181
> Project: HBase
>  Issue Type: Bug
>  Components: backup
>Reporter: Duo Zhang
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19181-v1.patch, HBASE-19181-v2.patch
>
>
> In the RSRollLogTask it will cast a WAL to FSHLog.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19181) LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog

2017-11-16 Thread Duo Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256358#comment-16256358
 ] 

Duo Zhang commented on HBASE-19181:
---

Belated +1.

> LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog
> --
>
> Key: HBASE-19181
> URL: https://issues.apache.org/jira/browse/HBASE-19181
> Project: HBase
>  Issue Type: Bug
>  Components: backup
>Reporter: Duo Zhang
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19181-v1.patch, HBASE-19181-v2.patch
>
>
> In the RSRollLogTask it will cast a WAL to FSHLog.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19181) LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog

2017-11-16 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256327#comment-16256327
 ] 

Hudson commented on HBASE-19181:


FAILURE: Integrated in Jenkins build HBase-2.0 #864 (See 
[https://builds.apache.org/job/HBase-2.0/864/])
HBASE-19181 LogRollBackupSubprocedure will fail if we use AsyncFSWAL (stack: 
rev f7ce3fd48a6bf82159788d78427d03a7de2df390)
* (edit) 
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/regionserver/LogRollBackupSubprocedure.java


> LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog
> --
>
> Key: HBASE-19181
> URL: https://issues.apache.org/jira/browse/HBASE-19181
> Project: HBase
>  Issue Type: Bug
>  Components: backup
>Reporter: Duo Zhang
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19181-v1.patch, HBASE-19181-v2.patch
>
>
> In the RSRollLogTask it will cast a WAL to FSHLog.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19181) LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog

2017-11-16 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256139#comment-16256139
 ] 

Hadoop QA commented on HBASE-19181:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
29s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
18s{color} | {color:green} hbase-backup: The patch generated 0 new + 2 
unchanged - 1 fixed = 2 total (was 3) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
17s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
68m 41s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 15m 
24s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
13s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}103m 15s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19181 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12898058/HBASE-19181-v2.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux e685823041e5 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 6f9651b417 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9872/testReport/ |
| modules | C: hbase-backup U: hbase-backup |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9872/console |
| Powered by | Apache Yetus 0.6.0   http://yetus.apache.org |


This message was automatically

[jira] [Commented] (HBASE-19181) LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog

2017-11-16 Thread Vladimir Rodionov (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255744#comment-16255744
 ] 

Vladimir Rodionov commented on HBASE-19181:
---

I will update patch today.

> LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog
> --
>
> Key: HBASE-19181
> URL: https://issues.apache.org/jira/browse/HBASE-19181
> Project: HBase
>  Issue Type: Bug
>  Components: backup
>Reporter: Duo Zhang
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19181-v1.patch
>
>
> In the RSRollLogTask it will cast a WAL to FSHLog.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19181) LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog

2017-11-16 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255645#comment-16255645
 ] 

stack commented on HBASE-19181:
---

Any progress on this? Patch looks good. There is just the [~Apache9] comment to 
deal w/ above.



> LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog
> --
>
> Key: HBASE-19181
> URL: https://issues.apache.org/jira/browse/HBASE-19181
> Project: HBase
>  Issue Type: Bug
>  Components: backup
>Reporter: Duo Zhang
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19181-v1.patch
>
>
> In the RSRollLogTask it will cast a WAL to FSHLog.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19181) LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog

2017-11-11 Thread Duo Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248502#comment-16248502
 ] 

Duo Zhang commented on HBASE-19181:
---

Use AbstractFSWAK to avoid the @SuppressWarnings("rawtypes").

> LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog
> --
>
> Key: HBASE-19181
> URL: https://issues.apache.org/jira/browse/HBASE-19181
> Project: HBase
>  Issue Type: Bug
>  Components: backup
>Reporter: Duo Zhang
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19181-v1.patch
>
>
> In the RSRollLogTask it will cast a WAL to FSHLog.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19181) LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog

2017-11-10 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248132#comment-16248132
 ] 

Hadoop QA commented on HBASE-19181:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
36s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} hbase-backup: The patch generated 0 new + 2 
unchanged - 1 fixed = 2 total (was 3) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
23s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
49m 48s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 16m 
16s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 81m 22s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19181 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12896791/HBASE-19181-v1.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 1a372372360b 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / 72270866cb |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9739/testReport/ |
| modules | C: hbase-backup U: hbase-backup |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9739/console |
| Powered by | Apache Yetus 0.6.0   http://yetus.apache.org |


This message was automatically

[jira] [Commented] (HBASE-19181) LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog

2017-11-04 Thread Duo Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239016#comment-16239016
 ] 

Duo Zhang commented on HBASE-19181:
---

And in the code below we cast WAL to AbstractFSWAL, so why not also use 
AbstractFSWAL here?

And the {{hlog}} is a class member variable but is only used locally in one 
method, can change it to a local variable? Or just remove it? Seems it is only 
used to do logging but I'm a little confused. We request rolling on a list of 
WALs but the log is only for the default WAL?

Thanks.

> LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog
> --
>
> Key: HBASE-19181
> URL: https://issues.apache.org/jira/browse/HBASE-19181
> Project: HBase
>  Issue Type: Bug
>  Components: backup
>Reporter: Duo Zhang
>Priority: Major
>
> In the RSRollLogTask it will cast a WAL to FSHLog.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)