[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432055#comment-16432055
]
Hadoop QA commented on HBASE-19850:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
50s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
31s{color} | {color:green} branch-1 passed with JDK v1.8.0_163 {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
14s{color} | {color:red} hbase-server in branch-1 failed with JDK v1.7.0_171.
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
11s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
20s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} branch-1 passed with JDK v1.8.0_163 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} the patch passed with JDK v1.8.0_163 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
15s{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_171.
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 15s{color}
| {color:red} hbase-server in the patch failed with JDK v1.7.0_171. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
19s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
50s{color} | {color:red} The patch causes 44 errors with Hadoop v2.4.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
39s{color} | {color:red} The patch causes 44 errors with Hadoop v2.5.2. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} the patch passed with JDK v1.8.0_163 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}106m 27s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}133m 32s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.replication.regionserver.TestGlobalThrottler |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
| JIRA Issue | HBASE-19850 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12918336/HBASE-19850.branch-1.
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440360#comment-16440360
]
Toshihiro Suzuki commented on HBASE-19850:
--
I just re-attached the latest patch to run a build again.
In the latest patch, I also remove region replica infos from in-memory states
when restoring a snapshot. Could you please review the patch
[~yuzhih...@gmail.com]? Thanks.
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch,
> HBASE-19850.branch-1.001.patch, HBASE-19850.branch-1.001.patch, The number of
> Offline Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code:java}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code:java}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code:java}
> (0...2000).each{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code:java}
> split "test"
> {code}
> 5. Restore the table from the snapshot
> {code:java}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong. And as far as I reviewed the code, it seems
> like the Offline Regions will not be cleaned up. After restarting Master, the
> offline regions disappear.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440458#comment-16440458
]
Hadoop QA commented on HBASE-19850:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
49s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
32s{color} | {color:green} branch-1 passed with JDK v1.8.0_163 {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
17s{color} | {color:red} hbase-server in branch-1 failed with JDK v1.7.0_171.
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
35s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} branch-1 passed with JDK v1.8.0_163 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
30s{color} | {color:green} the patch passed with JDK v1.8.0_163 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
17s{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_171.
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 17s{color}
| {color:red} hbase-server in the patch failed with JDK v1.7.0_171. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
34s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
27s{color} | {color:red} The patch causes 44 errors with Hadoop v2.4.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
51s{color} | {color:red} The patch causes 44 errors with Hadoop v2.5.2. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed with JDK v1.8.0_163 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}101m 55s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}126m 14s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.replication.regionserver.TestGlobalThrottler |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
| JIRA Issue | HBASE-19850 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12919332/HBASE-19850.branch-1.
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440671#comment-16440671
]
Toshihiro Suzuki commented on HBASE-19850:
--
I don't think TestGlobalThrottler is related to the pache.
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch,
> HBASE-19850.branch-1.001.patch, HBASE-19850.branch-1.001.patch, The number of
> Offline Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code:java}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code:java}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code:java}
> (0...2000).each{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code:java}
> split "test"
> {code}
> 5. Restore the table from the snapshot
> {code:java}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong. And as far as I reviewed the code, it seems
> like the Offline Regions will not be cleaned up. After restarting Master, the
> offline regions disappear.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440982#comment-16440982
]
Ted Yu commented on HBASE-19850:
The patch looks good.
Can you check
https://builds.apache.org/job/PreCommit-HBASE-Build/12488/artifact/patchprocess/patch-javac-2.5.2.txt
and see why the compilation failed ?
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch,
> HBASE-19850.branch-1.001.patch, HBASE-19850.branch-1.001.patch, The number of
> Offline Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code:java}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code:java}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code:java}
> (0...2000).each{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code:java}
> split "test"
> {code}
> 5. Restore the table from the snapshot
> {code:java}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong. And as far as I reviewed the code, it seems
> like the Offline Regions will not be cleaned up. After restarting Master, the
> offline regions disappear.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441263#comment-16441263
]
Ted Yu commented on HBASE-19850:
The compilation error was related to HBASE-19858.
See the tail of HBASE-19858.
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch,
> HBASE-19850.branch-1.001.patch, HBASE-19850.branch-1.001.patch, The number of
> Offline Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code:java}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code:java}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code:java}
> (0...2000).each{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code:java}
> split "test"
> {code}
> 5. Restore the table from the snapshot
> {code:java}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong. And as far as I reviewed the code, it seems
> like the Offline Regions will not be cleaned up. After restarting Master, the
> offline regions disappear.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441271#comment-16441271
]
Ted Yu commented on HBASE-19850:
When applying the patch to branch-1 using 'git am', I got:
{code}
Applying: HBASE-19850 The number of Offline Regions is wrong after restoring a
snapshot
error: patch failed:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java:175
error:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java:
patch does not apply
error: patch failed:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestRestoreSnapshotFromClient.java:39
error:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestRestoreSnapshotFromClient.java:
patch does not apply
Patch failed at 0001 HBASE-19850 The number of Offline Regions is wrong after
restoring a snapshot
The copy of the patch that failed is found in:
{code}
Can you check ?
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch,
> HBASE-19850.branch-1.001.patch, HBASE-19850.branch-1.001.patch, The number of
> Offline Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code:java}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code:java}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code:java}
> (0...2000).each{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code:java}
> split "test"
> {code}
> 5. Restore the table from the snapshot
> {code:java}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong. And as far as I reviewed the code, it seems
> like the Offline Regions will not be cleaned up. After restarting Master, the
> offline regions disappear.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441838#comment-16441838
]
Toshihiro Suzuki commented on HBASE-19850:
--
[~yuzhih...@gmail.com] I was able to apply the patch to branch-1 using 'git am'
locally. Thanks.
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch,
> HBASE-19850.branch-1.001.patch, HBASE-19850.branch-1.001.patch, The number of
> Offline Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code:java}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code:java}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code:java}
> (0...2000).each{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code:java}
> split "test"
> {code}
> 5. Restore the table from the snapshot
> {code:java}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong. And as far as I reviewed the code, it seems
> like the Offline Regions will not be cleaned up. After restarting Master, the
> offline regions disappear.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441850#comment-16441850
]
Toshihiro Suzuki commented on HBASE-19850:
--
Thank you for reviewing and committing the patch, Ted.
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch,
> HBASE-19850.branch-1.001.patch, HBASE-19850.branch-1.001.patch, The number of
> Offline Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code:java}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code:java}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code:java}
> (0...2000).each{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code:java}
> split "test"
> {code}
> 5. Restore the table from the snapshot
> {code:java}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong. And as far as I reviewed the code, it seems
> like the Offline Regions will not be cleaned up. After restarting Master, the
> offline regions disappear.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442159#comment-16442159
]
Hudson commented on HBASE-19850:
Results for branch branch-1
[build #287 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/287/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/287//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/287//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/287//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch,
> HBASE-19850.branch-1.001.patch, HBASE-19850.branch-1.001.patch, The number of
> Offline Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code:java}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code:java}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code:java}
> (0...2000).each{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code:java}
> split "test"
> {code}
> 5. Restore the table from the snapshot
> {code:java}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong. And as far as I reviewed the code, it seems
> like the Offline Regions will not be cleaned up. After restarting Master, the
> offline regions disappear.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336236#comment-16336236
]
Toshihiro Suzuki commented on HBASE-19850:
--
I attached a v1 patch for this issue. I think we need to delete regions to
remove from AssignmentManager and ServerManager when restoring a snapshot.
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch, The number of Offline
> Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code}
> (0...2000).each\{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code}
> split "test"
> {code}
> 5. Restore the table from the snapshot
>
> {code}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336451#comment-16336451
]
Hadoop QA commented on HBASE-19850:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 19m
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
35s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} branch-1 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} branch-1 passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
13s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
37s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
59s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} branch-1 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} branch-1 passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
10s{color} | {color:red} hbase-server: The patch generated 1 new + 6 unchanged
- 0 fixed = 7 total (was 6) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
16s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 19s{color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.5 2.7.4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 98m 51s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}149m 49s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.TestCatalogJanitorInMemoryStates |
| | hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas |
| | hadoop.hbase.client.TestClientOperationInterrupt |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
| JIRA
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343029#comment-16343029
]
Toshihiro Suzuki commented on HBASE-19850:
--
I attached the v2 patch. It seems like when RegionReplicas is enabled and a
primary region is split, its secondary region will become OFFLINE. So the
number of Offline Region will not zero in this case. I made the test ignored in
the RegionReplicas enabled situation.
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch,
> HBASE-19850-v2-branch-1.patch, The number of Offline Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code}
> (0...2000).each\{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code}
> split "test"
> {code}
> 5. Restore the table from the snapshot
>
> {code}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343036#comment-16343036
]
Toshihiro Suzuki commented on HBASE-19850:
--
In the RegionReplicas enabled situation, it seems to me that the offline
regions will not be cleaned up as well, which might be a bug. Similar to the
restoring a snapshot situation, when restarting Master, the offline regions are
cleaned up.
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch,
> HBASE-19850-v2-branch-1.patch, The number of Offline Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code:java}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code:java}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code:java}
> (0...2000).each\{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code:java}
> split "test"
> {code}
> 5. Restore the table from the snapshot
>
> {code:java}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong. And as far as I reviewed the code, it seems
> like the Offline Regions will not be cleaned up. After restarting Master, the
> offline regions disappear.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343157#comment-16343157
]
Hadoop QA commented on HBASE-19850:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
41s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
51s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
10s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
17s{color} | {color:red} hbase-server: The patch generated 1 new + 6 unchanged
- 0 fixed = 7 total (was 6) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
35s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 40s{color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.5 2.7.4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 97m 28s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}124m 23s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
| JIRA Issue | HBASE-19850 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12907332/HBASE-19850-branc
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343164#comment-16343164
]
Toshihiro Suzuki commented on HBASE-19850:
--
Reattached v2 patch to rerun the tests.
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch,
> HBASE-19850-v2-branch-1.patch, HBASE-19850-v2-branch-1.patch, The number of
> Offline Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code:java}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code:java}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code:java}
> (0...2000).each\{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code:java}
> split "test"
> {code}
> 5. Restore the table from the snapshot
>
> {code:java}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong. And as far as I reviewed the code, it seems
> like the Offline Regions will not be cleaned up. After restarting Master, the
> offline regions disappear.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343299#comment-16343299
]
Hadoop QA commented on HBASE-19850:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
53s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
29s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
3s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
11s{color} | {color:red} hbase-server: The patch generated 1 new + 6 unchanged
- 0 fixed = 7 total (was 6) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
17s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
7m 52s{color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.5 2.7.4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 97m 58s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}123m 4s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
| JIRA Issue | HBASE-19850 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12907332/HBASE-19850-branc
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343368#comment-16343368
]
Toshihiro Suzuki commented on HBASE-19850:
--
A build for v1 patch was executed for some reason. I remaned to the v2 patch
and attached it.
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch,
> HBASE-19850-branch-1.v2.patch, HBASE-19850-v2-branch-1.patch,
> HBASE-19850-v2-branch-1.patch, The number of Offline Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code:java}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code:java}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code:java}
> (0...2000).each\{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code:java}
> split "test"
> {code}
> 5. Restore the table from the snapshot
>
> {code:java}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong. And as far as I reviewed the code, it seems
> like the Offline Regions will not be cleaned up. After restarting Master, the
> offline regions disappear.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343583#comment-16343583
]
Hadoop QA commented on HBASE-19850:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 19m
55s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
19s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
12s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
56s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
7s{color} | {color:red} hbase-server: The patch generated 1 new + 6 unchanged -
0 fixed = 7 total (was 6) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
15s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
7m 40s{color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.5 2.7.4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}100m 51s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}144m 10s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas |
| | hadoop.hbase.util.TestHBaseFsck |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
| JIRA Issue | HBASE-19850 |
| JIRA Patch URL |
https://issues.apache.org/jira/secu
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343881#comment-16343881
]
Toshihiro Suzuki commented on HBASE-19850:
--
As the build for v1 patch was executed again for some reason, I deleted the v1
patch and attached the remaned v2 patch.
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch, The number of Offline
> Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code:java}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code:java}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code:java}
> (0...2000).each\{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code:java}
> split "test"
> {code}
> 5. Restore the table from the snapshot
>
> {code:java}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong. And as far as I reviewed the code, it seems
> like the Offline Regions will not be cleaned up. After restarting Master, the
> offline regions disappear.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344134#comment-16344134
]
Hadoop QA commented on HBASE-19850:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 15m
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
56s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
29s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
13s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
31s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
48s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 3s{color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.5 2.7.4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 98m
10s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}149m 9s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
| JIRA Issue | HBASE-19850 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12908195/HBASE-19850-branch-1.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux a0aef5878691 3.13
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344143#comment-16344143
]
Ted Yu commented on HBASE-19850:
Looks good overall.
Mind attaching patch for master branch ?
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch, The number of Offline
> Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code:java}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code:java}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code:java}
> (0...2000).each\{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code:java}
> split "test"
> {code}
> 5. Restore the table from the snapshot
>
> {code:java}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong. And as far as I reviewed the code, it seems
> like the Offline Regions will not be cleaned up. After restarting Master, the
> offline regions disappear.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19850) The number of Offline Regions is wrong after restoring a snapshot
[
https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344654#comment-16344654
]
Toshihiro Suzuki commented on HBASE-19850:
--
Thank you [~yuzhih...@gmail.com].
When I was trying to reproduce the issue in master branch, I faced another
issue which I filed in HBASE-19893. It seems like master branch has another
problem, so this Jira can be only for branch-1 branch.
> The number of Offline Regions is wrong after restoring a snapshot
> -
>
> Key: HBASE-19850
> URL: https://issues.apache.org/jira/browse/HBASE-19850
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19850-branch-1.patch, The number of Offline
> Regions.png
>
>
> Steps to reproduce are as follows:
> 1. Create a table
> {code:java}
> create "test", "cf"
> {code}
> 2. Take a snapshot for the table
> {code:java}
> snapshot "test", "snap"
> {code}
> 3. Load data to the table
> {code:java}
> (0...2000).each\{|i| put "test", "row#{i}", "cf:col", "val"}
> {code}
> 4. Split regions of the table
> {code:java}
> split "test"
> {code}
> 5. Restore the table from the snapshot
>
> {code:java}
> disable "test"
> restore_snapshot "snap"
> enable "test"
> {code}
>
> The number of Offline Regions is as follows:
> !The number of Offline Regions.png!
> The number of Offline Regions should be zero.
> It seems like when regions are removed by restoring a snapshot, the number of
> Offline Regions becomes wrong. And as far as I reviewed the code, it seems
> like the Offline Regions will not be cleaned up. After restarting Master, the
> offline regions disappear.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
