[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[
https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802065#comment-16802065
]
Hudson commented on HBASE-22074:
Results for branch master
[build #887 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/887/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/887//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/887//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/887//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Should use procedure store to persist the state in reportRegionStateTransition
> --
>
> Key: HBASE-22074
> URL: https://issues.apache.org/jira/browse/HBASE-22074
> Project: HBase
> Issue Type: Bug
> Components: amv2, proc-v2
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch,
> HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074-v4.patch,
> HBASE-22074-v5.patch, HBASE-22074-v6.patch, HBASE-22074-v7.patch,
> HBASE-22074.patch
>
>
> For now we will update the meta region directly. This may cause lots of
> problems and after a bunch of fixes, we still can not solve the problem in
> HBASE-22060.
> So maybe the approach itself is not a good choice, let's try another way to
> see if it could work better.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[
https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802052#comment-16802052
]
Hudson commented on HBASE-22074:
Results for branch branch-2
[build #1776 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1776/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1776//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1776//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1776//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Should use procedure store to persist the state in reportRegionStateTransition
> --
>
> Key: HBASE-22074
> URL: https://issues.apache.org/jira/browse/HBASE-22074
> Project: HBase
> Issue Type: Bug
> Components: amv2, proc-v2
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch,
> HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074-v4.patch,
> HBASE-22074-v5.patch, HBASE-22074-v6.patch, HBASE-22074-v7.patch,
> HBASE-22074.patch
>
>
> For now we will update the meta region directly. This may cause lots of
> problems and after a bunch of fixes, we still can not solve the problem in
> HBASE-22060.
> So maybe the approach itself is not a good choice, let's try another way to
> see if it could work better.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[
https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802050#comment-16802050
]
Hudson commented on HBASE-22074:
Results for branch branch-2.2
[build #133 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/133/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/133//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/133//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/133//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Should use procedure store to persist the state in reportRegionStateTransition
> --
>
> Key: HBASE-22074
> URL: https://issues.apache.org/jira/browse/HBASE-22074
> Project: HBase
> Issue Type: Bug
> Components: amv2, proc-v2
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch,
> HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074-v4.patch,
> HBASE-22074-v5.patch, HBASE-22074-v6.patch, HBASE-22074-v7.patch,
> HBASE-22074.patch
>
>
> For now we will update the meta region directly. This may cause lots of
> problems and after a bunch of fixes, we still can not solve the problem in
> HBASE-22060.
> So maybe the approach itself is not a good choice, let's try another way to
> see if it could work better.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801840#comment-16801840 ] stack commented on HBASE-22074: --- Thanks. Updated doc. > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074-v4.patch, > HBASE-22074-v5.patch, HBASE-22074-v6.patch, HBASE-22074-v7.patch, > HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801831#comment-16801831 ] Duo Zhang commented on HBASE-22074: --- The transition code is OPEN, CLOSED, FAILED_OPEN, and we also need to record the open sequence number if the region is opened. And for the doc, have sent the invitation to you. Thanks. > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074-v4.patch, > HBASE-22074-v5.patch, HBASE-22074-v6.patch, HBASE-22074-v7.patch, > HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801815#comment-16801815 ] stack commented on HBASE-22074: --- Thanks for the design. It helps understand what is going on. I added it to here as a link. On design, one question: why a transition code AND a sequence id? The code is not explained. If you give me edit rights, I can update doc. Let me take a look at rb... > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074-v4.patch, > HBASE-22074-v5.patch, HBASE-22074-v6.patch, HBASE-22074-v7.patch, > HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801548#comment-16801548 ] Duo Zhang commented on HBASE-22074: --- Tried several failed UTs, all passed locally. Should be a slow machine. Let me commit after fixing the checkstyle issue. > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074-v4.patch, > HBASE-22074-v5.patch, HBASE-22074-v6.patch, HBASE-22074-v7.patch, > HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[
https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801492#comment-16801492
]
Hadoop QA commented on HBASE-22074:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
9s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 4m
46s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 51s{color}
| {color:red} hbase-client generated 2 new + 127 unchanged - 2 fixed = 129
total (was 129) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 50s{color}
| {color:red} hbase-server generated 16 new + 178 unchanged - 16 fixed = 194
total (was 194) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} hbase-client: The patch generated 0 new + 295
unchanged - 3 fixed = 295 total (was 298) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
7s{color} | {color:red} hbase-server: The patch generated 1 new + 155 unchanged
- 0 fixed = 156 total (was 155) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
34s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 28s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
34s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
17s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}266m 6s{color}
| {color:red} hbase-server in the patch failed. {color} |
|
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801342#comment-16801342 ] Guanghao Zhang commented on HBASE-22074: +1 for v7 patch after run HADOOP QA. > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074-v4.patch, > HBASE-22074-v5.patch, HBASE-22074-v6.patch, HBASE-22074-v7.patch, > HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[
https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800898#comment-16800898
]
Hadoop QA commented on HBASE-22074:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
32s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 4m
44s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 52s{color}
| {color:red} hbase-client generated 2 new + 127 unchanged - 2 fixed = 129
total (was 129) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 43s{color}
| {color:red} hbase-server generated 17 new + 177 unchanged - 17 fixed = 194
total (was 194) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} hbase-client: The patch generated 0 new + 295
unchanged - 3 fixed = 295 total (was 298) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
16s{color} | {color:green} The patch passed checkstyle in hbase-server {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
30s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 45s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
35s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
8s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}139m
5s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} |
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[
https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800441#comment-16800441
]
Hadoop QA commented on HBASE-22074:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
8s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 4m
42s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 53s{color}
| {color:red} hbase-client generated 1 new + 128 unchanged - 1 fixed = 129
total (was 129) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 43s{color}
| {color:red} hbase-server generated 13 new + 181 unchanged - 13 fixed = 194
total (was 194) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} hbase-client: The patch generated 0 new + 295
unchanged - 3 fixed = 295 total (was 298) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
9s{color} | {color:green} The patch passed checkstyle in hbase-server {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
9s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
7m 53s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
33s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
16s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}132m
49s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} |
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800382#comment-16800382 ] Duo Zhang commented on HBASE-22074: --- PTAL. [~stack] [~zghaobac]. Thanks. > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074-v4.patch, > HBASE-22074-v5.patch, HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[
https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800120#comment-16800120
]
Hadoop QA commented on HBASE-22074:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
8s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 4m
41s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 51s{color}
| {color:red} hbase-client generated 1 new + 128 unchanged - 1 fixed = 129
total (was 129) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 40s{color}
| {color:red} hbase-server generated 10 new + 184 unchanged - 10 fixed = 194
total (was 194) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} hbase-client: The patch generated 0 new + 295
unchanged - 3 fixed = 295 total (was 298) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s{color} | {color:green} The patch passed checkstyle in hbase-server {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
13s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
7m 48s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
33s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
16s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}132m 56s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green}
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800070#comment-16800070 ] Duo Zhang commented on HBASE-22074: --- Please see the patch on RB [~allan163], this is just what I have done. Thanks. > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074-v4.patch, > HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800069#comment-16800069 ] Allan Yang commented on HBASE-22074: What about modify the meta entry in the procedure, if another master is becoming active during the procedure executing, the procedure can't finish correctly, thus it can't reply to the RS that the report is finished. > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074-v4.patch, > HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800020#comment-16800020 ] Allan Yang commented on HBASE-22074: Yes, you are right, it is not a atomic operation. It can't solve this problem. > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800018#comment-16800018 ] Duo Zhang commented on HBASE-22074: --- [~allan163] What if the master is marked as dead after you finish the dummy procedure and before you edit meta? > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800012#comment-16800012 ] Allan Yang commented on HBASE-22074: I think a more simple solution is to schedule a no-op procedure(a procedure doing nothing) and wait it to finish before editing meta in master. > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[
https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799961#comment-16799961
]
Duo Zhang commented on HBASE-22074:
---
OK, after HBASE-21895, the javac error is clear, it's just about order...
This is the result for the base branch.
{noformat}
[WARNING]
/testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
[UnusedVariable] The parameter 'updateCachedLocation' is never read.
[WARNING]
/testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
[UnusedVariable] The parameter 'error' is never read.
{noformat}
And this is the result for the patched branch
{noformat}
[WARNING]
/testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
[UnusedVariable] The parameter 'error' is never read.
[WARNING]
/testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
[UnusedVariable] The parameter 'updateCachedLocation' is never read.
{noformat}
So it will report a new one and a fixed one... Maybe we should sort before
calling diff? [~busbey]. Thanks.
> Should use procedure store to persist the state in reportRegionStateTransition
> --
>
> Key: HBASE-22074
> URL: https://issues.apache.org/jira/browse/HBASE-22074
> Project: HBase
> Issue Type: Bug
> Components: amv2, proc-v2
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch,
> HBASE-22074-v3.patch, HBASE-22074-v3.patch, HBASE-22074.patch
>
>
> For now we will update the meta region directly. This may cause lots of
> problems and after a bunch of fixes, we still can not solve the problem in
> HBASE-22060.
> So maybe the approach itself is not a good choice, let's try another way to
> see if it could work better.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[
https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799956#comment-16799956
]
Hadoop QA commented on HBASE-22074:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
10s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 4m
37s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 51s{color}
| {color:red} hbase-client generated 1 new + 128 unchanged - 1 fixed = 129
total (was 129) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 37s{color}
| {color:red} hbase-server generated 15 new + 179 unchanged - 15 fixed = 194
total (was 194) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} hbase-client: The patch generated 0 new + 295
unchanged - 3 fixed = 295 total (was 298) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s{color} | {color:green} The patch passed checkstyle in hbase-server {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
11s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
7m 55s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
34s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
18s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}133m
57s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} |
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799893#comment-16799893 ] Duo Zhang commented on HBASE-22074: --- Ah, TestHbck... Let me check. > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074-v3.patch, HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[
https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799727#comment-16799727
]
Hadoop QA commented on HBASE-22074:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
36s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 3m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} hbase-client: The patch generated 0 new + 295
unchanged - 3 fixed = 295 total (was 298) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
30s{color} | {color:green} The patch passed checkstyle in hbase-server {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
18s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
10m 3s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
42s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
32s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}150m 47s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}217m 31s{color} |
{color:black} {color} |
\\
\\
||
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799669#comment-16799669 ] Duo Zhang commented on HBASE-22074: --- [~stack] Attached a simple design doc: https://docs.google.com/document/d/1Zvi2z3lE049iu4LWBVlM2G6RFsUoUV78lrcnr2oZArM/edit# > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074-v3.patch, HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[
https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799204#comment-16799204
]
Hadoop QA commented on HBASE-22074:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
12s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 4m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} hbase-client: The patch generated 0 new + 295
unchanged - 3 fixed = 295 total (was 298) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
22s{color} | {color:green} The patch passed checkstyle in hbase-server {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
1s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 33s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
35s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
13s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}142m 38s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
57s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}211m 32s{color} |
{color:black} {color} |
\\
\\
||
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799027#comment-16799027 ] Duo Zhang commented on HBASE-22074: --- Let's try again. [~stack] The basic idea here is to make use of the existing 'fence' in our WALProcedureStore, that's why I introduced a reportTranstion method for OpenRegionProcedure/CloseRegionProcedure. In the method we will persist the state into the procedure store, and wake up the procedure, and then when executing the procedure, we will update the hbase:meta. So if we are not the active master any more, we can not write to the WALProcedureStore any more, as the new master will call recoverLease to close our writer. This could solve the problem in HBASE-22060. Thanks. > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799026#comment-16799026 ] Duo Zhang commented on HBASE-22074: --- Review board link: https://reviews.apache.org/r/70261/ > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074-v2.patch, > HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798275#comment-16798275 ] stack commented on HBASE-22074: --- I went over the patch. Any chance of a more general writeup on what the problem is and the fix proposed here? I think I get it and this seems much preferable to flagging all RSs on new master (as per [~sershe] comments over on HBASE-22060) but an overview would help. Thanks [~Apache9] > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798090#comment-16798090 ] Duo Zhang commented on HBASE-22074: --- OK, forget to deal with server crash and remoteCallFailed... Let me try. > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074-v1.patch, HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[
https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798079#comment-16798079
]
Hadoop QA commented on HBASE-22074:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
57s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 3m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} hbase-client: The patch generated 0 new + 295
unchanged - 3 fixed = 295 total (was 298) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
0s{color} | {color:green} The patch passed checkstyle in hbase-server {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
57s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
7m 50s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
31s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
16s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}144m 13s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
51s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}198m 31s{color} |
{color:black} {color} |
\\
\\
||
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[
https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798020#comment-16798020
]
Hadoop QA commented on HBASE-22074:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
14s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 3m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
22s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
10m 35s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
43s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}254m 58s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
47s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}315m 35s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.assignment.TestAMAssignWithRandExec |
| | hadoop.hbase.master.TestAssignmentManagerMetrics |
| | hadoop.hbase.master.TestMasterOperationsForRegionReplicas |
| | hadoop.hbase.master.assignment.TestAMServerFailedOpen |
| | hadoop.hbase.client.TestAsyncDecommissionAdminApi |
| | hadoop.hbase.master.assignment.TestAssignmentManager |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-22074 |
|
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797868#comment-16797868 ] Duo Zhang commented on HBASE-22074: --- Introduce a reportTransition method in RegionRemoteProcedureBase, where we will store the TransitionCode and sequence id in the procedure state, and then wake up the procedure. We will update the hbase:meta when executing the issue, using the stored TransitionCode and sequence id. The advntage here is that, if we have successfully stored the procedure state, then when master restarts, it will not send the procedure to RS again as we will load the TransitionCode and sequence id from the procedure store. And if the current master is not the active one(but does not know this itself), the persisting of the procedure state will fail as the active master will call recoverLease to close the openning writers for the old master. > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22074) Should use procedure store to persist the state in reportRegionStateTransition
[ https://issues.apache.org/jira/browse/HBASE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797862#comment-16797862 ] Duo Zhang commented on HBASE-22074: --- Not fully completed yet, let's try it first. > Should use procedure store to persist the state in reportRegionStateTransition > -- > > Key: HBASE-22074 > URL: https://issues.apache.org/jira/browse/HBASE-22074 > Project: HBase > Issue Type: Bug > Components: amv2, proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22074.patch > > > For now we will update the meta region directly. This may cause lots of > problems and after a bunch of fixes, we still can not solve the problem in > HBASE-22060. > So maybe the approach itself is not a good choice, let's try another way to > see if it could work better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
