[jira] [Commented] (HBASE-22469) replace md5 checksum in saveVersion script with sha512 for hbase version information

2019-05-28 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850493#comment-16850493
 ] 

Hudson commented on HBASE-22469:


Results for branch master
[build #1052 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1052/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1052//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1052//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1052//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for 
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1052//artifact/output-integration/hadoop-3.log].
 (note that this means we didn't check the Hadoop 3 shaded client)


> replace md5 checksum in saveVersion script with sha512 for hbase version 
> information
> 
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-22469.v01.patch, HBASE-22469.v02.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we 
> long retired md5 from the releases, it makes sense to replace hbase version 
> information as well. I also noticed that revision doesn't always show, case 
> in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only 
> appears if the compiled code was cloned from git and not a release candidate 
> download file. In that sense, release candidates should be checked out rather 
> than downloaded. This Jira only addresses replacement of the md5 sum. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22469) replace md5 checksum in saveVersion script with sha512 for hbase version information

2019-05-28 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850257#comment-16850257
 ] 

Hudson commented on HBASE-22469:


Results for branch branch-2
[build #1930 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1930/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1930//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1930//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1930//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> replace md5 checksum in saveVersion script with sha512 for hbase version 
> information
> 
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-22469.v01.patch, HBASE-22469.v02.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we 
> long retired md5 from the releases, it makes sense to replace hbase version 
> information as well. I also noticed that revision doesn't always show, case 
> in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only 
> appears if the compiled code was cloned from git and not a release candidate 
> download file. In that sense, release candidates should be checked out rather 
> than downloaded. This Jira only addresses replacement of the md5 sum. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22469) replace md5 checksum in saveVersion script with sha512 for hbase version information

2019-05-28 Thread Josh Elser (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850034#comment-16850034
 ] 

Josh Elser commented on HBASE-22469:


Actually, Artem, you changed too much. 
{code:java}
@@ -317,7 +317,7 @@ AssignmentManager assignmentManager = 
master.getAssignmentManager();
 
 Hadoop Source Checksum
 <% org.apache.hadoop.util.VersionInfo.getSrcChecksum() 
%>
-Hadoop source MD5 checksum
+Hadoop source SHA512 checksum
 
 
 ZooKeeper Client Version
{code}
You're modifying the table-cell for the Hadoop source checksum. The only change 
you made here was to the HBase source checksum. The Hadoop checksum is still an 
MD5.

Otherwise, this is fine. I'll just fix this on commit to branch-2 and master.

> replace md5 checksum in saveVersion script with sha512 for hbase version 
> information
> 
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22469.v01.patch, HBASE-22469.v02.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we 
> long retired md5 from the releases, it makes sense to replace hbase version 
> information as well. I also noticed that revision doesn't always show, case 
> in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only 
> appears if the compiled code was cloned from git and not a release candidate 
> download file. In that sense, release candidates should be checked out rather 
> than downloaded. This Jira only addresses replacement of the md5 sum. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22469) replace md5 checksum in saveVersion script with sha512 for hbase version information

2019-05-28 Thread HBase QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850014#comment-16850014
 ] 

HBase QA commented on HBASE-22469:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
51s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
48s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
37s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}245m 31s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
56s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}260m 25s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/437/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22469 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12970035/HBASE-22469.v02.patch 
|
| Optional Tests |  dupname  asflicense  shellcheck  shelldocs  javac  javadoc  
unit  |
| uname | Linux 6ad8003c9710 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 97090560a5 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| shellcheck | v0.4.4 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/437/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/437/testReport/ |
| Max. process+thread count | 5477 (vs. ulimit of 1) |
| modules | C: hbase-common hbase-server U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/437/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> replace md5 checksum in saveVersion script with sha512 for hbase version 
> information
> 
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform

[jira] [Commented] (HBASE-22469) replace md5 checksum in saveVersion script with sha512 for hbase version information

2019-05-28 Thread Josh Elser (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849795#comment-16849795
 ] 

Josh Elser commented on HBASE-22469:


LGTM, will let QA come back, but expect to commit.

> replace md5 checksum in saveVersion script with sha512 for hbase version 
> information
> 
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22469.v01.patch, HBASE-22469.v02.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we 
> long retired md5 from the releases, it makes sense to replace hbase version 
> information as well. I also noticed that revision doesn't always show, case 
> in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only 
> appears if the compiled code was cloned from git and not a release candidate 
> download file. In that sense, release candidates should be checked out rather 
> than downloaded. This Jira only addresses replacement of the md5 sum. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22469) replace md5 checksum in saveVersion script with sha512 for hbase version information

2019-05-28 Thread Artem Ervits (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849747#comment-16849747
 ] 

Artem Ervits commented on HBASE-22469:
--

v.02 patch addresses `RSStatusTmpl.jamon` and `MasterStatusTmpl.jamon` comments

> replace md5 checksum in saveVersion script with sha512 for hbase version 
> information
> 
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22469.v01.patch, HBASE-22469.v02.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we 
> long retired md5 from the releases, it makes sense to replace hbase version 
> information as well. I also noticed that revision doesn't always show, case 
> in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only 
> appears if the compiled code was cloned from git and not a release candidate 
> download file. In that sense, release candidates should be checked out rather 
> than downloaded. This Jira only addresses replacement of the md5 sum. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22469) replace md5 checksum in saveVersion script with sha512 for hbase version information

2019-05-24 Thread Josh Elser (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847904#comment-16847904
 ] 

Josh Elser commented on HBASE-22469:


[~dbist13], {{RSStatusTmpl.jamon}} and {{MasterStatusTmpl.jamon}} need to be 
updated, too, as they currently say "HBase source MD5 checksum" which is wrong 
after your change.

Can you put up a v2 with that fixed, too?

> replace md5 checksum in saveVersion script with sha512 for hbase version 
> information
> 
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22469.v01.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we 
> long retired md5 from the releases, it makes sense to replace hbase version 
> information as well. I also noticed that revision doesn't always show, case 
> in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only 
> appears if the compiled code was cloned from git and not a release candidate 
> download file. In that sense, release candidates should be checked out rather 
> than downloaded. This Jira only addresses replacement of the md5 sum. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22469) replace md5 checksum in saveVersion script with sha512 for hbase version information

2019-05-24 Thread Josh Elser (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847560#comment-16847560
 ] 

Josh Elser commented on HBASE-22469:


{quote}I also noticed that revision doesn't always show, case in point HBase 
2.2.0 RC4 vote, revision=Unknown. In my tests, revision only appears if the 
compiled code was cloned from git and not a release candidate download file
{quote}
Yeah, this is a result of the maven/git plugin(s) we have configured, IIRC. 
Like you said, if you don't build from a git checkout, we can't know what the 
revision was.

That said, it looks what saveVersion.sh does is conditionally regenerates the 
Version.java file which has a checksum over all of the source files. Switching 
that from md5 to sha512 seems fine, but I don't think it's giving us anything 
new (other than eliminate glaring eyes from thinking that there is a problem). 
It's not like a collision or someone figuring out somethign else that generates 
our checksum would invalidate our security model.

+1 on qa, I think.

> replace md5 checksum in saveVersion script with sha512 for hbase version 
> information
> 
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22469.v01.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we 
> long retired md5 from the releases, it makes sense to replace hbase version 
> information as well. I also noticed that revision doesn't always show, case 
> in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only 
> appears if the compiled code was cloned from git and not a release candidate 
> download file. In that sense, release candidates should be checked out rather 
> than downloaded. This Jira only addresses replacement of the md5 sum. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22469) replace md5 checksum in saveVersion script with sha512 for hbase version information

2019-05-24 Thread HBase QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847556#comment-16847556
 ] 

HBase QA commented on HBASE-22469:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
50s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  1m 16s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/415/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22469 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969642/HBASE-22469.v01.patch 
|
| Optional Tests |  dupname  asflicense  shellcheck  shelldocs  |
| uname | Linux 9e8d48d0ce22 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 96d2aabfad |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| shellcheck | v0.4.4 |
| Max. process+thread count | 40 (vs. ulimit of 1) |
| modules | C: hbase-common U: hbase-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/415/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> replace md5 checksum in saveVersion script with sha512 for hbase version 
> information
> 
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22469.v01.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we 
> long retired md5 from the releases, it makes sense to replace hbase version 
> information as well. I also noticed that revision doesn't always show, case 
> in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only 
> appears if the compiled code was cloned from git and not a release candidate 
> download file. In that sense, release candidates should be checked out rather 
> than downloaded. This Jira only addresses replacement of the md5 sum. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)