[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[
https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173296#comment-17173296
]
Hudson commented on HBASE-22762:
Results for branch branch-2.3
[build #202 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/202/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/202/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/202/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/201/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/201/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Print the delta between phases in the split/merge/compact/flush transaction
> journals
>
>
> Key: HBASE-22762
> URL: https://issues.apache.org/jira/browse/HBASE-22762
> Project: HBase
> Issue Type: Improvement
> Components: logging
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22762-branch-1-addendum.patch,
> HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch,
> HBASE-22762.branch-1.004.patch
>
>
> We print the start timestamp for each phase when logging the
> split/merge/compact/flush transaction journals and so when debugging an
> operator must do the math by hand. It would be trivial to also print the
> delta from the start timestamp of the previous phase and helpful to do so.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[
https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173171#comment-17173171
]
Hudson commented on HBASE-22762:
Results for branch master
[build #1806 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1806/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1806/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1806/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1806/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1806//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Print the delta between phases in the split/merge/compact/flush transaction
> journals
>
>
> Key: HBASE-22762
> URL: https://issues.apache.org/jira/browse/HBASE-22762
> Project: HBase
> Issue Type: Improvement
> Components: logging
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22762-branch-1-addendum.patch,
> HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch,
> HBASE-22762.branch-1.004.patch
>
>
> We print the start timestamp for each phase when logging the
> split/merge/compact/flush transaction journals and so when debugging an
> operator must do the math by hand. It would be trivial to also print the
> delta from the start timestamp of the previous phase and helpful to do so.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[
https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172982#comment-17172982
]
Hudson commented on HBASE-22762:
Results for branch branch-2
[build #2770 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2770/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2770/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2755/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2680/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2719/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Print the delta between phases in the split/merge/compact/flush transaction
> journals
>
>
> Key: HBASE-22762
> URL: https://issues.apache.org/jira/browse/HBASE-22762
> Project: HBase
> Issue Type: Improvement
> Components: logging
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22762-branch-1-addendum.patch,
> HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch,
> HBASE-22762.branch-1.004.patch
>
>
> We print the start timestamp for each phase when logging the
> split/merge/compact/flush transaction journals and so when debugging an
> operator must do the math by hand. It would be trivial to also print the
> delta from the start timestamp of the previous phase and helpful to do so.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162232#comment-17162232 ] Andrew Kyle Purtell commented on HBASE-22762: - bq. I just observed that we don't have the delta thing in the journal entry for master branch when I was adding journal for snapshot operation. Do we want to port this to master branch as well ? Yes let's do that. > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Minor > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22762-branch-1-addendum.patch, > HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch, > HBASE-22762.branch-1.004.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161557#comment-17161557 ] Sandeep Guggilam commented on HBASE-22762: -- [~apurtell] I just observed that we don't have the delta thing in the journal entry for master branch when I was adding journal for snapshot operation. Do we want to port this to master branch as well ? > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Minor > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22762-branch-1-addendum.patch, > HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch, > HBASE-22762.branch-1.004.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[
https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898837#comment-16898837
]
Hudson commented on HBASE-22762:
Results for branch branch-1
[build #988 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/988/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/988//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/988//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/988//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Print the delta between phases in the split/merge/compact/flush transaction
> journals
>
>
> Key: HBASE-22762
> URL: https://issues.apache.org/jira/browse/HBASE-22762
> Project: HBase
> Issue Type: Improvement
> Components: logging
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22762-branch-1-addendum.patch,
> HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch,
> HBASE-22762.branch-1.004.patch
>
>
> We print the start timestamp for each phase when logging the
> split/merge/compact/flush transaction journals and so when debugging an
> operator must do the math by hand. It would be trivial to also print the
> delta from the start timestamp of the previous phase and helpful to do so.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[
https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898831#comment-16898831
]
Hudson commented on HBASE-22762:
Results for branch branch-1.4
[build #938 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/938/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/938//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/938//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/938//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Print the delta between phases in the split/merge/compact/flush transaction
> journals
>
>
> Key: HBASE-22762
> URL: https://issues.apache.org/jira/browse/HBASE-22762
> Project: HBase
> Issue Type: Improvement
> Components: logging
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22762-branch-1-addendum.patch,
> HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch,
> HBASE-22762.branch-1.004.patch
>
>
> We print the start timestamp for each phase when logging the
> split/merge/compact/flush transaction journals and so when debugging an
> operator must do the math by hand. It would be trivial to also print the
> delta from the start timestamp of the previous phase and helpful to do so.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[
https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898803#comment-16898803
]
Hudson commented on HBASE-22762:
Results for branch branch-1.3
[build #900 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/900/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/900//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/900//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/900//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Print the delta between phases in the split/merge/compact/flush transaction
> journals
>
>
> Key: HBASE-22762
> URL: https://issues.apache.org/jira/browse/HBASE-22762
> Project: HBase
> Issue Type: Improvement
> Components: logging
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22762-branch-1-addendum.patch,
> HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch,
> HBASE-22762.branch-1.004.patch
>
>
> We print the start timestamp for each phase when logging the
> split/merge/compact/flush transaction journals and so when debugging an
> operator must do the math by hand. It would be trivial to also print the
> delta from the start timestamp of the previous phase and helpful to do so.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898670#comment-16898670 ] Hudson commented on HBASE-22762: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #610 (See [https://builds.apache.org/job/HBase-1.3-IT/610/]) Amend HBASE-22762 Print the delta between phases in the (apurtell: rev 45230dca1f2972f5293d0c8fda1b47b0c30d7113) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredTaskImpl.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionMergeRequest.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionMergeTransactionImpl.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransactionImpl.java > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22762-branch-1-addendum.patch, > HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch, > HBASE-22762.branch-1.004.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898487#comment-16898487 ] Andrew Purtell commented on HBASE-22762: Still working on the addendum. Monitored task journal dump can get partially clobbered, looks like multithreading issue on the logger not an issue with the patch. Looking at what can be done without any significant change. > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22762-branch-1-addendum.patch, > HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch, > HBASE-22762.branch-1.004.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898465#comment-16898465 ] Xu Cang commented on HBASE-22762: - +1 > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22762-branch-1-addendum.patch, > HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch, > HBASE-22762.branch-1.004.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898462#comment-16898462 ] Andrew Purtell commented on HBASE-22762: Attached addendum patch > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22762-branch-1-addendum.patch, > HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch, > HBASE-22762.branch-1.004.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[
https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896830#comment-16896830
]
Hudson commented on HBASE-22762:
Results for branch branch-1.4
[build #933 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/933/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/933//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/933//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/933//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Print the delta between phases in the split/merge/compact/flush transaction
> journals
>
>
> Key: HBASE-22762
> URL: https://issues.apache.org/jira/browse/HBASE-22762
> Project: HBase
> Issue Type: Improvement
> Components: logging
>Reporter: Andrew Purtell
>Assignee: Xu Cang
>Priority: Minor
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22762.branch-1.001.patch,
> HBASE-22762.branch-1.002.patch, HBASE-22762.branch-1.004.patch
>
>
> We print the start timestamp for each phase when logging the
> split/merge/compact/flush transaction journals and so when debugging an
> operator must do the math by hand. It would be trivial to also print the
> delta from the start timestamp of the previous phase and helpful to do so.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[
https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896811#comment-16896811
]
Hudson commented on HBASE-22762:
Results for branch branch-1
[build #983 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/983/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/983//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/983//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/983//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Print the delta between phases in the split/merge/compact/flush transaction
> journals
>
>
> Key: HBASE-22762
> URL: https://issues.apache.org/jira/browse/HBASE-22762
> Project: HBase
> Issue Type: Improvement
> Components: logging
>Reporter: Andrew Purtell
>Assignee: Xu Cang
>Priority: Minor
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22762.branch-1.001.patch,
> HBASE-22762.branch-1.002.patch, HBASE-22762.branch-1.004.patch
>
>
> We print the start timestamp for each phase when logging the
> split/merge/compact/flush transaction journals and so when debugging an
> operator must do the math by hand. It would be trivial to also print the
> delta from the start timestamp of the previous phase and helpful to do so.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[
https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896808#comment-16896808
]
Hudson commented on HBASE-22762:
Results for branch branch-1.3
[build #896 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/896/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/896//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/896//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/896//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Print the delta between phases in the split/merge/compact/flush transaction
> journals
>
>
> Key: HBASE-22762
> URL: https://issues.apache.org/jira/browse/HBASE-22762
> Project: HBase
> Issue Type: Improvement
> Components: logging
>Reporter: Andrew Purtell
>Assignee: Xu Cang
>Priority: Minor
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22762.branch-1.001.patch,
> HBASE-22762.branch-1.002.patch, HBASE-22762.branch-1.004.patch
>
>
> We print the start timestamp for each phase when logging the
> split/merge/compact/flush transaction journals and so when debugging an
> operator must do the math by hand. It would be trivial to also print the
> delta from the start timestamp of the previous phase and helpful to do so.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896714#comment-16896714 ] Hudson commented on HBASE-22762: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #608 (See [https://builds.apache.org/job/HBase-1.3-IT/608/]) HBASE-22762 Print the delta between phases in the (apurtell: rev 7fe609ff0288366542742190f33bedfafe177c60) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransactionImpl.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Xu Cang >Priority: Minor > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22762.branch-1.001.patch, > HBASE-22762.branch-1.002.patch, HBASE-22762.branch-1.004.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896646#comment-16896646 ] Andrew Purtell commented on HBASE-22762: Looks great, thanks so much. Will commit > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Xu Cang >Priority: Minor > Attachments: HBASE-22762.branch-1.001.patch, > HBASE-22762.branch-1.002.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896643#comment-16896643 ] Xu Cang commented on HBASE-22762: - This is new version: 5353 2019-07-30 17:07:33,779 INFO [RS:0;xcang-ltm:65524-splits-1564531627716] regionserver.SplitRequest(143): Split transaction journal: 5354 STARTED at 1564531651882PREPARED at 1564531651884 ( +2 ms) 5355 BEFORE_PRE_SPLIT_HOOK at 1564531651884 5356 AFTER_PRE_SPLIT_HOOK at 1564531651884 5357 SET_SPLITTING at 1564531651885 ( +1 ms) 5358 CREATE_SPLIT_DIR at 1564531651993 ( +108 ms) 5359 CLOSED_PARENT_REGION at 1564531651999 ( +6 ms) 5360 OFFLINED_PARENT at 1564531651999 5361 STARTED_REGION_A_CREATION at 1564531652820 ( +821 ms) 5362 STARTED_REGION_B_CREATION at 1564531653234 ( +414 ms) 5363 PONR at 1564531653643 ( +409 ms) 5364 OPENED_REGION_A at 1564531653665 ( +22 ms) 5365 OPENED_REGION_B at 1564531653665 5366 BEFORE_POST_SPLIT_HOOK at 1564531653777 ( +112 ms) 5367 AFTER_POST_SPLIT_HOOK at 1564531653777 5368 COMPLETED at 1564531653777 I misunderstood the timestamp, thought it was start of the phase, but it is end of the phase. > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Xu Cang >Priority: Minor > Attachments: HBASE-22762.branch-1.001.patch, > HBASE-22762.branch-1.002.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896631#comment-16896631 ] Andrew Purtell commented on HBASE-22762: The deltas are wrong. 1564524100618 - 1564524100504 is not 0. > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Xu Cang >Priority: Minor > Attachments: HBASE-22762.branch-1.001.patch, > HBASE-22762.branch-1.002.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896630#comment-16896630 ] Xu Cang commented on HBASE-22762: - One small question, for this order issue you mentioned: 1103 OPENED_REGION_A at 1564524100504 (0ms) 1104 OPENED_REGION_B at 1564524100504 (114ms) 1105 BEFORE_POST_SPLIT_HOOK at 1564524100618 (0ms) I think it's accurate. What it means is, it spent 0ms on OPENED_REGION_A and it spent 114ms on OPENED_REGION_B. [~apurtell] thanks. > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Xu Cang >Priority: Minor > Attachments: HBASE-22762.branch-1.001.patch, > HBASE-22762.branch-1.002.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896614#comment-16896614 ] Xu Cang commented on HBASE-22762: - thanks! [~apurtell] will fix. > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Xu Cang >Priority: Minor > Attachments: HBASE-22762.branch-1.001.patch, > HBASE-22762.branch-1.002.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[
https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896607#comment-16896607
]
Andrew Purtell commented on HBASE-22762:
Looks like you fail to print the first entry in the journal.
Ordering is weird. Have:
{noformat}
1102 PONR at 1564524100423 (81ms)
1103 OPENED_REGION_A at 1564524100504 (0ms)
1104 OPENED_REGION_B at 1564524100504 (114ms)
{noformat}
Should be:
{noformat}
1102 PONR at 1564524100423 (81ms)
1103 OPENED_REGION_A at 1564524100504 (114ms)
1104 OPENED_REGION_B at 1564524100504 (0ms)
{noformat}
Consider putting a space between the number and the time unit, like:
{noformat}
1100 STARTED_REGION_A_CREATION at 1564524100389 (20 ms)
{noformat}
The time in parenthesis is a delta so use a '+' to indicate it is a delta, like:
{noformat}
1100 STARTED_REGION_A_CREATION at 1564524100389 (+20 ms)
{noformat}
When there is no difference, don't print anything, like:
{noformat}
1102 PONR at 1564524100423 (+14 ms)
1103 OPENED_REGION_A at 1564524100504 (+81 ms)
1104 OPENED_REGION_B at 1564524100504
1105 BEFORE_POST_SPLIT_HOOK at 1564524100618 (+114 ms)
{noformat}
Example above corrected with correct deltas
> Print the delta between phases in the split/merge/compact/flush transaction
> journals
>
>
> Key: HBASE-22762
> URL: https://issues.apache.org/jira/browse/HBASE-22762
> Project: HBase
> Issue Type: Improvement
> Components: logging
>Reporter: Andrew Purtell
>Assignee: Xu Cang
>Priority: Minor
> Attachments: HBASE-22762.branch-1.001.patch,
> HBASE-22762.branch-1.002.patch
>
>
> We print the start timestamp for each phase when logging the
> split/merge/compact/flush transaction journals and so when debugging an
> operator must do the math by hand. It would be trivial to also print the
> delta from the start timestamp of the previous phase and helpful to do so.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896563#comment-16896563 ] Xu Cang commented on HBASE-22762: - Patch is ready, output looks like below: 1091 2019-07-30 15:01:40,620 INFO [RS:0;xcang-ltm:62046-splits-1564524100198] regionserver.SplitRequest(143): Split transaction journal: 1092 STARTED at 1564524100204 (5ms) 1093 PREPARED at 1564524100209 (2ms) 1094 BEFORE_PRE_SPLIT_HOOK at 1564524100211 (0ms) 1095 AFTER_PRE_SPLIT_HOOK at 1564524100211 (2ms) 1096 SET_SPLITTING at 1564524100213 (106ms) 1097 CREATE_SPLIT_DIR at 1564524100319 (30ms) 1098 CLOSED_PARENT_REGION at 1564524100349 (0ms) 1099 OFFLINED_PARENT at 1564524100349 (40ms) 1100 STARTED_REGION_A_CREATION at 1564524100389 (20ms) 1101 STARTED_REGION_B_CREATION at 1564524100409 (14ms) 1102 PONR at 1564524100423 (81ms) 1103 OPENED_REGION_A at 1564524100504 (0ms) 1104 OPENED_REGION_B at 1564524100504 (114ms) 1105 BEFORE_POST_SPLIT_HOOK at 1564524100618 (0ms) 1106 AFTER_POST_SPLIT_HOOK at 1564524100618 (0ms) 1107 COMPLETED at 1564524100618 > Print the delta between phases in the split/merge/compact/flush transaction > journals > > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Andrew Purtell >Assignee: Xu Cang >Priority: Minor > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
