[jira] [Commented] (HBASE-25115) HFilePrettyPrinter can't seek to the row which is the first row of a hfile

2020-10-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208602#comment-17208602
 ] 

Hudson commented on HBASE-25115:


Results for branch branch-2
[build #69 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/69/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/69/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/69/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]






(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> HFilePrettyPrinter can't seek to the row which is the first row of a hfile
> --
>
> Key: HBASE-25115
> URL: https://issues.apache.org/jira/browse/HBASE-25115
> Project: HBase
>  Issue Type: Bug
>  Components: HFile, tooling
>Affects Versions: 2.2.6
>Reporter: Chaoqiang Zhong
>Assignee: niuyulin
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.3, 2.4.0, 2.2.7
>
> Attachments: HBASE-25115.patch
>
>
> This issue can be reproduced by below steps:
>  * make a hfile contains two rows '000' and '001';
> {code:java}
> D:\bin>hbase hfile -p -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 000/f1:a/1601282789548/Put/vlen=4/seqid=4 V: 
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5 V: 
> Scanned kv count -> 2{code}
>  * '001' can be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 001 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5
> Scanned kv count -> 1{code}
>  * but '000' can't be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 000 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> Scanned kv count -> 0{code}
>  In HFilePrettyPrinter we use 
> "scanner.seekTo(PrivateCellUtil.createFirstOnRow(this.row))" to seek to 
> row.But this method will retrurn -1 when the row is the first row of hfile.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25115) HFilePrettyPrinter can't seek to the row which is the first row of a hfile

2020-10-04 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207730#comment-17207730
 ] 

Hudson commented on HBASE-25115:


Results for branch branch-2.3
[build #74 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/74/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/74/General_20Nightly_20Build_20Report/]






(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/74/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console 
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/74//console].


> HFilePrettyPrinter can't seek to the row which is the first row of a hfile
> --
>
> Key: HBASE-25115
> URL: https://issues.apache.org/jira/browse/HBASE-25115
> Project: HBase
>  Issue Type: Bug
>  Components: HFile, tooling
>Affects Versions: 2.2.6
>Reporter: Chaoqiang Zhong
>Assignee: niuyulin
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.3, 2.4.0, 2.2.7
>
> Attachments: HBASE-25115.patch
>
>
> This issue can be reproduced by below steps:
>  * make a hfile contains two rows '000' and '001';
> {code:java}
> D:\bin>hbase hfile -p -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 000/f1:a/1601282789548/Put/vlen=4/seqid=4 V: 
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5 V: 
> Scanned kv count -> 2{code}
>  * '001' can be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 001 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5
> Scanned kv count -> 1{code}
>  * but '000' can't be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 000 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> Scanned kv count -> 0{code}
>  In HFilePrettyPrinter we use 
> "scanner.seekTo(PrivateCellUtil.createFirstOnRow(this.row))" to seek to 
> row.But this method will retrurn -1 when the row is the first row of hfile.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25115) HFilePrettyPrinter can't seek to the row which is the first row of a hfile

2020-10-04 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207332#comment-17207332
 ] 

Hudson commented on HBASE-25115:


Results for branch master
[build #81 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/81/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/81/General_20Nightly_20Build_20Report/]






(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/81/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/81/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> HFilePrettyPrinter can't seek to the row which is the first row of a hfile
> --
>
> Key: HBASE-25115
> URL: https://issues.apache.org/jira/browse/HBASE-25115
> Project: HBase
>  Issue Type: Bug
>  Components: HFile, tooling
>Affects Versions: 2.2.6
>Reporter: Chaoqiang Zhong
>Assignee: niuyulin
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.3, 2.4.0, 2.2.7
>
> Attachments: HBASE-25115.patch
>
>
> This issue can be reproduced by below steps:
>  * make a hfile contains two rows '000' and '001';
> {code:java}
> D:\bin>hbase hfile -p -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 000/f1:a/1601282789548/Put/vlen=4/seqid=4 V: 
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5 V: 
> Scanned kv count -> 2{code}
>  * '001' can be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 001 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5
> Scanned kv count -> 1{code}
>  * but '000' can't be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 000 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> Scanned kv count -> 0{code}
>  In HFilePrettyPrinter we use 
> "scanner.seekTo(PrivateCellUtil.createFirstOnRow(this.row))" to seek to 
> row.But this method will retrurn -1 when the row is the first row of hfile.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25115) HFilePrettyPrinter can't seek to the row which is the first row of a hfile

2020-10-04 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207331#comment-17207331
 ] 

Hudson commented on HBASE-25115:


Results for branch branch-2.2
[build #81 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/81/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/81//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/81//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/81//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for 
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/81//artifact/output-integration/hadoop-2.log].
 (note that this means we didn't run on Hadoop 3)


> HFilePrettyPrinter can't seek to the row which is the first row of a hfile
> --
>
> Key: HBASE-25115
> URL: https://issues.apache.org/jira/browse/HBASE-25115
> Project: HBase
>  Issue Type: Bug
>  Components: HFile, tooling
>Affects Versions: 2.2.6
>Reporter: Chaoqiang Zhong
>Assignee: niuyulin
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.3, 2.4.0, 2.2.7
>
> Attachments: HBASE-25115.patch
>
>
> This issue can be reproduced by below steps:
>  * make a hfile contains two rows '000' and '001';
> {code:java}
> D:\bin>hbase hfile -p -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 000/f1:a/1601282789548/Put/vlen=4/seqid=4 V: 
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5 V: 
> Scanned kv count -> 2{code}
>  * '001' can be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 001 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5
> Scanned kv count -> 1{code}
>  * but '000' can't be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 000 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> Scanned kv count -> 0{code}
>  In HFilePrettyPrinter we use 
> "scanner.seekTo(PrivateCellUtil.createFirstOnRow(this.row))" to seek to 
> row.But this method will retrurn -1 when the row is the first row of hfile.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25115) HFilePrettyPrinter can't seek to the row which is the first row of a hfile

2020-10-04 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207325#comment-17207325
 ] 

Hudson commented on HBASE-25115:


Results for branch branch-2.3
[build #72 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/72/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/72/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/72/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/72/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/72/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console 
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/72//console].


> HFilePrettyPrinter can't seek to the row which is the first row of a hfile
> --
>
> Key: HBASE-25115
> URL: https://issues.apache.org/jira/browse/HBASE-25115
> Project: HBase
>  Issue Type: Bug
>  Components: HFile, tooling
>Affects Versions: 2.2.6
>Reporter: Chaoqiang Zhong
>Assignee: niuyulin
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.3, 2.4.0, 2.2.7
>
> Attachments: HBASE-25115.patch
>
>
> This issue can be reproduced by below steps:
>  * make a hfile contains two rows '000' and '001';
> {code:java}
> D:\bin>hbase hfile -p -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 000/f1:a/1601282789548/Put/vlen=4/seqid=4 V: 
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5 V: 
> Scanned kv count -> 2{code}
>  * '001' can be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 001 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5
> Scanned kv count -> 1{code}
>  * but '000' can't be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 000 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> Scanned kv count -> 0{code}
>  In HFilePrettyPrinter we use 
> "scanner.seekTo(PrivateCellUtil.createFirstOnRow(this.row))" to seek to 
> row.But this method will retrurn -1 when the row is the first row of hfile.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25115) HFilePrettyPrinter can't seek to the row which is the first row of a hfile

2020-10-04 Thread Viraj Jasani (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207308#comment-17207308
 ] 

Viraj Jasani commented on HBASE-25115:
--

[~zcq_rambo] I have just added you to the contributers list, so going forward 
you can assign Jira to yourself if it is unassigned and you would like to work 
on it.

> HFilePrettyPrinter can't seek to the row which is the first row of a hfile
> --
>
> Key: HBASE-25115
> URL: https://issues.apache.org/jira/browse/HBASE-25115
> Project: HBase
>  Issue Type: Bug
>  Components: HFile, tooling
>Affects Versions: 2.2.6
>Reporter: Chaoqiang Zhong
>Assignee: niuyulin
>Priority: Major
> Attachments: HBASE-25115.patch
>
>
> This issue can be reproduced by below steps:
>  * make a hfile contains two rows '000' and '001';
> {code:java}
> D:\bin>hbase hfile -p -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 000/f1:a/1601282789548/Put/vlen=4/seqid=4 V: 
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5 V: 
> Scanned kv count -> 2{code}
>  * '001' can be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 001 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5
> Scanned kv count -> 1{code}
>  * but '000' can't be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 000 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> Scanned kv count -> 0{code}
>  In HFilePrettyPrinter we use 
> "scanner.seekTo(PrivateCellUtil.createFirstOnRow(this.row))" to seek to 
> row.But this method will retrurn -1 when the row is the first row of hfile.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25115) HFilePrettyPrinter can't seek to the row which is the first row of a hfile

2020-10-04 Thread Viraj Jasani (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207307#comment-17207307
 ] 

Viraj Jasani commented on HBASE-25115:
--

[~niuyulin] [~zcq_rambo] I just realized that we have 2 PRs: one for master and 
another for branch-2.2, both from different authors.

Usually, only Jira assignee creates PR and we create PR for just master branch 
as long as the patch is not huge and patch is not significantly different 
across multiple release branches. For now it's fine, will merge both PRs after 
some time. Also, master PR has test, so let me include that for branch-2.2 
commit also.

Thanks to both of you for finding and fixing this nice bug.

> HFilePrettyPrinter can't seek to the row which is the first row of a hfile
> --
>
> Key: HBASE-25115
> URL: https://issues.apache.org/jira/browse/HBASE-25115
> Project: HBase
>  Issue Type: Bug
>  Components: HFile, tooling
>Affects Versions: 2.2.6
>Reporter: Chaoqiang Zhong
>Assignee: niuyulin
>Priority: Major
> Attachments: HBASE-25115.patch
>
>
> This issue can be reproduced by below steps:
>  * make a hfile contains two rows '000' and '001';
> {code:java}
> D:\bin>hbase hfile -p -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 000/f1:a/1601282789548/Put/vlen=4/seqid=4 V: 
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5 V: 
> Scanned kv count -> 2{code}
>  * '001' can be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 001 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5
> Scanned kv count -> 1{code}
>  * but '000' can't be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 000 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> Scanned kv count -> 0{code}
>  In HFilePrettyPrinter we use 
> "scanner.seekTo(PrivateCellUtil.createFirstOnRow(this.row))" to seek to 
> row.But this method will retrurn -1 when the row is the first row of hfile.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25115) HFilePrettyPrinter can't seek to the row which is the first row of a hfile

2020-09-30 Thread niuyulin (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204669#comment-17204669
 ] 

niuyulin commented on HBASE-25115:
--

[~zcq_rambo] Yes, your code is simplified, I will modify my PR on master branch

> HFilePrettyPrinter can't seek to the row which is the first row of a hfile
> --
>
> Key: HBASE-25115
> URL: https://issues.apache.org/jira/browse/HBASE-25115
> Project: HBase
>  Issue Type: Bug
>  Components: HFile, tooling
>Affects Versions: 2.2.6
>Reporter: Chaoqiang Zhong
>Assignee: niuyulin
>Priority: Major
> Attachments: HBASE-25115.patch
>
>
> This issue can be reproduced by below steps:
>  * make a hfile contains two rows '000' and '001';
> {code:java}
> D:\bin>hbase hfile -p -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 000/f1:a/1601282789548/Put/vlen=4/seqid=4 V: 
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5 V: 
> Scanned kv count -> 2{code}
>  * '001' can be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 001 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5
> Scanned kv count -> 1{code}
>  * but '000' can't be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 000 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> Scanned kv count -> 0{code}
>  In HFilePrettyPrinter we use 
> "scanner.seekTo(PrivateCellUtil.createFirstOnRow(this.row))" to seek to 
> row.But this method will retrurn -1 when the row is the first row of hfile.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25115) HFilePrettyPrinter can't seek to the row which is the first row of a hfile

2020-09-30 Thread Chaoqiang Zhong (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204592#comment-17204592
 ] 

Chaoqiang Zhong commented on HBASE-25115:
-

a simple fix for this issue.

> HFilePrettyPrinter can't seek to the row which is the first row of a hfile
> --
>
> Key: HBASE-25115
> URL: https://issues.apache.org/jira/browse/HBASE-25115
> Project: HBase
>  Issue Type: Bug
>  Components: HFile, tooling
>Affects Versions: 2.2.6
>Reporter: Chaoqiang Zhong
>Assignee: niuyulin
>Priority: Major
> Attachments: HBASE-25115.patch
>
>
> This issue can be reproduced by below steps:
>  * make a hfile contains two rows '000' and '001';
> {code:java}
> D:\bin>hbase hfile -p -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 000/f1:a/1601282789548/Put/vlen=4/seqid=4 V: 
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5 V: 
> Scanned kv count -> 2{code}
>  * '001' can be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 001 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5
> Scanned kv count -> 1{code}
>  * but '000' can't be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 000 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> Scanned kv count -> 0{code}
>  In HFilePrettyPrinter we use 
> "scanner.seekTo(PrivateCellUtil.createFirstOnRow(this.row))" to seek to 
> row.But this method will retrurn -1 when the row is the first row of hfile.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25115) HFilePrettyPrinter can't seek to the row which is the first row of a hfile

2020-09-29 Thread Chaoqiang Zhong (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203799#comment-17203799
 ] 

Chaoqiang Zhong commented on HBASE-25115:
-

This maybe cased by HFileBlockIndex#rootBlockContainingKey().

When we use HFileBlockIndex#rootBlockContainingKey() with a cell created by 
PrivateCellUtil.createFirstOnRow(), it will return -1.

> HFilePrettyPrinter can't seek to the row which is the first row of a hfile
> --
>
> Key: HBASE-25115
> URL: https://issues.apache.org/jira/browse/HBASE-25115
> Project: HBase
>  Issue Type: Bug
>  Components: HFile, tooling
>Affects Versions: 2.2.6
>Reporter: Chaoqiang Zhong
>Assignee: niuyulin
>Priority: Major
>
> This issue can be reproduced by below steps:
>  * make a hfile contains two rows '000' and '001';
> {code:java}
> D:\bin>hbase hfile -p -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 000/f1:a/1601282789548/Put/vlen=4/seqid=4 V: 
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5 V: 
> Scanned kv count -> 2{code}
>  * '001' can be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 001 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5
> Scanned kv count -> 1{code}
>  * but '000' can't be seeked to;
> {code:java}
> D:\bin>hbase hfile -e -w 000 -f 
> /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd
> Scanned kv count -> 0{code}
>  In HFilePrettyPrinter we use 
> "scanner.seekTo(PrivateCellUtil.createFirstOnRow(this.row))" to seek to 
> row.But this method will retrurn -1 when the row is the first row of hfile.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)