[jira] [Commented] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382406#comment-17382406 ] Hudson commented on HBASE-26083: Results for branch branch-2.4 [build #161 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/161/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/161/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/161/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/161/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/161/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > L1 miss metric is incorrect when using CombinedBlockCache > - > > Key: HBASE-26083 > URL: https://issues.apache.org/jira/browse/HBASE-26083 > Project: HBase > Issue Type: Bug > Components: BlockCache >Reporter: Yutong Xiao >Assignee: Yutong Xiao >Priority: Minor > Fix For: 2.3.6, 3.0.0-alpha-2, 2.4.5, 1.7.2 > > > In CombinedBlockCache getBlock method > {code:java} > public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, > boolean repeat, boolean updateCacheMetrics) { > // TODO: is there a hole here, or just awkwardness since in the lruCache > getBlock > // we end up calling l2Cache.getBlock. > // We are not in a position to exactly look at LRU cache or BC as > BlockType may not be getting > // passed always. > return l1Cache.containsBlock(cacheKey)? > l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics): > l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); > } > {code} > If L1 does not contains cacheKey, it will never check it in L1, so that L1 > miss metrics is always 0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382283#comment-17382283 ] Hudson commented on HBASE-26083: Results for branch branch-2 [build #301 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/301/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/301/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/301/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/301/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/301/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (x) {color:red}-1 client integration test{color} -- Something went wrong with this stage, [check relevant console output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/301//console]. > L1 miss metric is incorrect when using CombinedBlockCache > - > > Key: HBASE-26083 > URL: https://issues.apache.org/jira/browse/HBASE-26083 > Project: HBase > Issue Type: Bug > Components: BlockCache >Reporter: Yutong Xiao >Assignee: Yutong Xiao >Priority: Minor > Fix For: 2.3.6, 3.0.0-alpha-2, 2.4.5, 1.7.2 > > > In CombinedBlockCache getBlock method > {code:java} > public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, > boolean repeat, boolean updateCacheMetrics) { > // TODO: is there a hole here, or just awkwardness since in the lruCache > getBlock > // we end up calling l2Cache.getBlock. > // We are not in a position to exactly look at LRU cache or BC as > BlockType may not be getting > // passed always. > return l1Cache.containsBlock(cacheKey)? > l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics): > l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); > } > {code} > If L1 does not contains cacheKey, it will never check it in L1, so that L1 > miss metrics is always 0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382257#comment-17382257 ] Hudson commented on HBASE-26083: Results for branch branch-2.3 [build #255 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/255/]: (/) *{color:green}+1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/255/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/255/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/255/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/255/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > L1 miss metric is incorrect when using CombinedBlockCache > - > > Key: HBASE-26083 > URL: https://issues.apache.org/jira/browse/HBASE-26083 > Project: HBase > Issue Type: Bug > Components: BlockCache >Reporter: Yutong Xiao >Assignee: Yutong Xiao >Priority: Minor > Fix For: 2.3.6, 3.0.0-alpha-2, 2.4.5, 1.7.2 > > > In CombinedBlockCache getBlock method > {code:java} > public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, > boolean repeat, boolean updateCacheMetrics) { > // TODO: is there a hole here, or just awkwardness since in the lruCache > getBlock > // we end up calling l2Cache.getBlock. > // We are not in a position to exactly look at LRU cache or BC as > BlockType may not be getting > // passed always. > return l1Cache.containsBlock(cacheKey)? > l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics): > l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); > } > {code} > If L1 does not contains cacheKey, it will never check it in L1, so that L1 > miss metrics is always 0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382176#comment-17382176 ] Hudson commented on HBASE-26083: Results for branch branch-1 [build #151 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/151/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/151//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/151//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/151//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > L1 miss metric is incorrect when using CombinedBlockCache > - > > Key: HBASE-26083 > URL: https://issues.apache.org/jira/browse/HBASE-26083 > Project: HBase > Issue Type: Bug > Components: BlockCache >Reporter: Yutong Xiao >Assignee: Yutong Xiao >Priority: Minor > Fix For: 2.3.6, 3.0.0-alpha-2, 2.4.5, 1.7.2 > > > In CombinedBlockCache getBlock method > {code:java} > public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, > boolean repeat, boolean updateCacheMetrics) { > // TODO: is there a hole here, or just awkwardness since in the lruCache > getBlock > // we end up calling l2Cache.getBlock. > // We are not in a position to exactly look at LRU cache or BC as > BlockType may not be getting > // passed always. > return l1Cache.containsBlock(cacheKey)? > l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics): > l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); > } > {code} > If L1 does not contains cacheKey, it will never check it in L1, so that L1 > miss metrics is always 0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382087#comment-17382087 ] Hudson commented on HBASE-26083: Results for branch master [build #344 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/344/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/344/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/344/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/344/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > L1 miss metric is incorrect when using CombinedBlockCache > - > > Key: HBASE-26083 > URL: https://issues.apache.org/jira/browse/HBASE-26083 > Project: HBase > Issue Type: Bug > Components: BlockCache >Reporter: Yutong Xiao >Assignee: Yutong Xiao >Priority: Minor > Fix For: 2.3.6, 3.0.0-alpha-2, 2.4.5, 1.7.2 > > > In CombinedBlockCache getBlock method > {code:java} > public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, > boolean repeat, boolean updateCacheMetrics) { > // TODO: is there a hole here, or just awkwardness since in the lruCache > getBlock > // we end up calling l2Cache.getBlock. > // We are not in a position to exactly look at LRU cache or BC as > BlockType may not be getting > // passed always. > return l1Cache.containsBlock(cacheKey)? > l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics): > l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); > } > {code} > If L1 does not contains cacheKey, it will never check it in L1, so that L1 > miss metrics is always 0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381766#comment-17381766 ] Bharath Vissapragada commented on HBASE-26083: -- I just tagged RC0 moments back and triggered the release build which is running as I type this, lets include it in the next release? > L1 miss metric is incorrect when using CombinedBlockCache > - > > Key: HBASE-26083 > URL: https://issues.apache.org/jira/browse/HBASE-26083 > Project: HBase > Issue Type: Bug > Components: BlockCache >Reporter: Yutong Xiao >Assignee: Yutong Xiao >Priority: Minor > Fix For: 2.3.6, 3.0.0-alpha-2, 2.4.5 > > > In CombinedBlockCache getBlock method > {code:java} > public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, > boolean repeat, boolean updateCacheMetrics) { > // TODO: is there a hole here, or just awkwardness since in the lruCache > getBlock > // we end up calling l2Cache.getBlock. > // We are not in a position to exactly look at LRU cache or BC as > BlockType may not be getting > // passed always. > return l1Cache.containsBlock(cacheKey)? > l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics): > l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); > } > {code} > If L1 does not contains cacheKey, it will never check it in L1, so that L1 > miss metrics is always 0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381765#comment-17381765 ] Reid Chan commented on HBASE-26083: --- Will this be included in 1.7.1 or 1.7.2? I haven't updated the fixed versions for branch-1, your call. [~bharathv] > L1 miss metric is incorrect when using CombinedBlockCache > - > > Key: HBASE-26083 > URL: https://issues.apache.org/jira/browse/HBASE-26083 > Project: HBase > Issue Type: Bug > Components: BlockCache >Reporter: Yutong Xiao >Assignee: Yutong Xiao >Priority: Minor > Fix For: 2.3.6, 1.7.1, 3.0.0-alpha-2, 2.4.5 > > > In CombinedBlockCache getBlock method > {code:java} > public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, > boolean repeat, boolean updateCacheMetrics) { > // TODO: is there a hole here, or just awkwardness since in the lruCache > getBlock > // we end up calling l2Cache.getBlock. > // We are not in a position to exactly look at LRU cache or BC as > BlockType may not be getting > // passed always. > return l1Cache.containsBlock(cacheKey)? > l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics): > l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); > } > {code} > If L1 does not contains cacheKey, it will never check it in L1, so that L1 > miss metrics is always 0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381094#comment-17381094 ] Anoop Sam John commented on HBASE-26083: Just one comment added. pls eval. Then we are good for branch-2 + > L1 miss metric is incorrect when using CombinedBlockCache > - > > Key: HBASE-26083 > URL: https://issues.apache.org/jira/browse/HBASE-26083 > Project: HBase > Issue Type: Bug > Components: BlockCache >Reporter: Yutong Xiao >Assignee: Yutong Xiao >Priority: Major > > In CombinedBlockCache getBlock method > {code:java} > public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, > boolean repeat, boolean updateCacheMetrics) { > // TODO: is there a hole here, or just awkwardness since in the lruCache > getBlock > // we end up calling l2Cache.getBlock. > // We are not in a position to exactly look at LRU cache or BC as > BlockType may not be getting > // passed always. > return l1Cache.containsBlock(cacheKey)? > l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics): > l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); > } > {code} > If L1 does not contains cacheKey, it will never check it in L1, so that L1 > miss metrics is always 0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381085#comment-17381085 ] Yutong Xiao commented on HBASE-26083: - [~anoop.hbase] I have updated the github MR #3474 any comment? If not, I would update the branch-2 & master next. > L1 miss metric is incorrect when using CombinedBlockCache > - > > Key: HBASE-26083 > URL: https://issues.apache.org/jira/browse/HBASE-26083 > Project: HBase > Issue Type: Bug > Components: BlockCache >Reporter: Yutong Xiao >Assignee: Yutong Xiao >Priority: Major > > In CombinedBlockCache getBlock method > {code:java} > public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, > boolean repeat, boolean updateCacheMetrics) { > // TODO: is there a hole here, or just awkwardness since in the lruCache > getBlock > // we end up calling l2Cache.getBlock. > // We are not in a position to exactly look at LRU cache or BC as > BlockType may not be getting > // passed always. > return l1Cache.containsBlock(cacheKey)? > l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics): > l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); > } > {code} > If L1 does not contains cacheKey, it will never check it in L1, so that L1 > miss metrics is always 0. -- This message was sent by Atlassian Jira (v8.3.4#803005)