[jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously

2012-02-09 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205129#comment-13205129
 ] 

jirapos...@reviews.apache.org commented on HBASE-5358:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/#review4999
---



src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java


Ok.  Good.


- Michael


On 2012-02-09 22:18:10, enis wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3811/
bq.  ---
bq.  
bq.  (Updated 2012-02-09 22:18:10)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] 
where A extends Writable. This becomes an issue for example when adding a 
coprocessor method which takes A[] (see HBASE-5352).
bq.  
bq.  
bq.  This addresses bug HBASE-5358.
bq.  https://issues.apache.org/jira/browse/HBASE-5358
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 
260f982 
bq.src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java 
78513ce 
bq.  
bq.  Diff: https://reviews.apache.org/r/3811/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  enis
bq.  
bq.



> HBaseObjectWritable should be able to serialize generic arrays not defined 
> previously
> -
>
> Key: HBASE-5358
> URL: https://issues.apache.org/jira/browse/HBASE-5358
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors, io
>Affects Versions: 0.94.0
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Attachments: HBASE-5358_v3.patch
>
>
> HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
> A extends Writable. This becomes an issue for example when adding a 
> coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously

2012-02-09 Thread Zhihong Yu (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205056#comment-13205056
 ] 

Zhihong Yu commented on HBASE-5358:
---

Test result looks good.

Plan to integrate the patch tomorrow.

> HBaseObjectWritable should be able to serialize generic arrays not defined 
> previously
> -
>
> Key: HBASE-5358
> URL: https://issues.apache.org/jira/browse/HBASE-5358
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors, io
>Affects Versions: 0.94.0
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Attachments: HBASE-5358_v3.patch
>
>
> HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
> A extends Writable. This becomes an issue for example when adding a 
> coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously

2012-02-09 Thread Hadoop QA (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205053#comment-13205053
 ] 

Hadoop QA commented on HBASE-5358:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12514031/HBASE-5358_v3.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 11 new or modified tests.

-1 javadoc.  The javadoc tool appears to have generated -136 warning 
messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 156 new Findbugs (version 
1.3.9) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   org.apache.hadoop.hbase.mapreduce.TestImportTsv
  org.apache.hadoop.hbase.mapred.TestTableMapReduce
  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/932//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/932//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/932//console

This message is automatically generated.

> HBaseObjectWritable should be able to serialize generic arrays not defined 
> previously
> -
>
> Key: HBASE-5358
> URL: https://issues.apache.org/jira/browse/HBASE-5358
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors, io
>Affects Versions: 0.94.0
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Attachments: HBASE-5358_v3.patch
>
>
> HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
> A extends Writable. This becomes an issue for example when adding a 
> coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously

2012-02-09 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204969#comment-13204969
 ] 

jirapos...@reviews.apache.org commented on HBASE-5358:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/#review4995
---


Looks good.
Please attach patch to JIRA so that Hadoop QA can run test suite.


src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java


code is no longer a byte.
Please adjust javadoc accordingly.


- Ted


On 2012-02-09 22:18:10, enis wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3811/
bq.  ---
bq.  
bq.  (Updated 2012-02-09 22:18:10)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] 
where A extends Writable. This becomes an issue for example when adding a 
coprocessor method which takes A[] (see HBASE-5352).
bq.  
bq.  
bq.  This addresses bug HBASE-5358.
bq.  https://issues.apache.org/jira/browse/HBASE-5358
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 
260f982 
bq.src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java 
78513ce 
bq.  
bq.  Diff: https://reviews.apache.org/r/3811/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  enis
bq.  
bq.



> HBaseObjectWritable should be able to serialize generic arrays not defined 
> previously
> -
>
> Key: HBASE-5358
> URL: https://issues.apache.org/jira/browse/HBASE-5358
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors, io
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
>
> HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
> A extends Writable. This becomes an issue for example when adding a 
> coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously

2012-02-09 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204956#comment-13204956
 ] 

jirapos...@reviews.apache.org commented on HBASE-5358:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/
---

(Updated 2012-02-09 22:18:10.009110)


Review request for hbase.


Changes
---

Incoprorated review comments, optimized the serialization of Arrays of know 
types, and added a few more test cases


Summary
---

HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where A 
extends Writable. This becomes an issue for example when adding a coprocessor 
method which takes A[] (see HBASE-5352).


This addresses bug HBASE-5358.
https://issues.apache.org/jira/browse/HBASE-5358


Diffs (updated)
-

  src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 260f982 
  src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java 78513ce 

Diff: https://reviews.apache.org/r/3811/diff


Testing
---


Thanks,

enis



> HBaseObjectWritable should be able to serialize generic arrays not defined 
> previously
> -
>
> Key: HBASE-5358
> URL: https://issues.apache.org/jira/browse/HBASE-5358
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors, io
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
>
> HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
> A extends Writable. This becomes an issue for example when adding a 
> coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously

2012-02-09 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204943#comment-13204943
 ] 

jirapos...@reviews.apache.org commented on HBASE-5358:
--



bq.  On 2012-02-09 02:16:29, Ted Yu wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java, line 
606
bq.  > 
bq.  >
bq.  > Should we validate length ?

It is not validated in other array/list read operations. The allocation will 
fail anyway if the length is off, no? 


bq.  On 2012-02-09 02:16:29, Ted Yu wrote:
bq.  > src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java, 
line 246
bq.  > 
bq.  >
bq.  > What does InSeq mean ?

Oh, it comes from Seg from Scala, where Array and List extends. I'll 
change the method name to testPolymorphismInSequences(), and add some comments, 
if you don't have any suggestion. 


bq.  On 2012-02-09 02:16:29, Ted Yu wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java, line 
445
bq.  > 
bq.  >
bq.  > What if componentType is another Array ?

The test case for A[][] already covers for this i believe. 


- enis


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/#review4952
---


On 2012-02-09 01:38:18, enis wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3811/
bq.  ---
bq.  
bq.  (Updated 2012-02-09 01:38:18)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] 
where A extends Writable. This becomes an issue for example when adding a 
coprocessor method which takes A[] (see HBASE-5352).
bq.  
bq.  
bq.  This addresses bug HBASE-5358.
bq.  https://issues.apache.org/jira/browse/HBASE-5358
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java 
78513ce 
bq.src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 
260f982 
bq.  
bq.  Diff: https://reviews.apache.org/r/3811/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  enis
bq.  
bq.



> HBaseObjectWritable should be able to serialize generic arrays not defined 
> previously
> -
>
> Key: HBASE-5358
> URL: https://issues.apache.org/jira/browse/HBASE-5358
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors, io
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
>
> HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
> A extends Writable. This becomes an issue for example when adding a 
> coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously

2012-02-09 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204942#comment-13204942
 ] 

jirapos...@reviews.apache.org commented on HBASE-5358:
--



bq.  On 2012-02-09 07:02:48, Michael Stack wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java, line 
446
bq.  > 
bq.  >
bq.  > We are changing what is on the line now when we serialize?  All 
arrays now serialize their type ahead of array length?  In our public API what 
arrays will this effect?  Do you know?  Does it require our upping the version 
on the Interface that uses HBaseObjectWritable?

We are not changing the serialized bytes for the arrays that are already in 
CLASS_TO_CODE. This only affects the arrays that are not defined there. For 
them, when you serialize, the deserializer throws an erroneous 
ClassNotFoundException. So, I don't think wire compatibility will be affected. 


- enis


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/#review4960
---


On 2012-02-09 01:38:18, enis wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3811/
bq.  ---
bq.  
bq.  (Updated 2012-02-09 01:38:18)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] 
where A extends Writable. This becomes an issue for example when adding a 
coprocessor method which takes A[] (see HBASE-5352).
bq.  
bq.  
bq.  This addresses bug HBASE-5358.
bq.  https://issues.apache.org/jira/browse/HBASE-5358
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java 
78513ce 
bq.src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 
260f982 
bq.  
bq.  Diff: https://reviews.apache.org/r/3811/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  enis
bq.  
bq.



> HBaseObjectWritable should be able to serialize generic arrays not defined 
> previously
> -
>
> Key: HBASE-5358
> URL: https://issues.apache.org/jira/browse/HBASE-5358
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors, io
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
>
> HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
> A extends Writable. This becomes an issue for example when adding a 
> coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously

2012-02-08 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204314#comment-13204314
 ] 

jirapos...@reviews.apache.org commented on HBASE-5358:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/#review4960
---



src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java


We are changing what is on the line now when we serialize?  All arrays now 
serialize their type ahead of array length?  In our public API what arrays will 
this effect?  Do you know?  Does it require our upping the version on the 
Interface that uses HBaseObjectWritable?



src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java


Good


- Michael


On 2012-02-09 01:38:18, enis wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3811/
bq.  ---
bq.  
bq.  (Updated 2012-02-09 01:38:18)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] 
where A extends Writable. This becomes an issue for example when adding a 
coprocessor method which takes A[] (see HBASE-5352).
bq.  
bq.  
bq.  This addresses bug HBASE-5358.
bq.  https://issues.apache.org/jira/browse/HBASE-5358
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java 
78513ce 
bq.src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 
260f982 
bq.  
bq.  Diff: https://reviews.apache.org/r/3811/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  enis
bq.  
bq.



> HBaseObjectWritable should be able to serialize generic arrays not defined 
> previously
> -
>
> Key: HBASE-5358
> URL: https://issues.apache.org/jira/browse/HBASE-5358
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors, io
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
>
> HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
> A extends Writable. This becomes an issue for example when adding a 
> coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously

2012-02-08 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204249#comment-13204249
 ] 

jirapos...@reviews.apache.org commented on HBASE-5358:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/#review4958
---



src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java


Ignore this comment.
I see the recursive call @ line 441.


- Ted


On 2012-02-09 01:38:18, enis wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3811/
bq.  ---
bq.  
bq.  (Updated 2012-02-09 01:38:18)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] 
where A extends Writable. This becomes an issue for example when adding a 
coprocessor method which takes A[] (see HBASE-5352).
bq.  
bq.  
bq.  This addresses bug HBASE-5358.
bq.  https://issues.apache.org/jira/browse/HBASE-5358
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java 
78513ce 
bq.src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 
260f982 
bq.  
bq.  Diff: https://reviews.apache.org/r/3811/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  enis
bq.  
bq.



> HBaseObjectWritable should be able to serialize generic arrays not defined 
> previously
> -
>
> Key: HBASE-5358
> URL: https://issues.apache.org/jira/browse/HBASE-5358
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors, io
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
>
> HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
> A extends Writable. This becomes an issue for example when adding a 
> coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously

2012-02-08 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204197#comment-13204197
 ] 

jirapos...@reviews.apache.org commented on HBASE-5358:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/#review4952
---



src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java


Please move this to line 429.



src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java


getClassCode(Array.class) should be stored in a static variable.



src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java


What if componentType is another Array ?



src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java


Should we validate length ?



src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java


What does InSeq mean ?


- Ted


On 2012-02-09 01:38:18, enis wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3811/
bq.  ---
bq.  
bq.  (Updated 2012-02-09 01:38:18)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] 
where A extends Writable. This becomes an issue for example when adding a 
coprocessor method which takes A[] (see HBASE-5352).
bq.  
bq.  
bq.  This addresses bug HBASE-5358.
bq.  https://issues.apache.org/jira/browse/HBASE-5358
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java 
78513ce 
bq.src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 
260f982 
bq.  
bq.  Diff: https://reviews.apache.org/r/3811/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  enis
bq.  
bq.



> HBaseObjectWritable should be able to serialize generic arrays not defined 
> previously
> -
>
> Key: HBASE-5358
> URL: https://issues.apache.org/jira/browse/HBASE-5358
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors, io
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
>
> HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
> A extends Writable. This becomes an issue for example when adding a 
> coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously

2012-02-08 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204181#comment-13204181
 ] 

jirapos...@reviews.apache.org commented on HBASE-5358:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/
---

Review request for hbase.


Summary
---

HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where A 
extends Writable. This becomes an issue for example when adding a coprocessor 
method which takes A[] (see HBASE-5352).


This addresses bug HBASE-5358.
https://issues.apache.org/jira/browse/HBASE-5358


Diffs
-

  src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java 78513ce 
  src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 260f982 

Diff: https://reviews.apache.org/r/3811/diff


Testing
---


Thanks,

enis



> HBaseObjectWritable should be able to serialize generic arrays not defined 
> previously
> -
>
> Key: HBASE-5358
> URL: https://issues.apache.org/jira/browse/HBASE-5358
> Project: HBase
>  Issue Type: Improvement
>  Components: coprocessors, io
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
>
> HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
> A extends Writable. This becomes an issue for example when adding a 
> coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira