[jira] [Commented] (HBASE-6776) Opened region of disabled/enabling table is not added to online region list
[ https://issues.apache.org/jira/browse/HBASE-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456429#comment-13456429 ] Jimmy Xiang commented on HBASE-6776: That's right. Good point. I will update the patch. > Opened region of disabled/enabling table is not added to online region list > --- > > Key: HBASE-6776 > URL: https://issues.apache.org/jira/browse/HBASE-6776 > Project: HBase > Issue Type: Bug >Reporter: Jimmy Xiang >Assignee: Jimmy Xiang > Attachments: trunk-6776.patch > > > For opened region of disabled table, it should be added to online region > list, and then closed. We should not just ignore them. > For opened region of enabling table, it should be added to online region > list, so that we don't have to assign it again. Without adding it to online > region list, it could be double assigned when assign it again later. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6776) Opened region of disabled/enabling table is not added to online region list
[ https://issues.apache.org/jira/browse/HBASE-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456379#comment-13456379 ] rajeshbabu commented on HBASE-6776: --- @Jimmy If the scenario told by Ram happened after disable, with this patch assignment wont happen for the regions yet to be assigned because .META. has server info(server where the regions opened before disable) for the regions bq. Now if i have 4 regions for a table. 1 is assigned, 2 in the process of assigning and 1 is yet to be assigned so the table is in ENABLING(Lets suppose master restarted now). Now if all the regions are added to online map then how will EnableTableHandler know that he has to assign the ones that are not assigned? > Opened region of disabled/enabling table is not added to online region list > --- > > Key: HBASE-6776 > URL: https://issues.apache.org/jira/browse/HBASE-6776 > Project: HBase > Issue Type: Bug >Reporter: Jimmy Xiang >Assignee: Jimmy Xiang > Attachments: trunk-6776.patch > > > For opened region of disabled table, it should be added to online region > list, and then closed. We should not just ignore them. > For opened region of enabling table, it should be added to online region > list, so that we don't have to assign it again. Without adding it to online > region list, it could be double assigned when assign it again later. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6776) Opened region of disabled/enabling table is not added to online region list
[ https://issues.apache.org/jira/browse/HBASE-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455973#comment-13455973 ] Jimmy Xiang commented on HBASE-6776: That's a good question. In rebuilding the user regions, only these regions are added to online region map: 1. there is a server info in Meta for the region, and 2. the server is online. Here is the assumption: For the regions not assigned yet or still in assigning, the meta entry should not have the server info (assume no region in transition znodes, if there is, process region in transition will correct the assigning region's state). For tables not in ENABLING, this is our assumption too. So the question is whether the assumption correct, right? I think it is correct. > Opened region of disabled/enabling table is not added to online region list > --- > > Key: HBASE-6776 > URL: https://issues.apache.org/jira/browse/HBASE-6776 > Project: HBase > Issue Type: Bug >Reporter: Jimmy Xiang >Assignee: Jimmy Xiang > Attachments: trunk-6776.patch > > > For opened region of disabled table, it should be added to online region > list, and then closed. We should not just ignore them. > For opened region of enabling table, it should be added to online region > list, so that we don't have to assign it again. Without adding it to online > region list, it could be double assigned when assign it again later. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6776) Opened region of disabled/enabling table is not added to online region list
[ https://issues.apache.org/jira/browse/HBASE-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455965#comment-13455965 ] ramkrishna.s.vasudevan commented on HBASE-6776: --- @Jimmy If i read the patch correctly we just add all the regions into the regiononline map. Now if i have 4 regions for a table. 1 is assigned, 2 in the process of assigning and 1 is yet to be assigned so the table is in ENABLING. Now if all the regions are added to online map then how will EnableTableHandler know that he has to assign the ones that are not assigned? Actually HBASe-6317 tries to solve the problem that you mentioned - double assignment. Pls correct me if am wrong Jimmy. May be am missing something in trunk after the refactorings? > Opened region of disabled/enabling table is not added to online region list > --- > > Key: HBASE-6776 > URL: https://issues.apache.org/jira/browse/HBASE-6776 > Project: HBase > Issue Type: Bug >Reporter: Jimmy Xiang >Assignee: Jimmy Xiang > Attachments: trunk-6776.patch > > > For opened region of disabled table, it should be added to online region > list, and then closed. We should not just ignore them. > For opened region of enabling table, it should be added to online region > list, so that we don't have to assign it again. Without adding it to online > region list, it could be double assigned when assign it again later. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6776) Opened region of disabled/enabling table is not added to online region list
[ https://issues.apache.org/jira/browse/HBASE-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455915#comment-13455915 ] Jimmy Xiang commented on HBASE-6776: regionsToAssign will remove those already online regions from the regionsInMeta, then assign the rest of regions. That's what we want. This could happen during unit test for sure, some man-made corruptions. Another scenario could be because of racing between disabling a table, and assigning the table without going through ZK. > Opened region of disabled/enabling table is not added to online region list > --- > > Key: HBASE-6776 > URL: https://issues.apache.org/jira/browse/HBASE-6776 > Project: HBase > Issue Type: Bug >Reporter: Jimmy Xiang >Assignee: Jimmy Xiang > Attachments: trunk-6776.patch > > > For opened region of disabled table, it should be added to online region > list, and then closed. We should not just ignore them. > For opened region of enabling table, it should be added to online region > list, so that we don't have to assign it again. Without adding it to online > region list, it could be double assigned when assign it again later. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6776) Opened region of disabled/enabling table is not added to online region list
[
https://issues.apache.org/jira/browse/HBASE-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455690#comment-13455690
]
ramkrishna.s.vasudevan commented on HBASE-6776:
---
-> Adding all regions to online map?
How does enabletablehandler work then?
{code}
List regionsInMeta;
regionsInMeta = MetaReader.getTableRegions(this.ct, tableName, true);
int countOfRegionsInTable = regionsInMeta.size();
List regions = regionsToAssign(regionsInMeta);
{code}
This piece of code will not allow the assignment to happen right ?
-> Changing from DISABLED to DISABLING
In what condition this will happen? Because state is in DISABLED for sure we
can know that the disabling is completed fully?
> Opened region of disabled/enabling table is not added to online region list
> ---
>
> Key: HBASE-6776
> URL: https://issues.apache.org/jira/browse/HBASE-6776
> Project: HBase
> Issue Type: Bug
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Attachments: trunk-6776.patch
>
>
> For opened region of disabled table, it should be added to online region
> list, and then closed. We should not just ignore them.
> For opened region of enabling table, it should be added to online region
> list, so that we don't have to assign it again. Without adding it to online
> region list, it could be double assigned when assign it again later.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6776) Opened region of disabled/enabling table is not added to online region list
[ https://issues.apache.org/jira/browse/HBASE-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455483#comment-13455483 ] Jimmy Xiang commented on HBASE-6776: Right, the table is Disabled. Somehow, there is still a region opened somewhere. > Opened region of disabled/enabling table is not added to online region list > --- > > Key: HBASE-6776 > URL: https://issues.apache.org/jira/browse/HBASE-6776 > Project: HBase > Issue Type: Bug >Reporter: Jimmy Xiang >Assignee: Jimmy Xiang > Attachments: trunk-6776.patch > > > For opened region of disabled table, it should be added to online region > list, and then closed. We should not just ignore them. > For opened region of enabling table, it should be added to online region > list, so that we don't have to assign it again. Without adding it to online > region list, it could be double assigned when assign it again later. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6776) Opened region of disabled/enabling table is not added to online region list
[ https://issues.apache.org/jira/browse/HBASE-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455464#comment-13455464 ] Hadoop QA commented on HBASE-6776: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12545063/trunk-6776.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause mvn compile goal to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2861//testReport/ Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2861//console This message is automatically generated. > Opened region of disabled/enabling table is not added to online region list > --- > > Key: HBASE-6776 > URL: https://issues.apache.org/jira/browse/HBASE-6776 > Project: HBase > Issue Type: Bug >Reporter: Jimmy Xiang >Assignee: Jimmy Xiang > Attachments: trunk-6776.patch > > > For opened region of disabled table, it should be added to online region > list, and then closed. We should not just ignore them. > For opened region of enabling table, it should be added to online region > list, so that we don't have to assign it again. Without adding it to online > region list, it could be double assigned when assign it again later. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6776) Opened region of disabled/enabling table is not added to online region list
[ https://issues.apache.org/jira/browse/HBASE-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455451#comment-13455451 ] stack commented on HBASE-6776: -- bq. For opened region of disabled table, it should be added to online region list, and then closed. We should not just ignore them. So, I see you add all to online regions in your patch. If we do this inside in the rebuild of user regions, where do we do the close you suggest above? I see you do this: getZKTable().setDisablingTable(tableName); What is going on here? The table was Disabled but you are setting the set back to Disabling because you came across a region that is still open? bq. For opened region of enabling table, it should be added to online region list, so that we don't have to assign it again. Without adding it to online region list, it could be double assigned when assign it again later. This seems right. > Opened region of disabled/enabling table is not added to online region list > --- > > Key: HBASE-6776 > URL: https://issues.apache.org/jira/browse/HBASE-6776 > Project: HBase > Issue Type: Bug >Reporter: Jimmy Xiang >Assignee: Jimmy Xiang > Attachments: trunk-6776.patch > > > For opened region of disabled table, it should be added to online region > list, and then closed. We should not just ignore them. > For opened region of enabling table, it should be added to online region > list, so that we don't have to assign it again. Without adding it to online > region list, it could be double assigned when assign it again later. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
