[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13476094#comment-13476094 ] Hudson commented on HBASE-6785: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #221 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/221/]) HBASE-6785 Convert AggregateProtocol to protobuf defined coprocessor service (Devaraj Das) (Revision 1398175) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/LongColumnInterpreter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/ColumnInterpreter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AggregateProtos.java * /hbase/trunk/hbase-server/src/main/protobuf/Aggregate.proto Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6785-2.patch, 6785-simplified-pb1.patch, Aggregate.proto, Aggregate.proto With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[
https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13476548#comment-13476548
]
Gary Helmling commented on HBASE-6785:
--
FYI, opened HBASE-6995 for exposing {{BlockingInterface}} instances for
coprocessor endpoints.
Convert AggregateProtocol to protobuf defined coprocessor service
-
Key: HBASE-6785
URL: https://issues.apache.org/jira/browse/HBASE-6785
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6785-2.patch, 6785-simplified-pb1.patch,
Aggregate.proto, Aggregate.proto
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475935#comment-13475935 ] Gary Helmling commented on HBASE-6785: -- Latest patch looks good to me. Thanks for the doc updates, Devaraj. [~zhi...@ebaysf.com], do you have any other comments? Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6785-2.patch, 6785-simplified-pb1.patch, Aggregate.proto, Aggregate.proto With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475940#comment-13475940 ] Ted Yu commented on HBASE-6785: --- I don't have other comments. Integrated to trunk. Thanks for the review, Gary. Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6785-2.patch, 6785-simplified-pb1.patch, Aggregate.proto, Aggregate.proto With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475946#comment-13475946 ] Hudson commented on HBASE-6785: --- Integrated in HBase-TRUNK #3447 (See [https://builds.apache.org/job/HBase-TRUNK/3447/]) HBASE-6785 Convert AggregateProtocol to protobuf defined coprocessor service (Devaraj Das) (Revision 1398175) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/LongColumnInterpreter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/ColumnInterpreter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AggregateProtos.java * /hbase/trunk/hbase-server/src/main/protobuf/Aggregate.proto Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6785-2.patch, 6785-simplified-pb1.patch, Aggregate.proto, Aggregate.proto With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475195#comment-13475195 ] Ted Yu commented on HBASE-6785: --- [~ghelmling]: What do you think of the latest patch ? Thanks Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6785-2.patch, 6785-simplified-pb1.patch, Aggregate.proto, Aggregate.proto With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[
https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13474788#comment-13474788
]
Hadoop QA commented on HBASE-6785:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12548846/6785-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
82 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 5 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3041//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3041//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3041//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3041//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3041//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3041//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3041//console
This message is automatically generated.
Convert AggregateProtocol to protobuf defined coprocessor service
-
Key: HBASE-6785
URL: https://issues.apache.org/jira/browse/HBASE-6785
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6785-2.patch, 6785-simplified-pb1.patch,
Aggregate.proto, Aggregate.proto
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[
https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13473048#comment-13473048
]
Hadoop QA commented on HBASE-6785:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12548528/6785-simplified-pb1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
82 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 5 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3026//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3026//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3026//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3026//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3026//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3026//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3026//console
This message is automatically generated.
Convert AggregateProtocol to protobuf defined coprocessor service
-
Key: HBASE-6785
URL: https://issues.apache.org/jira/browse/HBASE-6785
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6785-simplified-pb1.patch, Aggregate.proto,
Aggregate.proto
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472163#comment-13472163 ] Devaraj Das commented on HBASE-6785: https://reviews.apache.org/r/7495/ is the new RB. Please ignore the previous one. Thanks, Ted for looking over the patch. I have simplified the PB definition to have only one message (all the use cases are covered by this one message). Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: Aggregate.proto, Aggregate.proto With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472166#comment-13472166 ] Devaraj Das commented on HBASE-6785: Just to reiterate, the patch could do with some cleanup and maybe javadoc fixes here and there. I have posted it here to get a feedback on the ColumnInterpreter interface additions, and the PB definition.. I'll clean up the patch as a follow up. Thanks! Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: Aggregate.proto, Aggregate.proto With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472406#comment-13472406 ] Ted Yu commented on HBASE-6785: --- Minor comment: 6758-simplified-pb.patch should have been named 6785-simplified-pb.patch (JIRA number was wrong) review comments to follow. Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: Aggregate.proto, Aggregate.proto With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13471424#comment-13471424 ] Devaraj Das commented on HBASE-6785: https://reviews.apache.org/r/7470/ has an initial patch on RB. Please have a look at that (I am debugging unit test failures) but it will be good to have some feedback on the patch now. Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: Aggregate.proto, Aggregate.proto With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13471427#comment-13471427 ] Devaraj Das commented on HBASE-6785: https://reviews.apache.org/media/uploaded/files/2012/10/08/6758-rb-2.patch is the right patch. For some reason RB doesn't display the latest diffs when I click on View Diff (in my latest uploaded patch I don't have the TestAggregateProtocol mods, whereas RB shows them..). Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: Aggregate.proto, Aggregate.proto With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13471651#comment-13471651 ] Ted Yu commented on HBASE-6785: --- Using 6758-rb-2.patch, I was able to create review request. Instead of attaching 6758-rb-2.patch, you should either upload it to current request or create a new one. Review comments to follow. Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: Aggregate.proto, Aggregate.proto With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[
https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13471661#comment-13471661
]
Ted Yu commented on HBASE-6785:
---
{code}
+message AggregateResponseTuple {
+ repeated bytes key = 1;
+ optional bytes value = 2;
+}
{code}
Looking at the definition from http://en.wikipedia.org/wiki/Tuple, I don't see
the term key.
I am trying to find a better term for the above structure.
{code}
+ * Return the PB for type T
+ * @param s
+ * @return PB-message
+ */
+ ByteString getProtoForPromotedType(S s);
{code}
'type T' - 'promoted type S'
{code}
+ public ByteString getProtoForPromotedType(Long s) {
+log.info(getProtoForCellType + s);
{code}
The log should be at debug level. Method name doesn't match log message.
Since the above method has same implementation as getProtoForCellType(), you
may want to extract the body in a utility method.
Convert AggregateProtocol to protobuf defined coprocessor service
-
Key: HBASE-6785
URL: https://issues.apache.org/jira/browse/HBASE-6785
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: Aggregate.proto, Aggregate.proto
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468697#comment-13468697 ] Ted Yu commented on HBASE-6785: --- castToReturnType(Object) signature and its javadoc isn't shown above. FYI Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: Aggregate.proto, Aggregate.proto With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468240#comment-13468240 ] Devaraj Das commented on HBASE-6785: bq. When BigDecimalColumnInterpreter is added, the above enum needs to be modified, right ? Yeah (good point) .. but it makes me less happy. I'll fix this to not have the enum at all. Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: Aggregate.proto With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[
https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468260#comment-13468260
]
Ted Yu commented on HBASE-6785:
---
Thanks Devaraj for being considerate.
w.r.t. the placeholder 'bytes' for the ColumnInterpreter serialization, let's
consider the following interpreter from HBASE-6669:
{code}
+public class BigDecimalColumnInterpreter implements
+ColumnInterpreterBigDecimal, BigDecimal {
+
+ private BigDecimal minValue;
+ private BigDecimal maxValue;
{code}
Looks like the user may need to serialize more than one field.
How about changing the field to this:
{code}
optional repeated bytes interpreterSpecificBytes = 2;
{code}
Convert AggregateProtocol to protobuf defined coprocessor service
-
Key: HBASE-6785
URL: https://issues.apache.org/jira/browse/HBASE-6785
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: Aggregate.proto
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468317#comment-13468317 ] stack commented on HBASE-6785: -- I thought for these endservices 1., we'd not be trying to bring folks over the singularity, and 2., they'll have to define their own pb if they want to extend. Given this, I'd say drop interpreterSpecificBytes. Let them add what ever they need explicitly. Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: Aggregate.proto With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[
https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468339#comment-13468339
]
Devaraj Das commented on HBASE-6785:
[~stack] IMO we need to serialize the ColumnInterpreter data to keep semantic
compatibility. The ColumnInterpreter today implements the Writable interface,
and it gets serialized as part of the AggregateProtocol coprocessor invocation.
So in the PB world, my aim was to maintain this compatibility although the user
should use PB instead for the serialization...
Am I missing something?
What I have done now is that ColumnInterpreter has a couple of interface
methods that users need to implement (and maybe for interpreters like
_LongColumnInterpreter_ the methods could trivially return the passed argument
or return null in some cases):
{noformat}
/**
* This method should implement the conversion of the columninterpreter
* to a PB message (used on the client side)
*/
AggregateProtos.ColumnInterpreter convertToColumnInterpreterMessage();
/**
* This method should implement the conversion of a PB message to the
* ColumnInterpreter class (used on the server side)
*/
ColumnInterpreterT,S getInstance(AggregateProtos.ColumnInterpreter message);
/**
* Converts the bytes in the server's response to the expected type S
*/
S parseResponseAsReturnType(AggregateProtos.AggregateResponse
responseMessage);
/**
* The response message comes as type S. This will convert/cast it to T.
* In some sense, performs the opposite of {@link #castToReturnType(Object)}
*/
T castToLowerType(S response);
{noformat}
The AggregationClient APIs will remain mostly the same (the implementation of
the AggregationClient APIs will use the above new ColumnInterpreter APIs in
addition to what it uses already).
I'll post a patch sometime soon that does the end-to-end stuff, but yeah please
let me know if this seems off the track.
Convert AggregateProtocol to protobuf defined coprocessor service
-
Key: HBASE-6785
URL: https://issues.apache.org/jira/browse/HBASE-6785
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: Aggregate.proto
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[
https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467345#comment-13467345
]
Ted Yu commented on HBASE-6785:
---
{code}
enum Type { SHORT = 1; INT = 2; LONG = 3; FLOAT = 4; DOUBLE = 5; }
{code}
When BigDecimalColumnInterpreter is added, the above enum needs to be modified,
right ?
bq. users will be impacted w.r.t the usage (via AggregationClient)
Yeah. That would be a little painful.
Convert AggregateProtocol to protobuf defined coprocessor service
-
Key: HBASE-6785
URL: https://issues.apache.org/jira/browse/HBASE-6785
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: Aggregate.proto
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13457930#comment-13457930 ] Ted Yu commented on HBASE-6785: --- Looking at AggregateProtocol, it utilizes type parameters in order to accommodate various ColumnInterpreters. I wonder how protobuf supports this use case. Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: coprocessors Reporter: Gary Helmling Fix For: 0.96.0 With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458047#comment-13458047 ] Gary Helmling commented on HBASE-6785: -- I believe we would need to specify the expected type or ColumnInterpreter as a field in the request message passed to the service. We would probably lose some transparency from the client side in being able to inspect return types to determine this, though possibly the request construction (and return type introspection) could still be hidden in the client layer. We'd need to look at it from both the client and server/service-definition side. Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: coprocessors Reporter: Gary Helmling Fix For: 0.96.0 With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6785) Convert AggregateProtocol to protobuf defined coprocessor service
[ https://issues.apache.org/jira/browse/HBASE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458167#comment-13458167 ] Ted Yu commented on HBASE-6785: --- ColumnInterpreter is genericized as well. Looks like we're going to lose some flexibility in protobuf defined coprocessor service version. Convert AggregateProtocol to protobuf defined coprocessor service - Key: HBASE-6785 URL: https://issues.apache.org/jira/browse/HBASE-6785 Project: HBase Issue Type: Sub-task Components: coprocessors Reporter: Gary Helmling Fix For: 0.96.0 With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
