[jira] [Commented] (HBASE-7531) [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't nullify the reader

2013-02-04 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13570941#comment-13570941
 ] 

Hudson commented on HBASE-7531:
---

Integrated in HBase-0.94-security-on-Hadoop-23 #11 (See 
[https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/11/])
HBASE-7530  [replication] Work around HDFS-4380 else we get NPEs
HBASE-7531  [replication] NPE in SequenceFileLogReader because
ReplicationSource doesn't nullify the reader
HBASE-7534  [replication] TestReplication.queueFailover can fail
because HBaseTestingUtility.createMultiRegions is dangerous 
(Revision 1431769)

 Result = FAILURE
jdcryans : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java


 [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't 
 nullify the reader
 ---

 Key: HBASE-7531
 URL: https://issues.apache.org/jira/browse/HBASE-7531
 Project: HBase
  Issue Type: Bug
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
 Fix For: 0.96.0, 0.94.5

 Attachments: HBASE-7531.patch


 Here's a NPE I get half the time I run TestReplication:
 {noformat}
 2012-12-20 08:59:17,259 ERROR 
 [RegionServer:1;192.168.10.135,49168,1356011734418-EventThread.replicationSource,2]
  regionserver.ReplicationSource$1(727): Unexpected exception in 
 ReplicationSource, 
 currentPath=hdfs://localhost:65533/user/jdcryans/hbase/.logs/192.168.10.135,49168,1356011734418/192.168.10.135%2C49168%2C1356011734418.1356011956626
 java.lang.NullPointerException
 at 
 org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.seek(SequenceFileLogReader.java:261)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationHLogReaderManager.seek(ReplicationHLogReaderManager.java:103)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.readAllEntriesToReplicateOrNextFile(ReplicationSource.java:414)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:332)
 {noformat}
 The issue happens after an IOE was caught while opening the reader, the issue 
 is that it isn't set to null after that then the rest of the code assumes the 
 reader is usable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7531) [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't nullify the reader

2013-01-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554217#comment-13554217
 ] 

Hudson commented on HBASE-7531:
---

Integrated in HBase-0.94-security #95 (See 
[https://builds.apache.org/job/HBase-0.94-security/95/])
HBASE-7530  [replication] Work around HDFS-4380 else we get NPEs
HBASE-7531  [replication] NPE in SequenceFileLogReader because
ReplicationSource doesn't nullify the reader
HBASE-7534  [replication] TestReplication.queueFailover can fail
because HBaseTestingUtility.createMultiRegions is dangerous 
(Revision 1431769)

 Result = SUCCESS
jdcryans : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java


 [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't 
 nullify the reader
 ---

 Key: HBASE-7531
 URL: https://issues.apache.org/jira/browse/HBASE-7531
 Project: HBase
  Issue Type: Bug
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
 Fix For: 0.96.0, 0.94.5

 Attachments: HBASE-7531.patch


 Here's a NPE I get half the time I run TestReplication:
 {noformat}
 2012-12-20 08:59:17,259 ERROR 
 [RegionServer:1;192.168.10.135,49168,1356011734418-EventThread.replicationSource,2]
  regionserver.ReplicationSource$1(727): Unexpected exception in 
 ReplicationSource, 
 currentPath=hdfs://localhost:65533/user/jdcryans/hbase/.logs/192.168.10.135,49168,1356011734418/192.168.10.135%2C49168%2C1356011734418.1356011956626
 java.lang.NullPointerException
 at 
 org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.seek(SequenceFileLogReader.java:261)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationHLogReaderManager.seek(ReplicationHLogReaderManager.java:103)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.readAllEntriesToReplicateOrNextFile(ReplicationSource.java:414)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:332)
 {noformat}
 The issue happens after an IOE was caught while opening the reader, the issue 
 is that it isn't set to null after that then the rest of the code assumes the 
 reader is usable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7531) [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't nullify the reader

2013-01-10 Thread Sergey Shelukhin (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13549948#comment-13549948
 ] 

Sergey Shelukhin commented on HBASE-7531:
-

+1. The cause is the dubious semantics of openReader imho (but I may just be 
unfamiliar with code); sleepMultiplier decision can be in the outside loop and 
openReader return value meaning can then be simpler.

 [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't 
 nullify the reader
 ---

 Key: HBASE-7531
 URL: https://issues.apache.org/jira/browse/HBASE-7531
 Project: HBase
  Issue Type: Bug
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
 Attachments: HBASE-7531.patch


 Here's a NPE I get half the time I run TestReplication:
 {noformat}
 2012-12-20 08:59:17,259 ERROR 
 [RegionServer:1;192.168.10.135,49168,1356011734418-EventThread.replicationSource,2]
  regionserver.ReplicationSource$1(727): Unexpected exception in 
 ReplicationSource, 
 currentPath=hdfs://localhost:65533/user/jdcryans/hbase/.logs/192.168.10.135,49168,1356011734418/192.168.10.135%2C49168%2C1356011734418.1356011956626
 java.lang.NullPointerException
 at 
 org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.seek(SequenceFileLogReader.java:261)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationHLogReaderManager.seek(ReplicationHLogReaderManager.java:103)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.readAllEntriesToReplicateOrNextFile(ReplicationSource.java:414)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:332)
 {noformat}
 The issue happens after an IOE was caught while opening the reader, the issue 
 is that it isn't set to null after that then the rest of the code assumes the 
 reader is usable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7531) [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't nullify the reader

2013-01-10 Thread Jean-Daniel Cryans (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13550515#comment-13550515
 ] 

Jean-Daniel Cryans commented on HBASE-7531:
---

I was able to find one test failure caused by this:

https://builds.apache.org/job/HBase-0.94/656/testReport/org.apache.hadoop.hbase.replication/TestReplicationWithCompression/testVerifyRepJob/

The replication thread dies so truncating can't complete.

bq. The cause is the dubious semantics of openReader imho

Yeah I should probably fold in that reader somehow into 
ReplicationHLogReaderManager.

 [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't 
 nullify the reader
 ---

 Key: HBASE-7531
 URL: https://issues.apache.org/jira/browse/HBASE-7531
 Project: HBase
  Issue Type: Bug
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
 Attachments: HBASE-7531.patch


 Here's a NPE I get half the time I run TestReplication:
 {noformat}
 2012-12-20 08:59:17,259 ERROR 
 [RegionServer:1;192.168.10.135,49168,1356011734418-EventThread.replicationSource,2]
  regionserver.ReplicationSource$1(727): Unexpected exception in 
 ReplicationSource, 
 currentPath=hdfs://localhost:65533/user/jdcryans/hbase/.logs/192.168.10.135,49168,1356011734418/192.168.10.135%2C49168%2C1356011734418.1356011956626
 java.lang.NullPointerException
 at 
 org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.seek(SequenceFileLogReader.java:261)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationHLogReaderManager.seek(ReplicationHLogReaderManager.java:103)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.readAllEntriesToReplicateOrNextFile(ReplicationSource.java:414)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:332)
 {noformat}
 The issue happens after an IOE was caught while opening the reader, the issue 
 is that it isn't set to null after that then the rest of the code assumes the 
 reader is usable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7531) [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't nullify the reader

2013-01-10 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13550584#comment-13550584
 ] 

stack commented on HBASE-7531:
--

+1

 [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't 
 nullify the reader
 ---

 Key: HBASE-7531
 URL: https://issues.apache.org/jira/browse/HBASE-7531
 Project: HBase
  Issue Type: Bug
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
 Attachments: HBASE-7531.patch


 Here's a NPE I get half the time I run TestReplication:
 {noformat}
 2012-12-20 08:59:17,259 ERROR 
 [RegionServer:1;192.168.10.135,49168,1356011734418-EventThread.replicationSource,2]
  regionserver.ReplicationSource$1(727): Unexpected exception in 
 ReplicationSource, 
 currentPath=hdfs://localhost:65533/user/jdcryans/hbase/.logs/192.168.10.135,49168,1356011734418/192.168.10.135%2C49168%2C1356011734418.1356011956626
 java.lang.NullPointerException
 at 
 org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.seek(SequenceFileLogReader.java:261)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationHLogReaderManager.seek(ReplicationHLogReaderManager.java:103)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.readAllEntriesToReplicateOrNextFile(ReplicationSource.java:414)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:332)
 {noformat}
 The issue happens after an IOE was caught while opening the reader, the issue 
 is that it isn't set to null after that then the rest of the code assumes the 
 reader is usable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7531) [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't nullify the reader

2013-01-10 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13550743#comment-13550743
 ] 

Hudson commented on HBASE-7531:
---

Integrated in HBase-TRUNK #3726 (See 
[https://builds.apache.org/job/HBase-TRUNK/3726/])
HBASE-7530  [replication] Work around HDFS-4380 else we get NPEs
HBASE-7531  [replication] NPE in SequenceFileLogReader because
ReplicationSource doesn't nullify the reader
HBASE-7534  [replication] TestReplication.queueFailover can fail
because HBaseTestingUtility.createMultiRegions is dangerous 
(Revision 1431768)

 Result = FAILURE
jdcryans : 
Files : 
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java


 [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't 
 nullify the reader
 ---

 Key: HBASE-7531
 URL: https://issues.apache.org/jira/browse/HBASE-7531
 Project: HBase
  Issue Type: Bug
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
 Fix For: 0.96.0, 0.94.5

 Attachments: HBASE-7531.patch


 Here's a NPE I get half the time I run TestReplication:
 {noformat}
 2012-12-20 08:59:17,259 ERROR 
 [RegionServer:1;192.168.10.135,49168,1356011734418-EventThread.replicationSource,2]
  regionserver.ReplicationSource$1(727): Unexpected exception in 
 ReplicationSource, 
 currentPath=hdfs://localhost:65533/user/jdcryans/hbase/.logs/192.168.10.135,49168,1356011734418/192.168.10.135%2C49168%2C1356011734418.1356011956626
 java.lang.NullPointerException
 at 
 org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.seek(SequenceFileLogReader.java:261)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationHLogReaderManager.seek(ReplicationHLogReaderManager.java:103)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.readAllEntriesToReplicateOrNextFile(ReplicationSource.java:414)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:332)
 {noformat}
 The issue happens after an IOE was caught while opening the reader, the issue 
 is that it isn't set to null after that then the rest of the code assumes the 
 reader is usable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7531) [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't nullify the reader

2013-01-10 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13550748#comment-13550748
 ] 

Hudson commented on HBASE-7531:
---

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #342 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/342/])
HBASE-7530  [replication] Work around HDFS-4380 else we get NPEs
HBASE-7531  [replication] NPE in SequenceFileLogReader because
ReplicationSource doesn't nullify the reader
HBASE-7534  [replication] TestReplication.queueFailover can fail
because HBaseTestingUtility.createMultiRegions is dangerous 
(Revision 1431768)

 Result = FAILURE
jdcryans : 
Files : 
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java


 [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't 
 nullify the reader
 ---

 Key: HBASE-7531
 URL: https://issues.apache.org/jira/browse/HBASE-7531
 Project: HBase
  Issue Type: Bug
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
 Fix For: 0.96.0, 0.94.5

 Attachments: HBASE-7531.patch


 Here's a NPE I get half the time I run TestReplication:
 {noformat}
 2012-12-20 08:59:17,259 ERROR 
 [RegionServer:1;192.168.10.135,49168,1356011734418-EventThread.replicationSource,2]
  regionserver.ReplicationSource$1(727): Unexpected exception in 
 ReplicationSource, 
 currentPath=hdfs://localhost:65533/user/jdcryans/hbase/.logs/192.168.10.135,49168,1356011734418/192.168.10.135%2C49168%2C1356011734418.1356011956626
 java.lang.NullPointerException
 at 
 org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.seek(SequenceFileLogReader.java:261)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationHLogReaderManager.seek(ReplicationHLogReaderManager.java:103)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.readAllEntriesToReplicateOrNextFile(ReplicationSource.java:414)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:332)
 {noformat}
 The issue happens after an IOE was caught while opening the reader, the issue 
 is that it isn't set to null after that then the rest of the code assumes the 
 reader is usable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7531) [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't nullify the reader

2013-01-10 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13550757#comment-13550757
 ] 

Hudson commented on HBASE-7531:
---

Integrated in HBase-0.94 #722 (See 
[https://builds.apache.org/job/HBase-0.94/722/])
HBASE-7530  [replication] Work around HDFS-4380 else we get NPEs
HBASE-7531  [replication] NPE in SequenceFileLogReader because
ReplicationSource doesn't nullify the reader
HBASE-7534  [replication] TestReplication.queueFailover can fail
because HBaseTestingUtility.createMultiRegions is dangerous 
(Revision 1431769)

 Result = SUCCESS
jdcryans : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java


 [replication] NPE in SequenceFileLogReader because ReplicationSource doesn't 
 nullify the reader
 ---

 Key: HBASE-7531
 URL: https://issues.apache.org/jira/browse/HBASE-7531
 Project: HBase
  Issue Type: Bug
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
 Fix For: 0.96.0, 0.94.5

 Attachments: HBASE-7531.patch


 Here's a NPE I get half the time I run TestReplication:
 {noformat}
 2012-12-20 08:59:17,259 ERROR 
 [RegionServer:1;192.168.10.135,49168,1356011734418-EventThread.replicationSource,2]
  regionserver.ReplicationSource$1(727): Unexpected exception in 
 ReplicationSource, 
 currentPath=hdfs://localhost:65533/user/jdcryans/hbase/.logs/192.168.10.135,49168,1356011734418/192.168.10.135%2C49168%2C1356011734418.1356011956626
 java.lang.NullPointerException
 at 
 org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.seek(SequenceFileLogReader.java:261)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationHLogReaderManager.seek(ReplicationHLogReaderManager.java:103)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.readAllEntriesToReplicateOrNextFile(ReplicationSource.java:414)
 at 
 org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:332)
 {noformat}
 The issue happens after an IOE was caught while opening the reader, the issue 
 is that it isn't set to null after that then the rest of the code assumes the 
 reader is usable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira