[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626339#comment-13626339 ] Hudson commented on HBASE-7615: --- Integrated in HBase-0.94-security #133 (See [https://builds.apache.org/job/HBase-0.94-security/133/]) HBASE-7615 Add metrics for snapshots (Revision 1464931) Result = SUCCESS mbertozzi : Files : * /hbase/branches/0.94/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/metrics/MasterMetrics.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/EnabledTableSnapshotHandler.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java * /hbase/branches/0.94/src/main/resources/hbase-webapps/master/snapshot.jsp * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotManager.java Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Fix For: 0.98.0, 0.94.7, 0.95.1 Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch, HBASE-7615-v2.patch, HBASE-7615-v3.patch, HBASE-7615-v4.patch Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13623624#comment-13623624 ] Hudson commented on HBASE-7615: --- Integrated in HBase-0.94 #947 (See [https://builds.apache.org/job/HBase-0.94/947/]) HBASE-7615 Add metrics for snapshots (Revision 1464931) Result = SUCCESS mbertozzi : Files : * /hbase/branches/0.94/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/metrics/MasterMetrics.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/EnabledTableSnapshotHandler.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java * /hbase/branches/0.94/src/main/resources/hbase-webapps/master/snapshot.jsp * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotManager.java Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Fix For: 0.95.1, 0.98.0, 0.94.7 Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch, HBASE-7615-v2.patch, HBASE-7615-v3.patch, HBASE-7615-v4.patch Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622046#comment-13622046 ] Matteo Bertozzi commented on HBASE-7615: committed to 0.95 and trunk, thanks for the reviews guys. Anyone wants it in 94? Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch, HBASE-7615-v2.patch, HBASE-7615-v3.patch, HBASE-7615-v4.patch Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622074#comment-13622074 ] Hudson commented on HBASE-7615: --- Integrated in HBase-TRUNK #4012 (See [https://builds.apache.org/job/HBase-TRUNK/4012/]) HBASE-7615 Add metrics for snapshots (Revision 1464441) Result = FAILURE mbertozzi : Files : * /hbase/trunk/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSource.java * /hbase/trunk/hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSourceImpl.java * /hbase/trunk/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSourceImpl.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetricsMaster.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/EnabledTableSnapshotHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java * /hbase/trunk/hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotManager.java Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch, HBASE-7615-v2.patch, HBASE-7615-v3.patch, HBASE-7615-v4.patch Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622081#comment-13622081 ] Hudson commented on HBASE-7615: --- Integrated in hbase-0.95 #123 (See [https://builds.apache.org/job/hbase-0.95/123/]) HBASE-7615 Add metrics for snapshots (Revision 1464443) Result = FAILURE mbertozzi : Files : * /hbase/branches/0.95/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSource.java * /hbase/branches/0.95/hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSourceImpl.java * /hbase/branches/0.95/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSourceImpl.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetricsMaster.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/EnabledTableSnapshotHandler.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java * /hbase/branches/0.95/hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotManager.java Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch, HBASE-7615-v2.patch, HBASE-7615-v3.patch, HBASE-7615-v4.patch Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622121#comment-13622121 ] Hudson commented on HBASE-7615: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #476 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/476/]) HBASE-7615 Add metrics for snapshots (Revision 1464441) Result = FAILURE mbertozzi : Files : * /hbase/trunk/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSource.java * /hbase/trunk/hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSourceImpl.java * /hbase/trunk/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSourceImpl.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetricsMaster.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/EnabledTableSnapshotHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java * /hbase/trunk/hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotManager.java Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch, HBASE-7615-v2.patch, HBASE-7615-v3.patch, HBASE-7615-v4.patch Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622174#comment-13622174 ] Hudson commented on HBASE-7615: --- Integrated in hbase-0.95-on-hadoop2 #54 (See [https://builds.apache.org/job/hbase-0.95-on-hadoop2/54/]) HBASE-7615 Add metrics for snapshots (Revision 1464443) Result = FAILURE mbertozzi : Files : * /hbase/branches/0.95/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSource.java * /hbase/branches/0.95/hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSourceImpl.java * /hbase/branches/0.95/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSourceImpl.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetricsMaster.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/EnabledTableSnapshotHandler.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java * /hbase/branches/0.95/hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotManager.java Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch, HBASE-7615-v2.patch, HBASE-7615-v3.patch, HBASE-7615-v4.patch Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620824#comment-13620824 ] Matteo Bertozzi commented on HBASE-7615: [~eclark] what do you suggest instead? I just want to keep track of min/max/avg time of snapshots... As far as I know, we don't have a way to store metrics like [snapshot: time] so at the moment just having an idea of how long on avg it takes taking a snapshot or restoring is a step forward. I've used the histogram because is the same used by the log splitting, that is quite similar to the snapshot workload... do you think that also the log split metrics doesn't make sense? Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch, HBASE-7615-v2.patch, HBASE-7615-v3.patch Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621165#comment-13621165 ] Elliott Clark commented on HBASE-7615: -- MetricMutableStat/MutableStat would have been what I used. On splits, yeah you are probably correct. I'll file a jira to change those. Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch, HBASE-7615-v2.patch, HBASE-7615-v3.patch Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[
https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621407#comment-13621407
]
Hadoop QA commented on HBASE-7615:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12576834/HBASE-7615.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5116//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5116//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5116//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5116//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5116//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5116//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5116//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5116//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5116//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5116//console
This message is automatically generated.
Add metrics for snapshots
-
Key: HBASE-7615
URL: https://issues.apache.org/jira/browse/HBASE-7615
Project: HBase
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Matteo Bertozzi
Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch,
HBASE-7615.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615-v0.patch,
HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch,
HBASE-7615-v2.patch, HBASE-7615-v3.patch, HBASE-7615-v4.patch
Metrics should be added for snapshot.
From Matteo: Output that we have in SnapshotInfo should be covered:
%d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source
table)
Jesse mentioned snaphot counts, average time to completion.
I think we should have counts for successful / failed snapshots.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621417#comment-13621417 ] Elliott Clark commented on HBASE-7615: -- +1 lgtm Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch, HBASE-7615-v2.patch, HBASE-7615-v3.patch, HBASE-7615-v4.patch Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619886#comment-13619886 ] Matteo Bertozzi commented on HBASE-7615: I'm planning to commit this one today, any other comments on the patch? Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch, HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch, HBASE-7615-v2.patch, HBASE-7615-v3.patch Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619897#comment-13619897 ] Ted Yu commented on HBASE-7615: --- There was no QA report. Mind attaching the patch one more time ? Thanks Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch, HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch, HBASE-7615-v2.patch, HBASE-7615-v3.patch Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620150#comment-13620150 ] Ted Yu commented on HBASE-7615: --- From https://builds.apache.org/job/PreCommit-HBASE-Build/5096/console , looks like compilation failed (on hadoop 2) Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch, HBASE-7615.patch, HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch, HBASE-7615-v2.patch, HBASE-7615-v3.patch Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[
https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620407#comment-13620407
]
Hadoop QA commented on HBASE-7615:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12576676/HBASE-7615.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestMasterFailover
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.master.TestMasterFailover.testMasterFailoverWithMockedRIT(TestMasterFailover.java:382)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5104//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5104//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5104//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5104//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5104//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5104//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5104//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5104//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5104//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5104//console
This message is automatically generated.
Add metrics for snapshots
-
Key: HBASE-7615
URL: https://issues.apache.org/jira/browse/HBASE-7615
Project: HBase
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Matteo Bertozzi
Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch,
HBASE-7615.patch, HBASE-7615.patch, HBASE-7615-v0.patch,
HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch,
HBASE-7615-v2.patch, HBASE-7615-v3.patch
Metrics should be added for snapshot.
From Matteo: Output that we have in SnapshotInfo should be covered:
%d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source
table)
Jesse mentioned snaphot counts, average time to completion.
I think we should have counts for successful / failed snapshots.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620596#comment-13620596 ] Elliott Clark commented on HBASE-7615: -- Why the histogram for snapshot time, clone time, and restore time? That comes with a pretty large overhead and I don't really understand what the user will gain by having the extra information of quantiles ? Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Attachments: HBASE-7615-0.94.patch, HBASE-7615-0.94-v1.patch, HBASE-7615.patch, HBASE-7615.patch, HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch, HBASE-7615-v2.patch, HBASE-7615-v3.patch Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[
https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617890#comment-13617890
]
Ted Yu commented on HBASE-7615:
---
nit:
{code}
+td%= stats.isSnapshotCorrupted() ? CORRUPTED : ok %/td
{code}
Consider showing the CORRUPTED text in a different color.
+1 on patch, if tests pass.
Add metrics for snapshots
-
Key: HBASE-7615
URL: https://issues.apache.org/jira/browse/HBASE-7615
Project: HBase
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Matteo Bertozzi
Attachments: HBASE-7615-0.94.patch, HBASE-7615-v0.patch,
HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png, HBASE-7615-v1.patch,
HBASE-7615-v2.patch
Metrics should be added for snapshot.
From Matteo: Output that we have in SnapshotInfo should be covered:
%d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source
table)
Jesse mentioned snaphot counts, average time to completion.
I think we should have counts for successful / failed snapshots.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[
https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615777#comment-13615777
]
Ted Yu commented on HBASE-7615:
---
Went through the patch which looks good.
{code}
+new CloneSnapshotHandler(master, snapshot, hTableDescriptor,
metricsMaster).prepare();
{code}
nit: both metricsMaster and this.metricsMaster are used. It would be nice to be
consistent.
Hadoop QA is down again - may need to run test suite manually or later.
Add metrics for snapshots
-
Key: HBASE-7615
URL: https://issues.apache.org/jira/browse/HBASE-7615
Project: HBase
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Matteo Bertozzi
Attachments: HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png,
HBASE-7615-v0-ui.png, HBASE-7615-v1.patch
Metrics should be added for snapshot.
From Matteo: Output that we have in SnapshotInfo should be covered:
%d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source
table)
Jesse mentioned snaphot counts, average time to completion.
I think we should have counts for successful / failed snapshots.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[
https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597227#comment-13597227
]
Ted Yu commented on HBASE-7615:
---
I thought stats would be surfaced through metrics2.
{code}
+ return ((float)hfileSize / (hfileSize + hfileArchiveSize)) * 100;
{code}
Do we need to check that hfileSize + hfileArchiveSize != 0 ?
Add metrics for snapshots
-
Key: HBASE-7615
URL: https://issues.apache.org/jira/browse/HBASE-7615
Project: HBase
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Matteo Bertozzi
Attachments: HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png,
HBASE-7615-v0-ui.png
Metrics should be added for snapshot.
From Matteo: Output that we have in SnapshotInfo should be covered:
%d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source
table)
Jesse mentioned snaphot counts, average time to completion.
I think we should have counts for successful / failed snapshots.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7615) Add metrics for snapshots
[ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597236#comment-13597236 ] Matteo Bertozzi commented on HBASE-7615: sure, the snapshot counters that Jesse mentioned should use metrics2 but this is something calculated from the disk, unless you're keeping a map of snapshot/stats in memory and you don't check every N second for the corrupted state, you can't obtain this info. Add metrics for snapshots - Key: HBASE-7615 URL: https://issues.apache.org/jira/browse/HBASE-7615 Project: HBase Issue Type: Sub-task Reporter: Ted Yu Assignee: Matteo Bertozzi Attachments: HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png Metrics should be added for snapshot. From Matteo: Output that we have in SnapshotInfo should be covered: %d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table) Jesse mentioned snaphot counts, average time to completion. I think we should have counts for successful / failed snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
