[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587434#comment-13587434 ] Sergey Shelukhin commented on HBASE-7638: - no objections > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.6 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586711#comment-13586711 ] Lars Hofhansl commented on HBASE-7638: -- Any objections if I marked this with "Won't fix" (for 0.94)? It's a corner case and the worst that can happen is that entry is removed from the cache when it shouldn't leading to another META lookup. > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.6 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570937#comment-13570937 ] Hudson commented on HBASE-7638: --- Integrated in HBase-0.94-security-on-Hadoop-23 #11 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/11/]) HBASE-7638 Revert, due to concerns of failing tests. (Revision 1437865) HBASE-7638 [0.94] region cache entry should only be removed on error if the error is from the server currently in cache (Sergey) (Revision 1437254) Result = FAILURE larsh : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java tedyu : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.6 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564558#comment-13564558 ] Sergey Shelukhin commented on HBASE-7638: - Presumably if we went to new RS in the first place, new RS should be in cache, so it will not happen? Otherwise, old RS will remain in cache until we update it from meta. > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.6 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564036#comment-13564036 ] Lars Hofhansl commented on HBASE-7638: -- What if the region has moved, the cache was not updated, and now the new RS returns an error? > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13563382#comment-13563382 ] Lars Hofhansl commented on HBASE-7638: -- Thanks for explaining. I don't know whether any test failures were caused by this, probably not. It's such a cornercase, though, that I we don't really need this. That said, if you think we should have this in 0.94 I'll reapply. > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13563319#comment-13563319 ] Sergey Shelukhin commented on HBASE-7638: - Is there consensus on whether this is the issue? > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561823#comment-13561823 ] Sergey Shelukhin commented on HBASE-7638: - The problems arises in multithreaded case (actually I only observed it in trunk, but I assumed this should also apply to 94). One thread gets A from cache and goes to A. Thread 2 does the same. Thread 1 errors out and updates the location from META to new correct location. Thread 2 errors out and removes it from cache. So it's not critical, just adds extra meta trips. In integration test where there are many threads and many errors it was relatively more prominent. I think it's made possible in no small part by using delayed callable, where we first build the request, including the destination server, then wait. > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561812#comment-13561812 ] Lars Hofhansl commented on HBASE-7638: -- [~sershe] I might be a bit slow here... Could you explain where this is a problem? We're removing regions from the cache by uniquely identified by their startKey, so if any server reports any problem with a region there is some problem with the region and it seems fine to remove it from the cache in that case. Is this a condition that happens when a region was moved? Or split? > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561746#comment-13561746 ] Lars Hofhansl commented on HBASE-7638: -- And both of them failed in Ubuntu2, which was known to have issues. (I added them back to the available machines just recently to see if that is still case) > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561742#comment-13561742 ] Lars Hofhansl commented on HBASE-7638: -- In both cases TestReplication and TestReplicationWithCompression did not finish. > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561704#comment-13561704 ] Hudson commented on HBASE-7638: --- Integrated in HBase-0.94-security #96 (See [https://builds.apache.org/job/HBase-0.94-security/96/]) HBASE-7638 Revert, due to concerns of failing tests. (Revision 1437865) HBASE-7638 [0.94] region cache entry should only be removed on error if the error is from the server currently in cache (Sergey) (Revision 1437254) Result = FAILURE larsh : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java tedyu : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561670#comment-13561670 ] Ted Yu commented on HBASE-7638: --- 0.94 builds #762 and #763 hung where the patch was reverted. I think there should be some other change(s) that caused the hang. > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561481#comment-13561481 ] Sergey Shelukhin commented on HBASE-7638: - 7268 should not affect 94 because the RegionMovedException stuff is not in 94... I will look at test failures tomorrow. > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561470#comment-13561470 ] Hudson commented on HBASE-7638: --- Integrated in HBase-0.94 #759 (See [https://builds.apache.org/job/HBase-0.94/759/]) HBASE-7638 Revert, due to concerns of failing tests. (Revision 1437865) Result = SUCCESS larsh : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561441#comment-13561441 ] Lars Hofhansl commented on HBASE-7638: -- With HBASE-7268 not fixed in 0.94. Is it possible to we now hold on to an old stale cache entry (produced as described in HBASE-7268), where before this patch we'd clean the cache (even if done too eagerly)? That would possibly explain why we see tests only fail sometimes (it would have to run into that scenario). I think I am going to revert this from 0.94 for now. The performance optimization from this should be slight (if any?) Please let me know if you disagree? > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561436#comment-13561436 ] Lars Hofhansl commented on HBASE-7638: -- Looked the patch again. It definitely looks right. > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561420#comment-13561420 ] Lars Hofhansl commented on HBASE-7638: -- Is there a chance that we keep an entry in the cache that should have been removed? > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[
https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561401#comment-13561401
]
Ted Yu commented on HBASE-7638:
---
Sergey and I looked at the patch.
There is no potential for NullPointerException similar to what HBASE-7268
addendum fixes.
See deleteCachedLocation():
{code}
if (oldLocation != null) {
isStaleDelete = (source != null) && !oldLocation.equals(source);
{code}
I also ran the tests that failed in recent 0.94 builds and they all passed:
1041 mt -Dtest=TestLruBlockCache,TestMiniClusterLoadParallel
1042 mt -Dtest=TestLruBlockCache
1043 mt -Dtest=TestCompactionState
1044 mt -Dtest=TestRSKilledWhenMasterInitializing
> [0.94] region cache entry should only be removed on error if the error is
> from the server currently in cache
>
>
> Key: HBASE-7638
> URL: https://issues.apache.org/jira/browse/HBASE-7638
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.94.4
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Minor
> Fix For: 0.94.5
>
> Attachments: HBASE-7638-v0.patch
>
>
> See HBASE-7268.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561365#comment-13561365 ] Lars Hofhansl commented on HBASE-7638: -- >From later test runs it looks like this change potentially destabilized some >of the tests. > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560379#comment-13560379 ] Hudson commented on HBASE-7638: --- Integrated in HBase-0.94 #753 (See [https://builds.apache.org/job/HBase-0.94/753/]) HBASE-7638 [0.94] region cache entry should only be removed on error if the error is from the server currently in cache (Sergey) (Revision 1437254) Result = SUCCESS tedyu : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560331#comment-13560331 ] Ted Yu commented on HBASE-7638: --- Integrated to 0.94 branch. Thanks for the patch, Sergey. Thanks for the review, Lars. > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560301#comment-13560301 ] Lars Hofhansl commented on HBASE-7638: -- +1 on this patch. > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560298#comment-13560298 ] Lars Hofhansl commented on HBASE-7638: -- Does this require HBASE-7268? > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[ https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560279#comment-13560279 ] Sergey Shelukhin commented on HBASE-7638: - [~lhofhansl] Any objections to putting this in 94? Thanks > [0.94] region cache entry should only be removed on error if the error is > from the server currently in cache > > > Key: HBASE-7638 > URL: https://issues.apache.org/jira/browse/HBASE-7638 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.4 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Minor > Fix For: 0.94.5 > > Attachments: HBASE-7638-v0.patch > > > See HBASE-7268. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7638) [0.94] region cache entry should only be removed on error if the error is from the server currently in cache
[
https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559344#comment-13559344
]
Hadoop QA commented on HBASE-7638:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12565899/HBASE-7638-v0.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4123//console
This message is automatically generated.
> [0.94] region cache entry should only be removed on error if the error is
> from the server currently in cache
>
>
> Key: HBASE-7638
> URL: https://issues.apache.org/jira/browse/HBASE-7638
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.94.4
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Minor
> Fix For: 0.94.5
>
> Attachments: HBASE-7638-v0.patch
>
>
> See HBASE-7268.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
