[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13612849#comment-13612849 ] stack commented on HBASE-8035: -- [~ted_yu] Thank you for the useless echo of publicly available knowledge made above. Adding the -N made site plugin pass for a while. HBASE-8186 Untether javadoc and site build removed the -N since it a band-aid and the thought was that javadoc aggregate target was what was causing our need of -N (Builds were working for me w/o the -N locally after I was able to reproduce the original site fail). Site precheck is now failing again in a manner simmilar to the original but on hbase-common mondule rather than in hbase-server. I'm working on our build/packaging in general and will try address this issue as part of it all. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum-remove-clean.txt, 8035-addendum.txt, 8035-addendum.txt, addendum_adds_-N.txt, addendum.out We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13612136#comment-13612136 ] Ted Yu commented on HBASE-8035: --- Site target check is still red in QA report. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum-remove-clean.txt, 8035-addendum.txt, 8035-addendum.txt, addendum_adds_-N.txt, addendum.out We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606779#comment-13606779 ] stack commented on HBASE-8035: -- Committed addendum. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum-remove-clean.txt, 8035-addendum.txt, 8035-addendum.txt, addendum.out We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606938#comment-13606938 ] stack commented on HBASE-8035: -- Committed. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum-remove-clean.txt, 8035-addendum.txt, 8035-addendum.txt, addendum_adds_-N.txt, addendum.out We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606990#comment-13606990 ] Hudson commented on HBASE-8035: --- Integrated in HBase-TRUNK #3974 (See [https://builds.apache.org/job/HBase-TRUNK/3974/]) HBASE-8035 Add site target check to precommit tests -- ADDENDUM (Revision 1458507) Result = FAILURE stack : Files : * /hbase/trunk/dev-support/test-patch.sh Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum-remove-clean.txt, 8035-addendum.txt, 8035-addendum.txt, addendum_adds_-N.txt, addendum.out We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607146#comment-13607146 ] Hudson commented on HBASE-8035: --- Integrated in HBase-TRUNK #3975 (See [https://builds.apache.org/job/HBase-TRUNK/3975/]) HBASE-8035 Add site target check to precommit tests; ANOTHER ADDENDUM (Revision 1458547) Result = FAILURE stack : Files : * /hbase/trunk/dev-support/test-patch.sh Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum-remove-clean.txt, 8035-addendum.txt, 8035-addendum.txt, addendum_adds_-N.txt, addendum.out We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607236#comment-13607236 ] Hudson commented on HBASE-8035: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #455 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/455/]) HBASE-8035 Add site target check to precommit tests; ANOTHER ADDENDUM (Revision 1458547) HBASE-8035 Add site target check to precommit tests -- ADDENDUM (Revision 1458507) Result = FAILURE stack : Files : * /hbase/trunk/dev-support/test-patch.sh stack : Files : * /hbase/trunk/dev-support/test-patch.sh Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum-remove-clean.txt, 8035-addendum.txt, 8035-addendum.txt, addendum_adds_-N.txt, addendum.out We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601365#comment-13601365 ] Ted Yu commented on HBASE-8035: --- So, which addendum should we use ? Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt, 8035-addendum.txt, addendum.out We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599100#comment-13599100 ] Nick Dimiduk commented on HBASE-8035: - It looks like we could have the pre-patch script instead call xml:validate: http://mojo.codehaus.org/xml-maven-plugin/validate-mojo.html Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599119#comment-13599119 ] stack commented on HBASE-8035: -- bq. I believe compile goal is necessary because site implies javadoc, and docbook depends on resources copied into target by compile... You are right. Site runs javadoc but it will be missing the above (unless we make sure they are included by they copy-resources plugin triggered by pre-site). Not important though. Can we close this issue then; the patch has been applied? Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599129#comment-13599129 ] Nick Dimiduk commented on HBASE-8035: - Looks like the addendum has not been applied. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599146#comment-13599146 ] stack commented on HBASE-8035: -- I think the addendum is useless doing nothing but using up more space on jenkins. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599158#comment-13599158 ] Ted Yu commented on HBASE-8035: --- Looking through recent QA reports, site check all failed. We should do something before closing this issue. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599184#comment-13599184 ] stack commented on HBASE-8035: -- For sure would be good to know why site failed. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599186#comment-13599186 ] Nick Dimiduk commented on HBASE-8035: - https://builds.apache.org/job/PreCommit-HBASE-Build/4758//artifact/trunk/patchprocess/patchSiteOutput.txt With the existing `clean compile site -DskipTests`, site didn't fail, the subsequent module builds do, which goes back to the compile vs package business. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599190#comment-13599190 ] stack commented on HBASE-8035: -- I run it locally and the exit code is 0 Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599192#comment-13599192 ] stack commented on HBASE-8035: -- [~ndimiduk] Sorry, your script has `clean compile site -DskipTests` in it... how do we get to the 'compile vs package business'? (I missed that there is a siteOutput nice) Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[
https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599194#comment-13599194
]
Nick Dimiduk commented on HBASE-8035:
-
This appears to work. `mvn -N clean site -DskipTests` builds the docbook
locally for me, and skips the walk through submodules. It complains loudly when
I first `rm -r ~/.m2/repository/org/apache/hbase/hbase*/0.97-SNAPSHOT` but
doesn't fail the build. The build succeeds and just creates docbook.
{noformat}
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 43.186s
{noformat}
Add site target check to precommit tests
Key: HBASE-8035
URL: https://issues.apache.org/jira/browse/HBASE-8035
Project: HBase
Issue Type: Task
Reporter: Andrew Purtell
Assignee: Nick Dimiduk
Fix For: 0.98.0
Attachments:
0001-HBASE-8035-Add-site-generation-to-patch-validation.patch,
8035-addendum.txt
We should check that the Maven 'site' target passes as part of precommit
testing. See HBASE-8022.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599242#comment-13599242 ] Nick Dimiduk commented on HBASE-8035: - When run w/o a compile or package included in the command, maven will attempt to resolve build artifacts from external repositories. This happens after the docbook step completes; I don't know why. It can't find 0.97-SNAPSHOT anything, but it doesn't result in an error when run with -N. See also [~yuzhih...@gmail.com]'s comments about compile/package. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599263#comment-13599263 ] stack commented on HBASE-8035: -- Makes sense I suppose. So, I think the addendum good since it checks our site target only which I think is what we want since elsewhere the other stuff (compile, unit tests) are checked. The site will run javadoc target. We are doing it twice now then? Once to look for javadoc warnings and again here when we do site build? Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599276#comment-13599276 ] stack commented on HBASE-8035: -- If I do this: MAVEN_OPTS= -Xmx3g mvn -DskipTests site -U It works for me. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597891#comment-13597891 ] Andrew Purtell commented on HBASE-8035: --- Take Maven out back and shoot. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597556#comment-13597556 ] stack commented on HBASE-8035: -- Oh, my issues was hidden because we have been failing tests in 0.95 and trunk so long... only now does it come to light now tests are starting to pass again. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597767#comment-13597767 ] Hudson commented on HBASE-8035: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #437 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/437/]) HBASE-8035 Add site target check to precommit tests (Revision 1454548) Result = FAILURE stack : Files : * /hbase/trunk/dev-support/test-patch.sh Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597785#comment-13597785 ] Nick Dimiduk commented on HBASE-8035: - Yeah, the compile step probably works for me because I've run `mvn packge install` on trunk. +1 for Ted's addendum. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597808#comment-13597808 ] stack commented on HBASE-8035: -- What is up on jenkins is kinda useless... it builds an assembly and then after builds the site (so assembly does not contain doc. its of no use). I am currently trying to fix it but putting 'site' anywhere but on the end breaks the build. The addendum builds an assembly which is a pretty useless exercise I'd say... in a hadoopqa patch test. We just want to see if patch breaks doc building... Looking at original patch again, we don't need the compile goal in there.. but its fine with it. Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8035) Add site target check to precommit tests
[ https://issues.apache.org/jira/browse/HBASE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597814#comment-13597814 ] Nick Dimiduk commented on HBASE-8035: - I believe compile goal is necessary because site implies javadoc, and docbook depends on resources copied into target by compile... Add site target check to precommit tests Key: HBASE-8035 URL: https://issues.apache.org/jira/browse/HBASE-8035 Project: HBase Issue Type: Task Reporter: Andrew Purtell Assignee: Nick Dimiduk Fix For: 0.98.0 Attachments: 0001-HBASE-8035-Add-site-generation-to-patch-validation.patch, 8035-addendum.txt We should check that the Maven 'site' target passes as part of precommit testing. See HBASE-8022. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
