[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964403#comment-15964403 ] Chia-Ping Tsai commented on HBASE-8220: --- HTablePool had been removed in 0.98.1. Shall we close this issue? > can we record the count opened HTable for HTablePool > > > Key: HBASE-8220 > URL: https://issues.apache.org/jira/browse/HBASE-8220 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Jianwei Cui > Attachments: 8220-trunk-v1.txt, 8220-trunk-v2.txt, > 8220-trunk-v3-reattached.txt, 8220-trunk-v3.txt, 8220-trunk-v4.txt, > HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, > HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, > HBASE-8220-0.94.3-v5.txt > > > In HTablePool, we have a method getCurrentPoolSize(...) to get how many > opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable > which means the count of HTable get from HTablePool.getTable(...) and don't > return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may > be meaningful because it indicates how many HTables should be opened for the > application which may help us set the appropriate MaxSize of HTablePool. > Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726383#comment-13726383 ] Jean-Marc Spaggiari commented on HBASE-8220: [~cuijianwei] can you rebase your patch on last trunk version? Then we will see if anyone can commit it? can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Assignee: cuijianwei Attachments: 8220-trunk-v1.txt, 8220-trunk-v2.txt, 8220-trunk-v3-reattached.txt, 8220-trunk-v3.txt, 8220-trunk-v4.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13644633#comment-13644633 ] Nick Dimiduk commented on HBASE-8220: - [~cuijianwei] committing to trunk is out of my hands. Yes, to apply a change to 0.94, it will need backported via a new patch. It's customary to ask the release manager if they'll accept the backport. If discussion is required, that generally happens on a new JIRA (ping [~lhofhansl]). can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Assignee: cuijianwei Attachments: 8220-trunk-v1.txt, 8220-trunk-v2.txt, 8220-trunk-v3-reattached.txt, 8220-trunk-v3.txt, 8220-trunk-v4.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643434#comment-13643434 ] cuijianwei commented on HBASE-8220: --- Thanks for your review, can we merge this patch to trunk? If we want to use this in 0.94, will we provide another patch for 0.94? can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Assignee: cuijianwei Attachments: 8220-trunk-v1.txt, 8220-trunk-v2.txt, 8220-trunk-v3-reattached.txt, 8220-trunk-v3.txt, 8220-trunk-v4.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13641257#comment-13641257 ] Jean-Marc Spaggiari commented on HBASE-8220: +1 from me too. can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Assignee: cuijianwei Attachments: 8220-trunk-v1.txt, 8220-trunk-v2.txt, 8220-trunk-v3-reattached.txt, 8220-trunk-v3.txt, 8220-trunk-v4.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638877#comment-13638877
]
Hadoop QA commented on HBASE-8220:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12579987/8220-trunk-v3-reattached.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5395//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5395//console
This message is automatically generated.
can we record the count opened HTable for HTablePool
Key: HBASE-8220
URL: https://issues.apache.org/jira/browse/HBASE-8220
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: cuijianwei
Assignee: cuijianwei
Attachments: 8220-trunk-v1.txt, 8220-trunk-v2.txt,
8220-trunk-v3-reattached.txt, 8220-trunk-v3.txt, HBASE-8220-0.94.3.txt,
HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt,
HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt
In HTablePool, we have a method getCurrentPoolSize(...) to get how many
opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable
which means the count of HTable get from HTablePool.getTable(...) and don't
return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may
be meaningful because it indicates how many HTables should be opened for the
application which may help us set the appropriate MaxSize of HTablePool.
Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13639980#comment-13639980 ] cuijianwei commented on HBASE-8220: --- Thanks for your review, I update the patch to remove whitespace. can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Assignee: cuijianwei Attachments: 8220-trunk-v1.txt, 8220-trunk-v2.txt, 8220-trunk-v3-reattached.txt, 8220-trunk-v3.txt, 8220-trunk-v4.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13640037#comment-13640037
]
Hadoop QA commented on HBASE-8220:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12580213/8220-trunk-v4.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5425//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5425//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5425//console
This message is automatically generated.
can we record the count opened HTable for HTablePool
Key: HBASE-8220
URL: https://issues.apache.org/jira/browse/HBASE-8220
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: cuijianwei
Assignee: cuijianwei
Attachments: 8220-trunk-v1.txt, 8220-trunk-v2.txt,
8220-trunk-v3-reattached.txt, 8220-trunk-v3.txt, 8220-trunk-v4.txt,
HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2,
HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt,
HBASE-8220-0.94.3-v5.txt
In HTablePool, we have a method getCurrentPoolSize(...) to get how many
opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable
which means the count of HTable get from HTablePool.getTable(...) and don't
return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may
be meaningful because it indicates how many HTables should be opened for the
application which may help us set the appropriate MaxSize of HTablePool.
Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13640106#comment-13640106 ] Nick Dimiduk commented on HBASE-8220: - +1 for 8220-trunk-v4.txt. can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Assignee: cuijianwei Attachments: 8220-trunk-v1.txt, 8220-trunk-v2.txt, 8220-trunk-v3-reattached.txt, 8220-trunk-v3.txt, 8220-trunk-v4.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638443#comment-13638443 ] Nick Dimiduk commented on HBASE-8220: - Thanks for adding the test. Instead of adding the method to both subclasses, can you add it to only the base class? can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Assignee: cuijianwei Attachments: 8220-trunk-v1.txt, 8220-trunk-v2.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638757#comment-13638757 ] cuijianwei commented on HBASE-8220: --- Thanks for your review, I have moved the unit test to base class in new patch. can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Assignee: cuijianwei Attachments: 8220-trunk-v1.txt, 8220-trunk-v2.txt, 8220-trunk-v3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638788#comment-13638788
]
Hadoop QA commented on HBASE-8220:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12579969/8220-trunk-v3.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.access.TestAccessController
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5392//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5392//console
This message is automatically generated.
can we record the count opened HTable for HTablePool
Key: HBASE-8220
URL: https://issues.apache.org/jira/browse/HBASE-8220
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: cuijianwei
Assignee: cuijianwei
Attachments: 8220-trunk-v1.txt, 8220-trunk-v2.txt, 8220-trunk-v3.txt,
HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2,
HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt,
HBASE-8220-0.94.3-v5.txt
In HTablePool, we have a method getCurrentPoolSize(...) to get how many
opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable
which means the count of HTable get from HTablePool.getTable(...) and don't
return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may
be meaningful because it indicates how many HTables should be opened for the
application which may help us set the appropriate MaxSize of HTablePool.
Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637775#comment-13637775
]
Hadoop QA commented on HBASE-8220:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12579776/8220-trunk-v2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5377//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5377//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5377//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5377//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5377//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5377//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5377//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5377//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5377//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5377//console
This message is automatically generated.
can we record the count opened HTable for HTablePool
Key: HBASE-8220
URL: https://issues.apache.org/jira/browse/HBASE-8220
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: cuijianwei
Assignee: cuijianwei
Attachments: 8220-trunk-v1.txt, 8220-trunk-v2.txt,
HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2,
HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt,
HBASE-8220-0.94.3-v5.txt
In HTablePool, we have a method getCurrentPoolSize(...) to get how many
opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable
which means the count of HTable get from HTablePool.getTable(...) and don't
return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may
be meaningful because it indicates how many HTables should be opened for the
application which may help us set the appropriate MaxSize of HTablePool.
Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637171#comment-13637171 ] cuijianwei commented on HBASE-8220: --- Thanks for your comments. Sorry for response late. I generate a patch of this issue under trunk. However, the corresponding unit test 'TestHTablePool.java' has not been included in trunk. I try to copy 'TestHTablePool.java' from 0.94 to trunk; however it depends on other classes which will break build. Could we merge this patch into trunk firstly? Then, after we merge this patch into 0.94, we can merge corresponding update of 'TestHTablePool.java' to 0.94. can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Assignee: cuijianwei Attachments: 8220-trunk-v1.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637202#comment-13637202
]
Hadoop QA commented on HBASE-8220:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12579670/8220-trunk-v1.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5372//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5372//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5372//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5372//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5372//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5372//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5372//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5372//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5372//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5372//console
This message is automatically generated.
can we record the count opened HTable for HTablePool
Key: HBASE-8220
URL: https://issues.apache.org/jira/browse/HBASE-8220
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: cuijianwei
Assignee: cuijianwei
Attachments: 8220-trunk-v1.txt, HBASE-8220-0.94.3.txt,
HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt,
HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt
In HTablePool, we have a method getCurrentPoolSize(...) to get how many
opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable
which means the count of HTable get from HTablePool.getTable(...) and don't
return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may
be meaningful because it indicates how many HTables should be opened for the
application which may help us set the appropriate MaxSize of HTablePool.
Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631707#comment-13631707 ] cuijianwei commented on HBASE-8220: --- Thanks very much for your concern and review. Maybe we can merge the patch to 0.94.6? By the way, could you please recommend a committer who is interested in HTablePool so that we can invite him/her to have a look? can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632276#comment-13632276
]
Hadoop QA commented on HBASE-8220:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12578345/HBASE-8220-0.94.3-v5.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5318//console
This message is automatically generated.
can we record the count opened HTable for HTablePool
Key: HBASE-8220
URL: https://issues.apache.org/jira/browse/HBASE-8220
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: cuijianwei
Assignee: cuijianwei
Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt,
HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt,
HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt
In HTablePool, we have a method getCurrentPoolSize(...) to get how many
opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable
which means the count of HTable get from HTablePool.getTable(...) and don't
return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may
be meaningful because it indicates how many HTables should be opened for the
application which may help us set the appropriate MaxSize of HTablePool.
Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632282#comment-13632282 ] Jean-Marc Spaggiari commented on HBASE-8220: The patch is for 0.94. So I don't think HadoopQA can handle it. can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Assignee: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632292#comment-13632292 ] Nick Dimiduk commented on HBASE-8220: - Oh bother, that's right. [~jmspaggi] HTablePool is still on trunk. Do you have a link to the discussion around removing it? [~lhofhansl] what are your thoughts on bringing this into 0.94? can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Assignee: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632371#comment-13632371 ] Lars Hofhansl commented on HBASE-8220: -- 0.94 is OK, but 0.94.8 at this point. can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Assignee: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632378#comment-13632378 ] Jean-Marc Spaggiari commented on HBASE-8220: [~ndimiduk] I'm refering to this discussion: http://mail-archives.apache.org/mod_mbox/hbase-dev/201303.mbox/%3CCALte62yPR0vmQQm7O_48SKQiecX_=bE7=vjvpyl+3uzqge7...@mail.gmail.com%3E But I can't confirm if it's going to be deprecated. Today in trunk it's not deprecated. So should we do a the same patch for the trunk until we clearify if it's deprecated or not? can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Assignee: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632404#comment-13632404 ] Nick Dimiduk commented on HBASE-8220: - Yes, let's get a patch for trunk here as well. The general guideline is to do new development against trunk first and back-port on a case-by-case basis. In that regard, this work is a little backwards. can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Assignee: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630024#comment-13630024
]
Jean-Marc Spaggiari commented on HBASE-8220:
Passed locally for me too:
{code}
---
T E S T S
---
Running org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.816 sec
Running org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 108.551 sec
Results :
Tests run: 18, Failures: 0, Errors: 0, Skipped: 0
{code}
+1
Don't forget that HTablePool is gone for 0.95 and above. So this patch will be
for temporary use only. Now you will need a commiter to take a look at it and
apply it in 0.94.x.
can we record the count opened HTable for HTablePool
Key: HBASE-8220
URL: https://issues.apache.org/jira/browse/HBASE-8220
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: cuijianwei
Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt,
HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt,
HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt
In HTablePool, we have a method getCurrentPoolSize(...) to get how many
opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable
which means the count of HTable get from HTablePool.getTable(...) and don't
return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may
be meaningful because it indicates how many HTables should be opened for the
application which may help us set the appropriate MaxSize of HTablePool.
Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628751#comment-13628751 ] cuijianwei commented on HBASE-8220: --- [~Jean-Marc Spaggiari] doest the newest patch test successfully on your side? thanks. can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628875#comment-13628875 ] Jean-Marc Spaggiari commented on HBASE-8220: Let me retry. I will let you know. Also, any chance to add a test to check that returned value is as expected? can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628962#comment-13628962
]
Jean-Marc Spaggiari commented on HBASE-8220:
{code}
Tests in error:
testBasicRollingRestart(org.apache.hadoop.hbase.master.TestRollingRestart):
test timed out after 30 milliseconds
Tests run: 1335, Failures: 0, Errors: 1, Skipped: 13
{code}
I retried the failed test and it passed:
{code}
---
T E S T S
---
Running org.apache.hadoop.hbase.master.TestRollingRestart
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 186.049 sec
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
{code}
So it seems to be good. +1 for me, even better if you can add a test.
can we record the count opened HTable for HTablePool
Key: HBASE-8220
URL: https://issues.apache.org/jira/browse/HBASE-8220
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: cuijianwei
Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt,
HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt,
HBASE-8220-0.94.3-v4.txt
In HTablePool, we have a method getCurrentPoolSize(...) to get how many
opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable
which means the count of HTable get from HTablePool.getTable(...) and don't
return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may
be meaningful because it indicates how many HTables should be opened for the
application which may help us set the appropriate MaxSize of HTablePool.
Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629725#comment-13629725 ] cuijianwei commented on HBASE-8220: --- [~Jean-Marc Spaggiari], thanks for your concern, I add corresponding unit tests for 'ConcurrentUsedTable' and the unit tests passed locally, could you please apply the patch 'HBASE-8220-0.94.3-v5.txt' and test it on your side? can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621144#comment-13621144 ] cuijianwei commented on HBASE-8220: --- Thanks for your comment. I make a new patch to fix the bug, however, it's a little slow to compile the project, I will run the test locally and given the test result. can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621152#comment-13621152 ] cuijianwei commented on HBASE-8220: --- I have run TestHTablePool.java, all uts in TestHTabelPool have passed locally with HBASE-8220-0.94.3-v4.txt. Could please help to make sure HBASE-8220-0.94.3-v4.txt is OK? can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619731#comment-13619731 ] Jean-Marc Spaggiari commented on HBASE-8220: I will run the 0.94 test suite locally with your patch and post the results here. You can keep .patch, or .txt. No issues. Any chance to add some test scenarios to validate that number of tables is following as expected? can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619783#comment-13619783 ] Jean-Marc Spaggiari commented on HBASE-8220: Many tests failed... I'm not concerned by most of them, but the 2 TestHTablePool tests are more concerning me. I will try to re-run them separatly. Tests in error: testDeleteAllTimestamps(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler) testDeleteSingleTimestamp(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler) testIncrement(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler) testCheckAndPut(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler) testCheckAndDelete(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler) testScan(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler) testMetrics(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler) testExists(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler) testPutGet(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler) testPutGetMultiple(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler) testDeleteMultiple(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler) testDelete(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler) testGetTableDescriptor(org.apache.hadoop.hbase.rest.client.TestRemoteTable): schema request returned 500 testGet(org.apache.hadoop.hbase.rest.client.TestRemoteTable): get request returned 400 testMultiGet(org.apache.hadoop.hbase.rest.client.TestRemoteTable): get request returned 500 testPut(org.apache.hadoop.hbase.rest.client.TestRemoteTable): put request failed with 500 testTableWithMaxSize(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool) testCloseTablePool(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool) testTableWithStringName(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool) testTableWithByteArrayName(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool) testTablesWithDifferentNames(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool) testDeprecatedUsagePattern(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool) testTableWithMaxSize(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool) testCloseTablePool(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool) testTableWithStringName(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool) testTableWithByteArrayName(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool) testTablesWithDifferentNames(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool) testDeprecatedUsagePattern(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool) testDML(org.apache.hadoop.hbase.avro.TestAvroServer) testFamilyAdminAndMetadata(org.apache.hadoop.hbase.avro.TestAvroServer) Tests run: 1332, Failures: 34, Errors: 30, Skipped: 13 can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619919#comment-13619919
]
Jean-Marc Spaggiari commented on HBASE-8220:
Tests are failing with NP on line 284:
{code}
concurrentUsedTableCounts.get(table).decrementAndGet();
{code}
Have you tried your patch locally? Is it working for you?
can we record the count opened HTable for HTablePool
Key: HBASE-8220
URL: https://issues.apache.org/jira/browse/HBASE-8220
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: cuijianwei
Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt,
HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt
In HTablePool, we have a method getCurrentPoolSize(...) to get how many
opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable
which means the count of HTable get from HTablePool.getTable(...) and don't
return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may
be meaningful because it indicates how many HTables should be opened for the
application which may help us set the appropriate MaxSize of HTablePool.
Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619932#comment-13619932
]
Jean-Marc Spaggiari commented on HBASE-8220:
Should it be replaced by
{code}
concurrentUsedTableCounts.get(tableName).decrementAndGet();
{code}
?
can we record the count opened HTable for HTablePool
Key: HBASE-8220
URL: https://issues.apache.org/jira/browse/HBASE-8220
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: cuijianwei
Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt,
HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt
In HTablePool, we have a method getCurrentPoolSize(...) to get how many
opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable
which means the count of HTable get from HTablePool.getTable(...) and don't
return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may
be meaningful because it indicates how many HTables should be opened for the
application which may help us set the appropriate MaxSize of HTablePool.
Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619935#comment-13619935
]
cuijianwei commented on HBASE-8220:
---
I'am sorry that I don't run the unit tests locally. Yes, it should be
{code}concurrentUsedTableCounts.get(tableName).decrementAndGet();{code}.
can we record the count opened HTable for HTablePool
Key: HBASE-8220
URL: https://issues.apache.org/jira/browse/HBASE-8220
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: cuijianwei
Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt,
HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt
In HTablePool, we have a method getCurrentPoolSize(...) to get how many
opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable
which means the count of HTable get from HTablePool.getTable(...) and don't
return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may
be meaningful because it indicates how many HTables should be opened for the
application which may help us set the appropriate MaxSize of HTablePool.
Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620002#comment-13620002
]
Nick Dimiduk commented on HBASE-8220:
-
You're developing against 0.94 branch, yes? You can run test locally according
to the instructions in [the
book|http://hbase.apache.org/0.94/book.html#hbase.tests]. At the very least,
before submitting a patch, I run
{noformat}
$ mvn clean package test -PrunSmallTests
{noformat}
You can also run specific tests with
{noformat}
$ mvn clean package test -Dtest=MyFavoriteTest
{noformat}
can we record the count opened HTable for HTablePool
Key: HBASE-8220
URL: https://issues.apache.org/jira/browse/HBASE-8220
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: cuijianwei
Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt,
HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt
In HTablePool, we have a method getCurrentPoolSize(...) to get how many
opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable
which means the count of HTable get from HTablePool.getTable(...) and don't
return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may
be meaningful because it indicates how many HTables should be opened for the
application which may help us set the appropriate MaxSize of HTablePool.
Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620187#comment-13620187 ] Jean-Marc Spaggiari commented on HBASE-8220: [~cuijianwei] can you attached an updated version? I was able to run the tests successfuly with the updated code, but can you please run them too to make sure? can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618699#comment-13618699 ] cuijianwei commented on HBASE-8220: --- Thanks for your comment, I add a new patch which including: commont#1 fixed comment#2 fixed comment#3 add more specific comment at the place we call 'decrementAndGet' comment#4 fixed comment#5 the path is made over 0.94 branch I'm sorry that I don't construct a test suite environment, do we have common platform to run the test suite? can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618278#comment-13618278 ] cuijianwei commented on HBASE-8220: --- ok, I make a path for this issue, could you please help to review? can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Attachments: HBASE-8220-0.94.3.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618310#comment-13618310
]
Jean-Marc Spaggiari commented on HBASE-8220:
Sound good to me.
Few comments.
- Remove the extra space at the end of this.concurrentUsingTableCounts = new
ConcurrentHashMapString, AtomicInteger();
- Remove the extra space at the end of +if ((previousCount =
concurrentUsingTableCounts.putIfAbsent(tableName, initCount)) == null) {
- In returnTable, I'm not sure we should reduce the counter after
releaseHTableInterface and not before. The table you are removing will already
be removed from the tables field even if releaseHTableInterface fails. I
think we should keep the 2 in sync and therefore make sure decrementAndGet is
called before releaseHTableInterface. Might need to have a 2nd opinion on that.
- concurrentUsingTableCounts field (and subsequent methods) might be renamed
concurrentUsedTableCounts or something similar (concurrentTableCount, etc.)
- Make sure the patch is build over the 0.94 branch and not a specific 0.94.x
tag.
Have you run the test suite locally? Does it pass?
can we record the count opened HTable for HTablePool
Key: HBASE-8220
URL: https://issues.apache.org/jira/browse/HBASE-8220
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: cuijianwei
Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt
In HTablePool, we have a method getCurrentPoolSize(...) to get how many
opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable
which means the count of HTable get from HTablePool.getTable(...) and don't
return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may
be meaningful because it indicates how many HTables should be opened for the
application which may help us set the appropriate MaxSize of HTablePool.
Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618344#comment-13618344 ] cuijianwei commented on HBASE-8220: --- Thanks for your review. Comments#3 looks a little complex. As you describe, if we put decrementAndGet after releaseHTableInterface, the HTable has been removed from HTable.tables while concurrentUsingTableCounts won't decrease if releaseHTableInterface throws an exception. On the other hand, if we put decrementAndGet before releaseHTableInterface, we may depend on what the users do when they getting an IOException from PoolTable.close(...). For example, if the users retries some times after this exception, concurrentUsingTableCounts will decrease many times. From this aspect, it may be a little better to put decrementAndGet after releaseHTableInterface. If HTable close fail, users should handle the exception, decide to retry until success(concurrentUsingTableCounts will decrease once eventually) or tolerate a close-fail HTable in their program(The HTable seems 'Using' by user from the view of HTablePool in this situation). On the other hand, removing the HTable from HTablePool.tables many times may not bring negative affect. can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618424#comment-13618424 ] Jean-Marc Spaggiari commented on HBASE-8220: I see your point. Both options are fine for me as long as we understand what's going on. can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: cuijianwei Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
[ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617266#comment-13617266 ] Jean-Marc Spaggiari commented on HBASE-8220: I don't se any issue with adding that. Are you going to provide a patch? can we record the count opened HTable for HTablePool Key: HBASE-8220 URL: https://issues.apache.org/jira/browse/HBASE-8220 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Environment: In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened for the application which may help us set the appropriate MaxSize of HTablePool. Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool. Reporter: cuijianwei -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
