[jira] [Commented] (HIVE-22334) There is a permission problem with the add jar package on the command line
[ https://issues.apache.org/jira/browse/HIVE-22334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955380#comment-16955380 ] fanshilun commented on HIVE-22334: -- look at /tmp/$userName/hive.log for error detail， in hive-site.xml ， this property (change org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactory) hive.security.authorization.manager org.apache.hadoop.hive.ql.security.authorization.DefaultHiveAuthorizationProvider > There is a permission problem with the add jar package on the command line > -- > > Key: HIVE-22334 > URL: https://issues.apache.org/jira/browse/HIVE-22334 > Project: Hive > Issue Type: Bug > Environment: hive 3.1 >Reporter: jiazhaoquan >Priority: Blocker > Attachments: 启动失败文档.jpg > > > The environment is ve3.0;Now add a jar package has the problem of removing > permissions, as follows; > >add jar > >/export/servers/hive-connector-0.9.0-SNAPSHOT-jar-with-dependencies.jar; > >Error: Error while processing statement: Permission denied: Principal > >[name=root, type=USER] does not have following privileges for operation ADD > >[ADMIN] (state=,code=1)` > > I have used Storage Based Authorization in the Metastore Server according to > the configuration;But the add jar package still has permissions issues;Put my > jar package into the lib file, and my hive started until it finally appeared > (closed on the command line).The problem log is in the attachment. > > 环境是hive3.0；现在add一个jar包出现去权限问题，如下； > >add jar > >/export/servers/hive-connector-0.9.0-SNAPSHOT-jar-with-dependencies.jar; > >Error: Error while processing statement: Permission denied: Principal > >[name=root, type=USER] does not have following privileges for operation ADD > >[ADMIN] (state=,code=1)` > 我已经根据配置使用了Storage Based Authorization in the Metastore Server；但是add > jar包还是有权限问题；将我的jar包放入lib文件，我的hive启动到最后出现（命令行出现closed），启动不了hive；问题在附件中； -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22274) Upgrade Calcite version to 1.21.0
[
https://issues.apache.org/jira/browse/HIVE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955379#comment-16955379
]
Hive QA commented on HIVE-22274:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983539/HIVE-22274.15.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17545 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19076/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19076/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19076/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983539 - PreCommit-HIVE-Build
> Upgrade Calcite version to 1.21.0
> -
>
> Key: HIVE-22274
> URL: https://issues.apache.org/jira/browse/HIVE-22274
> Project: Hive
> Issue Type: Task
>Affects Versions: 3.1.2
>Reporter: Steve Carlin
>Assignee: Steve Carlin
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22274.1.patch, HIVE-22274.10.patch,
> HIVE-22274.10.patch, HIVE-22274.11.patch, HIVE-22274.12.patch,
> HIVE-22274.13.patch, HIVE-22274.15.patch, HIVE-22274.2.patch,
> HIVE-22274.3.patch, HIVE-22274.4.patch, HIVE-22274.5.patch,
> HIVE-22274.6.patch, HIVE-22274.7.patch, HIVE-22274.8.patch,
> HIVE-22274.9.patch, HIVE-22274.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22274) Upgrade Calcite version to 1.21.0
[
https://issues.apache.org/jira/browse/HIVE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955378#comment-16955378
]
Hive QA commented on HIVE-22274:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
6s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
32s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
7s{color} | {color:blue} ql in master has 1547 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
32s{color} | {color:blue} accumulo-handler in master has 21 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
33s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
42s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
52s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m
8s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
44s{color} | {color:red} ql: The patch generated 36 new + 334 unchanged - 12
fixed = 370 total (was 346) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
5s{color} | {color:red} root: The patch generated 37 new + 386 unchanged - 12
fixed = 423 total (was 398) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
19s{color} | {color:red} itests/hive-unit: The patch generated 1 new + 52
unchanged - 0 fixed = 53 total (was 52) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 5 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
16s{color} | {color:red} ql generated 9 new + 1544 unchanged - 3 fixed = 1553
total (was 1547) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m
4s{color} | {color:red} ql generated 4 new + 96 unchanged - 4 fixed = 100 total
(was 100) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 6m
54s{color} | {color:red} root generated 4 new + 333 unchanged - 4 fixed = 337
total (was 337) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 77m 29s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Dead store to joinInfo in
org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, Set, JoinRelType, boolean) At
HiveRelFactories.java:org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, Set, JoinRelType, boolean) At HiveRelFactories.java:[line
170] |
| | Dead store to joinInfo in
org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, JoinRelType, Set, boolean) At
HiveRelFactories.java:
[jira] [Resolved] (HIVE-22372) Hive MetaStore
[ https://issues.apache.org/jira/browse/HIVE-22372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fanshilun resolved HIVE-22372. -- Fix Version/s: 2.3.7 Resolution: Fixed > Hive MetaStore > -- > > Key: HIVE-22372 > URL: https://issues.apache.org/jira/browse/HIVE-22372 > Project: Hive > Issue Type: Improvement > Components: Metastore >Affects Versions: 2.3.5 >Reporter: fanshilun >Assignee: fanshilun >Priority: Minor > Fix For: 2.3.7 > > > hive 3.x has cachedstore, this feature can reduce database pressure，hope this > feature in 2.3.X version -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22372) Hive MetaStore
[ https://issues.apache.org/jira/browse/HIVE-22372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955376#comment-16955376 ] fanshilun commented on HIVE-22372: -- this feature add 2.3.7 version > Hive MetaStore > -- > > Key: HIVE-22372 > URL: https://issues.apache.org/jira/browse/HIVE-22372 > Project: Hive > Issue Type: Improvement > Components: Metastore >Affects Versions: 2.3.5 >Reporter: fanshilun >Assignee: fanshilun >Priority: Minor > > hive 3.x has cachedstore, this feature can reduce database pressure，hope this > feature in 2.3.X version -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-22372) Hive MetaStore
[ https://issues.apache.org/jira/browse/HIVE-22372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fanshilun reassigned HIVE-22372: Assignee: fanshilun > Hive MetaStore > -- > > Key: HIVE-22372 > URL: https://issues.apache.org/jira/browse/HIVE-22372 > Project: Hive > Issue Type: Improvement > Components: Metastore >Affects Versions: 2.3.5 >Reporter: fanshilun >Assignee: fanshilun >Priority: Minor > > hive 3.x has cachedstore, this feature can reduce database pressure，hope this > feature in 2.3.X version -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22274) Upgrade Calcite version to 1.21.0
[ https://issues.apache.org/jira/browse/HIVE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Carlin updated HIVE-22274: Attachment: HIVE-22274.15.patch > Upgrade Calcite version to 1.21.0 > - > > Key: HIVE-22274 > URL: https://issues.apache.org/jira/browse/HIVE-22274 > Project: Hive > Issue Type: Task >Affects Versions: 3.1.2 >Reporter: Steve Carlin >Assignee: Steve Carlin >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22274.1.patch, HIVE-22274.10.patch, > HIVE-22274.10.patch, HIVE-22274.11.patch, HIVE-22274.12.patch, > HIVE-22274.13.patch, HIVE-22274.15.patch, HIVE-22274.2.patch, > HIVE-22274.3.patch, HIVE-22274.4.patch, HIVE-22274.5.patch, > HIVE-22274.6.patch, HIVE-22274.7.patch, HIVE-22274.8.patch, > HIVE-22274.9.patch, HIVE-22274.patch > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22274) Upgrade Calcite version to 1.21.0
[
https://issues.apache.org/jira/browse/HIVE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955361#comment-16955361
]
Hive QA commented on HIVE-22274:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983537/HIVE-22274.13.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19075/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19075/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19075/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2019-10-20 02:23:32.061
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-19075/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2019-10-20 02:23:32.064
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at c1e5fa3 HIVE-21365: Refactor Hep planner steps in CBO (Jesus
Camacho Rodriguez, reviewed by Vineet Garg)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at c1e5fa3 HIVE-21365: Refactor Hep planner steps in CBO (Jesus
Camacho Rodriguez, reviewed by Vineet Garg)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2019-10-20 02:23:33.080
+ rm -rf ../yetus_PreCommit-HIVE-Build-19075
+ mkdir ../yetus_PreCommit-HIVE-Build-19075
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-19075
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-19075/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
error:
a/accumulo-handler/src/test/results/positive/accumulo_predicate_pushdown.q.out:
does not exist in index
error: a/hbase-handler/src/test/results/positive/hbase_ppd_key_range.q.out:
does not exist in index
error: a/hbase-handler/src/test/results/positive/hbase_pushdown.q.out: does not
exist in index
error:
a/itests/hive-unit/src/test/java/org/apache/hive/jdbc/BaseJdbcWithMiniLlap.java:
does not exist in index
error:
a/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestNewGetSplitsFormat.java:
does not exist in index
error: a/pom.xml: does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveDefaultRelMetadataProvider.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptMaterializationValidator.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveSubQRemoveRelBuilder.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveSemiJoin.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinConstraintsRule.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hiv
[jira] [Updated] (HIVE-22274) Upgrade Calcite version to 1.21.0
[ https://issues.apache.org/jira/browse/HIVE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Carlin updated HIVE-22274: Attachment: HIVE-22274.13.patch > Upgrade Calcite version to 1.21.0 > - > > Key: HIVE-22274 > URL: https://issues.apache.org/jira/browse/HIVE-22274 > Project: Hive > Issue Type: Task >Affects Versions: 3.1.2 >Reporter: Steve Carlin >Assignee: Steve Carlin >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22274.1.patch, HIVE-22274.10.patch, > HIVE-22274.10.patch, HIVE-22274.11.patch, HIVE-22274.12.patch, > HIVE-22274.13.patch, HIVE-22274.2.patch, HIVE-22274.3.patch, > HIVE-22274.4.patch, HIVE-22274.5.patch, HIVE-22274.6.patch, > HIVE-22274.7.patch, HIVE-22274.8.patch, HIVE-22274.9.patch, HIVE-22274.patch > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22274) Upgrade Calcite version to 1.21.0
[
https://issues.apache.org/jira/browse/HIVE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955350#comment-16955350
]
Hive QA commented on HIVE-22274:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983533/HIVE-22274.12.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19074/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19074/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19074/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2019-10-20 01:33:25.265
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-19074/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2019-10-20 01:33:25.269
+ cd apache-github-source-source
+ git fetch origin
>From https://github.com/apache/hive
88314ee..c1e5fa3 master -> origin/master
+ git reset --hard HEAD
HEAD is now at 88314ee HIVE-22175: Fix TestBudyAllocator#testMTT by rechecking
if other thread has created new arena (John Sherman reviewed by Slim Bouguerra)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is behind 'origin/master' by 3 commits, and can be fast-forwarded.
(use "git pull" to update your local branch)
+ git reset --hard origin/master
HEAD is now at c1e5fa3 HIVE-21365: Refactor Hep planner steps in CBO (Jesus
Camacho Rodriguez, reviewed by Vineet Garg)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2019-10-20 01:33:27.341
+ rm -rf ../yetus_PreCommit-HIVE-Build-19074
+ mkdir ../yetus_PreCommit-HIVE-Build-19074
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-19074
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-19074/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
error:
a/accumulo-handler/src/test/results/positive/accumulo_predicate_pushdown.q.out:
does not exist in index
error: a/hbase-handler/src/test/results/positive/hbase_ppd_key_range.q.out:
does not exist in index
error: a/hbase-handler/src/test/results/positive/hbase_pushdown.q.out: does not
exist in index
error:
a/itests/hive-unit/src/test/java/org/apache/hive/jdbc/BaseJdbcWithMiniLlap.java:
does not exist in index
error:
a/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestNewGetSplitsFormat.java:
does not exist in index
error: a/pom.xml: does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveDefaultRelMetadataProvider.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptMaterializationValidator.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveSubQRemoveRelBuilder.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveSemiJoin.java:
does not exist in index
error:
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java:
does not exist in index
error:
a/ql/src/java/org/apache/hado
[jira] [Updated] (HIVE-22274) Upgrade Calcite version to 1.21.0
[ https://issues.apache.org/jira/browse/HIVE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Carlin updated HIVE-22274: Attachment: HIVE-22274.12.patch > Upgrade Calcite version to 1.21.0 > - > > Key: HIVE-22274 > URL: https://issues.apache.org/jira/browse/HIVE-22274 > Project: Hive > Issue Type: Task >Affects Versions: 3.1.2 >Reporter: Steve Carlin >Assignee: Steve Carlin >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22274.1.patch, HIVE-22274.10.patch, > HIVE-22274.10.patch, HIVE-22274.11.patch, HIVE-22274.12.patch, > HIVE-22274.2.patch, HIVE-22274.3.patch, HIVE-22274.4.patch, > HIVE-22274.5.patch, HIVE-22274.6.patch, HIVE-22274.7.patch, > HIVE-22274.8.patch, HIVE-22274.9.patch, HIVE-22274.patch > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-21365) Refactor Hep planner steps in CBO
[ https://issues.apache.org/jira/browse/HIVE-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesus Camacho Rodriguez updated HIVE-21365: --- Fix Version/s: 4.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Refactor Hep planner steps in CBO > - > > Key: HIVE-21365 > URL: https://issues.apache.org/jira/browse/HIVE-21365 > Project: Hive > Issue Type: Improvement > Components: CBO >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21365.01.patch, HIVE-21365.01.patch, > HIVE-21365.02.patch, HIVE-21365.03.patch, HIVE-21365.03.patch, > HIVE-21365.04.patch, HIVE-21365.05.patch, HIVE-21365.06.patch, > HIVE-21365.09.patch, HIVE-21365.patch > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Using subprograms to decrease number of planner instantiations and benefit > fully from metadata providers caching, among other benefits. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-21365) Refactor Hep planner steps in CBO
[ https://issues.apache.org/jira/browse/HIVE-21365?focusedWorklogId=331015&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-331015 ] ASF GitHub Bot logged work on HIVE-21365: - Author: ASF GitHub Bot Created on: 20/Oct/19 01:14 Start Date: 20/Oct/19 01:14 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #630: HIVE-21365 URL: https://github.com/apache/hive/pull/630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 331015) Time Spent: 1h 40m (was: 1.5h) > Refactor Hep planner steps in CBO > - > > Key: HIVE-21365 > URL: https://issues.apache.org/jira/browse/HIVE-21365 > Project: Hive > Issue Type: Improvement > Components: CBO >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21365.01.patch, HIVE-21365.01.patch, > HIVE-21365.02.patch, HIVE-21365.03.patch, HIVE-21365.03.patch, > HIVE-21365.04.patch, HIVE-21365.05.patch, HIVE-21365.06.patch, > HIVE-21365.09.patch, HIVE-21365.patch > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Using subprograms to decrease number of planner instantiations and benefit > fully from metadata providers caching, among other benefits. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22342) HMS Translation: HIVE-22189 too strict with location for EXTERNAL tables
[ https://issues.apache.org/jira/browse/HIVE-22342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Gangam updated HIVE-22342: - Fix Version/s: 4.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the review [~samuelan]. I have incorporated your feedback into the final fix. > HMS Translation: HIVE-22189 too strict with location for EXTERNAL tables > > > Key: HIVE-22342 > URL: https://issues.apache.org/jira/browse/HIVE-22342 > Project: Hive > Issue Type: Sub-task > Components: Hive >Affects Versions: 4.0.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22342.2.patch, HIVE-22342.3.patch, HIVE-22342.patch > > > HIVE-22189 restricts EXTERNAL tables being created to be restricted to the > EXTERNAL_WAREHOUSE_DIR. This might be too strict as any other location should > be allowed as long as the location is outside the MANAGED warehouse directory. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-21365) Refactor Hep planner steps in CBO
[
https://issues.apache.org/jira/browse/HIVE-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955275#comment-16955275
]
Hive QA commented on HIVE-21365:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983515/HIVE-21365.09.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19073/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19073/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19073/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL
https://issues.apache.org/jira/secure/attachment/12983515/HIVE-21365.09.patch
was found in seen patch url's cache and a test was probably run already on it.
Aborting...
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983515 - PreCommit-HIVE-Build
> Refactor Hep planner steps in CBO
> -
>
> Key: HIVE-21365
> URL: https://issues.apache.org/jira/browse/HIVE-21365
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21365.01.patch, HIVE-21365.01.patch,
> HIVE-21365.02.patch, HIVE-21365.03.patch, HIVE-21365.03.patch,
> HIVE-21365.04.patch, HIVE-21365.05.patch, HIVE-21365.06.patch,
> HIVE-21365.09.patch, HIVE-21365.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Using subprograms to decrease number of planner instantiations and benefit
> fully from metadata providers caching, among other benefits.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-21365) Refactor Hep planner steps in CBO
[
https://issues.apache.org/jira/browse/HIVE-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955274#comment-16955274
]
Hive QA commented on HIVE-21365:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983515/HIVE-21365.09.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19072/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19072/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19072/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL
https://issues.apache.org/jira/secure/attachment/12983515/HIVE-21365.09.patch
was found in seen patch url's cache and a test was probably run already on it.
Aborting...
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983515 - PreCommit-HIVE-Build
> Refactor Hep planner steps in CBO
> -
>
> Key: HIVE-21365
> URL: https://issues.apache.org/jira/browse/HIVE-21365
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21365.01.patch, HIVE-21365.01.patch,
> HIVE-21365.02.patch, HIVE-21365.03.patch, HIVE-21365.03.patch,
> HIVE-21365.04.patch, HIVE-21365.05.patch, HIVE-21365.06.patch,
> HIVE-21365.09.patch, HIVE-21365.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Using subprograms to decrease number of planner instantiations and benefit
> fully from metadata providers caching, among other benefits.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-21365) Refactor Hep planner steps in CBO
[
https://issues.apache.org/jira/browse/HIVE-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955272#comment-16955272
]
Hive QA commented on HIVE-21365:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983515/HIVE-21365.09.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17545 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19071/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19071/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19071/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983515 - PreCommit-HIVE-Build
> Refactor Hep planner steps in CBO
> -
>
> Key: HIVE-21365
> URL: https://issues.apache.org/jira/browse/HIVE-21365
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21365.01.patch, HIVE-21365.01.patch,
> HIVE-21365.02.patch, HIVE-21365.03.patch, HIVE-21365.03.patch,
> HIVE-21365.04.patch, HIVE-21365.05.patch, HIVE-21365.06.patch,
> HIVE-21365.09.patch, HIVE-21365.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Using subprograms to decrease number of planner instantiations and benefit
> fully from metadata providers caching, among other benefits.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-21365) Refactor Hep planner steps in CBO
[
https://issues.apache.org/jira/browse/HIVE-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955259#comment-16955259
]
Hive QA commented on HIVE-21365:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
17s{color} | {color:blue} ql in master has 1548 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
42s{color} | {color:red} ql: The patch generated 5 new + 198 unchanged - 18
fixed = 203 total (was 216) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
16s{color} | {color:green} ql generated 0 new + 1547 unchanged - 1 fixed = 1547
total (was 1548) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 13s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19071/dev-support/hive-personality.sh
|
| git revision | master / 88314ee |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19071/yetus/diff-checkstyle-ql.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19071/yetus/patch-asflicense-problems.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19071/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Refactor Hep planner steps in CBO
> -
>
> Key: HIVE-21365
> URL: https://issues.apache.org/jira/browse/HIVE-21365
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21365.01.patch, HIVE-21365.01.patch,
> HIVE-21365.02.patch, HIVE-21365.03.patch, HIVE-21365.03.patch,
> HIVE-21365.04.patch, HIVE-21365.05.patch, HIVE-21365.06.patch,
> HIVE-21365.09.patch, HIVE-21365.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Using subprograms to decrease number of planner instantiations and benefit
> fully from metadata providers caching, among other benefits.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22274) Upgrade Calcite version to 1.21.0
[
https://issues.apache.org/jira/browse/HIVE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955256#comment-16955256
]
Hive QA commented on HIVE-22274:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
36s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
12s{color} | {color:blue} ql in master has 1548 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
31s{color} | {color:blue} accumulo-handler in master has 21 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
31s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
44s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m
34s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
45s{color} | {color:red} ql: The patch generated 36 new + 348 unchanged - 12
fixed = 384 total (was 360) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
10s{color} | {color:red} root: The patch generated 37 new + 400 unchanged - 12
fixed = 437 total (was 412) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
19s{color} | {color:red} itests/hive-unit: The patch generated 1 new + 52
unchanged - 0 fixed = 53 total (was 52) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 5 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
33s{color} | {color:red} ql generated 9 new + 1545 unchanged - 3 fixed = 1554
total (was 1548) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m
3s{color} | {color:red} ql generated 4 new + 96 unchanged - 4 fixed = 100 total
(was 100) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 7m
22s{color} | {color:red} root generated 4 new + 333 unchanged - 4 fixed = 337
total (was 337) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
38s{color} | {color:red} The patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 80m 8s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Dead store to joinInfo in
org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, Set, JoinRelType, boolean) At
HiveRelFactories.java:org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, Set, JoinRelType, boolean) At HiveRelFactories.java:[line
170] |
| | Dead store to joinInfo in
org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, JoinRelType, Set, boolean) At
HiveRelFactories.java:
[jira] [Commented] (HIVE-22274) Upgrade Calcite version to 1.21.0
[
https://issues.apache.org/jira/browse/HIVE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955252#comment-16955252
]
Hive QA commented on HIVE-22274:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983507/HIVE-22274.11.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17545 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_ALL]
(batchId=162)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_ANY]
(batchId=177)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19070/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19070/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19070/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983507 - PreCommit-HIVE-Build
> Upgrade Calcite version to 1.21.0
> -
>
> Key: HIVE-22274
> URL: https://issues.apache.org/jira/browse/HIVE-22274
> Project: Hive
> Issue Type: Task
>Affects Versions: 3.1.2
>Reporter: Steve Carlin
>Assignee: Steve Carlin
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22274.1.patch, HIVE-22274.10.patch,
> HIVE-22274.10.patch, HIVE-22274.11.patch, HIVE-22274.2.patch,
> HIVE-22274.3.patch, HIVE-22274.4.patch, HIVE-22274.5.patch,
> HIVE-22274.6.patch, HIVE-22274.7.patch, HIVE-22274.8.patch,
> HIVE-22274.9.patch, HIVE-22274.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-21365) Refactor Hep planner steps in CBO
[ https://issues.apache.org/jira/browse/HIVE-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesus Camacho Rodriguez updated HIVE-21365: --- Attachment: (was: HIVE-21365.08.patch) > Refactor Hep planner steps in CBO > - > > Key: HIVE-21365 > URL: https://issues.apache.org/jira/browse/HIVE-21365 > Project: Hive > Issue Type: Improvement > Components: CBO >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Labels: pull-request-available > Attachments: HIVE-21365.01.patch, HIVE-21365.01.patch, > HIVE-21365.02.patch, HIVE-21365.03.patch, HIVE-21365.03.patch, > HIVE-21365.04.patch, HIVE-21365.05.patch, HIVE-21365.06.patch, > HIVE-21365.09.patch, HIVE-21365.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > Using subprograms to decrease number of planner instantiations and benefit > fully from metadata providers caching, among other benefits. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-21365) Refactor Hep planner steps in CBO
[ https://issues.apache.org/jira/browse/HIVE-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesus Camacho Rodriguez updated HIVE-21365: --- Attachment: HIVE-21365.09.patch > Refactor Hep planner steps in CBO > - > > Key: HIVE-21365 > URL: https://issues.apache.org/jira/browse/HIVE-21365 > Project: Hive > Issue Type: Improvement > Components: CBO >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Labels: pull-request-available > Attachments: HIVE-21365.01.patch, HIVE-21365.01.patch, > HIVE-21365.02.patch, HIVE-21365.03.patch, HIVE-21365.03.patch, > HIVE-21365.04.patch, HIVE-21365.05.patch, HIVE-21365.06.patch, > HIVE-21365.08.patch, HIVE-21365.09.patch, HIVE-21365.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > Using subprograms to decrease number of planner instantiations and benefit > fully from metadata providers caching, among other benefits. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-21365) Refactor Hep planner steps in CBO
[ https://issues.apache.org/jira/browse/HIVE-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesus Camacho Rodriguez updated HIVE-21365: --- Attachment: (was: HIVE-21365.07.patch) > Refactor Hep planner steps in CBO > - > > Key: HIVE-21365 > URL: https://issues.apache.org/jira/browse/HIVE-21365 > Project: Hive > Issue Type: Improvement > Components: CBO >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Labels: pull-request-available > Attachments: HIVE-21365.01.patch, HIVE-21365.01.patch, > HIVE-21365.02.patch, HIVE-21365.03.patch, HIVE-21365.03.patch, > HIVE-21365.04.patch, HIVE-21365.05.patch, HIVE-21365.06.patch, > HIVE-21365.08.patch, HIVE-21365.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > Using subprograms to decrease number of planner instantiations and benefit > fully from metadata providers caching, among other benefits. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-21365) Refactor Hep planner steps in CBO
[ https://issues.apache.org/jira/browse/HIVE-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesus Camacho Rodriguez updated HIVE-21365: --- Attachment: HIVE-21365.08.patch > Refactor Hep planner steps in CBO > - > > Key: HIVE-21365 > URL: https://issues.apache.org/jira/browse/HIVE-21365 > Project: Hive > Issue Type: Improvement > Components: CBO >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Labels: pull-request-available > Attachments: HIVE-21365.01.patch, HIVE-21365.01.patch, > HIVE-21365.02.patch, HIVE-21365.03.patch, HIVE-21365.03.patch, > HIVE-21365.04.patch, HIVE-21365.05.patch, HIVE-21365.06.patch, > HIVE-21365.08.patch, HIVE-21365.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > Using subprograms to decrease number of planner instantiations and benefit > fully from metadata providers caching, among other benefits. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22324) Checkin test output changes due to Calcite 1.21 upgrade
[
https://issues.apache.org/jira/browse/HIVE-22324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955225#comment-16955225
]
Hive QA commented on HIVE-22324:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983510/HIVE-22324.2.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17545 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19069/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19069/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19069/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983510 - PreCommit-HIVE-Build
> Checkin test output changes due to Calcite 1.21 upgrade
> ---
>
> Key: HIVE-22324
> URL: https://issues.apache.org/jira/browse/HIVE-22324
> Project: Hive
> Issue Type: Sub-task
>Reporter: Steve Carlin
>Assignee: Steve Carlin
>Priority: Major
> Attachments: HIVE-22324.1.patch, HIVE-22324.2.patch, HIVE-22324.patch
>
>
> On the upgrade to Calcite 1.21, CALC-2991 caused a change in some of the
> planner output. This initial hive checkin for the upgrade did an override of
> the RelMdMaxRowCount class to simulate 1.19 behavior.
> This task is to remove the HiveRelMdMaxRowCount class, use the new 1.21 code,
> and change the q.out files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22324) Checkin test output changes due to Calcite 1.21 upgrade
[
https://issues.apache.org/jira/browse/HIVE-22324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955224#comment-16955224
]
Hive QA commented on HIVE-22324:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
46s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
41s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
7s{color} | {color:blue} ql in master has 1548 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
32s{color} | {color:blue} accumulo-handler in master has 21 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
36s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
42s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
58s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m
21s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
41s{color} | {color:red} ql: The patch generated 14 new + 346 unchanged - 12
fixed = 360 total (was 358) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
9s{color} | {color:red} root: The patch generated 15 new + 398 unchanged - 12
fixed = 413 total (was 410) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
18s{color} | {color:red} itests/hive-unit: The patch generated 1 new + 52
unchanged - 0 fixed = 53 total (was 52) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
16s{color} | {color:red} ql generated 9 new + 1545 unchanged - 3 fixed = 1554
total (was 1548) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m
3s{color} | {color:red} ql generated 4 new + 96 unchanged - 4 fixed = 100 total
(was 100) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 6m
59s{color} | {color:red} root generated 4 new + 333 unchanged - 4 fixed = 337
total (was 337) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 77m 55s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Dead store to joinInfo in
org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, Set, JoinRelType, boolean) At
HiveRelFactories.java:org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, Set, JoinRelType, boolean) At HiveRelFactories.java:[line
170] |
| | Dead store to joinInfo in
org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, JoinRelType, Set, boolean) At
HiveRelFactories.java:
[jira] [Updated] (HIVE-21365) Refactor Hep planner steps in CBO
[ https://issues.apache.org/jira/browse/HIVE-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesus Camacho Rodriguez updated HIVE-21365: --- Attachment: HIVE-21365.07.patch > Refactor Hep planner steps in CBO > - > > Key: HIVE-21365 > URL: https://issues.apache.org/jira/browse/HIVE-21365 > Project: Hive > Issue Type: Improvement > Components: CBO >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Labels: pull-request-available > Attachments: HIVE-21365.01.patch, HIVE-21365.01.patch, > HIVE-21365.02.patch, HIVE-21365.03.patch, HIVE-21365.03.patch, > HIVE-21365.04.patch, HIVE-21365.05.patch, HIVE-21365.06.patch, > HIVE-21365.07.patch, HIVE-21365.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > Using subprograms to decrease number of planner instantiations and benefit > fully from metadata providers caching, among other benefits. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22342) HMS Translation: HIVE-22189 too strict with location for EXTERNAL tables
[ https://issues.apache.org/jira/browse/HIVE-22342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955214#comment-16955214 ] Sam An commented on HIVE-22342: --- +1. Except To have consistent style, we can change "true" to "TRUE" in MetastoreDefaultTransformer.java > HMS Translation: HIVE-22189 too strict with location for EXTERNAL tables > > > Key: HIVE-22342 > URL: https://issues.apache.org/jira/browse/HIVE-22342 > Project: Hive > Issue Type: Sub-task > Components: Hive >Affects Versions: 4.0.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Major > Attachments: HIVE-22342.2.patch, HIVE-22342.3.patch, HIVE-22342.patch > > > HIVE-22189 restricts EXTERNAL tables being created to be restricted to the > EXTERNAL_WAREHOUSE_DIR. This might be too strict as any other location should > be allowed as long as the location is outside the MANAGED warehouse directory. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22324) Checkin test output changes due to Calcite 1.21 upgrade
[ https://issues.apache.org/jira/browse/HIVE-22324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Carlin updated HIVE-22324: Attachment: HIVE-22324.2.patch > Checkin test output changes due to Calcite 1.21 upgrade > --- > > Key: HIVE-22324 > URL: https://issues.apache.org/jira/browse/HIVE-22324 > Project: Hive > Issue Type: Sub-task >Reporter: Steve Carlin >Assignee: Steve Carlin >Priority: Major > Attachments: HIVE-22324.1.patch, HIVE-22324.2.patch, HIVE-22324.patch > > > On the upgrade to Calcite 1.21, CALC-2991 caused a change in some of the > planner output. This initial hive checkin for the upgrade did an override of > the RelMdMaxRowCount class to simulate 1.19 behavior. > This task is to remove the HiveRelMdMaxRowCount class, use the new 1.21 code, > and change the q.out files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22274) Upgrade Calcite version to 1.21.0
[ https://issues.apache.org/jira/browse/HIVE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Carlin updated HIVE-22274: Attachment: HIVE-22274.11.patch > Upgrade Calcite version to 1.21.0 > - > > Key: HIVE-22274 > URL: https://issues.apache.org/jira/browse/HIVE-22274 > Project: Hive > Issue Type: Task >Affects Versions: 3.1.2 >Reporter: Steve Carlin >Assignee: Steve Carlin >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22274.1.patch, HIVE-22274.10.patch, > HIVE-22274.10.patch, HIVE-22274.11.patch, HIVE-22274.2.patch, > HIVE-22274.3.patch, HIVE-22274.4.patch, HIVE-22274.5.patch, > HIVE-22274.6.patch, HIVE-22274.7.patch, HIVE-22274.8.patch, > HIVE-22274.9.patch, HIVE-22274.patch > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22329) Create DriverContext
[
https://issues.apache.org/jira/browse/HIVE-22329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955155#comment-16955155
]
Hive QA commented on HIVE-22329:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983494/HIVE-22329.04.patch
{color:green}SUCCESS:{color} +1 due to 8 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17545 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[hybridgrace_hashjoin_2]
(batchId=111)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19068/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19068/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19068/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983494 - PreCommit-HIVE-Build
> Create DriverContext
>
>
> Key: HIVE-22329
> URL: https://issues.apache.org/jira/browse/HIVE-22329
> Project: Hive
> Issue Type: Sub-task
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22329.01.patch, HIVE-22329.02.patch,
> HIVE-22329.03.patch, HIVE-22329.04.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The current DriverContext class is not really a context, rather a queue, thus
> it should be renamed to DriverQueue. At the same time Driver has a a lot of
> fields, they should be in a real context class called DriverContext, which
> would also facilitate the extraction of independent parts of the Driver class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22329) Create DriverContext
[
https://issues.apache.org/jira/browse/HIVE-22329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955145#comment-16955145
]
Hive QA commented on HIVE-22329:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
55s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
22s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
14s{color} | {color:blue} ql in master has 1548 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
40s{color} | {color:blue} hcatalog/core in master has 36 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
40s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
45s{color} | {color:red} ql: The patch generated 5 new + 368 unchanged - 73
fixed = 373 total (was 441) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
21s{color} | {color:red} ql generated 13 new + 1535 unchanged - 13 fixed = 1548
total (was 1548) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m
5s{color} | {color:red} ql generated 1 new + 99 unchanged - 1 fixed = 100 total
(was 100) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 36m 2s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Naked notify in org.apache.hadoop.hive.ql.TaskQueue.releaseRunnable() At
TaskQueue.java:At TaskQueue.java:[line 98] |
| | Found reliance on default encoding in
org.apache.hadoop.hive.ql.exec.ExplainSQRewriteTask.execute():in
org.apache.hadoop.hive.ql.exec.ExplainSQRewriteTask.execute(): new
java.io.PrintStream(OutputStream) At ExplainSQRewriteTask.java:[line 59] |
| | Dead store to jsonPlan in
org.apache.hadoop.hive.ql.exec.ExplainTask.execute() At
ExplainTask.java:org.apache.hadoop.hive.ql.exec.ExplainTask.execute() At
ExplainTask.java:[line 454] |
| | Found reliance on default encoding in
org.apache.hadoop.hive.ql.exec.ExplainTask.execute():in
org.apache.hadoop.hive.ql.exec.ExplainTask.execute(): new
java.io.PrintStream(OutputStream) At ExplainTask.java:[line 406] |
| | Invocation of toString on
org.apache.hadoop.hive.ql.plan.CopyWork.getFromPaths() in
org.apache.hadoop.hive.ql.exec.ReplCopyTask.execute() At ReplCopyTask.java:in
org.apache.hadoop.hive.ql.exec.ReplCopyTask.execute() At
ReplCopyTask.java:[line 145] |
| | Invocation of toString on
org.apache.hadoop.hive.ql.plan.CopyWork.getToPaths() in
org.apache.hadoop.hive.ql.exec.ReplCopyTask.execute() At ReplCopyTask.java:in
org.apache.hadoop.hive.ql.exec.ReplCopyTask.execute() At
ReplCopyTask.java:[line 145] |
| | Exception is caught when Exception is not thrown in
org.apache.hadoop.hive.ql.exec.mr.MapRedTask.execute() At MapRedTask.java:is
not thrown in org.apache.hadoop.hive.ql.exec.mr.MapRedTask.execute() At
MapRedTask.java:[line 319] |
| |
[jira] [Commented] (HIVE-22274) Upgrade Calcite version to 1.21.0
[
https://issues.apache.org/jira/browse/HIVE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955138#comment-16955138
]
Hive QA commented on HIVE-22274:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
35s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
14s{color} | {color:blue} ql in master has 1548 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
33s{color} | {color:blue} accumulo-handler in master has 21 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
34s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
43s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 9m
4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m
20s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
46s{color} | {color:red} ql: The patch generated 14 new + 346 unchanged - 12
fixed = 360 total (was 358) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
12s{color} | {color:red} root: The patch generated 15 new + 398 unchanged - 12
fixed = 413 total (was 410) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
19s{color} | {color:red} itests/hive-unit: The patch generated 1 new + 52
unchanged - 0 fixed = 53 total (was 52) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
24s{color} | {color:red} ql generated 9 new + 1545 unchanged - 3 fixed = 1554
total (was 1548) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m
3s{color} | {color:red} ql generated 4 new + 96 unchanged - 4 fixed = 100 total
(was 100) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 6m
55s{color} | {color:red} root generated 4 new + 333 unchanged - 4 fixed = 337
total (was 337) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 79m 47s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Dead store to joinInfo in
org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, Set, JoinRelType, boolean) At
HiveRelFactories.java:org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, Set, JoinRelType, boolean) At HiveRelFactories.java:[line
171] |
| | Dead store to joinInfo in
org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, JoinRelType, Set, boolean) At
HiveRelFactories.java:
[jira] [Commented] (HIVE-22274) Upgrade Calcite version to 1.21.0
[
https://issues.apache.org/jira/browse/HIVE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955137#comment-16955137
]
Hive QA commented on HIVE-22274:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983487/HIVE-22274.10.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17545 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19067/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19067/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19067/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983487 - PreCommit-HIVE-Build
> Upgrade Calcite version to 1.21.0
> -
>
> Key: HIVE-22274
> URL: https://issues.apache.org/jira/browse/HIVE-22274
> Project: Hive
> Issue Type: Task
>Affects Versions: 3.1.2
>Reporter: Steve Carlin
>Assignee: Steve Carlin
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22274.1.patch, HIVE-22274.10.patch,
> HIVE-22274.10.patch, HIVE-22274.2.patch, HIVE-22274.3.patch,
> HIVE-22274.4.patch, HIVE-22274.5.patch, HIVE-22274.6.patch,
> HIVE-22274.7.patch, HIVE-22274.8.patch, HIVE-22274.9.patch, HIVE-22274.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22370) Remove Deprecated Fields from HiveConf
[
https://issues.apache.org/jira/browse/HIVE-22370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955120#comment-16955120
]
Hive QA commented on HIVE-22370:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983486/HIVE-22370.1.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19066/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19066/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19066/
Messages:
{noformat}
This message was trimmed, see log for full details
2019-10-19 09:17:22.575
+ rm -rf ../yetus_PreCommit-HIVE-Build-19066
+ mkdir ../yetus_PreCommit-HIVE-Build-19066
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-19066
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-19066/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
error:
a/common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java:
does not exist in index
error: a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java: does not
exist in index
error: a/common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java: does
not exist in index
error:
a/common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleReportersConf.java:
does not exist in index
error: a/common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java: does
not exist in index
error:
a/common/src/test/org/apache/hadoop/hive/conf/TestHiveConfRestrictList.java:
does not exist in index
error:
a/hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestSemanticAnalysis.java:
does not exist in index
error:
a/hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestPassProperties.java:
does not exist in index
error:
a/hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestE2EScenarios.java:
does not exist in index
error:
a/hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderEncryption.java:
does not exist in index
error:
a/hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java:
does not exist in index
error:
a/metastore/src/java/org/apache/hadoop/hive/metastore/HiveClientCache.java:
does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java: does
not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: does not
exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java: does
not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java: does not
exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java: does
not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java: does not
exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java: does
not exist in index
error: a/ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java: does not
exist in index
error: a/ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands2.java: does not
exist in index
error: a/ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommandsForMmTable.java:
does not exist in index
error: a/ql/src/test/org/apache/hadoop/hive/ql/TxnCommandsBaseForTests.java:
does not exist in index
error: a/ql/src/test/org/apache/hadoop/hive/ql/exec/TestOperators.java: does
not exist in index
error: a/ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java: does not
exist in index
error:
a/ql/src/test/org/apache/hadoop/hive/ql/processors/TestSetProcessor.java: does
not exist in index
error:
a/ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHivePrivilegeObjectOwnerNameAndType.java:
does not exist in index
error:
a/ql/src/test/org/apache/hadoop/hive/ql/stats/TestStatsUpdaterThread.java: does
not exist in index
error:
a/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
does not exist in index
Going to apply patch with: git apply -p1
+ [[ maven == \m\a\v\e\n ]]
+ rm -rf /data/hiveptest/working/maven/org/apache/hive
+ mvn -B clean install -DskipTests -T 4 -q
-Dmaven.repo.local=/data/hiveptest/working/maven
protoc-jar: executing: [/tmp/protoc7131237008015343620.exe, --version]
libprotoc 2.5.0
protoc-jar: executing: [/tmp/protoc7131237008015343620.exe,
-I/data/hiveptest/working/apache-githu
[jira] [Commented] (HIVE-22311) Propagate min/max column values from statistics to the optimizer for timestamp type
[
https://issues.apache.org/jira/browse/HIVE-22311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955118#comment-16955118
]
Hive QA commented on HIVE-22311:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983485/HIVE-22311.01.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 14 failed/errored test(s), 17546 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_nonvec_part_all_primitive]
(batchId=187)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_nonvec_part_all_primitive_llap_io]
(batchId=186)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_vec_part_all_primitive]
(batchId=183)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_vec_part_all_primitive_llap_io]
(batchId=168)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_nonvec_part_all_primitive]
(batchId=176)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_nonvec_part_all_primitive_llap_io]
(batchId=187)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part_all_primitive]
(batchId=178)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part_all_primitive_llap_io]
(batchId=183)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part_all_primitive]
(batchId=179)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part_all_primitive_llap_io]
(batchId=170)
org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerCustomCreatedDynamicPartitions
(batchId=284)
org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerCustomCreatedDynamicPartitionsUnionAll
(batchId=284)
org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerHighShuffleBytes
(batchId=284)
org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerSlowQueryExecutionTime
(batchId=284)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19065/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19065/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19065/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 14 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983485 - PreCommit-HIVE-Build
> Propagate min/max column values from statistics to the optimizer for
> timestamp type
> ---
>
> Key: HIVE-22311
> URL: https://issues.apache.org/jira/browse/HIVE-22311
> Project: Hive
> Issue Type: Bug
> Components: Statistics
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22311.01.patch, HIVE-22311.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently stats annotation does not consider timestamp type e.g. for
> estimates with range predicates.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22329) Create DriverContext
[ https://issues.apache.org/jira/browse/HIVE-22329?focusedWorklogId=330911&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330911 ] ASF GitHub Bot logged work on HIVE-22329: - Author: ASF GitHub Bot Created on: 19/Oct/19 09:14 Start Date: 19/Oct/19 09:14 Worklog Time Spent: 10m Work Description: miklosgergely commented on issue #810: HIVE-22329 Create DriverContext URL: https://github.com/apache/hive/pull/810#issuecomment-544118636 @kgyrtkirk I've modified the patch according to your comments. Also modified the logic of passing the arguments to a test, now the TaskQueue and the context are passed at the initialize call, and execute has no argument, which is much cleaner. TaskQueue now doesn't exposes the context. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 330911) Time Spent: 1h 10m (was: 1h) > Create DriverContext > > > Key: HIVE-22329 > URL: https://issues.apache.org/jira/browse/HIVE-22329 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22329.01.patch, HIVE-22329.02.patch, > HIVE-22329.03.patch, HIVE-22329.04.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The current DriverContext class is not really a context, rather a queue, thus > it should be renamed to DriverQueue. At the same time Driver has a a lot of > fields, they should be in a real context class called DriverContext, which > would also facilitate the extraction of independent parts of the Driver class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22329) Create DriverContext
[
https://issues.apache.org/jira/browse/HIVE-22329?focusedWorklogId=330910&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330910
]
ASF GitHub Bot logged work on HIVE-22329:
-
Author: ASF GitHub Bot
Created on: 19/Oct/19 09:10
Start Date: 19/Oct/19 09:10
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #810:
HIVE-22329 Create DriverContext
URL: https://github.com/apache/hive/pull/810#discussion_r336729080
##
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverQueue.java
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Queue;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.LinkedBlockingQueue;
+
+import org.apache.hadoop.hive.ql.exec.FileSinkOperator;
+import org.apache.hadoop.hive.ql.exec.NodeUtils;
+import org.apache.hadoop.hive.ql.exec.NodeUtils.Function;
+import org.apache.hadoop.hive.ql.exec.Operator;
+import org.apache.hadoop.hive.ql.exec.StatsTask;
+import org.apache.hadoop.hive.ql.exec.Task;
+import org.apache.hadoop.hive.ql.exec.TaskRunner;
+import org.apache.hadoop.hive.ql.exec.mr.MapRedTask;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+import org.apache.hadoop.hive.ql.plan.MapWork;
+import org.apache.hadoop.hive.ql.plan.ReduceWork;
+import org.apache.hadoop.hive.ql.session.SessionState;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Handles the queue of tasks that should be executed by the driver.
+ */
+public class DriverQueue {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(Driver.class.getName());
+ private static final SessionState.LogHelper CONSOLE = new
SessionState.LogHelper(LOG);
+
+ private static final int SLEEP_TIME = 2000;
+
+ private final Queue> runnable = new
ConcurrentLinkedQueue>();;
+ private final Queue running = new
LinkedBlockingQueue();
Review comment:
fixed, you are right, it is not a queue
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 330910)
Time Spent: 1h (was: 50m)
> Create DriverContext
>
>
> Key: HIVE-22329
> URL: https://issues.apache.org/jira/browse/HIVE-22329
> Project: Hive
> Issue Type: Sub-task
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22329.01.patch, HIVE-22329.02.patch,
> HIVE-22329.03.patch, HIVE-22329.04.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The current DriverContext class is not really a context, rather a queue, thus
> it should be renamed to DriverQueue. At the same time Driver has a a lot of
> fields, they should be in a real context class called DriverContext, which
> would also facilitate the extraction of independent parts of the Driver class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22329) Create DriverContext
[
https://issues.apache.org/jira/browse/HIVE-22329?focusedWorklogId=330909&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330909
]
ASF GitHub Bot logged work on HIVE-22329:
-
Author: ASF GitHub Bot
Created on: 19/Oct/19 09:09
Start Date: 19/Oct/19 09:09
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #810:
HIVE-22329 Create DriverContext
URL: https://github.com/apache/hive/pull/810#discussion_r336729070
##
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLOperationContext.java
##
@@ -34,19 +34,19 @@
public class DDLOperationContext {
private final Hive db;
private final HiveConf conf;
- private final DriverContext driverContext;
+ private final DriverQueue driverQueue;
Review comment:
fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 330909)
Time Spent: 50m (was: 40m)
> Create DriverContext
>
>
> Key: HIVE-22329
> URL: https://issues.apache.org/jira/browse/HIVE-22329
> Project: Hive
> Issue Type: Sub-task
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22329.01.patch, HIVE-22329.02.patch,
> HIVE-22329.03.patch, HIVE-22329.04.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The current DriverContext class is not really a context, rather a queue, thus
> it should be renamed to DriverQueue. At the same time Driver has a a lot of
> fields, they should be in a real context class called DriverContext, which
> would also facilitate the extraction of independent parts of the Driver class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22329) Create DriverContext
[
https://issues.apache.org/jira/browse/HIVE-22329?focusedWorklogId=330908&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330908
]
ASF GitHub Bot logged work on HIVE-22329:
-
Author: ASF GitHub Bot
Created on: 19/Oct/19 09:09
Start Date: 19/Oct/19 09:09
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #810:
HIVE-22329 Create DriverContext
URL: https://github.com/apache/hive/pull/810#discussion_r336729060
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/lock/LockTableOperation.java
##
@@ -34,7 +34,7 @@ public LockTableOperation(DDLOperationContext context,
LockTableDesc desc) {
@Override
public int execute() throws HiveException {
-Context ctx = context.getDriverContext().getCtx();
+Context ctx = context.getDriverQueue().getCtx();
Review comment:
fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 330908)
Time Spent: 40m (was: 0.5h)
> Create DriverContext
>
>
> Key: HIVE-22329
> URL: https://issues.apache.org/jira/browse/HIVE-22329
> Project: Hive
> Issue Type: Sub-task
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22329.01.patch, HIVE-22329.02.patch,
> HIVE-22329.03.patch, HIVE-22329.04.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The current DriverContext class is not really a context, rather a queue, thus
> it should be renamed to DriverQueue. At the same time Driver has a a lot of
> fields, they should be in a real context class called DriverContext, which
> would also facilitate the extraction of independent parts of the Driver class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22329) Create DriverContext
[
https://issues.apache.org/jira/browse/HIVE-22329?focusedWorklogId=330907&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330907
]
ASF GitHub Bot logged work on HIVE-22329:
-
Author: ASF GitHub Bot
Created on: 19/Oct/19 09:09
Start Date: 19/Oct/19 09:09
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #810:
HIVE-22329 Create DriverContext
URL: https://github.com/apache/hive/pull/810#discussion_r336729050
##
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverQueue.java
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Queue;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.LinkedBlockingQueue;
+
+import org.apache.hadoop.hive.ql.exec.FileSinkOperator;
+import org.apache.hadoop.hive.ql.exec.NodeUtils;
+import org.apache.hadoop.hive.ql.exec.NodeUtils.Function;
+import org.apache.hadoop.hive.ql.exec.Operator;
+import org.apache.hadoop.hive.ql.exec.StatsTask;
+import org.apache.hadoop.hive.ql.exec.Task;
+import org.apache.hadoop.hive.ql.exec.TaskRunner;
+import org.apache.hadoop.hive.ql.exec.mr.MapRedTask;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+import org.apache.hadoop.hive.ql.plan.MapWork;
+import org.apache.hadoop.hive.ql.plan.ReduceWork;
+import org.apache.hadoop.hive.ql.session.SessionState;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Handles the queue of tasks that should be executed by the driver.
+ */
+public class DriverQueue {
Review comment:
fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 330907)
Time Spent: 0.5h (was: 20m)
> Create DriverContext
>
>
> Key: HIVE-22329
> URL: https://issues.apache.org/jira/browse/HIVE-22329
> Project: Hive
> Issue Type: Sub-task
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22329.01.patch, HIVE-22329.02.patch,
> HIVE-22329.03.patch, HIVE-22329.04.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The current DriverContext class is not really a context, rather a queue, thus
> it should be renamed to DriverQueue. At the same time Driver has a a lot of
> fields, they should be in a real context class called DriverContext, which
> would also facilitate the extraction of independent parts of the Driver class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22329) Create DriverContext
[ https://issues.apache.org/jira/browse/HIVE-22329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely updated HIVE-22329: -- Attachment: HIVE-22329.04.patch > Create DriverContext > > > Key: HIVE-22329 > URL: https://issues.apache.org/jira/browse/HIVE-22329 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22329.01.patch, HIVE-22329.02.patch, > HIVE-22329.03.patch, HIVE-22329.04.patch > > Time Spent: 20m > Remaining Estimate: 0h > > The current DriverContext class is not really a context, rather a queue, thus > it should be renamed to DriverQueue. At the same time Driver has a a lot of > fields, they should be in a real context class called DriverContext, which > would also facilitate the extraction of independent parts of the Driver class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22311) Propagate min/max column values from statistics to the optimizer for timestamp type
[
https://issues.apache.org/jira/browse/HIVE-22311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955111#comment-16955111
]
Hive QA commented on HIVE-22311:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
40s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
35s{color} | {color:blue} standalone-metastore/metastore-common in master has
37 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
12s{color} | {color:blue} standalone-metastore/metastore-server in master has
170 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
3s{color} | {color:blue} ql in master has 1548 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
20s{color} | {color:red} standalone-metastore/metastore-server: The patch
generated 25 new + 109 unchanged - 11 fixed = 134 total (was 120) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
44s{color} | {color:red} ql: The patch generated 15 new + 280 unchanged - 2
fixed = 295 total (was 282) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
21s{color} | {color:red} standalone-metastore/metastore-server generated 2 new
+ 170 unchanged - 0 fixed = 172 total (was 170) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
15s{color} | {color:red} ql generated 1 new + 1548 unchanged - 0 fixed = 1549
total (was 1548) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
23s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
16s{color} | {color:red} The patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 41m 31s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
| | Integral division result cast to double or float in
org.apache.hadoop.hive.metastore.columnstats.aggr.TimestampColumnStatsAggregator.aggregate(List,
List, boolean) At TimestampColumnStatsAggregator.java:double or float in
org.apache.hadoop.hive.metastore.columnstats.aggr.TimestampColumnStatsAggregator.aggregate(List,
List, boolean) At TimestampColumnStatsAggregator.java:[line 104] |
| |
org.apache.hadoop.hive.metastore.columnstats.cache.TimestampColumnStatsDataInspector
doesn't override
org.apache.hadoop.hive.metastore.api.TimestampColumnStatsData.equals(Object)
At TimestampColumnStatsDataInspector.java:At
TimestampColumnStatsDataInspector.java:[line 1] |
| FindBugs | module:ql |
| | Dead store to uniformWithinRange in
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$JoinStatsRule.process(Node,
Stack, NodeProcessorCtx, Object[]) At
StatsRulesProcFactory.java:org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$JoinStatsRule.process(Node,
Stack, NodeProcessorCtx, Object[]) At StatsRulesProcFactory.java:[line
[jira] [Commented] (HIVE-21365) Refactor Hep planner steps in CBO
[
https://issues.apache.org/jira/browse/HIVE-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955102#comment-16955102
]
Hive QA commented on HIVE-21365:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983473/HIVE-21365.06.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17545 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[hybridgrace_hashjoin_2]
(batchId=111)
org.apache.hadoop.hive.metastore.TestPartitionManagement.testPartitionDiscoveryTransactionalTable
(batchId=223)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19064/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19064/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19064/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983473 - PreCommit-HIVE-Build
> Refactor Hep planner steps in CBO
> -
>
> Key: HIVE-21365
> URL: https://issues.apache.org/jira/browse/HIVE-21365
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21365.01.patch, HIVE-21365.01.patch,
> HIVE-21365.02.patch, HIVE-21365.03.patch, HIVE-21365.03.patch,
> HIVE-21365.04.patch, HIVE-21365.05.patch, HIVE-21365.06.patch,
> HIVE-21365.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Using subprograms to decrease number of planner instantiations and benefit
> fully from metadata providers caching, among other benefits.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
