[jira] [Commented] (HIVE-15675) ql.hooks.TestQueryHooks failure
[ https://issues.apache.org/jira/browse/HIVE-15675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852521#comment-15852521 ] Jun He commented on HIVE-15675: --- Thanks [~aihuaxu], [~pvary] > ql.hooks.TestQueryHooks failure > --- > > Key: HIVE-15675 > URL: https://issues.apache.org/jira/browse/HIVE-15675 > Project: Hive > Issue Type: Bug > Components: Tests >Reporter: Jun He >Assignee: Jun He > Fix For: 2.2.0 > > Attachments: HIVE-15675.0.patch, HIVE-15675.1.patch, > HIVE-15675.2.patch > > > ql.parse.TestQBCompact creates table "foo" in initialization but doesn't > clean it after its testcases are finished. This will cause > ql.hooks.TestQueryHooks::testCompileFailure failed as testCompileFailure > expects that "foo" doesn't exist. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15675) ql.hooks.TestQueryHooks failure
[ https://issues.apache.org/jira/browse/HIVE-15675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851551#comment-15851551 ] Aihua Xu commented on HIVE-15675: - The change makes sense. Pushed to master. Thanks Jun for the work and Peter for reviewing. > ql.hooks.TestQueryHooks failure > --- > > Key: HIVE-15675 > URL: https://issues.apache.org/jira/browse/HIVE-15675 > Project: Hive > Issue Type: Bug > Components: Tests >Reporter: Jun He >Assignee: Jun He > Fix For: 2.2.0 > > Attachments: HIVE-15675.0.patch, HIVE-15675.1.patch, > HIVE-15675.2.patch > > > ql.parse.TestQBCompact creates table "foo" in initialization but doesn't > clean it after its testcases are finished. This will cause > ql.hooks.TestQueryHooks::testCompileFailure failed as testCompileFailure > expects that "foo" doesn't exist. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15675) ql.hooks.TestQueryHooks failure
[ https://issues.apache.org/jira/browse/HIVE-15675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850946#comment-15850946 ] Jun He commented on HIVE-15675: --- The failures are not related. Thanks for [~pvary] for reviewing. [~aihuaxu], could you pls help to commit to master? Thanks. > ql.hooks.TestQueryHooks failure > --- > > Key: HIVE-15675 > URL: https://issues.apache.org/jira/browse/HIVE-15675 > Project: Hive > Issue Type: Bug > Components: Tests >Reporter: Jun He >Assignee: Jun He > Attachments: HIVE-15675.0.patch, HIVE-15675.1.patch, > HIVE-15675.2.patch > > > ql.parse.TestQBCompact creates table "foo" in initialization but doesn't > clean it after its testcases are finished. This will cause > ql.hooks.TestQueryHooks::testCompileFailure failed as testCompileFailure > expects that "foo" doesn't exist. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15675) ql.hooks.TestQueryHooks failure
[
https://issues.apache.org/jira/browse/HIVE-15675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832864#comment-15832864
]
Hive QA commented on HIVE-15675:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12848485/HIVE-15675.0.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 10974 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=235)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
(batchId=159)
org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver[cascade_dbdrop]
(batchId=226)
org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver[generatehfiles_require_family_path]
(batchId=226)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic]
(batchId=135)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part]
(batchId=149)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_char_simple]
(batchId=147)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3089/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3089/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3089/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12848485 - PreCommit-HIVE-Build
> ql.hooks.TestQueryHooks failure
> ---
>
> Key: HIVE-15675
> URL: https://issues.apache.org/jira/browse/HIVE-15675
> Project: Hive
> Issue Type: Bug
> Components: Tests
>Reporter: Jun He
>Assignee: Jun He
> Attachments: HIVE-15675.0.patch
>
>
> ql.parse.TestQBCompact creates table "foo" in initialization but doesn't
> clean it after its testcases are finished. This will cause
> ql.hooks.TestQueryHooks::testCompileFailure failed as testCompileFailure
> expects that "foo" doesn't exist.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15675) ql.hooks.TestQueryHooks failure
[
https://issues.apache.org/jira/browse/HIVE-15675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831885#comment-15831885
]
Peter Vary commented on HIVE-15675:
---
[~jun.he]: Thanks for finding this issue! The patch looks good to me. Just some
minor nits:
- The table could be deleted with h.dropTable("foo"), and the partitions will
be deleted automatically
- There should be a newline between the end of the init method, and before the
deInit method to adhere the coding conventions
(https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-CodingConventions)
Otherwise the patch looks good to me.
Thanks,
Peter
> ql.hooks.TestQueryHooks failure
> ---
>
> Key: HIVE-15675
> URL: https://issues.apache.org/jira/browse/HIVE-15675
> Project: Hive
> Issue Type: Bug
> Components: Tests
>Reporter: Jun He
>Assignee: Jun He
> Attachments: HIVE-15675.0.patch
>
>
> ql.parse.TestQBCompact creates table "foo" in initialization but doesn't
> clean it after its testcases are finished. This will cause
> ql.hooks.TestQueryHooks::testCompileFailure failed as testCompileFailure
> expects that "foo" doesn't exist.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15675) ql.hooks.TestQueryHooks failure
[ https://issues.apache.org/jira/browse/HIVE-15675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831340#comment-15831340 ] Jun He commented on HIVE-15675: --- A patch is uploaded to fix it. Please review and comment. Thanks > ql.hooks.TestQueryHooks failure > --- > > Key: HIVE-15675 > URL: https://issues.apache.org/jira/browse/HIVE-15675 > Project: Hive > Issue Type: Bug > Components: Tests >Reporter: Jun He >Assignee: Jun He > Attachments: HIVE-15675.0.patch > > > ql.parse.TestQBCompact creates table "foo" in initialization but doesn't > clean it after its testcases are finished. This will cause > ql.hooks.TestQueryHooks::testCompileFailure failed as testCompileFailure > expects that "foo" doesn't exist. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
