[jira] [Commented] (HIVE-17979) Tez: Improve ReduceRecordSource passDownKey copying
[ https://issues.apache.org/jira/browse/HIVE-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585033#comment-16585033 ] Hive QA commented on HIVE-17979: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12936177/HIVE-17979.4.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14885 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13336/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13336/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13336/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12936177 - PreCommit-HIVE-Build > Tez: Improve ReduceRecordSource passDownKey copying > --- > > Key: HIVE-17979 > URL: https://issues.apache.org/jira/browse/HIVE-17979 > Project: Hive > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-17979.1.patch, HIVE-17979.2.patch, > HIVE-17979.3.patch, HIVE-17979.4.patch > > > Tez does not use a single Key stream for both sides of the join, so each > input gets its own ReduceRecordSource > {code} > sources[tag] = new ReduceRecordSource(); > {code} > And this means for each input stream, there's a deserialized key (because the > tag is not part of the Key byte stream), this means for a 2-table join there > are 2 ReduceRecordSource objects. > This means that the passDownKey is only an optimization when the Key, > List has more than 1 value in it. Otherwise the copy is entirely > wasted CPU cycles, because it deserializes the entire row to extract the key > and discards the row. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-17979) Tez: Improve ReduceRecordSource passDownKey copying
[ https://issues.apache.org/jira/browse/HIVE-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585027#comment-16585027 ] Hive QA commented on HIVE-17979: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 44s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 10s{color} | {color:blue} ql in master has 2307 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 40s{color} | {color:red} ql: The patch generated 1 new + 136 unchanged - 0 fixed = 137 total (was 136) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 25m 3s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13336/dev-support/hive-personality.sh | | git revision | master / 0f772ed | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13336/yetus/diff-checkstyle-ql.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-13336/yetus/whitespace-eol.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13336/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Tez: Improve ReduceRecordSource passDownKey copying > --- > > Key: HIVE-17979 > URL: https://issues.apache.org/jira/browse/HIVE-17979 > Project: Hive > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-17979.1.patch, HIVE-17979.2.patch, > HIVE-17979.3.patch, HIVE-17979.4.patch > > > Tez does not use a single Key stream for both sides of the join, so each > input gets its own ReduceRecordSource > {code} > sources[tag] = new ReduceRecordSource(); > {code} > And this means for each input stream, there's a deserialized key (because the > tag is not part of the Key byte stream), this means for a 2-table join there > are 2 ReduceRecordSource objects. > This means that the passDownKey is only an optimization when the Key, > List has more than 1 value in it. Otherwise the copy is entirely > wasted CPU cycles, because it deserializes the entire row to extract the key > and discards the row. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-17979) Tez: Improve ReduceRecordSource passDownKey copying
[ https://issues.apache.org/jira/browse/HIVE-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585005#comment-16585005 ] Hive QA commented on HIVE-17979: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12936170/HIVE-17979.3.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13334/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13334/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13334/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12936170/HIVE-17979.3.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12936170 - PreCommit-HIVE-Build > Tez: Improve ReduceRecordSource passDownKey copying > --- > > Key: HIVE-17979 > URL: https://issues.apache.org/jira/browse/HIVE-17979 > Project: Hive > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-17979.1.patch, HIVE-17979.2.patch, > HIVE-17979.3.patch > > > Tez does not use a single Key stream for both sides of the join, so each > input gets its own ReduceRecordSource > {code} > sources[tag] = new ReduceRecordSource(); > {code} > And this means for each input stream, there's a deserialized key (because the > tag is not part of the Key byte stream), this means for a 2-table join there > are 2 ReduceRecordSource objects. > This means that the passDownKey is only an optimization when the Key, > List has more than 1 value in it. Otherwise the copy is entirely > wasted CPU cycles, because it deserializes the entire row to extract the key > and discards the row. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-17979) Tez: Improve ReduceRecordSource passDownKey copying
[ https://issues.apache.org/jira/browse/HIVE-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584950#comment-16584950 ] Hive QA commented on HIVE-17979: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12936170/HIVE-17979.3.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14885 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_test1] (batchId=194) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13330/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13330/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13330/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12936170 - PreCommit-HIVE-Build > Tez: Improve ReduceRecordSource passDownKey copying > --- > > Key: HIVE-17979 > URL: https://issues.apache.org/jira/browse/HIVE-17979 > Project: Hive > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-17979.1.patch, HIVE-17979.2.patch, > HIVE-17979.3.patch > > > Tez does not use a single Key stream for both sides of the join, so each > input gets its own ReduceRecordSource > {code} > sources[tag] = new ReduceRecordSource(); > {code} > And this means for each input stream, there's a deserialized key (because the > tag is not part of the Key byte stream), this means for a 2-table join there > are 2 ReduceRecordSource objects. > This means that the passDownKey is only an optimization when the Key, > List has more than 1 value in it. Otherwise the copy is entirely > wasted CPU cycles, because it deserializes the entire row to extract the key > and discards the row. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-17979) Tez: Improve ReduceRecordSource passDownKey copying
[ https://issues.apache.org/jira/browse/HIVE-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584941#comment-16584941 ] Hive QA commented on HIVE-17979: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 23s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 9s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 45s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 6s{color} | {color:blue} ql in master has 2307 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 42s{color} | {color:red} ql: The patch generated 1 new + 136 unchanged - 0 fixed = 137 total (was 136) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 25m 2s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13330/dev-support/hive-personality.sh | | git revision | master / 0f772ed | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13330/yetus/diff-checkstyle-ql.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-13330/yetus/whitespace-eol.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13330/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Tez: Improve ReduceRecordSource passDownKey copying > --- > > Key: HIVE-17979 > URL: https://issues.apache.org/jira/browse/HIVE-17979 > Project: Hive > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-17979.1.patch, HIVE-17979.2.patch, > HIVE-17979.3.patch > > > Tez does not use a single Key stream for both sides of the join, so each > input gets its own ReduceRecordSource > {code} > sources[tag] = new ReduceRecordSource(); > {code} > And this means for each input stream, there's a deserialized key (because the > tag is not part of the Key byte stream), this means for a 2-table join there > are 2 ReduceRecordSource objects. > This means that the passDownKey is only an optimization when the Key, > List has more than 1 value in it. Otherwise the copy is entirely > wasted CPU cycles, because it deserializes the entire row to extract the key > and discards the row. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-17979) Tez: Improve ReduceRecordSource passDownKey copying
[ https://issues.apache.org/jira/browse/HIVE-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584924#comment-16584924 ] Hive QA commented on HIVE-17979: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12896290/HIVE-17979.2.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13329/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13329/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13329/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12896290/HIVE-17979.2.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12896290 - PreCommit-HIVE-Build > Tez: Improve ReduceRecordSource passDownKey copying > --- > > Key: HIVE-17979 > URL: https://issues.apache.org/jira/browse/HIVE-17979 > Project: Hive > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-17979.1.patch, HIVE-17979.2.patch > > > Tez does not use a single Key stream for both sides of the join, so each > input gets its own ReduceRecordSource > {code} > sources[tag] = new ReduceRecordSource(); > {code} > And this means for each input stream, there's a deserialized key (because the > tag is not part of the Key byte stream), this means for a 2-table join there > are 2 ReduceRecordSource objects. > This means that the passDownKey is only an optimization when the Key, > List has more than 1 value in it. Otherwise the copy is entirely > wasted CPU cycles, because it deserializes the entire row to extract the key > and discards the row. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-17979) Tez: Improve ReduceRecordSource passDownKey copying
[ https://issues.apache.org/jira/browse/HIVE-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584695#comment-16584695 ] Hive QA commented on HIVE-17979: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12896290/HIVE-17979.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 14880 tests executed *Failed tests:* {noformat} TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=193) [druidmini_dynamic_partition.q,druidmini_test_ts.q,druidmini_expressions.q,druidmini_test_alter.q,druidmini_test_insert.q] org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[udf_coalesce] (batchId=179) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13321/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13321/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13321/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12896290 - PreCommit-HIVE-Build > Tez: Improve ReduceRecordSource passDownKey copying > --- > > Key: HIVE-17979 > URL: https://issues.apache.org/jira/browse/HIVE-17979 > Project: Hive > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-17979.1.patch, HIVE-17979.2.patch > > > Tez does not use a single Key stream for both sides of the join, so each > input gets its own ReduceRecordSource > {code} > sources[tag] = new ReduceRecordSource(); > {code} > And this means for each input stream, there's a deserialized key (because the > tag is not part of the Key byte stream), this means for a 2-table join there > are 2 ReduceRecordSource objects. > This means that the passDownKey is only an optimization when the Key, > List has more than 1 value in it. Otherwise the copy is entirely > wasted CPU cycles, because it deserializes the entire row to extract the key > and discards the row. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-17979) Tez: Improve ReduceRecordSource passDownKey copying
[ https://issues.apache.org/jira/browse/HIVE-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584687#comment-16584687 ] Hive QA commented on HIVE-17979: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 17s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 7s{color} | {color:blue} ql in master has 2307 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 41s{color} | {color:red} ql: The patch generated 1 new + 136 unchanged - 0 fixed = 137 total (was 136) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 38s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13321/dev-support/hive-personality.sh | | git revision | master / e57b52b | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13321/yetus/diff-checkstyle-ql.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-13321/yetus/whitespace-eol.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13321/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Tez: Improve ReduceRecordSource passDownKey copying > --- > > Key: HIVE-17979 > URL: https://issues.apache.org/jira/browse/HIVE-17979 > Project: Hive > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-17979.1.patch, HIVE-17979.2.patch > > > Tez does not use a single Key stream for both sides of the join, so each > input gets its own ReduceRecordSource > {code} > sources[tag] = new ReduceRecordSource(); > {code} > And this means for each input stream, there's a deserialized key (because the > tag is not part of the Key byte stream), this means for a 2-table join there > are 2 ReduceRecordSource objects. > This means that the passDownKey is only an optimization when the Key, > List has more than 1 value in it. Otherwise the copy is entirely > wasted CPU cycles, because it deserializes the entire row to extract the key > and discards the row. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-17979) Tez: Improve ReduceRecordSource passDownKey copying
[ https://issues.apache.org/jira/browse/HIVE-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569013#comment-16569013 ] Hive QA commented on HIVE-17979: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12896290/HIVE-17979.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14859 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.llap.security.TestLlapSignerImpl.testSigning (batchId=322) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13034/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13034/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13034/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12896290 - PreCommit-HIVE-Build > Tez: Improve ReduceRecordSource passDownKey copying > --- > > Key: HIVE-17979 > URL: https://issues.apache.org/jira/browse/HIVE-17979 > Project: Hive > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-17979.1.patch, HIVE-17979.2.patch > > > Tez does not use a single Key stream for both sides of the join, so each > input gets its own ReduceRecordSource > {code} > sources[tag] = new ReduceRecordSource(); > {code} > And this means for each input stream, there's a deserialized key (because the > tag is not part of the Key byte stream), this means for a 2-table join there > are 2 ReduceRecordSource objects. > This means that the passDownKey is only an optimization when the Key, > List has more than 1 value in it. Otherwise the copy is entirely > wasted CPU cycles, because it deserializes the entire row to extract the key > and discards the row. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-17979) Tez: Improve ReduceRecordSource passDownKey copying
[ https://issues.apache.org/jira/browse/HIVE-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568990#comment-16568990 ] Hive QA commented on HIVE-17979: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 18s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 16s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 44s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 17s{color} | {color:blue} ql in master has 2301 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 45s{color} | {color:red} ql: The patch generated 1 new + 136 unchanged - 0 fixed = 137 total (was 136) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 26m 58s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13034/dev-support/hive-personality.sh | | git revision | master / ce2754d | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13034/yetus/diff-checkstyle-ql.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-13034/yetus/whitespace-eol.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13034/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Tez: Improve ReduceRecordSource passDownKey copying > --- > > Key: HIVE-17979 > URL: https://issues.apache.org/jira/browse/HIVE-17979 > Project: Hive > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-17979.1.patch, HIVE-17979.2.patch > > > Tez does not use a single Key stream for both sides of the join, so each > input gets its own ReduceRecordSource > {code} > sources[tag] = new ReduceRecordSource(); > {code} > And this means for each input stream, there's a deserialized key (because the > tag is not part of the Key byte stream), this means for a 2-table join there > are 2 ReduceRecordSource objects. > This means that the passDownKey is only an optimization when the Key, > List has more than 1 value in it. Otherwise the copy is entirely > wasted CPU cycles, because it deserializes the entire row to extract the key > and discards the row. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-17979) Tez: Improve ReduceRecordSource passDownKey copying
[ https://issues.apache.org/jira/browse/HIVE-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241714#comment-16241714 ] Hive QA commented on HIVE-17979: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12896290/HIVE-17979.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 11366 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=62) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=156) org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc] (batchId=94) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi] (batchId=111) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14] (batchId=243) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query23] (batchId=243) org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=206) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanQpChanges (batchId=281) org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7675/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7675/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7675/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 9 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12896290 - PreCommit-HIVE-Build > Tez: Improve ReduceRecordSource passDownKey copying > --- > > Key: HIVE-17979 > URL: https://issues.apache.org/jira/browse/HIVE-17979 > Project: Hive > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V > Attachments: HIVE-17979.1.patch, HIVE-17979.2.patch > > > Tez does not use a single Key stream for both sides of the join, so each > input gets its own ReduceRecordSource > {code} > sources[tag] = new ReduceRecordSource(); > {code} > And this means for each input stream, there's a deserialized key (because the > tag is not part of the Key byte stream), this means for a 2-table join there > are 2 ReduceRecordSource objects. > This means that the passDownKey is only an optimization when the Key, > List has more than 1 value in it. Otherwise the copy is entirely > wasted CPU cycles, because it deserializes the entire row to extract the key > and discards the row. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17979) Tez: Improve ReduceRecordSource passDownKey copying
[ https://issues.apache.org/jira/browse/HIVE-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239061#comment-16239061 ] Hive QA commented on HIVE-17979: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12895984/HIVE-17979.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 19 failed/errored test(s), 11354 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=62) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast] (batchId=157) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=156) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_dynamic_partition_pruning_2] (batchId=175) org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc] (batchId=94) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi] (batchId=111) org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=206) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAmPoolInteractions (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanQpChanges (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanUserMapping (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAsyncSessionInitFailures (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testClusterFractions (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testDestroyAndReturn (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testQueueing (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReopen (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuse (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuseWithDifferentPool (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuseWithQueueing (batchId=281) org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7637/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7637/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7637/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 19 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12895984 - PreCommit-HIVE-Build > Tez: Improve ReduceRecordSource passDownKey copying > --- > > Key: HIVE-17979 > URL: https://issues.apache.org/jira/browse/HIVE-17979 > Project: Hive > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-17979.1.patch > > > Tez does not use a single Key stream for both sides of the join, so each > input gets its own ReduceRecordSource > {code} > sources[tag] = new ReduceRecordSource(); > {code} > And this means for each input stream, there's a deserialized key (because the > tag is not part of the Key byte stream), this means for a 2-table join there > are 2 ReduceRecordSource objects. > This means that the passDownKey is only an optimization when the Key, > List has more than 1 value in it. Otherwise the copy is entirely > wasted CPU cycles, because it deserializes the entire row to extract the key > and discards the row. -- This message was sent by Atlassian JIRA (v6.4.14#64029)