[jira] [Commented] (HIVE-20365) Fix warnings when regenerating thrift code
[ https://issues.apache.org/jira/browse/HIVE-20365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634552#comment-16634552 ] Vihang Karajgaonkar commented on HIVE-20365: Looks like HIVE-20293 already fixed this. > Fix warnings when regenerating thrift code > -- > > Key: HIVE-20365 > URL: https://issues.apache.org/jira/browse/HIVE-20365 > Project: Hive > Issue Type: Bug >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-20365.01.patch > > > When you build thrift code you can see thrift warning like below. > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167] > No field key specified for rqst, resulting protocol may have conflicts or > not be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235] > No field key specified for o2, resulting protocol may have conflicts or not > be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167] > No field key specified for rqst, resulting protocol may have conflicts or > not be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235] > No field key specified for o2, resulting protocol may have conflicts or not > be backwards compatible! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20365) Fix warnings when regenerating thrift code
[ https://issues.apache.org/jira/browse/HIVE-20365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632655#comment-16632655 ] Andrew Sherman commented on HIVE-20365: --- One day we will have to really deal with wire format compatibility. As St Augustine said "Lord, make me pure – but not yet!”. +1 LGTM > Fix warnings when regenerating thrift code > -- > > Key: HIVE-20365 > URL: https://issues.apache.org/jira/browse/HIVE-20365 > Project: Hive > Issue Type: Bug >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-20365.01.patch > > > When you build thrift code you can see thrift warning like below. > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167] > No field key specified for rqst, resulting protocol may have conflicts or > not be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235] > No field key specified for o2, resulting protocol may have conflicts or not > be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167] > No field key specified for rqst, resulting protocol may have conflicts or > not be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235] > No field key specified for o2, resulting protocol may have conflicts or not > be backwards compatible! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20365) Fix warnings when regenerating thrift code
[ https://issues.apache.org/jira/browse/HIVE-20365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632606#comment-16632606 ] Vihang Karajgaonkar commented on HIVE-20365: Was out for a while. Picking this up again.. [~asherman] Do you still have concerns? Looks like the API is not yet fully ready and hence it is very unlikely that it is being used in branch-3. Either ways I think we can commit it in 4.0 > Fix warnings when regenerating thrift code > -- > > Key: HIVE-20365 > URL: https://issues.apache.org/jira/browse/HIVE-20365 > Project: Hive > Issue Type: Bug >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-20365.01.patch > > > When you build thrift code you can see thrift warning like below. > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167] > No field key specified for rqst, resulting protocol may have conflicts or > not be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235] > No field key specified for o2, resulting protocol may have conflicts or not > be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167] > No field key specified for rqst, resulting protocol may have conflicts or > not be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235] > No field key specified for o2, resulting protocol may have conflicts or not > be backwards compatible! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20365) Fix warnings when regenerating thrift code
[ https://issues.apache.org/jira/browse/HIVE-20365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596526#comment-16596526 ] Alan Gates commented on HIVE-20365: --- It's fine to change this in 3. AFAIK no one is using the ischema calls yet as the rest of the tasks under HIVE-17989 aren't yet finished. > Fix warnings when regenerating thrift code > -- > > Key: HIVE-20365 > URL: https://issues.apache.org/jira/browse/HIVE-20365 > Project: Hive > Issue Type: Bug >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-20365.01.patch > > > When you build thrift code you can see thrift warning like below. > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167] > No field key specified for rqst, resulting protocol may have conflicts or > not be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235] > No field key specified for o2, resulting protocol may have conflicts or not > be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167] > No field key specified for rqst, resulting protocol may have conflicts or > not be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235] > No field key specified for o2, resulting protocol may have conflicts or not > be backwards compatible! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20365) Fix warnings when regenerating thrift code
[ https://issues.apache.org/jira/browse/HIVE-20365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594436#comment-16594436 ] Vihang Karajgaonkar commented on HIVE-20365: [~asherman] mentioned that this might break wire compatibility. I tried keeping it at -1 but thrift doesn't like non-positive numbers for fieldIds. May be we can just fix it in 4.0 branch. [~alangates] I think this was introduced in HIVE-17990? Do you think its okay to change it now to get rid of the warnings? or should we just limit the change to 4.0? > Fix warnings when regenerating thrift code > -- > > Key: HIVE-20365 > URL: https://issues.apache.org/jira/browse/HIVE-20365 > Project: Hive > Issue Type: Bug >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-20365.01.patch > > > When you build thrift code you can see thrift warning like below. > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167] > No field key specified for rqst, resulting protocol may have conflicts or > not be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235] > No field key specified for o2, resulting protocol may have conflicts or not > be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167] > No field key specified for rqst, resulting protocol may have conflicts or > not be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235] > No field key specified for o2, resulting protocol may have conflicts or not > be backwards compatible! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20365) Fix warnings when regenerating thrift code
[ https://issues.apache.org/jira/browse/HIVE-20365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594300#comment-16594300 ] Vihang Karajgaonkar commented on HIVE-20365: Hi [~asherman] Can you please take a look? > Fix warnings when regenerating thrift code > -- > > Key: HIVE-20365 > URL: https://issues.apache.org/jira/browse/HIVE-20365 > Project: Hive > Issue Type: Bug >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-20365.01.patch > > > When you build thrift code you can see thrift warning like below. > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167] > No field key specified for rqst, resulting protocol may have conflicts or > not be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235] > No field key specified for o2, resulting protocol may have conflicts or not > be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167] > No field key specified for rqst, resulting protocol may have conflicts or > not be backwards compatible! > [exec] > [exec] > [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235] > No field key specified for o2, resulting protocol may have conflicts or not > be backwards compatible! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20365) Fix warnings when regenerating thrift code
[
https://issues.apache.org/jira/browse/HIVE-20365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592494#comment-16592494
]
Hive QA commented on HIVE-20365:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12937087/HIVE-20365.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14896 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13462/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13462/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13462/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12937087 - PreCommit-HIVE-Build
> Fix warnings when regenerating thrift code
> --
>
> Key: HIVE-20365
> URL: https://issues.apache.org/jira/browse/HIVE-20365
> Project: Hive
> Issue Type: Bug
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Major
> Attachments: HIVE-20365.01.patch
>
>
> When you build thrift code you can see thrift warning like below.
> [exec]
> [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167]
> No field key specified for rqst, resulting protocol may have conflicts or
> not be backwards compatible!
> [exec]
> [exec]
> [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235]
> No field key specified for o2, resulting protocol may have conflicts or not
> be backwards compatible!
> [exec]
> [exec]
> [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167]
> No field key specified for rqst, resulting protocol may have conflicts or
> not be backwards compatible!
> [exec]
> [exec]
> [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235]
> No field key specified for o2, resulting protocol may have conflicts or not
> be backwards compatible!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20365) Fix warnings when regenerating thrift code
[
https://issues.apache.org/jira/browse/HIVE-20365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592480#comment-16592480
]
Hive QA commented on HIVE-20365:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
6s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
25s{color} | {color:blue} standalone-metastore/metastore-common in master has 9
extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 21s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13462/dev-support/hive-personality.sh
|
| git revision | master / b5578eb |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: standalone-metastore/metastore-common U:
standalone-metastore/metastore-common |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13462/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Fix warnings when regenerating thrift code
> --
>
> Key: HIVE-20365
> URL: https://issues.apache.org/jira/browse/HIVE-20365
> Project: Hive
> Issue Type: Bug
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Major
> Attachments: HIVE-20365.01.patch
>
>
> When you build thrift code you can see thrift warning like below.
> [exec]
> [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167]
> No field key specified for rqst, resulting protocol may have conflicts or
> not be backwards compatible!
> [exec]
> [exec]
> [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235]
> No field key specified for o2, resulting protocol may have conflicts or not
> be backwards compatible!
> [exec]
> [exec]
> [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167]
> No field key specified for rqst, resulting protocol may have conflicts or
> not be backwards compatible!
> [exec]
> [exec]
> [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235]
> No field key specified for o2, resulting protocol may have conflicts or not
> be backwards compatible!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
