[jira] [Comment Edited] (IGNITE-11708) Unable to run tests in IgniteConfigVariationsAbstractTest subclasses
[ https://issues.apache.org/jira/browse/IGNITE-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855917#comment-16855917 ] Ivan Fedotov edited comment on IGNITE-11708 at 6/4/19 5:42 PM: --- [~Pavlukhin], I fixed some moments after TC results: * added ConfigVariationsExecutionTest to testSuite [1] * ignored cache test in MVCC [2] * make dummyCfg non-static: since testCfg already is not static, now static dummyCfg is not necessary [3]. TC Bot gives me 2 blockers: code style and .Net Inspections, but both of them have a lot of recent failures (76 and 37 % respectively) [4]. [1] https://github.com/apache/ignite/pull/6434/commits/62ac5a64b8489ea5d16cd27487f284ee248aa2f3#diff-e36adf615dfcc36775e2edd132042b4aR234 [2] https://github.com/apache/ignite/pull/6434/commits/62ac5a64b8489ea5d16cd27487f284ee248aa2f3#diff-1cf9dd56dece1e687eada1c9cbc3388eR91 [3] https://github.com/apache/ignite/pull/6434/commits/62ac5a64b8489ea5d16cd27487f284ee248aa2f3#diff-cd3a07ce10f21d396c1eac0c328850e0L376 [4] https://mtcga.gridgain.com/pr.html?serverId=apache=IgniteTests24Java8_RunAllNightly=pull/6434/head=Latest was (Author: ivanan.fed): [~Pavlukhin], I fixed some moments after TC results: * added ConfigVariationsExecutionTest to testSuite [1] * ignored cache test in MVCC [2] * make dummyCfg non-static: science testCfg already is not static, now static dummyCfg is not necessary [3]. TC Bot gives me 2 blockers: code style and .Net Inspections, but both of them have a lot of recent failures (76 and 37 % respectively) [4]. [1] https://github.com/apache/ignite/pull/6434/commits/62ac5a64b8489ea5d16cd27487f284ee248aa2f3#diff-e36adf615dfcc36775e2edd132042b4aR234 [2] https://github.com/apache/ignite/pull/6434/commits/62ac5a64b8489ea5d16cd27487f284ee248aa2f3#diff-1cf9dd56dece1e687eada1c9cbc3388eR91 [3] https://github.com/apache/ignite/pull/6434/commits/62ac5a64b8489ea5d16cd27487f284ee248aa2f3#diff-cd3a07ce10f21d396c1eac0c328850e0L376 [4] https://mtcga.gridgain.com/pr.html?serverId=apache=IgniteTests24Java8_RunAllNightly=pull/6434/head=Latest > Unable to run tests in IgniteConfigVariationsAbstractTest subclasses > > > Key: IGNITE-11708 > URL: https://issues.apache.org/jira/browse/IGNITE-11708 > Project: Ignite > Issue Type: Bug >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep30 > Attachments: read_through_eviction_self_test.patch, > tx_out_test_fixed.patch > > Time Spent: 3h 50m > Remaining Estimate: 0h > > It seems that test classes that extend from > IgniteConfigVariationsAbstractTest cannot be started with JUnit4 @Test > annotation. > It is easy to check: if throw exception in any test methods, nothing will > happen. > Reason can be in rule chain in IgniteConfigVariationsAbstractTest class [1], > maybe it destroys existing test workflow. > [1] > https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java#L62 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-11708) Unable to run tests in IgniteConfigVariationsAbstractTest subclasses
[ https://issues.apache.org/jira/browse/IGNITE-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850028#comment-16850028 ] Ivan Fedotov edited comment on IGNITE-11708 at 5/28/19 6:44 PM: [~Pavlukhin], I removed the garbage injection and left only one non-static cfg variable. Moreover, I assigned configuration directly before each test (and beforeTestsStarted method) with reflection instead of injectTestsConfiguration method invocation [1]. I think now it looks better and without unnecessary actions. Also, I removed double stopAllGrids (I don't know why it's necessary to invoke it twice - because of this Cache tests were broken) [2]. I checked RunAllNightly and new failures seem for me from the first view not because of test workflow, but because of real reasons. Could you take a look at such solution, please? [1]https://github.com/apache/ignite/pull/6434/files#diff-3da5dbb6f22e5bf3bf18734933f1bfc5R434 [2] https://github.com/apache/ignite/pull/6434/files#diff-cd3a07ce10f21d396c1eac0c328850e0L179 was (Author: ivanan.fed): [~Pavlukhin], I removed the garbage injection and left only one non-static cfg variable. Moreover, I assigned configuration directly before each test (and beforeTestsStarted method) with reflection instead of injectTestsConfiguration method invocation [1]. I think now it looks better and without unnecessary actions. Also, I removed double stopAllGrids (I don't know why it's necessary to invoke it twice - because of this Cache tests were broken) [2]. I checked RunAllNightly and new failures seem for me from the first view not because of test workflow, but because of real reasons. Could you take a look at such solution, please? [1]https://github.com/apache/ignite/pull/6434/files#diff-3da5dbb6f22e5bf3bf18734933f1bfc5R434 [2] https://github.com/apache/ignite/pull/6434/files#diff-cd3a07ce10f21d396c1eac0c328850e0L179 > Unable to run tests in IgniteConfigVariationsAbstractTest subclasses > > > Key: IGNITE-11708 > URL: https://issues.apache.org/jira/browse/IGNITE-11708 > Project: Ignite > Issue Type: Bug >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep30 > Attachments: read_through_eviction_self_test.patch, > tx_out_test_fixed.patch > > Time Spent: 3h 20m > Remaining Estimate: 0h > > It seems that test classes that extend from > IgniteConfigVariationsAbstractTest cannot be started with JUnit4 @Test > annotation. > It is easy to check: if throw exception in any test methods, nothing will > happen. > Reason can be in rule chain in IgniteConfigVariationsAbstractTest class [1], > maybe it destroys existing test workflow. > [1] > https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java#L62 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-11708) Unable to run tests in IgniteConfigVariationsAbstractTest subclasses
[ https://issues.apache.org/jira/browse/IGNITE-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845953#comment-16845953 ] Ivan Fedotov edited comment on IGNITE-11708 at 5/22/19 3:01 PM: [~Pavlukhin] , I run TC with the latest changes, it seems not good now [1]. The problem is in NPE in IgniteCacheConfigVariationsAbstractTest#beforeTest [2]. With default VariationsTestsConfig all works fine, it is clear from the previous TC results. But when we use injected config, default ignite instance does not create - ignite() method returns null [3]. I think that the problem is in makeTestClass method when configs are injected [4]. For some reason, configs are not correct or are not correct injected. But this reason is unclear for me now. [1][https://ci.ignite.apache.org/viewLog.html?buildId=3911405=IgniteTests24Java8_RunAllNightly] [2] [https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteCacheConfigVariationsAbstractTest.java#L204] [3] [https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteCacheConfigVariationsAbstractTest.java#L469] [4] [https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/configvariations/ConfigVariationsTestSuiteBuilder.java#L434] was (Author: ivanan.fed): [~Pavlukhin] , I run TC with the latest changes, it seems not good now [1]. The problem is in NPE in IgniteCacheConfigVariationsAbstractTest#beforeTest [2]. With default VariationsTestsConfig all works fine, it is clear from the previous TC results. But when we use injected config, default ignite instance does not create - ignite() method returns null [3]. I think that the problem is in makeTestClass method when configs are injected. For some reason, configs are not correct or are not correct injected. But this reason is unclear for me now. [1][https://ci.ignite.apache.org/viewLog.html?buildId=3911405=IgniteTests24Java8_RunAllNightly] [2] [https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteCacheConfigVariationsAbstractTest.java#L204] [3] [https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteCacheConfigVariationsAbstractTest.java#L469] [4] [https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/configvariations/ConfigVariationsTestSuiteBuilder.java#L434] > Unable to run tests in IgniteConfigVariationsAbstractTest subclasses > > > Key: IGNITE-11708 > URL: https://issues.apache.org/jira/browse/IGNITE-11708 > Project: Ignite > Issue Type: Bug >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep30 > Attachments: read_through_eviction_self_test.patch, > tx_out_test_fixed.patch > > Time Spent: 3h 20m > Remaining Estimate: 0h > > It seems that test classes that extend from > IgniteConfigVariationsAbstractTest cannot be started with JUnit4 @Test > annotation. > It is easy to check: if throw exception in any test methods, nothing will > happen. > Reason can be in rule chain in IgniteConfigVariationsAbstractTest class [1], > maybe it destroys existing test workflow. > [1] > https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java#L62 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-11708) Unable to run tests in IgniteConfigVariationsAbstractTest subclasses
[
https://issues.apache.org/jira/browse/IGNITE-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818759#comment-16818759
]
Ivan Fedotov edited comment on IGNITE-11708 at 4/16/19 12:26 PM:
-
[~Pavlukhin], I added test for check {{IgniteConfigVariationsAbstractTest}}
execution according to your suggestions. May be add similar check that
before/after JUnit methods also work, what do you think?
According to fix {{IgniteConfigVariationsAbstractTest}} rules workflow. I
decided to simplify code and remove outer rule and ruleChain from
{{IgniteConfigVariationsAbstractTest}} [1]. We can implement the same idea if
we just put {{testCfg}} initilization in {{beforeTestsStarted}}. Now all tests
work - you can try to start
{{InterceptorCacheConfigVariationsFullApiTestSuite}} [2] and see that methods
work indeed (it takes time unlike the master branch).
But now TeamCity bot shows us a lot of failures [3]. I tried to figure out and
it seems that failures are related to what tests check, but not JUnit error. I
mean that in master tests are green just because nothing happens, but indeed
tests can fail. I can not figure out in each test quickly, but in nutshell,
according to logs the failures are caused errors in tests functionality.
Moreover, 450 failures on 15_000 tests are just 3%, so it could be true.
[1] [https://github.com/apache/ignite/pull/6434/files]
[2]
[https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testsuites/InterceptorCacheConfigVariationsFullApiTestSuite.java]
[3]
[https://mtcga.gridgain.com/pr.html?serverId=apache=IgniteTests24Java8_RunAll=pull/6434/head=Latest]
was (Author: ivanan.fed):
[~Pavlukhin], I added test for check {{IgniteConfigVariationsAbstractTest}}
execution according to your suggestions. May be add similar check that
before/after JUnit methods also work, what do you think?
According to fix {{IgniteConfigVariationsAbstractTest}} rules workflow. I
decided to simplify code and remove outer rule and ruleChain from
{{IgniteConfigVariationsAbstractTest}} [1]. We can implement the same idea if
we just put {{testCfg}} initilization in {{beforeTestsStarted}}. Now all tests
work - you can try to start
{{InterceptorCacheConfigVariationsFullApiTestSuite}} [2] and see that methods
work indeed (it takes time unlike the master branch).
But now TeamCity bot shows us a lot of failures [3]. I tried to figure out and
it seems that failures are related to what tests check, but not JUnit error. I
mean that in master tests are green just because nothing happens, but indeed
tests can fail. I can not figure out in each tests quickly, but in nutshell,
according to logs the failures are caused errors in tests functionality.
Moreover, 450 failures on 15_000 tests are just 3%, so it could be true.
[1] [https://github.com/apache/ignite/pull/6434/files]
[2]
[https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testsuites/InterceptorCacheConfigVariationsFullApiTestSuite.java]
[3]
[https://mtcga.gridgain.com/pr.html?serverId=apache=IgniteTests24Java8_RunAll=pull/6434/head=Latest]
> Unable to run tests in IgniteConfigVariationsAbstractTest subclasses
>
>
> Key: IGNITE-11708
> URL: https://issues.apache.org/jira/browse/IGNITE-11708
> Project: Ignite
> Issue Type: Bug
>Reporter: Ivan Fedotov
>Assignee: Ivan Fedotov
>Priority: Major
> Labels: iep30
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It seems that test classes that extend from
> IgniteConfigVariationsAbstractTest cannot be started with JUnit4 @Test
> annotation.
> It is easy to check: if throw exception in any test methods, nothing will
> happen.
> Reason can be in rule chain in IgniteConfigVariationsAbstractTest class [1],
> maybe it destroys existing test workflow.
> [1]
> https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java#L62
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-11708) Unable to run tests in IgniteConfigVariationsAbstractTest subclasses
[
https://issues.apache.org/jira/browse/IGNITE-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818759#comment-16818759
]
Ivan Fedotov edited comment on IGNITE-11708 at 4/16/19 8:23 AM:
[~Pavlukhin], I added test for check {{IgniteConfigVariationsAbstractTest}}
execution according to your suggestions. May be add similar check that
before/after JUnit methods also work, what do you think?
According to fix {{IgniteConfigVariationsAbstractTest}} rules workflow. I
decided to simplify code and remove outer rule and ruleChain from
{{IgniteConfigVariationsAbstractTest}} [1]. We can implement the same idea if
we just put {{testCfg}} initilization in {{beforeTestsStarted}}. Now all tests
work - you can try to start
{{InterceptorCacheConfigVariationsFullApiTestSuite}} [2] and see that methods
work indeed (it takes time unlike the master branch).
But now TeamCity bot shows us a lot of failures [3]. I tried to figure out and
it seems that failures are related to what tests check, but not JUnit error. I
mean that in master tests are green just because nothing happens, but indeed
tests can fail. I can not figure out in each tests quickly, but in nutshell,
according to logs the failures are caused errors in tests functionality.
Moreover, 450 failures on 15_000 tests are just 3%, so it could be true.
[1] [https://github.com/apache/ignite/pull/6434/files]
[2]
[https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testsuites/InterceptorCacheConfigVariationsFullApiTestSuite.java]
[3]
[https://mtcga.gridgain.com/pr.html?serverId=apache=IgniteTests24Java8_RunAll=pull/6434/head=Latest]
was (Author: ivanan.fed):
[~Pavlukhin], I added test for check {{IgniteConfigVariationsAbstractTest}}
execution according to your suggestions. May be add similar check that
before/after JUnit methods also work, what do you think?
According to fix {{IgniteConfigVariationsAbstractTest}} rules workflow. I
decided to simplify code and remove outer rule and ruleChain from
{{IgniteConfigVariationsAbstractTest}} [1]. We can implement the same idea if
we just put {{testCfg}} initilization in {{beforeTestsStarted}}. Now all tests
work - you can try to start
{{InterceptorCacheConfigVariationsFullApiTestSuite}} [2] and see that methods
work indeed (it takes time unlike the master branch).
But now TeamCity bot shows us a lot of failures [3]. I tried to figure out and
it seems that failures are related to what tests check, but not JUnit error. I
mean that in master tests are green just because nothing happens, but indeed
tests can fail. I can not figure out in each tests quickly, but in nutshell,
according to logs the failures are caused errors in tests functionality.
Moreover, 300 failures on 15_000 tests are just 2%, so it could be true.
[1] https://github.com/apache/ignite/pull/6434
[2]
https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testsuites/InterceptorCacheConfigVariationsFullApiTestSuite.java
[3]
https://mtcga.gridgain.com/pr.html?serverId=apache=IgniteTests24Java8_RunAll=pull/6434/head=Latest
> Unable to run tests in IgniteConfigVariationsAbstractTest subclasses
>
>
> Key: IGNITE-11708
> URL: https://issues.apache.org/jira/browse/IGNITE-11708
> Project: Ignite
> Issue Type: Bug
>Reporter: Ivan Fedotov
>Assignee: Ivan Fedotov
>Priority: Major
> Labels: iep30
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It seems that test classes that extend from
> IgniteConfigVariationsAbstractTest cannot be started with JUnit4 @Test
> annotation.
> It is easy to check: if throw exception in any test methods, nothing will
> happen.
> Reason can be in rule chain in IgniteConfigVariationsAbstractTest class [1],
> maybe it destroys existing test workflow.
> [1]
> https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java#L62
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
