[jira] [Commented] (IGNITE-3196) Marshaling works wrong for the BigDecimals that have negative scale
[
https://issues.apache.org/jira/browse/IGNITE-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198795#comment-16198795
]
ASF GitHub Bot commented on IGNITE-3196:
Github user alamar closed the pull request at:
https://github.com/apache/ignite/pull/2484
> Marshaling works wrong for the BigDecimals that have negative scale
> ---
>
> Key: IGNITE-3196
> URL: https://issues.apache.org/jira/browse/IGNITE-3196
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Vyacheslav Daradur
> Fix For: 2.0
>
>
> Current marshalling procedure of the {{BigDecimal}} assumes that the scale of
> the {{BigDecimal}} value is always more than or equal to zero. However, scale
> [can be
> negative|https://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html#scale()].
> This leads to invalid results if we try to marshal-unmarshal {{BigDecimal}}
> that has a negative scale.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-3196) Marshaling works wrong for the BigDecimals that have negative scale
[ https://issues.apache.org/jira/browse/IGNITE-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133071#comment-16133071 ] ASF GitHub Bot commented on IGNITE-3196: GitHub user alamar reopened a pull request: https://github.com/apache/ignite/pull/2484 Backport IGNITE-3196 Add support for BigDecimals with negative scale in BinaryMarshaller You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-1.7.15 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/2484.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2484 commit a62a0136d295486d95c6e2ab5bba88270d831753 Author: dkarachentsev Date: 2016-11-02T16:07:45Z GG-11655 - Fix merge commit 348593986b56ddfcec4a4455e49d9b279eae4dc8 Author: devozerov Date: 2016-11-05T10:28:03Z Merge branch 'ignite-1.7.3' into ignite-1.7.4 commit 175da6b7e394dd76c27d5155ff98a5b2ef03bb9d Author: tledkov-gridgain Date: 2016-11-07T06:16:58Z IGNITE-3432: check data/meta cache names are different for different IGFS instances. This closes #1201 commit ead15193899d08f41491166003cabed0560f0c59 Author: Pavel Tupitsyn Date: 2016-11-07T07:49:03Z IGNITE-4028 Get rid of OP_META in PlatformAbstractTarget This closes #1192 commit 40ef2f5ae42826fe8fd077e3013e8f55c8512bdd Author: Dmitriy Govorukhin Date: 2016-11-07T09:09:41Z ignite-4178 support permission builder commit df670c7d64046d282c053f296c47a4743c58c8b1 Author: Pavel Tupitsyn Date: 2016-11-07T09:40:00Z IGNITE-4118 .NET: Optimistic transaction example This closes #1200 commit 474f22fda4c7cf4d7b2623c451cd7c10f0d8c636 Author: Pavel Tupitsyn Date: 2016-11-07T09:55:20Z IGNITE-4119 .NET: add TransactionDeadlockException commit fc7ce5a4d72145f2e8a86debeda264ef0a5b37e3 Author: isapego Date: 2016-11-07T10:26:05Z IGNITE-4090: Added flags so stdint and limits can be used in C++. commit a98804a249496ba9bafbc96daa7aaf25b3d36724 Author: Igor Sapego Date: 2016-11-07T11:00:00Z IGNITE-4113: Added tests. Added Statement::Set/GetAttribute. commit b1c7c9bb95c900083702d0ba0362edf3aea5a7b4 Author: sboikov Date: 2016-11-07T12:40:36Z GG-11360 - Implement SQL queries cancellation Fix for commit 80abd1b: for distributed joins need always send cancel request. commit 319014de075c80fb15e58172cc24e35ce16b56cf Author: Pavel Tupitsyn Date: 2016-11-07T14:53:40Z IGNITE-4132 .NET: Improve BinaryConfiguration documentation commit 950bad474ef29f9b808e74034c49a69d57eb2740 Author: dkarachentsev Date: 2016-11-08T11:03:34Z GG-11655 - Restore service compatibility with releases before 1.5.30. commit 3d19bfc2b66574e3945ce17c7a4dfe77d0070b8d Author: dkarachentsev Date: 2016-11-08T11:04:36Z Merge remote-tracking branch 'origin/ignite-1.6.11' into ignite-1.6.11 commit 1612b6d66fed032182a41e90da71e6b986ae087b Author: Pavel Tupitsyn Date: 2016-11-08T11:07:54Z .NET: Fix minor analysis warnings commit e821dc0083003bc81058b1cb223d8a8a2ee44daf Author: Dmitriy Govorukhin Date: 2016-11-08T12:09:21Z IGNITE-2079 (revert commit) GridCacheIoManager eats exception trail if it falls into the directed case commit c2c82ca44befe4570325dd6cf2ba885e0d90596c Author: Dmitriy Govorukhin Date: 2016-11-08T12:10:10Z Merge remote-tracking branch 'professional/ignite-1.6.11' into ignite-1.6.11 commit 865bbcf0f41a0c4944e0928f1758d43a0eae82c5 Author: Dmitriy Govorukhin Date: 2016-11-08T12:18:29Z Revert "Merge remote-tracking branch 'professional/ignite-1.6.11' into ignite-1.6.11" This reverts commit c2c82ca44befe4570325dd6cf2ba885e0d90596c, reversing changes made to e821dc0083003bc81058b1cb223d8a8a2ee44daf. commit 9726421ff9efb2b19813b2fd6ad27a3728b5ab1a Author: Dmitriy Govorukhin Date: 2016-11-08T12:59:00Z Revert Revert Merge remote-tracking branch 'professional/ignite-1.6.11' commit 5a3a1960fff1dcf32961c45c0ba5149d6748d2fc Author: Igor Sapego Date: 2016-11-08T14:36:35Z Added license header. commit f697fb5786fb4ce15f581c465ff0dcb3d2bb7b14 Author: Pavel Tupitsyn Date: 2016-11-08T16:13:48Z IGNITE-4185 .NET: Fix NullReferenceException in IgniteOutputCacheProvider when igniteConfiguration is missing commit 69487f2c375010737311af65750a519b403fc17f Author: Pavel Tupitsyn Date: 2016-11-08T16:38:28Z .NET: Fix error messages when IgniteConfigurationSection content is missing commit d88f422aeb02738d676d86ce416551b805ad154e Author: Andrey Novikov Date: 2016-11-09T07:25:38Z GG-11028 Fixed resolving of host name. commit ac660dcaa5bf8eb20e7dd4e442e97c1cf548a827 Author: Igor Sapego Date: 2016-11-09T12:29:06Z IGNITE-4183: ODBC Fixed null
[jira] [Commented] (IGNITE-3196) Marshaling works wrong for the BigDecimals that have negative scale
[
https://issues.apache.org/jira/browse/IGNITE-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133067#comment-16133067
]
ASF GitHub Bot commented on IGNITE-3196:
Github user alamar closed the pull request at:
https://github.com/apache/ignite/pull/2484
> Marshaling works wrong for the BigDecimals that have negative scale
> ---
>
> Key: IGNITE-3196
> URL: https://issues.apache.org/jira/browse/IGNITE-3196
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Vyacheslav Daradur
> Fix For: 2.0
>
>
> Current marshalling procedure of the {{BigDecimal}} assumes that the scale of
> the {{BigDecimal}} value is always more than or equal to zero. However, scale
> [can be
> negative|https://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html#scale()].
> This leads to invalid results if we try to marshal-unmarshal {{BigDecimal}}
> that has a negative scale.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-3196) Marshaling works wrong for the BigDecimals that have negative scale
[
https://issues.apache.org/jira/browse/IGNITE-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133038#comment-16133038
]
ASF GitHub Bot commented on IGNITE-3196:
Github user alamar closed the pull request at:
https://github.com/apache/ignite/pull/2485
> Marshaling works wrong for the BigDecimals that have negative scale
> ---
>
> Key: IGNITE-3196
> URL: https://issues.apache.org/jira/browse/IGNITE-3196
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Vyacheslav Daradur
> Fix For: 2.0
>
>
> Current marshalling procedure of the {{BigDecimal}} assumes that the scale of
> the {{BigDecimal}} value is always more than or equal to zero. However, scale
> [can be
> negative|https://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html#scale()].
> This leads to invalid results if we try to marshal-unmarshal {{BigDecimal}}
> that has a negative scale.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-3196) Marshaling works wrong for the BigDecimals that have negative scale
[ https://issues.apache.org/jira/browse/IGNITE-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133037#comment-16133037 ] ASF GitHub Bot commented on IGNITE-3196: GitHub user alamar opened a pull request: https://github.com/apache/ignite/pull/2485 Backport IGNITE-3196 support for BigDecimals with negative scale in BinaryMarshaller You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-1.9.6 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/2485.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2485 commit bb3ff120e6995431d10439243d8b163712de0e0e Author: dkarachentsev Date: 2017-04-10T08:40:17Z IGNITE-2466 - Disable back-pressure for sender data nodes to avoid deadlock. (cherry picked from commit ba6227b) commit 960e454b4b68c76ed94ca58a3ee9a9d8e79c2039 Author: dkarachentsev Date: 2017-04-10T07:28:15Z IGNITE-2466 - Use current NIO back pressure mechanism to limit received messages. Mark them process only when backups acknowledged. (cherry picked from commit 220db88) commit 207ccaa1ff5a021a25dc779b5b2d7bfdb0f3b647 Author: dkarachentsev Date: 2017-04-10T08:40:17Z IGNITE-2466 - Disable back-pressure for sender data nodes to avoid deadlock. (cherry picked from commit ba6227b) (cherry picked from commit bb3ff12) commit 5fbbc37669bcf0557a98d8ab70c3dbb79ebcd340 Author: Andrey V. Mashenkov Date: 2017-04-05T12:01:02Z IGNITE-4917: Fixed failure when accessing BinaryObjectBuilder field value serialized with OptimizedMarshaller . This closes #1736. (cherry picked from commit b8e3d1b) commit 315ff38eeef96f12954d6ff39c84d58b2b959667 Author: Andrey V. Mashenkov Date: 2017-04-06T11:43:50Z IGNITE-4879: Fixed System pool starvation while partition evicting. commit 89e9dbe484312c251f02c9fbe9698c3ac2e03df8 Author: Alexander Fedotov Date: 2017-04-10T13:36:33Z Fix org.apache.ignite.internal.processors.cache.expiry .IgniteCacheExpiryPolicyAbstractTest#testNearExpiresWithCacheStore commit 01ceeb13420b68edf12b0262fe0991e84c085dd8 Author: Andrey V. Mashenkov Date: 2017-04-06T11:43:50Z IGNITE-4863: Disallow change RootLogger log-level if it can have negative effect on other loggers. This closes #1687. commit 02b194268071b179d291b28472cef5d587e7558a Author: Alexander Fedotov Date: 2017-04-11T09:00:59Z Fix missing test resource directory for org.apache.ignite.spi.discovery.tcp .TcpDiscoveryNodeAttributesUpdateOnReconnectTest.testReconnect commit 20016a20f780eb3c21f249d3cb74d08018c4eea5 Author: Alexander Fedotov Date: 2017-04-11T11:54:06Z Fix org.apache.ignite.internal.processors.cache.expiry .IgniteCacheExpiryPolicyAbstractTest#testNearExpiresWithCacheStore commit 6d12bd4b9fbded5e5862b5c3d89b05a5ddd11755 Author: Igor Sapego Date: 2017-03-21T14:54:51Z IGNITE-4200: Added copying of the C++ binaries. (cherry picked from commit 8b3860f) commit 0f7ef74216fab64f5d1d2b6d432b552b7fe40d2f Author: Andrey V. Mashenkov Date: 2017-04-12T10:01:25Z IGNITE-4907: Fixed excessive service instances can be started with dynamic deployment. This closes #1766. commit 465084da5b00dcfc056d338f5d0a24875ca2af08 Author: Andrey V. Mashenkov Date: 2017-04-12T10:01:25Z IGNITE-4907: Fixed excessive service instances can be started with dynamic deployment. This closes #1766. (cherry picked from commit 0f7ef74) commit a20c307df1dd000309a273ef93231fdc41a2a81c Author: dkarachentsev Date: 2017-04-13T06:31:17Z IGNITE-4891 - Fix. Key is deserialized during transactional get() even if withKeepBinary is set (Backport from master) commit 630558dfeb373f237057e394e8f2f63230d59dab Author: vladisav Date: 2017-04-13T10:24:42Z ignite-4173 IgniteSemaphore with failoverSafe enabled doesn't release permits in case permits owner node left topology Backport from master. (cherry picked from commit 76485fc) commit 870b752c095ed3776e91a65b99763142b9f2ebc0 Author: Vladisav Jelisavcic Date: 2017-04-11T11:09:12Z ignite-1977 - fixed IgniteSemaphore fault tolerance. Backport from master. (cherry picked from commit 902bf42) commit cd0b92950c6691c6fc1a26cb4f7e55f5ee459298 Author: Yakov Zhdanov Date: 2017-04-13T12:52:20Z ignite-4946 GridCacheP2PUndeploySelfTest became failed (cherry picked from commit d298e75) commit 241e9291dbe43138be1c027a3d8d1b7e3ed9b4dd Author: dkarachentsev Date: 2017-04-14T06:36:10Z Merge branch 'ignite-1.9.1-p1' into ignite-1.9.2 commit 405ce563fb7c35627c6e1bb0b68f423ba089c6f2 Author: Dmitriy Shabalin Date: 2017-04-14T1
[jira] [Commented] (IGNITE-3196) Marshaling works wrong for the BigDecimals that have negative scale
[ https://issues.apache.org/jira/browse/IGNITE-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133022#comment-16133022 ] ASF GitHub Bot commented on IGNITE-3196: GitHub user alamar opened a pull request: https://github.com/apache/ignite/pull/2484 Backport IGNITE-3196 Add support for BigDecimals with negative scale in BinaryMarshaller You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-1.7.15 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/2484.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2484 commit a62a0136d295486d95c6e2ab5bba88270d831753 Author: dkarachentsev Date: 2016-11-02T16:07:45Z GG-11655 - Fix merge commit 348593986b56ddfcec4a4455e49d9b279eae4dc8 Author: devozerov Date: 2016-11-05T10:28:03Z Merge branch 'ignite-1.7.3' into ignite-1.7.4 commit 175da6b7e394dd76c27d5155ff98a5b2ef03bb9d Author: tledkov-gridgain Date: 2016-11-07T06:16:58Z IGNITE-3432: check data/meta cache names are different for different IGFS instances. This closes #1201 commit ead15193899d08f41491166003cabed0560f0c59 Author: Pavel Tupitsyn Date: 2016-11-07T07:49:03Z IGNITE-4028 Get rid of OP_META in PlatformAbstractTarget This closes #1192 commit 40ef2f5ae42826fe8fd077e3013e8f55c8512bdd Author: Dmitriy Govorukhin Date: 2016-11-07T09:09:41Z ignite-4178 support permission builder commit df670c7d64046d282c053f296c47a4743c58c8b1 Author: Pavel Tupitsyn Date: 2016-11-07T09:40:00Z IGNITE-4118 .NET: Optimistic transaction example This closes #1200 commit 474f22fda4c7cf4d7b2623c451cd7c10f0d8c636 Author: Pavel Tupitsyn Date: 2016-11-07T09:55:20Z IGNITE-4119 .NET: add TransactionDeadlockException commit fc7ce5a4d72145f2e8a86debeda264ef0a5b37e3 Author: isapego Date: 2016-11-07T10:26:05Z IGNITE-4090: Added flags so stdint and limits can be used in C++. commit a98804a249496ba9bafbc96daa7aaf25b3d36724 Author: Igor Sapego Date: 2016-11-07T11:00:00Z IGNITE-4113: Added tests. Added Statement::Set/GetAttribute. commit b1c7c9bb95c900083702d0ba0362edf3aea5a7b4 Author: sboikov Date: 2016-11-07T12:40:36Z GG-11360 - Implement SQL queries cancellation Fix for commit 80abd1b: for distributed joins need always send cancel request. commit 319014de075c80fb15e58172cc24e35ce16b56cf Author: Pavel Tupitsyn Date: 2016-11-07T14:53:40Z IGNITE-4132 .NET: Improve BinaryConfiguration documentation commit 950bad474ef29f9b808e74034c49a69d57eb2740 Author: dkarachentsev Date: 2016-11-08T11:03:34Z GG-11655 - Restore service compatibility with releases before 1.5.30. commit 3d19bfc2b66574e3945ce17c7a4dfe77d0070b8d Author: dkarachentsev Date: 2016-11-08T11:04:36Z Merge remote-tracking branch 'origin/ignite-1.6.11' into ignite-1.6.11 commit 1612b6d66fed032182a41e90da71e6b986ae087b Author: Pavel Tupitsyn Date: 2016-11-08T11:07:54Z .NET: Fix minor analysis warnings commit e821dc0083003bc81058b1cb223d8a8a2ee44daf Author: Dmitriy Govorukhin Date: 2016-11-08T12:09:21Z IGNITE-2079 (revert commit) GridCacheIoManager eats exception trail if it falls into the directed case commit c2c82ca44befe4570325dd6cf2ba885e0d90596c Author: Dmitriy Govorukhin Date: 2016-11-08T12:10:10Z Merge remote-tracking branch 'professional/ignite-1.6.11' into ignite-1.6.11 commit 865bbcf0f41a0c4944e0928f1758d43a0eae82c5 Author: Dmitriy Govorukhin Date: 2016-11-08T12:18:29Z Revert "Merge remote-tracking branch 'professional/ignite-1.6.11' into ignite-1.6.11" This reverts commit c2c82ca44befe4570325dd6cf2ba885e0d90596c, reversing changes made to e821dc0083003bc81058b1cb223d8a8a2ee44daf. commit 9726421ff9efb2b19813b2fd6ad27a3728b5ab1a Author: Dmitriy Govorukhin Date: 2016-11-08T12:59:00Z Revert Revert Merge remote-tracking branch 'professional/ignite-1.6.11' commit 5a3a1960fff1dcf32961c45c0ba5149d6748d2fc Author: Igor Sapego Date: 2016-11-08T14:36:35Z Added license header. commit f697fb5786fb4ce15f581c465ff0dcb3d2bb7b14 Author: Pavel Tupitsyn Date: 2016-11-08T16:13:48Z IGNITE-4185 .NET: Fix NullReferenceException in IgniteOutputCacheProvider when igniteConfiguration is missing commit 69487f2c375010737311af65750a519b403fc17f Author: Pavel Tupitsyn Date: 2016-11-08T16:38:28Z .NET: Fix error messages when IgniteConfigurationSection content is missing commit d88f422aeb02738d676d86ce416551b805ad154e Author: Andrey Novikov Date: 2016-11-09T07:25:38Z GG-11028 Fixed resolving of host name. commit ac660dcaa5bf8eb20e7dd4e442e97c1cf548a827 Author: Igor Sapego Date: 2016-11-09T12:29:06Z IGNITE-4183: ODBC Fixed null-v
[jira] [Commented] (IGNITE-3196) Marshaling works wrong for the BigDecimals that have negative scale
[
https://issues.apache.org/jira/browse/IGNITE-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861429#comment-15861429
]
ASF GitHub Bot commented on IGNITE-3196:
Github user daradurvs closed the pull request at:
https://github.com/apache/ignite/pull/1473
> Marshaling works wrong for the BigDecimals that have negative scale
> ---
>
> Key: IGNITE-3196
> URL: https://issues.apache.org/jira/browse/IGNITE-3196
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Vyacheslav Daradur
> Fix For: 2.0
>
>
> Current marshalling procedure of the {{BigDecimal}} assumes that the scale of
> the {{BigDecimal}} value is always more than or equal to zero. However, scale
> [can be
> negative|https://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html#scale()].
> This leads to invalid results if we try to marshal-unmarshal {{BigDecimal}}
> that has a negative scale.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-3196) Marshaling works wrong for the BigDecimals that have negative scale
[
https://issues.apache.org/jira/browse/IGNITE-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861296#comment-15861296
]
Pavel Tupitsyn commented on IGNITE-3196:
Added .NET test, works as expected (throws exception on negative scale value).
Merged to ignite-2.0.
> Marshaling works wrong for the BigDecimals that have negative scale
> ---
>
> Key: IGNITE-3196
> URL: https://issues.apache.org/jira/browse/IGNITE-3196
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Vyacheslav Daradur
> Fix For: 2.0
>
>
> Current marshalling procedure of the {{BigDecimal}} assumes that the scale of
> the {{BigDecimal}} value is always more than or equal to zero. However, scale
> [can be
> negative|https://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html#scale()].
> This leads to invalid results if we try to marshal-unmarshal {{BigDecimal}}
> that has a negative scale.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-3196) Marshaling works wrong for the BigDecimals that have negative scale
[
https://issues.apache.org/jira/browse/IGNITE-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861248#comment-15861248
]
Vladimir Ozerov commented on IGNITE-3196:
-
Changes looks good to me. Though, it would be useful to have negative test in
.NET ensuring that exception is thrown as expected.
[~ptupitsyn], how difficult would be to have such test?
> Marshaling works wrong for the BigDecimals that have negative scale
> ---
>
> Key: IGNITE-3196
> URL: https://issues.apache.org/jira/browse/IGNITE-3196
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Vyacheslav Daradur
> Fix For: 2.0
>
>
> Current marshalling procedure of the {{BigDecimal}} assumes that the scale of
> the {{BigDecimal}} value is always more than or equal to zero. However, scale
> [can be
> negative|https://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html#scale()].
> This leads to invalid results if we try to marshal-unmarshal {{BigDecimal}}
> that has a negative scale.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-3196) Marshaling works wrong for the BigDecimals that have negative scale
[
https://issues.apache.org/jira/browse/IGNITE-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853796#comment-15853796
]
Pavel Tupitsyn commented on IGNITE-3196:
.NET changes look good to me.
> Marshaling works wrong for the BigDecimals that have negative scale
> ---
>
> Key: IGNITE-3196
> URL: https://issues.apache.org/jira/browse/IGNITE-3196
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Vyacheslav Daradur
> Fix For: 2.0
>
>
> Current marshalling procedure of the {{BigDecimal}} assumes that the scale of
> the {{BigDecimal}} value is always more than or equal to zero. However, scale
> [can be
> negative|https://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html#scale()].
> This leads to invalid results if we try to marshal-unmarshal {{BigDecimal}}
> that has a negative scale.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-3196) Marshaling works wrong for the BigDecimals that have negative scale
[
https://issues.apache.org/jira/browse/IGNITE-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15842927#comment-15842927
]
ASF GitHub Bot commented on IGNITE-3196:
GitHub user daradurvs opened a pull request:
https://github.com/apache/ignite/pull/1473
IGNITE-3196
We shouldn't check sign at serialization, because the used approach:
BigInteger intVal = val.unscaledValue();
byte[] vals = intVal.toByteArray();
#toByteArray() - already including at least one sign bit, which is
(ceil((this.bitLength() + 1)/8)). (This representation is compatible with the
(byte[]) constructor.)
Therefore, at deserialization we just read byte[] vals and scale, also we
use default constructor which will define a sign from byte[] vals.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daradurvs/ignite ignite-3196
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/1473.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1473
commit 48fab04f4a8b48a1f6ff0a632d56075c855b62e5
Author: daradurvs
Date: 2017-01-26T17:21:01Z
ignite-3196: serialization of BigDecimal is simplified
commit 91327c3797fb1ea8702cf8e2ce34998819c0c8c9
Author: daradurvs
Date: 2017-01-27T09:50:32Z
ignite-3196: fix old serialization method (it is better, serialized object
has the smaller size)
commit f3d2297d9db4e773003eeea800ae37843ce79f14
Author: daradurvs
Date: 2017-01-27T11:48:53Z
ignite-3196: "negative scale with RoundingMode" tests are added
> Marshaling works wrong for the BigDecimals that have negative scale
> ---
>
> Key: IGNITE-3196
> URL: https://issues.apache.org/jira/browse/IGNITE-3196
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Vyacheslav Daradur
> Fix For: 2.0
>
>
> Current marshalling procedure of the {{BigDecimal}} assumes that the scale of
> the {{BigDecimal}} value is always more than or equal to zero. However, scale
> [can be
> negative|https://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html#scale()].
> This leads to invalid results if we try to marshal-unmarshal {{BigDecimal}}
> that has a negative scale.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
