[jira] [Commented] (IGNITE-5328) Support cache atomicity mode for CREATE TABLE
[
https://issues.apache.org/jira/browse/IGNITE-5328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034610#comment-16034610
]
ASF GitHub Bot commented on IGNITE-5328:
Github user asfgit closed the pull request at:
https://github.com/apache/ignite/pull/2054
> Support cache atomicity mode for CREATE TABLE
> -
>
> Key: IGNITE-5328
> URL: https://issues.apache.org/jira/browse/IGNITE-5328
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Alexander Paschenko
> Fix For: 2.1
>
>
> Users should be able to set atomicity mode through "WITH" synthax.
> Property name: {{atomicityMode}}
> Allowed values (case insensitive): {{atomic}}, {{transactional}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-5328) Support cache atomicity mode for CREATE TABLE
[
https://issues.apache.org/jira/browse/IGNITE-5328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033019#comment-16033019
]
Vladimir Ozerov commented on IGNITE-5328:
-
Need to fix outstanding test failures.
> Support cache atomicity mode for CREATE TABLE
> -
>
> Key: IGNITE-5328
> URL: https://issues.apache.org/jira/browse/IGNITE-5328
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Alexander Paschenko
> Fix For: 2.1
>
>
> Users should be able to set atomicity mode through "WITH" synthax.
> Property name: {{atomicityMode}}
> Allowed values (case insensitive): {{atomic}}, {{transactional}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-5328) Support cache atomicity mode for CREATE TABLE
[
https://issues.apache.org/jira/browse/IGNITE-5328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032896#comment-16032896
]
Vladimir Ozerov commented on IGNITE-5328:
-
Let's also make sure that we support both syntax forms:
1) {{"template=REPLICATED", "backups=1"}}
2) {{"template=REPLICATED, backups=1"}}
> Support cache atomicity mode for CREATE TABLE
> -
>
> Key: IGNITE-5328
> URL: https://issues.apache.org/jira/browse/IGNITE-5328
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Alexander Paschenko
> Fix For: 2.1
>
>
> Users should be able to set atomicity mode through "WITH" synthax.
> Property name: {{atomicityMode}}
> Allowed values (case insensitive): {{atomic}}, {{transactional}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-5328) Support cache atomicity mode for CREATE TABLE
[
https://issues.apache.org/jira/browse/IGNITE-5328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032884#comment-16032884
]
Vladimir Ozerov commented on IGNITE-5328:
-
[~al.psc], my comments:
1) {{parseEnumParam}} - let's remove this method, and perform parsing directly
in {{processExtraParam}}. If failed we should throw exception with allowed
values. We should not sey anything about Java classes in the message.
2) Now I see many test with various cases and spaces for {{backups}}, but I do
not see a single test for {{backups=1}}.
> Support cache atomicity mode for CREATE TABLE
> -
>
> Key: IGNITE-5328
> URL: https://issues.apache.org/jira/browse/IGNITE-5328
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Alexander Paschenko
> Fix For: 2.1
>
>
> Users should be able to set atomicity mode through "WITH" synthax.
> Property name: {{atomicityMode}}
> Allowed values (case insensitive): {{atomic}}, {{transactional}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-5328) Support cache atomicity mode for CREATE TABLE
[
https://issues.apache.org/jira/browse/IGNITE-5328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032758#comment-16032758
]
Vladimir Ozerov commented on IGNITE-5328:
-
[~al.psc], I did some minor changes, please merge them first.
> Support cache atomicity mode for CREATE TABLE
> -
>
> Key: IGNITE-5328
> URL: https://issues.apache.org/jira/browse/IGNITE-5328
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Alexander Paschenko
> Fix For: 2.1
>
>
> Users should be able to set atomicity mode through "WITH" synthax.
> Property name: {{atomicityMode}}
> Allowed values (case insensitive): {{atomic}}, {{transactional}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-5328) Support cache atomicity mode for CREATE TABLE
[
https://issues.apache.org/jira/browse/IGNITE-5328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032757#comment-16032757
]
Vladimir Ozerov commented on IGNITE-5328:
-
[~al.psc], my comments:
1) {{GridSqlQueryParser.parseCreateTable}} - please confirm that both
{{backups=1}} and {{backups = 1}} will work, as I do not see calls to
String.trim(). We need tests for this.
2) No "param" abbreviation in error messages. "parameter" should be used
3) Please make sure that error message follows our conventions: it should be
either "GENERAL_CAUSE (OPTIONAL_SPECIFICATION): SINGLE_PARAM" or "GENERAL_CAUSE
(OPTIONAL_SPECIFICATION) \[param1=val1, param2=val2, ...\]". E.g.:
{code}
throw new IgniteSQLException("Invalid param syntax (key[=value] expected): " +
p);
{code}
4) {{GridSqlQueryParser.processExtraParam}} - {{backups=}} should raise
exception. Will that happen in current implementation? Same question for
atomicity.
5) {{GridSqlQueryParser}}: {{parseIntParam}} and {{parseEnumParam}} should
throw {{PARSING}} exception.
6) Lets rename "cacheTemplate" parameter to "template".
7) Negative backups number should raise an exception.
> Support cache atomicity mode for CREATE TABLE
> -
>
> Key: IGNITE-5328
> URL: https://issues.apache.org/jira/browse/IGNITE-5328
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Alexander Paschenko
> Fix For: 2.1
>
>
> Users should be able to set atomicity mode through "WITH" synthax.
> Property name: {{atomicityMode}}
> Allowed values (case insensitive): {{atomic}}, {{transactional}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-5328) Support cache atomicity mode for CREATE TABLE
[
https://issues.apache.org/jira/browse/IGNITE-5328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032328#comment-16032328
]
ASF GitHub Bot commented on IGNITE-5328:
GitHub user alexpaschenko opened a pull request:
https://github.com/apache/ignite/pull/2054
IGNITE-5328 Added CREATE TABLE params
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-5328
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/2054.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2054
commit 3ad4fa125cad7ff1ae782f17d7a32c5e3ca5ad9a
Author: Alexander Paschenko
Date: 2017-06-01T02:09:44Z
IGNITE-5328 Added CREATE TABLE params for backups number and atomicity mode.
> Support cache atomicity mode for CREATE TABLE
> -
>
> Key: IGNITE-5328
> URL: https://issues.apache.org/jira/browse/IGNITE-5328
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Alexander Paschenko
> Fix For: 2.1
>
>
> Users should be able to set atomicity mode through "WITH" synthax.
> Property name: {{atomicityMode}}
> Allowed values (case insensitive): {{atomic}}, {{transactional}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
