[jira] [Commented] (IGNITE-5899) Thin client: cache.Get for primitives

[Vladimir Ozerov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145517#comment-16145517
 ] 

Vladimir Ozerov commented on IGNITE-5899:
-

[~ptupitsyn], LGTM.

> Thin client: cache.Get for primitives
> -
>
> Key: IGNITE-5899
> URL: https://issues.apache.org/jira/browse/IGNITE-5899
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Implement {{cache.Get}} for primitive data types via thin client protocol.
> This will include:
> * New client type in {{SqlListenerNioListener}}
> * {{PlatformRequestHandler implements SqlListenerRequestHandler}}, 
> {{PlatformMessageParser implements SqlListenerMessageParser}}
> * Integration test in .NET (just because .NET is the first platform to adopt 
> this; we could do tests in Java as well, but this is redundant for now)
> Support only primitive types for now to avoid dealing with bynary type 
> metadata, schemas, compact footers, etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5899) Thin client: cache.Get for primitives

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145531#comment-16145531
 ] 

Pavel Tupitsyn commented on IGNITE-5899:


Merged to {{ignite-5896}}.

> Thin client: cache.Get for primitives
> -
>
> Key: IGNITE-5899
> URL: https://issues.apache.org/jira/browse/IGNITE-5899
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Implement {{cache.Get}} for primitive data types via thin client protocol.
> This will include:
> * New client type in {{SqlListenerNioListener}}
> * {{PlatformRequestHandler implements SqlListenerRequestHandler}}, 
> {{PlatformMessageParser implements SqlListenerMessageParser}}
> * Integration test in .NET (just because .NET is the first platform to adopt 
> this; we could do tests in Java as well, but this is redundant for now)
> Support only primitive types for now to avoid dealing with bynary type 
> metadata, schemas, compact footers, etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5899) Thin client: cache.Get for primitives

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145367#comment-16145367
 ] 

Pavel Tupitsyn commented on IGNITE-5899:


Merged from master.

> Thin client: cache.Get for primitives
> -
>
> Key: IGNITE-5899
> URL: https://issues.apache.org/jira/browse/IGNITE-5899
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Implement {{cache.Get}} for primitive data types via thin client protocol.
> This will include:
> * New client type in {{SqlListenerNioListener}}
> * {{PlatformRequestHandler implements SqlListenerRequestHandler}}, 
> {{PlatformMessageParser implements SqlListenerMessageParser}}
> * Integration test in .NET (just because .NET is the first platform to adopt 
> this; we could do tests in Java as well, but this is redundant for now)
> Support only primitive types for now to avoid dealing with bynary type 
> metadata, schemas, compact footers, etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5899) Thin client: cache.Get for primitives

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1613#comment-1613
 ] 

Pavel Tupitsyn commented on IGNITE-5899:


[~vozerov] fixed.

> Thin client: cache.Get for primitives
> -
>
> Key: IGNITE-5899
> URL: https://issues.apache.org/jira/browse/IGNITE-5899
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.2
>
>
> Implement {{cache.Get}} for primitive data types via thin client protocol.
> This will include:
> * New client type in {{SqlListenerNioListener}}
> * {{PlatformRequestHandler implements SqlListenerRequestHandler}}, 
> {{PlatformMessageParser implements SqlListenerMessageParser}}
> * Integration test in .NET (just because .NET is the first platform to adopt 
> this; we could do tests in Java as well, but this is redundant for now)
> Support only primitive types for now to avoid dealing with bynary type 
> metadata, schemas, compact footers, etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5899) Thin client: cache.Get for primitives

[Vladimir Ozerov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110940#comment-16110940
 ] 

Vladimir Ozerov commented on IGNITE-5899:
-

[~ptupitsyn], my comments:
1) Please rename all classes from {{Platform*}} to {{Client*}}, as it is not 
about platforms at all.
2) Parser looks useless to me at the moment. We have clear separation of 
concerns between parser and handler:
- Parser should construct request object with all necessary data inside. If 
this is a GET request, then it should produce something like 
{code}
class ClientGetRequest {
long reqId,
int cacheId;
Object key;
}
{code}
- Handler must process request and produce a response, e.g.:
{code}
class ClientGetResponse {
long reqId;
Object val;
}
{code}

> Thin client: cache.Get for primitives
> -
>
> Key: IGNITE-5899
> URL: https://issues.apache.org/jira/browse/IGNITE-5899
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.2
>
>
> Implement {{cache.Get}} for primitive data types via thin client protocol.
> This will include:
> * New client type in {{SqlListenerNioListener}}
> * {{PlatformRequestHandler implements SqlListenerRequestHandler}}, 
> {{PlatformMessageParser implements SqlListenerMessageParser}}
> * Integration test in .NET (just because .NET is the first platform to adopt 
> this; we could do tests in Java as well, but this is redundant for now)
> Support only primitive types for now to avoid dealing with bynary type 
> metadata, schemas, compact footers, etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5899) Thin client: cache.Get for primitives

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110678#comment-16110678
 ] 

Pavel Tupitsyn commented on IGNITE-5899:


Done, [~vozerov] please have a look.

> Thin client: cache.Get for primitives
> -
>
> Key: IGNITE-5899
> URL: https://issues.apache.org/jira/browse/IGNITE-5899
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.2
>
>
> Implement {{cache.Get}} for primitive data types via thin client protocol.
> This will include:
> * New client type in {{SqlListenerNioListener}}
> * {{PlatformRequestHandler implements SqlListenerRequestHandler}}, 
> {{PlatformMessageParser implements SqlListenerMessageParser}}
> * Integration test in .NET (just because .NET is the first platform to adopt 
> this; we could do tests in Java as well, but this is redundant for now)
> Support only primitive types for now to avoid dealing with bynary type 
> metadata, schemas, compact footers, etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5899) Thin client: cache.Get for primitives

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110676#comment-16110676
 ] 

ASF GitHub Bot commented on IGNITE-5899:


GitHub user ptupitsyn opened a pull request:

https://github.com/apache/ignite/pull/2376

IGNITE-5899 Thin client: cache.Get for primitives



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-5899

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2376.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2376


commit 25c16ecc1f3aac8379ae430572baceaf5116a827
Author: Pavel Tupitsyn 
Date:   2017-08-02T10:23:06Z

IGNITE-5899 Thin client: cache.Get for primitives




> Thin client: cache.Get for primitives
> -
>
> Key: IGNITE-5899
> URL: https://issues.apache.org/jira/browse/IGNITE-5899
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.2
>
>
> Implement {{cache.Get}} for primitive data types via thin client protocol.
> This will include:
> * New client type in {{SqlListenerNioListener}}
> * {{PlatformRequestHandler implements SqlListenerRequestHandler}}, 
> {{PlatformMessageParser implements SqlListenerMessageParser}}
> * Integration test in .NET (just because .NET is the first platform to adopt 
> this; we could do tests in Java as well, but this is redundant for now)
> Support only primitive types for now to avoid dealing with bynary type 
> metadata, schemas, compact footers, etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5899) Thin client: cache.Get for primitives

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109345#comment-16109345
 ] 

Pavel Tupitsyn commented on IGNITE-5899:


Java side done, implementing .NET tests.

> Thin client: cache.Get for primitives
> -
>
> Key: IGNITE-5899
> URL: https://issues.apache.org/jira/browse/IGNITE-5899
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.2
>
>
> Implement {{cache.Get}} for primitive data types via thin client protocol.
> This will include:
> * New client type in {{SqlListenerNioListener}}
> * {{PlatformRequestHandler implements SqlListenerRequestHandler}}, 
> {{PlatformMessageParser implements SqlListenerMessageParser}}
> * Integration test in .NET (just because .NET is the first platform to adopt 
> this; we could do tests in Java as well, but this is redundant for now)
> Support only primitive types for now to avoid dealing with bynary type 
> metadata, schemas, compact footers, etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)