[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331578#comment-16331578
 ] 

ASF GitHub Bot commented on IGNITE-7284:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/3346


> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Valentin Kulichenko
>Priority: Major
> Fix For: 2.5
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[Valentin Kulichenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331577#comment-16331577
 ] 

Valentin Kulichenko commented on IGNITE-7284:
-

[~slukyanov], I disagree about system property caching. I don't see much value 
in checking it every time the warning is added to the log. If we want to add an 
ability to change this value dynamically, there should be another way, probably 
via MBean. Feel free to create a separate ticket for this. Agree on the rest 
though, so I made the change myself and merged code to master. Thanks for the 
contribution!

> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Valentin Kulichenko
>Priority: Major
> Fix For: 2.5
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[Stanislav Lukyanov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328633#comment-16328633
 ] 

Stanislav Lukyanov commented on IGNITE-7284:


I've also added marker names to the log4j2's output format. I thought about 
also appending the marker to the message in loggers that don't support markers, 
but it probably doesn't worth it - markers don't have too much of information 
value and mostly useful for filtering, and the loggers that can't use them for 
filtering probably wouldn't benefit from having them in the message as well.

> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Stanislav Lukyanov
>Priority: Major
> Fix For: 2.4
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[Stanislav Lukyanov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328600#comment-16328600
 ] 

Stanislav Lukyanov commented on IGNITE-7284:


[~vkulichenko],
{quote}Let's rename warnDev to warnDevOnly.
{quote}
Done.
{quote}System property name should not 'WARNINGS' word in it, as it can be 
related to other log levels as well. IGNITE_DEV_ONLY_LOGGING_DISABLED looks 
better to me.
{quote}
Done.
{quote}IgniteUtils should initialize system property value in the static block 
and then the value should be reused. It's a bad idea to call System.getProperty 
every time, check how this is done for other properties.
{quote}
I don't think that's necessary. Even IgniteUtils doesn't do that for a lot of 
properties - it mostly caches readonly properties like os.name and the 
properties that shouldn't change dynamically, like IGNITE_MBEANS_DISABLED. With 
IGNITE_DEV_ONLY_LOGGING_DISABLED it is quite easy to handle the dynamic change 
of the value (and it even makes sense, particularly in testing and maybe 
debugging) so I'd keep it as it is. Also, the cost of property lookup should be 
small enough to ignore it compared to the writing the message to the log.
{quote}Marker seems to be nullable. If so, parameter should be marked with 
@Nullable in IgniteLogger interface.
{quote}
Done
{quote}In addition, I think these two log statements can be marked with 
DEV_ONLY right away (we obviously will add more as we go):
 * Config validation warnings in GridCacheStoreManagerAdapter#start0.
 * Performance suggestions printed out by GridPerformanceSuggestions.{quote}
Actually, I think both of these are not "development only" - they're rather 
about deployment and can be fixed without rewriting the code.
 If you want to handle all these messages together, maybe we should name the 
marker like USAGE_SUGGESTION instead of DEV_ONLY. That would be a marker for 
the messages that help to write code and configs, but not to debug dynamic 
problems like network failures. Also we might want to deprecate 
IGNITE_PERFORMANCE_SUGGESTIONS_DISABLED since USAGE_SUGGESTION marker and the 
related property would be used instead.

> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Stanislav Lukyanov
>Priority: Major
> Fix For: 2.4
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[Valentin Kulichenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328059#comment-16328059
 ] 

Valentin Kulichenko commented on IGNITE-7284:
-

In addition, I think these two log statements can be marked with {{DEV_ONLY}} 
right away (we obviously will add more as we go):
 * Config validation warnings in {{GridCacheStoreManagerAdapter#start0}}.
 * Performance suggestions printed out by {{GridPerformanceSuggestions}}.

> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Stanislav Lukyanov
>Priority: Major
> Fix For: 2.4
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[Valentin Kulichenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328057#comment-16328057
 ] 

Valentin Kulichenko commented on IGNITE-7284:
-

[~slukyanov], overall looks good, although here are some minor comments:
 * Let's rename {{warnDev}} to {{warnDevOnly}}.
* System property name should not 'WARNINGS' word in it, as it can be related 
to other log levels as well. {{IGNITE_DEV_ONLY_LOGGING_DISABLED}} looks better 
to me.
* {{IgniteUtils}} should initialize system property value in the static block 
and then the value should be reused. It's a bad idea to call 
{{System.getProperty}} every time, check how this is done for other properties.
* Marker seems to be nullable. If so, parameter should be marked with 
{{@Nullable}} in {{IgniteLogger}} interface.

> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Stanislav Lukyanov
>Priority: Major
> Fix For: 2.4
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[Stanislav Lukyanov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326962#comment-16326962
 ] 

Stanislav Lukyanov commented on IGNITE-7284:


After the issue is fixed, need to 1) Consider adding docs on Ignite logging 
markers (just one marker for now) to 
[https://apacheignite.readme.io/docs/logging]; 2) Update TeamCity build "Ignite 
Basic 2" to include org.apache.ignite.testsuites.IgniteSlf4jTestSuite (append 
it to the TEST_SUITE parameter)

> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Stanislav Lukyanov
>Priority: Major
> Fix For: 2.4
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[Stanislav Lukyanov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325189#comment-16325189
 ] 

Stanislav Lukyanov commented on IGNITE-7284:


[~vkulichenko], merged and reran the tests, all good.

> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Stanislav Lukyanov
> Fix For: 2.4
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[Valentin Kulichenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324753#comment-16324753
 ] 

Valentin Kulichenko commented on IGNITE-7284:
-

[~slukyanov], I tried to merge pull request to master, but there are conflicts. 
Can you please fix them?

> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Stanislav Lukyanov
> Fix For: 2.4
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[Stanislav Lukyanov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321978#comment-16321978
 ] 

Stanislav Lukyanov commented on IGNITE-7284:


[~vkulichenko], my concern here is that this way we do reinvent the wheel for 
100% of the markers that we use now :) 
The question is, when we add more markers, are we likely to add a property for 
each to allow filtering on JUL?

Anyway, I guess you're right that it's easy to do, so I'll add a property and 
handle it on IgniteUtils level. It'll be easier to come up with the right 
strategy when there are more standard markers in Ignite.

> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Stanislav Lukyanov
> Fix For: 2.4
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[Valentin Kulichenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321339#comment-16321339
 ] 

Valentin Kulichenko commented on IGNITE-7284:
-

[~slukyanov], I don't want to overcomplicate and reinvent the wheel for loggers 
that do not support markers. Adding a system property for them is very easy 
though and solves the problem to certain extent. Yes, it's a backdoor, but it 
still can be useful, so let's add it.

Agree about message formats. We should check all logger implementation for this.

> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Stanislav Lukyanov
> Fix For: 2.4
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[Stanislav Lukyanov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319833#comment-16319833
 ] 

Stanislav Lukyanov commented on IGNITE-7284:


We might also need to consider updating message formats.
Default log4j2 pattern should include markers, if any are present.
When JUL is used it seems reasonable to add the marker name at the start of the 
message.

> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Stanislav Lukyanov
> Fix For: 2.4
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[Stanislav Lukyanov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319830#comment-16319830
 ] 

Stanislav Lukyanov commented on IGNITE-7284:


[~vkulichenko], thanks for the feedback.

Yes, I'll be adding the DEV_ONLY now + a few IgniteUtils methods accepting 
markers + applying DEV_ONLY for the serialization warnings mentioned in the 
referenced mail thread.

About the system property, - is it really necessary?
Special-handling DEV_ONLY messages via a property kind of defeats the purpose 
of introducing markers as a general solution for this kind of problem.
Using JUL (or another simplistic logger) as a logging implementation is likely 
to be a deliberate choice not to care too much about the logs. If a user wants 
a finer filtering of the logs, they'll probably be able to use log4j2 (or 
already use it).

We *could* re-implement marker-based filtering for JUL via system properties, 
say by looking up IGNITE_LOG_ and only printing the message if the 
property is set to true, but enhancing underlying implementations seems to be a 
bit of an overkill.

> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Stanislav Lukyanov
> Fix For: 2.4
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[Valentin Kulichenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319507#comment-16319507
 ] 

Valentin Kulichenko commented on IGNITE-7284:
-

[~slukyanov], looks good to me so far. Now let's also do the following:
* Add a system property for loggers that do not support markers.
* Introduce the {{DEV_ONLY}} marker.

> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Stanislav Lukyanov
> Fix For: 2.4
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318783#comment-16318783
 ] 

ASF GitHub Bot commented on IGNITE-7284:


GitHub user slukyano opened a pull request:

https://github.com/apache/ignite/pull/3346

IGNITE-7284: Introduce DEV_ONLY marker to IgniteLogger



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-7284

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3346


commit fd43e44b7be7746f496502147711246bd8555024
Author: Stanislav Lukyanov 
Date:   2018-01-09T13:37:52Z

IGNITE-7284: change loggers to use default methods for overloads

commit 102bf58bafae44e9872fa3e395f9566d84703993
Author: Stanislav Lukyanov 
Date:   2018-01-09T17:32:50Z

IGNITE-7284: added handling of markers in slf4j and log4j2




> Introduce DEV_ONLY marker to IgniteLogger
> -
>
> Key: IGNITE-7284
> URL: https://issues.apache.org/jira/browse/IGNITE-7284
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Stanislav Lukyanov
> Fix For: 2.4
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)