[jira] [Commented] (KARAF-40) Create a maven archetype for creating shell commands
[
https://issues.apache.org/jira/browse/KARAF-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13067560#comment-13067560
]
Charles Moulliard commented on KARAF-40:
Correct syntax to be used :
{code}
mvn archetype:generate -DarchetypeGroupId=org.apache.karaf.archetypes
-DarchetypeArtifactId=archetypes-command -DarchetypeVersion=2.2.2
-DgroupId=org.apache.shell.test -DartifactId=test.commands
-Dversion=1.0-SNAPSHOT -Dscope='test' -Dcommand='TestCommand' -Ddescription='An
example command for demonstrating the command archetype.'
{code}
Create a maven archetype for creating shell commands
Key: KARAF-40
URL: https://issues.apache.org/jira/browse/KARAF-40
Project: Karaf
Issue Type: Task
Reporter: Guillaume Nodet
Assignee: Ioannis Canellos
Fix For: 2.1.0
Attachments: command-archetype-patch.txt, karaf-archetypes-patch.txt,
karaf-archetypes-patch.txt
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (KARAF-40) Create a maven archetype for creating shell commands
[ https://issues.apache.org/jira/browse/KARAF-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901305#action_12901305 ] Guillaume Nodet commented on KARAF-40: -- I guess i didn't expressed my pov correctly regarding #1. What I meant was not really about the artifact ids, but rather the name of the folders. We usually have a convention that when you have a folder foo with a subfolder bar, the artifactIds will be xxx-foo and xxx-foo-bar, which means the folders name do not include the parent folder name. Create a maven archetype for creating shell commands Key: KARAF-40 URL: https://issues.apache.org/jira/browse/KARAF-40 Project: Karaf Issue Type: Task Reporter: Guillaume Nodet Attachments: command-archetype-patch.txt, karaf-archetypes-patch.txt -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-40) Create a maven archetype for creating shell commands
[ https://issues.apache.org/jira/browse/KARAF-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901319#action_12901319 ] Ioannis Canellos commented on KARAF-40: --- OK, I will apply the convention and upload the updated patch later today. Create a maven archetype for creating shell commands Key: KARAF-40 URL: https://issues.apache.org/jira/browse/KARAF-40 Project: Karaf Issue Type: Task Reporter: Guillaume Nodet Attachments: command-archetype-patch.txt, karaf-archetypes-patch.txt -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-40) Create a maven archetype for creating shell commands
[ https://issues.apache.org/jira/browse/KARAF-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901200#action_12901200 ] Ioannis Canellos commented on KARAF-40: --- Regarding points 2 and 3 there are not much to discuss since I agree both on displaying a simple message and on removing the parent pom from the generated project. Regarding point 1, I think that its not that bad to have included in the artifactId a literal that is also part of the groupId if it is used to avoid having extremely generic artifactIds (some examples: a) all maven plugins, b) all spring modules c) all servicemix/camel components). Personally, I wouldn't like to have a project structure that would contain multiple projects with artifactId itest (beyound my personal preference this is also messy in some IDEs) . In any case I wouldn't like to create inconsistencies inside the project, so if I wasn't persuasive enough, I would be more than happy to provide a supplemental patch with all 3 changes. Create a maven archetype for creating shell commands Key: KARAF-40 URL: https://issues.apache.org/jira/browse/KARAF-40 Project: Karaf Issue Type: Task Reporter: Guillaume Nodet Attachments: command-archetype-patch.txt, karaf-archetypes-patch.txt -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-40) Create a maven archetype for creating shell commands
[ https://issues.apache.org/jira/browse/KARAF-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12898823#action_12898823 ] Guillaume Nodet commented on KARAF-40: -- Just a few remarks: * i'm not very keen on the karaf-command-archetype and karaf-archetypes-itests names for the maven modules, shouldn''t they be command and itests, given they are in the archetypes folder already ? that would be more consistent with the remaining of the project * maybe the code for the function generated should print something to std out like Executing command xxx so that the user can visually see something with a bare generated artifact * I don't think the generated maven project should inherit from a karaf project Those are not critical problems and i'm really open to discuss those if you have a different point of view. Create a maven archetype for creating shell commands Key: KARAF-40 URL: https://issues.apache.org/jira/browse/KARAF-40 Project: Karaf Issue Type: Task Reporter: Guillaume Nodet Attachments: command-archetype-patch.txt, karaf-archetypes-patch.txt -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
