[jira] [Created] (KYLIN-3072) Fix the regular expression in function 'removeCommentInSql'
peng.jianhua created KYLIN-3072: --- Summary: Fix the regular expression in function 'removeCommentInSql' Key: KYLIN-3072 URL: https://issues.apache.org/jira/browse/KYLIN-3072 Project: Kylin Issue Type: Bug Components: Query Engine Reporter: peng.jianhua Assignee: peng.jianhua -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (KYLIN-3073) When you save a new query condition, the 'Saved Queries' tab page will not be automatically refreshed.
peng.jianhua created KYLIN-3073: --- Summary: When you save a new query condition, the 'Saved Queries' tab page will not be automatically refreshed. Key: KYLIN-3073 URL: https://issues.apache.org/jira/browse/KYLIN-3073 Project: Kylin Issue Type: Bug Components: Web Affects Versions: v2.3.0 Reporter: peng.jianhua Assignee: peng.jianhua Attachments: add_a_new_record.png, init_status.png, manual_refresh.png, saved_queries_not_refresh.png When you save a new query condition, the 'Saved Queries' tab will not be automatically refreshed. 1. Open the 'Insight' page; 2. Choose the 'Saved Queries' tab page, you will see the current page is like [^init_status.png]; 3. Resubmit anyone query, then save it, just like [^add_a_new_record.png]; 4. When you saved it, you will find the 'Saved Queries' tab page will not be automatically refreshed, refer to [^saved_queries_not_refresh.png]; 5. You should manually refresh it by clicking the 'Saved Queries' tab, refer to [^manual_refresh.png]. I check the code and find the reason, when closing the 'Save Query' dialog, the code doesn't trigger refreshing 'Saved Queries' tab. I have repaired this code, please check the patch, thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3073) When you save a new query condition, the 'Saved Queries' tab page will not be automatically refreshed.
[ https://issues.apache.org/jira/browse/KYLIN-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated KYLIN-3073: Flags: Patch Labels: patch (was: ) > When you save a new query condition, the 'Saved Queries' tab page will not be > automatically refreshed. > -- > > Key: KYLIN-3073 > URL: https://issues.apache.org/jira/browse/KYLIN-3073 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.3.0 >Reporter: peng.jianhua >Assignee: peng.jianhua > Labels: patch > Attachments: add_a_new_record.png, init_status.png, > manual_refresh.png, saved_queries_not_refresh.png > > > When you save a new query condition, the 'Saved Queries' tab will not be > automatically refreshed. > 1. Open the 'Insight' page; > 2. Choose the 'Saved Queries' tab page, you will see the current page is like > [^init_status.png]; > 3. Resubmit anyone query, then save it, just like [^add_a_new_record.png]; > 4. When you saved it, you will find the 'Saved Queries' tab page will not be > automatically refreshed, refer to [^saved_queries_not_refresh.png]; > 5. You should manually refresh it by clicking the 'Saved Queries' tab, refer > to [^manual_refresh.png]. > I check the code and find the reason, when closing the 'Save Query' dialog, > the code doesn't trigger refreshing 'Saved Queries' tab. > I have repaired this code, please check the patch, thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (KYLIN-3074) Change cube access to project access in ExternalAclProvider.java
peng.jianhua created KYLIN-3074: --- Summary: Change cube access to project access in ExternalAclProvider.java Key: KYLIN-3074 URL: https://issues.apache.org/jira/browse/KYLIN-3074 Project: Kylin Issue Type: Bug Reporter: peng.jianhua Assignee: peng.jianhua Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3073) When you save a new query condition, the 'Saved Queries' tab page will not be automatically refreshed.
[ https://issues.apache.org/jira/browse/KYLIN-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated KYLIN-3073: Attachment: 0001-KYLIN-3073-When-you-save-a-new-query-condition-the-S.patch > When you save a new query condition, the 'Saved Queries' tab page will not be > automatically refreshed. > -- > > Key: KYLIN-3073 > URL: https://issues.apache.org/jira/browse/KYLIN-3073 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.3.0 >Reporter: peng.jianhua >Assignee: peng.jianhua > Labels: patch > Attachments: > 0001-KYLIN-3073-When-you-save-a-new-query-condition-the-S.patch, > add_a_new_record.png, init_status.png, manual_refresh.png, > saved_queries_not_refresh.png > > > When you save a new query condition, the 'Saved Queries' tab will not be > automatically refreshed. > 1. Open the 'Insight' page; > 2. Choose the 'Saved Queries' tab page, you will see the current page is like > [^init_status.png]; > 3. Resubmit anyone query, then save it, just like [^add_a_new_record.png]; > 4. When you saved it, you will find the 'Saved Queries' tab page will not be > automatically refreshed, refer to [^saved_queries_not_refresh.png]; > 5. You should manually refresh it by clicking the 'Saved Queries' tab, refer > to [^manual_refresh.png]. > I check the code and find the reason, when closing the 'Save Query' dialog, > the code doesn't trigger refreshing 'Saved Queries' tab. > I have repaired this code, please check the patch, thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3019) The pop-up window of 'Calculate Cardinality' and 'Load Hive Table' should have the same hint
[ https://issues.apache.org/jira/browse/KYLIN-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated KYLIN-3019: Attachment: 0001-KYLIN-3019-The-pop-up-window-of-Calculate-Cardinalit.patch > The pop-up window of 'Calculate Cardinality' and 'Load Hive Table' should > have the same hint > > > Key: KYLIN-3019 > URL: https://issues.apache.org/jira/browse/KYLIN-3019 > Project: Kylin > Issue Type: Improvement >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Fix For: v2.3.0 > > Attachments: > 0001-KYLIN-3019-The-pop-up-window-of-Calculate-Cardinalit.patch, 01.PNG, > 02.PNG > > > 01.png is when we click the 'Calculate Cardinality' button,it shows nothing. > 02.png is when we click the 'Load Hive Table' button,it shows the hint of > that we will choose the 'Default' database when there is no database input. > In my opinion,they should keep the same. > And we also need the hint when we input in the pop-up window of 'Calculate > Cardinality' . -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3019) The pop-up window of 'Calculate Cardinality' and 'Load Hive Table' should have the same hint
[ https://issues.apache.org/jira/browse/KYLIN-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated KYLIN-3019: Attachment: (was: 0001-KYLIN-3019-The-pop-up-window-of-Calculate-Cardinalit.patch) > The pop-up window of 'Calculate Cardinality' and 'Load Hive Table' should > have the same hint > > > Key: KYLIN-3019 > URL: https://issues.apache.org/jira/browse/KYLIN-3019 > Project: Kylin > Issue Type: Improvement >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Fix For: v2.3.0 > > Attachments: > 0001-KYLIN-3019-The-pop-up-window-of-Calculate-Cardinalit.patch, 01.PNG, > 02.PNG > > > 01.png is when we click the 'Calculate Cardinality' button,it shows nothing. > 02.png is when we click the 'Load Hive Table' button,it shows the hint of > that we will choose the 'Default' database when there is no database input. > In my opinion,they should keep the same. > And we also need the hint when we input in the pop-up window of 'Calculate > Cardinality' . -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3072) Fix the regular expression in function 'removeCommentInSql'
[ https://issues.apache.org/jira/browse/KYLIN-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated KYLIN-3072: Attachment: 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch > Fix the regular expression in function 'removeCommentInSql' > --- > > Key: KYLIN-3072 > URL: https://issues.apache.org/jira/browse/KYLIN-3072 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3072) Fix the regular expression in function 'removeCommentInSql'
[ https://issues.apache.org/jira/browse/KYLIN-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated KYLIN-3072: Description: select * from kylin_sales /*comments--comments*/ we should remove comments like /*comments*/ first,or the sql above will have an error. > Fix the regular expression in function 'removeCommentInSql' > --- > > Key: KYLIN-3072 > URL: https://issues.apache.org/jira/browse/KYLIN-3072 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch > > > select * from kylin_sales /*comments--comments*/ > we should remove comments like /*comments*/ first,or the sql above will have > an error. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3072) Fix the regular expression in function 'removeCommentInSql'
[ https://issues.apache.org/jira/browse/KYLIN-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated KYLIN-3072: Attachment: 01.png 02.PNG > Fix the regular expression in function 'removeCommentInSql' > --- > > Key: KYLIN-3072 > URL: https://issues.apache.org/jira/browse/KYLIN-3072 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch, 01.png, > 02.PNG > > > select * from kylin_sales /*comments--comments*/ > we should remove comments like /*comments*/ first,or the sql above will have > an error. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3072) Fix the regular expression in function 'removeCommentInSql'
[ https://issues.apache.org/jira/browse/KYLIN-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated KYLIN-3072: Description: select * from kylin_sales /*comments--comments*/ we should remove comments like '/*comments*/' first,then remove comments like '--comments' , or the sql above will have an exception. please refer to 01.png. if we exchange the sequence of this two comment patterns,we will get 02.png. was: select * from kylin_sales /*comments--comments*/ we should remove comments like /*comments*/ first,or the sql above will have an error. > Fix the regular expression in function 'removeCommentInSql' > --- > > Key: KYLIN-3072 > URL: https://issues.apache.org/jira/browse/KYLIN-3072 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch, 01.png, > 02.PNG > > > select * from kylin_sales /*comments--comments*/ > we should remove comments like '/*comments*/' first,then remove comments like > '--comments' , or the sql above will have an exception. > please refer to 01.png. > if we exchange the sequence of this two comment patterns,we will get 02.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (KYLIN-3075) Improvement kylin.sh, remove duplicate dependency check, let kylin start faster.
peng.jianhua created KYLIN-3075: --- Summary: Improvement kylin.sh, remove duplicate dependency check, let kylin start faster. Key: KYLIN-3075 URL: https://issues.apache.org/jira/browse/KYLIN-3075 Project: Kylin Issue Type: Improvement Reporter: peng.jianhua Assignee: peng.jianhua Priority: Minor Improvement kylin.sh, remove duplicate dependency check, let kylin start faster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3075) Improvement kylin.sh, remove duplicate dependency check, let kylin start faster.
[ https://issues.apache.org/jira/browse/KYLIN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated KYLIN-3075: Attachment: 0001-KYLIN-3075-Improvement-kylin.sh-remove-duplicate-dep.patch > Improvement kylin.sh, remove duplicate dependency check, let kylin start > faster. > > > Key: KYLIN-3075 > URL: https://issues.apache.org/jira/browse/KYLIN-3075 > Project: Kylin > Issue Type: Improvement >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Attachments: > 0001-KYLIN-3075-Improvement-kylin.sh-remove-duplicate-dep.patch > > > Improvement kylin.sh, remove duplicate dependency check, let kylin start > faster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3035) How to use Kylin on EMR with S3 as hbase storage
[
https://issues.apache.org/jira/browse/KYLIN-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272622#comment-16272622
]
Shaofeng SHI commented on KYLIN-3035:
-
Docs on Kylin with EMR:
https://kylin.apache.org/docs21/install/kylin_aws_emr.html
> How to use Kylin on EMR with S3 as hbase storage
>
>
> Key: KYLIN-3035
> URL: https://issues.apache.org/jira/browse/KYLIN-3035
> Project: Kylin
> Issue Type: Bug
> Components: Metadata
>Affects Versions: v2.2.0
> Environment: EMR 5.5.0, Kylin 2.2.0
>Reporter: Shawn Wang
>Assignee: Shaofeng SHI
>
> Can somebody give an example of how to use kylin on EMR with S3 as hbase
> storage, which support reuse the previously built cube on new EMR after the
> original EMR has been terminated.
> My purpose is simple:
> 1. use transient EMR cluster to build cubes
> 2. use a persistent cluster to handle query requests
> Of course, the culsters should share same hbase storage, so I setup the
> cluster to use S3 as hbase storage, after 2.2.0 fix the "HFile not written to
> S3" issue, I have been built a sample cube successfully, using configurations:
> EMR:
> {noformat}
> [
> {
> "Classification": "hbase-site",
> "Properties": {
> "hbase.rootdir": "s3://kylin-emrfs/hbase-production"
> }
> },
> {
> "Classification": "hbase",
> "Properties": {
> "hbase.emr.storageMode": "s3"
> }
> },
> {
> "Classification": "emrfs-site",
> "Properties": {
> "fs.s3.consistent": "true",
> "fs.s3.consistent.metadata.tableName":
> "KylinEmrFSMetadata"
> }
> }
> ]
> {noformat}
> kylin.propertities:
> {noformat}
> kylin.env.hdfs-working-dir=s3://kylin-emrfs/kylin-working-dir
> kylin.server.mode=all
> {noformat}
> Then I create a new cluster with same EMR configuration and query mode for
> kylin, kylin just can't startup with errors:
> {noformat}
> 2017-11-13 07:33:44,415 INFO
> [main-SendThread(ip-172-31-1-10.cn-north-1.compute.internal:2181)]
> zookeeper.ClientCnxn:876 : Socket connection established to
> ip-172-31-1-10.cn-north-1.compute.internal/172.31.1.10:2181, initiating
> session
> 2017-11-13 07:33:44,422 INFO
> [main-SendThread(ip-172-31-1-10.cn-north-1.compute.internal:2181)]
> zookeeper.ClientCnxn:1299 : Session establishment complete on server
> ip-172-31-1-10.cn-north-1.compute.internal/172.31.1.10:2181, sessionid =
> 0x15fb4173c100156, negotiated timeout = 4
> 2017-11-13 07:33:48,380 DEBUG [main] hbase.HBaseConnection:279 : HTable
> 'kylin_metadata' already exists
> Exception in thread "main" java.lang.IllegalArgumentException: Failed to find
> metadata store by url: kylin_metadata@hbase
> at
> org.apache.kylin.common.persistence.ResourceStore.createResourceStore(ResourceStore.java:89)
> at
> org.apache.kylin.common.persistence.ResourceStore.getStore(ResourceStore.java:101)
> at
> org.apache.kylin.rest.service.AclTableMigrationTool.checkIfNeedMigrate(AclTableMigrationTool.java:94)
> at
> org.apache.kylin.tool.AclTableMigrationCLI.main(AclTableMigrationCLI.java:41)
> Caused by: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed
> after attempts=1, exceptions:
> Mon Nov 13 07:33:48 UTC 2017,
> RpcRetryingCaller{globalStartTime=1510558428667, pause=100, retries=1},
> java.net.ConnectException: 拒绝连接
> at
> org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:159)
> at org.apache.hadoop.hbase.client.HTable.get(HTable.java:864)
> at org.apache.hadoop.hbase.client.HTable.get(HTable.java:830)
> at
> org.apache.kylin.storage.hbase.HBaseResourceStore.internalGetFromHTable(HBaseResourceStore.java:385)
> at
> org.apache.kylin.storage.hbase.HBaseResourceStore.getFromHTable(HBaseResourceStore.java:363)
> at
> org.apache.kylin.storage.hbase.HBaseResourceStore.existsImpl(HBaseResourceStore.java:116)
> at
> org.apache.kylin.common.persistence.ResourceStore.exists(ResourceStore.java:144)
> at
> org.apache.kylin.common.persistence.ResourceStore.createResourceStore(ResourceStore.java:84)
> ... 3 more
> Caused by: java.net.ConnectException: 拒绝连接
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
> at
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
> at
> org.apache.hadoop.net.SocketIOWithTimeout.connect(SocketIOWithTimeout.java:206)
> at org.apache.hadoop.net.NetUtils.connect(NetUtils.java:531)
> at org.apache.hadoop.net.NetUtils.connect(NetUtils.java:495)
> at
> org.apache.hadoop.hbase.ipc.RpcClientI
[jira] [Commented] (KYLIN-3019) The pop-up window of 'Calculate Cardinality' and 'Load Hive Table' should have the same hint
[ https://issues.apache.org/jira/browse/KYLIN-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272680#comment-16272680 ] peng.jianhua commented on KYLIN-3019: - Thank you [~Shaofengshi],I've update the patch. > The pop-up window of 'Calculate Cardinality' and 'Load Hive Table' should > have the same hint > > > Key: KYLIN-3019 > URL: https://issues.apache.org/jira/browse/KYLIN-3019 > Project: Kylin > Issue Type: Improvement >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Fix For: v2.3.0 > > Attachments: > 0001-KYLIN-3019-The-pop-up-window-of-Calculate-Cardinalit.patch, 01.PNG, > 02.PNG > > > 01.png is when we click the 'Calculate Cardinality' button,it shows nothing. > 02.png is when we click the 'Load Hive Table' button,it shows the hint of > that we will choose the 'Default' database when there is no database input. > In my opinion,they should keep the same. > And we also need the hint when we input in the pop-up window of 'Calculate > Cardinality' . -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3069) Add proper time zone support to the WebUI instead of GMT/PST kludge
[ https://issues.apache.org/jira/browse/KYLIN-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272686#comment-16272686 ] Shaofeng SHI commented on KYLIN-3069: - Vsevolod, this is a good suggestion; Would you like to contribute a patch to Kylin, as you already made the investigation? Thanks! > Add proper time zone support to the WebUI instead of GMT/PST kludge > --- > > Key: KYLIN-3069 > URL: https://issues.apache.org/jira/browse/KYLIN-3069 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.2.0 > Environment: HDP 2.5.3, Kylin 2.2.0 >Reporter: Vsevolod Ostapenko >Assignee: Zhixiong Chen >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > Time zone handling logic in the WebUI is a kludge, coded to parse only > "GMT-N" time zone specifications and defaulting to PST, if parsing is not > successful (kylin/webapp/app/js/filters/filter.js) > Integrating moment and moment time zone (http://momentjs.com/timezone/docs/) > into the product, would allow correct time zone handling. > For the users who happen to reside in the geographical locations that do > observe day light savings time, usage of GMT-N format is very inconvenient > and info reported by the UI in various places is perplexing. > Needless to say that the GMT moniker itself is long deprecated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3019) The pop-up window of 'Calculate Cardinality' and 'Load Hive Table' should have the same hint
[ https://issues.apache.org/jira/browse/KYLIN-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated KYLIN-3019: Attachment: (was: 0001-KYLIN-3019-The-pop-up-window-of-Calculate-Cardinalit.patch) > The pop-up window of 'Calculate Cardinality' and 'Load Hive Table' should > have the same hint > > > Key: KYLIN-3019 > URL: https://issues.apache.org/jira/browse/KYLIN-3019 > Project: Kylin > Issue Type: Improvement >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Fix For: v2.3.0 > > Attachments: > 0001-KYLIN-3019-The-pop-up-window-of-Calculate-Cardinalit.patch, 01.PNG, > 02.PNG > > > 01.png is when we click the 'Calculate Cardinality' button,it shows nothing. > 02.png is when we click the 'Load Hive Table' button,it shows the hint of > that we will choose the 'Default' database when there is no database input. > In my opinion,they should keep the same. > And we also need the hint when we input in the pop-up window of 'Calculate > Cardinality' . -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3070) Add a config property for flat table storage format
[ https://issues.apache.org/jira/browse/KYLIN-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272688#comment-16272688 ] Shaofeng SHI commented on KYLIN-3070: - +1 Agree; Besides, using other format like Parquet, ORC may gain better compression and performance. Please let me know if you want to contribute a patch; I can add you as the assignee for the JIRA. > Add a config property for flat table storage format > --- > > Key: KYLIN-3070 > URL: https://issues.apache.org/jira/browse/KYLIN-3070 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: v2.2.0 > Environment: HDP 2.5.6, Kylin 2.2.0 >Reporter: Vsevolod Ostapenko >Assignee: Dong Li >Priority: Minor > Original Estimate: 24h > Remaining Estimate: 24h > > Flat table storage format is currently hard-coded as SEQUENCEFILE in the > core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java > That prevents using Impala as a SQL engine while using beeline CLI (via > custom JDBC URL), as Impala cannot write sequence files. > Adding a parameter to kylin.properties to override the default setting would > address the issue. > Removing a hard-coded value for storage format might be good idea in and on > itself. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3019) The pop-up window of 'Calculate Cardinality' and 'Load Hive Table' should have the same hint
[ https://issues.apache.org/jira/browse/KYLIN-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated KYLIN-3019: Attachment: 0001-KYLIN-3019-The-pop-up-window-of-Calculate-Cardinalit.patch > The pop-up window of 'Calculate Cardinality' and 'Load Hive Table' should > have the same hint > > > Key: KYLIN-3019 > URL: https://issues.apache.org/jira/browse/KYLIN-3019 > Project: Kylin > Issue Type: Improvement >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Fix For: v2.3.0 > > Attachments: > 0001-KYLIN-3019-The-pop-up-window-of-Calculate-Cardinalit.patch, 01.PNG, > 02.PNG > > > 01.png is when we click the 'Calculate Cardinality' button,it shows nothing. > 02.png is when we click the 'Load Hive Table' button,it shows the hint of > that we will choose the 'Default' database when there is no database input. > In my opinion,they should keep the same. > And we also need the hint when we input in the pop-up window of 'Calculate > Cardinality' . -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (KYLIN-3067) Provide web interface for dimension capping feature
[ https://issues.apache.org/jira/browse/KYLIN-3067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI reassigned KYLIN-3067: --- Assignee: Zhixiong Chen (was: Zhong,Jason) > Provide web interface for dimension capping feature > --- > > Key: KYLIN-3067 > URL: https://issues.apache.org/jira/browse/KYLIN-3067 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Roger Shi >Assignee: Zhixiong Chen > > As [KYLIN-2363] has provided the dimension capping feature in the backend, we > need a proper web interface. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3066) cleanup job's intermediate hdfs file belong to very old segment
[ https://issues.apache.org/jira/browse/KYLIN-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272691#comment-16272691 ] Shaofeng SHI commented on KYLIN-3066: - +1 The top level segments (like yearly) won't be merged, keeping the cuboid files on HDFS is wasteful. > cleanup job's intermediate hdfs file belong to very old segment > --- > > Key: KYLIN-3066 > URL: https://issues.apache.org/jira/browse/KYLIN-3066 > Project: Kylin > Issue Type: Improvement >Reporter: Yang Hao > > Currently, the job intermediate file won't be deleted if it belongs to a > segment which is 1 year ago . It is very waste. We should supply a config to > define old seg and which cannot be merged , so the old seg can be deleted -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3075) Improvement kylin.sh, remove duplicate dependency check, let kylin start faster.
[ https://issues.apache.org/jira/browse/KYLIN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272751#comment-16272751 ] Billy Liu commented on KYLIN-3075: -- +1 > Improvement kylin.sh, remove duplicate dependency check, let kylin start > faster. > > > Key: KYLIN-3075 > URL: https://issues.apache.org/jira/browse/KYLIN-3075 > Project: Kylin > Issue Type: Improvement >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Attachments: > 0001-KYLIN-3075-Improvement-kylin.sh-remove-duplicate-dep.patch > > > Improvement kylin.sh, remove duplicate dependency check, let kylin start > faster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3072) Fix the regular expression in function 'removeCommentInSql'
[ https://issues.apache.org/jira/browse/KYLIN-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272777#comment-16272777 ] Billy Liu commented on KYLIN-3072: -- Thanks [~peng.jianhua], could you add unit test for this update also? > Fix the regular expression in function 'removeCommentInSql' > --- > > Key: KYLIN-3072 > URL: https://issues.apache.org/jira/browse/KYLIN-3072 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch, 01.png, > 02.PNG > > > select * from kylin_sales /*comments--comments*/ > we should remove comments like '/*comments*/' first,then remove comments like > '--comments' , or the sql above will have an exception. > please refer to 01.png. > if we exchange the sequence of this two comment patterns,we will get 02.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3069) Add proper time zone support to the WebUI instead of GMT/PST kludge
[ https://issues.apache.org/jira/browse/KYLIN-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272884#comment-16272884 ] Vsevolod Ostapenko commented on KYLIN-3069: --- Shaofeng, JavaScript is not exactly my cup of tee. So, it would be better, if someone well versed in that area works on it. > Add proper time zone support to the WebUI instead of GMT/PST kludge > --- > > Key: KYLIN-3069 > URL: https://issues.apache.org/jira/browse/KYLIN-3069 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.2.0 > Environment: HDP 2.5.3, Kylin 2.2.0 >Reporter: Vsevolod Ostapenko >Assignee: Zhixiong Chen >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > Time zone handling logic in the WebUI is a kludge, coded to parse only > "GMT-N" time zone specifications and defaulting to PST, if parsing is not > successful (kylin/webapp/app/js/filters/filter.js) > Integrating moment and moment time zone (http://momentjs.com/timezone/docs/) > into the product, would allow correct time zone handling. > For the users who happen to reside in the geographical locations that do > observe day light savings time, usage of GMT-N format is very inconvenient > and info reported by the UI in various places is perplexing. > Needless to say that the GMT moniker itself is long deprecated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3068) HiveColumnCardinalityJob.java is using deprecated parameter name for HDFS block size
[ https://issues.apache.org/jira/browse/KYLIN-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273071#comment-16273071 ] Vsevolod Ostapenko commented on KYLIN-3068: --- I don't mind trying to contribute back to the project, but I find existing instructions on setting up dev environment somewhat outdated. Since Kylin 2.2.x now pulls and packages Spark 2.1.1 as part of the distribution tar, do I really need to have spark 1.6.x configured to run the tests? Is there an updated/yet unpublished dev env setup instruction? > HiveColumnCardinalityJob.java is using deprecated parameter name for HDFS > block size > > > Key: KYLIN-3068 > URL: https://issues.apache.org/jira/browse/KYLIN-3068 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: v2.2.0 > Environment: HDP 2.5.3, Kylin 2.2.0 >Reporter: Vsevolod Ostapenko >Assignee: Dong Li >Priority: Minor > Original Estimate: 24h > Remaining Estimate: 24h > > While setting MR job configuration HiveColumnCardinalityJob.java uses > deprecated parameter name for HDFS block size. > Since Hadoop 2.5 (at least) recommended parameter name is dfs.blocksize, > while the existing code (2.2.0 and earlier) uses dfs.block.size (please refer > to the list of Hadoop deprecated parameters - > http://hadoop.apache.org/docs/r2.7.3/hadoop-project-dist/hadoop-common/DeprecatedProperties.html) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3070) Add a config property for flat table storage format
[ https://issues.apache.org/jira/browse/KYLIN-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273081#comment-16273081 ] Vsevolod Ostapenko commented on KYLIN-3070: --- I don't mind to work on this issue, but I'm new to the process and existing instructions on setting up dev environment seem a bit outdated. If there are updated version for a non-sandbox HDP 2.5.x install and Kylin 2.2.x, I'd like to have that in order to have my environment setup correctly. > Add a config property for flat table storage format > --- > > Key: KYLIN-3070 > URL: https://issues.apache.org/jira/browse/KYLIN-3070 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: v2.2.0 > Environment: HDP 2.5.6, Kylin 2.2.0 >Reporter: Vsevolod Ostapenko >Assignee: Dong Li >Priority: Minor > Original Estimate: 24h > Remaining Estimate: 24h > > Flat table storage format is currently hard-coded as SEQUENCEFILE in the > core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java > That prevents using Impala as a SQL engine while using beeline CLI (via > custom JDBC URL), as Impala cannot write sequence files. > Adding a parameter to kylin.properties to override the default setting would > address the issue. > Removing a hard-coded value for storage format might be good idea in and on > itself. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (KYLIN-3019) The pop-up window of 'Calculate Cardinality' and 'Load Hive Table' should have the same hint
[ https://issues.apache.org/jira/browse/KYLIN-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-3019. - Resolution: Fixed > The pop-up window of 'Calculate Cardinality' and 'Load Hive Table' should > have the same hint > > > Key: KYLIN-3019 > URL: https://issues.apache.org/jira/browse/KYLIN-3019 > Project: Kylin > Issue Type: Improvement >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Fix For: v2.3.0 > > Attachments: > 0001-KYLIN-3019-The-pop-up-window-of-Calculate-Cardinalit.patch, 01.PNG, > 02.PNG > > > 01.png is when we click the 'Calculate Cardinality' button,it shows nothing. > 02.png is when we click the 'Load Hive Table' button,it shows the hint of > that we will choose the 'Default' database when there is no database input. > In my opinion,they should keep the same. > And we also need the hint when we input in the pop-up window of 'Calculate > Cardinality' . -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3019) The pop-up window of 'Calculate Cardinality' and 'Load Hive Table' should have the same hint
[ https://issues.apache.org/jira/browse/KYLIN-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273746#comment-16273746 ] Shaofeng SHI commented on KYLIN-3019: - Patch merged, and I made minor update on it (adding a blank after ","). Thanks Jianhua! > The pop-up window of 'Calculate Cardinality' and 'Load Hive Table' should > have the same hint > > > Key: KYLIN-3019 > URL: https://issues.apache.org/jira/browse/KYLIN-3019 > Project: Kylin > Issue Type: Improvement >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Fix For: v2.3.0 > > Attachments: > 0001-KYLIN-3019-The-pop-up-window-of-Calculate-Cardinalit.patch, 01.PNG, > 02.PNG > > > 01.png is when we click the 'Calculate Cardinality' button,it shows nothing. > 02.png is when we click the 'Load Hive Table' button,it shows the hint of > that we will choose the 'Default' database when there is no database input. > In my opinion,they should keep the same. > And we also need the hint when we input in the pop-up window of 'Calculate > Cardinality' . -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3072) Fix the regular expression in function 'removeCommentInSql'
[ https://issues.apache.org/jira/browse/KYLIN-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273756#comment-16273756 ] Shaofeng SHI commented on KYLIN-3072: - Do you have a real case that using the two style comments together? > Fix the regular expression in function 'removeCommentInSql' > --- > > Key: KYLIN-3072 > URL: https://issues.apache.org/jira/browse/KYLIN-3072 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch, 01.png, > 02.PNG > > > select * from kylin_sales /*comments--comments*/ > we should remove comments like '/*comments*/' first,then remove comments like > '--comments' , or the sql above will have an exception. > please refer to 01.png. > if we exchange the sequence of this two comment patterns,we will get 02.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3075) Improvement kylin.sh, remove duplicate dependency check, let kylin start faster.
[ https://issues.apache.org/jira/browse/KYLIN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273768#comment-16273768 ] Shaofeng SHI commented on KYLIN-3075: - What's the value here? Can you elaborate on it? > Improvement kylin.sh, remove duplicate dependency check, let kylin start > faster. > > > Key: KYLIN-3075 > URL: https://issues.apache.org/jira/browse/KYLIN-3075 > Project: Kylin > Issue Type: Improvement >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Attachments: > 0001-KYLIN-3075-Improvement-kylin.sh-remove-duplicate-dep.patch > > > Improvement kylin.sh, remove duplicate dependency check, let kylin start > faster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3072) Fix the regular expression in function 'removeCommentInSql'
[ https://issues.apache.org/jira/browse/KYLIN-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated KYLIN-3072: Description: select * from kylin_sales /\*comments--comments*/ we should remove comments like '/\*comments*/' first,then remove comments like '--comments' , or the sql above will have an exception. please refer to 01.png. if we exchange the sequence of this two comment patterns,we will get 02.png. was: select * from kylin_sales /\*comments--comments*/ we should remove comments like '/*comments*/' first,then remove comments like '--comments' , or the sql above will have an exception. please refer to 01.png. if we exchange the sequence of this two comment patterns,we will get 02.png. > Fix the regular expression in function 'removeCommentInSql' > --- > > Key: KYLIN-3072 > URL: https://issues.apache.org/jira/browse/KYLIN-3072 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch, 01.png, > 02.PNG > > > select * from kylin_sales /\*comments--comments*/ > we should remove comments like '/\*comments*/' first,then remove comments > like '--comments' , or the sql above will have an exception. > please refer to 01.png. > if we exchange the sequence of this two comment patterns,we will get 02.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KYLIN-3072) Fix the regular expression in function 'removeCommentInSql'
[ https://issues.apache.org/jira/browse/KYLIN-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated KYLIN-3072: Description: select * from kylin_sales /\*comments--comments*/ we should remove comments like '/*comments*/' first,then remove comments like '--comments' , or the sql above will have an exception. please refer to 01.png. if we exchange the sequence of this two comment patterns,we will get 02.png. was: select * from kylin_sales /*comments--comments*/ we should remove comments like '/*comments*/' first,then remove comments like '--comments' , or the sql above will have an exception. please refer to 01.png. if we exchange the sequence of this two comment patterns,we will get 02.png. > Fix the regular expression in function 'removeCommentInSql' > --- > > Key: KYLIN-3072 > URL: https://issues.apache.org/jira/browse/KYLIN-3072 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch, 01.png, > 02.PNG > > > select * from kylin_sales /\*comments--comments*/ > we should remove comments like '/*comments*/' first,then remove comments like > '--comments' , or the sql above will have an exception. > please refer to 01.png. > if we exchange the sequence of this two comment patterns,we will get 02.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3072) Fix the regular expression in function 'removeCommentInSql'
[ https://issues.apache.org/jira/browse/KYLIN-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273799#comment-16273799 ] Shaofeng SHI commented on KYLIN-3072: - I know it; My question is, do you see a case that such comment style generated from a BI tool like Tableau, Cognos or MSTR? or it is made by manual? If by manual, there are many possible combinations, can this patch solve all of them? Besides, Calcite can recognize comments, Kylin doesn't need take over that too much. I don't think this is a solid enhancement that worth a JIRA to discuss on it. If a strange comment couldn't be recognized and got error, then please correct it, that's it. > Fix the regular expression in function 'removeCommentInSql' > --- > > Key: KYLIN-3072 > URL: https://issues.apache.org/jira/browse/KYLIN-3072 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch, 01.png, > 02.PNG > > > select * from kylin_sales /\*comments--comments*/ > we should remove comments like '/\*comments*/' first,then remove comments > like '--comments' , or the sql above will have an exception. > please refer to 01.png. > if we exchange the sequence of this two comment patterns,we will get 02.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3075) Improvement kylin.sh, remove duplicate dependency check, let kylin start faster.
[ https://issues.apache.org/jira/browse/KYLIN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273803#comment-16273803 ] peng.jianhua commented on KYLIN-3075: - Hi [~Shaofengshi], Base on the following reasons, I think we should Improvement it. 1. Its logic is not very clear, there are repeated load dependent components, the result is too much use of computer resources; 2. And lots of the value for parameters was repeatedly loaded. 3. Based on the above 2 points, the start speed of the kylin is slow. The value of this issue is following: 1. The start logic for kylin is clearer. So we are more easy to maintain and expand. 2. When the kylin starts, the kylin saves more system computer resources. 3. When the kylin starts, the issue speed up the kylin startup speed. > Improvement kylin.sh, remove duplicate dependency check, let kylin start > faster. > > > Key: KYLIN-3075 > URL: https://issues.apache.org/jira/browse/KYLIN-3075 > Project: Kylin > Issue Type: Improvement >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Attachments: > 0001-KYLIN-3075-Improvement-kylin.sh-remove-duplicate-dep.patch > > > Improvement kylin.sh, remove duplicate dependency check, let kylin start > faster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3069) Add proper time zone support to the WebUI instead of GMT/PST kludge
[ https://issues.apache.org/jira/browse/KYLIN-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273809#comment-16273809 ] Shaofeng SHI commented on KYLIN-3069: - No problem, thank you! > Add proper time zone support to the WebUI instead of GMT/PST kludge > --- > > Key: KYLIN-3069 > URL: https://issues.apache.org/jira/browse/KYLIN-3069 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.2.0 > Environment: HDP 2.5.3, Kylin 2.2.0 >Reporter: Vsevolod Ostapenko >Assignee: Zhixiong Chen >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > Time zone handling logic in the WebUI is a kludge, coded to parse only > "GMT-N" time zone specifications and defaulting to PST, if parsing is not > successful (kylin/webapp/app/js/filters/filter.js) > Integrating moment and moment time zone (http://momentjs.com/timezone/docs/) > into the product, would allow correct time zone handling. > For the users who happen to reside in the geographical locations that do > observe day light savings time, usage of GMT-N format is very inconvenient > and info reported by the UI in various places is perplexing. > Needless to say that the GMT moniker itself is long deprecated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (KYLIN-3070) Add a config property for flat table storage format
[ https://issues.apache.org/jira/browse/KYLIN-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI reassigned KYLIN-3070: --- Assignee: (was: Dong Li) Labels: newbie (was: ) Issue Type: Improvement (was: Bug) > Add a config property for flat table storage format > --- > > Key: KYLIN-3070 > URL: https://issues.apache.org/jira/browse/KYLIN-3070 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Affects Versions: v2.2.0 > Environment: HDP 2.5.6, Kylin 2.2.0 >Reporter: Vsevolod Ostapenko >Priority: Minor > Labels: newbie > Original Estimate: 24h > Remaining Estimate: 24h > > Flat table storage format is currently hard-coded as SEQUENCEFILE in the > core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java > That prevents using Impala as a SQL engine while using beeline CLI (via > custom JDBC URL), as Impala cannot write sequence files. > Adding a parameter to kylin.properties to override the default setting would > address the issue. > Removing a hard-coded value for storage format might be good idea in and on > itself. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2986) Segments overlap issue may happen when concurrent merge or build
[ https://issues.apache.org/jira/browse/KYLIN-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273833#comment-16273833 ] liyang commented on KYLIN-2986: --- Why discarding a job didn't delete the related segment, have any one trace down the root cause? > Segments overlap issue may happen when concurrent merge or build > > > Key: KYLIN-2986 > URL: https://issues.apache.org/jira/browse/KYLIN-2986 > Project: Kylin > Issue Type: Bug >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Trivial > Labels: scope > Attachments: screenshot-1.png > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3070) Add a config property for flat table storage format
[ https://issues.apache.org/jira/browse/KYLIN-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273837#comment-16273837 ] RongH commented on KYLIN-3070: -- I want to do it. Could you assign this issue to me? > Add a config property for flat table storage format > --- > > Key: KYLIN-3070 > URL: https://issues.apache.org/jira/browse/KYLIN-3070 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Affects Versions: v2.2.0 > Environment: HDP 2.5.6, Kylin 2.2.0 >Reporter: Vsevolod Ostapenko >Priority: Minor > Labels: newbie > Original Estimate: 24h > Remaining Estimate: 24h > > Flat table storage format is currently hard-coded as SEQUENCEFILE in the > core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java > That prevents using Impala as a SQL engine while using beeline CLI (via > custom JDBC URL), as Impala cannot write sequence files. > Adding a parameter to kylin.properties to override the default setting would > address the issue. > Removing a hard-coded value for storage format might be good idea in and on > itself. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2014) Support multiple languages
[ https://issues.apache.org/jira/browse/KYLIN-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273878#comment-16273878 ] yongjie zhao commented on KYLIN-2014: - this issue looks like #KYLIN-1000, please merge both issue. I can do this feature, could you assign it to me? > Support multiple languages > -- > > Key: KYLIN-2014 > URL: https://issues.apache.org/jira/browse/KYLIN-2014 > Project: Kylin > Issue Type: New Feature > Components: Web >Reporter: Shaofeng SHI > > Till today English is the only language on Kylin's Web GUI; Need to support > multiple languages. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3072) Fix the regular expression in function 'removeCommentInSql'
[ https://issues.apache.org/jira/browse/KYLIN-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274001#comment-16274001 ] peng.jianhua commented on KYLIN-3072: - Hi [~Shaofengshi], I'm sorry. I did not describe this issue clearly. If you still think there is no problem, I will close the issue according to your review. The essence of this problem is that the logic of parsing is flawed. The current logic is as following: 1. Firstly, the "--" was parsed. 2. Secondly, the "/* */" was parsed. Based on the above parsing logic, once the "/* */" contains the "--" and the "*/" and the "--" are in the same line , the parsing will be wrong. Because the "*/" will be removed when the program parses the "--". When parsing the "/* */" again, the program parses fail because the "*/" was removed. What we modify is the wrong logic of the program. Based on the above logic modification, all possible combinations will not be a problem, do you think? > Fix the regular expression in function 'removeCommentInSql' > --- > > Key: KYLIN-3072 > URL: https://issues.apache.org/jira/browse/KYLIN-3072 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch, 01.png, > 02.PNG > > > select * from kylin_sales /\*comments--comments*/ > we should remove comments like '/\*comments*/' first,then remove comments > like '--comments' , or the sql above will have an exception. > please refer to 01.png. > if we exchange the sequence of this two comment patterns,we will get 02.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (KYLIN-3072) Fix the regular expression in function 'removeCommentInSql'
[ https://issues.apache.org/jira/browse/KYLIN-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274001#comment-16274001 ] peng.jianhua edited comment on KYLIN-3072 at 12/1/17 6:21 AM: -- Hi [~Shaofengshi], I'm sorry. I did not describe this issue clearly. If you still think there is no problem, I will close the issue according to your review. The essence of this problem is that the logic of parsing is flawed. The current logic is as following: 1. Firstly, the "--" was parsed. 2. Secondly, the "/* */" was parsed. Based on the above parsing logic, once the "/\* */" contains the "--" and the "\*/" and the "--" are in the same line , the parsing will be wrong. Because the "\*/" will be removed when the program parses the "--". When parsing the "/\* */" again, the program parses fail because the "\*/" was removed. What we modify is the wrong logic of the program. Based on the above logic modification, all possible combinations will not be a problem, do you think? was (Author: peng.jianhua): Hi [~Shaofengshi], I'm sorry. I did not describe this issue clearly. If you still think there is no problem, I will close the issue according to your review. The essence of this problem is that the logic of parsing is flawed. The current logic is as following: 1. Firstly, the "--" was parsed. 2. Secondly, the "/* */" was parsed. Based on the above parsing logic, once the "/* */" contains the "--" and the "*/" and the "--" are in the same line , the parsing will be wrong. Because the "*/" will be removed when the program parses the "--". When parsing the "/* */" again, the program parses fail because the "*/" was removed. What we modify is the wrong logic of the program. Based on the above logic modification, all possible combinations will not be a problem, do you think? > Fix the regular expression in function 'removeCommentInSql' > --- > > Key: KYLIN-3072 > URL: https://issues.apache.org/jira/browse/KYLIN-3072 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch, 01.png, > 02.PNG > > > select * from kylin_sales /\*comments--comments*/ > we should remove comments like '/\*comments*/' first,then remove comments > like '--comments' , or the sql above will have an exception. > please refer to 01.png. > if we exchange the sequence of this two comment patterns,we will get 02.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (KYLIN-3072) Fix the regular expression in function 'removeCommentInSql'
[ https://issues.apache.org/jira/browse/KYLIN-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274001#comment-16274001 ] peng.jianhua edited comment on KYLIN-3072 at 12/1/17 6:22 AM: -- Hi [~Shaofengshi], I'm sorry. I did not describe this issue clearly. If you still think there is no problem, I will close the issue according to your review. The essence of this problem is that the logic of parsing is flawed. The current logic is as following: 1. Firstly, the "--" was parsed. 2. Secondly, the "/* */" was parsed. Based on the above parsing logic, once the "/\* */" contains the "\--" and the "\*/" and the "\--" are in the same line , the parsing will be wrong. Because the "\*/" will be removed when the program parses the "\--". When parsing the "/\* */" again, the program parses fail because the "\*/" was removed. What we modify is the wrong logic of the program. Based on the above logic modification, all possible combinations will not be a problem, do you think? was (Author: peng.jianhua): Hi [~Shaofengshi], I'm sorry. I did not describe this issue clearly. If you still think there is no problem, I will close the issue according to your review. The essence of this problem is that the logic of parsing is flawed. The current logic is as following: 1. Firstly, the "--" was parsed. 2. Secondly, the "/* */" was parsed. Based on the above parsing logic, once the "/\* */" contains the "--" and the "\*/" and the "--" are in the same line , the parsing will be wrong. Because the "\*/" will be removed when the program parses the "--". When parsing the "/\* */" again, the program parses fail because the "\*/" was removed. What we modify is the wrong logic of the program. Based on the above logic modification, all possible combinations will not be a problem, do you think? > Fix the regular expression in function 'removeCommentInSql' > --- > > Key: KYLIN-3072 > URL: https://issues.apache.org/jira/browse/KYLIN-3072 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch, 01.png, > 02.PNG > > > select * from kylin_sales /\*comments--comments*/ > we should remove comments like '/\*comments*/' first,then remove comments > like '--comments' , or the sql above will have an exception. > please refer to 01.png. > if we exchange the sequence of this two comment patterns,we will get 02.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (KYLIN-3072) Fix the regular expression in function 'removeCommentInSql'
[ https://issues.apache.org/jira/browse/KYLIN-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274001#comment-16274001 ] peng.jianhua edited comment on KYLIN-3072 at 12/1/17 6:23 AM: -- Hi [~Shaofengshi], I'm sorry. I did not describe this issue clearly. If you still think there is no problem, I will close the issue according to your review. The essence of this problem is that the logic of parsing is flawed. The current logic is as following: 1. Firstly, the "--" was parsed. 2. Secondly, the "/* */" was parsed. Based on the above parsing logic, once the "/\* */" contains the "\-\-" and the "\*/" and the "\-\-" are in the same line , the parsing will be wrong. Because the "\*/" will be removed when the program parses the "\--". When parsing the "/\* */" again, the program parses fail because the "\*/" was removed. What we modify is the wrong logic of the program. Based on the above logic modification, all possible combinations will not be a problem, do you think? was (Author: peng.jianhua): Hi [~Shaofengshi], I'm sorry. I did not describe this issue clearly. If you still think there is no problem, I will close the issue according to your review. The essence of this problem is that the logic of parsing is flawed. The current logic is as following: 1. Firstly, the "--" was parsed. 2. Secondly, the "/* */" was parsed. Based on the above parsing logic, once the "/\* */" contains the "\--" and the "\*/" and the "\--" are in the same line , the parsing will be wrong. Because the "\*/" will be removed when the program parses the "\--". When parsing the "/\* */" again, the program parses fail because the "\*/" was removed. What we modify is the wrong logic of the program. Based on the above logic modification, all possible combinations will not be a problem, do you think? > Fix the regular expression in function 'removeCommentInSql' > --- > > Key: KYLIN-3072 > URL: https://issues.apache.org/jira/browse/KYLIN-3072 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch, 01.png, > 02.PNG > > > select * from kylin_sales /\*comments--comments*/ > we should remove comments like '/\*comments*/' first,then remove comments > like '--comments' , or the sql above will have an exception. > please refer to 01.png. > if we exchange the sequence of this two comment patterns,we will get 02.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3031) KeywordDefaultDirtyHack should ignore case of default like other database does
[ https://issues.apache.org/jira/browse/KYLIN-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274015#comment-16274015 ] liyang commented on KYLIN-3031: --- Commit merged. https://github.com/apache/kylin/commit/a94b4796a6c4732af7b138e46f844d89bcdac8d9 > KeywordDefaultDirtyHack should ignore case of default like other database does > -- > > Key: KYLIN-3031 > URL: https://issues.apache.org/jira/browse/KYLIN-3031 > Project: Kylin > Issue Type: Bug >Reporter: Zhong Yanghong >Assignee: liyang > Attachments: APACHE-KYLIN-3031.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (KYLIN-3031) KeywordDefaultDirtyHack should ignore case of default like other database does
[ https://issues.apache.org/jira/browse/KYLIN-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liyang resolved KYLIN-3031. --- Resolution: Fixed Fix Version/s: v2.3.0 > KeywordDefaultDirtyHack should ignore case of default like other database does > -- > > Key: KYLIN-3031 > URL: https://issues.apache.org/jira/browse/KYLIN-3031 > Project: Kylin > Issue Type: Bug >Reporter: Zhong Yanghong >Assignee: liyang > Fix For: v2.3.0 > > Attachments: APACHE-KYLIN-3031.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3059) Query got IllegalArgumentException
[
https://issues.apache.org/jira/browse/KYLIN-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274017#comment-16274017
]
liyang commented on KYLIN-3059:
---
Thanks for the good report. From this and a few related reports, we have
identified that the metadata cache mechanism can corrupt in certain concurrency
scenarios. Will attempt a fix soon.
> Query got IllegalArgumentException
> --
>
> Key: KYLIN-3059
> URL: https://issues.apache.org/jira/browse/KYLIN-3059
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: v1.6.0
> Environment: apache-kylin-1.6.0-hbase1.x
> apache hadoop 2.7.2
> hbase-1.2.4
>Reporter: Xingxing Di
>Assignee: liyang
> Attachments: query.log
>
>
> A query got an exception , the error trace was :
> {code:java}
> Caused by: java.lang.IllegalArgumentException
> at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:76)
> at
> org.apache.kylin.metadata.model.TblColRef.(TblColRef.java:105)
> at
> org.apache.kylin.metadata.model.TblColRef.columnForUnknownModel(TblColRef.java:74)
> at
> org.apache.kylin.query.relnode.OLAPTableScan.buildColumnRowType(OLAPTableScan.java:231)
> {code}
> the code is :
> {code:java}
> TblColRef(TableRef table, ColumnDesc column) {
> checkArgument(table.getTableDesc() == column.getTable()); // this
> line cause exception
> this.table = table;
> this.column = column;
> }
> {code}
> and after we did "Reload metadata", query executed successful.
> I dont know what will cause this exception, i think it may related to
> ProjectL2Cache or ProjectManager.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KYLIN-3059) Query got IllegalArgumentException
[
https://issues.apache.org/jira/browse/KYLIN-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274038#comment-16274038
]
Xingxing Di commented on KYLIN-3059:
[~liyang.g...@gmail.com] Happy to hear that .
I saw this in kylin2.2 :
{code:java}
TblColRef(TableRef table, ColumnDesc column) {
checkArgument(table.getTableDesc().getIdentity().equals(column.getTable().getIdentity()));
this.table = table;
this.column = column;
}
{code}
I had merge this into our kylin(v 1.6) , I'm not sure if that can resolve the
problem.
> Query got IllegalArgumentException
> --
>
> Key: KYLIN-3059
> URL: https://issues.apache.org/jira/browse/KYLIN-3059
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: v1.6.0
> Environment: apache-kylin-1.6.0-hbase1.x
> apache hadoop 2.7.2
> hbase-1.2.4
>Reporter: Xingxing Di
>Assignee: liyang
> Attachments: query.log
>
>
> A query got an exception , the error trace was :
> {code:java}
> Caused by: java.lang.IllegalArgumentException
> at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:76)
> at
> org.apache.kylin.metadata.model.TblColRef.(TblColRef.java:105)
> at
> org.apache.kylin.metadata.model.TblColRef.columnForUnknownModel(TblColRef.java:74)
> at
> org.apache.kylin.query.relnode.OLAPTableScan.buildColumnRowType(OLAPTableScan.java:231)
> {code}
> the code is :
> {code:java}
> TblColRef(TableRef table, ColumnDesc column) {
> checkArgument(table.getTableDesc() == column.getTable()); // this
> line cause exception
> this.table = table;
> this.column = column;
> }
> {code}
> and after we did "Reload metadata", query executed successful.
> I dont know what will cause this exception, i think it may related to
> ProjectL2Cache or ProjectManager.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (KYLIN-3059) Query got IllegalArgumentException
[
https://issues.apache.org/jira/browse/KYLIN-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274038#comment-16274038
]
Xingxing Di edited comment on KYLIN-3059 at 12/1/17 7:04 AM:
-
[~liyang.g...@gmail.com] Happy to hear that .
I saw this in kylin2.2 :
{code:java}
TblColRef(TableRef table, ColumnDesc column) {
checkArgument(table.getTableDesc().getIdentity().equals(column.getTable().getIdentity()));
this.table = table;
this.column = column;
}
{code}
I had merge this into our kylin (v1.6) , I'm not sure if that can resolve the
problem.
was (Author: dixingx...@yeah.net):
[~liyang.g...@gmail.com] Happy to hear that .
I saw this in kylin2.2 :
{code:java}
TblColRef(TableRef table, ColumnDesc column) {
checkArgument(table.getTableDesc().getIdentity().equals(column.getTable().getIdentity()));
this.table = table;
this.column = column;
}
{code}
I had merge this into our kylin(v 1.6) , I'm not sure if that can resolve the
problem.
> Query got IllegalArgumentException
> --
>
> Key: KYLIN-3059
> URL: https://issues.apache.org/jira/browse/KYLIN-3059
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: v1.6.0
> Environment: apache-kylin-1.6.0-hbase1.x
> apache hadoop 2.7.2
> hbase-1.2.4
>Reporter: Xingxing Di
>Assignee: liyang
> Attachments: query.log
>
>
> A query got an exception , the error trace was :
> {code:java}
> Caused by: java.lang.IllegalArgumentException
> at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:76)
> at
> org.apache.kylin.metadata.model.TblColRef.(TblColRef.java:105)
> at
> org.apache.kylin.metadata.model.TblColRef.columnForUnknownModel(TblColRef.java:74)
> at
> org.apache.kylin.query.relnode.OLAPTableScan.buildColumnRowType(OLAPTableScan.java:231)
> {code}
> the code is :
> {code:java}
> TblColRef(TableRef table, ColumnDesc column) {
> checkArgument(table.getTableDesc() == column.getTable()); // this
> line cause exception
> this.table = table;
> this.column = column;
> }
> {code}
> and after we did "Reload metadata", query executed successful.
> I dont know what will cause this exception, i think it may related to
> ProjectL2Cache or ProjectManager.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (KYLIN-1000) i18n and localization support
[ https://issues.apache.org/jira/browse/KYLIN-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI reassigned KYLIN-1000: --- Assignee: yongjie zhao (was: Zhong,Jason) Issue Type: Wish (was: New Feature) Yong jie, please go ahead. Thanks! > i18n and localization support > - > > Key: KYLIN-1000 > URL: https://issues.apache.org/jira/browse/KYLIN-1000 > Project: Kylin > Issue Type: Wish > Components: Web >Affects Versions: v1.0, v1.4.0 >Reporter: Luke Han >Assignee: yongjie zhao > > There are many use cases of Apache Kylin are requiring to support other > language rather than English, like Chinese, Japanese, EU side and others. > Open this JIRA to tracking internationalization and localization of Kylin. > The first phase is to support multi-language of web UI, like Chinese. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2014) Support multiple languages
[ https://issues.apache.org/jira/browse/KYLIN-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274045#comment-16274045 ] Shaofeng SHI commented on KYLIN-2014: - Thanks Yongjie, let's use KYLIN-1000 to track and then close this one. I have change the assignee of KYLIN-1000 to you, your contribution is welcomed. > Support multiple languages > -- > > Key: KYLIN-2014 > URL: https://issues.apache.org/jira/browse/KYLIN-2014 > Project: Kylin > Issue Type: New Feature > Components: Web >Reporter: Shaofeng SHI > > Till today English is the only language on Kylin's Web GUI; Need to support > multiple languages. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (KYLIN-2014) Support multiple languages
[ https://issues.apache.org/jira/browse/KYLIN-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI closed KYLIN-2014. --- Resolution: Duplicate > Support multiple languages > -- > > Key: KYLIN-2014 > URL: https://issues.apache.org/jira/browse/KYLIN-2014 > Project: Kylin > Issue Type: New Feature > Components: Web >Reporter: Shaofeng SHI > > Till today English is the only language on Kylin's Web GUI; Need to support > multiple languages. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
