[jira] [Created] (KYLIN-3266) Improve CI coverage
liyang created KYLIN-3266: - Summary: Improve CI coverage Key: KYLIN-3266 URL: https://issues.apache.org/jira/browse/KYLIN-3266 Project: Kylin Issue Type: Improvement Reporter: liyang Assignee: liyang The current CI, aka BuildCubeWithEngine, only test merge on the MR engine. The merge operation is not tested on Spark engine. Need to improve the test coverage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (KYLIN-2964) AclEntity operation issue
[ https://issues.apache.org/jira/browse/KYLIN-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian closed KYLIN-2964. -- Resolution: Fixed The issue is resolved by KYLIN-2555, it is better this patch. > AclEntity operation issue > -- > > Key: KYLIN-2964 > URL: https://issues.apache.org/jira/browse/KYLIN-2964 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.1.0 >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN_2964.patch > > > When user add/update/delete access for AclEntity (project, model, cube, job), > which will check user exist. But if there are two user not exist, which will > cause issue. Admin want to delete the notExistsUser1, it will throws > notExistsUser2 not exist. The other operation has same issues for this check. > Could we add another method for checkExistUser and just add the method for > add or update? It should be fix this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3262) Produce jacoco exec files for integration test
[ https://issues.apache.org/jira/browse/KYLIN-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375377#comment-16375377 ] Zhong Yanghong commented on KYLIN-3262: --- [~yimingliu], it's an easy way to config the path for jacocoagent.jar. There should be some better way. > Produce jacoco exec files for integration test > -- > > Key: KYLIN-3262 > URL: https://issues.apache.org/jira/browse/KYLIN-3262 > Project: Kylin > Issue Type: Task >Reporter: Zhong Yanghong >Priority: Major > Attachments: APACHE-KYLIN-3262.patch > > > Currently to calculate code coverage, kylin only considers UT. However, IT > also covers lots of code. It's better to include this for code coverage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375358#comment-16375358 ] ASF GitHub Bot commented on KYLIN-2884: --- codecov-io commented on issue #105: KYLIN-2884 Add delete segment function for portal - bug fix URL: https://github.com/apache/kylin/pull/105#issuecomment-368205395 # [Codecov](https://codecov.io/gh/apache/kylin/pull/105?src=pr=h1) Report > Merging [#105](https://codecov.io/gh/apache/kylin/pull/105?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/66ea154ecee74a18066e9b6ea706e7232fb19bf5?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/105?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #105 +/- ## - Coverage 21.47% 21.47% -0.01% + Complexity 3822 3820 -2 Files 992 992 Lines 5973459734 Branches 8638 8638 - Hits 1282612825 -1 - Misses4572745728 +1 Partials 1181 1181 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/105?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...apache/kylin/job/execution/AbstractExecutable.java](https://codecov.io/gh/apache/kylin/pull/105/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQWJzdHJhY3RFeGVjdXRhYmxlLmphdmE=) | `51.69% <0%> (-1.45%)` | `46% <0%> (-2%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/105/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.31%)` | `7% <0%> (ø)` | | | [...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/105/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=) | `55.72% <0%> (+0.49%)` | `21% <0%> (ø)` | :arrow_down: | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/105/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `72.29% <0%> (+1.35%)` | `8% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/105?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/105?src=pr=footer). Last update [66ea154...23641a2](https://codecov.io/gh/apache/kylin/pull/105?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375354#comment-16375354 ] ASF GitHub Bot commented on KYLIN-2884: --- coveralls commented on issue #105: KYLIN-2884 Add delete segment function for portal - bug fix URL: https://github.com/apache/kylin/pull/105#issuecomment-368205238 ## Pull Request Test Coverage Report for [Build 2997](https://coveralls.io/builds/15677654) * **0** of **0** **(NaN%)** changed or added relevant lines in **0** files are covered. * **6** unchanged lines in **2** files lost coverage. * Overall coverage decreased (**-0.002%**) to **23.451%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java](https://coveralls.io/builds/15677654/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fexecution%2FAbstractExecutable.java#L157) | 1 | 58.94% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15677654/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | Totals | [](https://coveralls.io/builds/15677654) | | :-- | --: | | Change from base [Build 2992](https://coveralls.io/builds/15667361): | -0.002% | | Covered Lines: | 14008 | | Relevant Lines: | 59734 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375348#comment-16375348 ] Pan, Julian commented on KYLIN-2884: Hi [~Zhixiong Chen], I create a pull request: [https://github.com/apache/kylin/pull/105] Please merge, thanks. > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375345#comment-16375345 ] ASF GitHub Bot commented on KYLIN-2884: --- sanjulian opened a new pull request #105: KYLIN-2884 Add delete segment function for portal - bug fix URL: https://github.com/apache/kylin/pull/105 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375347#comment-16375347 ] ASF GitHub Bot commented on KYLIN-2884: --- asfgit commented on issue #105: KYLIN-2884 Add delete segment function for portal - bug fix URL: https://github.com/apache/kylin/pull/105#issuecomment-36820 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3265) Add "jobSearchMode" as a condition to "/kylin/jobs" API
[ https://issues.apache.org/jira/browse/KYLIN-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375320#comment-16375320 ] Shaofeng SHI commented on KYLIN-3265: - [~yaho] yanghong, pelase review this patch. Now the default behavior is loading only cubing jobs. If need fetch all, just change the front end side to pass the new parameter with 'all' > Add "jobSearchMode" as a condition to "/kylin/jobs" API > --- > > Key: KYLIN-3265 > URL: https://issues.apache.org/jira/browse/KYLIN-3265 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Affects Versions: v2.3.0 >Reporter: Shaofeng SHI >Priority: Major > Attachments: KYLIN-3265.master.001.patch > > > In kylin 2.3, the "/kylin/jobs" API will return both cubing job and > checkpoint job together, this changed the API's behavior as there isn't > checkpoint job before. We should keep the api only return cubing jobs to be > compitable as before, and extend the API to add another condition > 'jobSearchMode' to determine which kind of job should be returned. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3265) Add "jobSearchMode" as a condition to "/kylin/jobs" API
[ https://issues.apache.org/jira/browse/KYLIN-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-3265: Attachment: KYLIN-3265.master.001.patch > Add "jobSearchMode" as a condition to "/kylin/jobs" API > --- > > Key: KYLIN-3265 > URL: https://issues.apache.org/jira/browse/KYLIN-3265 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Affects Versions: v2.3.0 >Reporter: Shaofeng SHI >Priority: Major > Attachments: KYLIN-3265.master.001.patch > > > In kylin 2.3, the "/kylin/jobs" API will return both cubing job and > checkpoint job together, this changed the API's behavior as there isn't > checkpoint job before. We should keep the api only return cubing jobs to be > compitable as before, and extend the API to add another condition > 'jobSearchMode' to determine which kind of job should be returned. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375314#comment-16375314 ] Zhixiong Chen edited comment on KYLIN-2884 at 2/24/18 5:34 AM: --- OK, this patch is fine with me. [~julianpan] Could you make a pull request about this patch in master branch. Then I will merge it. was (Author: zhixiong chen): OK, then this patch is fine with me. > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375314#comment-16375314 ] Zhixiong Chen commented on KYLIN-2884: -- OK, then this patch is fine with me. > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3262) Produce jacoco exec files for integration test
[ https://issues.apache.org/jira/browse/KYLIN-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhong Yanghong updated KYLIN-3262: -- Attachment: APACHE-KYLIN-3262.patch > Produce jacoco exec files for integration test > -- > > Key: KYLIN-3262 > URL: https://issues.apache.org/jira/browse/KYLIN-3262 > Project: Kylin > Issue Type: Task >Reporter: Zhong Yanghong >Priority: Major > Attachments: APACHE-KYLIN-3262.patch > > > Currently to calculate code coverage, kylin only considers UT. However, IT > also covers lots of code. It's better to include this for code coverage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3262) Produce jacoco exec files for integration test
[ https://issues.apache.org/jira/browse/KYLIN-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhong Yanghong updated KYLIN-3262: -- Attachment: APACHE-KYLIN-3262.patch > Produce jacoco exec files for integration test > -- > > Key: KYLIN-3262 > URL: https://issues.apache.org/jira/browse/KYLIN-3262 > Project: Kylin > Issue Type: Task >Reporter: Zhong Yanghong >Priority: Major > > Currently to calculate code coverage, kylin only considers UT. However, IT > also covers lots of code. It's better to include this for code coverage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3262) Produce jacoco exec files for integration test
[ https://issues.apache.org/jira/browse/KYLIN-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhong Yanghong updated KYLIN-3262: -- Attachment: (was: APACHE-KYLIN-3262.patch) > Produce jacoco exec files for integration test > -- > > Key: KYLIN-3262 > URL: https://issues.apache.org/jira/browse/KYLIN-3262 > Project: Kylin > Issue Type: Task >Reporter: Zhong Yanghong >Priority: Major > > Currently to calculate code coverage, kylin only considers UT. However, IT > also covers lots of code. It's better to include this for code coverage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (KYLIN-2913) Enable job retry for configurable exceptions
[ https://issues.apache.org/jira/browse/KYLIN-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Li resolved KYLIN-2913. Resolution: Fixed this issue has been fixed at *https://issues.apache.org/jira/browse/KYLIN-3263* > Enable job retry for configurable exceptions > > > Key: KYLIN-2913 > URL: https://issues.apache.org/jira/browse/KYLIN-2913 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Affects Versions: v2.1.0 >Reporter: Wang, Gang >Assignee: Wang, Gang >Priority: Minor > Fix For: v2.3.0 > > Attachments: > 0001-KYLIN-2913-Enable-job-retry-for-configurable-excepti.patch > > > In our production environment, we always get some certain exceptions from > Hadoop or HBase, like > "org.apache.kylin.job.exception.NoEnoughReplicationException", > "java.util.ConcurrentModificationException", which results in job failure. > While, these exceptions can be handled by retry actually. So, it will be much > more convenient if we are able to make job retry on some configurable > exceptions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (KYLIN-3264) kylin.job.retry=1 cause build error
[ https://issues.apache.org/jira/browse/KYLIN-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Billy Liu resolved KYLIN-3264. -- Resolution: Duplicate Fix Version/s: v2.3.0 > kylin.job.retry=1 cause build error > --- > > Key: KYLIN-3264 > URL: https://issues.apache.org/jira/browse/KYLIN-3264 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: v2.3.0 >Reporter: readme_kylin >Priority: Major > Fix For: v2.3.0 > > > when i set kylin.job.retry to 1,it cause build error at 6 step :Create HTable > . > here is the error info. > java.lang.RuntimeException: HBase table KYLIN230_CFJ854DYZ4 exists! > at > org.apache.kylin.storage.hbase.steps.CubeHTableUtil.createHTable(CubeHTableUtil.java:100) > at > org.apache.kylin.storage.hbase.steps.CreateHTableJob.run(CreateHTableJob.java:111) > at org.apache.kylin.engine.mr.MRUtil.runMRJob(MRUtil.java:97) > at > org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:63) > at > org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:162) > at > org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:67) > at > org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:162) > at > org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:300) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:745) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375284#comment-16375284 ] Pan, Julian commented on KYLIN-2884: Thanks for your reply, here is the patch attached. You are right, the reason I put the loadDetail(cube) in click action is related to our internal streaming branch (will contribute soon) which need dynamic change action menu. I will do some refactor when we contribute back for this part, but in this release it should be keep the same as previous we did. > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2884: --- Attachment: KYLIN-2884.patch > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3265) Add "jobSearchMode" as a condition to "/kylin/jobs" API
Shaofeng SHI created KYLIN-3265: --- Summary: Add "jobSearchMode" as a condition to "/kylin/jobs" API Key: KYLIN-3265 URL: https://issues.apache.org/jira/browse/KYLIN-3265 Project: Kylin Issue Type: Improvement Components: REST Service Affects Versions: v2.3.0 Reporter: Shaofeng SHI In kylin 2.3, the "/kylin/jobs" API will return both cubing job and checkpoint job together, this changed the API's behavior as there isn't checkpoint job before. We should keep the api only return cubing jobs to be compitable as before, and extend the API to add another condition 'jobSearchMode' to determine which kind of job should be returned. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3264) kylin.job.retry=1 cause build error
readme_kylin created KYLIN-3264: --- Summary: kylin.job.retry=1 cause build error Key: KYLIN-3264 URL: https://issues.apache.org/jira/browse/KYLIN-3264 Project: Kylin Issue Type: Bug Components: Job Engine Affects Versions: v2.3.0 Reporter: readme_kylin when i set kylin.job.retry to 1,it cause build error at 6 step :Create HTable . here is the error info. java.lang.RuntimeException: HBase table KYLIN230_CFJ854DYZ4 exists! at org.apache.kylin.storage.hbase.steps.CubeHTableUtil.createHTable(CubeHTableUtil.java:100) at org.apache.kylin.storage.hbase.steps.CreateHTableJob.run(CreateHTableJob.java:111) at org.apache.kylin.engine.mr.MRUtil.runMRJob(MRUtil.java:97) at org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:63) at org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:162) at org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:67) at org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:162) at org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:300) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (KYLIN-3263) AbstractExecutable's retry has problem
[ https://issues.apache.org/jira/browse/KYLIN-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Billy Liu resolved KYLIN-3263. -- Resolution: Fixed Fix Version/s: v2.3.0 > AbstractExecutable's retry has problem > -- > > Key: KYLIN-3263 > URL: https://issues.apache.org/jira/browse/KYLIN-3263 > Project: Kylin > Issue Type: Bug >Reporter: jiatao.tao >Assignee: jiatao.tao >Priority: Major > Fix For: v2.3.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3263) AbstractExecutable's retry has problem
[
https://issues.apache.org/jira/browse/KYLIN-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374486#comment-16374486
]
ASF GitHub Bot commented on KYLIN-3263:
---
yiming187 closed pull request #104: KYLIN-3263, bugfix with
AbstractExecutable's retry.
URL: https://github.com/apache/kylin/pull/104
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
b/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
index 91283f0f2d..dbe11c2ea3 100644
---
a/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
+++
b/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
@@ -165,7 +165,7 @@ public final ExecuteResult execute(ExecutableContext
executableContext) throws E
exception = e;
}
retry++;
-} while (needRetry(result, exception));
+} while (needRetry(this.retry, exception)); //exception in
ExecuteResult should handle by user itself.
if (exception != null) {
onExecuteError(exception, executableContext);
@@ -221,13 +221,6 @@ private boolean isMetaDataPersistException(Exception e) {
return false;
}
-private boolean isRetryableExecutionResult(ExecuteResult result) {
-if (result != null && result.getThrowable() != null &&
isRetrableException(result.getThrowable())) {
-return true;
-}
-return false;
-}
-
protected abstract ExecuteResult doWork(ExecutableContext context) throws
ExecuteException;
@Override
@@ -468,25 +461,20 @@ protected final boolean isPaused() {
return status == ExecutableState.STOPPED;
}
-protected boolean isRetrableException(Throwable t) {
-return
ArrayUtils.contains(KylinConfig.getInstanceFromEnv().getJobRetryExceptions(),
t.getClass().getName());
-}
-
// Retry will happen in below cases:
// 1) if property "kylin.job.retry-exception-classes" is not set or is
null, all jobs with exceptions will retry according to the retry times.
// 2) if property "kylin.job.retry-exception-classes" is set and is not
null, only jobs with the specified exceptions will retry according to the retry
times.
-protected boolean needRetry(ExecuteResult result, Throwable e) {
-if (this.retry > KylinConfig.getInstanceFromEnv().getJobRetry()) {
+public static boolean needRetry(int retry, Throwable t) {
+if (retry > KylinConfig.getInstanceFromEnv().getJobRetry() || t ==
null) {
return false;
+} else {
+return isRetryableException(t.getClass().getName());
}
-String[] retryableEx =
KylinConfig.getInstanceFromEnv().getJobRetryExceptions();
-if (retryableEx == null || retryableEx.length == 0) {
-return true;
-}
-if ((result != null && isRetryableExecutionResult(result)) || e !=
null && isRetrableException(e)) {
-return true;
-}
-return false;
+}
+
+private static boolean isRetryableException(String exceptionName) {
+String[] jobRetryExceptions =
KylinConfig.getInstanceFromEnv().getJobRetryExceptions();
+return ArrayUtils.isEmpty(jobRetryExceptions) ||
ArrayUtils.contains(jobRetryExceptions, exceptionName);
}
@Override
diff --git
a/core-job/src/test/java/org/apache/kylin/job/RetryableTestExecutable.java
b/core-job/src/test/java/org/apache/kylin/job/RetryableTestExecutable.java
deleted file mode 100644
index f656c44058..00
--- a/core-job/src/test/java/org/apache/kylin/job/RetryableTestExecutable.java
+++ /dev/null
@@ -1,50 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.kylin.job;
-
-import org.apache.kylin.common.KylinConfig;
-import
[jira] [Commented] (KYLIN-3263) AbstractExecutable's retry has problem
[ https://issues.apache.org/jira/browse/KYLIN-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374487#comment-16374487 ] ASF subversion and git services commented on KYLIN-3263: Commit 74dff9fa36ea937e947a0cc5a96f373d7c2f372d in kylin's branch refs/heads/master from [~Aron.tao] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=74dff9f ] KYLIN-3263, bugfix with AbstractExecutable's retry. > AbstractExecutable's retry has problem > -- > > Key: KYLIN-3263 > URL: https://issues.apache.org/jira/browse/KYLIN-3263 > Project: Kylin > Issue Type: Bug >Reporter: jiatao.tao >Assignee: jiatao.tao >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3263) AbstractExecutable's retry has problem
[ https://issues.apache.org/jira/browse/KYLIN-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374488#comment-16374488 ] ASF subversion and git services commented on KYLIN-3263: Commit 66ea154ecee74a18066e9b6ea706e7232fb19bf5 in kylin's branch refs/heads/master from [~liuyiming.vip] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=66ea154 ] Merge pull request #104 from tttMelody/master KYLIN-3263, bugfix with AbstractExecutable's retry. > AbstractExecutable's retry has problem > -- > > Key: KYLIN-3263 > URL: https://issues.apache.org/jira/browse/KYLIN-3263 > Project: Kylin > Issue Type: Bug >Reporter: jiatao.tao >Assignee: jiatao.tao >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374345#comment-16374345 ] Zhixiong Chen commented on KYLIN-2884: -- Hi,[~julianpan] You don't need combine 2 commits. But could you put 'loadDetail(cube)' into function 'startDeleteSegment' like cube's merge action? Because it can reduce the call of api. > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3263) AbstractExecutable's retry has problem
[ https://issues.apache.org/jira/browse/KYLIN-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374232#comment-16374232 ] ASF GitHub Bot commented on KYLIN-3263: --- coveralls commented on issue #104: KYLIN-3263, bugfix with AbstractExecutable's retry. URL: https://github.com/apache/kylin/pull/104#issuecomment-367983164 ## Pull Request Test Coverage Report for [Build 2991](https://coveralls.io/builds/15663717) * **5** of **5** **(100.0%)** changed or added relevant lines in **1** file are covered. * **7** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.001%**) to **23.441%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15663717/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L193) | 7 | 76.29% | | Totals | [](https://coveralls.io/builds/15663717) | | :-- | --: | | Change from base [Build 2978](https://coveralls.io/builds/15605811): | 0.001% | | Covered Lines: | 14002 | | Relevant Lines: | 59734 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > AbstractExecutable's retry has problem > -- > > Key: KYLIN-3263 > URL: https://issues.apache.org/jira/browse/KYLIN-3263 > Project: Kylin > Issue Type: Bug >Reporter: jiatao.tao >Assignee: jiatao.tao >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3263) AbstractExecutable's retry has problem
[ https://issues.apache.org/jira/browse/KYLIN-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374229#comment-16374229 ] ASF GitHub Bot commented on KYLIN-3263: --- codecov-io commented on issue #104: KYLIN-3263, bugfix with AbstractExecutable's retry. URL: https://github.com/apache/kylin/pull/104#issuecomment-367982611 # [Codecov](https://codecov.io/gh/apache/kylin/pull/104?src=pr=h1) Report > Merging [#104](https://codecov.io/gh/apache/kylin/pull/104?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/21ef4d6e4bb62eb3f5209b14daaa8ab404d0f4c5?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `80%`. [](https://codecov.io/gh/apache/kylin/pull/104?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #104 +/- ## - Coverage 21.45% 21.45% -0.01% - Complexity 3815 3819 +4 Files 992 992 Lines 5974159734 -7 Branches 8639 8638 -1 - Hits 1281912813 -6 + Misses4574045734 -6 - Partials 1182 1187 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/104?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...apache/kylin/job/execution/AbstractExecutable.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQWJzdHJhY3RFeGVjdXRhYmxlLmphdmE=) | `51.69% <80%> (+3.55%)` | `46 <6> (+5)` | :arrow_up: | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `66.56% <0%> (-3.65%)` | `7% <0%> (ø)` | | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `65.35% <0%> (+0.78%)` | `0% <0%> (ø)` | :arrow_down: | | [...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=) | `55.72% <0%> (+0.99%)` | `21% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/104?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/104?src=pr=footer). Last update [21ef4d6...74dff9f](https://codecov.io/gh/apache/kylin/pull/104?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > AbstractExecutable's retry has problem > -- > > Key: KYLIN-3263 > URL: https://issues.apache.org/jira/browse/KYLIN-3263 > Project: Kylin > Issue Type: Bug >Reporter: jiatao.tao >Assignee: jiatao.tao >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374209#comment-16374209 ] Pan, Julian edited comment on KYLIN-2884 at 2/23/18 10:58 AM: -- I add new patch for it. I'm not sure whether it need combine or not. Please let me know, if it need combine 2 commits. was (Author: julianpan): I add new patch for it. I'm not sure whether it need separate or not. Please let me know, if it need separate 2 commit. > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2884: --- Attachment: KYLIN-2884.patch > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2884: --- Attachment: (was: KYLIN-2884.patch) > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374209#comment-16374209 ] Pan, Julian commented on KYLIN-2884: I add new patch for it. I'm not sure whether it need separate or not. Please let me know, if it need separate 2 commit. > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian updated KYLIN-2884: --- Attachment: KYLIN-2884.patch > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3263) AbstractExecutable's retry has problem
jiatao.tao created KYLIN-3263: - Summary: AbstractExecutable's retry has problem Key: KYLIN-3263 URL: https://issues.apache.org/jira/browse/KYLIN-3263 Project: Kylin Issue Type: Bug Reporter: jiatao.tao Assignee: jiatao.tao -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374058#comment-16374058 ] Pan, Julian commented on KYLIN-2884: Sorry for late reply, I forgot another patch for this. I will create a patch soon. > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.3.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
