[jira] [Commented] (KYLIN-3265) Add "jobSearchMode" as a condition to "/kylin/api/jobs" API
[ https://issues.apache.org/jira/browse/KYLIN-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375889#comment-16375889 ] Shaofeng SHI commented on KYLIN-3265: - Patch updated, please check. [~yaho] > Add "jobSearchMode" as a condition to "/kylin/api/jobs" API > --- > > Key: KYLIN-3265 > URL: https://issues.apache.org/jira/browse/KYLIN-3265 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Affects Versions: v2.3.0 >Reporter: Shaofeng SHI >Priority: Major > Attachments: KYLIN-3265.master.002.patch, KYLIN-3265.master.002.patch > > > In kylin 2.3, the "/kylin/jobs" API will return both cubing job and > checkpoint job together, this changed the API's behavior as there isn't > checkpoint job before. We should keep the api only return cubing jobs to be > compitable as before, and extend the API to add another condition > 'jobSearchMode' to determine which kind of job should be returned. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3265) Add "jobSearchMode" as a condition to "/kylin/api/jobs" API
[ https://issues.apache.org/jira/browse/KYLIN-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-3265: Attachment: (was: KYLIN-3265.master.001.patch) > Add "jobSearchMode" as a condition to "/kylin/api/jobs" API > --- > > Key: KYLIN-3265 > URL: https://issues.apache.org/jira/browse/KYLIN-3265 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Affects Versions: v2.3.0 >Reporter: Shaofeng SHI >Priority: Major > Attachments: KYLIN-3265.master.002.patch, KYLIN-3265.master.002.patch > > > In kylin 2.3, the "/kylin/jobs" API will return both cubing job and > checkpoint job together, this changed the API's behavior as there isn't > checkpoint job before. We should keep the api only return cubing jobs to be > compitable as before, and extend the API to add another condition > 'jobSearchMode' to determine which kind of job should be returned. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3265) Add "jobSearchMode" as a condition to "/kylin/api/jobs" API
[ https://issues.apache.org/jira/browse/KYLIN-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-3265: Attachment: KYLIN-3265.master.002.patch > Add "jobSearchMode" as a condition to "/kylin/api/jobs" API > --- > > Key: KYLIN-3265 > URL: https://issues.apache.org/jira/browse/KYLIN-3265 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Affects Versions: v2.3.0 >Reporter: Shaofeng SHI >Priority: Major > Attachments: KYLIN-3265.master.001.patch, > KYLIN-3265.master.002.patch, KYLIN-3265.master.002.patch > > > In kylin 2.3, the "/kylin/jobs" API will return both cubing job and > checkpoint job together, this changed the API's behavior as there isn't > checkpoint job before. We should keep the api only return cubing jobs to be > compitable as before, and extend the API to add another condition > 'jobSearchMode' to determine which kind of job should be returned. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3265) Add "jobSearchMode" as a condition to "/kylin/api/jobs" API
[ https://issues.apache.org/jira/browse/KYLIN-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-3265: Attachment: KYLIN-3265.master.002.patch > Add "jobSearchMode" as a condition to "/kylin/api/jobs" API > --- > > Key: KYLIN-3265 > URL: https://issues.apache.org/jira/browse/KYLIN-3265 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Affects Versions: v2.3.0 >Reporter: Shaofeng SHI >Priority: Major > Attachments: KYLIN-3265.master.001.patch, KYLIN-3265.master.002.patch > > > In kylin 2.3, the "/kylin/jobs" API will return both cubing job and > checkpoint job together, this changed the API's behavior as there isn't > checkpoint job before. We should keep the api only return cubing jobs to be > compitable as before, and extend the API to add another condition > 'jobSearchMode' to determine which kind of job should be returned. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3265) Add "jobSearchMode" as a condition to "/kylin/api/jobs" API
[ https://issues.apache.org/jira/browse/KYLIN-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375888#comment-16375888 ] Shaofeng SHI commented on KYLIN-3265: - Hi Yanghong, This is a new added parameter, and it is optional, so won't impact the interface. For the second concern, it won't return null but may throw IllegalArgumentException, so I will add a check for that. Thanks for the comment. > Add "jobSearchMode" as a condition to "/kylin/api/jobs" API > --- > > Key: KYLIN-3265 > URL: https://issues.apache.org/jira/browse/KYLIN-3265 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Affects Versions: v2.3.0 >Reporter: Shaofeng SHI >Priority: Major > Attachments: KYLIN-3265.master.001.patch > > > In kylin 2.3, the "/kylin/jobs" API will return both cubing job and > checkpoint job together, this changed the API's behavior as there isn't > checkpoint job before. We should keep the api only return cubing jobs to be > compitable as before, and extend the API to add another condition > 'jobSearchMode' to determine which kind of job should be returned. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3265) Add "jobSearchMode" as a condition to "/kylin/api/jobs" API
[ https://issues.apache.org/jira/browse/KYLIN-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-3265: Summary: Add "jobSearchMode" as a condition to "/kylin/api/jobs" API (was: Add "jobSearchMode" as a condition to "/kylin/jobs" API) > Add "jobSearchMode" as a condition to "/kylin/api/jobs" API > --- > > Key: KYLIN-3265 > URL: https://issues.apache.org/jira/browse/KYLIN-3265 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Affects Versions: v2.3.0 >Reporter: Shaofeng SHI >Priority: Major > Attachments: KYLIN-3265.master.001.patch > > > In kylin 2.3, the "/kylin/jobs" API will return both cubing job and > checkpoint job together, this changed the API's behavior as there isn't > checkpoint job before. We should keep the api only return cubing jobs to be > compitable as before, and extend the API to add another condition > 'jobSearchMode' to determine which kind of job should be returned. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3265) Add "jobSearchMode" as a condition to "/kylin/jobs" API
[
https://issues.apache.org/jira/browse/KYLIN-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375468#comment-16375468
]
Zhong Yanghong commented on KYLIN-3265:
---
Hi [~Shaofengshi], this patch looks good for me, except two concerns:
* By add {{jobSearchMode}} in {{JobListRequest}}, will this impact the interface
*
{color:#f79232}JobService.JobSearchMode.valueOf(jobRequest.getJobSearchMode()){color}
may return null.
> Add "jobSearchMode" as a condition to "/kylin/jobs" API
> ---
>
> Key: KYLIN-3265
> URL: https://issues.apache.org/jira/browse/KYLIN-3265
> Project: Kylin
> Issue Type: Improvement
> Components: REST Service
>Affects Versions: v2.3.0
>Reporter: Shaofeng SHI
>Priority: Major
> Attachments: KYLIN-3265.master.001.patch
>
>
> In kylin 2.3, the "/kylin/jobs" API will return both cubing job and
> checkpoint job together, this changed the API's behavior as there isn't
> checkpoint job before. We should keep the api only return cubing jobs to be
> compitable as before, and extend the API to add another condition
> 'jobSearchMode' to determine which kind of job should be returned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhixiong Chen resolved KYLIN-2884. -- Resolution: Fixed Fix Version/s: (was: Future) v2.4.0 > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: v2.4.0 > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375417#comment-16375417 ] ASF subversion and git services commented on KYLIN-2884: Commit 865e377b6803caa2e2b2aeab2e5bb77f6470c3e6 in kylin's branch refs/heads/master from [~chenliang613] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=865e377 ] Merge pull request #105 from sanjulian/APACHE-KYLIN-2884 KYLIN-2884 Add delete segment function for portal - bug fix > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[
https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375414#comment-16375414
]
ASF GitHub Bot commented on KYLIN-2884:
---
chenzhx closed pull request #105: KYLIN-2884 Add delete segment function for
portal - bug fix
URL: https://github.com/apache/kylin/pull/105
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/webapp/app/js/controllers/cubes.js
b/webapp/app/js/controllers/cubes.js
index a38620218b..cbd6fad1bb 100644
--- a/webapp/app/js/controllers/cubes.js
+++ b/webapp/app/js/controllers/cubes.js
@@ -522,23 +522,25 @@ KylinApp.controller('CubesCtrl', function ($scope, $q,
$routeParams, $location,
})
};
-$scope.startDeleteSegment = function (cube) {
- $scope.metaModel={
-model:modelsManager.getModelByCube(cube.name)
- };
- $modal.open({
-templateUrl: 'deleteSegment.html',
-controller: deleteSegmentCtrl,
-resolve: {
- cube: function () {
-return cube;
- },
- scope: function() {
-return $scope;
- }
-}
- });
-};
+ $scope.startDeleteSegment = function (cube) {
+ $scope.loadDetail(cube).then(function () {
+ $scope.metaModel={
+ model:modelsManager.getModelByCube(cube.name)
+ };
+ $modal.open({
+ templateUrl: 'deleteSegment.html',
+ controller: deleteSegmentCtrl,
+ resolve: {
+ cube: function () {
+ return cube;
+ },
+ scope: function() {
+ return $scope;
+ }
+ }
+ });
+ });
+ };
});
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add delete segment function for portal
> --
>
> Key: KYLIN-2884
> URL: https://issues.apache.org/jira/browse/KYLIN-2884
> Project: Kylin
> Issue Type: Improvement
> Components: Web
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Major
> Fix For: Future
>
> Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch,
> KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png
>
>
> Kylin restful already support delete segment function. Could we add a action
> button for front-end to user?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375416#comment-16375416 ] ASF subversion and git services commented on KYLIN-2884: Commit 865e377b6803caa2e2b2aeab2e5bb77f6470c3e6 in kylin's branch refs/heads/master from [~chenliang613] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=865e377 ] Merge pull request #105 from sanjulian/APACHE-KYLIN-2884 KYLIN-2884 Add delete segment function for portal - bug fix > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2884) Add delete segment function for portal
[ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375415#comment-16375415 ] ASF subversion and git services commented on KYLIN-2884: Commit 23641a2ee31bed105575671d565b006f3ca257c4 in kylin's branch refs/heads/master from liapan [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=23641a2 ] KYLIN-2884 Add delete segment function for portal - bug fix > Add delete segment function for portal > -- > > Key: KYLIN-2884 > URL: https://issues.apache.org/jira/browse/KYLIN-2884 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Pan, Julian >Assignee: Pan, Julian >Priority: Major > Fix For: Future > > Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, > KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png > > > Kylin restful already support delete segment function. Could we add a action > button for front-end to user? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
