[jira] [Commented] (KYLIN-3631) Utilize Arrays#parallelSort for better performance
[ https://issues.apache.org/jira/browse/KYLIN-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692582#comment-16692582 ] ASF subversion and git services commented on KYLIN-3631: Commit dca3ee7e12e238f6c0baf25388c5a63d3298758f in kylin's branch refs/heads/master from 武斌 [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=dca3ee7 ] KYLIN-3631 Use Arrays#parallelSort instead of Arrays#sort > Utilize Arrays#parallelSort for better performance > -- > > Key: KYLIN-3631 > URL: https://issues.apache.org/jira/browse/KYLIN-3631 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Wu Bin >Priority: Minor > Fix For: v2.6.0 > > > Arrays#parallelSort was introduced since Java 1.8 > We can utilize Arrays#parallelSort to achieve better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3631) Utilize Arrays#parallelSort for better performance
[
https://issues.apache.org/jira/browse/KYLIN-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692581#comment-16692581
]
ASF GitHub Bot commented on KYLIN-3631:
---
shaofengshi closed pull request #350: Fix issue : KYLIN-3631
URL: https://github.com/apache/kylin/pull/350
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-cube/src/test/java/org/apache/kylin/cube/cuboid/CuboidSchedulerTest.java
b/core-cube/src/test/java/org/apache/kylin/cube/cuboid/CuboidSchedulerTest.java
index 87bf9c3c35..c40e766a67 100644
---
a/core-cube/src/test/java/org/apache/kylin/cube/cuboid/CuboidSchedulerTest.java
+++
b/core-cube/src/test/java/org/apache/kylin/cube/cuboid/CuboidSchedulerTest.java
@@ -118,8 +118,9 @@ private void testSpanningAndGetParent(CuboidScheduler
scheduler, CubeDesc cube,
}
long[] spanningsArray = Longs.toArray(totalSpanning);
-Arrays.sort(spanningsArray);
-Arrays.sort(expectChildren);
+
+Arrays.parallelSort(spanningsArray);
+Arrays.parallelSort(expectChildren);
assertArrayEquals(expectChildren, spanningsArray);
}
diff --git
a/core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java
b/core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java
index bb68299133..6c4c9a3142 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java
@@ -220,7 +220,7 @@ public SegmentRange autoMergeCubeSegments(boolean
needAutoMerge, String cubeName
// exclude those already under merging segments
readySegs.removeAll(mergingSegs);
-Arrays.sort(timeRanges);
+Arrays.parallelSort(timeRanges);
for (int i = timeRanges.length - 1; i >= 0; i--) {
long toMergeRange = timeRanges[i];
diff --git
a/core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java
b/core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java
index 63a78f89e6..6bbc70c96c 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java
@@ -308,7 +308,7 @@ public void init(KylinConfig config, String project) {
setDatabase(getDatabase().toUpperCase(Locale.ROOT));
if (columns != null) {
-Arrays.sort(columns, new Comparator() {
+Arrays.parallelSort(columns, new Comparator() {
@Override
public int compare(ColumnDesc col1, ColumnDesc col2) {
Integer id1 = Integer.parseInt(col1.getId());
diff --git
a/core-metadata/src/test/java/org/apache/kylin/measure/topn/DoubleDeltaSerializerTest.java
b/core-metadata/src/test/java/org/apache/kylin/measure/topn/DoubleDeltaSerializerTest.java
index e979791df5..30b2e56711 100644
---
a/core-metadata/src/test/java/org/apache/kylin/measure/topn/DoubleDeltaSerializerTest.java
+++
b/core-metadata/src/test/java/org/apache/kylin/measure/topn/DoubleDeltaSerializerTest.java
@@ -67,7 +67,8 @@ public void testRandom() {
for (int i = 0; i < n; i++) {
nums[i] = rand.nextDouble() * 100;
}
-Arrays.sort(nums);
+
+Arrays.parallelSort(nums);
buf.clear();
dds.serialize(nums, buf);
@@ -86,7 +87,8 @@ public void testRandom2() {
for (int i = 0; i < n; i++) {
nums[i] = rand.nextInt();
}
-Arrays.sort(nums);
+
+Arrays.parallelSort(nums);
buf.clear();
dds.serialize(nums, buf);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Utilize Arrays#parallelSort for better performance
> --
>
> Key: KYLIN-3631
> URL: https://issues.apache.org/jira/browse/KYLIN-3631
> Project: Kylin
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Wu Bin
>Priority: Minor
> Fix For: v2.6.0
>
>
> Arrays#parallelSort was introduced since Java 1.8
> We can utilize Arrays#parallelSort to achieve better performance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3631) Utilize Arrays#parallelSort for better performance
[ https://issues.apache.org/jira/browse/KYLIN-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692543#comment-16692543 ] ASF GitHub Bot commented on KYLIN-3631: --- coveralls edited a comment on issue #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350#issuecomment-439873914 ## Pull Request Test Coverage Report for [Build 3860](https://coveralls.io/builds/20193220) * **1** of **2** **(50.0%)** changed or added relevant lines in **2** files are covered. * **7** unchanged lines in **3** files lost coverage. * Overall coverage decreased (**-0.003%**) to **25.913%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java](https://coveralls.io/builds/20193220/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FSegments.java#L223) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/20193220/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/20193220/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20193220/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 4 | 78.12% | | Totals | [](https://coveralls.io/builds/20193220) | | :-- | --: | | Change from base [Build 3853](https://coveralls.io/builds/20137109): | -0.003% | | Covered Lines: | 17645 | | Relevant Lines: | 68093 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize Arrays#parallelSort for better performance > -- > > Key: KYLIN-3631 > URL: https://issues.apache.org/jira/browse/KYLIN-3631 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Wu Bin >Priority: Minor > Fix For: v2.6.0 > > > Arrays#parallelSort was introduced since Java 1.8 > We can utilize Arrays#parallelSort to achieve better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3631) Utilize Arrays#parallelSort for better performance
[ https://issues.apache.org/jira/browse/KYLIN-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691959#comment-16691959 ] ASF GitHub Bot commented on KYLIN-3631: --- coveralls edited a comment on issue #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350#issuecomment-439873914 ## Pull Request Test Coverage Report for [Build 3859](https://coveralls.io/builds/20183226) * **1** of **2** **(50.0%)** changed or added relevant lines in **2** files are covered. * **3** unchanged lines in **2** files lost coverage. * Overall coverage decreased (**-0.004%**) to **25.912%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java](https://coveralls.io/builds/20183226/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FSegments.java#L223) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/20183226/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/20183226/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | Totals | [](https://coveralls.io/builds/20183226) | | :-- | --: | | Change from base [Build 3853](https://coveralls.io/builds/20137109): | -0.004% | | Covered Lines: | 17644 | | Relevant Lines: | 68093 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize Arrays#parallelSort for better performance > -- > > Key: KYLIN-3631 > URL: https://issues.apache.org/jira/browse/KYLIN-3631 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Wu Bin >Priority: Minor > Fix For: v2.6.0 > > > Arrays#parallelSort was introduced since Java 1.8 > We can utilize Arrays#parallelSort to achieve better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3631) Utilize Arrays#parallelSort for better performance
[ https://issues.apache.org/jira/browse/KYLIN-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691919#comment-16691919 ] ASF GitHub Bot commented on KYLIN-3631: --- whuwb commented on a change in pull request #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350#discussion_r234681139 ## File path: core-cube/src/test/java/org/apache/kylin/cube/cuboid/CuboidSchedulerTest.java ## @@ -118,8 +118,13 @@ private void testSpanningAndGetParent(CuboidScheduler scheduler, CubeDesc cube, } long[] spanningsArray = Longs.toArray(totalSpanning); -Arrays.sort(spanningsArray); -Arrays.sort(expectChildren); + +/* +According to issue : https://issues.apache.org/jira/browse/KYLIN-3631 Review comment: Sure This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize Arrays#parallelSort for better performance > -- > > Key: KYLIN-3631 > URL: https://issues.apache.org/jira/browse/KYLIN-3631 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Wu Bin >Priority: Minor > Fix For: v2.6.0 > > > Arrays#parallelSort was introduced since Java 1.8 > We can utilize Arrays#parallelSort to achieve better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3631) Utilize Arrays#parallelSort for better performance
[ https://issues.apache.org/jira/browse/KYLIN-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691757#comment-16691757 ] ASF GitHub Bot commented on KYLIN-3631: --- shaofengshi commented on a change in pull request #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350#discussion_r234635124 ## File path: core-cube/src/test/java/org/apache/kylin/cube/cuboid/CuboidSchedulerTest.java ## @@ -118,8 +118,13 @@ private void testSpanningAndGetParent(CuboidScheduler scheduler, CubeDesc cube, } long[] spanningsArray = Longs.toArray(totalSpanning); -Arrays.sort(spanningsArray); -Arrays.sort(expectChildren); + +/* +According to issue : https://issues.apache.org/jira/browse/KYLIN-3631 Review comment: This comment is not needed. Can you remove it in all the places? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize Arrays#parallelSort for better performance > -- > > Key: KYLIN-3631 > URL: https://issues.apache.org/jira/browse/KYLIN-3631 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Wu Bin >Priority: Minor > Fix For: v2.6.0 > > > Arrays#parallelSort was introduced since Java 1.8 > We can utilize Arrays#parallelSort to achieve better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3631) Utilize Arrays#parallelSort for better performance
[ https://issues.apache.org/jira/browse/KYLIN-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691634#comment-16691634 ] ASF GitHub Bot commented on KYLIN-3631: --- codecov-io commented on issue #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350#issuecomment-439874742 # [Codecov](https://codecov.io/gh/apache/kylin/pull/350?src=pr&el=h1) Report > Merging [#350](https://codecov.io/gh/apache/kylin/pull/350?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/634498649f20ce61fcabe0b46fe515bb6ca96af0?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `50%`. [](https://codecov.io/gh/apache/kylin/pull/350?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #350 +/- ## - Coverage 23.62% 23.61% -0.01% + Complexity 4823 4822 -1 Files 1133 1133 Lines 6809368093 Branches 9657 9657 - Hits 1608716081 -6 - Misses5044550449 +4 - Partials 1561 1563 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/350?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...java/org/apache/kylin/metadata/model/Segments.java](https://codecov.io/gh/apache/kylin/pull/350/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvU2VnbWVudHMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ava/org/apache/kylin/metadata/model/TableDesc.java](https://codecov.io/gh/apache/kylin/pull/350/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVEZXNjLmphdmE=) | `47.77% <100%> (ø)` | `27 <0> (ø)` | :arrow_down: | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/350/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `70.94% <0%> (-1.36%)` | `8% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/350/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (-0.92%)` | `7% <0%> (ø)` | | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/350/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/350?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/350?src=pr&el=footer). Last update [6344986...c47dd9f](https://codecov.io/gh/apache/kylin/pull/350?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize Arrays#parallelSort for better performance > -- > > Key: KYLIN-3631 > URL: https://issues.apache.org/jira/browse/KYLIN-3631 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Wu Bin >Priority: Minor > Fix For: v2.6.0 > > > Arrays#parallelSort was introduced since Java 1.8 > We can utilize Arrays#parallelSort to achieve better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3631) Utilize Arrays#parallelSort for better performance
[ https://issues.apache.org/jira/browse/KYLIN-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691627#comment-16691627 ] ASF GitHub Bot commented on KYLIN-3631: --- coveralls commented on issue #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350#issuecomment-439873914 ## Pull Request Test Coverage Report for [Build 3858](https://coveralls.io/builds/20178446) * **1** of **2** **(50.0%)** changed or added relevant lines in **2** files are covered. * **4** unchanged lines in **2** files lost coverage. * Overall coverage increased (+**0.001%**) to **25.917%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java](https://coveralls.io/builds/20178446/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FSegments.java#L227) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/20178446/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20178446/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [](https://coveralls.io/builds/20178446) | | :-- | --: | | Change from base [Build 3853](https://coveralls.io/builds/20137109): | 0.001% | | Covered Lines: | 17648 | | Relevant Lines: | 68093 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize Arrays#parallelSort for better performance > -- > > Key: KYLIN-3631 > URL: https://issues.apache.org/jira/browse/KYLIN-3631 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Wu Bin >Priority: Minor > Fix For: v2.6.0 > > > Arrays#parallelSort was introduced since Java 1.8 > We can utilize Arrays#parallelSort to achieve better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3631) Utilize Arrays#parallelSort for better performance
[ https://issues.apache.org/jira/browse/KYLIN-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691604#comment-16691604 ] ASF GitHub Bot commented on KYLIN-3631: --- asfgit commented on issue #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350#issuecomment-439868082 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize Arrays#parallelSort for better performance > -- > > Key: KYLIN-3631 > URL: https://issues.apache.org/jira/browse/KYLIN-3631 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Wu Bin >Priority: Minor > Fix For: v2.6.0 > > > Arrays#parallelSort was introduced since Java 1.8 > We can utilize Arrays#parallelSort to achieve better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3631) Utilize Arrays#parallelSort for better performance
[ https://issues.apache.org/jira/browse/KYLIN-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691603#comment-16691603 ] ASF GitHub Bot commented on KYLIN-3631: --- whuwb opened a new pull request #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350 Issue : https://issues.apache.org/jira/browse/KYLIN-3631 How to fix : 1. Find all the Arrays.sort and replace with Arrays.parallelSort and add comments. 2. Run UT & integration tests to validate the fix. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize Arrays#parallelSort for better performance > -- > > Key: KYLIN-3631 > URL: https://issues.apache.org/jira/browse/KYLIN-3631 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Wu Bin >Priority: Minor > Fix For: v2.6.0 > > > Arrays#parallelSort was introduced since Java 1.8 > We can utilize Arrays#parallelSort to achieve better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3631) Utilize Arrays#parallelSort for better performance
[ https://issues.apache.org/jira/browse/KYLIN-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689139#comment-16689139 ] Wu Bin commented on KYLIN-3631: --- I want to take a try for this issue. > Utilize Arrays#parallelSort for better performance > -- > > Key: KYLIN-3631 > URL: https://issues.apache.org/jira/browse/KYLIN-3631 > Project: Kylin > Issue Type: Task >Reporter: Ted Yu >Priority: Minor > > Arrays#parallelSort was introduced since Java 1.8 > We can utilize Arrays#parallelSort to achieve better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
