[jira] [Commented] (KYLIN-4062) Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType

2019-06-30 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/KYLIN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875904#comment-16875904
 ] 

王汝鹏 commented on KYLIN-4062:


Hi, Shaofeng, I can fix this. Can you assign this to me?

> Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType
> -
>
> Key: KYLIN-4062
> URL: https://issues.apache.org/jira/browse/KYLIN-4062
> Project: Kylin
>  Issue Type: Improvement
>  Components: Query Engine
>Reporter: Shaofeng SHI
>Priority: Minor
>
> In this method, it has 30 "if else" which is low efficient; Should use a 
> static Hashmap, then only need 1 check.
>  
> {code:java}
> if ("string".equalsIgnoreCase(type)) {
> return Types.VARCHAR;
> } else if ("varchar".equalsIgnoreCase(type)) {
> return Types.VARCHAR;
> } else if ("char".equalsIgnoreCase(type)) {
> return Types.CHAR;
> } else if
> ...{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-4062) Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType

2019-07-02 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/KYLIN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876822#comment-16876822
 ] 

ASF GitHub Bot commented on KYLIN-4062:
---

RupengWang commented on pull request #725: KYLIN-4062 Using a static hashmap to 
replace many "if-else" to improv…
URL: https://github.com/apache/kylin/pull/725
 
 
   …e efficiency
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType
> -
>
> Key: KYLIN-4062
> URL: https://issues.apache.org/jira/browse/KYLIN-4062
> Project: Kylin
>  Issue Type: Improvement
>  Components: Query Engine
>Reporter: Shaofeng SHI
>Assignee: 王汝鹏
>Priority: Minor
>
> In this method, it has 30 "if else" which is low efficient; Should use a 
> static Hashmap, then only need 1 check.
>  
> {code:java}
> if ("string".equalsIgnoreCase(type)) {
> return Types.VARCHAR;
> } else if ("varchar".equalsIgnoreCase(type)) {
> return Types.VARCHAR;
> } else if ("char".equalsIgnoreCase(type)) {
> return Types.CHAR;
> } else if
> ...{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-4062) Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType

2019-07-07 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/KYLIN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879842#comment-16879842
 ] 

ASF subversion and git services commented on KYLIN-4062:


Commit 9331a94b2a95c00a59c0783f0be1555f13a7059f in kylin's branch 
refs/heads/master from rupengwang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=9331a94 ]

KYLIN-4062 Using a static hashmap to replace many "if-else" to improve 
efficiency


> Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType
> -
>
> Key: KYLIN-4062
> URL: https://issues.apache.org/jira/browse/KYLIN-4062
> Project: Kylin
>  Issue Type: Improvement
>  Components: Query Engine
>Reporter: Shaofeng SHI
>Assignee: 王汝鹏
>Priority: Minor
>
> In this method, it has 30 "if else" which is low efficient; Should use a 
> static Hashmap, then only need 1 check.
>  
> {code:java}
> if ("string".equalsIgnoreCase(type)) {
> return Types.VARCHAR;
> } else if ("varchar".equalsIgnoreCase(type)) {
> return Types.VARCHAR;
> } else if ("char".equalsIgnoreCase(type)) {
> return Types.CHAR;
> } else if
> ...{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-4062) Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType

2019-07-07 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/KYLIN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879841#comment-16879841
 ] 

ASF GitHub Bot commented on KYLIN-4062:
---

nichunen commented on pull request #725: KYLIN-4062 Using a static hashmap to 
replace many "if-else" to improv…
URL: https://github.com/apache/kylin/pull/725
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType
> -
>
> Key: KYLIN-4062
> URL: https://issues.apache.org/jira/browse/KYLIN-4062
> Project: Kylin
>  Issue Type: Improvement
>  Components: Query Engine
>Reporter: Shaofeng SHI
>Assignee: 王汝鹏
>Priority: Minor
>
> In this method, it has 30 "if else" which is low efficient; Should use a 
> static Hashmap, then only need 1 check.
>  
> {code:java}
> if ("string".equalsIgnoreCase(type)) {
> return Types.VARCHAR;
> } else if ("varchar".equalsIgnoreCase(type)) {
> return Types.VARCHAR;
> } else if ("char".equalsIgnoreCase(type)) {
> return Types.CHAR;
> } else if
> ...{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)