[jira] [Commented] (SOLR-13725) TermsFacetMap.setLimit() unnecessarily rejects negative parameter value
[ https://issues.apache.org/jira/browse/SOLR-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930735#comment-16930735 ] Munendra S N commented on SOLR-13725: - [^SOLR-13725.patch] [~gerlowskija] I have removed check from {{setLimit}}. I checked {{setMinCount}}, solrJ doesn't allow mincount to be 0. Currently, solr doesn't support mincount=0 for numeric fieldtypes in terms facet but, for other types it is supported. Shouldn't we just allow setting mincount to 0 and handle this case at Server(Solr already throws error on mincount=0 for numeric types) > TermsFacetMap.setLimit() unnecessarily rejects negative parameter value > --- > > Key: SOLR-13725 > URL: https://issues.apache.org/jira/browse/SOLR-13725 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrJ >Affects Versions: 8.2 >Reporter: Richard Walker >Priority: Trivial > Attachments: SOLR-13725.patch > > > SolrJ's {{TermsFacetMap.setLimit(int maximumBuckets)}} rejects a negative > parameter value with an IllegalArgumentException "Parameter 'maximumBuckets' > must be non-negative". > But a negative value for the limit parameter is accepted by Solr server, and > is meaningful: i.e., it means "no limit". > The {{setLimit()}} method shouldn't reject a negative parameter value. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13725) TermsFacetMap.setLimit() unnecessarily rejects negative parameter value
[ https://issues.apache.org/jira/browse/SOLR-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931824#comment-16931824 ] Lucene/Solr QA commented on SOLR-13725: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m 11s{color} | {color:green} solrj in the patch passed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 18m 16s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | SOLR-13725 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12980524/SOLR-13725.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns | | uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / fd0c8b9 | | ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 | | Default Java | LTS | | Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/550/testReport/ | | modules | C: solr/solrj U: solr/solrj | | Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/550/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > TermsFacetMap.setLimit() unnecessarily rejects negative parameter value > --- > > Key: SOLR-13725 > URL: https://issues.apache.org/jira/browse/SOLR-13725 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrJ >Affects Versions: 8.2 >Reporter: Richard Walker >Assignee: Munendra S N >Priority: Trivial > Attachments: SOLR-13725.patch, SOLR-13725.patch > > > SolrJ's {{TermsFacetMap.setLimit(int maximumBuckets)}} rejects a negative > parameter value with an IllegalArgumentException "Parameter 'maximumBuckets' > must be non-negative". > But a negative value for the limit parameter is accepted by Solr server, and > is meaningful: i.e., it means "no limit". > The {{setLimit()}} method shouldn't reject a negative parameter value. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13725) TermsFacetMap.setLimit() unnecessarily rejects negative parameter value
[ https://issues.apache.org/jira/browse/SOLR-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932552#comment-16932552 ] Munendra S N commented on SOLR-13725: - I'm planning to commit this in the weekend > TermsFacetMap.setLimit() unnecessarily rejects negative parameter value > --- > > Key: SOLR-13725 > URL: https://issues.apache.org/jira/browse/SOLR-13725 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrJ >Affects Versions: 8.2 >Reporter: Richard Walker >Assignee: Munendra S N >Priority: Trivial > Attachments: SOLR-13725.patch, SOLR-13725.patch > > > SolrJ's {{TermsFacetMap.setLimit(int maximumBuckets)}} rejects a negative > parameter value with an IllegalArgumentException "Parameter 'maximumBuckets' > must be non-negative". > But a negative value for the limit parameter is accepted by Solr server, and > is meaningful: i.e., it means "no limit". > The {{setLimit()}} method shouldn't reject a negative parameter value. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13725) TermsFacetMap.setLimit() unnecessarily rejects negative parameter value
[ https://issues.apache.org/jira/browse/SOLR-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934933#comment-16934933 ] ASF subversion and git services commented on SOLR-13725: Commit 59fe7b7d9fc7bbc26e761a6a51a32803eb024c3e in lucene-solr's branch refs/heads/master from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=59fe7b7 ] SOLR-13725: allow negative values for limit in TermsFacetMap * when limit is negative all the facet values are returned * allow mincount=0 in TermsFacetMap. > TermsFacetMap.setLimit() unnecessarily rejects negative parameter value > --- > > Key: SOLR-13725 > URL: https://issues.apache.org/jira/browse/SOLR-13725 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrJ >Affects Versions: 8.2 >Reporter: Richard Walker >Assignee: Munendra S N >Priority: Trivial > Attachments: SOLR-13725.patch, SOLR-13725.patch > > > SolrJ's {{TermsFacetMap.setLimit(int maximumBuckets)}} rejects a negative > parameter value with an IllegalArgumentException "Parameter 'maximumBuckets' > must be non-negative". > But a negative value for the limit parameter is accepted by Solr server, and > is meaningful: i.e., it means "no limit". > The {{setLimit()}} method shouldn't reject a negative parameter value. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13725) TermsFacetMap.setLimit() unnecessarily rejects negative parameter value
[ https://issues.apache.org/jira/browse/SOLR-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934943#comment-16934943 ] ASF subversion and git services commented on SOLR-13725: Commit b7a46659251750ebd754f75727b5c251ea5c74da in lucene-solr's branch refs/heads/branch_8x from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b7a46659 ] SOLR-13725: allow negative values for limit in TermsFacetMap * when limit is negative all the facet values are returned * allow mincount=0 in TermsFacetMap. > TermsFacetMap.setLimit() unnecessarily rejects negative parameter value > --- > > Key: SOLR-13725 > URL: https://issues.apache.org/jira/browse/SOLR-13725 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrJ >Affects Versions: 8.2 >Reporter: Richard Walker >Assignee: Munendra S N >Priority: Trivial > Attachments: SOLR-13725.patch, SOLR-13725.patch > > > SolrJ's {{TermsFacetMap.setLimit(int maximumBuckets)}} rejects a negative > parameter value with an IllegalArgumentException "Parameter 'maximumBuckets' > must be non-negative". > But a negative value for the limit parameter is accepted by Solr server, and > is meaningful: i.e., it means "no limit". > The {{setLimit()}} method shouldn't reject a negative parameter value. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org