[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210161#comment-17210161
]
ASF subversion and git services commented on SOLR-14576:
Commit ad7ad02238de8a61bc32673e553178792f711445 in lucene-solr's branch
refs/heads/branch_8x from Noble Paul
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ad7ad02 ]
SOLR-14576 : Do not use SolrCore as keys in a WeakHashMap (#1586)
> HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
> -
>
> Key: SOLR-14576
> URL: https://issues.apache.org/jira/browse/SOLR-14576
> Project: Solr
> Issue Type: Bug
>Reporter: Noble Paul
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> GC performance is affected when the key is a complex data structure. We can
> make it
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
> instead of
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210160#comment-17210160
]
ASF subversion and git services commented on SOLR-14576:
Commit ad7ad02238de8a61bc32673e553178792f711445 in lucene-solr's branch
refs/heads/branch_8x from Noble Paul
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ad7ad02 ]
SOLR-14576 : Do not use SolrCore as keys in a WeakHashMap (#1586)
> HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
> -
>
> Key: SOLR-14576
> URL: https://issues.apache.org/jira/browse/SOLR-14576
> Project: Solr
> Issue Type: Bug
>Reporter: Noble Paul
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> GC performance is affected when the key is a complex data structure. We can
> make it
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
> instead of
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210159#comment-17210159
]
ASF subversion and git services commented on SOLR-14576:
Commit ad7ad02238de8a61bc32673e553178792f711445 in lucene-solr's branch
refs/heads/branch_8x from Noble Paul
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ad7ad02 ]
SOLR-14576 : Do not use SolrCore as keys in a WeakHashMap (#1586)
> HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
> -
>
> Key: SOLR-14576
> URL: https://issues.apache.org/jira/browse/SOLR-14576
> Project: Solr
> Issue Type: Bug
>Reporter: Noble Paul
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> GC performance is affected when the key is a complex data structure. We can
> make it
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
> instead of
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210157#comment-17210157
]
ASF subversion and git services commented on SOLR-14576:
Commit ad7ad02238de8a61bc32673e553178792f711445 in lucene-solr's branch
refs/heads/branch_8x from Noble Paul
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ad7ad02 ]
SOLR-14576 : Do not use SolrCore as keys in a WeakHashMap (#1586)
> HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
> -
>
> Key: SOLR-14576
> URL: https://issues.apache.org/jira/browse/SOLR-14576
> Project: Solr
> Issue Type: Bug
>Reporter: Noble Paul
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> GC performance is affected when the key is a complex data structure. We can
> make it
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
> instead of
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210154#comment-17210154
]
ASF subversion and git services commented on SOLR-14576:
Commit ad7ad02238de8a61bc32673e553178792f711445 in lucene-solr's branch
refs/heads/branch_8x from Noble Paul
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ad7ad02 ]
SOLR-14576 : Do not use SolrCore as keys in a WeakHashMap (#1586)
> HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
> -
>
> Key: SOLR-14576
> URL: https://issues.apache.org/jira/browse/SOLR-14576
> Project: Solr
> Issue Type: Bug
>Reporter: Noble Paul
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> GC performance is affected when the key is a complex data structure. We can
> make it
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
> instead of
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210149#comment-17210149
]
ASF subversion and git services commented on SOLR-14576:
Commit 8c41418c0fb33fdc0ee6aedbd52917c63b447756 in lucene-solr's branch
refs/heads/master from Noble Paul
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8c41418 ]
SOLR-14576 : Do not use SolrCore as keys in a WeakHashMap (#1586)
> HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
> -
>
> Key: SOLR-14576
> URL: https://issues.apache.org/jira/browse/SOLR-14576
> Project: Solr
> Issue Type: Bug
>Reporter: Noble Paul
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> GC performance is affected when the key is a complex data structure. We can
> make it
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
> instead of
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172059#comment-17172059
]
Noble Paul commented on SOLR-14576:
---
I've changed it to UUID as the key. Plan to commit this soon
> HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
> -
>
> Key: SOLR-14576
> URL: https://issues.apache.org/jira/browse/SOLR-14576
> Project: Solr
> Issue Type: Bug
>Reporter: Noble Paul
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> GC performance is affected when the key is a complex data structure. We can
> make it
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
> instead of
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144561#comment-17144561
]
Noble Paul commented on SOLR-14576:
---
{quote}Using String as a key in an Identity HashMap seems dubious, but probably
not any more dubious than the SolrCore itself.
{quote}
True [~mdrob]. That's m concern as well. JVMs intern the Strings and there is a
very good chance that the Object lingers on. I think we should have a {{new
Object()}} inside {{SolrCore}} and use that as a key to avoid that problem
> HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
> -
>
> Key: SOLR-14576
> URL: https://issues.apache.org/jira/browse/SOLR-14576
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> GC performance is affected when the key is a complex data structure. We can
> make it
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
> instead of
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143935#comment-17143935
]
Mike Drob commented on SOLR-14576:
--
I'm worried about two things here -
1) Using String as a key in an Identity HashMap seems dubious, but probably not
any more dubious than the SolrCore itself.
2) Would the liveness of the the String be different than the liveness of the
SolrCore? i.e. would it be possible that the SolrCore is GC'd but that the
String is still around because there are other references to it? I think this
is fairly likely actually, but I don't have any analysis to prove it.
I'm -1 on this change as is. Would like to see some tests around it, or some
profiler analysis that shows we should be worried about things here before we
start making changes.
> HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
> -
>
> Key: SOLR-14576
> URL: https://issues.apache.org/jira/browse/SOLR-14576
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> GC performance is affected when the key is a complex data structure. We can
> make it
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
> instead of
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142500#comment-17142500
]
Noble Paul commented on SOLR-14576:
---
This was reported by a client and unfortunately I do not have the heap dump.
> HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
> -
>
> Key: SOLR-14576
> URL: https://issues.apache.org/jira/browse/SOLR-14576
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> GC performance is affected when the key is a complex data structure. We can
> make it
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
> instead of
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142196#comment-17142196
]
Mike Drob commented on SOLR-14576:
--
Do you have GC logs or a heap dump analysis highlighting it? I'd be interested
to learn more.
> HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
> -
>
> Key: SOLR-14576
> URL: https://issues.apache.org/jira/browse/SOLR-14576
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> GC performance is affected when the key is a complex data structure. We can
> make it
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
> instead of
> {code}
> private static WeakIdentityMap etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
