[jira] (MNG-5454) cvc-complex-type.3.2.2: Attribute 'combine.self' is not allowed to appear in element 'executions'.

2014-01-11 Thread Robert Scholte (JIRA)

[ 
https://jira.codehaus.org/browse/MNG-5454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338390#comment-338390
 ] 

Robert Scholte commented on MNG-5454:
-

{code:xml|title=http://maven.apache.org/xsd/maven-4.0.0.xsd}
...

  
4.0.0
The configuration of the reporting 
plugin.
  
  

  

  

...
{code}

The title of this issue refers to executions. The 'combine.self' can never be 
used on this element, only within the configuration element(read the article of 
my previous comment). As you can see in the xsd snippet, what goes between the 
configuration-tag can be anything, as long as it is valid XML. 

> cvc-complex-type.3.2.2: Attribute 'combine.self' is not allowed to appear in 
> element 'executions'.
> --
>
> Key: MNG-5454
> URL: https://jira.codehaus.org/browse/MNG-5454
> Project: Maven 2 & 3
>  Issue Type: Bug
>  Components: POM
>Affects Versions: 3.0.4
> Environment: springsource3.2.0_with_Juno3.8.2
>Reporter: Sebastien Tardif
>Assignee: Robert Scholte
>
> This generate an error:
> 
>   
> maven-antrun-plugin
>combine.self="override" >
>   
>   
> default-cli
>   
>   
> run
>   
>   
>   
>   
> 
>   
> 
>   
> 
>   
>   
>   
>   
>   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MNG-5538) mvn start script causes cygwin warning

2014-01-11 Thread Robert Scholte (JIRA)

 [ 
https://jira.codehaus.org/browse/MNG-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MNG-5538:


Description: 
The shell script mvn in the bin directory of maven does various tricks with the 
variable M2_HOME but before the last line (the JAVACMD) is executed, the value 
of M2_HOME contains the Windows-style path to maven.

One of the arguments to java.exe is:
{noformat}-classpath "${M2_HOME}"/boot/plexus-classworlds-*.jar{noformat}

The resolving of the asterisk is still done by the cygwin bash,
and since M2_HOME is windows-style at that time,
cygwin generates the following warning:
{noformat}
cygwin warning:
  MS-DOS style path detected: D:\apps\apache-maven-3.1.1/boot/
  Preferred POSIX equivalent is: /cygdrive/d/apps/apache-maven-3.1.1/boot/
  CYGWIN environment variable option "nodosfilewarning" turns off this warning.
  Consult the user's guide for more details about POSIX paths:
http://cygwin.com/cygwin-ug-net/using.html#using-pathnames
{noformat}

This can be fixed quite easily - attached please find my proposal.



  was:
The shell script mvn in the bin directory of maven does various tricks with the 
variable M2_HOME but before the last line (the JAVACMD) is executed, the value 
of M2_HOME contains the Windows-style path to maven.

One of the arguments to java.exe is:
  -classpath "${M2_HOME}"/boot/plexus-classworlds-*.jar

The resolving of the asterisk is still done by the cygwin bash,
and since M2_HOME is windows-style at that time,
cygwin generates the following warning:

cygwin warning:
  MS-DOS style path detected: D:\apps\apache-maven-3.1.1/boot/
  Preferred POSIX equivalent is: /cygdrive/d/apps/apache-maven-3.1.1/boot/
  CYGWIN environment variable option "nodosfilewarning" turns off this warning.
  Consult the user's guide for more details about POSIX paths:
http://cygwin.com/cygwin-ug-net/using.html#using-pathnames


This can be fixed quite easily - attached please find my proposal.




> mvn start script causes cygwin warning
> --
>
> Key: MNG-5538
> URL: https://jira.codehaus.org/browse/MNG-5538
> Project: Maven 2 & 3
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.1.1
> Environment: windows 7 64bit, cygwin 1.7.25, mvn 3.1.1
>Reporter: Martin Vavra
>Priority: Minor
> Attachments: mvn.diff, mvn.fixed, mvn.orig
>
>
> The shell script mvn in the bin directory of maven does various tricks with 
> the variable M2_HOME but before the last line (the JAVACMD) is executed, the 
> value of M2_HOME contains the Windows-style path to maven.
> One of the arguments to java.exe is:
> {noformat}-classpath "${M2_HOME}"/boot/plexus-classworlds-*.jar{noformat}
> The resolving of the asterisk is still done by the cygwin bash,
> and since M2_HOME is windows-style at that time,
> cygwin generates the following warning:
> {noformat}
> cygwin warning:
>   MS-DOS style path detected: D:\apps\apache-maven-3.1.1/boot/
>   Preferred POSIX equivalent is: /cygdrive/d/apps/apache-maven-3.1.1/boot/
>   CYGWIN environment variable option "nodosfilewarning" turns off this 
> warning.
>   Consult the user's guide for more details about POSIX paths:
> http://cygwin.com/cygwin-ug-net/using.html#using-pathnames
> {noformat}
> This can be fixed quite easily - attached please find my proposal.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MRELEASE-862) Upgrade to Apache Maven SCM 1.9

2014-01-11 Thread Robert Scholte (JIRA)
Robert Scholte created MRELEASE-862:
---

 Summary: Upgrade to Apache Maven SCM 1.9
 Key: MRELEASE-862
 URL: https://jira.codehaus.org/browse/MRELEASE-862
 Project: Maven Release Plugin
  Issue Type: Bug
  Components: scm
Affects Versions: 2.4.2
Reporter: Robert Scholte
Priority: Minor




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MRELEASE-862) Upgrade to Apache Maven SCM 1.9

2014-01-11 Thread Robert Scholte (JIRA)

 [ 
https://jira.codehaus.org/browse/MRELEASE-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MRELEASE-862.
---

   Resolution: Fixed
Fix Version/s: 2.5
 Assignee: Robert Scholte

Fixed in [r1557369|http://svn.apache.org/r1557369]

> Upgrade to Apache Maven SCM 1.9
> ---
>
> Key: MRELEASE-862
> URL: https://jira.codehaus.org/browse/MRELEASE-862
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: scm
>Affects Versions: 2.4.2
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 2.5
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MRELEASE-812) "prepare" does not commit before tagging and therefore deploys snapshot instead of release

2014-01-11 Thread Robert Scholte (JIRA)

 [ 
https://jira.codehaus.org/browse/MRELEASE-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MRELEASE-812.
---

   Resolution: Fixed
Fix Version/s: 2.5
 Assignee: Robert Scholte

Fixed by MRELEASE-862

> "prepare" does not commit before tagging and therefore deploys snapshot 
> instead of release
> --
>
> Key: MRELEASE-812
> URL: https://jira.codehaus.org/browse/MRELEASE-812
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: Git
>Affects Versions: 2.4
>Reporter: Andrei Pozolotin
>Assignee: Robert Scholte
>Priority: Critical
> Fix For: 2.5
>
> Attachments: mvn-2.3.2.txt, mvn-2.4.0.txt
>
>
> thank you very much for new release!
> http://mail-archives.apache.org/mod_mbox/maven-announce/201212.mbox/%3Cop.wpjbptp1kdkhrr@columbia%3E
> it seems we need an emergency fix:
> attached are 2 logs:
> 1) mvn-2.3.2.txt invocation that works fine with 2.3.2
> 2) mvn-2.4.0.txt invocation that fails with 2.4
> problem:
> "perform" does not commit tags, deploys snapshot instead of release
> here is project parent:
> http://search.maven.org/remotecontent?filepath=com/barchart/base/barchart-archon/2.3.6/barchart-archon-2.3.6.pom
> build is invoked both times with this:
> mvn --define resume=false release:prepare
> mvn --define resume=false release:perform

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MNG-5063) Unable to install file with existing pom with element set to 'dll'

2014-01-11 Thread Robert Scholte (JIRA)

 [ 
https://jira.codehaus.org/browse/MNG-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MNG-5063.
---

Resolution: Not A Bug
  Assignee: Robert Scholte

That's because Maven first reads the {{pom.xml}} of the Maven execution folder 
before doing any actions. It discovers the packaging-type {{dll}}, for which he 
doesn't know what to do. There's no description which plugin should be called 
during a specific phase. So Maven stops.
It should work if the {{pom.xml}} was in another folder (i.e. changing the 
-DpomFile parameter).
However, that makes the {{pom.xml}} useless for building. It'll only be useful 
for dependency management.
One solution is to add the native-maven-plugin, see its 
[usage|http://mojo.codehaus.org/maven-native/native-maven-plugin/usage.html] 
page.

> Unable to install file with existing pom with  element set to 'dll'
> --
>
> Key: MNG-5063
> URL: https://jira.codehaus.org/browse/MNG-5063
> Project: Maven 2 & 3
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.0.3
> Environment: Windows XP 32 bits
> JRE 6 update 24
>Reporter: Alexandre de Paula
>Assignee: Robert Scholte
>Priority: Minor
>
> Installing a dll file into local repository works fine when typing all 
> required parameters like below:
> mvn install:install-file -Dfile=myfile.dll -DgroupId=my.group.id 
> -DartifactId=myartifact -Dversion=1.0 -Dpackaging=dll -DgeneratePo
> m=true
> Although, when I create a pom file with such descriptions and try to install 
> it like:
> mvn install:install-file -Dfile=myfile.dll -DpomFile=./pom.xml
> an error message is displayed:
> [ERROR] Unknown packaging: dll @ line 8, column 16

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MNG-5063) Unable to install file with existing pom with element set to 'dll'

2014-01-11 Thread Robert Scholte (JIRA)

 [ 
https://jira.codehaus.org/browse/MNG-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MNG-5063:


Description: 
Installing a dll file into local repository works fine when typing all required 
parameters like below:

{{mvn install:install-file -Dfile=myfile.dll -DgroupId=my.group.id 
-DartifactId=myartifact -Dversion=1.0 -Dpackaging=dll -DgeneratePom=true}}

Although, when I create a pom file with such descriptions and try to install it 
like:

{{mvn install:install-file -Dfile=myfile.dll -DpomFile=./pom.xml}}

an error message is displayed:
{noformat}
[ERROR] Unknown packaging: dll @ line 8, column 16
{noformat}

  was:
Installing a dll file into local repository works fine when typing all required 
parameters like below:

mvn install:install-file -Dfile=myfile.dll -DgroupId=my.group.id 
-DartifactId=myartifact -Dversion=1.0 -Dpackaging=dll -DgeneratePo
m=true

Although, when I create a pom file with such descriptions and try to install it 
like:

mvn install:install-file -Dfile=myfile.dll -DpomFile=./pom.xml

an error message is displayed:

[ERROR] Unknown packaging: dll @ line 8, column 16


> Unable to install file with existing pom with  element set to 'dll'
> --
>
> Key: MNG-5063
> URL: https://jira.codehaus.org/browse/MNG-5063
> Project: Maven 2 & 3
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.0.3
> Environment: Windows XP 32 bits
> JRE 6 update 24
>Reporter: Alexandre de Paula
>Assignee: Robert Scholte
>Priority: Minor
>
> Installing a dll file into local repository works fine when typing all 
> required parameters like below:
> {{mvn install:install-file -Dfile=myfile.dll -DgroupId=my.group.id 
> -DartifactId=myartifact -Dversion=1.0 -Dpackaging=dll -DgeneratePom=true}}
> Although, when I create a pom file with such descriptions and try to install 
> it like:
> {{mvn install:install-file -Dfile=myfile.dll -DpomFile=./pom.xml}}
> an error message is displayed:
> {noformat}
> [ERROR] Unknown packaging: dll @ line 8, column 16
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MNG-3258) the command "mvn -help" should describe the usage of the maven help plugin

2014-01-11 Thread Robert Scholte (JIRA)

[ 
https://jira.codehaus.org/browse/MNG-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338394#comment-338394
 ] 

Robert Scholte commented on MNG-3258:
-

This issue is probably outdated. By now almost every plugin has it's own 
help-goal, which is much easier to use compared to the maven-help-plugin.

> the command "mvn -help" should describe the usage of the maven help plugin
> --
>
> Key: MNG-3258
> URL: https://jira.codehaus.org/browse/MNG-3258
> Project: Maven 2 & 3
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 2.0.4, 2.0.5, 2.0.6, 2.0.7
>Reporter: Eirik Maus
> Fix For: Issues to be reviewed for 3.x
>
> Attachments: MNG-3258.patch
>
>
> The help system in maven (and any other program as well) is typically what 
> you use if you can't remember the syntax for a given command. The syntax for 
> the help plugin is, however no simpler than any other command, and I always 
> find myself ending up with searching google for info on how to use the help 
> system to find out how to use, for instance, the dependency plugin. 
> I have suggested a new goal "mvn help:help" in the help plugin to use for 
> getting info on how to use the help system. The same info should be printed 
> when a user types "mvn -help". 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MNG-3258) the command "mvn -help" should describe the usage of the maven help plugin

2014-01-11 Thread Barend Garvelink (JIRA)

[ 
https://jira.codehaus.org/browse/MNG-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338396#comment-338396
 ] 

Barend Garvelink commented on MNG-3258:
---

> This issue is probably outdated.

I had certainly forgotten about it. Feel free to close it if I'm the only one 
keeping you from doing so.

> the command "mvn -help" should describe the usage of the maven help plugin
> --
>
> Key: MNG-3258
> URL: https://jira.codehaus.org/browse/MNG-3258
> Project: Maven 2 & 3
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 2.0.4, 2.0.5, 2.0.6, 2.0.7
>Reporter: Eirik Maus
> Fix For: Issues to be reviewed for 3.x
>
> Attachments: MNG-3258.patch
>
>
> The help system in maven (and any other program as well) is typically what 
> you use if you can't remember the syntax for a given command. The syntax for 
> the help plugin is, however no simpler than any other command, and I always 
> find myself ending up with searching google for info on how to use the help 
> system to find out how to use, for instance, the dependency plugin. 
> I have suggested a new goal "mvn help:help" in the help plugin to use for 
> getting info on how to use the help system. The same info should be printed 
> when a user types "mvn -help". 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MNG-5342) Please expose --fail-at-end as a property

2014-01-11 Thread Robert Scholte (JIRA)

 [ 
https://jira.codehaus.org/browse/MNG-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MNG-5342:


Component/s: (was: Settings)
 Command Line

> Please expose --fail-at-end as a property
> -
>
> Key: MNG-5342
> URL: https://jira.codehaus.org/browse/MNG-5342
> Project: Maven 2 & 3
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.0.4
>Reporter: Dave Henderson
>Priority: Minor
>
> It would be useful to be able to set -fae/--fail-at-end through a system 
> property, to simplify maven runs for development teams who would prefer the 
> reactor to do as much as possible (especially in terms of running unit tests) 
> before finishing.
> Note that the maven.test.failure.ignore property is close to this, but 
> ignores failures instead of simply continuing despite failures (ending up 
> with an incorrect status at the end of the run).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MNG-5342) Please expose --fail-at-end as a property

2014-01-11 Thread Robert Scholte (JIRA)

[ 
https://jira.codehaus.org/browse/MNG-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338398#comment-338398
 ] 

Robert Scholte commented on MNG-5342:
-

There are probably other lazy users who'd like to change the logging to debug 
or quiet by default or want to start with version info. So just the {{-fae}} is 
not the solution. One possible solution could be an environment variable like 
MAVEN_DEFAULT_ARGS. 
However, I'd prefer that users know what they are doing to prevent the "it 
works on my machine"-discussion between team members due to this option.
Anyhow, if you really need it now, just change the mvn batchfile.

{noformat:title=mvn.bat}
...
%MAVEN_JAVA_EXE% %MAVEN_OPTS% -classpath %CLASSWORLDS_JAR% 
"-Dclassworlds.conf=%M2_HOME%\bin\m2.conf" "-Dmaven.home=%M2_HOME%" 
%CLASSWORLDS_LAUNCHER% %MAVEN_CMD_LINE_ARGS% %MAVEN_DEFAULT_ARGS%
...
{noformat}

> Please expose --fail-at-end as a property
> -
>
> Key: MNG-5342
> URL: https://jira.codehaus.org/browse/MNG-5342
> Project: Maven 2 & 3
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.0.4
>Reporter: Dave Henderson
>Priority: Minor
>
> It would be useful to be able to set -fae/--fail-at-end through a system 
> property, to simplify maven runs for development teams who would prefer the 
> reactor to do as much as possible (especially in terms of running unit tests) 
> before finishing.
> Note that the maven.test.failure.ignore property is close to this, but 
> ignores failures instead of simply continuing despite failures (ending up 
> with an incorrect status at the end of the run).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MNG-5139) MAVEN_OPTS are not taked into account in Windows 7

2014-01-11 Thread Robert Scholte (JIRA)

 [ 
https://jira.codehaus.org/browse/MNG-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MNG-5139.
---

Resolution: Not A Bug
  Assignee: Robert Scholte

{{MAVEN_OPTS}} are used for passing options to the java executable ( try: 
{{java -?}} ). By putting them behind the jar, they become arguments for the 
Maven main-method.
So if it works with your adjustments, then those values are actually Maven 
arguments and not java options for Maven. 

> MAVEN_OPTS are not taked into account in Windows 7
> --
>
> Key: MNG-5139
> URL: https://jira.codehaus.org/browse/MNG-5139
> Project: Maven 2 & 3
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.0.3
> Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 14:31:09-0300)
> Maven home: C:\productos\apache-maven-3.0.3
> Java version: 1.6.0_26, vendor: Sun Microsystems Inc.
> Java home: C:\Program Files\Java\jdk1.6.0_26\jre
> Default locale: es_AR, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "x86", family: "windows"
>Reporter: Gabriel Belingueres
>Assignee: Robert Scholte
>Priority: Minor
>
> Hi,
> The mvn.bat file does not take into account the MAVEN_OPTS environment 
> variable, but it does if I add it to the command line (ex. mvn %MAVEN_OPTS%).
> I fixed it by changing this line of the script:
> %MAVEN_JAVA_EXE% %MAVEN_OPTS% -classpath %CLASSWORLDS_JAR% 
> "-Dclassworlds.conf=%M2_HOME%\bin\m2.conf" "-Dmaven.home=%M2_HOME%" 
> %CLASSWORLDS_LAUNCHER% %MAVEN_CMD_LINE_ARGS%
> to this (changed the location of the env var only):
> %MAVEN_JAVA_EXE% -classpath %CLASSWORLDS_JAR% 
> "-Dclassworlds.conf=%M2_HOME%\bin\m2.conf" "-Dmaven.home=%M2_HOME%" 
> %CLASSWORLDS_LAUNCHER% %MAVEN_OPTS% %MAVEN_CMD_LINE_ARGS%
> For the record, I used the MAVEN_OPTS variable to pass the http.proxyHost and 
> http.proxyPort to maven, because it seems that the settings.xml is not enough 
> for certaing plugins for checking XML files against its DTDs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MSITE-701) IT failures with Jdk 8 (EA)

2014-01-11 Thread Herve Boutemy (JIRA)

[ 
https://jira.codehaus.org/browse/MSITE-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338401#comment-338401
 ] 

Herve Boutemy commented on MSITE-701:
-

plugin-tools doclet exist: 
http://maven.apache.org/plugin-tools/maven-plugin-tools-javadoc/
added in [r1557474|http://svn.apache.org/r1557474] which fixes 
new-configuration IT failure

> IT failures with Jdk 8 (EA)
> ---
>
> Key: MSITE-701
> URL: https://jira.codehaus.org/browse/MSITE-701
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.3
>Reporter: Herve Boutemy
>
> see 
> https://builds.apache.org/view/M-R/view/Maven/job/maven-plugins-ITs-m3.1.x-with-maven-plugin-jdk-1.8/modules
> {noformat}[INFO] --- maven-invoker-plugin:1.8:verify (integration-test) @ 
> maven-site-plugin ---
> [INFO] -
> [INFO] Build Summary:
> [INFO]   Passed: 47, Failed: 2, Errors: 0, Skipped: 0
> [INFO] -
> [ERROR] The following builds failed:
> [ERROR] *  new-configuration/pom.xml
> [ERROR] *  MSITE-506/pom.xml
> [INFO] -{noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (DOXIASITETOOLS-87) inconsistent newlines between template from skin and content generated

2014-01-11 Thread Herve Boutemy (JIRA)

[ 
https://jira.codehaus.org/browse/DOXIASITETOOLS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338402#comment-338402
 ] 

Herve Boutemy commented on DOXIASITETOOLS-87:
-

seems like improvement has to be done in 
[DefaultSiteRenderer.html#620|http://maven.apache.org/doxia/doxia-sitetools-archives/doxia-sitetools-1.3/doxia-site-renderer/xref/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.html#620]
{code:java}public SiteRenderingContext createContextForSkin( File skinFile, 
Map attributes,
  DecorationModel 
decoration, String defaultWindowTitle,
  Locale locale )
throws IOException
{
SiteRenderingContext context = new SiteRenderingContext();

ZipFile zipFile = getZipFile( skinFile );

try
{
if ( zipFile.getEntry( SKIN_TEMPLATE_LOCATION ) != null )
{
context.setTemplateName( SKIN_TEMPLATE_LOCATION );
context.setTemplateClassLoader( new URLClassLoader( new 
URL[]{skinFile.toURI().toURL()} ) );
}
else
{
context.setTemplateName( DEFAULT_TEMPLATE );
context.setTemplateClassLoader( getClass().getClassLoader() );
context.setUsingDefaultTemplate( true );
}
}
finally
{
closeZipFile( zipFile );
}{code}

> inconsistent newlines between template from skin and content generated
> --
>
> Key: DOXIASITETOOLS-87
> URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-87
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Reporter: Herve Boutemy
>
> template from skin artifact is read with newline set from skin artifact 
> builder
> then content is added into it with current newline, which can be different 
> from artifact builder
> Template newline should be harmonized with current newline
> this causes MSITE-121 and requires hack in 
> [maven-scm-publish-plugin|http://maven.apache.org/plugins/maven-scm-publish-plugin/]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (DOXIASITETOOLS-87) inconsistent newlines between template from skin and content generated

2014-01-11 Thread Herve Boutemy (JIRA)
Herve Boutemy created DOXIASITETOOLS-87:
---

 Summary: inconsistent newlines between template from skin and 
content generated
 Key: DOXIASITETOOLS-87
 URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-87
 Project: Maven Doxia Sitetools
  Issue Type: Bug
  Components: Site renderer
Reporter: Herve Boutemy


template from skin artifact is read with newline set from skin artifact builder
then content is added into it with current newline, which can be different from 
artifact builder

Template newline should be harmonized with current newline

this causes MSITE-121 and requires hack in 
[maven-scm-publish-plugin|http://maven.apache.org/plugins/maven-scm-publish-plugin/]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira