[jira] [Commented] (SUREFIRE-1216) TEST-*.xml files generated by Surefire are invalid

2017-01-17 Thread Gary Field (JIRA)

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825777#comment-15825777
 ] 

Gary Field commented on SUREFIRE-1216:
--

Hi @Tibor17. Any ETA on the release of 2.19.2, as it has been over a year now? 
Unable to move to JUnit 5 M3 due to this bug. Anything specific preventing you 
releasing it? Thanks.

> TEST-*.xml files generated by Surefire are invalid
> --
>
> Key: SUREFIRE-1216
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1216
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Mirko Friedenhagen
>Assignee: Mirko Friedenhagen
> Fix For: 2.19.2
>
>
> See SUREFIRE-964 as well. The XML produced is invalid because 
> {{schemaLocation}} *must* include two URIs, as outlined in 
> [xmlschema-1|http://www.w3.org/TR/xmlschema-1/#schema-loc].
> Because of this, the Xerces parser fails in the Jenkins XUnit plugin and e.g. 
> IntelliJ is not able to parse the file correctly.
> Suggested solution is to replace {{xsi:schemaLocation}} by 
> {{xsi:noNamespaceSchemaLocation}}, which fixes this for the Unit plugin as 
> well the file is parseable by IntelliJ.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MINVOKER-209) ITs fail (on Windows 10) when working directory contains space

2017-01-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MINVOKER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825883#comment-15825883
 ] 

Hudson commented on MINVOKER-209:
-

FAILURE: Integrated in Jenkins build maven-plugins #8552 (See 
[https://builds.apache.org/job/maven-plugins/8552/])
[MINVOKER-209] ITs fail (on Windows 10) when working directory contains space
Split ITs since there's no multi-criteria support yet (rfscholte: 
[http://svn.apache.org/viewvc/?view=rev&rev=1779169])
* (add) maven-invoker-plugin/src/it/spaces-should-work_non-windows
* (add) 
maven-invoker-plugin/src/it/spaces-should-work_non-windows/invoker.properties
* (add) maven-invoker-plugin/src/it/spaces-should-work_non-windows/pom.xml
* (add) maven-invoker-plugin/src/it/spaces-should-work_non-windows/setup.groovy
* (add) maven-invoker-plugin/src/it/spaces-should-work_non-windows/src
* (add) maven-invoker-plugin/src/it/spaces-should-work_non-windows/src/it
* (add) 
maven-invoker-plugin/src/it/spaces-should-work_non-windows/src/it/minvoker-test
* (add) 
maven-invoker-plugin/src/it/spaces-should-work_non-windows/src/it/minvoker-test/invoker.properties
* (add) 
maven-invoker-plugin/src/it/spaces-should-work_non-windows/src/it/minvoker-test/pom.xml
* (add) 
maven-invoker-plugin/src/it/spaces-should-work_non-windows/src/it/minvoker-test/verify.groovy
* (add) maven-invoker-plugin/src/it/spaces-should-work_windows
* (add) 
maven-invoker-plugin/src/it/spaces-should-work_windows/invoker.properties
* (add) maven-invoker-plugin/src/it/spaces-should-work_windows/pom.xml
* (add) maven-invoker-plugin/src/it/spaces-should-work_windows/setup.groovy
* (add) maven-invoker-plugin/src/it/spaces-should-work_windows/src
* (add) maven-invoker-plugin/src/it/spaces-should-work_windows/src/it
* (add) 
maven-invoker-plugin/src/it/spaces-should-work_windows/src/it/minvoker-test
* (add) 
maven-invoker-plugin/src/it/spaces-should-work_windows/src/it/minvoker-test/invoker.properties
* (add) 
maven-invoker-plugin/src/it/spaces-should-work_windows/src/it/minvoker-test/pom.xml
* (add) 
maven-invoker-plugin/src/it/spaces-should-work_windows/src/it/minvoker-test/verify.groovy
* (edit) maven-invoker-plugin/src/it/special-characters-should-work/setup.groovy


>  ITs fail (on Windows 10) when working directory contains space
> ---
>
> Key: MINVOKER-209
> URL: https://issues.apache.org/jira/browse/MINVOKER-209
> Project: Maven Invoker Plugin
>  Issue Type: Test
>Affects Versions: 3.0.0
> Environment: Windows 10
>Reporter: Alix Lourme
>Assignee: Michael Osipov
>Priority: Minor
>  Labels: test-fail, window
> Fix For: 3.0.0
>
> Attachments: 
> MINVOKER-209-maven-invoker-plugin-IT-double-exec-special-characters-should-work.patch,
>  MINVOKER-209-workaround-maven-invoker-plugin.patch
>
>
> When working copy contains some space (common situation on W10 with users 
> directories Firstname/Lastname), most of ITs fail.
> h3. Scenario
> Command:
> {code}
> mvn invoker:run -Dinvoker.test=special-characters-should-work 
> -Dfile.encoding=UTF-8 -Prun-its,dev
> {code}
> h4. working directory with spaces
> _build.log_ result : 
> {code}
> Running pre-build script: C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script: C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Erreur : impossible de trouver ou charger la classe principale 
> Lastname\git\maven-plugins\maven-invoker-plugin\target
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline, 
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D 
> "maven.repo.local=C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\local-repo" -s 
> "C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\interpolated-settings.xml"
>  -D maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> h3. working directory without space
> _build.log_ result:
> {code}
> Running pre-build script: 
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script: 
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Apache Maven 3.4.0-SNAPSHOT (54827e6b0fc02425f701cfcccde46f81edcb7058; 
> 2016-10-01T18:01:52+02:00)
> ... next lines are ok : BUILD SUCCESS
> {code}
> Content of :  _DefaultInvoker.executeCommandLine(Commandline, 
> InvocationRequest

[jira] [Closed] (MINVOKER-209) ITs fail (on Windows 10) when working directory contains space

2017-01-17 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MINVOKER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MINVOKER-209.
---
Resolution: Fixed

Fixed in [r1779169|http://svn.apache.org/viewvc?rev=1779169&view=rev] (Hudson 
fails due to m-javadoc-p)

>  ITs fail (on Windows 10) when working directory contains space
> ---
>
> Key: MINVOKER-209
> URL: https://issues.apache.org/jira/browse/MINVOKER-209
> Project: Maven Invoker Plugin
>  Issue Type: Test
>Affects Versions: 3.0.0
> Environment: Windows 10
>Reporter: Alix Lourme
>Assignee: Michael Osipov
>Priority: Minor
>  Labels: test-fail, window
> Fix For: 3.0.0
>
> Attachments: 
> MINVOKER-209-maven-invoker-plugin-IT-double-exec-special-characters-should-work.patch,
>  MINVOKER-209-workaround-maven-invoker-plugin.patch
>
>
> When working copy contains some space (common situation on W10 with users 
> directories Firstname/Lastname), most of ITs fail.
> h3. Scenario
> Command:
> {code}
> mvn invoker:run -Dinvoker.test=special-characters-should-work 
> -Dfile.encoding=UTF-8 -Prun-its,dev
> {code}
> h4. working directory with spaces
> _build.log_ result : 
> {code}
> Running pre-build script: C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script: C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Erreur : impossible de trouver ou charger la classe principale 
> Lastname\git\maven-plugins\maven-invoker-plugin\target
> {code}
> Content of : _DefaultInvoker.executeCommandLine(Commandline, 
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D 
> "maven.repo.local=C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\local-repo" -s 
> "C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\interpolated-settings.xml"
>  -D maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Users\Firstname 
> Lastname\git\maven-plugins\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> h3. working directory without space
> _build.log_ result:
> {code}
> Running pre-build script: 
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Finished pre-build script: 
> c:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work\setup.groovy
> Apache Maven 3.4.0-SNAPSHOT (54827e6b0fc02425f701cfcccde46f81edcb7058; 
> 2016-10-01T18:01:52+02:00)
> ... next lines are ok : BUILD SUCCESS
> {code}
> Content of :  _DefaultInvoker.executeCommandLine(Commandline, 
> InvocationRequest)_ (line: ~126)
> cmd:
> {code}
> cmd.exe /X /C ""C:\Program Files\[MavenDirectory]\bin\mvn.cmd" -B -X -D 
> maven.repo.local=C:\Windows\Temp\maven-invoker-plugin\target\local-repo -s 
> C:\Windows\Temp\maven-invoker-plugin\target\it\interpolated-settings.xml -D 
> maven.compiler.source=1.6 -D maven.compiler.target=1.6 clean verify"
> {code}
> workDir:
> {code}
> C:\Windows\Temp\maven-invoker-plugin\target\it\special-characters-should-work
> {code}
> I'm not sure of the root cause (invoker initialization or _plexus-utils_ 
> problem :()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (MINVOKER-215) Use maven-artifact-transfer to support multiple Aether implementations

2017-01-17 Thread Robert Scholte (JIRA)
Robert Scholte created MINVOKER-215:
---

 Summary: Use maven-artifact-transfer to support multiple Aether 
implementations
 Key: MINVOKER-215
 URL: https://issues.apache.org/jira/browse/MINVOKER-215
 Project: Maven Invoker Plugin
  Issue Type: Improvement
Reporter: Robert Scholte
Assignee: Robert Scholte
Priority: Minor
 Fix For: 3.0.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MINVOKER-215) Use maven-artifact-transfer to support multiple Aether implementations

2017-01-17 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MINVOKER-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MINVOKER-215.
---
Resolution: Fixed

Fixed in [r1779182|http://svn.apache.org/viewvc?rev=1779182&view=rev]

> Use maven-artifact-transfer to support multiple Aether implementations
> --
>
> Key: MINVOKER-215
> URL: https://issues.apache.org/jira/browse/MINVOKER-215
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MINVOKER-215) Use maven-artifact-transfer to support multiple Aether implementations

2017-01-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MINVOKER-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825987#comment-15825987
 ] 

Hudson commented on MINVOKER-215:
-

SUCCESS: Integrated in Jenkins build maven-plugins #8553 (See 
[https://builds.apache.org/job/maven-plugins/8553/])
[MINVOKER-215] Use maven-artifact-transfer to support multiple Aether 
implementations (rfscholte: 
[http://svn.apache.org/viewvc/?view=rev&rev=1779182])
* (edit) maven-invoker-plugin/pom.xml


> Use maven-artifact-transfer to support multiple Aether implementations
> --
>
> Key: MINVOKER-215
> URL: https://issues.apache.org/jira/browse/MINVOKER-215
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (MJAVADOC-477) Use Javadoc instead of JavaDoc in the reporting output

2017-01-17 Thread Michael Benz (JIRA)
Michael Benz created MJAVADOC-477:
-

 Summary: Use Javadoc instead of JavaDoc in the reporting output
 Key: MJAVADOC-477
 URL: https://issues.apache.org/jira/browse/MJAVADOC-477
 Project: Maven Javadoc Plugin
  Issue Type: Bug
  Components: javadoc
Affects Versions: 2.10.4
 Environment: Java 8
Reporter: Michael Benz
Priority: Trivial


Also the current maven-javadoc-plugin uses "JavaDoc" instead of "Javadoc" in 
the reporting output.

{code}
[INFO] Generating "JavaDocs" report --- 
maven-javadoc-plugin:2.10.4:javadoc
{code}

Correct:
{code}
(...)
Constructing Javadoc information...
(...)
[WARNING] Javadoc Warnings
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MJAVADOC-477) Use Javadoc instead of JavaDoc in the reporting output

2017-01-17 Thread Michael Benz (JIRA)

 [ 
https://issues.apache.org/jira/browse/MJAVADOC-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Benz updated MJAVADOC-477:
--
Attachment: Maven_Site_Reports_de-DE.PNG

(German) Maven Site project output also contains:
- JavaDocs
- Test JavaDocs

> Use Javadoc instead of JavaDoc in the reporting output
> --
>
> Key: MJAVADOC-477
> URL: https://issues.apache.org/jira/browse/MJAVADOC-477
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 2.10.4
> Environment: Java 8
>Reporter: Michael Benz
>Priority: Trivial
> Attachments: Maven_Site_Reports_de-DE.PNG
>
>
> Also the current maven-javadoc-plugin uses "JavaDoc" instead of "Javadoc" in 
> the reporting output.
> {code}
> [INFO] Generating "JavaDocs" report --- 
> maven-javadoc-plugin:2.10.4:javadoc
> {code}
> Correct:
> {code}
> (...)
> Constructing Javadoc information...
> (...)
> [WARNING] Javadoc Warnings
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (MJAVADOC-477) Use Javadoc instead of JavaDoc in the reporting output

2017-01-17 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MJAVADOC-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MJAVADOC-477:
---

Assignee: Michael Osipov

> Use Javadoc instead of JavaDoc in the reporting output
> --
>
> Key: MJAVADOC-477
> URL: https://issues.apache.org/jira/browse/MJAVADOC-477
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 2.10.4
> Environment: Java 8
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: Maven_Site_Reports_de-DE.PNG
>
>
> Also the current maven-javadoc-plugin uses "JavaDoc" instead of "Javadoc" in 
> the reporting output.
> {code}
> [INFO] Generating "JavaDocs" report --- 
> maven-javadoc-plugin:2.10.4:javadoc
> {code}
> Correct:
> {code}
> (...)
> Constructing Javadoc information...
> (...)
> [WARNING] Javadoc Warnings
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MJAVADOC-477) Use Javadoc instead of JavaDoc in the reporting output

2017-01-17 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MJAVADOC-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MJAVADOC-477:

Fix Version/s: 3.0.0

> Use Javadoc instead of JavaDoc in the reporting output
> --
>
> Key: MJAVADOC-477
> URL: https://issues.apache.org/jira/browse/MJAVADOC-477
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 2.10.4
> Environment: Java 8
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: Maven_Site_Reports_de-DE.PNG
>
>
> Also the current maven-javadoc-plugin uses "JavaDoc" instead of "Javadoc" in 
> the reporting output.
> {code}
> [INFO] Generating "JavaDocs" report --- 
> maven-javadoc-plugin:2.10.4:javadoc
> {code}
> Correct:
> {code}
> (...)
> Constructing Javadoc information...
> (...)
> [WARNING] Javadoc Warnings
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MJAVADOC-477) Use Javadoc instead of JavaDoc in the reporting output

2017-01-17 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/MJAVADOC-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826454#comment-15826454
 ] 

Michael Osipov commented on MJAVADOC-477:
-

According to 
[this|http://www.oracle.com/technetwork/java/javase/documentation/index-jsp-135444.html#javadocdocuments],
 {{Javadoc}} is the canonical name.

> Use Javadoc instead of JavaDoc in the reporting output
> --
>
> Key: MJAVADOC-477
> URL: https://issues.apache.org/jira/browse/MJAVADOC-477
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 2.10.4
> Environment: Java 8
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: Maven_Site_Reports_de-DE.PNG
>
>
> Also the current maven-javadoc-plugin uses "JavaDoc" instead of "Javadoc" in 
> the reporting output.
> {code}
> [INFO] Generating "JavaDocs" report --- 
> maven-javadoc-plugin:2.10.4:javadoc
> {code}
> Correct:
> {code}
> (...)
> Constructing Javadoc information...
> (...)
> [WARNING] Javadoc Warnings
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (MJAVADOC-477) Use Javadoc instead of JavaDoc in the reporting output

2017-01-17 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/MJAVADOC-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826454#comment-15826454
 ] 

Michael Osipov edited comment on MJAVADOC-477 at 1/17/17 5:37 PM:
--

According to 
[this|http://www.oracle.com/technetwork/java/javase/documentation/index-jsp-135444.html#javadocdocuments],
 {{Javadoc}} is the canonical name. Testing a locally patched version...


was (Author: michael-o):
According to 
[this|http://www.oracle.com/technetwork/java/javase/documentation/index-jsp-135444.html#javadocdocuments],
 {{Javadoc}} is the canonical name.

> Use Javadoc instead of JavaDoc in the reporting output
> --
>
> Key: MJAVADOC-477
> URL: https://issues.apache.org/jira/browse/MJAVADOC-477
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 2.10.4
> Environment: Java 8
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: Maven_Site_Reports_de-DE.PNG
>
>
> Also the current maven-javadoc-plugin uses "JavaDoc" instead of "Javadoc" in 
> the reporting output.
> {code}
> [INFO] Generating "JavaDocs" report --- 
> maven-javadoc-plugin:2.10.4:javadoc
> {code}
> Correct:
> {code}
> (...)
> Constructing Javadoc information...
> (...)
> [WARNING] Javadoc Warnings
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MJAVADOC-477) Use Javadoc instead of JavaDoc in the reporting output

2017-01-17 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MJAVADOC-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MJAVADOC-477.
---
Resolution: Fixed

Fixed with [r1779225|http://svn.apache.org/r1779225].

> Use Javadoc instead of JavaDoc in the reporting output
> --
>
> Key: MJAVADOC-477
> URL: https://issues.apache.org/jira/browse/MJAVADOC-477
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 2.10.4
> Environment: Java 8
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: Maven_Site_Reports_de-DE.PNG
>
>
> Also the current maven-javadoc-plugin uses "JavaDoc" instead of "Javadoc" in 
> the reporting output.
> {code}
> [INFO] Generating "JavaDocs" report --- 
> maven-javadoc-plugin:2.10.4:javadoc
> {code}
> Correct:
> {code}
> (...)
> Constructing Javadoc information...
> (...)
> [WARNING] Javadoc Warnings
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MJAVADOC-477) Use Javadoc instead of JavaDoc in the reporting output

2017-01-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MJAVADOC-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826535#comment-15826535
 ] 

Hudson commented on MJAVADOC-477:
-

SUCCESS: Integrated in Jenkins build maven-plugins #8558 (See 
[https://builds.apache.org/job/maven-plugins/8558/])
[MJAVADOC-477] Use Javadoc instead of JavaDoc in the reporting output 
(michaelo: [http://svn.apache.org/viewvc/?view=rev&rev=1779225])
* (edit) maven-javadoc-plugin/src/it/MJAVADOC-194/module1/pom.xml
* (edit) maven-javadoc-plugin/src/it/MJAVADOC-194/module2/pom.xml
* (edit) maven-javadoc-plugin/src/main/resources/javadoc-report.properties
* (edit) maven-javadoc-plugin/src/main/resources/javadoc-report_de.properties
* (edit) maven-javadoc-plugin/src/main/resources/javadoc-report_fr.properties
* (edit) maven-javadoc-plugin/src/main/resources/javadoc-report_nl.properties
* (edit) maven-javadoc-plugin/src/main/resources/javadoc-report_sv.properties
* (edit) maven-javadoc-plugin/src/main/resources/test-javadoc-report.properties
* (edit) 
maven-javadoc-plugin/src/main/resources/test-javadoc-report_de.properties
* (edit) 
maven-javadoc-plugin/src/main/resources/test-javadoc-report_fr.properties
* (edit) 
maven-javadoc-plugin/src/main/resources/test-javadoc-report_nl.properties
* (edit) 
maven-javadoc-plugin/src/main/resources/test-javadoc-report_sv.properties
* (edit) maven-javadoc-plugin/src/site/fml/faq.fml


> Use Javadoc instead of JavaDoc in the reporting output
> --
>
> Key: MJAVADOC-477
> URL: https://issues.apache.org/jira/browse/MJAVADOC-477
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 2.10.4
> Environment: Java 8
>Reporter: Michael Benz
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: Maven_Site_Reports_de-DE.PNG
>
>
> Also the current maven-javadoc-plugin uses "JavaDoc" instead of "Javadoc" in 
> the reporting output.
> {code}
> [INFO] Generating "JavaDocs" report --- 
> maven-javadoc-plugin:2.10.4:javadoc
> {code}
> Correct:
> {code}
> (...)
> Constructing Javadoc information...
> (...)
> [WARNING] Javadoc Warnings
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MENFORCER-261) We have rule requireActiveProfile, now implement rule BanProfiles

2017-01-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MENFORCER-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826659#comment-15826659
 ] 

ASF GitHub Bot commented on MENFORCER-261:
--

GitHub user mikkoi opened a pull request:

https://github.com/apache/maven-enforcer/pull/21

Add rule: banProfiles

Same patch as in https://issues.apache.org/jira/browse/MENFORCER-261

Signed-off-by: Mikko Johannes Koivunalho 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mikkoi/maven-enforcer ban-profiles

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-enforcer/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #21


commit 61afeed50313d002dfac205f292ab0b231ce8acf
Author: Mikko Johannes Koivunalho 
Date:   2017-01-17T19:27:07Z

Add rule: banProfiles

Signed-off-by: Mikko Johannes Koivunalho 




> We have rule requireActiveProfile, now implement rule BanProfiles
> -
>
> Key: MENFORCER-261
> URL: https://issues.apache.org/jira/browse/MENFORCER-261
> Project: Maven Enforcer Plugin
>  Issue Type: Improvement
>  Components: Documentation, Standard Rules
>Reporter: Mikko Johannes Koivunalho
>  Labels: patch
> Attachments: enforcerBanProfiles.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Implement rule to ban one or more profiles from being active.
> This has been discussed in MENFORCER-225.
> But no ticket was created, and the created patch may have become invalid due 
> to age and development.
> So here is a new patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MENFORCER-261) We have rule requireActiveProfile, now implement rule BanProfiles

2017-01-17 Thread Mikko Johannes Koivunalho (JIRA)

 [ 
https://issues.apache.org/jira/browse/MENFORCER-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikko Johannes Koivunalho updated MENFORCER-261:

Description: 
Implement rule to ban one or more profiles from being active.

This has been discussed in MENFORCER-225.
But no ticket was created, and the created patch may have become invalid due to 
age and development.

So here is a new patch.

This batch is also a pull request in GitHub: 
https://github.com/apache/maven-enforcer/pull/21


  was:
Implement rule to ban one or more profiles from being active.

This has been discussed in MENFORCER-225.
But no ticket was created, and the created patch may have become invalid due to 
age and development.

So here is a new patch.


> We have rule requireActiveProfile, now implement rule BanProfiles
> -
>
> Key: MENFORCER-261
> URL: https://issues.apache.org/jira/browse/MENFORCER-261
> Project: Maven Enforcer Plugin
>  Issue Type: Improvement
>  Components: Documentation, Standard Rules
>Reporter: Mikko Johannes Koivunalho
>  Labels: patch
> Attachments: enforcerBanProfiles.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Implement rule to ban one or more profiles from being active.
> This has been discussed in MENFORCER-225.
> But no ticket was created, and the created patch may have become invalid due 
> to age and development.
> So here is a new patch.
> This batch is also a pull request in GitHub: 
> https://github.com/apache/maven-enforcer/pull/21



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MENFORCER-261) We have rule requireActiveProfile, now implement rule BanProfiles

2017-01-17 Thread Mikko Johannes Koivunalho (JIRA)

 [ 
https://issues.apache.org/jira/browse/MENFORCER-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikko Johannes Koivunalho updated MENFORCER-261:

Description: 
Implement rule to ban one or more profiles from being active.

This has been discussed in MENFORCER-225.
But no ticket was created, and the created patch may have become invalid due to 
age and development.

So here is a new patch.


  was:
Implement rule to ban one or more profiles from being active.

This has been discussed in MENFORCER-225.
But no ticket was created, and the created patch may have become invalid due to 
age and development.

So here is a new patch.

This batch is also a pull request in GitHub: 
https://github.com/apache/maven-enforcer/pull/21



> We have rule requireActiveProfile, now implement rule BanProfiles
> -
>
> Key: MENFORCER-261
> URL: https://issues.apache.org/jira/browse/MENFORCER-261
> Project: Maven Enforcer Plugin
>  Issue Type: Improvement
>  Components: Documentation, Standard Rules
>Reporter: Mikko Johannes Koivunalho
>  Labels: patch
> Attachments: enforcerBanProfiles.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Implement rule to ban one or more profiles from being active.
> This has been discussed in MENFORCER-225.
> But no ticket was created, and the created patch may have become invalid due 
> to age and development.
> So here is a new patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MSHADE-241) Groovy extension module transformer

2017-01-17 Thread *$^¨%`£

 [ 
https://issues.apache.org/jira/browse/MSHADE-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy (*$^¨%`£) closed MSHADE-241.
-
Resolution: Fixed

pr merged.

> Groovy extension module transformer
> ---
>
> Key: MSHADE-241
> URL: https://issues.apache.org/jira/browse/MSHADE-241
> Project: Maven Shade Plugin
>  Issue Type: Improvement
>Affects Versions: 2.4.3
>Reporter: Julien Viet
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 2.4.4
>
>
> Currently Groovy uses a specific format for its extension modules located 
> under the name META-INF/services/org.codehaus.groovy.runtime.ExtensionModule .
> The content is actually a property file with 4 entries:
> - moduleName
> - moduleVersion
> - extensionClasses : a comma separated list of class names
> - staticExtensionClasses : :a comma separated list of class names
> A correct merge operation should merge the list extensionClasses and 
> staticExtensionClasses
> Such merge operation can be implemented as a resource transformer. It not 
> require any of a specific Groovy class and can operate on plain property 
> files.
> I am willing to contribute this with tests as a resource transformer. In fact 
> I already have an working implementation (quite trivial).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MINVOKER-214) Allow indexed maven.version and os.familiy in invoker.properties

2017-01-17 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MINVOKER-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MINVOKER-214.
---
   Resolution: Fixed
Fix Version/s: 3.0.0

Fixed in [r1779250|http://svn.apache.org/viewvc?rev=1779250&view=rev]

Solved by adding the following options:
{noformat}
selector.1.java.version = 1.5+
selector.1.maven.version = 3.2.5+
selector.1.os.family = !windows
selector.2.maven.version = 3.3.9+
selector.3.java.version = 1.6+
{noformat}

If one of the selectors evaluates to true, the test is executed. 


> Allow indexed maven.version and os.familiy in invoker.properties
> 
>
> Key: MINVOKER-214
> URL: https://issues.apache.org/jira/browse/MINVOKER-214
> Project: Maven Invoker Plugin
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Robert Scholte
>Assignee: Robert Scholte
> Fix For: 3.0.0
>
>
> MINVOKER-209 requires two criteria to run, i.e:
> - Always for non-windows
> - When Windows, run it only with Maven 3.5.0+
> For {{maven.version}}, {{os.family}} and {{java.version}} indexed keys are 
> not allowed (undocumented!), because it makes it much easier to explain why 
> the IT didn't run. In fact, there are much more properties which don't work 
> with an index.
> We could clone the test, but that implies you need to keep both ITs in sync.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSHADE-241) Groovy extension module transformer

2017-01-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MSHADE-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826749#comment-15826749
 ] 

ASF GitHub Bot commented on MSHADE-241:
---

Github user vietj closed the pull request at:

https://github.com/apache/maven-plugins/pull/96


> Groovy extension module transformer
> ---
>
> Key: MSHADE-241
> URL: https://issues.apache.org/jira/browse/MSHADE-241
> Project: Maven Shade Plugin
>  Issue Type: Improvement
>Affects Versions: 2.4.3
>Reporter: Julien Viet
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 2.4.4
>
>
> Currently Groovy uses a specific format for its extension modules located 
> under the name META-INF/services/org.codehaus.groovy.runtime.ExtensionModule .
> The content is actually a property file with 4 entries:
> - moduleName
> - moduleVersion
> - extensionClasses : a comma separated list of class names
> - staticExtensionClasses : :a comma separated list of class names
> A correct merge operation should merge the list extensionClasses and 
> staticExtensionClasses
> Such merge operation can be implemented as a resource transformer. It not 
> require any of a specific Groovy class and can operate on plain property 
> files.
> I am willing to contribute this with tests as a resource transformer. In fact 
> I already have an working implementation (quite trivial).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MSHADE-187) Change location of the dependency reduced pom

2017-01-17 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSHADE-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MSHADE-187.
-
   Resolution: Duplicate
 Assignee: Robert Scholte
Fix Version/s: (was: 3.0.0)

> Change location of the dependency reduced pom
> -
>
> Key: MSHADE-187
> URL: https://issues.apache.org/jira/browse/MSHADE-187
> Project: Maven Shade Plugin
>  Issue Type: Improvement
>Affects Versions: 2.3
>Reporter: Karl Heinz Marbaise
>Assignee: Robert Scholte
>Priority: Minor
>
> Using the following configuration:
> {code}
>   
> org.apache.maven.plugins
> maven-shade-plugin
> 
>   
> 
>   org.apache.maven.profiler:*
>   org.apache.maven.plugins:*
>   org.apache.maven.surefire:*
> 
> 
>   org.sonatype.plexus:*
>   javax:*
> 
>   
> 
> 
>   
> 
>   shade
> 
>   
> 
>   
> {code}
> Based on the docs:
> {code}
> Flag whether to generate a simplified POM for the shaded artifact. If set to 
> true, dependencies that have been included into the uber JAR will be removed 
> from the  section of the generated POM. The reduced POM will be 
> named dependency-reduced-pom.xml and is stored into the same directory as the 
> shaded artifact. Unless you also specify dependencyReducedPomLocation, the 
> plugin will create a temporary file named dependency-reduced-pom.xml in the 
> project basedir.
> {code}
> The dependency reduced pom should be stored within target folder (where the 
> shaded artifacts has been stored into) and not in the project basedir.
> This is the documentation of the dependencyReducedPomLocation parameter:
> {code}
>  * Where to put the dependency reduced pom.
>  * Note: setting a value for this parameter with a directory other than 
> ${basedir} will change the value of
>  * ${basedir} for all executions that come after the shade execution. 
> This is often not what you want.
>  * This is considered an open issue with this plugin.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MINVOKER-214) Allow indexed maven.version and os.familiy in invoker.properties

2017-01-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MINVOKER-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826759#comment-15826759
 ] 

Hudson commented on MINVOKER-214:
-

SUCCESS: Integrated in Jenkins build maven-plugins #8562 (See 
[https://builds.apache.org/job/maven-plugins/8562/])
[MINVOKER-214] Allow indexed maven.version and os.familiy in invoker.properties 
(rfscholte: [http://svn.apache.org/viewvc/?view=rev&rev=1779250])
* (edit) maven-invoker-plugin/pom.xml
* (edit) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java
* (edit) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/InvokerProperties.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/Selector.java
* (edit) 
maven-invoker-plugin/src/test/java/org/apache/maven/plugin/invoker/InvokerPropertiesTest.java
* (add) 
maven-invoker-plugin/src/test/java/org/apache/maven/plugin/invoker/SelectorTest.java


> Allow indexed maven.version and os.familiy in invoker.properties
> 
>
> Key: MINVOKER-214
> URL: https://issues.apache.org/jira/browse/MINVOKER-214
> Project: Maven Invoker Plugin
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Robert Scholte
>Assignee: Robert Scholte
> Fix For: 3.0.0
>
>
> MINVOKER-209 requires two criteria to run, i.e:
> - Always for non-windows
> - When Windows, run it only with Maven 3.5.0+
> For {{maven.version}}, {{os.family}} and {{java.version}} indexed keys are 
> not allowed (undocumented!), because it makes it much easier to explain why 
> the IT didn't run. In fact, there are much more properties which don't work 
> with an index.
> We could clone the test, but that implies you need to keep both ITs in sync.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (MSHADE-246) Switch to maven-artifact-transfer to support both Aether implementations

2017-01-17 Thread Robert Scholte (JIRA)
Robert Scholte created MSHADE-246:
-

 Summary: Switch to maven-artifact-transfer to support both Aether 
implementations
 Key: MSHADE-246
 URL: https://issues.apache.org/jira/browse/MSHADE-246
 Project: Maven Shade Plugin
  Issue Type: Improvement
Affects Versions: 2.4.3
Reporter: Robert Scholte
Assignee: Robert Scholte
 Fix For: 3.0.0


This is also required if we want the plugin to be a real Maven3 plugin, not 
depending on maven-compat anymore.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MSHADE-246) Switch to maven-artifact-transfer to support both Aether implementations

2017-01-17 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSHADE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MSHADE-246.
-
Resolution: Fixed

Fixed in [r1779258|http://svn.apache.org/viewvc?rev=1779258&view=rev]

> Switch to maven-artifact-transfer to support both Aether implementations
> 
>
> Key: MSHADE-246
> URL: https://issues.apache.org/jira/browse/MSHADE-246
> Project: Maven Shade Plugin
>  Issue Type: Improvement
>Affects Versions: 2.4.3
>Reporter: Robert Scholte
>Assignee: Robert Scholte
> Fix For: 3.0.0
>
>
> This is also required if we want the plugin to be a real Maven3 plugin, not 
> depending on maven-compat anymore.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MSHADE-232) AppendingTransformer should support wildcard resources

2017-01-17 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSHADE-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MSHADE-232:
--
Fix Version/s: (was: 2.4.4)
   3.0.0

> AppendingTransformer should support wildcard resources
> --
>
> Key: MSHADE-232
> URL: https://issues.apache.org/jira/browse/MSHADE-232
> Project: Maven Shade Plugin
>  Issue Type: Improvement
>Affects Versions: 2.4.3
>Reporter: dennis lucero
>Priority: Minor
> Fix For: 3.0.0
>
>
> {{AppendingTransformer}} should support wildcards in {{resource}} elements.
> Currently it is necessary to add
> {code} implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
> ValidationMessages.properties
> 
>  implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
> ValidationMessages_en.properties
> 
>  implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
> ValidationMessages_de.properties
> {code}
> and so on to join messages from different dependencies.
> In this case it should be sufficient to specify a single 
> {{AppendingTransformer}} having
> {code}ValidationMessages*.properties{code}
> but that should not match {{ValidationMessagesFoo/Bar.properties}} (maybe 
> {{ValidationMessages**.properties}} would).
> Alternatively a way to specify regular expressions would also work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MSHADE-225) Writing output only once

2017-01-17 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSHADE-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MSHADE-225:
--
Fix Version/s: (was: 2.4.4)
   3.0.0

> Writing output only once
> 
>
> Key: MSHADE-225
> URL: https://issues.apache.org/jira/browse/MSHADE-225
> Project: Maven Shade Plugin
>  Issue Type: Improvement
>Affects Versions: 2.4.3
>Reporter: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0
>
>
> Currently maven-shade-plugin writes something like this:
> {noformat}
> [INFO] Dependency-reduced POM written at: 
> /.../apache-maven/maven-shared/maven-artifact-transfer/dependency-reduced-pom.xml
> [INFO] Dependency-reduced POM written at: 
> /.../apache-maven/maven-shared/maven-artifact-transfer/dependency-reduced-pom.xml
> {noformat}
> which should be written only once..



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MSHADE-241) Groovy extension module transformer

2017-01-17 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSHADE-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MSHADE-241:
--
Fix Version/s: (was: 2.4.4)
   3.0.0

> Groovy extension module transformer
> ---
>
> Key: MSHADE-241
> URL: https://issues.apache.org/jira/browse/MSHADE-241
> Project: Maven Shade Plugin
>  Issue Type: Improvement
>Affects Versions: 2.4.3
>Reporter: Julien Viet
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 3.0.0
>
>
> Currently Groovy uses a specific format for its extension modules located 
> under the name META-INF/services/org.codehaus.groovy.runtime.ExtensionModule .
> The content is actually a property file with 4 entries:
> - moduleName
> - moduleVersion
> - extensionClasses : a comma separated list of class names
> - staticExtensionClasses : :a comma separated list of class names
> A correct merge operation should merge the list extensionClasses and 
> staticExtensionClasses
> Such merge operation can be implemented as a resource transformer. It not 
> require any of a specific Groovy class and can operate on plain property 
> files.
> I am willing to contribute this with tests as a resource transformer. In fact 
> I already have an working implementation (quite trivial).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MSHADE-219) Update XSD location of POM to the new one in POMWriter

2017-01-17 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSHADE-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MSHADE-219:
--
Fix Version/s: (was: 2.4.4)
   3.0.0

> Update XSD location of POM to the new one in POMWriter
> --
>
> Key: MSHADE-219
> URL: https://issues.apache.org/jira/browse/MSHADE-219
> Project: Maven Shade Plugin
>  Issue Type: Improvement
>Affects Versions: 2.4.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 3.0.0
>
>
> The {{POMWriter}} still refers to the old location: 
> http://maven.apache.org/maven-v4_0_0.xsd



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MINVOKER-214) Allow indexed maven.version and os.familiy in invoker.properties

2017-01-17 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MINVOKER-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826773#comment-15826773
 ] 

Guillaume Boué commented on MINVOKER-214:
-

Is it not possible to support a {{invoker.java.version.1}} syntax? It would 
prevent the creation of a new syntax just for those. Also, can the 
documentation be updated in [the selector conditions 
page|http://maven.apache.org/plugins/maven-invoker-plugin/examples/selector-conditions.html]?

> Allow indexed maven.version and os.familiy in invoker.properties
> 
>
> Key: MINVOKER-214
> URL: https://issues.apache.org/jira/browse/MINVOKER-214
> Project: Maven Invoker Plugin
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Robert Scholte
>Assignee: Robert Scholte
> Fix For: 3.0.0
>
>
> MINVOKER-209 requires two criteria to run, i.e:
> - Always for non-windows
> - When Windows, run it only with Maven 3.5.0+
> For {{maven.version}}, {{os.family}} and {{java.version}} indexed keys are 
> not allowed (undocumented!), because it makes it much easier to explain why 
> the IT didn't run. In fact, there are much more properties which don't work 
> with an index.
> We could clone the test, but that implies you need to keep both ITs in sync.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSHADE-246) Switch to maven-artifact-transfer to support both Aether implementations

2017-01-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MSHADE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826791#comment-15826791
 ] 

Hudson commented on MSHADE-246:
---

SUCCESS: Integrated in Jenkins build maven-plugins #8563 (See 
[https://builds.apache.org/job/maven-plugins/8563/])
[MSHADE-246] Switch to maven-artifact-transfer to support both Aether 
implementations (rfscholte: 
[http://svn.apache.org/viewvc/?view=rev&rev=1779258])
* (edit) maven-shade-plugin/pom.xml
* (edit) 
maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
* (edit) 
maven-shade-plugin/src/test/java/org/apache/maven/plugins/shade/mojo/ShadeMojoTest.java


> Switch to maven-artifact-transfer to support both Aether implementations
> 
>
> Key: MSHADE-246
> URL: https://issues.apache.org/jira/browse/MSHADE-246
> Project: Maven Shade Plugin
>  Issue Type: Improvement
>Affects Versions: 2.4.3
>Reporter: Robert Scholte
>Assignee: Robert Scholte
> Fix For: 3.0.0
>
>
> This is also required if we want the plugin to be a real Maven3 plugin, not 
> depending on maven-compat anymore.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MINVOKER-214) Allow indexed maven.version and os.familiy in invoker.properties

2017-01-17 Thread Robert Scholte (JIRA)

[ 
https://issues.apache.org/jira/browse/MINVOKER-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826795#comment-15826795
 ] 

Robert Scholte commented on MINVOKER-214:
-

I thought about it, but it is not correct, because that would suggest that 
{{invoker.goals.1}} are only executed when matching {{invoker.java.version.1}} 
and  {{invoker.goals.2}} when matching {{invoker.java.version.2}}. What we want 
is: call all (indexed) goals when at least one selector criteria is matched.
Also, if you take a look which properties are indexed, those are the ones being 
passed to the maven-invoker component.
So there's a huge differenct between the selector properties and the invoker 
properties, hence doing it with a different prefix should make that clear.

And yes, I should update that page as well.

> Allow indexed maven.version and os.familiy in invoker.properties
> 
>
> Key: MINVOKER-214
> URL: https://issues.apache.org/jira/browse/MINVOKER-214
> Project: Maven Invoker Plugin
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Robert Scholte
>Assignee: Robert Scholte
> Fix For: 3.0.0
>
>
> MINVOKER-209 requires two criteria to run, i.e:
> - Always for non-windows
> - When Windows, run it only with Maven 3.5.0+
> For {{maven.version}}, {{os.family}} and {{java.version}} indexed keys are 
> not allowed (undocumented!), because it makes it much easier to explain why 
> the IT didn't run. In fact, there are much more properties which don't work 
> with an index.
> We could clone the test, but that implies you need to keep both ITs in sync.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MSHADE-212) Check if we can take the changes from here https://github.com/immutables/maven-shade-plugin

2017-01-17 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSHADE-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MSHADE-212:
--
Fix Version/s: (was: 3.0.0)
   more-investigation

> Check if we can take the changes from here 
> https://github.com/immutables/maven-shade-plugin
> ---
>
> Key: MSHADE-212
> URL: https://issues.apache.org/jira/browse/MSHADE-212
> Project: Maven Shade Plugin
>  Issue Type: Improvement
>Reporter: Karl Heinz Marbaise
> Fix For: more-investigation
>
>
> Check if we could take the changes into the original place...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MSHADE-222) Dependency updates.

2017-01-17 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSHADE-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MSHADE-222:
--
Description: 
* maven-plugins:org.apache.maven.plugins:pom 28 -> 30
* org.codehaus.plexus:plexus-utils:jar 3.0.22 -> 3.0.24
* org.ow2.asm:*:jar 5.0.2 -> 5.1
* org.jdom:jdom:jar 1.1 -> 1.1.3
* commons-io:commons-io:jar 2.2 -> 2.5
* com.google.guava:guava:11.0.2 -> 19.0
* org.apache.maven.shared:maven-artifact-transfer:jar:0.9.0


> Dependency updates.
> ---
>
> Key: MSHADE-222
> URL: https://issues.apache.org/jira/browse/MSHADE-222
> Project: Maven Shade Plugin
>  Issue Type: Task
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Trivial
> Fix For: 3.0.0
>
>
> * maven-plugins:org.apache.maven.plugins:pom 28 -> 30
> * org.codehaus.plexus:plexus-utils:jar 3.0.22 -> 3.0.24
> * org.ow2.asm:*:jar 5.0.2 -> 5.1
> * org.jdom:jdom:jar 1.1 -> 1.1.3
> * commons-io:commons-io:jar 2.2 -> 2.5
> * com.google.guava:guava:11.0.2 -> 19.0
> * org.apache.maven.shared:maven-artifact-transfer:jar:0.9.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (MSHADE-222) Dependency updates.

2017-01-17 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSHADE-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte resolved MSHADE-222.
---
Resolution: Fixed

> Dependency updates.
> ---
>
> Key: MSHADE-222
> URL: https://issues.apache.org/jira/browse/MSHADE-222
> Project: Maven Shade Plugin
>  Issue Type: Task
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Trivial
> Fix For: 3.0.0
>
>
> * maven-plugins:org.apache.maven.plugins:pom 28 -> 30
> * org.codehaus.plexus:plexus-utils:jar 3.0.22 -> 3.0.24
> * org.ow2.asm:*:jar 5.0.2 -> 5.1
> * org.jdom:jdom:jar 1.1 -> 1.1.3
> * commons-io:commons-io:jar 2.2 -> 2.5
> * com.google.guava:guava:11.0.2 -> 19.0
> * org.apache.maven.shared:maven-artifact-transfer:jar:0.9.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MSHADE-225) Writing output only once

2017-01-17 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSHADE-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MSHADE-225.
-
Resolution: Fixed
  Assignee: Robert Scholte

Fixed in [r1779270|http://svn.apache.org/viewvc?rev=1779270&view=rev]
It is only reducing the noise, might need to figure if the reducing algorithm 
could be optimized.

> Writing output only once
> 
>
> Key: MSHADE-225
> URL: https://issues.apache.org/jira/browse/MSHADE-225
> Project: Maven Shade Plugin
>  Issue Type: Improvement
>Affects Versions: 2.4.3
>Reporter: Karl Heinz Marbaise
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 3.0.0
>
>
> Currently maven-shade-plugin writes something like this:
> {noformat}
> [INFO] Dependency-reduced POM written at: 
> /.../apache-maven/maven-shared/maven-artifact-transfer/dependency-reduced-pom.xml
> [INFO] Dependency-reduced POM written at: 
> /.../apache-maven/maven-shared/maven-artifact-transfer/dependency-reduced-pom.xml
> {noformat}
> which should be written only once..



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSHADE-225) Writing output only once

2017-01-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MSHADE-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826912#comment-15826912
 ] 

Hudson commented on MSHADE-225:
---

SUCCESS: Integrated in Jenkins build maven-plugins #8565 (See 
[https://builds.apache.org/job/maven-plugins/8565/])
[MSHADE-225] Writing output only once
Probably only happens in case of reducing reactor projects (rfscholte: 
[http://svn.apache.org/viewvc/?view=rev&rev=1779270])
* (edit) maven-shade-plugin/src/it/project-with-reactors-included/verify.bsh
* (edit) 
maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java


> Writing output only once
> 
>
> Key: MSHADE-225
> URL: https://issues.apache.org/jira/browse/MSHADE-225
> Project: Maven Shade Plugin
>  Issue Type: Improvement
>Affects Versions: 2.4.3
>Reporter: Karl Heinz Marbaise
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 3.0.0
>
>
> Currently maven-shade-plugin writes something like this:
> {noformat}
> [INFO] Dependency-reduced POM written at: 
> /.../apache-maven/maven-shared/maven-artifact-transfer/dependency-reduced-pom.xml
> [INFO] Dependency-reduced POM written at: 
> /.../apache-maven/maven-shared/maven-artifact-transfer/dependency-reduced-pom.xml
> {noformat}
> which should be written only once..



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MNG-5958) java.lang.String cannot be cast to org.apache.maven.lifecycle.mapping.LifecyclePhase

2017-01-17 Thread Christian Schulte (JIRA)

[ 
https://issues.apache.org/jira/browse/MNG-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826943#comment-15826943
 ] 

Christian Schulte commented on MNG-5958:


The changes to the core integration testing repository have been discussed on 
dev@. See the following threads.

[\[IT MNG-5958\]: Please review integration test for 
MNG-5958|http://www.mail-archive.com/dev@maven.apache.org/msg112133.html]
[\[IT MNG-5958 - Take 2\]: Please review integration test for 
MNG-5958|http://www.mail-archive.com/dev@maven.apache.org/msg112212.html]

> java.lang.String cannot be cast to 
> org.apache.maven.lifecycle.mapping.LifecyclePhase
> 
>
> Key: MNG-5958
> URL: https://issues.apache.org/jira/browse/MNG-5958
> Project: Maven
>  Issue Type: Bug
>  Components: Plugins and Lifecycle
>Affects Versions: 3.3.9
> Environment: win 8.1
>Reporter: Meytal Genah
>Assignee: Christian Schulte
>Priority: Minor
> Fix For: 3.5.0
>
>
> Our app uses flex mojo.
> We upgraded from Maven 3.3.3 to Maven 3.3.9 and when building we get:
> {noformat}[ERROR] Internal error: java.lang.ClassCastException: 
> java.lang.String cannot be cast to 
> org.apache.maven.lifecycle.mapping.LifecyclePhase -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.maven.lifecycle.mapping.LifecyclePhas
> e
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:121)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.maven.lifecycle.mapping.LifecyclePhase
> at 
> org.apache.maven.lifecycle.internal.DefaultLifecyclePluginAnalyzer.getPluginsBoundByDefaultToAllLifecycles(DefaultLifecyclePluginAnalyzer.java:119)
> at 
> org.apache.maven.model.plugin.DefaultLifecycleBindingsInjector.injectLifecycleBindings(DefaultLifecycleBindingsInjector.java:64)
> at 
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:451)
> at 
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:421)
> at 
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:620)
> at 
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:626)
> at 
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:626)
> at 
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:626)
> at 
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:626)
> at 
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:411)
> at 
> org.apache.maven.graph.DefaultGraphBuilder.collectProjects(DefaultGraphBuilder.java:419)
> at 
> org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor(DefaultGraphBuilder.java:410)
> at 
> org.apache.maven.graph.DefaultGraphBuilder.build(DefaultGraphBuilder.java:83)
> at org.apache.maven.DefaultMaven.buildGraph(DefaultMaven.java:491)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:219)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> ... 11 more{noformat}
> I didn’t see anyone encountering the same problem. Maybe it is related to the 
> fix of https://issues.apache.org/jira/browse/MNG-5805.
> Also, according to the stack trace, the invalid casting is in this line:
> {code:java}LifecyclePhase goals = 
> goalsForLifecyclePhase.getValue();{code}
> this is the content of the pom.xml:
> {code:xml}http://maven.apache.org/POM/4.0.0";
>  xmlns:xsi="http://www.w3