[jira] [Commented] (MSHADE-248) shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
[
https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858520#comment-15858520
]
Robert Scholte commented on MSHADE-248:
---
If it would have been the main jar, you would have a real issue which would
require the same kind of actions. The corrupt jar isn't a jar so hence it
cannot be opened. I consider this too rare to fix.
> shading fails with "error in opening zip file" if createSourcesJar=true and
> an invalid sources jar file is encountered
> --
>
> Key: MSHADE-248
> URL: https://issues.apache.org/jira/browse/MSHADE-248
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.4.3
>Reporter: Ian Springer
>
> {code}
> Downloading:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
> Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> (2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
>
> BUILD FAILURE
>
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project
> jclouds-shaded: Error creating shaded jar: error in opening zip file
> /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar ->
> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't
> control the fact that they have an invalid sources jar published, the shade
> plugin should be more forgiving and just log a warning and skip the bsh
> sources jar when building the shaded sources jar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MSHADE-248) shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
[
https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858469#comment-15858469
]
Michael Osipov commented on MSHADE-248:
---
Alright! [~rfscholte], what do you think, can we have a better message? Do you
even have that kind of context information at the time of the exception?
> shading fails with "error in opening zip file" if createSourcesJar=true and
> an invalid sources jar file is encountered
> --
>
> Key: MSHADE-248
> URL: https://issues.apache.org/jira/browse/MSHADE-248
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.4.3
>Reporter: Ian Springer
>
> {code}
> Downloading:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
> Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> (2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
>
> BUILD FAILURE
>
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project
> jclouds-shaded: Error creating shaded jar: error in opening zip file
> /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar ->
> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't
> control the fact that they have an invalid sources jar published, the shade
> plugin should be more forgiving and just log a warning and skip the bsh
> sources jar when building the shaded sources jar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MSHADE-248) shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
[
https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858446#comment-15858446
]
Ian Springer commented on MSHADE-248:
-
Well, it turned out in this case, I am able to fix the root cause by deleting
the invalid artifact from my Nexus repo. But I am thinking if there was an
invalid sources jar on some public repo that I didn't control, it would be
frustrating if that prevented me from building a sources jar for my shaded jar.
I think it would be ideal if the shard plugin logged something like:
WARN: Error in opening sources jar for inclusion in shaded sources jar: invalid
zip file
/Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar.
org.beanshell.bsh:bsh sources will be omitted from the shaded sources jar. To
fix this issue, try deleting the file from your local repo. If the problem
persists, a corrupt artifact was probably published to a remote repo.
> shading fails with "error in opening zip file" if createSourcesJar=true and
> an invalid sources jar file is encountered
> --
>
> Key: MSHADE-248
> URL: https://issues.apache.org/jira/browse/MSHADE-248
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.4.3
>Reporter: Ian Springer
>
> {code}
> Downloading:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
> Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> (2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
>
> BUILD FAILURE
>
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project
> jclouds-shaded: Error creating shaded jar: error in opening zip file
> /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar ->
> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't
> control the fact that they have an invalid sources jar published, the shade
> plugin should be more forgiving and just log a warning and skip the bsh
> sources jar when building the shaded sources jar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (MSHADE-248) shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
[
https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858411#comment-15858411
]
Michael Osipov edited comment on MSHADE-248 at 2/8/17 7:23 PM:
---
bq. In any case, it sounds like you don't agree the shade plugin should be more
lenient. That's cool.
I didn't say that. I wanted to understand the root cause first. As you can see,
Maven already gives you a warning that there is something wrong with the JAR.
Basically, no plugin interacting with ZIP files does a content validation. It
is done here with {{java.util.jar.JarFile}}. During dep download it is assumed
that the ZIP file is validated against its checksum and in case of a problem
you'll see the warning. What would you expect to see? Skipping a ZIP isn't a
good way to go. Either all or nothing.
was (Author: michael-o):
bq. In any case, it sounds like you don't agree the shade plugin should be more
lenient. That's cool.
I didn't say that. I wanted to understand the root cause first. As you can see,
Maven already gives you a warning that there is something wrong with the JAR.
Basically, no plugin interacting with ZIP files does a content validation.
During dep download it is assumed that the ZIP file is validated against its
checksum and in case of a problem, you'll see the warning. What would you
expect to see?
> shading fails with "error in opening zip file" if createSourcesJar=true and
> an invalid sources jar file is encountered
> --
>
> Key: MSHADE-248
> URL: https://issues.apache.org/jira/browse/MSHADE-248
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.4.3
>Reporter: Ian Springer
>
> {code}
> Downloading:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
> Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> (2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
>
> BUILD FAILURE
>
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project
> jclouds-shaded: Error creating shaded jar: error in opening zip file
> /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar ->
> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't
> control the fact that they have an invalid sources jar published, the shade
> plugin should be more forgiving and just log a warning and skip the bsh
> sources jar when building the shaded sources jar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (MSHADE-248) shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
[
https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858411#comment-15858411
]
Michael Osipov edited comment on MSHADE-248 at 2/8/17 7:21 PM:
---
bq. In any case, it sounds like you don't agree the shade plugin should be more
lenient. That's cool.
I didn't say that. I wanted to understand the root cause first. As you can see,
Maven already gives you a warning that there is something wrong with the JAR.
Basically, no plugin interacting with ZIP files does a content validation.
During dep download it is assumed that the ZIP file is validated against its
checksum and in case of a problem, you'll see the warning. What would you
expect to see?
was (Author: michael-o):
bq. In any case, it sounds like you don't agree the shade plugin should be more
lenient. That's cool.
I didn't say that. I wanted to understand the root cause first. Can you rebuild
the project with a empty repo? It should give you a checksum warning. I'd like
to see this first.
> shading fails with "error in opening zip file" if createSourcesJar=true and
> an invalid sources jar file is encountered
> --
>
> Key: MSHADE-248
> URL: https://issues.apache.org/jira/browse/MSHADE-248
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.4.3
>Reporter: Ian Springer
>
> {code}
> Downloading:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
> Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> (2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
>
> BUILD FAILURE
>
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project
> jclouds-shaded: Error creating shaded jar: error in opening zip file
> /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar ->
> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't
> control the fact that they have an invalid sources jar published, the shade
> plugin should be more forgiving and just log a warning and skip the bsh
> sources jar when building the shaded sources jar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MSHADE-248) shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
[
https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858411#comment-15858411
]
Michael Osipov commented on MSHADE-248:
---
bq. In any case, it sounds like you don't agree the shade plugin should be more
lenient. That's cool.
I didn't say that. I wanted to understand the root cause first. Can you rebuild
the project with a empty repo? It should give you a checksum warning. I'd like
to see this first.
> shading fails with "error in opening zip file" if createSourcesJar=true and
> an invalid sources jar file is encountered
> --
>
> Key: MSHADE-248
> URL: https://issues.apache.org/jira/browse/MSHADE-248
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.4.3
>Reporter: Ian Springer
>
> {code}
> Downloading:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
> Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> (2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
>
> BUILD FAILURE
>
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project
> jclouds-shaded: Error creating shaded jar: error in opening zip file
> /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar ->
> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't
> control the fact that they have an invalid sources jar published, the shade
> plugin should be more forgiving and just log a warning and skip the bsh
> sources jar when building the shaded sources jar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MSHADE-248) shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
[
https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858406#comment-15858406
]
Ian Springer commented on MSHADE-248:
-
Our Nexus repo has been running for 5 years or so, so my guess is the jar did
exist on central or some other repo we proxy at some point in the past 5 years.
In any case, it sounds like you don't agree the shade plugin should be more
lenient. That's cool.
> shading fails with "error in opening zip file" if createSourcesJar=true and
> an invalid sources jar file is encountered
> --
>
> Key: MSHADE-248
> URL: https://issues.apache.org/jira/browse/MSHADE-248
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.4.3
>Reporter: Ian Springer
>
> {code}
> Downloading:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
> Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> (2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
>
> BUILD FAILURE
>
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project
> jclouds-shaded: Error creating shaded jar: error in opening zip file
> /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar ->
> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't
> control the fact that they have an invalid sources jar published, the shade
> plugin should be more forgiving and just log a warning and skip the bsh
> sources jar when building the shaded sources jar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Reopened] (ARCHETYPE-512) archetype:generate while merging the pom with existing pom does not copy the attributes on the elements
[ https://issues.apache.org/jira/browse/ARCHETYPE-512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte reopened ARCHETYPE-512: -- This issue shouldn't have been marked as resolved. > archetype:generate while merging the pom with existing pom does not copy the > attributes on the elements > > > Key: ARCHETYPE-512 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-512 > Project: Maven Archetype > Issue Type: Bug > Components: Generator >Affects Versions: 2.4 > Environment: Windows >Reporter: Chetana > Attachments: MNG-ARCHETYPE-512-archetype-common.patch > > Original Estimate: 5h > Remaining Estimate: 5h > > I am using partial=true and running the archetype on an existing project. The > template pom has plugins with attributes. On archetype:generate, the template > pom is getting merged with the existing pom however the attributes are missed > out -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (ARCHETYPE-512) archetype:generate while merging the pom with existing pom does not copy the attributes on the elements
[ https://issues.apache.org/jira/browse/ARCHETYPE-512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated ARCHETYPE-512: - Fix Version/s: (was: 3.0.0) > archetype:generate while merging the pom with existing pom does not copy the > attributes on the elements > > > Key: ARCHETYPE-512 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-512 > Project: Maven Archetype > Issue Type: Bug > Components: Generator >Affects Versions: 2.4 > Environment: Windows >Reporter: Chetana > Attachments: MNG-ARCHETYPE-512-archetype-common.patch > > Original Estimate: 5h > Remaining Estimate: 5h > > I am using partial=true and running the archetype on an existing project. The > template pom has plugins with attributes. On archetype:generate, the template > pom is getting merged with the existing pom however the attributes are missed > out -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (MSHADE-248) shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
[
https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858370#comment-15858370
]
Michael Osipov edited comment on MSHADE-248 at 2/8/17 6:43 PM:
---
Unlikely that Nexus would deliver such a content. Especially becasue this JAR
does not exist on Central.
was (Author: michael-o):
Unlikely that Nexus would deliver such a content. Espcially becasue this JAR
does not exist on Central.
> shading fails with "error in opening zip file" if createSourcesJar=true and
> an invalid sources jar file is encountered
> --
>
> Key: MSHADE-248
> URL: https://issues.apache.org/jira/browse/MSHADE-248
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.4.3
>Reporter: Ian Springer
>
> {code}
> Downloading:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
> Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> (2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
>
> BUILD FAILURE
>
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project
> jclouds-shaded: Error creating shaded jar: error in opening zip file
> /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar ->
> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't
> control the fact that they have an invalid sources jar published, the shade
> plugin should be more forgiving and just log a warning and skip the bsh
> sources jar when building the shaded sources jar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MSHADE-248) shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
[
https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858370#comment-15858370
]
Michael Osipov commented on MSHADE-248:
---
Unlikely that Nexus would deliver such a content. Espcially becasue this JAR
does not exist on Central.
> shading fails with "error in opening zip file" if createSourcesJar=true and
> an invalid sources jar file is encountered
> --
>
> Key: MSHADE-248
> URL: https://issues.apache.org/jira/browse/MSHADE-248
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.4.3
>Reporter: Ian Springer
>
> {code}
> Downloading:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
> Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> (2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
>
> BUILD FAILURE
>
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project
> jclouds-shaded: Error creating shaded jar: error in opening zip file
> /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar ->
> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't
> control the fact that they have an invalid sources jar published, the shade
> plugin should be more forgiving and just log a warning and skip the bsh
> sources jar when building the shaded sources jar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MSHADE-248) shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
[
https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858367#comment-15858367
]
Ian Springer commented on MSHADE-248:
-
What is extremely unlikely? I've been using Maven for like 12 years, and I have
seen the HTML thing a bunch of times in the past.
> shading fails with "error in opening zip file" if createSourcesJar=true and
> an invalid sources jar file is encountered
> --
>
> Key: MSHADE-248
> URL: https://issues.apache.org/jira/browse/MSHADE-248
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.4.3
>Reporter: Ian Springer
>
> {code}
> Downloading:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
> Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> (2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
>
> BUILD FAILURE
>
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project
> jclouds-shaded: Error creating shaded jar: error in opening zip file
> /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar ->
> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't
> control the fact that they have an invalid sources jar published, the shade
> plugin should be more forgiving and just log a warning and skip the bsh
> sources jar when building the shaded sources jar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MSHADE-248) shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
[
https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858308#comment-15858308
]
Michael Osipov commented on MSHADE-248:
---
Extremely unlikely. Your setup seems to be really broken. Nexus (Jetty) will
never deliver something for sedoparking.com. Inquire with your Nexus admin
first.
> shading fails with "error in opening zip file" if createSourcesJar=true and
> an invalid sources jar file is encountered
> --
>
> Key: MSHADE-248
> URL: https://issues.apache.org/jira/browse/MSHADE-248
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.4.3
>Reporter: Ian Springer
>
> {code}
> Downloading:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
> Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> (2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
>
> BUILD FAILURE
>
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project
> jclouds-shaded: Error creating shaded jar: error in opening zip file
> /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar ->
> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't
> control the fact that they have an invalid sources jar published, the shade
> plugin should be more forgiving and just log a warning and skip the bsh
> sources jar when building the shaded sources jar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (MSHADE-248) shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
[
https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858308#comment-15858308
]
Michael Osipov edited comment on MSHADE-248 at 2/8/17 5:52 PM:
---
Extremely unlikely. Your setup seems to be really broken. Nexus (Jetty) will
never deliver something for sedoparking.com. Inquire with your Nexus admin
first. Moreover, you can enable content validation on Nexus side for proxy
repositories.
was (Author: michael-o):
Extremely unlikely. Your setup seems to be really broken. Nexus (Jetty) will
never deliver something for sedoparking.com. Inquire with your Nexus admin
first.
> shading fails with "error in opening zip file" if createSourcesJar=true and
> an invalid sources jar file is encountered
> --
>
> Key: MSHADE-248
> URL: https://issues.apache.org/jira/browse/MSHADE-248
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 2.4.3
>Reporter: Ian Springer
>
> {code}
> Downloading:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
> Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> (2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
>
> BUILD FAILURE
>
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project
> jclouds-shaded: Error creating shaded jar: error in opening zip file
> /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar ->
> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't
> control the fact that they have an invalid sources jar published, the shade
> plugin should be more forgiving and just log a warning and skip the bsh
> sources jar when building the shaded sources jar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MSHADE-248) shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
[
https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858270#comment-15858270
]
Ian Springer commented on MSHADE-248:
-
Here is the content of bsh-2.0b4-sources.jar:
{code}
html, body, #partner, iframe {
height:100%;
width:100%;
margin:0;
padding:0;
border:0;
outline:0;
font-size:100%;
vertical-align:baseline;
background:transparent;
}
body {
overflow:hidden;
}
document.write(
'