[GitHub] maven-surefire issue #163: Surefire-report

2018-01-07 Thread Tibor17
Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/163
  
@shafiullas 
Thx for contributing. The PR was modified and pushed to master. Please 
close this PR.


---


[jira] [Closed] (SUREFIRE-1183) Custom Test Report Titles and Descriptions

2018-01-07 Thread Tibor Digana (JIRA)

 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana closed SUREFIRE-1183.
--
Resolution: Fixed

https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=7a33fd67b066908ef4aad6eb044c40eb4fe29482

> Custom Test Report Titles and Descriptions
> --
>
> Key: SUREFIRE-1183
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1183
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Report Plugin
>Affects Versions: 2.18.1
>Reporter: Gerald Mücke
>Assignee: Tibor Digana
>Priority: Minor
> Fix For: 2.21.0.Jigsaw
>
>  Time Spent: 16h
>  Remaining Estimate: 0h
>
> Hi,
> I'd like to add the possibility to customize the name and descriptions of the 
> test reports, in order to define report sets with not only custom outputNames 
> but custom titles and descriptions as well so that they appear in the report 
> with a self-describing name and description.
> Motivation:
> At a customer project we have several automated tests (unit tests, 
> integration tests, automated acceptance tests, performance tests) and each of 
> those are run either using surefire or failsafe. 
> We have different report sets for each of these tests and separate output 
> files. But in the Project Reports Overview each Report is named either 
> "Surefire Report" or "Failsafe Report" with the corresponding default 
> description. Further, the title of the Report page itself is always "Surefire 
> Reports"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (MCHECKSTYLE-346) Release a new version

2018-01-07 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MCHECKSTYLE-346.
--
Resolution: Done
  Assignee: Robert Scholte

Version 3.0.0 has been released

> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Assignee: Robert Scholte
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed 
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this 
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for 
> fixes and functionality needed. As it is now, we cannot remove old deprecated 
> code from our utility as the plugin relies on them too much and breaks if 
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to 
> update the code base. Why is this? Is there something that prevents you from 
> creating a new release? Do you lack personnel of some kind? Is it possible to 
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking 
> compatibility with the plugin in newer versions as this project seems to have 
> run stagnant and is lacking support. If compatibility is broken, the current 
> plugin released will then only work with old and outdated versions. I, and I 
> am sure the community, don't wish to see this happen but the checkstyle 
> utility needs to keep evolving and remove outdated code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (MCHECKSTYLE-322) Update plugin to use 6.18 checkstyle (last version that is based on jdk7)

2018-01-07 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MCHECKSTYLE-322:
---
Summary: Update plugin to use 6.18 checkstyle (last version that is based 
on jdk7)  (was: Update plugin to use 6.19 checkstyle (last version that is 
based on jdk7))

> Update plugin to use 6.18 checkstyle (last version that is based on jdk7)
> -
>
> Key: MCHECKSTYLE-322
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-322
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Reporter: Roman Ivanov
>Assignee: Guillaume Boué
> Fix For: 3.0.0
>
>
> Update plugin to use 6.19 checkstyle (last version that is based on jdk7).
> http://checkstyle.sourceforge.net/releasenotes.html#Release_6.19
> Java8 based version is 7.0:
> http://checkstyle.sourceforge.net/releasenotes.html#Release_7.0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MPLUGIN-331) Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()

2018-01-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MPLUGIN-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315452#comment-16315452
 ] 

ASF GitHub Bot commented on MPLUGIN-331:


rfscholte commented on a change in pull request #10: [MPLUGIN-331] Let 
plugin:report support takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#discussion_r160058763
 
 

 ##
 File path: 
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java
 ##
 @@ -197,9 +197,18 @@
 @Component
 private RuntimeInformation rtInfo;
 
+/**
+ * Path to {@code plugin.xml} plugin descriptor to generate the report 
from.
+ *
+ * @since 3.5.1
+ */
+@Parameter( defaultValue = 
"${project.build.outputDirectory}/META-INF/maven/plugin.xml", required = true )
 
 Review comment:
   The claim of breaking things is a bit too hard, but making it variable 
assumes that is configurable in real world. It will also appear on reports like 
the goal page, the help goal, etc.
   Let's not confuse people or show parameters which will only distract them.
   What is the issue of *not* making it readOnly?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Check the existence of plugin.xml rather than project packaging in 
> PluginReport.canGenerateReport()
> ---
>
> Key: MPLUGIN-331
> URL: https://issues.apache.org/jira/browse/MPLUGIN-331
> Project: Maven Plugin Tools
>  Issue Type: Task
>  Components: Plugin Plugin
>Reporter: Peter Palaga
>Assignee: Hervé Boutemy
> Fix For: 3.5.1
>
>
> {{org.apache.maven.plugin.plugin.PluginReport.canGenerateReport()}} currently 
> reads
> {code}
> return "maven-plugin".equals( project.getPackaging() );
> {code}
> I propose to change it to 
> {code}
> return "maven-plugin".equals( project.getPackaging() )
> || "takari-maven-plugin".equals( project.getPackaging() );
> {code}
> so that also takari-maven-plugins are supported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] rfscholte commented on a change in pull request #10: [MPLUGIN-331] Let plugin:report support takari-maven-plugin packaging

2018-01-07 Thread GitBox
rfscholte commented on a change in pull request #10: [MPLUGIN-331] Let 
plugin:report support takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#discussion_r160058763
 
 

 ##
 File path: 
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java
 ##
 @@ -197,9 +197,18 @@
 @Component
 private RuntimeInformation rtInfo;
 
+/**
+ * Path to {@code plugin.xml} plugin descriptor to generate the report 
from.
+ *
+ * @since 3.5.1
+ */
+@Parameter( defaultValue = 
"${project.build.outputDirectory}/META-INF/maven/plugin.xml", required = true )
 
 Review comment:
   The claim of breaking things is a bit too hard, but making it variable 
assumes that is configurable in real world. It will also appear on reports like 
the goal page, the help goal, etc.
   Let's not confuse people or show parameters which will only distract them.
   What is the issue of *not* making it readOnly?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MPLUGIN-331) Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()

2018-01-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MPLUGIN-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315445#comment-16315445
 ] 

ASF GitHub Bot commented on MPLUGIN-331:


ppalaga commented on a change in pull request #10: [MPLUGIN-331] Let 
plugin:report support takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#discussion_r160058324
 
 

 ##
 File path: 
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java
 ##
 @@ -197,9 +197,18 @@
 @Component
 private RuntimeInformation rtInfo;
 
+/**
+ * Path to {@code plugin.xml} plugin descriptor to generate the report 
from.
+ *
+ * @since 3.5.1
+ */
+@Parameter( defaultValue = 
"${project.build.outputDirectory}/META-INF/maven/plugin.xml", required = true )
 
 Review comment:
   Thanks for the explanation, @rfscholte . But 
https://maven.apache.org/ref/3.5.2/maven-plugin-api/ seems to define the the 
location of the `plugin.xml` within the `jar` rather than its location in the 
source tree. This `pluginXmlFile` indeed is a location in the source tree and 
this `PluginReport` is a report mojo that will not impact the location of 
`plugin.xml` in the jar in any way. That said, I cannot see how a writable 
`pluginXmlFile` can violate the maven-plugin-api.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Check the existence of plugin.xml rather than project packaging in 
> PluginReport.canGenerateReport()
> ---
>
> Key: MPLUGIN-331
> URL: https://issues.apache.org/jira/browse/MPLUGIN-331
> Project: Maven Plugin Tools
>  Issue Type: Task
>  Components: Plugin Plugin
>Reporter: Peter Palaga
>Assignee: Hervé Boutemy
> Fix For: 3.5.1
>
>
> {{org.apache.maven.plugin.plugin.PluginReport.canGenerateReport()}} currently 
> reads
> {code}
> return "maven-plugin".equals( project.getPackaging() );
> {code}
> I propose to change it to 
> {code}
> return "maven-plugin".equals( project.getPackaging() )
> || "takari-maven-plugin".equals( project.getPackaging() );
> {code}
> so that also takari-maven-plugins are supported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] ppalaga commented on a change in pull request #10: [MPLUGIN-331] Let plugin:report support takari-maven-plugin packaging

2018-01-07 Thread GitBox
ppalaga commented on a change in pull request #10: [MPLUGIN-331] Let 
plugin:report support takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#discussion_r160058324
 
 

 ##
 File path: 
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java
 ##
 @@ -197,9 +197,18 @@
 @Component
 private RuntimeInformation rtInfo;
 
+/**
+ * Path to {@code plugin.xml} plugin descriptor to generate the report 
from.
+ *
+ * @since 3.5.1
+ */
+@Parameter( defaultValue = 
"${project.build.outputDirectory}/META-INF/maven/plugin.xml", required = true )
 
 Review comment:
   Thanks for the explanation, @rfscholte . But 
https://maven.apache.org/ref/3.5.2/maven-plugin-api/ seems to define the the 
location of the `plugin.xml` within the `jar` rather than its location in the 
source tree. This `pluginXmlFile` indeed is a location in the source tree and 
this `PluginReport` is a report mojo that will not impact the location of 
`plugin.xml` in the jar in any way. That said, I cannot see how a writable 
`pluginXmlFile` can violate the maven-plugin-api.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Comment Edited] (MENFORCER-283) Java 9 banDuplicateClasses incorrectly sees module-info.class as duplicate

2018-01-07 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/MENFORCER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315376#comment-16315376
 ] 

Karl Heinz Marbaise edited comment on MENFORCER-283 at 1/7/18 7:22 PM:
---

This issue is related to 
[extra-enforcer-rules|https://github.com/mojohaus/extra-enforcer-rules/issues]
Opened an appropriate 
[issue|https://github.com/mojohaus/extra-enforcer-rules/issues/42]


was (Author: khmarbaise):
This issue is related to 
[extra-enforcer-rules|https://github.com/mojohaus/extra-enforcer-rules/issues]

> Java 9 banDuplicateClasses incorrectly sees module-info.class as duplicate
> --
>
> Key: MENFORCER-283
> URL: https://issues.apache.org/jira/browse/MENFORCER-283
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 1.4.1
>Reporter: Sven Haster
>Priority: Minor
> Fix For: 3.0.0
>
>
> When running the enforcer plugin with banDuplicateClasses rule against a 
> project with dependencies on java-9 compatible libraries which include a 
> module-info.class file, the plugin sees the multiple module-info files as 
> duplicate classes. 
> It should simply ignore these similar to package-info.
> In our projects, it is the dependencies on multiple libs from org.ow2.asm 
> which provides the module-info class, rendering the following output:
> {noformat}
> [WARNING] Rule 2: org.apache.maven.plugins.enforcer.BanDuplicateClasses 
> failed with message:
> Duplicate classes found:
>   Found in:
> org.ow2.asm:asm-tree:jar:6.0:compile
> org.ow2.asm:asm:jar:6.0:compile
> org.ow2.asm:asm-util:jar:6.0:compile
>   Duplicate classes:
> module-info.class
> {noformat}
> We can easily work around this problem for now by adding a global rule to 
> ignore module-info such as the following but it would be nice if the enforces 
> plugin ignored this file by default.
> {code:xml}
> 
>   
>   module-info
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] maven-surefire issue #163: Surefire-report

2018-01-07 Thread Tibor17
Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/163
  
@shafiullas 
I have fixed the checkstyle in your code but I do not see text of 
Description in HTML. Did you try to use it in real and saw the Description on 
the page?


---


[jira] [Commented] (MPLUGIN-331) Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()

2018-01-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MPLUGIN-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315403#comment-16315403
 ] 

ASF GitHub Bot commented on MPLUGIN-331:


rfscholte commented on a change in pull request #10: [MPLUGIN-331] Let 
plugin:report support takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#discussion_r160055432
 
 

 ##
 File path: 
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java
 ##
 @@ -197,9 +197,18 @@
 @Component
 private RuntimeInformation rtInfo;
 
+/**
+ * Path to {@code plugin.xml} plugin descriptor to generate the report 
from.
+ *
+ * @since 3.5.1
+ */
+@Parameter( defaultValue = 
"${project.build.outputDirectory}/META-INF/maven/plugin.xml", required = true )
 
 Review comment:
   https://maven.apache.org/ref/3.5.2/maven-plugin-api/ says that the 
`plugin.xml` is alwys expected at this location. So it should be considered a 
contant, not a variable, hence why I would like to see it as readOnly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Check the existence of plugin.xml rather than project packaging in 
> PluginReport.canGenerateReport()
> ---
>
> Key: MPLUGIN-331
> URL: https://issues.apache.org/jira/browse/MPLUGIN-331
> Project: Maven Plugin Tools
>  Issue Type: Task
>  Components: Plugin Plugin
>Reporter: Peter Palaga
>Assignee: Hervé Boutemy
> Fix For: 3.5.1
>
>
> {{org.apache.maven.plugin.plugin.PluginReport.canGenerateReport()}} currently 
> reads
> {code}
> return "maven-plugin".equals( project.getPackaging() );
> {code}
> I propose to change it to 
> {code}
> return "maven-plugin".equals( project.getPackaging() )
> || "takari-maven-plugin".equals( project.getPackaging() );
> {code}
> so that also takari-maven-plugins are supported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] rfscholte commented on a change in pull request #10: [MPLUGIN-331] Let plugin:report support takari-maven-plugin packaging

2018-01-07 Thread GitBox
rfscholte commented on a change in pull request #10: [MPLUGIN-331] Let 
plugin:report support takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#discussion_r160055432
 
 

 ##
 File path: 
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java
 ##
 @@ -197,9 +197,18 @@
 @Component
 private RuntimeInformation rtInfo;
 
+/**
+ * Path to {@code plugin.xml} plugin descriptor to generate the report 
from.
+ *
+ * @since 3.5.1
+ */
+@Parameter( defaultValue = 
"${project.build.outputDirectory}/META-INF/maven/plugin.xml", required = true )
 
 Review comment:
   https://maven.apache.org/ref/3.5.2/maven-plugin-api/ says that the 
`plugin.xml` is alwys expected at this location. So it should be considered a 
contant, not a variable, hence why I would like to see it as readOnly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MENFORCER-283) Java 9 banDuplicateClasses incorrectly sees module-info.class as duplicate

2018-01-07 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/MENFORCER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315376#comment-16315376
 ] 

Karl Heinz Marbaise commented on MENFORCER-283:
---

This issue is related to 
[extra-enforcer-rules|https://github.com/mojohaus/extra-enforcer-rules/issues]

> Java 9 banDuplicateClasses incorrectly sees module-info.class as duplicate
> --
>
> Key: MENFORCER-283
> URL: https://issues.apache.org/jira/browse/MENFORCER-283
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 1.4.1
>Reporter: Sven Haster
>Priority: Minor
> Fix For: 3.0.0
>
>
> When running the enforcer plugin with banDuplicateClasses rule against a 
> project with dependencies on java-9 compatible libraries which include a 
> module-info.class file, the plugin sees the multiple module-info files as 
> duplicate classes. 
> It should simply ignore these similar to package-info.
> In our projects, it is the dependencies on multiple libs from org.ow2.asm 
> which provides the module-info class, rendering the following output:
> {noformat}
> [WARNING] Rule 2: org.apache.maven.plugins.enforcer.BanDuplicateClasses 
> failed with message:
> Duplicate classes found:
>   Found in:
> org.ow2.asm:asm-tree:jar:6.0:compile
> org.ow2.asm:asm:jar:6.0:compile
> org.ow2.asm:asm-util:jar:6.0:compile
>   Duplicate classes:
> module-info.class
> {noformat}
> We can easily work around this problem for now by adding a global rule to 
> ignore module-info such as the following but it would be nice if the enforces 
> plugin ignored this file by default.
> {code:xml}
> 
>   
>   module-info
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MJAVADOC-509) additionalParam are overridden when used in maven release plugin ?

2018-01-07 Thread Pascal Schumacher (JIRA)

[ 
https://issues.apache.org/jira/browse/MJAVADOC-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315359#comment-16315359
 ] 

Pascal Schumacher commented on MJAVADOC-509:


[~jocosti] I could replicated this error with maven javadoc plugin version 
3.0.0 and jdk 1.8.0_152 and 9.0.1. "mvn javadoc:javadoc" of the AssertJ failed 
every time.

I was able to solve this be replacing "additinonalParam" with 
"additionalOptions".

It looks like "additionalParam" was removed in version 3.0.0.

I guess this defect can be closed.



> additionalParam are overridden when used in maven release plugin ?
> --
>
> Key: MJAVADOC-509
> URL: https://issues.apache.org/jira/browse/MJAVADOC-509
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 3.0.0-M1
> Environment: Linux ubuntu 16.04
> Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 
> 2017-10-18T20:58:13+13:00)
> Maven home: /home/joel/prog/apache-maven-3.5.2
> Java version: 1.8.0_144, vendor: Oracle Corporation
> Java home: /home/joel/prog/java/jdk1.8.0_144/jre
> Default locale: en_NZ, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-104-generic", arch: "amd64", family: "unix"
>Reporter: Joel Costigliola
>
> I believe https://issues.apache.org/jira/browse/MJAVADOC-387 introduced a 
> regression as it overrides any value set in {{additionalparam}} which only 
> manifests when using the maven release plugin 
> My open source project 
> ([AssertJ|http://joel-costigliola.github.io/assertj/index.html]) adds 
> javascript to the javadoc footer I thus need to add this parameter to be able 
> to generate the javadoc:
> {{--allow-script-in-comments}}
> The {{mvn release:perform}} command failed with this error:
> {noformat}
> [INFO] Exit code: 1 - javadoc: error - Argument for -footer contains 
> JavaScript.
> [INFO] Use --allow-script-in-comments to allow use of JavaScript.
> {noformat}
> the debug log shows that the {{--allow-script-in-comments}} parameter I set 
> was not honored:
> {noformat}
> [INFO] [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-javadoc-plugin:3.0.0-M1:jar' with basic 
> configurator -->
> [INFO] [DEBUG]   (f) additionalparam = -Xdoclint:none
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MPLUGIN-331) Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()

2018-01-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MPLUGIN-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315347#comment-16315347
 ] 

ASF GitHub Bot commented on MPLUGIN-331:


ppalaga commented on issue #10: [MPLUGIN-331] Let plugin:report support 
takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#issuecomment-355831723
 
 
   > Changing its value will break things.
   
   Which things will it break?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Check the existence of plugin.xml rather than project packaging in 
> PluginReport.canGenerateReport()
> ---
>
> Key: MPLUGIN-331
> URL: https://issues.apache.org/jira/browse/MPLUGIN-331
> Project: Maven Plugin Tools
>  Issue Type: Task
>  Components: Plugin Plugin
>Reporter: Peter Palaga
>Assignee: Hervé Boutemy
> Fix For: 3.5.1
>
>
> {{org.apache.maven.plugin.plugin.PluginReport.canGenerateReport()}} currently 
> reads
> {code}
> return "maven-plugin".equals( project.getPackaging() );
> {code}
> I propose to change it to 
> {code}
> return "maven-plugin".equals( project.getPackaging() )
> || "takari-maven-plugin".equals( project.getPackaging() );
> {code}
> so that also takari-maven-plugins are supported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MPLUGIN-331) Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()

2018-01-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MPLUGIN-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315350#comment-16315350
 ] 

ASF GitHub Bot commented on MPLUGIN-331:


ppalaga commented on a change in pull request #10: [MPLUGIN-331] Let 
plugin:report support takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#discussion_r160052969
 
 

 ##
 File path: 
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java
 ##
 @@ -197,9 +197,18 @@
 @Component
 private RuntimeInformation rtInfo;
 
+/**
+ * Path to {@code plugin.xml} plugin descriptor to generate the report 
from.
+ *
+ * @since 3.5.1
+ */
+@Parameter( defaultValue = 
"${project.build.outputDirectory}/META-INF/maven/plugin.xml", required = true )
 
 Review comment:
   Which things will it break?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Check the existence of plugin.xml rather than project packaging in 
> PluginReport.canGenerateReport()
> ---
>
> Key: MPLUGIN-331
> URL: https://issues.apache.org/jira/browse/MPLUGIN-331
> Project: Maven Plugin Tools
>  Issue Type: Task
>  Components: Plugin Plugin
>Reporter: Peter Palaga
>Assignee: Hervé Boutemy
> Fix For: 3.5.1
>
>
> {{org.apache.maven.plugin.plugin.PluginReport.canGenerateReport()}} currently 
> reads
> {code}
> return "maven-plugin".equals( project.getPackaging() );
> {code}
> I propose to change it to 
> {code}
> return "maven-plugin".equals( project.getPackaging() )
> || "takari-maven-plugin".equals( project.getPackaging() );
> {code}
> so that also takari-maven-plugins are supported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MPLUGIN-331) Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()

2018-01-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MPLUGIN-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315348#comment-16315348
 ] 

ASF GitHub Bot commented on MPLUGIN-331:


ppalaga commented on issue #10: [MPLUGIN-331] Let plugin:report support 
takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#issuecomment-355831723
 
 
   > Changing its value will break things.
   
   Which things will it break?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Check the existence of plugin.xml rather than project packaging in 
> PluginReport.canGenerateReport()
> ---
>
> Key: MPLUGIN-331
> URL: https://issues.apache.org/jira/browse/MPLUGIN-331
> Project: Maven Plugin Tools
>  Issue Type: Task
>  Components: Plugin Plugin
>Reporter: Peter Palaga
>Assignee: Hervé Boutemy
> Fix For: 3.5.1
>
>
> {{org.apache.maven.plugin.plugin.PluginReport.canGenerateReport()}} currently 
> reads
> {code}
> return "maven-plugin".equals( project.getPackaging() );
> {code}
> I propose to change it to 
> {code}
> return "maven-plugin".equals( project.getPackaging() )
> || "takari-maven-plugin".equals( project.getPackaging() );
> {code}
> so that also takari-maven-plugins are supported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] ppalaga commented on issue #10: [MPLUGIN-331] Let plugin:report support takari-maven-plugin packaging

2018-01-07 Thread GitBox
ppalaga commented on issue #10: [MPLUGIN-331] Let plugin:report support 
takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#issuecomment-355831723
 
 
   > Changing its value will break things.
   
   Which things will it break?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ppalaga commented on issue #10: [MPLUGIN-331] Let plugin:report support takari-maven-plugin packaging

2018-01-07 Thread GitBox
ppalaga commented on issue #10: [MPLUGIN-331] Let plugin:report support 
takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#issuecomment-355831723
 
 
   > Changing its value will break things.
   
   Which things will it break?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ppalaga commented on a change in pull request #10: [MPLUGIN-331] Let plugin:report support takari-maven-plugin packaging

2018-01-07 Thread GitBox
ppalaga commented on a change in pull request #10: [MPLUGIN-331] Let 
plugin:report support takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#discussion_r160052969
 
 

 ##
 File path: 
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java
 ##
 @@ -197,9 +197,18 @@
 @Component
 private RuntimeInformation rtInfo;
 
+/**
+ * Path to {@code plugin.xml} plugin descriptor to generate the report 
from.
+ *
+ * @since 3.5.1
+ */
+@Parameter( defaultValue = 
"${project.build.outputDirectory}/META-INF/maven/plugin.xml", required = true )
 
 Review comment:
   Which things will it break?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (MENFORCER-293) Remove deprecated marked ignoreParent from BanDistributionManagement

2018-01-07 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created MENFORCER-293:
-

 Summary: Remove deprecated marked ignoreParent from 
BanDistributionManagement
 Key: MENFORCER-293
 URL: https://issues.apache.org/jira/browse/MENFORCER-293
 Project: Maven Enforcer Plugin
  Issue Type: Improvement
  Components: Standard Rules
Affects Versions: 3.0.0-M1
Reporter: Karl Heinz Marbaise
Assignee: Karl Heinz Marbaise
Priority: Minor
 Fix For: 3.0.0


Remove the deprecated marked {{ignoreParent}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (MENFORCER-292) Remove getModelsRecursively from EnforcerRuleUtils

2018-01-07 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/MENFORCER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MENFORCER-292.
-
Resolution: Implemented
  Assignee: Karl Heinz Marbaise

Implemented by MENFORCER-281

> Remove getModelsRecursively from EnforcerRuleUtils
> --
>
> Key: MENFORCER-292
> URL: https://issues.apache.org/jira/browse/MENFORCER-292
> Project: Maven Enforcer Plugin
>  Issue Type: Improvement
>Affects Versions: 3.0.0-M1
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 3.0.0
>
>
> Remove the {{EnforcerRuleUtils.getModelsRecursively()}} cause it implements 
> reading of the model manually.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MENFORCER-281) RequirePluginVersions broken with "CI Friendly versions"

2018-01-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MENFORCER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315339#comment-16315339
 ] 

ASF GitHub Bot commented on MENFORCER-281:
--

khmarbaise commented on issue #28: [MENFORCER-281] added IT to show the issue.
URL: https://github.com/apache/maven-enforcer/pull/28#issuecomment-355830138
 
 
   Integrated. You can close the PR..


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> RequirePluginVersions broken with "CI Friendly versions"
> 
>
> Key: MENFORCER-281
> URL: https://issues.apache.org/jira/browse/MENFORCER-281
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: Standard Rules
>Affects Versions: 1.4.1, 3.0.0-M1
>Reporter: James Nord
>Assignee: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 3.0.0
>
>
> Maven 
> [3.5.0|https://maven.apache.org/docs/3.5.0/release-notes.html#Overview_about_the_changes]
>  [introduced CI friendly 
> versions|https://maven.apache.org/maven-ci-friendly.html].
> However when used with [multi module 
> project|https://maven.apache.org/maven-ci-friendly.html#Multi_Module_Setup] 
> the enforcer fails the build as it can not resolve the parent.
> The bug is that the parent resolution of a module in the reactor is 
> attempting to use the untransposed version.
> e.g.
> {noformat}
> INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ sub-module 
> ---
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequirePluginVersions 
> failed with message:
> Failure to find com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT in 
> https://repo.acme.com/content/groups/all was cached in the local repository, 
> resolution will not be reattempted until the update interval of acme-internal 
> has elapsed or updates are forced
>   com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT
> from the specified remote repositories:
>   acme-internal (https://repo.acme.com/content/groups/all, releases=true, 
> snapshots=true)
> {noformat}
> to reproduce create a new multi module project as per the linked page above.  
> Add the enforcer plugin and rule to the build
> run {{mvn -Drevision=1.2.3-SNAPSHOT}}  and watch the build fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] khmarbaise commented on issue #28: [MENFORCER-281] added IT to show the issue.

2018-01-07 Thread GitBox
khmarbaise commented on issue #28: [MENFORCER-281] added IT to show the issue.
URL: https://github.com/apache/maven-enforcer/pull/28#issuecomment-355830138
 
 
   Integrated. You can close the PR..


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Closed] (MENFORCER-281) RequirePluginVersions broken with "CI Friendly versions"

2018-01-07 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/MENFORCER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MENFORCER-281.
-
Resolution: Fixed

got the pull request of James Nord here 
[5311c5742da760e2910eda39698c62f7cfb3e46e|https://gitbox.apache.org/repos/asf?p=maven-enforcer.git;a=commitdiff;h=5311c5742da760e2910eda39698c62f7cfb3e46e]
Implementation and fixed here: 
[ad0a84368f97a335a9455f04ec04bfbbb10ac49e|https://gitbox.apache.org/repos/asf?p=maven-enforcer.git;a=commitdiff;h=ad0a84368f97a335a9455f04ec04bfbbb10ac49e]

Thanks for your support James.


> RequirePluginVersions broken with "CI Friendly versions"
> 
>
> Key: MENFORCER-281
> URL: https://issues.apache.org/jira/browse/MENFORCER-281
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: Standard Rules
>Affects Versions: 1.4.1, 3.0.0-M1
>Reporter: James Nord
>Assignee: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 3.0.0
>
>
> Maven 
> [3.5.0|https://maven.apache.org/docs/3.5.0/release-notes.html#Overview_about_the_changes]
>  [introduced CI friendly 
> versions|https://maven.apache.org/maven-ci-friendly.html].
> However when used with [multi module 
> project|https://maven.apache.org/maven-ci-friendly.html#Multi_Module_Setup] 
> the enforcer fails the build as it can not resolve the parent.
> The bug is that the parent resolution of a module in the reactor is 
> attempting to use the untransposed version.
> e.g.
> {noformat}
> INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ sub-module 
> ---
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequirePluginVersions 
> failed with message:
> Failure to find com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT in 
> https://repo.acme.com/content/groups/all was cached in the local repository, 
> resolution will not be reattempted until the update interval of acme-internal 
> has elapsed or updates are forced
>   com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT
> from the specified remote repositories:
>   acme-internal (https://repo.acme.com/content/groups/all, releases=true, 
> snapshots=true)
> {noformat}
> to reproduce create a new multi module project as per the linked page above.  
> Add the enforcer plugin and rule to the build
> run {{mvn -Drevision=1.2.3-SNAPSHOT}}  and watch the build fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MRESOLVER-7) Download dependency POMs in parallel

2018-01-07 Thread Sylwester Lachiewicz (JIRA)

[ 
https://issues.apache.org/jira/browse/MRESOLVER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315332#comment-16315332
 ] 

Sylwester Lachiewicz commented on MRESOLVER-7:
--

rebased Herald's version splitted to 2 changes
https://github.com/apache/maven-resolver/pull/10 main change
https://github.com/apache/maven-resolver/pull/12 move to subpackage

> Download dependency POMs in parallel
> 
>
> Key: MRESOLVER-7
> URL: https://issues.apache.org/jira/browse/MRESOLVER-7
> Project: Maven Resolver
>  Issue Type: Improvement
>Affects Versions: Aether 1.0.2
>Reporter: Harald Wellmann
>
> h3. Background
> When building a project with dependencies not yet available in the local 
> repository, I noticed that Maven 3.3.9/Aether 1.0.2 first downloads the 
> dependency POMs _sequentially_ and then proceeds downloading the dependency 
> JARs with up to 5 threads _in parallel_.
> Due to this, when first building a project with a large number of 
> dependencies, downloading a large number of small POMs may take a lot longer 
> than downloading the much larger JARs, or even longer than building the 
> project itself, especially when a repository manager is used which increases 
> the download latency.
> h3. Enhancement
> Download POMs of (transitive) dependencies in parallel to significantly speed 
> up initial builds of large projects.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (MSCMPUB-35) add support for symbolic links

2018-01-07 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/MSCMPUB-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy reassigned MSCMPUB-35:


Assignee: Hervé Boutemy

> add support for symbolic links
> --
>
> Key: MSCMPUB-35
> URL: https://issues.apache.org/jira/browse/MSCMPUB-35
> Project: Maven SCM Publish Plugin
>  Issue Type: Improvement
>Affects Versions: 1.1
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
> Fix For: 1.2
>
>
> Maven site uses symbolic links to link from main site to components
> If we want to publish the site without CMS (https://cms.apache.org/), we'll 
> need to have a Jenkins job to publish generated html to 
> https://svn.apache.org/repos/infra/websites/production/maven/content/
> then we'll need symbolic link support, which currently is failing
> {noformat}[ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-scm-publish-plugin:1.2-SNAPSHOT:publish-scm 
> (default-cli) on project maven-scm-publish-plugin-002-publish-scm: Could not 
> copy content to SCM checkout: Source 
> '/home/herve/projets/maven/git/plugins/maven-scm-publish-plugin/target/it/002-publish-scm/target/site/link'
>  does not exist -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal 
> org.apache.maven.plugins:maven-scm-publish-plugin:1.2-SNAPSHOT:publish-scm 
> (default-cli) on project maven-scm-publish-plugin-002-publish-scm: Could not 
> copy content to SCM checkout
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:213)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:146)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:51)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:606)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Could not copy 
> content to SCM checkout
> at 
> org.apache.maven.plugins.scmpublish.ScmPublishPublishScmMojo.scmPublishExecute
>  (ScmPublishPublishScmMojo.java:262)
> at org.apache.maven.plugins.scmpublish.AbstractScmPublishMojo.execute 
> (AbstractScmPublishMojo.java:579)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:146)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:51)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
> at org.apach

[jira] [Updated] (MSCMPUB-35) add support for symbolic links

2018-01-07 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/MSCMPUB-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MSCMPUB-35:
-
Fix Version/s: 1.2

> add support for symbolic links
> --
>
> Key: MSCMPUB-35
> URL: https://issues.apache.org/jira/browse/MSCMPUB-35
> Project: Maven SCM Publish Plugin
>  Issue Type: Improvement
>Affects Versions: 1.1
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
> Fix For: 1.2
>
>
> Maven site uses symbolic links to link from main site to components
> If we want to publish the site without CMS (https://cms.apache.org/), we'll 
> need to have a Jenkins job to publish generated html to 
> https://svn.apache.org/repos/infra/websites/production/maven/content/
> then we'll need symbolic link support, which currently is failing
> {noformat}[ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-scm-publish-plugin:1.2-SNAPSHOT:publish-scm 
> (default-cli) on project maven-scm-publish-plugin-002-publish-scm: Could not 
> copy content to SCM checkout: Source 
> '/home/herve/projets/maven/git/plugins/maven-scm-publish-plugin/target/it/002-publish-scm/target/site/link'
>  does not exist -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal 
> org.apache.maven.plugins:maven-scm-publish-plugin:1.2-SNAPSHOT:publish-scm 
> (default-cli) on project maven-scm-publish-plugin-002-publish-scm: Could not 
> copy content to SCM checkout
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:213)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:146)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:51)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:606)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Could not copy 
> content to SCM checkout
> at 
> org.apache.maven.plugins.scmpublish.ScmPublishPublishScmMojo.scmPublishExecute
>  (ScmPublishPublishScmMojo.java:262)
> at org.apache.maven.plugins.scmpublish.AbstractScmPublishMojo.execute 
> (AbstractScmPublishMojo.java:579)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:146)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:51)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
> at org.apache.maven.cli.

[jira] [Closed] (MSCMPUB-35) add support for symbolic links

2018-01-07 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/MSCMPUB-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy closed MSCMPUB-35.

Resolution: Fixed

done 
https://gitbox.apache.org/repos/asf?p=maven-scm-publish-plugin.git&a=commit&h=f8b468867ca6e5e46778a7f72286a5756124db04

notice that this fixes symbolic links support when publishing mono-module sites 
that avoid site staging: but for multi-modules sites that absolutely require 
staging or not-optimized mono-module sites that used intermediary staging, it's 
the site staging that will blow up before scm-publish is in action: MSITE-807 
created

> add support for symbolic links
> --
>
> Key: MSCMPUB-35
> URL: https://issues.apache.org/jira/browse/MSCMPUB-35
> Project: Maven SCM Publish Plugin
>  Issue Type: Improvement
>Affects Versions: 1.1
>Reporter: Hervé Boutemy
>
> Maven site uses symbolic links to link from main site to components
> If we want to publish the site without CMS (https://cms.apache.org/), we'll 
> need to have a Jenkins job to publish generated html to 
> https://svn.apache.org/repos/infra/websites/production/maven/content/
> then we'll need symbolic link support, which currently is failing
> {noformat}[ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-scm-publish-plugin:1.2-SNAPSHOT:publish-scm 
> (default-cli) on project maven-scm-publish-plugin-002-publish-scm: Could not 
> copy content to SCM checkout: Source 
> '/home/herve/projets/maven/git/plugins/maven-scm-publish-plugin/target/it/002-publish-scm/target/site/link'
>  does not exist -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal 
> org.apache.maven.plugins:maven-scm-publish-plugin:1.2-SNAPSHOT:publish-scm 
> (default-cli) on project maven-scm-publish-plugin-002-publish-scm: Could not 
> copy content to SCM checkout
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:213)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:146)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:51)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:606)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Could not copy 
> content to SCM checkout
> at 
> org.apache.maven.plugins.scmpublish.ScmPublishPublishScmMojo.scmPublishExecute
>  (ScmPublishPublishScmMojo.java:262)
> at org.apache.maven.plugins.scmpublish.AbstractScmPublishMojo.execute 
> (AbstractScmPublishMojo.java:579)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:146)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:51)
> at org.apache.maven.life

[jira] [Created] (MSITE-807) support staging of symbolic links

2018-01-07 Thread JIRA
Hervé Boutemy created MSITE-807:
---

 Summary: support staging of symbolic links
 Key: MSITE-807
 URL: https://issues.apache.org/jira/browse/MSITE-807
 Project: Maven Site Plugin
  Issue Type: Improvement
  Components: site:stage(-deploy)
Affects Versions: 3.7
Reporter: Hervé Boutemy


as seen during maven-scm-publish-plugin MSCMPUB-35 work, having it not blow up 
on symbolic links is a first step to be able to publish mono-module sites
but for multi-module sites, maven-site-plugin needs to be able to stage the 
multi-modules site before scm-publish can publish it



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MSCMPUB-35) add support for symbolic links

2018-01-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MSCMPUB-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315283#comment-16315283
 ] 

Hudson commented on MSCMPUB-35:
---

Build succeeded in Jenkins: Maven TLP » maven-scm-publish-plugin » master #8

See 
https://builds.apache.org/job/maven-box/job/maven-scm-publish-plugin/job/master/8/

> add support for symbolic links
> --
>
> Key: MSCMPUB-35
> URL: https://issues.apache.org/jira/browse/MSCMPUB-35
> Project: Maven SCM Publish Plugin
>  Issue Type: Improvement
>Affects Versions: 1.1
>Reporter: Hervé Boutemy
>
> Maven site uses symbolic links to link from main site to components
> If we want to publish the site without CMS (https://cms.apache.org/), we'll 
> need to have a Jenkins job to publish generated html to 
> https://svn.apache.org/repos/infra/websites/production/maven/content/
> then we'll need symbolic link support, which currently is failing
> {noformat}[ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-scm-publish-plugin:1.2-SNAPSHOT:publish-scm 
> (default-cli) on project maven-scm-publish-plugin-002-publish-scm: Could not 
> copy content to SCM checkout: Source 
> '/home/herve/projets/maven/git/plugins/maven-scm-publish-plugin/target/it/002-publish-scm/target/site/link'
>  does not exist -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal 
> org.apache.maven.plugins:maven-scm-publish-plugin:1.2-SNAPSHOT:publish-scm 
> (default-cli) on project maven-scm-publish-plugin-002-publish-scm: Could not 
> copy content to SCM checkout
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:213)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:146)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:51)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:606)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Could not copy 
> content to SCM checkout
> at 
> org.apache.maven.plugins.scmpublish.ScmPublishPublishScmMojo.scmPublishExecute
>  (ScmPublishPublishScmMojo.java:262)
> at org.apache.maven.plugins.scmpublish.AbstractScmPublishMojo.execute 
> (AbstractScmPublishMojo.java:579)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:146)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:51)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute 

[jira] [Commented] (MNG-6069) Migrate to non deprecated parts of Commons CLI

2018-01-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MNG-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315278#comment-16315278
 ] 

ASF GitHub Bot commented on MNG-6069:
-

Github user rfscholte commented on the issue:

https://github.com/apache/maven/pull/153
  
I don't see that piece of code, but if it works, that's fine. Jason added a 
comment about exposing them as System properties. I don't think we should 
remove that right now, but with a major version.


> Migrate to non deprecated parts of Commons CLI
> --
>
> Key: MNG-6069
> URL: https://issues.apache.org/jira/browse/MNG-6069
> Project: Maven
>  Issue Type: Improvement
>  Components: Embedding
>Affects Versions: 3.3.9, 3.5.0-alpha-1, 3.5.0-beta-1, 3.5.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.5.x-candidate
>
>
> At the moment all parts of {{OptionBuilder...}} are marked deprecated in 
> {{CLIManager}}. They should be migrated to:
> {code:java}
> Option.builder( HELP ).longOpt( "help" ).desc( "Display help information" 
> ).build()
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MNG-5968) plugin version updates in Maven core build

2018-01-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MNG-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315250#comment-16315250
 ] 

ASF GitHub Bot commented on MNG-5968:
-

Github user slachiewicz commented on the issue:

https://github.com/apache/maven/pull/151
  
Thank you for the explanation, I have seen previous discussions about the 
update - for sure the refreshment of the topic will be useful like MNG-6169
I have prepared fix for MNG-5992 and clossing this pull.


> plugin version updates in Maven core build
> --
>
> Key: MNG-5968
> URL: https://issues.apache.org/jira/browse/MNG-5968
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.3.9
>Reporter: Christian Schulte
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.0-alpha-1, 3.5.0
>
>
> upgrade some plugins in Maven core build (pom.xml), just because newest are 
> expected to be better (no known bug):
> ||groupId||artifactId||previous version||target version||
> |{{org.codehaus.mojo}}|{{buildnumber-maven-plugincol}}|1.2|1.4|
> |{{org.codehaus.mojo}}|{{animal-sniffer-maven-plugin}}|1.14|1.15|
> |{{org.apache.maven.plugins}}|{{maven-doap-plugin}}|1.1|1.2|



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MNG-5968) plugin version updates in Maven core build

2018-01-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MNG-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315251#comment-16315251
 ] 

ASF GitHub Bot commented on MNG-5968:
-

Github user slachiewicz closed the pull request at:

https://github.com/apache/maven/pull/151


> plugin version updates in Maven core build
> --
>
> Key: MNG-5968
> URL: https://issues.apache.org/jira/browse/MNG-5968
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.3.9
>Reporter: Christian Schulte
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.0-alpha-1, 3.5.0
>
>
> upgrade some plugins in Maven core build (pom.xml), just because newest are 
> expected to be better (no known bug):
> ||groupId||artifactId||previous version||target version||
> |{{org.codehaus.mojo}}|{{buildnumber-maven-plugincol}}|1.2|1.4|
> |{{org.codehaus.mojo}}|{{animal-sniffer-maven-plugin}}|1.14|1.15|
> |{{org.apache.maven.plugins}}|{{maven-doap-plugin}}|1.1|1.2|



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MNG-6069) Migrate to non deprecated parts of Commons CLI

2018-01-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MNG-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315244#comment-16315244
 ] 

ASF GitHub Bot commented on MNG-6069:
-

GitHub user slachiewicz opened a pull request:

https://github.com/apache/maven/pull/153

[MNG-6069] Migrate to non deprecated parts of Commons CLI

Without 2nd commit 719234d when I set -Dstyle.color=never is not working 
correctly and returns value "true" not "never"

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/slachiewicz/maven fix/MNG-6069

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #153


commit 23b24d314c4253f722a282444cb133e5bd37d5c5
Author: Karl Heinz Marbaise 
Date:   2017-03-18T17:18:27Z

[MNG-6069] Migrate to non deprecated parts of Commons CLI

commit 719234dacf63bfee36f67c1a8c2f7a9e76eb3842
Author: Sylwester Lachiewicz 
Date:   2017-11-24T02:21:09Z

[MNG-6069] Fix optionProperties parsing




> Migrate to non deprecated parts of Commons CLI
> --
>
> Key: MNG-6069
> URL: https://issues.apache.org/jira/browse/MNG-6069
> Project: Maven
>  Issue Type: Improvement
>  Components: Embedding
>Affects Versions: 3.3.9, 3.5.0-alpha-1, 3.5.0-beta-1, 3.5.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.5.x-candidate
>
>
> At the moment all parts of {{OptionBuilder...}} are marked deprecated in 
> {{CLIManager}}. They should be migrated to:
> {code:java}
> Option.builder( HELP ).longOpt( "help" ).desc( "Display help information" 
> ).build()
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MNG-6069) Migrate to non deprecated parts of Commons CLI

2018-01-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MNG-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315240#comment-16315240
 ] 

ASF GitHub Bot commented on MNG-6069:
-

Github user slachiewicz closed the pull request at:

https://github.com/apache/maven/pull/137


> Migrate to non deprecated parts of Commons CLI
> --
>
> Key: MNG-6069
> URL: https://issues.apache.org/jira/browse/MNG-6069
> Project: Maven
>  Issue Type: Improvement
>  Components: Embedding
>Affects Versions: 3.3.9, 3.5.0-alpha-1, 3.5.0-beta-1, 3.5.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.5.x-candidate
>
>
> At the moment all parts of {{OptionBuilder...}} are marked deprecated in 
> {{CLIManager}}. They should be migrated to:
> {code:java}
> Option.builder( HELP ).longOpt( "help" ).desc( "Display help information" 
> ).build()
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MNG-5992) Git passwords are exposed as the Super POM still uses Maven Release Plugin 2.3.2

2018-01-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MNG-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315204#comment-16315204
 ] 

ASF GitHub Bot commented on MNG-5992:
-

GitHub user slachiewicz opened a pull request:

https://github.com/apache/maven/pull/152

[MNG-5992] Upgrade default version of maven-release-plugin to 2.5.3

Fix password printout to logs

Credit to: Ryan J. McDonough

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/slachiewicz/maven 
fix/MNG-5992-maven-release-plugin

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #152


commit 285158e1f76667eea2b92c17fe770b226c15e259
Author: Sylwester Lachiewicz 
Date:   2018-01-07T11:22:11Z

[MNG-5992] Upgrade default version of maven-release-plugin to 2.5.3

Fix password printout to logs

Credit to: Ryan J. McDonough




> Git passwords are exposed as the Super POM still uses Maven Release Plugin 
> 2.3.2
> 
>
> Key: MNG-5992
> URL: https://issues.apache.org/jira/browse/MNG-5992
> Project: Maven
>  Issue Type: Improvement
>  Components: Bootstrap & Build, Plugins and Lifecycle, POM
>Affects Versions: 3.3.3, 3.3.9
> Environment: All
>Reporter: Ryan J. McDonough
>Priority: Critical
>  Labels: security
> Fix For: needing-scrub-3.4.0-fallout
>
>
> The super POM defines version 2.3.2 of the Maven Release plugin. When using 
> HTTP/HTTPS Git SCM URIs, Maven will printout the password in the logs. Thus, 
> any CI system such as Jenkins, TravisCI, etc. will have the passwords exposed 
> in the logs and in the console output. In the case of TravisCI, this will be 
> publicly visible. 
> The [Maven Release Plugin fixed this issue in 
> MRELEASE-846|https://issues.apache.org/jira/browse/MRELEASE-846], but Maven 
> core is still pointing at an exposed version of the Maven Release plugin. I 
> have a test case that demonstrates the issue here:
> https://github.com/damnhandy/maven-publish-issue
> If you run the same build and explicitly define 2.5.3, the password is no 
> longer displayed. This should be the default. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (MNG-6272) How to create deployment file(war/ear/zip) using pom without libraries

2018-01-07 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/MNG-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated MNG-6272:
-
Fix Version/s: (was: waiting-for-feedback)

> How to create deployment file(war/ear/zip) using pom without libraries
> --
>
> Key: MNG-6272
> URL: https://issues.apache.org/jira/browse/MNG-6272
> Project: Maven
>  Issue Type: Bug
>  Components: Dependencies
>Affects Versions: waiting-for-feedback
> Environment: Development
>Reporter: Vijay
>  Labels: build
>   Original Estimate: 2m
>  Remaining Estimate: 2m
>
> Hi
> In my case i have multiple projects referring the same jar file
> For an example my application name is  app1,app2,app3 and these 3 application 
> used db,mq jars
> while running the mvn package command the all the 3 application having the 
> db,mq jars
> Here while running the maven package i have to create the deployment 
> file(war/ear/zip) without libraries
> How can i achieve this in  maven



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MNG-6299) Allow plugins to contribute resolved dependencies

2018-01-07 Thread Romain Manni-Bucau (JIRA)

[ 
https://issues.apache.org/jira/browse/MNG-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315109#comment-16315109
 ] 

Romain Manni-Bucau commented on MNG-6299:
-

Yes, I implement a custom resolver for a particular module. The resolution is 
dynamic and require some coded logic. I dont want to use a custom layout or 
anything like that and just let the plugin modify the dependencies in the 
initialize phase.

A more concrete/widespread example can be to do the same with a p2 repo, 
caching it in a local m2 repo (tycho is way to slow to be usable) and add them 
on the fly. Firdt exec requires this feature.

> Allow plugins to contribute resolved dependencies
> -
>
> Key: MNG-6299
> URL: https://issues.apache.org/jira/browse/MNG-6299
> Project: Maven
>  Issue Type: New Feature
>Reporter: Romain Manni-Bucau
>Priority: Minor
>
> Today maven uses resolvedArtifacts as the base for the "available" artifacts 
> for plugins.
> It would be very fancy and smooth to be able to enrich this list in a plugin 
> for next plugins.
> Today the workaround using gmavenplus-plugin is to use reflection to modify 
> this list but this is not satisfying.
> For info is here the kind of code which is usable:
> {code}
> def addArtifact = { project, art ->
> def f = project.class.getDeclaredField('resolvedArtifacts')
> if (!f.accessible) {
> f.accessible = true
> }
> f.get(pj).add(art)
> }
> {code}
> The high level goal is to be able, for a particular project, to resolve in a 
> custom manner some artifacts and attach them to the project without having to 
> develop a custom repository layout or maven extension (outside the final 
> project).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (SUREFIRE-1458) When multiple surefire providers are available through the maven plugin dependency test are executed N times

2018-01-07 Thread Romain Manni-Bucau (JIRA)

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315108#comment-16315108
 ] 

Romain Manni-Bucau commented on SUREFIRE-1458:
--

Or just the desired classname directly. But yes it is what this ticket is about.

> When multiple surefire providers are available through the maven plugin 
> dependency test are executed N times
> 
>
> Key: SUREFIRE-1458
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1458
> Project: Maven Surefire
>  Issue Type: New Feature
>Reporter: Romain Manni-Bucau
> Fix For: Backlog
>
>
> In a parent surefire-junit47 is enforced and if I add in a child another 
> provider (junit5) then tests are executed twice



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)