[jira] [Created] (MSHARED-771) Upgrade shared-component to version 33
Karl Heinz Marbaise created MSHARED-771: --- Summary: Upgrade shared-component to version 33 Key: MSHARED-771 URL: https://issues.apache.org/jira/browse/MSHARED-771 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-dependency-tree Affects Versions: maven-dependency-tree-3.0.2 Reporter: Karl Heinz Marbaise Fix For: maven-dependency-tree-3.0.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MSHARED-770) Upgrade org.ow2.asm:asm to 7.0
Karl Heinz Marbaise created MSHARED-770: --- Summary: Upgrade org.ow2.asm:asm to 7.0 Key: MSHARED-770 URL: https://issues.apache.org/jira/browse/MSHARED-770 Project: Maven Shared Components Issue Type: Improvement Components: maven-dependency-analyzer Affects Versions: maven-dependency-analyzer-1.10 Reporter: Karl Heinz Marbaise Assignee: Karl Heinz Marbaise Fix For: maven-dependency-analyzer-1.11 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6511) Option -pl ! foo should not fail if foo does not exist
[
https://issues.apache.org/jira/browse/MNG-6511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682256#comment-16682256
]
Karl Heinz Marbaise commented on MNG-6511:
--
I'm not sure if I understand your problem but the {{-pl}} option does not have
a negation
{code}
-pl,--projectsComma-delimited list of specified
reactor projects to build instead
of all projects. A project can be
specified by [groupId]:artifactId
or by its relative path
{code}
Apart from the negation. If a given project is not part of the reactor it must
fail...?
> Option -pl ! foo should not fail if foo does not exist
> --
>
> Key: MNG-6511
> URL: https://issues.apache.org/jira/browse/MNG-6511
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.3.9, 3.6.0
>Reporter: Falko Modler
>Priority: Major
>
> While I completely understand why Maven throws an error when
> {{\-pl/--projects}} defines/contains a non-existing project, I don't really
> see why the negation of a non-existing project yields the same error, e.g.:
> {noformat}
> c:\_dev\git\gitflow-incremental-builder>mvn -pl !foo
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Could not find the selected project in the reactor: foo @
> [ERROR] Could not find the selected project in the reactor: foo -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
> {noformat}
> I'd say that at most this should be a warning, not an error.
> This change would come in handy to reuse scripts with certain default options
> (e.g. quickly build everything without tests, checkstyle, _exclude moduleX_,
> etc.) on different hierarchy levels of larger multi module project.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHADE-291) shadedPattern applied multiples times when relocating the contents of META-INF/services files
[
https://issues.apache.org/jira/browse/MSHADE-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682193#comment-16682193
]
Fabiano Cipriano de Oliveira commented on MSHADE-291:
-
Hi I create a pull request for this
[https://github.com/apache/maven-shade-plugin/pull/9]
Let me know if you need some more information. Thanks
> shadedPattern applied multiples times when relocating the contents of
> META-INF/services files
> -
>
> Key: MSHADE-291
> URL: https://issues.apache.org/jira/browse/MSHADE-291
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Jan Luehe
>Priority: Major
> Labels: up-for-grabs
>
> Steps to reproduce:
> 1. Modified the test case for
> https://issues.apache.org/jira/browse/MSHADE-190, as follows:
> {code:java}
> diff --git a/pom.xml b/pom.xml
> index 746b700..aea9abb 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -68,12 +68,12 @@
>
> org.apache.maven.plugins
> maven-shade-plugin
> -2.4
> +3.1.1
>
>
>
> -org.eclipse.*
> -borg.eclipse.*
> +org.eclipse
> +org.eclipse1234
>
>
>
> {code}
> 2. mvn package
> 3. jar -xvf target/shade-meta-tc-1.0-SNAPSHOT.jar META-INF/services
> 4. cat META-INF/services/org.osgi.framework.launch.FrameworkFactory
> The shaded service implementation class looks as follows:
> {code:java}
> org.eclipse12341234.osgi.launch.EquinoxFactory
> {code}
> It appears that shadedPattern was applied twice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHADE-291) shadedPattern applied multiples times when relocating the contents of META-INF/services files
[
https://issues.apache.org/jira/browse/MSHADE-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682192#comment-16682192
]
ASF GitHub Bot commented on MSHADE-291:
---
fabcipriano opened a new pull request #9: [MSHADE-291] - Fixes bug in
SimpleRelocator
URL: https://github.com/apache/maven-shade-plugin/pull/9
I write a unit test to fix this bug. The fix is in SimpleRelocator
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MSHADE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MSHADE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MSHADE-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> shadedPattern applied multiples times when relocating the contents of
> META-INF/services files
> -
>
> Key: MSHADE-291
> URL: https://issues.apache.org/jira/browse/MSHADE-291
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Jan Luehe
>Priority: Major
> Labels: up-for-grabs
>
> Steps to reproduce:
> 1. Modified the test case for
> https://issues.apache.org/jira/browse/MSHADE-190, as follows:
> {code:java}
> diff --git a/pom.xml b/pom.xml
> index 746b700..aea9abb 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -68,12 +68,12 @@
>
> org.apache.maven.plugins
> maven-shade-plugin
> -2.4
> +3.1.1
>
>
>
> -org.eclipse.*
> -borg.eclipse.*
> +org.eclipse
> +org.eclipse1234
>
>
>
> {code}
> 2. mvn package
> 3. jar -xvf target/shade-meta-tc-1.0-SNAPSHOT.jar META-INF/services
> 4. cat META-INF/services/org.osgi.framework.launch.FrameworkFactory
> The shaded service implementation class looks as follows:
> {code:java}
> org.eclipse12341234.osgi.launch.EquinoxFactory
> {code}
> It appears that shadedPattern was applied twice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] fabcipriano opened a new pull request #9: [MSHADE-291] - Fixes bug in SimpleRelocator
fabcipriano opened a new pull request #9: [MSHADE-291] - Fixes bug in SimpleRelocator URL: https://github.com/apache/maven-shade-plugin/pull/9 I write a unit test to fix this bug. The fix is in SimpleRelocator Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHADE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MSHADE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHADE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6509) Upgrade maven-dependency-plugin to 3.1.1
[ https://issues.apache.org/jira/browse/MNG-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682150#comment-16682150 ] Hudson commented on MNG-6509: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6481 #6 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6481/6/ > Upgrade maven-dependency-plugin to 3.1.1 > > > Key: MNG-6509 > URL: https://issues.apache.org/jira/browse/MNG-6509 > Project: Maven > Issue Type: Dependency upgrade > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > > Upgrade plugin to version compatible with Java 9+ for dependency:resolve goal > in Bootstrap ITs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6481) Allow to compile and test Maven with Java 10/11
[ https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682149#comment-16682149 ] Hudson commented on MNG-6481: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6481 #6 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6481/6/ > Allow to compile and test Maven with Java 10/11 > --- > > Key: MNG-6481 > URL: https://issues.apache.org/jira/browse/MNG-6481 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.x-candidate > > > Java 11 is coming closer, let's prepare to use it for the development of > Maven. > A minimal requirement to run Maven - still Java 7. > * compile and pass Maven's tests with Java 11 > * adjust ITs to run under Java 11 > Do we need compile and to pass all tests with Java 9, 10 and 11? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-1957) clause in the activation section has to provide more complex expressions.
[ https://issues.apache.org/jira/browse/MNG-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682148#comment-16682148 ] Hudson commented on MNG-1957: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6481 #6 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6481/6/ > clause in the activation section has to provide more complex > expressions. > - > > Key: MNG-1957 > URL: https://issues.apache.org/jira/browse/MNG-1957 > Project: Maven > Issue Type: Improvement > Components: POM >Affects Versions: 2.0, 2.0.1 >Reporter: Trustin Lee >Assignee: Brett Porter >Priority: Major > Fix For: 2.1.0 > > Attachments: MNG-1957-maven-project.patch > > > For now, provides only one operator '!' which means negation, but > it would be great if i can use '+' and ~ operator: > 1.5+ > 1.1 ~ 1.4 > ~ 1.3 > 1.4 ~ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6427) IT for MNG-1957 fails on Java 9+
[
https://issues.apache.org/jira/browse/MNG-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682147#comment-16682147
]
Hudson commented on MNG-6427:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-6481 #6
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6481/6/
> IT for MNG-1957 fails on Java 9+
>
>
> Key: MNG-6427
> URL: https://issues.apache.org/jira/browse/MNG-6427
> Project: Maven
> Issue Type: Bug
> Components: Integration Tests
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> The execution fails with:
> {noformat}
> junit.framework.ComparisonFailure: expected: but was:
> at
> org.apache.maven.it.MavenITmng1957JdkActivationWithVersionRangeTest.testitMNG1957(MavenITmng1957JdkActivationWithVersionRangeTest.java:64)
> {noformat}
> This is caused by incorrect JDK ranges in the {{pom.xml}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MNG-6511) Option -pl ! foo should not fail if foo does not exist
Falko Modler created MNG-6511:
-
Summary: Option -pl ! foo should not fail if foo does not exist
Key: MNG-6511
URL: https://issues.apache.org/jira/browse/MNG-6511
Project: Maven
Issue Type: Improvement
Affects Versions: 3.6.0, 3.3.9
Reporter: Falko Modler
While I completely understand why Maven throws an error when
{{\-pl/--projects}} defines/contains a non-existing project, I don't really see
why the negation of a non-existing project yields the same error, e.g.:
{noformat}
c:\_dev\git\gitflow-incremental-builder>mvn -pl !foo
[INFO] Scanning for projects...
[ERROR] [ERROR] Could not find the selected project in the reactor: foo @
[ERROR] Could not find the selected project in the reactor: foo -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
{noformat}
I'd say that at most this should be a warning, not an error.
This change would come in handy to reuse scripts with certain default options
(e.g. quickly build everything without tests, checkstyle, _exclude moduleX_,
etc.) on different hierarchy levels of larger multi module project.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MEAR-271) Support lookup-name in resource-ref section
[
https://issues.apache.org/jira/browse/MEAR-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681967#comment-16681967
]
Hudson commented on MEAR-271:
-
Build succeeded in Jenkins: Maven TLP » maven-ear-plugin » master #52
See https://builds.apache.org/job/maven-box/job/maven-ear-plugin/job/master/52/
> Support lookup-name in resource-ref section
> ---
>
> Key: MEAR-271
> URL: https://issues.apache.org/jira/browse/MEAR-271
> Project: Maven Ear Plugin
> Issue Type: Wish
>Affects Versions: 3.0.1
>Reporter: Lonzak
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.0.2
>
>
> It would be nice if the 'lookup-name' would be supported in the resource-ref
> section to support JNDI lookup. Currently, this tag is ignored in the
> generated application.xml. (+description would also be nice)
> Example:
> The pom.xml snippet
> {code:xml}
>
>
>
> ExampleDS
> jdbc/ExampleDS
> javax.sql.DataSource
> Container
> java:jboss/datasources/ExampleDS
>
>
>
> {code}
> should generate application.xml with
> {code:xml}
>
> ExampleDS
> jdbc/ExampleDS
> javax.sql.DataSource
> Container
> java:jboss/datasources/ExampleDS
>
> {code}
> This is from a solution from the jboss guys.
> [JBoss solution|https://i.imgur.com/3XDxQNJ.png]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MEAR-271) Support lookup-name in resource-ref section
[
https://issues.apache.org/jira/browse/MEAR-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MEAR-271.
Resolution: Fixed
Done in
[f002918d6cad2e607572a5049fe2b8e078a04979|https://gitbox.apache.org/repos/asf?p=maven-ear-plugin.git;a=commitdiff;h=f002918d6cad2e607572a5049fe2b8e078a04979]
> Support lookup-name in resource-ref section
> ---
>
> Key: MEAR-271
> URL: https://issues.apache.org/jira/browse/MEAR-271
> Project: Maven Ear Plugin
> Issue Type: Wish
>Affects Versions: 3.0.1
>Reporter: Lonzak
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.0.2
>
>
> It would be nice if the 'lookup-name' would be supported in the resource-ref
> section to support JNDI lookup. Currently, this tag is ignored in the
> generated application.xml. (+description would also be nice)
> Example:
> The pom.xml snippet
> {code:xml}
>
>
>
> ExampleDS
> jdbc/ExampleDS
> javax.sql.DataSource
> Container
> java:jboss/datasources/ExampleDS
>
>
>
> {code}
> should generate application.xml with
> {code:xml}
>
> ExampleDS
> jdbc/ExampleDS
> javax.sql.DataSource
> Container
> java:jboss/datasources/ExampleDS
>
> {code}
> This is from a solution from the jboss guys.
> [JBoss solution|https://i.imgur.com/3XDxQNJ.png]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MSHARED-769) FileNotFoundException not thrown for unknown property file
Robert Scholte created MSHARED-769: -- Summary: FileNotFoundException not thrown for unknown property file Key: MSHARED-769 URL: https://issues.apache.org/jira/browse/MSHARED-769 Project: Maven Shared Components Issue Type: Bug Components: maven-verifier Affects Versions: maven-verifier-1.6 Reporter: Robert Scholte Assignee: Robert Scholte -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-768) Require Java 7
[ https://issues.apache.org/jira/browse/MSHARED-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681829#comment-16681829 ] Hudson commented on MSHARED-768: Build succeeded in Jenkins: Maven TLP » maven-verifier » master #28 See https://builds.apache.org/job/maven-box/job/maven-verifier/job/master/28/ > Require Java 7 > -- > > Key: MSHARED-768 > URL: https://issues.apache.org/jira/browse/MSHARED-768 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-verifier >Reporter: Robert Scholte >Assignee: Robert Scholte >Priority: Major > Fix For: maven-verifier-3.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MSHARED-768) Require Java 7
Robert Scholte created MSHARED-768: -- Summary: Require Java 7 Key: MSHARED-768 URL: https://issues.apache.org/jira/browse/MSHARED-768 Project: Maven Shared Components Issue Type: Improvement Components: maven-verifier Reporter: Robert Scholte Assignee: Robert Scholte Fix For: maven-verifier-3.0.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1539) Surefire causes Jigwaw runtime errors when forkCount > 0
[
https://issues.apache.org/jira/browse/SUREFIRE-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681800#comment-16681800
]
Robert Scholte commented on SUREFIRE-1539:
--
[~pether] I don't think that's the best advice, with forking you can test it
with the module-path. I wouldn't call it "mixed", but split up. As you can see,
surefire generates a lot of extra flags to make the application run. Still
_somebody_ needs to figure out what's happening here exactly and how to fix it.
Based on the exception the following should be (automatically) added too:
{noformat}
--add-exports
fr.cla.wires.core/fr.cla.wires.core.pbt=ALL-UNNAMED
{noformat}
> Surefire causes Jigwaw runtime errors when forkCount > 0
>
>
> Key: SUREFIRE-1539
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1539
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: foo bar
>Priority: Major
> Attachments: mvn-X-clean-install--forkCount0-OK.txt,
> mvn-X-clean-install--noforkCount0-KO.txt
>
>
> h1. The problem
> I'm migrating my toy project to Jigsaw modules.
> Now I managed to make it work ({{maven clean install}} OK), but I had to
> pass an additional flag to Surefire ({{forkCount=0}}) that I think I
> shouldn't have to and feels very "magical" (in a bad way).
> To reproduce:
> 1. {{git clone [https://github.com/vandekeiser/wires.git]}}
> 2. {{git checkout REPORT_SUREFIRE}}
> 3.1 {{mvn clean install}}
> -->passes
> 3.2 remove {{0}} in {{/pom.xml}}
> -->fails
> h1. Analysis
> If I remove {{0}} or set it to 1 in {{/pom.xml}} I get:
> {code:java}
> [ERROR] Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 5.678
> s <<< FAILURE! - in
> fr.cla.wires.core.boxes.exampleusage.propertybasedtesting.MultipleAnd_ReduceAndCollectShouldBeEquivalent_PbtTest
> [ERROR]
> should_sometimes_give_false(fr.cla.wires.core.boxes.exampleusage.propertybasedtesting.MultipleAnd_ReduceAndCollectShouldBeEquivalent_PbtTest)
> Time elapsed: 0.219 s <<< ERROR!
> com.pholser.junit.quickcheck.internal.ReflectionException:
> java.lang.IllegalAccessException: class
> com.pholser.junit.quickcheck.internal.Reflection cannot access class
> fr.cla.wires.core.support.tests.pbt.BooleansGenerator (in module
> fr.cla.wires.core) because module fr.cla.wires.core does not export
> fr.cla.wires.core.support.tests.pbt to unnamed module @4b5a5ed1
> {code}
> Looks like --add-opens is no longer added? Or is it just appended to the
> command line, not added to the tmp java @arg file?
> Or is it that with forkCount=0 the test is ran on the classpath and with
> forkCount=1 the test is ran on the modulepath?
>
> If i set it to 2, I get instead:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test (default-test) on
> project wires-support: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test failed:
> java.lang.ClassNotFoundException:
> org.apache.maven.plugin.surefire.StartupReportConfiguration -> [Help 1]{code}
> Which is even more mysterious.
> Environment:
> {code:java}
> $ mvn -version
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T20:33:14+02:00)
> Maven home: G:\software\apache-maven-3.5.4-bin\apache-maven-3.5.4
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk-10.0.2
> Default locale: fr_FR, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1593) 3.0.0-M1 produces invalid code sources on Windows
[
https://issues.apache.org/jira/browse/SUREFIRE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681779#comment-16681779
]
ASF GitHub Bot commented on SUREFIRE-1593:
--
jglick commented on a change in pull request #198: [SUREFIRE-1593] Correcting
relativization logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#discussion_r232342689
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
##
@@ -150,10 +150,9 @@ private static String toClasspathElementUri( @Nonnull
Path parent,
{
try
{
-return new URI( null,
-parent.relativize( classPathElement.toPath()
).toString().
-replace( File.separatorChar, '/' ),
-null ).toASCIIString();
+Path relativePath = parent.relativize( classPathElement.toPath() );
Review comment:
I cannot imagine you could write a reliable IT without Vagrant or similar.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 3.0.0-M1 produces invalid code sources on Windows
> -
>
> Key: SUREFIRE-1593
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1593
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, process forking
>Affects Versions: 3.0.0-M1
>Reporter: Jesse Glick
>Priority: Major
>
> The fix for SUREFIRE-1588 did not work correctly on Windows. (When
> active—i.e., when the drive letters of the system temporary directory, per
> SUREFIRE-1400, and the project basedir were the same.) It would produce
> relative URIs containing {{%5C}} where {{/}} was intended.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] jglick commented on a change in pull request #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
jglick commented on a change in pull request #198: [SUREFIRE-1593] Correcting
relativization logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#discussion_r232342689
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
##
@@ -150,10 +150,9 @@ private static String toClasspathElementUri( @Nonnull
Path parent,
{
try
{
-return new URI( null,
-parent.relativize( classPathElement.toPath()
).toString().
-replace( File.separatorChar, '/' ),
-null ).toASCIIString();
+Path relativePath = parent.relativize( classPathElement.toPath() );
Review comment:
I cannot imagine you could write a reliable IT without Vagrant or similar.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (SUREFIRE-1593) 3.0.0-M1 produces invalid code sources on Windows
[
https://issues.apache.org/jira/browse/SUREFIRE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681776#comment-16681776
]
ASF GitHub Bot commented on SUREFIRE-1593:
--
jglick commented on issue #198: [SUREFIRE-1593] Correcting relativization logic
to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-43771
> create a new Jira ticket?
Besides the SUREFIRE-1593 I already created?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 3.0.0-M1 produces invalid code sources on Windows
> -
>
> Key: SUREFIRE-1593
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1593
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, process forking
>Affects Versions: 3.0.0-M1
>Reporter: Jesse Glick
>Priority: Major
>
> The fix for SUREFIRE-1588 did not work correctly on Windows. (When
> active—i.e., when the drive letters of the system temporary directory, per
> SUREFIRE-1400, and the project basedir were the same.) It would produce
> relative URIs containing {{%5C}} where {{/}} was intended.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] jglick commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
jglick commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-43771 > create a new Jira ticket? Besides the SUREFIRE-1593 I already created? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SUREFIRE-1539) Surefire causes Jigwaw runtime errors when forkCount > 0
[
https://issues.apache.org/jira/browse/SUREFIRE-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681731#comment-16681731
]
James Pether Sörling commented on SUREFIRE-1539:
My workaround at the moment is to stay on version 2.20.1 , same problem on
2.21.0, 2.21.1,2.22.0, 2.22.1 and 3.0.0-M1.
>From :
>https://medium.com/criciumadev/its-time-migrating-to-java-11-5eb3868354f9
_Notes: When_ *_module-info.java_* _is present and fork process is enabled,
surefire creates a mixed classpath with modules and unnamed modules causing
module visibility issues and preventing the application to start._
> Surefire causes Jigwaw runtime errors when forkCount > 0
>
>
> Key: SUREFIRE-1539
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1539
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: foo bar
>Priority: Major
> Attachments: mvn-X-clean-install--forkCount0-OK.txt,
> mvn-X-clean-install--noforkCount0-KO.txt
>
>
> h1. The problem
> I'm migrating my toy project to Jigsaw modules.
> Now I managed to make it work ({{maven clean install}} OK), but I had to
> pass an additional flag to Surefire ({{forkCount=0}}) that I think I
> shouldn't have to and feels very "magical" (in a bad way).
> To reproduce:
> 1. {{git clone [https://github.com/vandekeiser/wires.git]}}
> 2. {{git checkout REPORT_SUREFIRE}}
> 3.1 {{mvn clean install}}
> -->passes
> 3.2 remove {{0}} in {{/pom.xml}}
> -->fails
> h1. Analysis
> If I remove {{0}} or set it to 1 in {{/pom.xml}} I get:
> {code:java}
> [ERROR] Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 5.678
> s <<< FAILURE! - in
> fr.cla.wires.core.boxes.exampleusage.propertybasedtesting.MultipleAnd_ReduceAndCollectShouldBeEquivalent_PbtTest
> [ERROR]
> should_sometimes_give_false(fr.cla.wires.core.boxes.exampleusage.propertybasedtesting.MultipleAnd_ReduceAndCollectShouldBeEquivalent_PbtTest)
> Time elapsed: 0.219 s <<< ERROR!
> com.pholser.junit.quickcheck.internal.ReflectionException:
> java.lang.IllegalAccessException: class
> com.pholser.junit.quickcheck.internal.Reflection cannot access class
> fr.cla.wires.core.support.tests.pbt.BooleansGenerator (in module
> fr.cla.wires.core) because module fr.cla.wires.core does not export
> fr.cla.wires.core.support.tests.pbt to unnamed module @4b5a5ed1
> {code}
> Looks like --add-opens is no longer added? Or is it just appended to the
> command line, not added to the tmp java @arg file?
> Or is it that with forkCount=0 the test is ran on the classpath and with
> forkCount=1 the test is ran on the modulepath?
>
> If i set it to 2, I get instead:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test (default-test) on
> project wires-support: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test failed:
> java.lang.ClassNotFoundException:
> org.apache.maven.plugin.surefire.StartupReportConfiguration -> [Help 1]{code}
> Which is even more mysterious.
> Environment:
> {code:java}
> $ mvn -version
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T20:33:14+02:00)
> Maven home: G:\software\apache-maven-3.5.4-bin\apache-maven-3.5.4
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk-10.0.2
> Default locale: fr_FR, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MJAR-193) Allow other mojos to contribute to the manifest
[ https://issues.apache.org/jira/browse/MJAR-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681718#comment-16681718 ] Robert Scholte commented on MJAR-193: - I don't think plexus-archiver, maven-archiver might make sense, depending on the question if this can be solved at that level in an abstract way. > Allow other mojos to contribute to the manifest > --- > > Key: MJAR-193 > URL: https://issues.apache.org/jira/browse/MJAR-193 > Project: Maven JAR Plugin > Issue Type: Improvement >Reporter: Carsten Ziegeler >Priority: Major > Fix For: waiting-for-feedback > > > It would be great to have a programmatic way to add entries to the manifest > from other mojos. The most important client of such a way would be the maven > bundle plugin (from the Apache Felix project) that calculates additional > headers for OSGi bundles. Right now, that bundle does not only do the > calculation but generates the jar file as well. > While a workaround would be to let the bundle plugin generate the full > manifest and configure the jar plugin to use it, this is not very elegant. > Passing down a map of manifest entries from one mojo to the jar plugin would > solve this in a much better way. > And I could imagine that other mojos/plugins might benefit for this as well. > This would be a simple but very convenient enhancement to the plugin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1539) Surefire causes Jigwaw runtime errors when forkCount > 0
[
https://issues.apache.org/jira/browse/SUREFIRE-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681682#comment-16681682
]
Tibor Digana commented on SUREFIRE-1539:
[~vandekeizer]
[~pether]
Pls see the comments above and isolate particular code in a separate Maven
module. Let us know how it is going.
I want to know if we have this as one problem or there is more. Thx
> Surefire causes Jigwaw runtime errors when forkCount > 0
>
>
> Key: SUREFIRE-1539
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1539
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: foo bar
>Priority: Major
> Attachments: mvn-X-clean-install--forkCount0-OK.txt,
> mvn-X-clean-install--noforkCount0-KO.txt
>
>
> h1. The problem
> I'm migrating my toy project to Jigsaw modules.
> Now I managed to make it work ({{maven clean install}} OK), but I had to
> pass an additional flag to Surefire ({{forkCount=0}}) that I think I
> shouldn't have to and feels very "magical" (in a bad way).
> To reproduce:
> 1. {{git clone [https://github.com/vandekeiser/wires.git]}}
> 2. {{git checkout REPORT_SUREFIRE}}
> 3.1 {{mvn clean install}}
> -->passes
> 3.2 remove {{0}} in {{/pom.xml}}
> -->fails
> h1. Analysis
> If I remove {{0}} or set it to 1 in {{/pom.xml}} I get:
> {code:java}
> [ERROR] Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 5.678
> s <<< FAILURE! - in
> fr.cla.wires.core.boxes.exampleusage.propertybasedtesting.MultipleAnd_ReduceAndCollectShouldBeEquivalent_PbtTest
> [ERROR]
> should_sometimes_give_false(fr.cla.wires.core.boxes.exampleusage.propertybasedtesting.MultipleAnd_ReduceAndCollectShouldBeEquivalent_PbtTest)
> Time elapsed: 0.219 s <<< ERROR!
> com.pholser.junit.quickcheck.internal.ReflectionException:
> java.lang.IllegalAccessException: class
> com.pholser.junit.quickcheck.internal.Reflection cannot access class
> fr.cla.wires.core.support.tests.pbt.BooleansGenerator (in module
> fr.cla.wires.core) because module fr.cla.wires.core does not export
> fr.cla.wires.core.support.tests.pbt to unnamed module @4b5a5ed1
> {code}
> Looks like --add-opens is no longer added? Or is it just appended to the
> command line, not added to the tmp java @arg file?
> Or is it that with forkCount=0 the test is ran on the classpath and with
> forkCount=1 the test is ran on the modulepath?
>
> If i set it to 2, I get instead:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test (default-test) on
> project wires-support: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test failed:
> java.lang.ClassNotFoundException:
> org.apache.maven.plugin.surefire.StartupReportConfiguration -> [Help 1]{code}
> Which is even more mysterious.
> Environment:
> {code:java}
> $ mvn -version
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T20:33:14+02:00)
> Maven home: G:\software\apache-maven-3.5.4-bin\apache-maven-3.5.4
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk-10.0.2
> Default locale: fr_FR, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1593) 3.0.0-M1 produces invalid code sources on Windows
[
https://issues.apache.org/jira/browse/SUREFIRE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681688#comment-16681688
]
ASF GitHub Bot commented on SUREFIRE-1593:
--
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization
logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437419749
Currently running the build with our changes...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 3.0.0-M1 produces invalid code sources on Windows
> -
>
> Key: SUREFIRE-1593
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1593
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, process forking
>Affects Versions: 3.0.0-M1
>Reporter: Jesse Glick
>Priority: Major
>
> The fix for SUREFIRE-1588 did not work correctly on Windows. (When
> active—i.e., when the drive letters of the system temporary directory, per
> SUREFIRE-1400, and the project basedir were the same.) It would produce
> relative URIs containing {{%5C}} where {{/}} was intended.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437419749 Currently running the build with our changes... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (SUREFIRE-1541) SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[
https://issues.apache.org/jira/browse/SUREFIRE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1541.
--
Resolution: Duplicate
Assignee: Tibor Digana
> SurefireBooterForkException: The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> --
>
> Key: SUREFIRE-1541
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1541
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Anghel Botos
>Assignee: Tibor Digana
>Priority: Major
>
> Attempting to run integration tests using maven-failsafe-plugin with
> {{-Dmaven.failsafe.debug=false}} yields the following stacktrace:
>
> {noformat}
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was cmd.exe /X /C ""C:\Program
> Files\Java\jdk1.8.0_121\jre\bin\java" false -jar
> C:\Users\ANGHEL~1.BOT\AppData\Local\Temp\surefire8539836821793811485\surefirebooter6734575521909210279.jar
> C:\Users\anghel.botos\AppData\Local\Temp\surefire8539836821793811485
> 2018-07-24T11-18-12_704-jvmRun1 surefire7184511894589995478tmp
> surefire_411836142070426630764tmp"
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:494)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:441)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:293)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> {noformat}
>
> The issue is the "free-floating" {{false}} that appears in the command line
> used to start a new JVM. I've traced down the issue to
> {{org.apache.maven.plugin.surefire.AbstractSurefireMojo#getEffectiveDebugForkedProcess}}
> where the following code can be found:
> {code:java}
> String debugForkedProcess = getDebugForkedProcess();
> if ( "true".equals( debugForkedProcess ) )
> {
> return "-Xdebug -Xnoagent -Djava.compiler=NONE"
> + "
> -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005";
> }
> return debugForkedProcess;
> {code}
> ...which is quite..."unexpected" to see that one can pass in a value of
> {{true}}, but not a value of {{false}}.
> Please fix with a proper parsing of true/false values for the
> {{maven.failsafe.debug}} property.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1541) SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[
https://issues.apache.org/jira/browse/SUREFIRE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681677#comment-16681677
]
Tibor Digana commented on SUREFIRE-1541:
[~patsevanton]
No, it's not a beta. It's release candidate. We used Java 1.7 and Maven API 3.0
and we fixed {{SUREFIRE-1588}} which is fix for your problem. The API 3.0 and
java 1.7 is a MUST for our plugin version 3.0.0 but since we are expecting more
dramatic changes, that we cannot do after the release 3.0.0, we have release
the mandatory M1 first of all and then we will continue with more release
candidates which break some backwards compatibility (but not everything of
course - only those API which fix critical and blocker issues - see Jira).
> SurefireBooterForkException: The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> --
>
> Key: SUREFIRE-1541
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1541
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Anghel Botos
>Priority: Major
>
> Attempting to run integration tests using maven-failsafe-plugin with
> {{-Dmaven.failsafe.debug=false}} yields the following stacktrace:
>
> {noformat}
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was cmd.exe /X /C ""C:\Program
> Files\Java\jdk1.8.0_121\jre\bin\java" false -jar
> C:\Users\ANGHEL~1.BOT\AppData\Local\Temp\surefire8539836821793811485\surefirebooter6734575521909210279.jar
> C:\Users\anghel.botos\AppData\Local\Temp\surefire8539836821793811485
> 2018-07-24T11-18-12_704-jvmRun1 surefire7184511894589995478tmp
> surefire_411836142070426630764tmp"
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:494)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:441)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:293)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> {noformat}
>
> The issue is the "free-floating" {{false}} that appears in the command line
> used to start a new JVM. I've traced down the issue to
> {{org.apache.maven.plugin.surefire.AbstractSurefireMojo#getEffectiveDebugForkedProcess}}
> where the following code can be found:
> {code:java}
> String debugForkedProcess = getDebugForkedProcess();
> if ( "true".equals( debugForkedProcess ) )
> {
> return "-Xdebug -Xnoagent -Djava.compiler=NONE"
> + "
> -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005";
> }
> return debugForkedProcess;
> {code}
> ...which is quite..."unexpected" to see that one can pass in a value of
> {{true}}, but not a value of {{false}}.
> Please fix with a proper parsing of true/false values for the
> {{maven.failsafe.debug}} property.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1541) SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[
https://issues.apache.org/jira/browse/SUREFIRE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681665#comment-16681665
]
Anton commented on SUREFIRE-1541:
-
Yes. maven-surefire-plugin 3.0.0-M1 with maven:3.6.0-jdk-8 fixed issue. Thx!
maven-surefire-plugin 3.0.0-M1 - is beta? when new stable release?
> SurefireBooterForkException: The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> --
>
> Key: SUREFIRE-1541
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1541
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Anghel Botos
>Priority: Major
>
> Attempting to run integration tests using maven-failsafe-plugin with
> {{-Dmaven.failsafe.debug=false}} yields the following stacktrace:
>
> {noformat}
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was cmd.exe /X /C ""C:\Program
> Files\Java\jdk1.8.0_121\jre\bin\java" false -jar
> C:\Users\ANGHEL~1.BOT\AppData\Local\Temp\surefire8539836821793811485\surefirebooter6734575521909210279.jar
> C:\Users\anghel.botos\AppData\Local\Temp\surefire8539836821793811485
> 2018-07-24T11-18-12_704-jvmRun1 surefire7184511894589995478tmp
> surefire_411836142070426630764tmp"
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:494)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:441)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:293)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> {noformat}
>
> The issue is the "free-floating" {{false}} that appears in the command line
> used to start a new JVM. I've traced down the issue to
> {{org.apache.maven.plugin.surefire.AbstractSurefireMojo#getEffectiveDebugForkedProcess}}
> where the following code can be found:
> {code:java}
> String debugForkedProcess = getDebugForkedProcess();
> if ( "true".equals( debugForkedProcess ) )
> {
> return "-Xdebug -Xnoagent -Djava.compiler=NONE"
> + "
> -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005";
> }
> return debugForkedProcess;
> {code}
> ...which is quite..."unexpected" to see that one can pass in a value of
> {{true}}, but not a value of {{false}}.
> Please fix with a proper parsing of true/false values for the
> {{maven.failsafe.debug}} property.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SUREFIRE-1541) SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[
https://issues.apache.org/jira/browse/SUREFIRE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681665#comment-16681665
]
Anton edited comment on SUREFIRE-1541 at 11/9/18 4:25 PM:
--
Yes.
https://gitlab.com/anton_patsev/java-junit-sample/pipelines/36051881
maven-surefire-plugin 3.0.0-M1 with maven:3.6.0-jdk-8 fixed issue. Thx!
maven-surefire-plugin 3.0.0-M1 - is beta? when new stable release?
was (Author: patsevanton):
Yes. maven-surefire-plugin 3.0.0-M1 with maven:3.6.0-jdk-8 fixed issue. Thx!
maven-surefire-plugin 3.0.0-M1 - is beta? when new stable release?
> SurefireBooterForkException: The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> --
>
> Key: SUREFIRE-1541
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1541
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Anghel Botos
>Priority: Major
>
> Attempting to run integration tests using maven-failsafe-plugin with
> {{-Dmaven.failsafe.debug=false}} yields the following stacktrace:
>
> {noformat}
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was cmd.exe /X /C ""C:\Program
> Files\Java\jdk1.8.0_121\jre\bin\java" false -jar
> C:\Users\ANGHEL~1.BOT\AppData\Local\Temp\surefire8539836821793811485\surefirebooter6734575521909210279.jar
> C:\Users\anghel.botos\AppData\Local\Temp\surefire8539836821793811485
> 2018-07-24T11-18-12_704-jvmRun1 surefire7184511894589995478tmp
> surefire_411836142070426630764tmp"
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:494)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:441)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:293)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> {noformat}
>
> The issue is the "free-floating" {{false}} that appears in the command line
> used to start a new JVM. I've traced down the issue to
> {{org.apache.maven.plugin.surefire.AbstractSurefireMojo#getEffectiveDebugForkedProcess}}
> where the following code can be found:
> {code:java}
> String debugForkedProcess = getDebugForkedProcess();
> if ( "true".equals( debugForkedProcess ) )
> {
> return "-Xdebug -Xnoagent -Djava.compiler=NONE"
> + "
> -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005";
> }
> return debugForkedProcess;
> {code}
> ...which is quite..."unexpected" to see that one can pass in a value of
> {{true}}, but not a value of {{false}}.
> Please fix with a proper parsing of true/false values for the
> {{maven.failsafe.debug}} property.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MJAR-193) Allow other mojos to contribute to the manifest
[ https://issues.apache.org/jira/browse/MJAR-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681659#comment-16681659 ] Konrad Windszus commented on MJAR-193: -- [~rfscholte] Where should this new interface live in your opinion? Should it be part of the maven-jar-plugin, maven-archiver (https://github.com/apache/maven-archiver) or plexus-archiver (https://github.com/codehaus-plexus/plexus-archiver)? > Allow other mojos to contribute to the manifest > --- > > Key: MJAR-193 > URL: https://issues.apache.org/jira/browse/MJAR-193 > Project: Maven JAR Plugin > Issue Type: Improvement >Reporter: Carsten Ziegeler >Priority: Major > Fix For: waiting-for-feedback > > > It would be great to have a programmatic way to add entries to the manifest > from other mojos. The most important client of such a way would be the maven > bundle plugin (from the Apache Felix project) that calculates additional > headers for OSGi bundles. Right now, that bundle does not only do the > calculation but generates the jar file as well. > While a workaround would be to let the bundle plugin generate the full > manifest and configure the jar plugin to use it, this is not very elegant. > Passing down a map of manifest entries from one mojo to the jar plugin would > solve this in a much better way. > And I could imagine that other mojos/plugins might benefit for this as well. > This would be a simple but very convenient enhancement to the plugin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1593) 3.0.0-M1 produces invalid code sources on Windows
[
https://issues.apache.org/jira/browse/SUREFIRE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681654#comment-16681654
]
ASF GitHub Bot commented on SUREFIRE-1593:
--
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization
logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437408939
@jglick
Can you squash the commits together, rebase on the master and create a new
Jira ticket?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 3.0.0-M1 produces invalid code sources on Windows
> -
>
> Key: SUREFIRE-1593
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1593
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, process forking
>Affects Versions: 3.0.0-M1
>Reporter: Jesse Glick
>Priority: Major
>
> The fix for SUREFIRE-1588 did not work correctly on Windows. (When
> active—i.e., when the drive letters of the system temporary directory, per
> SUREFIRE-1400, and the project basedir were the same.) It would produce
> relative URIs containing {{%5C}} where {{/}} was intended.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437408939 @jglick Can you squash the commits together, rebase on the master and create a new Jira ticket? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MSHARED-767) Incremental should result in Stream
[ https://issues.apache.org/jira/browse/MSHARED-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681614#comment-16681614 ] Robert Scholte commented on MSHARED-767: We need to start somewhere, this one looks like a nice one to start with. > Incremental should result in Stream > --- > > Key: MSHARED-767 > URL: https://issues.apache.org/jira/browse/MSHARED-767 > Project: Maven Shared Components > Issue Type: Task > Components: maven-shared-incremental >Affects Versions: maven-shared-incremental-2.0.0 >Reporter: Robert Scholte >Priority: Major > > The current implementation is inefficient, it does a complete scan of the > sourcefolder(s) whereas in general knowing the first change is already > sufficient. > The Java 8 StreamAPI can help here. > The result should be a Stream of Resources(?) containing the filereference > and a status (added, removed, changed). It must be possible to support > localResources (where input and output can be compared) and remoteResources > (where metadata must be stored to know if it has been changed). Filtering can > be done by the consumer of the stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-767) Incremental should result in Stream
[ https://issues.apache.org/jira/browse/MSHARED-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681590#comment-16681590 ] Michael Osipov commented on MSHARED-767: This is a good idea. We actually need to overhaul all of our API with Java 7 and 8 features, but this will take years... > Incremental should result in Stream > --- > > Key: MSHARED-767 > URL: https://issues.apache.org/jira/browse/MSHARED-767 > Project: Maven Shared Components > Issue Type: Task > Components: maven-shared-incremental >Affects Versions: maven-shared-incremental-2.0.0 >Reporter: Robert Scholte >Priority: Major > > The current implementation is inefficient, it does a complete scan of the > sourcefolder(s) whereas in general knowing the first change is already > sufficient. > The Java 8 StreamAPI can help here. > The result should be a Stream of Resources(?) containing the filereference > and a status (added, removed, changed). It must be possible to support > localResources (where input and output can be compared) and remoteResources > (where metadata must be stored to know if it has been changed). Filtering can > be done by the consumer of the stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1541) SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[
https://issues.apache.org/jira/browse/SUREFIRE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681586#comment-16681586
]
Tibor Digana commented on SUREFIRE-1541:
[~patsevanton]
Use the latest version {{3.0.0-M1}} of the plugin together with
{{maven:3.5.4-jdk-8}} and let me know the result. Thx
> SurefireBooterForkException: The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> --
>
> Key: SUREFIRE-1541
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1541
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Anghel Botos
>Priority: Major
>
> Attempting to run integration tests using maven-failsafe-plugin with
> {{-Dmaven.failsafe.debug=false}} yields the following stacktrace:
>
> {noformat}
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was cmd.exe /X /C ""C:\Program
> Files\Java\jdk1.8.0_121\jre\bin\java" false -jar
> C:\Users\ANGHEL~1.BOT\AppData\Local\Temp\surefire8539836821793811485\surefirebooter6734575521909210279.jar
> C:\Users\anghel.botos\AppData\Local\Temp\surefire8539836821793811485
> 2018-07-24T11-18-12_704-jvmRun1 surefire7184511894589995478tmp
> surefire_411836142070426630764tmp"
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:494)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:441)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:293)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> {noformat}
>
> The issue is the "free-floating" {{false}} that appears in the command line
> used to start a new JVM. I've traced down the issue to
> {{org.apache.maven.plugin.surefire.AbstractSurefireMojo#getEffectiveDebugForkedProcess}}
> where the following code can be found:
> {code:java}
> String debugForkedProcess = getDebugForkedProcess();
> if ( "true".equals( debugForkedProcess ) )
> {
> return "-Xdebug -Xnoagent -Djava.compiler=NONE"
> + "
> -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005";
> }
> return debugForkedProcess;
> {code}
> ...which is quite..."unexpected" to see that one can pass in a value of
> {{true}}, but not a value of {{false}}.
> Please fix with a proper parsing of true/false values for the
> {{maven.failsafe.debug}} property.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SUREFIRE-1541) SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[
https://issues.apache.org/jira/browse/SUREFIRE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681572#comment-16681572
]
Tibor Digana edited comment on SUREFIRE-1541 at 11/9/18 3:11 PM:
-
[~bchupika]
Do not use this workaround.
I think you have totally different problem -
[SUREFIRE1588|https://issues.apache.org/jira/browse/SUREFIRE-1555].
Use the latest version {{3.0.0-M1}}.
was (Author: tibor17):
[~bchupika]
Do not use this workaround.
I think you have totally different problem - SUREFIRE1588.
Use the latest version {{3.0.0-M1}}.
> SurefireBooterForkException: The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> --
>
> Key: SUREFIRE-1541
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1541
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Anghel Botos
>Priority: Major
>
> Attempting to run integration tests using maven-failsafe-plugin with
> {{-Dmaven.failsafe.debug=false}} yields the following stacktrace:
>
> {noformat}
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was cmd.exe /X /C ""C:\Program
> Files\Java\jdk1.8.0_121\jre\bin\java" false -jar
> C:\Users\ANGHEL~1.BOT\AppData\Local\Temp\surefire8539836821793811485\surefirebooter6734575521909210279.jar
> C:\Users\anghel.botos\AppData\Local\Temp\surefire8539836821793811485
> 2018-07-24T11-18-12_704-jvmRun1 surefire7184511894589995478tmp
> surefire_411836142070426630764tmp"
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:494)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:441)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:293)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> {noformat}
>
> The issue is the "free-floating" {{false}} that appears in the command line
> used to start a new JVM. I've traced down the issue to
> {{org.apache.maven.plugin.surefire.AbstractSurefireMojo#getEffectiveDebugForkedProcess}}
> where the following code can be found:
> {code:java}
> String debugForkedProcess = getDebugForkedProcess();
> if ( "true".equals( debugForkedProcess ) )
> {
> return "-Xdebug -Xnoagent -Djava.compiler=NONE"
> + "
> -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005";
> }
> return debugForkedProcess;
> {code}
> ...which is quite..."unexpected" to see that one can pass in a value of
> {{true}}, but not a value of {{false}}.
> Please fix with a proper parsing of true/false values for the
> {{maven.failsafe.debug}} property.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1541) SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[
https://issues.apache.org/jira/browse/SUREFIRE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681572#comment-16681572
]
Tibor Digana commented on SUREFIRE-1541:
[~bchupika]
Do not use this workaround.
I think you have totally different problem - SUREFIRE1588.
Use the latest version {{3.0.0-M1}}.
> SurefireBooterForkException: The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> --
>
> Key: SUREFIRE-1541
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1541
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Anghel Botos
>Priority: Major
>
> Attempting to run integration tests using maven-failsafe-plugin with
> {{-Dmaven.failsafe.debug=false}} yields the following stacktrace:
>
> {noformat}
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was cmd.exe /X /C ""C:\Program
> Files\Java\jdk1.8.0_121\jre\bin\java" false -jar
> C:\Users\ANGHEL~1.BOT\AppData\Local\Temp\surefire8539836821793811485\surefirebooter6734575521909210279.jar
> C:\Users\anghel.botos\AppData\Local\Temp\surefire8539836821793811485
> 2018-07-24T11-18-12_704-jvmRun1 surefire7184511894589995478tmp
> surefire_411836142070426630764tmp"
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:494)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:441)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:293)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> {noformat}
>
> The issue is the "free-floating" {{false}} that appears in the command line
> used to start a new JVM. I've traced down the issue to
> {{org.apache.maven.plugin.surefire.AbstractSurefireMojo#getEffectiveDebugForkedProcess}}
> where the following code can be found:
> {code:java}
> String debugForkedProcess = getDebugForkedProcess();
> if ( "true".equals( debugForkedProcess ) )
> {
> return "-Xdebug -Xnoagent -Djava.compiler=NONE"
> + "
> -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005";
> }
> return debugForkedProcess;
> {code}
> ...which is quite..."unexpected" to see that one can pass in a value of
> {{true}}, but not a value of {{false}}.
> Please fix with a proper parsing of true/false values for the
> {{maven.failsafe.debug}} property.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1541) SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[
https://issues.apache.org/jira/browse/SUREFIRE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681552#comment-16681552
]
Bohdan Chupika commented on SUREFIRE-1541:
--
Hi, [~patsevanton]
I had the same error. Solved this by adding
*false* property:
{code:java}
org.apache.maven.plugins
maven-surefire-plugin
${mavenSurefirePluginVersion}
org.apache.maven.surefire
surefire-junit47
2.20.1
false
false
**/*.class
com.my.package.IntegrationTest
{code}
> SurefireBooterForkException: The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> --
>
> Key: SUREFIRE-1541
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1541
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Anghel Botos
>Priority: Major
>
> Attempting to run integration tests using maven-failsafe-plugin with
> {{-Dmaven.failsafe.debug=false}} yields the following stacktrace:
>
> {noformat}
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was cmd.exe /X /C ""C:\Program
> Files\Java\jdk1.8.0_121\jre\bin\java" false -jar
> C:\Users\ANGHEL~1.BOT\AppData\Local\Temp\surefire8539836821793811485\surefirebooter6734575521909210279.jar
> C:\Users\anghel.botos\AppData\Local\Temp\surefire8539836821793811485
> 2018-07-24T11-18-12_704-jvmRun1 surefire7184511894589995478tmp
> surefire_411836142070426630764tmp"
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:494)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:441)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:293)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> {noformat}
>
> The issue is the "free-floating" {{false}} that appears in the command line
> used to start a new JVM. I've traced down the issue to
> {{org.apache.maven.plugin.surefire.AbstractSurefireMojo#getEffectiveDebugForkedProcess}}
> where the following code can be found:
> {code:java}
> String debugForkedProcess = getDebugForkedProcess();
> if ( "true".equals( debugForkedProcess ) )
> {
> return "-Xdebug -Xnoagent -Djava.compiler=NONE"
> + "
> -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005";
> }
> return debugForkedProcess;
> {code}
> ...which is quite..."unexpected" to see that one can pass in a value of
> {{true}}, but not a value of {{false}}.
> Please fix with a proper parsing of true/false values for the
> {{maven.failsafe.debug}} property.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MSHARED-767) Incremental should result in Stream
Robert Scholte created MSHARED-767: -- Summary: Incremental should result in Stream Key: MSHARED-767 URL: https://issues.apache.org/jira/browse/MSHARED-767 Project: Maven Shared Components Issue Type: Task Components: maven-shared-incremental Affects Versions: maven-shared-incremental-2.0.0 Reporter: Robert Scholte The current implementation is inefficient, it does a complete scan of the sourcefolder(s) whereas in general knowing the first change is already sufficient. The Java 8 StreamAPI can help here. The result should be a Stream of Resources(?) containing the filereference and a status (added, removed, changed). It must be possible to support localResources (where input and output can be compared) and remoteResources (where metadata must be stored to know if it has been changed). Filtering can be done by the consumer of the stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPATCH-20) support exclude pattern
[
https://issues.apache.org/jira/browse/MPATCH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681262#comment-16681262
]
ASF GitHub Bot commented on MPATCH-20:
--
matthiasbalke commented on a change in pull request #2: added support for
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232216491
##
File path: src/it/exclude-patches-from-patchDirectory/pom.xml
##
@@ -0,0 +1,65 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ 4.0.0
+
+ test
+ exclude-patches-from-patchDirectory
+ exclude-patches-from-patchDirectory
+ 1.0-SNAPSHOT
+
+
+UTF-8
+
+
+
+
+
+org.apache.maven.plugins
+maven-patch-plugin
+@pom.version@
Review comment:
Ok thanks for explaining, I changed it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support exclude pattern
> ---
>
> Key: MPATCH-20
> URL: https://issues.apache.org/jira/browse/MPATCH-20
> Project: Maven Patch Plugin
> Issue Type: New Feature
>Affects Versions: 1.2, 1.3
>Reporter: Matthias Balke
>Priority: Major
>
> The maven-patch-plugin should provide a feature to configure an exclude
> pattern which is applied, when searching for patch files within
> {{patchDirectory}}.
>
> I'll provide a PR on GitHub for this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MPATCH-20) support exclude pattern
[
https://issues.apache.org/jira/browse/MPATCH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681269#comment-16681269
]
ASF GitHub Bot commented on MPATCH-20:
--
matthiasbalke commented on issue #2: added support for excludePattern (fixes
MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#issuecomment-437327057
updated the code like discussed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support exclude pattern
> ---
>
> Key: MPATCH-20
> URL: https://issues.apache.org/jira/browse/MPATCH-20
> Project: Maven Patch Plugin
> Issue Type: New Feature
>Affects Versions: 1.2, 1.3
>Reporter: Matthias Balke
>Priority: Major
>
> The maven-patch-plugin should provide a feature to configure an exclude
> pattern which is applied, when searching for patch files within
> {{patchDirectory}}.
>
> I'll provide a PR on GitHub for this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] matthiasbalke commented on issue #2: added support for excludePattern (fixes MPATCH-20)
matthiasbalke commented on issue #2: added support for excludePattern (fixes MPATCH-20) URL: https://github.com/apache/maven-patch-plugin/pull/2#issuecomment-437327057 updated the code like discussed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MPATCH-20) support exclude pattern
[
https://issues.apache.org/jira/browse/MPATCH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681264#comment-16681264
]
ASF GitHub Bot commented on MPATCH-20:
--
matthiasbalke commented on a change in pull request #2: added support for
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232216532
##
File path: src/it/cant-exclude-patches-from-patches/pom.xml
##
@@ -0,0 +1,69 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ 4.0.0
+
+ test
+ cant-exclude-patches-from-patches
+ cant-exclude-patches-from-patches
+ 1.0-SNAPSHOT
+
+
+UTF-8
+
+
+
+
+
+org.apache.maven.plugins
+maven-patch-plugin
+@pom.version@
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support exclude pattern
> ---
>
> Key: MPATCH-20
> URL: https://issues.apache.org/jira/browse/MPATCH-20
> Project: Maven Patch Plugin
> Issue Type: New Feature
>Affects Versions: 1.2, 1.3
>Reporter: Matthias Balke
>Priority: Major
>
> The maven-patch-plugin should provide a feature to configure an exclude
> pattern which is applied, when searching for patch files within
> {{patchDirectory}}.
>
> I'll provide a PR on GitHub for this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MPATCH-20) support exclude pattern
[
https://issues.apache.org/jira/browse/MPATCH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681263#comment-16681263
]
ASF GitHub Bot commented on MPATCH-20:
--
matthiasbalke commented on a change in pull request #2: added support for
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232216512
##
File path: src/it/exclude-multiple-patterns-from-patchDirectory/pom.xml
##
@@ -0,0 +1,66 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ 4.0.0
+
+ test
+ exclude-multiple-patterns-from-patchDirectory
+ exclude-multiple-patterns-from-patchDirectory
+ 1.0-SNAPSHOT
+
+
+UTF-8
+
+
+
+
+
+org.apache.maven.plugins
+maven-patch-plugin
+@pom.version@
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support exclude pattern
> ---
>
> Key: MPATCH-20
> URL: https://issues.apache.org/jira/browse/MPATCH-20
> Project: Maven Patch Plugin
> Issue Type: New Feature
>Affects Versions: 1.2, 1.3
>Reporter: Matthias Balke
>Priority: Major
>
> The maven-patch-plugin should provide a feature to configure an exclude
> pattern which is applied, when searching for patch files within
> {{patchDirectory}}.
>
> I'll provide a PR on GitHub for this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20)
matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20) URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232216512 ## File path: src/it/exclude-multiple-patterns-from-patchDirectory/pom.xml ## @@ -0,0 +1,66 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + 4.0.0 + + test + exclude-multiple-patterns-from-patchDirectory + exclude-multiple-patterns-from-patchDirectory + 1.0-SNAPSHOT + + +UTF-8 + + + + + +org.apache.maven.plugins +maven-patch-plugin +@pom.version@ Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20)
matthiasbalke commented on a change in pull request #2: added support for
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232216460
##
File path: src/main/java/org/apache/maven/plugin/patch/ApplyMojo.java
##
@@ -237,6 +238,16 @@
@Parameter( defaultValue = "false" )
private boolean binary;
+/**
+ * List of ANT-style exclude patterns. These patterns are used to exclude
patch files found
+ * in the {@link ApplyMojo#patchDirectory}. These exclude patterns does
not apply to a static defined list of
+ * {@link ApplyMojo#patches}.
+ *
+ * @since 1.3
+ */
+@Parameter
+private List excludes;
Review comment:
Ok thanks for explaining, I changed it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MPATCH-20) support exclude pattern
[
https://issues.apache.org/jira/browse/MPATCH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681261#comment-16681261
]
ASF GitHub Bot commented on MPATCH-20:
--
matthiasbalke commented on a change in pull request #2: added support for
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232216460
##
File path: src/main/java/org/apache/maven/plugin/patch/ApplyMojo.java
##
@@ -237,6 +238,16 @@
@Parameter( defaultValue = "false" )
private boolean binary;
+/**
+ * List of ANT-style exclude patterns. These patterns are used to exclude
patch files found
+ * in the {@link ApplyMojo#patchDirectory}. These exclude patterns does
not apply to a static defined list of
+ * {@link ApplyMojo#patches}.
+ *
+ * @since 1.3
+ */
+@Parameter
+private List excludes;
Review comment:
Ok thanks for explaining, I changed it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support exclude pattern
> ---
>
> Key: MPATCH-20
> URL: https://issues.apache.org/jira/browse/MPATCH-20
> Project: Maven Patch Plugin
> Issue Type: New Feature
>Affects Versions: 1.2, 1.3
>Reporter: Matthias Balke
>Priority: Major
>
> The maven-patch-plugin should provide a feature to configure an exclude
> pattern which is applied, when searching for patch files within
> {{patchDirectory}}.
>
> I'll provide a PR on GitHub for this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20)
matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20) URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232216532 ## File path: src/it/cant-exclude-patches-from-patches/pom.xml ## @@ -0,0 +1,69 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + 4.0.0 + + test + cant-exclude-patches-from-patches + cant-exclude-patches-from-patches + 1.0-SNAPSHOT + + +UTF-8 + + + + + +org.apache.maven.plugins +maven-patch-plugin +@pom.version@ Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20)
matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20) URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232216491 ## File path: src/it/exclude-patches-from-patchDirectory/pom.xml ## @@ -0,0 +1,65 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + 4.0.0 + + test + exclude-patches-from-patchDirectory + exclude-patches-from-patchDirectory + 1.0-SNAPSHOT + + +UTF-8 + + + + + +org.apache.maven.plugins +maven-patch-plugin +@pom.version@ Review comment: Ok thanks for explaining, I changed it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (MNG-6510) [ERROR] 57971
[
https://issues.apache.org/jira/browse/MNG-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MNG-6510.
---
Resolution: Duplicate
Assignee: Robert Scholte
> [ERROR] 57971
> -
>
> Key: MNG-6510
> URL: https://issues.apache.org/jira/browse/MNG-6510
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
> Environment: Apache Maven 3.5.0
> (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T21:39:06+02:00)
> Maven home: /opt/maven
> Java version: 1.8.0_141, vendor: Oracle Corporation
> Java home: /usr/java/jdk8/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.10.0-862.14.4.el7.x86_64", arch: "amd64",
> family: "unix"
>Reporter: Andreas Schaller
>Assignee: Robert Scholte
>Priority: Minor
>
> Hi,
> I'm getting an highly informational error from maven:
> {quote}:~/svn/trunk/app-bss-control$ mvn compile
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building app-bss-control 12.1.0-SNAPSHOT
> [INFO]
>
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 1.472 s
> [INFO] Finished at: 2018-11-09T10:18:40+01:00
> [INFO] Final Memory: 18M/222M
> [INFO]
>
> [ERROR] 57971
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> {quote}
> in process-resources phase the build is still working.
> The Stracktrace given by -e:
> {quote}java.lang.ArrayIndexOutOfBoundsException: 57971
> at org.codehaus.plexus.util.xml.pull.MXParser.parsePI(MXParser.java:2502)
> at org.codehaus.plexus.util.xml.pull.MXParser.parseEpilog(MXParser.java:1604)
> at org.codehaus.plexus.util.xml.pull.MXParser.nextImpl(MXParser.java:1434)
> at org.codehaus.plexus.util.xml.pull.MXParser.next(MXParser.java:1131)
> at
> org.apache.maven.model.io.xpp3.MavenXpp3Reader.read(MavenXpp3Reader.java:3856)
> at
> org.apache.maven.model.io.xpp3.MavenXpp3Reader.read(MavenXpp3Reader.java:595)
> at
> org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:109)
> at
> org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:82)
> at
> org.apache.maven.model.building.DefaultModelProcessor.read(DefaultModelProcessor.java:81)
> at
> org.apache.maven.model.building.DefaultModelBuilder.readModel(DefaultModelBuilder.java:535)
> at
> org.apache.maven.model.building.DefaultModelBuilder.readParentExternally(DefaultModelBuilder.java:1097)
> at
> org.apache.maven.model.building.DefaultModelBuilder.readParent(DefaultModelBuilder.java:829)
> at
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:331)
> at
> org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:321)
> at
> org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.readArtifactDescriptor(DefaultArtifactDescriptorReader.java:199)
> at
> org.eclipse.aether.internal.impl.DefaultDependencyCollector.resolveCachedArtifactDescriptor(DefaultDependencyCollector.java:544)
> at
> org.eclipse.aether.internal.impl.DefaultDependencyCollector.getArtifactDescriptorResult(DefaultDependencyCollector.java:528)
> at
> org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency(DefaultDependencyCollector.java:418)
> at
> org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency(DefaultDependencyCollector.java:372)
> at
> org.eclipse.aether.internal.impl.DefaultDependencyCollector.process(DefaultDependencyCollector.java:360)
> at
> org.eclipse.aether.internal.impl.DefaultDependencyCollector.doRecurse(DefaultDependencyCollector.java:513)
> at
> org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency(DefaultDependencyCollector.java:467)
> at
> org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency(DefaultDependencyCollector.java:372)
> at
> org.eclipse.aether.internal.impl.DefaultDependencyCollector.process(DefaultDependencyCollector.java:360)
> at
> org.eclipse.aether.internal.impl.DefaultDependencyCollector.doRecurse(DefaultDependencyCollector.java:513)
> at
> org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency(DefaultDependencyCollector.java:467)
> at
> org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency(DefaultDependencyCollector.java:372)
> at
> org.eclipse.
[jira] [Updated] (MDEPLOY-247) Version 3.0.0-M1 breaks deploy using alt*DeploymentRepository with old syntax on Windows
[ https://issues.apache.org/jira/browse/MDEPLOY-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Schaible updated MDEPLOY-247: --- Summary: Version 3.0.0-M1 breaks deploy using alt*DeploymentRepository with old syntax on Windows (was: Version 3.0.0-M1 breaks deploy using alt*DeploymentRepository with old syntax on Windows using) > Version 3.0.0-M1 breaks deploy using alt*DeploymentRepository with old syntax > on Windows > > > Key: MDEPLOY-247 > URL: https://issues.apache.org/jira/browse/MDEPLOY-247 > Project: Maven Deploy Plugin > Issue Type: Bug > Components: deploy:deploy >Affects Versions: 3.0.0-M1 > Environment: Windows >Reporter: Joerg Schaible >Priority: Trivial > > With version 3.0.0-M1 the syntax for the alt*DeploymentRepository changed > from id::layout::URL to id::URL (were using a file protocol here). > Additionally the plugin now writes a lock file into the local repository > using the id of the repository as base name. Since the plugin seems to > interpret id::layout as the id for a legacy parameter value, it tries to > write with such a name. Works with Unix, but not with Windows. Here the build > fails. > Removing the layout part from the parameter will fix the problem. Therefore > this report is more a heads-up for others running into this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MDEPLOY-247) Version 3.0.0-M1 breaks deploy using alt*DeploymentRepository with old syntax on Windows using
Joerg Schaible created MDEPLOY-247: -- Summary: Version 3.0.0-M1 breaks deploy using alt*DeploymentRepository with old syntax on Windows using Key: MDEPLOY-247 URL: https://issues.apache.org/jira/browse/MDEPLOY-247 Project: Maven Deploy Plugin Issue Type: Bug Components: deploy:deploy Affects Versions: 3.0.0-M1 Environment: Windows Reporter: Joerg Schaible With version 3.0.0-M1 the syntax for the alt*DeploymentRepository changed from id::layout::URL to id::URL (were using a file protocol here). Additionally the plugin now writes a lock file into the local repository using the id of the repository as base name. Since the plugin seems to interpret id::layout as the id for a legacy parameter value, it tries to write with such a name. Works with Unix, but not with Windows. Here the build fails. Removing the layout part from the parameter will fix the problem. Therefore this report is more a heads-up for others running into this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MNG-6510) [ERROR] 57971
Andreas Schaller created MNG-6510:
-
Summary: [ERROR] 57971
Key: MNG-6510
URL: https://issues.apache.org/jira/browse/MNG-6510
Project: Maven
Issue Type: Bug
Affects Versions: 3.5.0
Environment: Apache Maven 3.5.0
(ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T21:39:06+02:00)
Maven home: /opt/maven
Java version: 1.8.0_141, vendor: Oracle Corporation
Java home: /usr/java/jdk8/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.10.0-862.14.4.el7.x86_64", arch: "amd64", family:
"unix"
Reporter: Andreas Schaller
Hi,
I'm getting an highly informational error from maven:
{quote}:~/svn/trunk/app-bss-control$ mvn compile
[INFO] Scanning for projects...
[INFO]
[INFO]
[INFO] Building app-bss-control 12.1.0-SNAPSHOT
[INFO]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 1.472 s
[INFO] Finished at: 2018-11-09T10:18:40+01:00
[INFO] Final Memory: 18M/222M
[INFO]
[ERROR] 57971
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
{quote}
in process-resources phase the build is still working.
The Stracktrace given by -e:
{quote}java.lang.ArrayIndexOutOfBoundsException: 57971
at org.codehaus.plexus.util.xml.pull.MXParser.parsePI(MXParser.java:2502)
at org.codehaus.plexus.util.xml.pull.MXParser.parseEpilog(MXParser.java:1604)
at org.codehaus.plexus.util.xml.pull.MXParser.nextImpl(MXParser.java:1434)
at org.codehaus.plexus.util.xml.pull.MXParser.next(MXParser.java:1131)
at
org.apache.maven.model.io.xpp3.MavenXpp3Reader.read(MavenXpp3Reader.java:3856)
at
org.apache.maven.model.io.xpp3.MavenXpp3Reader.read(MavenXpp3Reader.java:595)
at
org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:109)
at
org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:82)
at
org.apache.maven.model.building.DefaultModelProcessor.read(DefaultModelProcessor.java:81)
at
org.apache.maven.model.building.DefaultModelBuilder.readModel(DefaultModelBuilder.java:535)
at
org.apache.maven.model.building.DefaultModelBuilder.readParentExternally(DefaultModelBuilder.java:1097)
at
org.apache.maven.model.building.DefaultModelBuilder.readParent(DefaultModelBuilder.java:829)
at
org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:331)
at
org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:321)
at
org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.readArtifactDescriptor(DefaultArtifactDescriptorReader.java:199)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.resolveCachedArtifactDescriptor(DefaultDependencyCollector.java:544)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.getArtifactDescriptorResult(DefaultDependencyCollector.java:528)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency(DefaultDependencyCollector.java:418)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency(DefaultDependencyCollector.java:372)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.process(DefaultDependencyCollector.java:360)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.doRecurse(DefaultDependencyCollector.java:513)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency(DefaultDependencyCollector.java:467)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency(DefaultDependencyCollector.java:372)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.process(DefaultDependencyCollector.java:360)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.doRecurse(DefaultDependencyCollector.java:513)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency(DefaultDependencyCollector.java:467)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency(DefaultDependencyCollector.java:372)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.process(DefaultDependencyCollector.java:360)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.doRecurse(DefaultDependencyCollector.java:513)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency(DefaultDependencyCollector.java:467)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency(DefaultDependenc
[jira] [Commented] (MCOMPILER-205) maven-compiler-plugin: incremental compilation broken
[
https://issues.apache.org/jira/browse/MCOMPILER-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681096#comment-16681096
]
Robert Scholte commented on MCOMPILER-205:
--
This looks good enough to me.
> maven-compiler-plugin: incremental compilation broken
> -
>
> Key: MCOMPILER-205
> URL: https://issues.apache.org/jira/browse/MCOMPILER-205
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Lukas Fryc
>Priority: Major
> Attachments: hello.tgz, ignore-package-info.patch,
> no-class-in-java-file.zip, only-recompile-changed.patch
>
>
> When we do {{clean}} -> {{compile}} -> {{compile}}, all Java sources are
> re-compiled for second compilation steps:
> {code}
> [framework]$ mvn clean
> ...
> [framework]$ mvn compile
> ...
> [INFO] --- maven-compiler-plugin:3.1:compile (precompile-sources-for-cdk) @
> richfaces-framework ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 915 source files to
> /mnt/workspace/workspaces/richfaces/richfaces5/framework/target/classes
> ...
> [framework]$ mvn compile
> ...
> [INFO] --- maven-compiler-plugin:3.1:compile (precompile-sources-for-cdk) @
> richfaces-framework ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 915 source files to
> /mnt/workspace/workspaces/richfaces/richfaces5/framework/target/classes
> ...
> {code}
> The source code of the affected project:
> https://github.com/richfaces/richfaces5/tree/077dcfc0a46d03d7ba9a7ac3e701a4adfb834c71
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MPATCH-20) support exclude pattern
[
https://issues.apache.org/jira/browse/MPATCH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681061#comment-16681061
]
ASF GitHub Bot commented on MPATCH-20:
--
rfscholte commented on a change in pull request #2: added support for
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232173636
##
File path: src/it/exclude-patches-from-patchDirectory/pom.xml
##
@@ -0,0 +1,65 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ 4.0.0
+
+ test
+ exclude-patches-from-patchDirectory
+ exclude-patches-from-patchDirectory
+ 1.0-SNAPSHOT
+
+
+UTF-8
+
+
+
+
+
+org.apache.maven.plugins
+maven-patch-plugin
+@pom.version@
Review comment:
Both are still valid, but we prefer @project@ (even though a lot of tests
still use @pom@, just like bash scripts instead of groovy)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support exclude pattern
> ---
>
> Key: MPATCH-20
> URL: https://issues.apache.org/jira/browse/MPATCH-20
> Project: Maven Patch Plugin
> Issue Type: New Feature
>Affects Versions: 1.2, 1.3
>Reporter: Matthias Balke
>Priority: Major
>
> The maven-patch-plugin should provide a feature to configure an exclude
> pattern which is applied, when searching for patch files within
> {{patchDirectory}}.
>
> I'll provide a PR on GitHub for this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] rfscholte commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20)
rfscholte commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20) URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232173636 ## File path: src/it/exclude-patches-from-patchDirectory/pom.xml ## @@ -0,0 +1,65 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + 4.0.0 + + test + exclude-patches-from-patchDirectory + exclude-patches-from-patchDirectory + 1.0-SNAPSHOT + + +UTF-8 + + + + + +org.apache.maven.plugins +maven-patch-plugin +@pom.version@ Review comment: Both are still valid, but we prefer @project@ (even though a lot of tests still use @pom@, just like bash scripts instead of groovy) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MPATCH-20) support exclude pattern
[
https://issues.apache.org/jira/browse/MPATCH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681058#comment-16681058
]
ASF GitHub Bot commented on MPATCH-20:
--
rfscholte commented on a change in pull request #2: added support for
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232173205
##
File path: src/main/java/org/apache/maven/plugin/patch/ApplyMojo.java
##
@@ -237,6 +238,16 @@
@Parameter( defaultValue = "false" )
private boolean binary;
+/**
+ * List of ANT-style exclude patterns. These patterns are used to exclude
patch files found
+ * in the {@link ApplyMojo#patchDirectory}. These exclude patterns does
not apply to a static defined list of
+ * {@link ApplyMojo#patches}.
+ *
+ * @since 1.3
+ */
+@Parameter
+private List excludes;
Review comment:
AFAIK this plugin was written in Java 1.4, not a lot of maintenance so
nobody cared about generics. However we should, especially when adding new code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support exclude pattern
> ---
>
> Key: MPATCH-20
> URL: https://issues.apache.org/jira/browse/MPATCH-20
> Project: Maven Patch Plugin
> Issue Type: New Feature
>Affects Versions: 1.2, 1.3
>Reporter: Matthias Balke
>Priority: Major
>
> The maven-patch-plugin should provide a feature to configure an exclude
> pattern which is applied, when searching for patch files within
> {{patchDirectory}}.
>
> I'll provide a PR on GitHub for this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] rfscholte commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20)
rfscholte commented on a change in pull request #2: added support for
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232173205
##
File path: src/main/java/org/apache/maven/plugin/patch/ApplyMojo.java
##
@@ -237,6 +238,16 @@
@Parameter( defaultValue = "false" )
private boolean binary;
+/**
+ * List of ANT-style exclude patterns. These patterns are used to exclude
patch files found
+ * in the {@link ApplyMojo#patchDirectory}. These exclude patterns does
not apply to a static defined list of
+ * {@link ApplyMojo#patches}.
+ *
+ * @since 1.3
+ */
+@Parameter
+private List excludes;
Review comment:
AFAIK this plugin was written in Java 1.4, not a lot of maintenance so
nobody cared about generics. However we should, especially when adding new code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MSHARED-766) Build on JDK 11
[ https://issues.apache.org/jira/browse/MSHARED-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681035#comment-16681035 ] Hudson commented on MSHARED-766: Build succeeded in Jenkins: Maven TLP » maven-artifact-transfer » master #48 See https://builds.apache.org/job/maven-box/job/maven-artifact-transfer/job/master/48/ > Build on JDK 11 > --- > > Key: MSHARED-766 > URL: https://issues.apache.org/jira/browse/MSHARED-766 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.11.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-artifact-transfer-0.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
